[PATCH v2 00/13] qcom: dts: thermal cleanups

[PATCH v2 00/13] qcom: dts: thermal cleanups

[Amit Kucheria]

Changes since v1:
- Devices that are not associated with cooling-maps use the 'hot' type
- Remove critical trip from such devices too and restrict that type of CPUs
- For 8916, add the sensor on the modem

Description:
- Expose all temperature sensors on msm8916, msm996, msm8998, sdm845
- split up the register address map for msm8998
- standardize names of the various thermal-zones across boards to make it
  easy for test scripts to parse

Amit Kucheria (13):
  arm64: dts: msm8998: thermal: split address space into two
  arm64: dts: msm8998: efficiency is not valid property
  arm64: dts: msm8916: thermal: Add sensor for modem
  arm64: dts: msm8996: thermal: Add temperature sensors near major
    peripherals
  arm64: dts: msm8998: thermal: Fix the cpu sensor numbers
  arm64: dts: msm8998: thermal: Fix the gpu sensor number
  arm64: dts: msm8998: thermal: GPU has two sensors, add the second
  arm64: dts: msm8998: thermal: Add temperature sensors near major
    peripherals
  arm64: dts: sdm845: thermal: Add temperature sensors near major
    peripherals
  arm64: dts: msm8998: thermal: Make trip names consistent
  arm64: dts: msm8916: thermal: Make trip names consistent
  arm64: dts: msm8996: thermal: Make trip names consistent
  arm64: dts: msm8916: thermal: Convert camera trip type to hot

 arch/arm64/boot/dts/qcom/msm8916.dtsi |  41 +++--
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 174 ++++++++++++++++--
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 242 +++++++++++++++++++++-----
 arch/arm64/boot/dts/qcom/sdm845.dtsi  | 205 ++++++++++++++++++++++
 4 files changed, 589 insertions(+), 73 deletions(-)

-- 
2.17.1

[PATCH v2 01/13] arm64: dts: msm8998: thermal: split address space into two

[Amit Kucheria]

We've earlier added support to split the register address space into TM
and SROT regions. Split up the regmap address space into two for msm8998
that has a similar register layout.

The order is important (TM before SROT) because we make an assumption
that SROT is always the second address space in order to support legacy
DTs.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 3fd0769fe648..ac25e9142cbd 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -590,17 +590,19 @@
 			cell-index = <0>;
 		};
 
-		tsens0: thermal@10aa000 {
+		tsens0: thermal@10ab000 {
 			compatible = "qcom,msm8998-tsens", "qcom,tsens-v2";
-			reg = <0x10aa000 0x2000>;
+			reg = <0x10ab000 0x1000>, /* TM */
+			      <0x10aa000 0x1000>; /* SROT */
 
 			#qcom,sensors = <12>;
 			#thermal-sensor-cells = <1>;
 		};
 
-		tsens1: thermal@10ad000 {
+		tsens1: thermal@10ae000 {
 			compatible = "qcom,msm8998-tsens", "qcom,tsens-v2";
-			reg = <0x10ad000 0x2000>;
+			reg = <0x10ae000 0x1000>, /* TM */
+			      <0x10ad000 0x1000>; /* SROT */
 
 			#qcom,sensors = <8>;
 			#thermal-sensor-cells = <1>;
-- 
2.17.1

[PATCH v2 02/13] arm64: dts: msm8998: efficiency is not valid property

[Amit Kucheria]

efficiency comes from downstream. The valid upstream property is
capacity-dmips-mhz but until we can come up with those numbers, remove
this property.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index ac25e9142cbd..0b6de0c29ee8 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -78,7 +78,6 @@
 			compatible = "arm,armv8";
 			reg = <0x0 0x0>;
 			enable-method = "psci";
-			efficiency = <1024>;
 			next-level-cache = <&L2_0>;
 			L2_0: l2-cache {
 				compatible = "arm,arch-cache";
@@ -97,7 +96,6 @@
 			compatible = "arm,armv8";
 			reg = <0x0 0x1>;
 			enable-method = "psci";
-			efficiency = <1024>;
 			next-level-cache = <&L2_0>;
 			L1_I_1: l1-icache {
 				compatible = "arm,arch-cache";
@@ -112,7 +110,6 @@
 			compatible = "arm,armv8";
 			reg = <0x0 0x2>;
 			enable-method = "psci";
-			efficiency = <1024>;
 			next-level-cache = <&L2_0>;
 			L1_I_2: l1-icache {
 				compatible = "arm,arch-cache";
@@ -127,7 +124,6 @@
 			compatible = "arm,armv8";
 			reg = <0x0 0x3>;
 			enable-method = "psci";
-			efficiency = <1024>;
 			next-level-cache = <&L2_0>;
 			L1_I_3: l1-icache {
 				compatible = "arm,arch-cache";
@@ -142,7 +138,6 @@
 			compatible = "arm,armv8";
 			reg = <0x0 0x100>;
 			enable-method = "psci";
-			efficiency = <1536>;
 			next-level-cache = <&L2_1>;
 			L2_1: l2-cache {
 				compatible = "arm,arch-cache";
@@ -161,7 +156,6 @@
 			compatible = "arm,armv8";
 			reg = <0x0 0x101>;
 			enable-method = "psci";
-			efficiency = <1536>;
 			next-level-cache = <&L2_1>;
 			L1_I_101: l1-icache {
 				compatible = "arm,arch-cache";
@@ -176,7 +170,6 @@
 			compatible = "arm,armv8";
 			reg = <0x0 0x102>;
 			enable-method = "psci";
-			efficiency = <1536>;
 			next-level-cache = <&L2_1>;
 			L1_I_102: l1-icache {
 				compatible = "arm,arch-cache";
@@ -191,7 +184,6 @@
 			compatible = "arm,armv8";
 			reg = <0x0 0x103>;
 			enable-method = "psci";
-			efficiency = <1536>;
 			next-level-cache = <&L2_1>;
 			L1_I_103: l1-icache {
 				compatible = "arm,arch-cache";
-- 
2.17.1

[PATCH v2 03/13] arm64: dts: msm8916: thermal: Add sensor for modem

[Amit Kucheria]

On platforms that have a modem, sensor 0 monitors the modem.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 0803ca8c02da..c8aa9a0986d2 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -278,7 +278,21 @@
 					type = "critical";
 				};
 			};
+		};
+
+		modem-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens 0>;
 
+			trips {
+				modem_alert0: trip-point@0 {
+					temperature = <85000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
 		};
 
 	};
-- 
2.17.1

[PATCH v2 04/13] arm64: dts: msm8996: thermal: Add temperature sensors near major peripherals

[Amit Kucheria]

msm8996 has a total of 21 temperature sensors. Populate DT with
information about them.

There are 2 sensors on each of the cpus - one on the top, the other
below (we only expose one on the top in DT for now). For the GPU, we
expose both, the one on the top and the one below.

Depending on the version of the silicon, sensor 2 is either placed near
the L3 cache or the venus video decoder. It would've been nice to be
able to be version-specific but we don't have DTs that differentiate the
two versions of silicon yet.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 150 ++++++++++++++++++++++++++
 1 file changed, 150 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index c761269caf80..e2408ee91184 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -237,6 +237,156 @@
 				};
 			};
 		};
+
+		gpu-thermal-top {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 6>;
+
+			trips {
+				gpu1_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		gpu-thermal-bottom {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 7>;
+
+			trips {
+				gpu2_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		m4m-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 1>;
+
+			trips {
+				m4m_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		l3-or-venus-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 2>;
+
+			trips {
+				l3_or_venus_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		cluster0-l2-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 7>;
+
+			trips {
+				cluster0_l2_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		cluster1-l2-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 12>;
+
+			trips {
+				cluster1_l2_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		camera-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 1>;
+
+			trips {
+				camera_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		q6-dsp-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 2>;
+
+			trips {
+				q6_dsp_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		mem-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 3>;
+
+			trips {
+				mem_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		modemtx-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 4>;
+
+			trips {
+				modemtx_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
 	};
 
 	timer {
-- 
2.17.1

[PATCH v2 05/13] arm64: dts: msm8998: thermal: Fix the cpu sensor numbers

[Amit Kucheria]

The silver cluster (typically cpu0-3) are monitored by sensor IDs 1-3 on
tsens controller 0. The gold cluster (typically cpu4-7) are monitored by
sensor IDs 7-10 on tsens controller 0.

Fixes: 4449b6f248d9a1 ("arm64: dts: qcom: msm8998: Add tsens and thermal-zones")
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 0b6de0c29ee8..108a5aa146a2 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -342,7 +342,7 @@
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
-			thermal-sensors = <&tsens0 6>;
+			thermal-sensors = <&tsens0 1>;
 
 			trips {
 				cpu_alert0: trip0 {
@@ -363,7 +363,7 @@
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
-			thermal-sensors = <&tsens0 7>;
+			thermal-sensors = <&tsens0 2>;
 
 			trips {
 				cpu_alert1: trip0 {
@@ -384,7 +384,7 @@
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
-			thermal-sensors = <&tsens0 8>;
+			thermal-sensors = <&tsens0 3>;
 
 			trips {
 				cpu_alert2: trip0 {
@@ -405,7 +405,7 @@
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
-			thermal-sensors = <&tsens0 9>;
+			thermal-sensors = <&tsens0 4>;
 
 			trips {
 				cpu_alert3: trip0 {
@@ -426,7 +426,7 @@
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
-			thermal-sensors = <&tsens0 10>;
+			thermal-sensors = <&tsens0 7>;
 
 			trips {
 				cpu_alert4: trip0 {
@@ -447,7 +447,7 @@
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
-			thermal-sensors = <&tsens0 11>;
+			thermal-sensors = <&tsens0 8>;
 
 			trips {
 				cpu_alert5: trip0 {
@@ -468,7 +468,7 @@
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
-			thermal-sensors = <&tsens1 0>;
+			thermal-sensors = <&tsens0 9>;
 
 			trips {
 				cpu_alert6: trip0 {
@@ -489,7 +489,7 @@
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
-			thermal-sensors = <&tsens1 1>;
+			thermal-sensors = <&tsens0 10>;
 
 			trips {
 				cpu_alert7: trip0 {
-- 
2.17.1

[PATCH v2 06/13] arm64: dts: msm8998: thermal: Fix the gpu sensor number

[Amit Kucheria]

The GPU sensor is sensor ID 13 on controller 0

Fixes: 4449b6f248d9a1 ("arm64: dts: qcom: msm8998: Add tsens and thermal-zones")
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 108a5aa146a2..56ca9ecdb0bf 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -510,7 +510,7 @@
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
-			thermal-sensors = <&tsens1 3>;
+			thermal-sensors = <&tsens0 13>;
 		};
 	};
 
-- 
2.17.1

[PATCH v2 07/13] arm64: dts: msm8998: thermal: GPU has two sensors, add the second

[Amit Kucheria]

The first sensor is on top and the second sensor below the GPU

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 56ca9ecdb0bf..b368da235663 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -506,11 +506,34 @@
 			};
 		};
 
-		gpu-thermal {
+		gpu-thermal-bottom {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 12>;
+
+			trips {
+				gpu1_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		gpu-thermal-top {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens0 13>;
+
+			trips {
+				gpu2_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
 		};
 	};
 
-- 
2.17.1

[PATCH v2 08/13] arm64: dts: msm8998: thermal: Add temperature sensors near major peripherals

[Amit Kucheria]

msm8998 has a total of 22 temperature sensors. Populate DT with
information about them.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 135 ++++++++++++++++++++++++++
 1 file changed, 135 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index b368da235663..26e476078cb6 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -535,6 +535,141 @@
 				};
 			};
 		};
+
+		cluster0-mhm-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 5>;
+
+			trips {
+				cluster0_mhm_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		cluster1-mhm-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 6>;
+
+			trips {
+				cluster1_mhm_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		cluster1-l2-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 11>;
+
+			trips {
+				cluster1_l2_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		modem-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 1>;
+
+			trips {
+				modem_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		mem-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 2>;
+
+			trips {
+				mem_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		wlan-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 3>;
+
+			trips {
+				wlan_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		q6-dsp-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 4>;
+
+			trips {
+				q6_dsp_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		camera-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 5>;
+
+			trips {
+				camera_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		multimedia-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 6>;
+
+			trips {
+				multimedia_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
 	};
 
 	timer {
-- 
2.17.1

[PATCH v2 09/13] arm64: dts: sdm845: thermal: Add temperature sensors near major peripherals

[Amit Kucheria]

sdm845 has a total of 21 temperature sensors. Populate DT with
information about them.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 205 +++++++++++++++++++++++++++
 1 file changed, 205 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 5308f1671824..7c0643ccef18 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2611,5 +2611,210 @@
 				};
 			};
 		};
+
+		aoss0-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 0>;
+
+			trips {
+				aoss0_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		cluster0-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 5>;
+
+			trips {
+				cluster0_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+				cluster0_crit: cluster0_crit {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+		cluster1-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 6>;
+
+			trips {
+				cluster1_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+				cluster1_crit: cluster1_crit {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
+			};
+		};
+
+		gpu-thermal-top {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 11>;
+
+			trips {
+				gpu1_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		gpu-thermal-bottom {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens0 12>;
+
+			trips {
+				gpu2_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		aoss1-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 0>;
+
+			trips {
+				aoss1_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		q6-modem-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 1>;
+
+			trips {
+				q6_modem_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		mem-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 2>;
+
+			trips {
+				mem_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		wlan-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 3>;
+
+			trips {
+				wlan_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		q6-hvx-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 4>;
+
+			trips {
+				q6_hvx_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		camera-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 5>;
+
+			trips {
+				camera_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		video-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 6>;
+
+			trips {
+				video_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
+
+		modem-thermal {
+			polling-delay-passive = <250>;
+			polling-delay = <1000>;
+
+			thermal-sensors = <&tsens1 7>;
+
+			trips {
+				modem_alert0: trip-point@0 {
+					temperature = <90000>;
+					hysteresis = <2000>;
+					type = "hot";
+				};
+			};
+		};
 	};
 };
-- 
2.17.1

[PATCH v2 10/13] arm64: dts: msm8998: thermal: Make trip names consistent

[Amit Kucheria]

Maintain naming consistency with what was landed for sdm845. Simplifies
parsing for test tools.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 48 +++++++++++++--------------
 1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 26e476078cb6..998017d4d847 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -338,20 +338,20 @@
 	};
 
 	thermal-zones {
-		cpu-thermal0 {
+		cpu0-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens0 1>;
 
 			trips {
-				cpu_alert0: trip0 {
+				cpu0_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
 
-				cpu_crit0: trip1 {
+				cpu0_crit: cpu_crit {
 					temperature = <110000>;
 					hysteresis = <2000>;
 					type = "critical";
@@ -359,20 +359,20 @@
 			};
 		};
 
-		cpu-thermal1 {
+		cpu1-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens0 2>;
 
 			trips {
-				cpu_alert1: trip0 {
+				cpu1_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
 
-				cpu_crit1: trip1 {
+				cpu1_crit: cpu_crit {
 					temperature = <110000>;
 					hysteresis = <2000>;
 					type = "critical";
@@ -380,20 +380,20 @@
 			};
 		};
 
-		cpu-thermal2 {
+		cpu2-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens0 3>;
 
 			trips {
-				cpu_alert2: trip0 {
+				cpu2_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
 
-				cpu_crit2: trip1 {
+				cpu2_crit: cpu_crit {
 					temperature = <110000>;
 					hysteresis = <2000>;
 					type = "critical";
@@ -401,20 +401,20 @@
 			};
 		};
 
-		cpu-thermal3 {
+		cpu3-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens0 4>;
 
 			trips {
-				cpu_alert3: trip0 {
+				cpu3_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
 
-				cpu_crit3: trip1 {
+				cpu3_crit: cpu_crit {
 					temperature = <110000>;
 					hysteresis = <2000>;
 					type = "critical";
@@ -422,20 +422,20 @@
 			};
 		};
 
-		cpu-thermal4 {
+		cpu4-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens0 7>;
 
 			trips {
-				cpu_alert4: trip0 {
+				cpu4_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
 
-				cpu_crit4: trip1 {
+				cpu4_crit: cpu_crit {
 					temperature = <110000>;
 					hysteresis = <2000>;
 					type = "critical";
@@ -443,20 +443,20 @@
 			};
 		};
 
-		cpu-thermal5 {
+		cpu5-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens0 8>;
 
 			trips {
-				cpu_alert5: trip0 {
+				cpu5_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
 
-				cpu_crit5: trip1 {
+				cpu5_crit: cpu_crit {
 					temperature = <110000>;
 					hysteresis = <2000>;
 					type = "critical";
@@ -464,20 +464,20 @@
 			};
 		};
 
-		cpu-thermal6 {
+		cpu6-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens0 9>;
 
 			trips {
-				cpu_alert6: trip0 {
+				cpu6_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
 
-				cpu_crit6: trip1 {
+				cpu6_crit: cpu_crit {
 					temperature = <110000>;
 					hysteresis = <2000>;
 					type = "critical";
@@ -485,20 +485,20 @@
 			};
 		};
 
-		cpu-thermal7 {
+		cpu7-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens0 10>;
 
 			trips {
-				cpu_alert7: trip0 {
+				cpu7_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
 
-				cpu_crit7: trip1 {
+				cpu7_crit: cpu_crit {
 					temperature = <110000>;
 					hysteresis = <2000>;
 					type = "critical";
-- 
2.17.1

[PATCH v2 11/13] arm64: dts: msm8916: thermal: Make trip names consistent

[Amit Kucheria]

Maintain naming consistency with what was landed for sdm845. Simplifies
parsing for test tools.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index c8aa9a0986d2..ea734b98ec96 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -180,19 +180,19 @@
 	};
 
 	thermal-zones {
-		cpu-thermal0 {
+		cpu0_1-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens 4>;
 
 			trips {
-				cpu_alert0: trip0 {
+				cpu0_1_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
-				cpu_crit0: trip1 {
+				cpu0_1_crit: cpu_crit {
 					temperature = <110000>;
 					hysteresis = <2000>;
 					type = "critical";
@@ -201,7 +201,7 @@
 
 			cooling-maps {
 				map0 {
-					trip = <&cpu_alert0>;
+					trip = <&cpu0_1_alert0>;
 					cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
 							 <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
 							 <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
@@ -210,19 +210,19 @@
 			};
 		};
 
-		cpu-thermal1 {
+		cpu2_3-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens 3>;
 
 			trips {
-				cpu_alert1: trip0 {
+				cpu2_3_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
-				cpu_crit1: trip1 {
+				cpu2_3_crit: cpu_crit {
 					temperature = <110000>;
 					hysteresis = <2000>;
 					type = "critical";
@@ -231,7 +231,7 @@
 
 			cooling-maps {
 				map0 {
-					trip = <&cpu_alert1>;
+					trip = <&cpu2_3_alert0>;
 					cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
 							 <&CPU1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
 							 <&CPU2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
@@ -247,12 +247,12 @@
 			thermal-sensors = <&tsens 2>;
 
 			trips {
-				gpu_alert: trip0 {
+				gpu_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
-				gpu_crit: trip1 {
+				gpu_crit: gpu_crit {
 					temperature = <95000>;
 					hysteresis = <2000>;
 					type = "critical";
@@ -267,12 +267,12 @@
 			thermal-sensors = <&tsens 1>;
 
 			trips {
-				cam_alert: trip0 {
+				cam_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
-				cam_crit: trip1 {
+				cam_crit: cam_crit {
 					temperature = <95000>;
 					hysteresis = <2000>;
 					type = "critical";
-- 
2.17.1

[PATCH v2 12/13] arm64: dts: msm8996: thermal: Make trip names consistent

[Amit Kucheria]

Maintain naming consistency with what was landed for sdm845. Simplifies
parsing for test tools.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index e2408ee91184..edcddc74a4fc 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -154,20 +154,20 @@
 	};
 
 	thermal-zones {
-		cpu-thermal0 {
+		cpu0-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens0 3>;
 
 			trips {
-				cpu_alert0: trip0 {
+				cpu0_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
 
-				cpu_crit0: trip1 {
+				cpu0_crit: cpu_crit {
 					temperature = <110000>;
 					hysteresis = <2000>;
 					type = "critical";
@@ -175,20 +175,20 @@
 			};
 		};
 
-		cpu-thermal1 {
+		cpu1-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens0 5>;
 
 			trips {
-				cpu_alert1: trip0 {
+				cpu1_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
 
-				cpu_crit1: trip1 {
+				cpu1_crit: cpu_crit {
 					temperature = <110000>;
 					hysteresis = <2000>;
 					type = "critical";
@@ -196,20 +196,20 @@
 			};
 		};
 
-		cpu-thermal2 {
+		cpu2-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens0 8>;
 
 			trips {
-				cpu_alert2: trip0 {
+				cpu2_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
 
-				cpu_crit2: trip1 {
+				cpu2_crit: cpu_crit {
 					temperature = <110000>;
 					hysteresis = <2000>;
 					type = "critical";
@@ -217,20 +217,20 @@
 			};
 		};
 
-		cpu-thermal3 {
+		cpu3-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens0 10>;
 
 			trips {
-				cpu_alert3: trip0 {
+				cpu3_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
 				};
 
-				cpu_crit3: trip1 {
+				cpu3_crit: cpu_crit {
 					temperature = <110000>;
 					hysteresis = <2000>;
 					type = "critical";
-- 
2.17.1

[PATCH v2 13/13] arm64: dts: msm8916: thermal: Convert camera trip type to hot

[Amit Kucheria]

We don't have any cooling-devices related to the camera. Use the "hot"
trip type so allow the temperature to be exported to userspace and
remove the "critical" trip.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index ea734b98ec96..e4b1010f70b6 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -270,12 +270,7 @@
 				cam_alert0: trip-point@0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
-					type = "passive";
-				};
-				cam_crit: cam_crit {
-					temperature = <95000>;
-					hysteresis = <2000>;
-					type = "critical";
+					type = "hot";
 				};
 			};
 		};
-- 
2.17.1

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

[Marc Gonzalez]

On 29/03/2019 11:12, Amit Kucheria wrote:

> Changes since v1:
> - Devices that are not associated with cooling-maps use the 'hot' type
> - Remove critical trip from such devices too and restrict that type of CPUs
> - For 8916, add the sensor on the modem
> 
> Description:
> - Expose all temperature sensors on msm8916, msm996, msm8998, sdm845
> - split up the register address map for msm8998
> - standardize names of the various thermal-zones across boards to make it
>   easy for test scripts to parse

This is what I see on msm8998 with your patch series applied on top of
yesterday's next:

# dmesg | grep of_parse_thermal_zones
of_parse_thermal_zones: build cpu0-thermal zone 0
of_parse_thermal_zones: build cpu1-thermal zone 0
of_parse_thermal_zones: build cpu2-thermal zone 0
of_parse_thermal_zones: build cpu3-thermal zone 0
of_parse_thermal_zones: build cpu4-thermal zone 0
of_parse_thermal_zones: build cpu5-thermal zone 0
of_parse_thermal_zones: build cpu6-thermal zone 0
of_parse_thermal_zones: build cpu7-thermal zone 0
of_parse_thermal_zones: build gpu-thermal-bottom zone 0
of_parse_thermal_zones: build gpu-thermal-top zone 0
of_parse_thermal_zones: build cluster0-mhm-thermal zone -22
of_parse_thermal_zones: build cluster1-mhm-thermal zone -22
of_parse_thermal_zones: build cluster1-l2-thermal zone 0
of_parse_thermal_zones: build modem-thermal zone 0
of_parse_thermal_zones: build mem-thermal zone 0
of_parse_thermal_zones: build wlan-thermal zone 0
of_parse_thermal_zones: build q6-dsp-thermal zone 0
of_parse_thermal_zones: build camera-thermal zone 0
of_parse_thermal_zones: build multimedia-thermal zone 0
of_parse_thermal_zones: build pm8998 zone 0
of_parse_thermal_zones: build battery-thermal zone 0
of_parse_thermal_zones: build skin-thermal zone 0

NB: -EINVAL for cluster0-mhm-thermal and cluster1-mhm-thermal


# cat /sys/devices/virtual/thermal/thermal_zone*/temp 
35800
35200
34500
34800
34500
34100
34100
33500
33800
cat: /sys/devices/virtual/thermal/thermal_zone17/temp: Invalid argument
36100
cat: /sys/devices/virtual/thermal/thermal_zone19/temp: Invalid argument
35500
36100
35800
35200
35500
36100
cat: /sys/devices/virtual/thermal/thermal_zone8/temp: Invalid argument
cat: /sys/devices/virtual/thermal/thermal_zone9/temp: Invalid argument


Are the failures expected?
(cluster*-mhm-thermal and thermal_zone*/temp)

Regards.

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

[Amit Kucheria]

On Tue, Apr 2, 2019 at 8:58 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
>
> On 29/03/2019 11:12, Amit Kucheria wrote:
>
> > Changes since v1:
> > - Devices that are not associated with cooling-maps use the 'hot' type
> > - Remove critical trip from such devices too and restrict that type of CPUs
> > - For 8916, add the sensor on the modem
> >
> > Description:
> > - Expose all temperature sensors on msm8916, msm996, msm8998, sdm845
> > - split up the register address map for msm8998
> > - standardize names of the various thermal-zones across boards to make it
> >   easy for test scripts to parse
>
> This is what I see on msm8998 with your patch series applied on top of
> yesterday's next:
>
> # dmesg | grep of_parse_thermal_zones
> of_parse_thermal_zones: build cpu0-thermal zone 0
> of_parse_thermal_zones: build cpu1-thermal zone 0
> of_parse_thermal_zones: build cpu2-thermal zone 0
> of_parse_thermal_zones: build cpu3-thermal zone 0
> of_parse_thermal_zones: build cpu4-thermal zone 0
> of_parse_thermal_zones: build cpu5-thermal zone 0
> of_parse_thermal_zones: build cpu6-thermal zone 0
> of_parse_thermal_zones: build cpu7-thermal zone 0
> of_parse_thermal_zones: build gpu-thermal-bottom zone 0
> of_parse_thermal_zones: build gpu-thermal-top zone 0
> of_parse_thermal_zones: build cluster0-mhm-thermal zone -22
> of_parse_thermal_zones: build cluster1-mhm-thermal zone -22
> of_parse_thermal_zones: build cluster1-l2-thermal zone 0
> of_parse_thermal_zones: build modem-thermal zone 0
> of_parse_thermal_zones: build mem-thermal zone 0
> of_parse_thermal_zones: build wlan-thermal zone 0
> of_parse_thermal_zones: build q6-dsp-thermal zone 0
> of_parse_thermal_zones: build camera-thermal zone 0
> of_parse_thermal_zones: build multimedia-thermal zone 0
> of_parse_thermal_zones: build pm8998 zone 0
> of_parse_thermal_zones: build battery-thermal zone 0
> of_parse_thermal_zones: build skin-thermal zone 0
>
> NB: -EINVAL for cluster0-mhm-thermal and cluster1-mhm-thermal
>
>
> # cat /sys/devices/virtual/thermal/thermal_zone*/temp
> 35800
> 35200
> 34500
> 34800
> 34500
> 34100
> 34100
> 33500
> 33800
> cat: /sys/devices/virtual/thermal/thermal_zone17/temp: Invalid argument
> 36100
> cat: /sys/devices/virtual/thermal/thermal_zone19/temp: Invalid argument
> 35500
> 36100
> 35800
> 35200
> 35500
> 36100
> cat: /sys/devices/virtual/thermal/thermal_zone8/temp: Invalid argument
> cat: /sys/devices/virtual/thermal/thermal_zone9/temp: Invalid argument
>
>
> Are the failures expected?
> (cluster*-mhm-thermal and thermal_zone*/temp)

No they are not. Unfortunately, I didn't have HW to test, so
appreciate the help with testing. I'll check the 8, 9, 17 and 19 again
before resubmitting.

Regards,
Amit

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

[Marc Gonzalez]

On 02/04/2019 20:46, Amit Kucheria wrote:

> On Tue, Apr 2, 2019 at 8:58 PM Marc Gonzalez wrote:
>>
>> On 29/03/2019 11:12, Amit Kucheria wrote:
>>
>>> Changes since v1:
>>> - Devices that are not associated with cooling-maps use the 'hot' type
>>> - Remove critical trip from such devices too and restrict that type of CPUs
>>> - For 8916, add the sensor on the modem
>>>
>>> Description:
>>> - Expose all temperature sensors on msm8916, msm996, msm8998, sdm845
>>> - split up the register address map for msm8998
>>> - standardize names of the various thermal-zones across boards to make it
>>>   easy for test scripts to parse
>>
>> This is what I see on msm8998 with your patch series applied on top of
>> yesterday's next:
>>
>> # dmesg | grep of_parse_thermal_zones
>> of_parse_thermal_zones: build cpu0-thermal zone 0
>> of_parse_thermal_zones: build cpu1-thermal zone 0
>> of_parse_thermal_zones: build cpu2-thermal zone 0
>> of_parse_thermal_zones: build cpu3-thermal zone 0
>> of_parse_thermal_zones: build cpu4-thermal zone 0
>> of_parse_thermal_zones: build cpu5-thermal zone 0
>> of_parse_thermal_zones: build cpu6-thermal zone 0
>> of_parse_thermal_zones: build cpu7-thermal zone 0
>> of_parse_thermal_zones: build gpu-thermal-bottom zone 0
>> of_parse_thermal_zones: build gpu-thermal-top zone 0
>> of_parse_thermal_zones: build cluster0-mhm-thermal zone -22
>> of_parse_thermal_zones: build cluster1-mhm-thermal zone -22
>> of_parse_thermal_zones: build cluster1-l2-thermal zone 0
>> of_parse_thermal_zones: build modem-thermal zone 0
>> of_parse_thermal_zones: build mem-thermal zone 0
>> of_parse_thermal_zones: build wlan-thermal zone 0
>> of_parse_thermal_zones: build q6-dsp-thermal zone 0
>> of_parse_thermal_zones: build camera-thermal zone 0
>> of_parse_thermal_zones: build multimedia-thermal zone 0
>> of_parse_thermal_zones: build pm8998 zone 0
>> of_parse_thermal_zones: build battery-thermal zone 0
>> of_parse_thermal_zones: build skin-thermal zone 0
>>
>> NB: -EINVAL for cluster0-mhm-thermal and cluster1-mhm-thermal
>>
>>
>> # cat /sys/devices/virtual/thermal/thermal_zone*/temp
>> 35800
>> 35200
>> 34500
>> 34800
>> 34500
>> 34100
>> 34100
>> 33500
>> 33800
>> cat: /sys/devices/virtual/thermal/thermal_zone17/temp: Invalid argument
>> 36100
>> cat: /sys/devices/virtual/thermal/thermal_zone19/temp: Invalid argument
>> 35500
>> 36100
>> 35800
>> 35200
>> 35500
>> 36100
>> cat: /sys/devices/virtual/thermal/thermal_zone8/temp: Invalid argument
>> cat: /sys/devices/virtual/thermal/thermal_zone9/temp: Invalid argument
>>
>>
>> Are the failures expected?
>> (cluster*-mhm-thermal and thermal_zone*/temp)
> 
> No they are not. Unfortunately, I didn't have HW to test, so
> appreciate the help with testing. I'll check the 8, 9, 17 and 19 again
> before resubmitting.

Looks like Andy merged this series?

https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-next

I was expecting a respin, or a discussion of the failures.

Slightly confused. What next?

Regards.

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

[Amit Kucheria]

On Tue, Apr 23, 2019 at 3:01 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
>
> On 02/04/2019 20:46, Amit Kucheria wrote:
>
> > On Tue, Apr 2, 2019 at 8:58 PM Marc Gonzalez wrote:
> >>
> >> On 29/03/2019 11:12, Amit Kucheria wrote:
> >>
> >>> Changes since v1:
> >>> - Devices that are not associated with cooling-maps use the 'hot' type
> >>> - Remove critical trip from such devices too and restrict that type of CPUs
> >>> - For 8916, add the sensor on the modem
> >>>
> >>> Description:
> >>> - Expose all temperature sensors on msm8916, msm996, msm8998, sdm845
> >>> - split up the register address map for msm8998
> >>> - standardize names of the various thermal-zones across boards to make it
> >>>   easy for test scripts to parse
> >>
> >> This is what I see on msm8998 with your patch series applied on top of
> >> yesterday's next:
> >>
> >> # dmesg | grep of_parse_thermal_zones
> >> of_parse_thermal_zones: build cpu0-thermal zone 0
> >> of_parse_thermal_zones: build cpu1-thermal zone 0
> >> of_parse_thermal_zones: build cpu2-thermal zone 0
> >> of_parse_thermal_zones: build cpu3-thermal zone 0
> >> of_parse_thermal_zones: build cpu4-thermal zone 0
> >> of_parse_thermal_zones: build cpu5-thermal zone 0
> >> of_parse_thermal_zones: build cpu6-thermal zone 0
> >> of_parse_thermal_zones: build cpu7-thermal zone 0
> >> of_parse_thermal_zones: build gpu-thermal-bottom zone 0
> >> of_parse_thermal_zones: build gpu-thermal-top zone 0
> >> of_parse_thermal_zones: build cluster0-mhm-thermal zone -22
> >> of_parse_thermal_zones: build cluster1-mhm-thermal zone -22
> >> of_parse_thermal_zones: build cluster1-l2-thermal zone 0
> >> of_parse_thermal_zones: build modem-thermal zone 0
> >> of_parse_thermal_zones: build mem-thermal zone 0
> >> of_parse_thermal_zones: build wlan-thermal zone 0
> >> of_parse_thermal_zones: build q6-dsp-thermal zone 0
> >> of_parse_thermal_zones: build camera-thermal zone 0
> >> of_parse_thermal_zones: build multimedia-thermal zone 0
> >> of_parse_thermal_zones: build pm8998 zone 0
> >> of_parse_thermal_zones: build battery-thermal zone 0
> >> of_parse_thermal_zones: build skin-thermal zone 0
> >>
> >> NB: -EINVAL for cluster0-mhm-thermal and cluster1-mhm-thermal
> >>
> >>
> >> # cat /sys/devices/virtual/thermal/thermal_zone*/temp
> >> 35800
> >> 35200
> >> 34500
> >> 34800
> >> 34500
> >> 34100
> >> 34100
> >> 33500
> >> 33800
> >> cat: /sys/devices/virtual/thermal/thermal_zone17/temp: Invalid argument
> >> 36100
> >> cat: /sys/devices/virtual/thermal/thermal_zone19/temp: Invalid argument
> >> 35500
> >> 36100
> >> 35800
> >> 35200
> >> 35500
> >> 36100
> >> cat: /sys/devices/virtual/thermal/thermal_zone8/temp: Invalid argument
> >> cat: /sys/devices/virtual/thermal/thermal_zone9/temp: Invalid argument
> >>
> >>
> >> Are the failures expected?
> >> (cluster*-mhm-thermal and thermal_zone*/temp)
> >
> > No they are not. Unfortunately, I didn't have HW to test, so
> > appreciate the help with testing. I'll check the 8, 9, 17 and 19 again
> > before resubmitting.
>
> Looks like Andy merged this series?

Argh! my bad, I completely forgot about the need to fix this up. I
need to get me one of these boards.

> https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-next
>
> I was expecting a respin, or a discussion of the failures.
>
> Slightly confused. What next?
>

We can either revert that one patch for the msm8998, but I think it
might be better if I send a fixup patch that could fixup those 4 zones
instead.

Does that work for you?

Regards,
Amit

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

[Marc Gonzalez]

On 23/04/2019 14:56, Amit Kucheria wrote:

> On Tue, Apr 23, 2019 at 3:01 PM Marc Gonzalez wrote:
>
>> On 02/04/2019 20:46, Amit Kucheria wrote:
>>
>>> On Tue, Apr 2, 2019 at 8:58 PM Marc Gonzalez wrote:
>>>
>>>> On 29/03/2019 11:12, Amit Kucheria wrote:
>>>>
>>>>> Changes since v1:
>>>>> - Devices that are not associated with cooling-maps use the 'hot' type
>>>>> - Remove critical trip from such devices too and restrict that type of CPUs
>>>>> - For 8916, add the sensor on the modem
>>>>>
>>>>> Description:
>>>>> - Expose all temperature sensors on msm8916, msm996, msm8998, sdm845
>>>>> - split up the register address map for msm8998
>>>>> - standardize names of the various thermal-zones across boards to make it
>>>>>   easy for test scripts to parse
>>>>
>>>> This is what I see on msm8998 with your patch series applied on top of
>>>> yesterday's next:
>>>>
>>>> # dmesg | grep of_parse_thermal_zones
>>>> of_parse_thermal_zones: build cpu0-thermal zone 0
>>>> of_parse_thermal_zones: build cpu1-thermal zone 0
>>>> of_parse_thermal_zones: build cpu2-thermal zone 0
>>>> of_parse_thermal_zones: build cpu3-thermal zone 0
>>>> of_parse_thermal_zones: build cpu4-thermal zone 0
>>>> of_parse_thermal_zones: build cpu5-thermal zone 0
>>>> of_parse_thermal_zones: build cpu6-thermal zone 0
>>>> of_parse_thermal_zones: build cpu7-thermal zone 0
>>>> of_parse_thermal_zones: build gpu-thermal-bottom zone 0
>>>> of_parse_thermal_zones: build gpu-thermal-top zone 0
>>>> of_parse_thermal_zones: build cluster0-mhm-thermal zone -22
>>>> of_parse_thermal_zones: build cluster1-mhm-thermal zone -22
>>>> of_parse_thermal_zones: build cluster1-l2-thermal zone 0
>>>> of_parse_thermal_zones: build modem-thermal zone 0
>>>> of_parse_thermal_zones: build mem-thermal zone 0
>>>> of_parse_thermal_zones: build wlan-thermal zone 0
>>>> of_parse_thermal_zones: build q6-dsp-thermal zone 0
>>>> of_parse_thermal_zones: build camera-thermal zone 0
>>>> of_parse_thermal_zones: build multimedia-thermal zone 0
>>>> of_parse_thermal_zones: build pm8998 zone 0
>>>> of_parse_thermal_zones: build battery-thermal zone 0
>>>> of_parse_thermal_zones: build skin-thermal zone 0
>>>>
>>>> NB: -EINVAL for cluster0-mhm-thermal and cluster1-mhm-thermal
>>>>
>>>>
>>>> # cat /sys/devices/virtual/thermal/thermal_zone*/temp
>>>> 35800
>>>> 35200
>>>> 34500
>>>> 34800
>>>> 34500
>>>> 34100
>>>> 34100
>>>> 33500
>>>> 33800
>>>> cat: /sys/devices/virtual/thermal/thermal_zone17/temp: Invalid argument
>>>> 36100
>>>> cat: /sys/devices/virtual/thermal/thermal_zone19/temp: Invalid argument
>>>> 35500
>>>> 36100
>>>> 35800
>>>> 35200
>>>> 35500
>>>> 36100
>>>> cat: /sys/devices/virtual/thermal/thermal_zone8/temp: Invalid argument
>>>> cat: /sys/devices/virtual/thermal/thermal_zone9/temp: Invalid argument
>>>>
>>>>
>>>> Are the failures expected?
>>>> (cluster*-mhm-thermal and thermal_zone*/temp)
>>>
>>> No they are not. Unfortunately, I didn't have HW to test, so
>>> appreciate the help with testing. I'll check the 8, 9, 17 and 19 again
>>> before resubmitting.
>>
>> Looks like Andy merged this series?
> 
> Argh! my bad, I completely forgot about the need to fix this up. I
> need to get me one of these boards.
> 
>> https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-next
>>
>> I was expecting a respin, or a discussion of the failures.
>>
>> Slightly confused. What next?
> 
> We can either revert that one patch for the msm8998, but I think it
> might be better if I send a fixup patch that could fixup those 4 zones
> instead.
> 
> Does that work for you?

Sure. I can give you a Tested-by once everything works on the MEDIABOX I have.

You mention the 4 thermal_zone*/temp failures.

What about the cluster0-mhm-thermal and cluster1-mhm-thermal failures?

Regards.

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

[Marc Gonzalez]

On 23/04/2019 15:10, Marc Gonzalez wrote:

> Sure. I can give you a Tested-by once everything works on the MEDIABOX I have.
> 
> You mention the 4 thermal_zone*/temp failures.
> 
> What about the cluster0-mhm-thermal and cluster1-mhm-thermal failures?

I have synced up with today's linux-next.

# dmesg | grep thermal
Failed to build cluster0-mhm-thermal zone -22
Failed to build cluster1-mhm-thermal zone -22

# for F in $(find /sys/class/thermal/thermal_zone?/ /sys/class/thermal/thermal_zone??/ -type f); do echo $F; cat $F; done
/sys/class/thermal/thermal_zone0/uevent
/sys/class/thermal/thermal_zone0/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone0/mode
enabled
/sys/class/thermal/thermal_zone0/power/runtime_active_time
0
/sys/class/thermal/thermal_zone0/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone0/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone0/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone0/power/control
auto
/sys/class/thermal/thermal_zone0/available_policies
step_wise
/sys/class/thermal/thermal_zone0/policy
step_wise
/sys/class/thermal/thermal_zone0/trip_point_1_type
critical
/sys/class/thermal/thermal_zone0/k_d
0
/sys/class/thermal/thermal_zone0/sustainable_power
0
/sys/class/thermal/thermal_zone0/type
cpu0-thermal
/sys/class/thermal/thermal_zone0/offset
0
/sys/class/thermal/thermal_zone0/slope
1
/sys/class/thermal/thermal_zone0/trip_point_0_type
passive
/sys/class/thermal/thermal_zone0/k_po
0
/sys/class/thermal/thermal_zone0/integral_cutoff
0
/sys/class/thermal/thermal_zone0/k_i
0
/sys/class/thermal/thermal_zone0/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone0/k_pu
0
/sys/class/thermal/thermal_zone0/temp
34900
/sys/class/thermal/thermal_zone0/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone0/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone1/uevent
/sys/class/thermal/thermal_zone1/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone1/mode
enabled
/sys/class/thermal/thermal_zone1/power/runtime_active_time
0
/sys/class/thermal/thermal_zone1/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone1/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone1/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone1/power/control
auto
/sys/class/thermal/thermal_zone1/available_policies
step_wise
/sys/class/thermal/thermal_zone1/policy
step_wise
/sys/class/thermal/thermal_zone1/trip_point_1_type
critical
/sys/class/thermal/thermal_zone1/k_d
0
/sys/class/thermal/thermal_zone1/sustainable_power
0
/sys/class/thermal/thermal_zone1/type
cpu1-thermal
/sys/class/thermal/thermal_zone1/offset
0
/sys/class/thermal/thermal_zone1/slope
1
/sys/class/thermal/thermal_zone1/trip_point_0_type
passive
/sys/class/thermal/thermal_zone1/k_po
0
/sys/class/thermal/thermal_zone1/integral_cutoff
0
/sys/class/thermal/thermal_zone1/k_i
0
/sys/class/thermal/thermal_zone1/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone1/k_pu
0
/sys/class/thermal/thermal_zone1/temp
33900
/sys/class/thermal/thermal_zone1/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone1/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone2/uevent
/sys/class/thermal/thermal_zone2/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone2/mode
enabled
/sys/class/thermal/thermal_zone2/power/runtime_active_time
0
/sys/class/thermal/thermal_zone2/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone2/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone2/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone2/power/control
auto
/sys/class/thermal/thermal_zone2/available_policies
step_wise
/sys/class/thermal/thermal_zone2/policy
step_wise
/sys/class/thermal/thermal_zone2/trip_point_1_type
critical
/sys/class/thermal/thermal_zone2/k_d
0
/sys/class/thermal/thermal_zone2/sustainable_power
0
/sys/class/thermal/thermal_zone2/type
cpu2-thermal
/sys/class/thermal/thermal_zone2/offset
0
/sys/class/thermal/thermal_zone2/slope
1
/sys/class/thermal/thermal_zone2/trip_point_0_type
passive
/sys/class/thermal/thermal_zone2/k_po
0
/sys/class/thermal/thermal_zone2/integral_cutoff
0
/sys/class/thermal/thermal_zone2/k_i
0
/sys/class/thermal/thermal_zone2/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone2/k_pu
0
/sys/class/thermal/thermal_zone2/temp
34200
/sys/class/thermal/thermal_zone2/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone2/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone3/uevent
/sys/class/thermal/thermal_zone3/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone3/mode
enabled
/sys/class/thermal/thermal_zone3/power/runtime_active_time
0
/sys/class/thermal/thermal_zone3/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone3/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone3/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone3/power/control
auto
/sys/class/thermal/thermal_zone3/available_policies
step_wise
/sys/class/thermal/thermal_zone3/policy
step_wise
/sys/class/thermal/thermal_zone3/trip_point_1_type
critical
/sys/class/thermal/thermal_zone3/k_d
0
/sys/class/thermal/thermal_zone3/sustainable_power
0
/sys/class/thermal/thermal_zone3/type
cpu3-thermal
/sys/class/thermal/thermal_zone3/offset
0
/sys/class/thermal/thermal_zone3/slope
1
/sys/class/thermal/thermal_zone3/trip_point_0_type
passive
/sys/class/thermal/thermal_zone3/k_po
0
/sys/class/thermal/thermal_zone3/integral_cutoff
0
/sys/class/thermal/thermal_zone3/k_i
0
/sys/class/thermal/thermal_zone3/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone3/k_pu
0
/sys/class/thermal/thermal_zone3/temp
34200
/sys/class/thermal/thermal_zone3/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone3/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone4/uevent
/sys/class/thermal/thermal_zone4/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone4/mode
enabled
/sys/class/thermal/thermal_zone4/power/runtime_active_time
0
/sys/class/thermal/thermal_zone4/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone4/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone4/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone4/power/control
auto
/sys/class/thermal/thermal_zone4/available_policies
step_wise
/sys/class/thermal/thermal_zone4/policy
step_wise
/sys/class/thermal/thermal_zone4/trip_point_1_type
critical
/sys/class/thermal/thermal_zone4/k_d
0
/sys/class/thermal/thermal_zone4/sustainable_power
0
/sys/class/thermal/thermal_zone4/type
cpu4-thermal
/sys/class/thermal/thermal_zone4/offset
0
/sys/class/thermal/thermal_zone4/slope
1
/sys/class/thermal/thermal_zone4/trip_point_0_type
passive
/sys/class/thermal/thermal_zone4/k_po
0
/sys/class/thermal/thermal_zone4/integral_cutoff
0
/sys/class/thermal/thermal_zone4/k_i
0
/sys/class/thermal/thermal_zone4/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone4/k_pu
0
/sys/class/thermal/thermal_zone4/temp
34200
/sys/class/thermal/thermal_zone4/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone4/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone5/uevent
/sys/class/thermal/thermal_zone5/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone5/mode
enabled
/sys/class/thermal/thermal_zone5/power/runtime_active_time
0
/sys/class/thermal/thermal_zone5/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone5/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone5/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone5/power/control
auto
/sys/class/thermal/thermal_zone5/available_policies
step_wise
/sys/class/thermal/thermal_zone5/policy
step_wise
/sys/class/thermal/thermal_zone5/trip_point_1_type
critical
/sys/class/thermal/thermal_zone5/k_d
0
/sys/class/thermal/thermal_zone5/sustainable_power
0
/sys/class/thermal/thermal_zone5/type
cpu5-thermal
/sys/class/thermal/thermal_zone5/offset
0
/sys/class/thermal/thermal_zone5/slope
1
/sys/class/thermal/thermal_zone5/trip_point_0_type
passive
/sys/class/thermal/thermal_zone5/k_po
0
/sys/class/thermal/thermal_zone5/integral_cutoff
0
/sys/class/thermal/thermal_zone5/k_i
0
/sys/class/thermal/thermal_zone5/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone5/k_pu
0
/sys/class/thermal/thermal_zone5/temp
32900
/sys/class/thermal/thermal_zone5/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone5/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone6/uevent
/sys/class/thermal/thermal_zone6/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone6/mode
enabled
/sys/class/thermal/thermal_zone6/power/runtime_active_time
0
/sys/class/thermal/thermal_zone6/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone6/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone6/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone6/power/control
auto
/sys/class/thermal/thermal_zone6/available_policies
step_wise
/sys/class/thermal/thermal_zone6/policy
step_wise
/sys/class/thermal/thermal_zone6/trip_point_1_type
critical
/sys/class/thermal/thermal_zone6/k_d
0
/sys/class/thermal/thermal_zone6/sustainable_power
0
/sys/class/thermal/thermal_zone6/type
cpu6-thermal
/sys/class/thermal/thermal_zone6/offset
0
/sys/class/thermal/thermal_zone6/slope
1
/sys/class/thermal/thermal_zone6/trip_point_0_type
passive
/sys/class/thermal/thermal_zone6/k_po
0
/sys/class/thermal/thermal_zone6/integral_cutoff
0
/sys/class/thermal/thermal_zone6/k_i
0
/sys/class/thermal/thermal_zone6/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone6/k_pu
0
/sys/class/thermal/thermal_zone6/temp
33300
/sys/class/thermal/thermal_zone6/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone6/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone7/uevent
/sys/class/thermal/thermal_zone7/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone7/mode
enabled
/sys/class/thermal/thermal_zone7/power/runtime_active_time
0
/sys/class/thermal/thermal_zone7/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone7/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone7/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone7/power/control
auto
/sys/class/thermal/thermal_zone7/available_policies
step_wise
/sys/class/thermal/thermal_zone7/policy
step_wise
/sys/class/thermal/thermal_zone7/trip_point_1_type
critical
/sys/class/thermal/thermal_zone7/k_d
0
/sys/class/thermal/thermal_zone7/sustainable_power
0
/sys/class/thermal/thermal_zone7/type
cpu7-thermal
/sys/class/thermal/thermal_zone7/offset
0
/sys/class/thermal/thermal_zone7/slope
1
/sys/class/thermal/thermal_zone7/trip_point_0_type
passive
/sys/class/thermal/thermal_zone7/k_po
0
/sys/class/thermal/thermal_zone7/integral_cutoff
0
/sys/class/thermal/thermal_zone7/k_i
0
/sys/class/thermal/thermal_zone7/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone7/k_pu
0
/sys/class/thermal/thermal_zone7/temp
34200
/sys/class/thermal/thermal_zone7/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone7/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone8/uevent
/sys/class/thermal/thermal_zone8/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone8/passive
0
/sys/class/thermal/thermal_zone8/mode
disabled
/sys/class/thermal/thermal_zone8/power/runtime_active_time
0
/sys/class/thermal/thermal_zone8/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone8/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone8/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone8/power/control
auto
/sys/class/thermal/thermal_zone8/available_policies
step_wise
/sys/class/thermal/thermal_zone8/policy
step_wise
/sys/class/thermal/thermal_zone8/k_d
0
/sys/class/thermal/thermal_zone8/sustainable_power
0
/sys/class/thermal/thermal_zone8/type
gpu-thermal-bottom
/sys/class/thermal/thermal_zone8/offset
0
/sys/class/thermal/thermal_zone8/slope
1
/sys/class/thermal/thermal_zone8/trip_point_0_type
hot
/sys/class/thermal/thermal_zone8/k_po
0
/sys/class/thermal/thermal_zone8/integral_cutoff
0
/sys/class/thermal/thermal_zone8/k_i
0
/sys/class/thermal/thermal_zone8/k_pu
0
/sys/class/thermal/thermal_zone8/temp
cat: read error: Invalid argument
/sys/class/thermal/thermal_zone8/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone9/uevent
/sys/class/thermal/thermal_zone9/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone9/passive
0
/sys/class/thermal/thermal_zone9/mode
disabled
/sys/class/thermal/thermal_zone9/power/runtime_active_time
0
/sys/class/thermal/thermal_zone9/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone9/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone9/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone9/power/control
auto
/sys/class/thermal/thermal_zone9/available_policies
step_wise
/sys/class/thermal/thermal_zone9/policy
step_wise
/sys/class/thermal/thermal_zone9/k_d
0
/sys/class/thermal/thermal_zone9/sustainable_power
0
/sys/class/thermal/thermal_zone9/type
gpu-thermal-top
/sys/class/thermal/thermal_zone9/offset
0
/sys/class/thermal/thermal_zone9/slope
1
/sys/class/thermal/thermal_zone9/trip_point_0_type
hot
/sys/class/thermal/thermal_zone9/k_po
0
/sys/class/thermal/thermal_zone9/integral_cutoff
0
/sys/class/thermal/thermal_zone9/k_i
0
/sys/class/thermal/thermal_zone9/k_pu
0
/sys/class/thermal/thermal_zone9/temp
cat: read error: Invalid argument
/sys/class/thermal/thermal_zone9/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone10/uevent
/sys/class/thermal/thermal_zone10/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone10/passive
0
/sys/class/thermal/thermal_zone10/mode
enabled
/sys/class/thermal/thermal_zone10/power/runtime_active_time
0
/sys/class/thermal/thermal_zone10/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone10/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone10/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone10/power/control
auto
/sys/class/thermal/thermal_zone10/available_policies
step_wise
/sys/class/thermal/thermal_zone10/policy
step_wise
/sys/class/thermal/thermal_zone10/k_d
0
/sys/class/thermal/thermal_zone10/sustainable_power
0
/sys/class/thermal/thermal_zone10/type
cluster1-l2-thermal
/sys/class/thermal/thermal_zone10/offset
0
/sys/class/thermal/thermal_zone10/slope
1
/sys/class/thermal/thermal_zone10/trip_point_0_type
hot
/sys/class/thermal/thermal_zone10/k_po
0
/sys/class/thermal/thermal_zone10/integral_cutoff
0
/sys/class/thermal/thermal_zone10/k_i
0
/sys/class/thermal/thermal_zone10/k_pu
0
/sys/class/thermal/thermal_zone10/temp
32900
/sys/class/thermal/thermal_zone10/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone11/uevent
/sys/class/thermal/thermal_zone11/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone11/passive
0
/sys/class/thermal/thermal_zone11/mode
enabled
/sys/class/thermal/thermal_zone11/power/runtime_active_time
0
/sys/class/thermal/thermal_zone11/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone11/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone11/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone11/power/control
auto
/sys/class/thermal/thermal_zone11/available_policies
step_wise
/sys/class/thermal/thermal_zone11/policy
step_wise
/sys/class/thermal/thermal_zone11/k_d
0
/sys/class/thermal/thermal_zone11/sustainable_power
0
/sys/class/thermal/thermal_zone11/type
modem-thermal
/sys/class/thermal/thermal_zone11/offset
0
/sys/class/thermal/thermal_zone11/slope
1
/sys/class/thermal/thermal_zone11/trip_point_0_type
hot
/sys/class/thermal/thermal_zone11/k_po
0
/sys/class/thermal/thermal_zone11/integral_cutoff
0
/sys/class/thermal/thermal_zone11/k_i
0
/sys/class/thermal/thermal_zone11/k_pu
0
/sys/class/thermal/thermal_zone11/temp
33200
/sys/class/thermal/thermal_zone11/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone12/uevent
/sys/class/thermal/thermal_zone12/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone12/passive
0
/sys/class/thermal/thermal_zone12/mode
enabled
/sys/class/thermal/thermal_zone12/power/runtime_active_time
0
/sys/class/thermal/thermal_zone12/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone12/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone12/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone12/power/control
auto
/sys/class/thermal/thermal_zone12/available_policies
step_wise
/sys/class/thermal/thermal_zone12/policy
step_wise
/sys/class/thermal/thermal_zone12/k_d
0
/sys/class/thermal/thermal_zone12/sustainable_power
0
/sys/class/thermal/thermal_zone12/type
mem-thermal
/sys/class/thermal/thermal_zone12/offset
0
/sys/class/thermal/thermal_zone12/slope
1
/sys/class/thermal/thermal_zone12/trip_point_0_type
hot
/sys/class/thermal/thermal_zone12/k_po
0
/sys/class/thermal/thermal_zone12/integral_cutoff
0
/sys/class/thermal/thermal_zone12/k_i
0
/sys/class/thermal/thermal_zone12/k_pu
0
/sys/class/thermal/thermal_zone12/temp
32900
/sys/class/thermal/thermal_zone12/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone13/uevent
/sys/class/thermal/thermal_zone13/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone13/passive
0
/sys/class/thermal/thermal_zone13/mode
enabled
/sys/class/thermal/thermal_zone13/power/runtime_active_time
0
/sys/class/thermal/thermal_zone13/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone13/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone13/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone13/power/control
auto
/sys/class/thermal/thermal_zone13/available_policies
step_wise
/sys/class/thermal/thermal_zone13/policy
step_wise
/sys/class/thermal/thermal_zone13/k_d
0
/sys/class/thermal/thermal_zone13/sustainable_power
0
/sys/class/thermal/thermal_zone13/type
wlan-thermal
/sys/class/thermal/thermal_zone13/offset
0
/sys/class/thermal/thermal_zone13/slope
1
/sys/class/thermal/thermal_zone13/trip_point_0_type
hot
/sys/class/thermal/thermal_zone13/k_po
0
/sys/class/thermal/thermal_zone13/integral_cutoff
0
/sys/class/thermal/thermal_zone13/k_i
0
/sys/class/thermal/thermal_zone13/k_pu
0
/sys/class/thermal/thermal_zone13/temp
33200
/sys/class/thermal/thermal_zone13/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone14/uevent
/sys/class/thermal/thermal_zone14/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone14/passive
0
/sys/class/thermal/thermal_zone14/mode
enabled
/sys/class/thermal/thermal_zone14/power/runtime_active_time
0
/sys/class/thermal/thermal_zone14/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone14/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone14/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone14/power/control
auto
/sys/class/thermal/thermal_zone14/available_policies
step_wise
/sys/class/thermal/thermal_zone14/policy
step_wise
/sys/class/thermal/thermal_zone14/k_d
0
/sys/class/thermal/thermal_zone14/sustainable_power
0
/sys/class/thermal/thermal_zone14/type
q6-dsp-thermal
/sys/class/thermal/thermal_zone14/offset
0
/sys/class/thermal/thermal_zone14/slope
1
/sys/class/thermal/thermal_zone14/trip_point_0_type
hot
/sys/class/thermal/thermal_zone14/k_po
0
/sys/class/thermal/thermal_zone14/integral_cutoff
0
/sys/class/thermal/thermal_zone14/k_i
0
/sys/class/thermal/thermal_zone14/k_pu
0
/sys/class/thermal/thermal_zone14/temp
32900
/sys/class/thermal/thermal_zone14/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone15/uevent
/sys/class/thermal/thermal_zone15/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone15/passive
0
/sys/class/thermal/thermal_zone15/mode
enabled
/sys/class/thermal/thermal_zone15/power/runtime_active_time
0
/sys/class/thermal/thermal_zone15/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone15/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone15/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone15/power/control
auto
/sys/class/thermal/thermal_zone15/available_policies
step_wise
/sys/class/thermal/thermal_zone15/policy
step_wise
/sys/class/thermal/thermal_zone15/k_d
0
/sys/class/thermal/thermal_zone15/sustainable_power
0
/sys/class/thermal/thermal_zone15/type
camera-thermal
/sys/class/thermal/thermal_zone15/offset
0
/sys/class/thermal/thermal_zone15/slope
1
/sys/class/thermal/thermal_zone15/trip_point_0_type
hot
/sys/class/thermal/thermal_zone15/k_po
0
/sys/class/thermal/thermal_zone15/integral_cutoff
0
/sys/class/thermal/thermal_zone15/k_i
0
/sys/class/thermal/thermal_zone15/k_pu
0
/sys/class/thermal/thermal_zone15/temp
32200
/sys/class/thermal/thermal_zone15/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone16/uevent
/sys/class/thermal/thermal_zone16/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone16/passive
0
/sys/class/thermal/thermal_zone16/mode
enabled
/sys/class/thermal/thermal_zone16/power/runtime_active_time
0
/sys/class/thermal/thermal_zone16/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone16/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone16/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone16/power/control
auto
/sys/class/thermal/thermal_zone16/available_policies
step_wise
/sys/class/thermal/thermal_zone16/policy
step_wise
/sys/class/thermal/thermal_zone16/k_d
0
/sys/class/thermal/thermal_zone16/sustainable_power
0
/sys/class/thermal/thermal_zone16/type
multimedia-thermal
/sys/class/thermal/thermal_zone16/offset
0
/sys/class/thermal/thermal_zone16/slope
1
/sys/class/thermal/thermal_zone16/trip_point_0_type
hot
/sys/class/thermal/thermal_zone16/k_po
0
/sys/class/thermal/thermal_zone16/integral_cutoff
0
/sys/class/thermal/thermal_zone16/k_i
0
/sys/class/thermal/thermal_zone16/k_pu
0
/sys/class/thermal/thermal_zone16/temp
32900
/sys/class/thermal/thermal_zone16/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone17/uevent
/sys/class/thermal/thermal_zone17/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone17/mode
disabled
/sys/class/thermal/thermal_zone17/power/runtime_active_time
0
/sys/class/thermal/thermal_zone17/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone17/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone17/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone17/power/control
auto
/sys/class/thermal/thermal_zone17/available_policies
step_wise
/sys/class/thermal/thermal_zone17/policy
step_wise
/sys/class/thermal/thermal_zone17/trip_point_1_type
critical
/sys/class/thermal/thermal_zone17/k_d
0
/sys/class/thermal/thermal_zone17/sustainable_power
0
/sys/class/thermal/thermal_zone17/type
pm8998
/sys/class/thermal/thermal_zone17/offset
0
/sys/class/thermal/thermal_zone17/slope
1
/sys/class/thermal/thermal_zone17/trip_point_0_type
passive
/sys/class/thermal/thermal_zone17/k_po
0
/sys/class/thermal/thermal_zone17/integral_cutoff
0
/sys/class/thermal/thermal_zone17/k_i
0
/sys/class/thermal/thermal_zone17/trip_point_1_temp
125000
/sys/class/thermal/thermal_zone17/k_pu
0
/sys/class/thermal/thermal_zone17/temp
cat: read error: Invalid argument
/sys/class/thermal/thermal_zone17/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone17/trip_point_0_temp
105000
/sys/class/thermal/thermal_zone18/uevent
/sys/class/thermal/thermal_zone18/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone18/passive
0
/sys/class/thermal/thermal_zone18/mode
enabled
/sys/class/thermal/thermal_zone18/power/runtime_active_time
0
/sys/class/thermal/thermal_zone18/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone18/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone18/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone18/power/control
auto
/sys/class/thermal/thermal_zone18/available_policies
step_wise
/sys/class/thermal/thermal_zone18/policy
step_wise
/sys/class/thermal/thermal_zone18/k_d
0
/sys/class/thermal/thermal_zone18/sustainable_power
0
/sys/class/thermal/thermal_zone18/type
battery-thermal
/sys/class/thermal/thermal_zone18/offset
0
/sys/class/thermal/thermal_zone18/slope
1
/sys/class/thermal/thermal_zone18/trip_point_0_type
critical
/sys/class/thermal/thermal_zone18/k_po
0
/sys/class/thermal/thermal_zone18/integral_cutoff
0
/sys/class/thermal/thermal_zone18/k_i
0
/sys/class/thermal/thermal_zone18/k_pu
0
/sys/class/thermal/thermal_zone18/temp
34900
/sys/class/thermal/thermal_zone18/trip_point_0_temp
60000
/sys/class/thermal/thermal_zone19/uevent
/sys/class/thermal/thermal_zone19/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone19/mode
disabled
/sys/class/thermal/thermal_zone19/power/runtime_active_time
0
/sys/class/thermal/thermal_zone19/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone19/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone19/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone19/power/control
auto
/sys/class/thermal/thermal_zone19/available_policies
step_wise
/sys/class/thermal/thermal_zone19/policy
step_wise
/sys/class/thermal/thermal_zone19/trip_point_1_type
critical
/sys/class/thermal/thermal_zone19/k_d
0
/sys/class/thermal/thermal_zone19/sustainable_power
0
/sys/class/thermal/thermal_zone19/type
skin-thermal
/sys/class/thermal/thermal_zone19/offset
0
/sys/class/thermal/thermal_zone19/slope
1
/sys/class/thermal/thermal_zone19/trip_point_0_type
passive
/sys/class/thermal/thermal_zone19/k_po
0
/sys/class/thermal/thermal_zone19/integral_cutoff
0
/sys/class/thermal/thermal_zone19/k_i
0
/sys/class/thermal/thermal_zone19/trip_point_1_temp
70000
/sys/class/thermal/thermal_zone19/k_pu
0
/sys/class/thermal/thermal_zone19/temp
cat: read error: Invalid argument
/sys/class/thermal/thermal_zone19/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone19/trip_point_0_temp
44000

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

[Amit Kucheria]

[-- Attachment #1: Type: text/plain, Size: 3700 bytes --]

Marc, can you please test these 3 patches on top of my original series?

Andy, patches 1 and 2 fix problems that already exist upstream. They
were not introduced by my series.
Patch 3 fixes an issue with my series where the name of the thermal
zone was too long. You can choose to fold it into the patch titled
"arm64: dts: msm8998: thermal: Add temperature sensors near major
peripherals" or add it as a new patch with a Fixes tag.

On Wed, Apr 24, 2019 at 8:00 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
>
> On 23/04/2019 15:10, Marc Gonzalez wrote:
>
> > Sure. I can give you a Tested-by once everything works on the MEDIABOX I have.
> >
> > You mention the 4 thermal_zone*/temp failures.
> >
> > What about the cluster0-mhm-thermal and cluster1-mhm-thermal failures?
>
> I have synced up with today's linux-next.

Thanks for the report. Can you add the attached couple of patches and retest?

> # dmesg | grep thermal
> Failed to build cluster0-mhm-thermal zone -22
> Failed to build cluster1-mhm-thermal zone -22

This one turned out to be a silly one, The name of the thermal zone is
restricted to under 20 characters. Fixed that with patch 3.

> # for F in $(find /sys/class/thermal/thermal_zone?/ /sys/class/thermal/thermal_zone??/ -type f); do echo $F; cat $F; done
> /sys/class/thermal/thermal_zone0/uevent
> /sys/class/thermal/thermal_zone0/trip_point_0_hyst
> 2000
> /sys/class/thermal/thermal_zone0/mode
> enabled
> /sys/class/thermal/thermal_zone0/power/runtime_active_time
> 0
> /sys/class/thermal/thermal_zone0/power/runtime_status
> unsupported

<snip>

> /sys/class/thermal/thermal_zone8/type
> gpu-thermal-bottom
> /sys/class/thermal/thermal_zone8/offset
> 0
> /sys/class/thermal/thermal_zone8/slope
> 1
> /sys/class/thermal/thermal_zone8/trip_point_0_type
> hot
> /sys/class/thermal/thermal_zone8/k_po
> 0
> /sys/class/thermal/thermal_zone8/integral_cutoff
> 0
> /sys/class/thermal/thermal_zone8/k_i
> 0
> /sys/class/thermal/thermal_zone8/k_pu
> 0
> /sys/class/thermal/thermal_zone8/temp
> cat: read error: Invalid argument

Patch 2 should fix this and thermal_zone9 below.

> /sys/class/thermal/thermal_zone8/trip_point_0_temp
> 90000
> /sys/class/thermal/thermal_zone9/uevent
> /sys/class/thermal/thermal_zone9/trip_point_0_hyst
> 2000
> /sys/class/thermal/thermal_zone9/passive
> 0
> /sys/class/thermal/thermal_zone9/mode
> disabled
> /sys/class/thermal/thermal_zone9/power/runtime_active_time
> 0
> /sys/class/thermal/thermal_zone9/power/runtime_status
> unsupported
> /sys/class/thermal/thermal_zone9/power/autosuspend_delay_ms
> cat: read error: Input/output error
> /sys/class/thermal/thermal_zone9/power/runtime_suspended_time
> 0
> /sys/class/thermal/thermal_zone9/power/control
> auto
> /sys/class/thermal/thermal_zone9/available_policies
> step_wise
> /sys/class/thermal/thermal_zone9/policy
> step_wise
> /sys/class/thermal/thermal_zone9/k_d
> 0
> /sys/class/thermal/thermal_zone9/sustainable_power
> 0
> /sys/class/thermal/thermal_zone9/type
> gpu-thermal-top
> /sys/class/thermal/thermal_zone9/offset
> 0
> /sys/class/thermal/thermal_zone9/slope

<snip>

> /sys/class/thermal/thermal_zone18/available_policies
> step_wise
> /sys/class/thermal/thermal_zone18/policy
> step_wise
> /sys/class/thermal/thermal_zone18/k_d
> 0
> /sys/class/thermal/thermal_zone18/sustainable_power
> 0
> /sys/class/thermal/thermal_zone18/type
> battery-thermal

This look wrong. TSENS shouldn't have board-specific thermal zones.

<snip>

> /sys/class/thermal/thermal_zone19/k_d
> 0
> /sys/class/thermal/thermal_zone19/sustainable_power
> 0
> /sys/class/thermal/thermal_zone19/type
> skin-thermal

And this too. See patch 1 to fix this existing issue (not introduced
by my series).

[-- Attachment #2: 0001-arm64-dts-msm8998-mtp-thermal-Remove-skin-and-batter.patch --]
[-- Type: text/x-patch, Size: 2034 bytes --]

From 94698e19b6329e98404ff9b9cc0c90a3062fa5e5 Mon Sep 17 00:00:00 2001
Message-Id: <94698e19b6329e98404ff9b9cc0c90a3062fa5e5.1556169637.git.amit.kucheria@linaro.org>
From: Amit Kucheria <amit.kucheria@linaro.org>
Date: Thu, 25 Apr 2019 01:22:50 +0530
Subject: [PATCH 1/2] arm64: dts: msm8998-mtp: thermal: Remove skin and battery
 thermal zones

The msm8998-mtp doesn't have TSENS-based sensors wired up for skin and
battery thermal zones. TSENS sensors should be common across all boards
using the SoC and shouldn't be board-specific as these entries.

They also show the following error when trying to read the temperature

   cat: read error: Invalid argument

Remove these board-specific erroneous thermal zones.

Fixes: 4449b6f248d9 ("arm64: dts: qcom: msm8998: Add tsens and thermal-zones")
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 38 -----------------------
 1 file changed, 38 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
index f0901067b043..60bdf7485f0e 100644
--- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi
@@ -15,44 +15,6 @@
 		stdout-path = "serial0:115200n8";
 	};
 
-	thermal-zones {
-		battery-thermal {
-			polling-delay-passive = <250>;
-			polling-delay = <1000>;
-
-			thermal-sensors = <&tsens0 0>;
-
-			trips {
-				battery_crit: trip0 {
-					temperature = <60000>;
-					hysteresis = <2000>;
-					type = "critical";
-				};
-			};
-		};
-
-		skin-thermal {
-			polling-delay-passive = <250>;
-			polling-delay = <1000>;
-
-			thermal-sensors = <&tsens1 5>;
-
-			trips {
-				skin_alert: trip0 {
-					temperature = <44000>;
-					hysteresis = <2000>;
-					type = "passive";
-				};
-
-				skip_crit: trip1 {
-					temperature = <70000>;
-					hysteresis = <2000>;
-					type = "critical";
-				};
-			};
-		};
-	};
-
 	vph_pwr: vph-pwr-regulator {
 		compatible = "regulator-fixed";
 		regulator-name = "vph_pwr";
-- 
2.17.1


[-- Attachment #3: 0002-arm64-dts-msm8998-thermal-Fix-number-of-supported-se.patch --]
[-- Type: text/x-patch, Size: 1275 bytes --]

From eda7da2d0098d6617671e67658226e3c5fb07045 Mon Sep 17 00:00:00 2001
Message-Id: <eda7da2d0098d6617671e67658226e3c5fb07045.1556169637.git.amit.kucheria@linaro.org>
In-Reply-To: <94698e19b6329e98404ff9b9cc0c90a3062fa5e5.1556169637.git.amit.kucheria@linaro.org>
References: <94698e19b6329e98404ff9b9cc0c90a3062fa5e5.1556169637.git.amit.kucheria@linaro.org>
From: Amit Kucheria <amit.kucheria@linaro.org>
Date: Thu, 25 Apr 2019 01:52:44 +0530
Subject: [PATCH 2/2] arm64: dts: msm8998: thermal: Fix number of supported
 sensors

msm8998 has 22 sensors connected in total, 14 on the 1st controller, 8
on the 2nd controller. Increase the number to allow sensors with ID 12
and 13 to be registered.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 998017d4d847..062a93a12198 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -745,7 +745,7 @@
 			reg = <0x10ab000 0x1000>, /* TM */
 			      <0x10aa000 0x1000>; /* SROT */
 
-			#qcom,sensors = <12>;
+			#qcom,sensors = <14>;
 			#thermal-sensor-cells = <1>;
 		};
 
-- 
2.17.1


[-- Attachment #4: 0003-arm64-dts-msm8998-thermal-Restrict-thermal-zone-name.patch --]
[-- Type: text/x-patch, Size: 1358 bytes --]

From 43ee011006562bac3091fbbe563df883460e98a6 Mon Sep 17 00:00:00 2001
Message-Id: <43ee011006562bac3091fbbe563df883460e98a6.1556173507.git.amit.kucheria@linaro.org>
In-Reply-To: <94698e19b6329e98404ff9b9cc0c90a3062fa5e5.1556173507.git.amit.kucheria@linaro.org>
References: <94698e19b6329e98404ff9b9cc0c90a3062fa5e5.1556173507.git.amit.kucheria@linaro.org>
From: Amit Kucheria <amit.kucheria@linaro.org>
Date: Thu, 25 Apr 2019 11:53:27 +0530
Subject: [PATCH 3/3] arm64: dts: msm8998: thermal: Restrict thermal zone name
 length to under 20

The thermal core restricts names of thermal zones to under 20
characters. Fix the names for a couple of msm8998 thermal zones.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 062a93a12198..01757829d5f3 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -536,7 +536,7 @@
 			};
 		};
 
-		cluster0-mhm-thermal {
+		clust0-mhm-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
@@ -551,7 +551,7 @@
 			};
 		};
 
-		cluster1-mhm-thermal {
+		clust1-mhm-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
-- 
2.17.1

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

[Marc Gonzalez]

On 25/04/2019 08:31, Amit Kucheria wrote:

> Andy, patches 1 and 2 fix problems that already exist upstream. They
> were not introduced by my series.

On IRC, you wrote: "can you send me the same output against mainline
(or linux-next) w/o my patches applied?"

$ git show 58ad5ab73152
commit 58ad5ab731521a80a848033512467675de06b1f2
Merge: 596a434369f6 10518bb15940
Author: Andy Gross <agross@kernel.org>
Date:   Tue Apr 9 23:08:50 2019 -0500

    Merge branch 'arm64-thermal-for-5.2' into arm64-for-5.2

$ git revert -m 1 58ad5ab73152


Below, I only see an error when reading /sys/class/thermal/thermal_zone9/temp
(/sys/class/thermal/thermal_zone9/type = pm8998)


# for F in $(find /sys/class/thermal/thermal_zone?/ /sys/class/thermal/thermal_zone??/ -type f); do echo $F; cat $F; done
/sys/class/thermal/thermal_zone0/uevent
/sys/class/thermal/thermal_zone0/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone0/mode
enabled
/sys/class/thermal/thermal_zone0/power/runtime_active_time
0
/sys/class/thermal/thermal_zone0/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone0/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone0/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone0/power/control
auto
/sys/class/thermal/thermal_zone0/available_policies
step_wise
/sys/class/thermal/thermal_zone0/policy
step_wise
/sys/class/thermal/thermal_zone0/trip_point_1_type
critical
/sys/class/thermal/thermal_zone0/k_d
0
/sys/class/thermal/thermal_zone0/sustainable_power
0
/sys/class/thermal/thermal_zone0/type
cpu-thermal0
/sys/class/thermal/thermal_zone0/offset
0
/sys/class/thermal/thermal_zone0/slope
1
/sys/class/thermal/thermal_zone0/trip_point_0_type
passive
/sys/class/thermal/thermal_zone0/k_po
0
/sys/class/thermal/thermal_zone0/integral_cutoff
0
/sys/class/thermal/thermal_zone0/k_i
0
/sys/class/thermal/thermal_zone0/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone0/k_pu
0
/sys/class/thermal/thermal_zone0/temp
31000
/sys/class/thermal/thermal_zone0/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone0/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone1/uevent
/sys/class/thermal/thermal_zone1/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone1/mode
enabled
/sys/class/thermal/thermal_zone1/power/runtime_active_time
0
/sys/class/thermal/thermal_zone1/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone1/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone1/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone1/power/control
auto
/sys/class/thermal/thermal_zone1/available_policies
step_wise
/sys/class/thermal/thermal_zone1/policy
step_wise
/sys/class/thermal/thermal_zone1/trip_point_1_type
critical
/sys/class/thermal/thermal_zone1/k_d
0
/sys/class/thermal/thermal_zone1/sustainable_power
0
/sys/class/thermal/thermal_zone1/type
cpu-thermal1
/sys/class/thermal/thermal_zone1/offset
0
/sys/class/thermal/thermal_zone1/slope
1
/sys/class/thermal/thermal_zone1/trip_point_0_type
passive
/sys/class/thermal/thermal_zone1/k_po
0
/sys/class/thermal/thermal_zone1/integral_cutoff
0
/sys/class/thermal/thermal_zone1/k_i
0
/sys/class/thermal/thermal_zone1/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone1/k_pu
0
/sys/class/thermal/thermal_zone1/temp
32000
/sys/class/thermal/thermal_zone1/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone1/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone2/uevent
/sys/class/thermal/thermal_zone2/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone2/mode
enabled
/sys/class/thermal/thermal_zone2/power/runtime_active_time
0
/sys/class/thermal/thermal_zone2/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone2/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone2/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone2/power/control
auto
/sys/class/thermal/thermal_zone2/available_policies
step_wise
/sys/class/thermal/thermal_zone2/policy
step_wise
/sys/class/thermal/thermal_zone2/trip_point_1_type
critical
/sys/class/thermal/thermal_zone2/k_d
0
/sys/class/thermal/thermal_zone2/sustainable_power
0
/sys/class/thermal/thermal_zone2/type
cpu-thermal2
/sys/class/thermal/thermal_zone2/offset
0
/sys/class/thermal/thermal_zone2/slope
1
/sys/class/thermal/thermal_zone2/trip_point_0_type
passive
/sys/class/thermal/thermal_zone2/k_po
0
/sys/class/thermal/thermal_zone2/integral_cutoff
0
/sys/class/thermal/thermal_zone2/k_i
0
/sys/class/thermal/thermal_zone2/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone2/k_pu
0
/sys/class/thermal/thermal_zone2/temp
30700
/sys/class/thermal/thermal_zone2/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone2/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone3/uevent
/sys/class/thermal/thermal_zone3/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone3/mode
enabled
/sys/class/thermal/thermal_zone3/power/runtime_active_time
0
/sys/class/thermal/thermal_zone3/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone3/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone3/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone3/power/control
auto
/sys/class/thermal/thermal_zone3/available_policies
step_wise
/sys/class/thermal/thermal_zone3/policy
step_wise
/sys/class/thermal/thermal_zone3/trip_point_1_type
critical
/sys/class/thermal/thermal_zone3/k_d
0
/sys/class/thermal/thermal_zone3/sustainable_power
0
/sys/class/thermal/thermal_zone3/type
cpu-thermal3
/sys/class/thermal/thermal_zone3/offset
0
/sys/class/thermal/thermal_zone3/slope
1
/sys/class/thermal/thermal_zone3/trip_point_0_type
passive
/sys/class/thermal/thermal_zone3/k_po
0
/sys/class/thermal/thermal_zone3/integral_cutoff
0
/sys/class/thermal/thermal_zone3/k_i
0
/sys/class/thermal/thermal_zone3/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone3/k_pu
0
/sys/class/thermal/thermal_zone3/temp
31000
/sys/class/thermal/thermal_zone3/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone3/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone4/uevent
/sys/class/thermal/thermal_zone4/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone4/mode
enabled
/sys/class/thermal/thermal_zone4/power/runtime_active_time
0
/sys/class/thermal/thermal_zone4/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone4/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone4/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone4/power/control
auto
/sys/class/thermal/thermal_zone4/available_policies
step_wise
/sys/class/thermal/thermal_zone4/policy
step_wise
/sys/class/thermal/thermal_zone4/trip_point_1_type
critical
/sys/class/thermal/thermal_zone4/k_d
0
/sys/class/thermal/thermal_zone4/sustainable_power
0
/sys/class/thermal/thermal_zone4/type
cpu-thermal4
/sys/class/thermal/thermal_zone4/offset
0
/sys/class/thermal/thermal_zone4/slope
1
/sys/class/thermal/thermal_zone4/trip_point_0_type
passive
/sys/class/thermal/thermal_zone4/k_po
0
/sys/class/thermal/thermal_zone4/integral_cutoff
0
/sys/class/thermal/thermal_zone4/k_i
0
/sys/class/thermal/thermal_zone4/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone4/k_pu
0
/sys/class/thermal/thermal_zone4/temp
32000
/sys/class/thermal/thermal_zone4/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone4/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone5/uevent
/sys/class/thermal/thermal_zone5/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone5/mode
enabled
/sys/class/thermal/thermal_zone5/power/runtime_active_time
0
/sys/class/thermal/thermal_zone5/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone5/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone5/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone5/power/control
auto
/sys/class/thermal/thermal_zone5/available_policies
step_wise
/sys/class/thermal/thermal_zone5/policy
step_wise
/sys/class/thermal/thermal_zone5/trip_point_1_type
critical
/sys/class/thermal/thermal_zone5/k_d
0
/sys/class/thermal/thermal_zone5/sustainable_power
0
/sys/class/thermal/thermal_zone5/type
cpu-thermal5
/sys/class/thermal/thermal_zone5/offset
0
/sys/class/thermal/thermal_zone5/slope
1
/sys/class/thermal/thermal_zone5/trip_point_0_type
passive
/sys/class/thermal/thermal_zone5/k_po
0
/sys/class/thermal/thermal_zone5/integral_cutoff
0
/sys/class/thermal/thermal_zone5/k_i
0
/sys/class/thermal/thermal_zone5/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone5/k_pu
0
/sys/class/thermal/thermal_zone5/temp
30400
/sys/class/thermal/thermal_zone5/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone5/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone6/uevent
/sys/class/thermal/thermal_zone6/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone6/mode
enabled
/sys/class/thermal/thermal_zone6/power/runtime_active_time
0
/sys/class/thermal/thermal_zone6/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone6/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone6/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone6/power/control
auto
/sys/class/thermal/thermal_zone6/available_policies
step_wise
/sys/class/thermal/thermal_zone6/policy
step_wise
/sys/class/thermal/thermal_zone6/trip_point_1_type
critical
/sys/class/thermal/thermal_zone6/k_d
0
/sys/class/thermal/thermal_zone6/sustainable_power
0
/sys/class/thermal/thermal_zone6/type
cpu-thermal6
/sys/class/thermal/thermal_zone6/offset
0
/sys/class/thermal/thermal_zone6/slope
1
/sys/class/thermal/thermal_zone6/trip_point_0_type
passive
/sys/class/thermal/thermal_zone6/k_po
0
/sys/class/thermal/thermal_zone6/integral_cutoff
0
/sys/class/thermal/thermal_zone6/k_i
0
/sys/class/thermal/thermal_zone6/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone6/k_pu
0
/sys/class/thermal/thermal_zone6/temp
31200
/sys/class/thermal/thermal_zone6/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone6/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone7/uevent
/sys/class/thermal/thermal_zone7/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone7/mode
enabled
/sys/class/thermal/thermal_zone7/power/runtime_active_time
0
/sys/class/thermal/thermal_zone7/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone7/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone7/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone7/power/control
auto
/sys/class/thermal/thermal_zone7/available_policies
step_wise
/sys/class/thermal/thermal_zone7/policy
step_wise
/sys/class/thermal/thermal_zone7/trip_point_1_type
critical
/sys/class/thermal/thermal_zone7/k_d
0
/sys/class/thermal/thermal_zone7/sustainable_power
0
/sys/class/thermal/thermal_zone7/type
cpu-thermal7
/sys/class/thermal/thermal_zone7/offset
0
/sys/class/thermal/thermal_zone7/slope
1
/sys/class/thermal/thermal_zone7/trip_point_0_type
passive
/sys/class/thermal/thermal_zone7/k_po
0
/sys/class/thermal/thermal_zone7/integral_cutoff
0
/sys/class/thermal/thermal_zone7/k_i
0
/sys/class/thermal/thermal_zone7/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone7/k_pu
0
/sys/class/thermal/thermal_zone7/temp
30600
/sys/class/thermal/thermal_zone7/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone7/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone8/uevent
/sys/class/thermal/thermal_zone8/passive
0
/sys/class/thermal/thermal_zone8/mode
enabled
/sys/class/thermal/thermal_zone8/power/runtime_active_time
0
/sys/class/thermal/thermal_zone8/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone8/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone8/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone8/power/control
auto
/sys/class/thermal/thermal_zone8/available_policies
step_wise
/sys/class/thermal/thermal_zone8/policy
step_wise
/sys/class/thermal/thermal_zone8/k_d
0
/sys/class/thermal/thermal_zone8/sustainable_power
0
/sys/class/thermal/thermal_zone8/type
gpu-thermal
/sys/class/thermal/thermal_zone8/offset
0
/sys/class/thermal/thermal_zone8/slope
1
/sys/class/thermal/thermal_zone8/k_po
0
/sys/class/thermal/thermal_zone8/integral_cutoff
0
/sys/class/thermal/thermal_zone8/k_i
0
/sys/class/thermal/thermal_zone8/k_pu
0
/sys/class/thermal/thermal_zone8/temp
30600
/sys/class/thermal/thermal_zone9/uevent
/sys/class/thermal/thermal_zone9/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone9/mode
disabled
/sys/class/thermal/thermal_zone9/power/runtime_active_time
0
/sys/class/thermal/thermal_zone9/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone9/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone9/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone9/power/control
auto
/sys/class/thermal/thermal_zone9/available_policies
step_wise
/sys/class/thermal/thermal_zone9/policy
step_wise
/sys/class/thermal/thermal_zone9/trip_point_1_type
critical
/sys/class/thermal/thermal_zone9/k_d
0
/sys/class/thermal/thermal_zone9/sustainable_power
0
/sys/class/thermal/thermal_zone9/type
pm8998
/sys/class/thermal/thermal_zone9/offset
0
/sys/class/thermal/thermal_zone9/slope
1
/sys/class/thermal/thermal_zone9/trip_point_0_type
passive
/sys/class/thermal/thermal_zone9/k_po
0
/sys/class/thermal/thermal_zone9/integral_cutoff
0
/sys/class/thermal/thermal_zone9/k_i
0
/sys/class/thermal/thermal_zone9/trip_point_1_temp
125000
/sys/class/thermal/thermal_zone9/k_pu
0
/sys/class/thermal/thermal_zone9/temp
cat: read error: Invalid argument
/sys/class/thermal/thermal_zone9/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone9/trip_point_0_temp
105000
/sys/class/thermal/thermal_zone10/uevent
/sys/class/thermal/thermal_zone10/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone10/passive
0
/sys/class/thermal/thermal_zone10/mode
enabled
/sys/class/thermal/thermal_zone10/power/runtime_active_time
0
/sys/class/thermal/thermal_zone10/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone10/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone10/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone10/power/control
auto
/sys/class/thermal/thermal_zone10/available_policies
step_wise
/sys/class/thermal/thermal_zone10/policy
step_wise
/sys/class/thermal/thermal_zone10/k_d
0
/sys/class/thermal/thermal_zone10/sustainable_power
0
/sys/class/thermal/thermal_zone10/type
battery-thermal
/sys/class/thermal/thermal_zone10/offset
0
/sys/class/thermal/thermal_zone10/slope
1
/sys/class/thermal/thermal_zone10/trip_point_0_type
critical
/sys/class/thermal/thermal_zone10/k_po
0
/sys/class/thermal/thermal_zone10/integral_cutoff
0
/sys/class/thermal/thermal_zone10/k_i
0
/sys/class/thermal/thermal_zone10/k_pu
0
/sys/class/thermal/thermal_zone10/temp
32300
/sys/class/thermal/thermal_zone10/trip_point_0_temp
60000
/sys/class/thermal/thermal_zone11/uevent
/sys/class/thermal/thermal_zone11/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone11/mode
enabled
/sys/class/thermal/thermal_zone11/power/runtime_active_time
0
/sys/class/thermal/thermal_zone11/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone11/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone11/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone11/power/control
auto
/sys/class/thermal/thermal_zone11/available_policies
step_wise
/sys/class/thermal/thermal_zone11/policy
step_wise
/sys/class/thermal/thermal_zone11/trip_point_1_type
critical
/sys/class/thermal/thermal_zone11/k_d
0
/sys/class/thermal/thermal_zone11/sustainable_power
0
/sys/class/thermal/thermal_zone11/type
skin-thermal
/sys/class/thermal/thermal_zone11/offset
0
/sys/class/thermal/thermal_zone11/slope
1
/sys/class/thermal/thermal_zone11/trip_point_0_type
passive
/sys/class/thermal/thermal_zone11/k_po
0
/sys/class/thermal/thermal_zone11/integral_cutoff
0
/sys/class/thermal/thermal_zone11/k_i
0
/sys/class/thermal/thermal_zone11/trip_point_1_temp
70000
/sys/class/thermal/thermal_zone11/k_pu
0
/sys/class/thermal/thermal_zone11/temp
29900
/sys/class/thermal/thermal_zone11/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone11/trip_point_0_temp
44000

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

[Marc Gonzalez]

On 25/04/2019 08:31, Amit Kucheria wrote:

> Marc, can you please test these 3 patches on top of my original series?

Roger that.

# dmesg | grep thermal
/* NOTHING */

# for F in $(find /sys/class/thermal/thermal_zone?/ /sys/class/thermal/thermal_zone??/ -type f); do echo $F; cat $F; done
/sys/class/thermal/thermal_zone0/uevent
/sys/class/thermal/thermal_zone0/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone0/mode
enabled
/sys/class/thermal/thermal_zone0/power/runtime_active_time
0
/sys/class/thermal/thermal_zone0/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone0/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone0/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone0/power/control
auto
/sys/class/thermal/thermal_zone0/available_policies
step_wise
/sys/class/thermal/thermal_zone0/policy
step_wise
/sys/class/thermal/thermal_zone0/trip_point_1_type
critical
/sys/class/thermal/thermal_zone0/k_d
0
/sys/class/thermal/thermal_zone0/sustainable_power
0
/sys/class/thermal/thermal_zone0/type
cpu0-thermal
/sys/class/thermal/thermal_zone0/offset
0
/sys/class/thermal/thermal_zone0/slope
1
/sys/class/thermal/thermal_zone0/trip_point_0_type
passive
/sys/class/thermal/thermal_zone0/k_po
0
/sys/class/thermal/thermal_zone0/integral_cutoff
0
/sys/class/thermal/thermal_zone0/k_i
0
/sys/class/thermal/thermal_zone0/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone0/k_pu
0
/sys/class/thermal/thermal_zone0/temp
33600
/sys/class/thermal/thermal_zone0/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone0/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone1/uevent
/sys/class/thermal/thermal_zone1/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone1/mode
enabled
/sys/class/thermal/thermal_zone1/power/runtime_active_time
0
/sys/class/thermal/thermal_zone1/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone1/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone1/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone1/power/control
auto
/sys/class/thermal/thermal_zone1/available_policies
step_wise
/sys/class/thermal/thermal_zone1/policy
step_wise
/sys/class/thermal/thermal_zone1/trip_point_1_type
critical
/sys/class/thermal/thermal_zone1/k_d
0
/sys/class/thermal/thermal_zone1/sustainable_power
0
/sys/class/thermal/thermal_zone1/type
cpu1-thermal
/sys/class/thermal/thermal_zone1/offset
0
/sys/class/thermal/thermal_zone1/slope
1
/sys/class/thermal/thermal_zone1/trip_point_0_type
passive
/sys/class/thermal/thermal_zone1/k_po
0
/sys/class/thermal/thermal_zone1/integral_cutoff
0
/sys/class/thermal/thermal_zone1/k_i
0
/sys/class/thermal/thermal_zone1/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone1/k_pu
0
/sys/class/thermal/thermal_zone1/temp
32300
/sys/class/thermal/thermal_zone1/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone1/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone2/uevent
/sys/class/thermal/thermal_zone2/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone2/mode
enabled
/sys/class/thermal/thermal_zone2/power/runtime_active_time
0
/sys/class/thermal/thermal_zone2/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone2/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone2/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone2/power/control
auto
/sys/class/thermal/thermal_zone2/available_policies
step_wise
/sys/class/thermal/thermal_zone2/policy
step_wise
/sys/class/thermal/thermal_zone2/trip_point_1_type
critical
/sys/class/thermal/thermal_zone2/k_d
0
/sys/class/thermal/thermal_zone2/sustainable_power
0
/sys/class/thermal/thermal_zone2/type
cpu2-thermal
/sys/class/thermal/thermal_zone2/offset
0
/sys/class/thermal/thermal_zone2/slope
1
/sys/class/thermal/thermal_zone2/trip_point_0_type
passive
/sys/class/thermal/thermal_zone2/k_po
0
/sys/class/thermal/thermal_zone2/integral_cutoff
0
/sys/class/thermal/thermal_zone2/k_i
0
/sys/class/thermal/thermal_zone2/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone2/k_pu
0
/sys/class/thermal/thermal_zone2/temp
32600
/sys/class/thermal/thermal_zone2/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone2/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone3/uevent
/sys/class/thermal/thermal_zone3/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone3/mode
enabled
/sys/class/thermal/thermal_zone3/power/runtime_active_time
0
/sys/class/thermal/thermal_zone3/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone3/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone3/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone3/power/control
auto
/sys/class/thermal/thermal_zone3/available_policies
step_wise
/sys/class/thermal/thermal_zone3/policy
step_wise
/sys/class/thermal/thermal_zone3/trip_point_1_type
critical
/sys/class/thermal/thermal_zone3/k_d
0
/sys/class/thermal/thermal_zone3/sustainable_power
0
/sys/class/thermal/thermal_zone3/type
cpu3-thermal
/sys/class/thermal/thermal_zone3/offset
0
/sys/class/thermal/thermal_zone3/slope
1
/sys/class/thermal/thermal_zone3/trip_point_0_type
passive
/sys/class/thermal/thermal_zone3/k_po
0
/sys/class/thermal/thermal_zone3/integral_cutoff
0
/sys/class/thermal/thermal_zone3/k_i
0
/sys/class/thermal/thermal_zone3/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone3/k_pu
0
/sys/class/thermal/thermal_zone3/temp
32900
/sys/class/thermal/thermal_zone3/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone3/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone4/uevent
/sys/class/thermal/thermal_zone4/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone4/mode
enabled
/sys/class/thermal/thermal_zone4/power/runtime_active_time
0
/sys/class/thermal/thermal_zone4/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone4/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone4/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone4/power/control
auto
/sys/class/thermal/thermal_zone4/available_policies
step_wise
/sys/class/thermal/thermal_zone4/policy
step_wise
/sys/class/thermal/thermal_zone4/trip_point_1_type
critical
/sys/class/thermal/thermal_zone4/k_d
0
/sys/class/thermal/thermal_zone4/sustainable_power
0
/sys/class/thermal/thermal_zone4/type
cpu4-thermal
/sys/class/thermal/thermal_zone4/offset
0
/sys/class/thermal/thermal_zone4/slope
1
/sys/class/thermal/thermal_zone4/trip_point_0_type
passive
/sys/class/thermal/thermal_zone4/k_po
0
/sys/class/thermal/thermal_zone4/integral_cutoff
0
/sys/class/thermal/thermal_zone4/k_i
0
/sys/class/thermal/thermal_zone4/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone4/k_pu
0
/sys/class/thermal/thermal_zone4/temp
32600
/sys/class/thermal/thermal_zone4/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone4/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone5/uevent
/sys/class/thermal/thermal_zone5/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone5/mode
enabled
/sys/class/thermal/thermal_zone5/power/runtime_active_time
0
/sys/class/thermal/thermal_zone5/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone5/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone5/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone5/power/control
auto
/sys/class/thermal/thermal_zone5/available_policies
step_wise
/sys/class/thermal/thermal_zone5/policy
step_wise
/sys/class/thermal/thermal_zone5/trip_point_1_type
critical
/sys/class/thermal/thermal_zone5/k_d
0
/sys/class/thermal/thermal_zone5/sustainable_power
0
/sys/class/thermal/thermal_zone5/type
cpu5-thermal
/sys/class/thermal/thermal_zone5/offset
0
/sys/class/thermal/thermal_zone5/slope
1
/sys/class/thermal/thermal_zone5/trip_point_0_type
passive
/sys/class/thermal/thermal_zone5/k_po
0
/sys/class/thermal/thermal_zone5/integral_cutoff
0
/sys/class/thermal/thermal_zone5/k_i
0
/sys/class/thermal/thermal_zone5/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone5/k_pu
0
/sys/class/thermal/thermal_zone5/temp
31700
/sys/class/thermal/thermal_zone5/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone5/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone6/uevent
/sys/class/thermal/thermal_zone6/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone6/mode
enabled
/sys/class/thermal/thermal_zone6/power/runtime_active_time
0
/sys/class/thermal/thermal_zone6/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone6/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone6/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone6/power/control
auto
/sys/class/thermal/thermal_zone6/available_policies
step_wise
/sys/class/thermal/thermal_zone6/policy
step_wise
/sys/class/thermal/thermal_zone6/trip_point_1_type
critical
/sys/class/thermal/thermal_zone6/k_d
0
/sys/class/thermal/thermal_zone6/sustainable_power
0
/sys/class/thermal/thermal_zone6/type
cpu6-thermal
/sys/class/thermal/thermal_zone6/offset
0
/sys/class/thermal/thermal_zone6/slope
1
/sys/class/thermal/thermal_zone6/trip_point_0_type
passive
/sys/class/thermal/thermal_zone6/k_po
0
/sys/class/thermal/thermal_zone6/integral_cutoff
0
/sys/class/thermal/thermal_zone6/k_i
0
/sys/class/thermal/thermal_zone6/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone6/k_pu
0
/sys/class/thermal/thermal_zone6/temp
32000
/sys/class/thermal/thermal_zone6/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone6/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone7/uevent
/sys/class/thermal/thermal_zone7/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone7/mode
enabled
/sys/class/thermal/thermal_zone7/power/runtime_active_time
0
/sys/class/thermal/thermal_zone7/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone7/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone7/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone7/power/control
auto
/sys/class/thermal/thermal_zone7/available_policies
step_wise
/sys/class/thermal/thermal_zone7/policy
step_wise
/sys/class/thermal/thermal_zone7/trip_point_1_type
critical
/sys/class/thermal/thermal_zone7/k_d
0
/sys/class/thermal/thermal_zone7/sustainable_power
0
/sys/class/thermal/thermal_zone7/type
cpu7-thermal
/sys/class/thermal/thermal_zone7/offset
0
/sys/class/thermal/thermal_zone7/slope
1
/sys/class/thermal/thermal_zone7/trip_point_0_type
passive
/sys/class/thermal/thermal_zone7/k_po
0
/sys/class/thermal/thermal_zone7/integral_cutoff
0
/sys/class/thermal/thermal_zone7/k_i
0
/sys/class/thermal/thermal_zone7/trip_point_1_temp
110000
/sys/class/thermal/thermal_zone7/k_pu
0
/sys/class/thermal/thermal_zone7/temp
32600
/sys/class/thermal/thermal_zone7/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone7/trip_point_0_temp
75000
/sys/class/thermal/thermal_zone8/uevent
/sys/class/thermal/thermal_zone8/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone8/passive
0
/sys/class/thermal/thermal_zone8/mode
enabled
/sys/class/thermal/thermal_zone8/power/runtime_active_time
0
/sys/class/thermal/thermal_zone8/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone8/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone8/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone8/power/control
auto
/sys/class/thermal/thermal_zone8/available_policies
step_wise
/sys/class/thermal/thermal_zone8/policy
step_wise
/sys/class/thermal/thermal_zone8/k_d
0
/sys/class/thermal/thermal_zone8/sustainable_power
0
/sys/class/thermal/thermal_zone8/type
gpu-thermal-bottom
/sys/class/thermal/thermal_zone8/offset
0
/sys/class/thermal/thermal_zone8/slope
1
/sys/class/thermal/thermal_zone8/trip_point_0_type
hot
/sys/class/thermal/thermal_zone8/k_po
0
/sys/class/thermal/thermal_zone8/integral_cutoff
0
/sys/class/thermal/thermal_zone8/k_i
0
/sys/class/thermal/thermal_zone8/k_pu
0
/sys/class/thermal/thermal_zone8/temp
31700
/sys/class/thermal/thermal_zone8/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone9/uevent
/sys/class/thermal/thermal_zone9/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone9/passive
0
/sys/class/thermal/thermal_zone9/mode
enabled
/sys/class/thermal/thermal_zone9/power/runtime_active_time
0
/sys/class/thermal/thermal_zone9/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone9/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone9/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone9/power/control
auto
/sys/class/thermal/thermal_zone9/available_policies
step_wise
/sys/class/thermal/thermal_zone9/policy
step_wise
/sys/class/thermal/thermal_zone9/k_d
0
/sys/class/thermal/thermal_zone9/sustainable_power
0
/sys/class/thermal/thermal_zone9/type
gpu-thermal-top
/sys/class/thermal/thermal_zone9/offset
0
/sys/class/thermal/thermal_zone9/slope
1
/sys/class/thermal/thermal_zone9/trip_point_0_type
hot
/sys/class/thermal/thermal_zone9/k_po
0
/sys/class/thermal/thermal_zone9/integral_cutoff
0
/sys/class/thermal/thermal_zone9/k_i
0
/sys/class/thermal/thermal_zone9/k_pu
0
/sys/class/thermal/thermal_zone9/temp
31700
/sys/class/thermal/thermal_zone9/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone10/uevent
/sys/class/thermal/thermal_zone10/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone10/passive
0
/sys/class/thermal/thermal_zone10/mode
enabled
/sys/class/thermal/thermal_zone10/power/runtime_active_time
0
/sys/class/thermal/thermal_zone10/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone10/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone10/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone10/power/control
auto
/sys/class/thermal/thermal_zone10/available_policies
step_wise
/sys/class/thermal/thermal_zone10/policy
step_wise
/sys/class/thermal/thermal_zone10/k_d
0
/sys/class/thermal/thermal_zone10/sustainable_power
0
/sys/class/thermal/thermal_zone10/type
clust0-mhm-thermal
/sys/class/thermal/thermal_zone10/offset
0
/sys/class/thermal/thermal_zone10/slope
1
/sys/class/thermal/thermal_zone10/trip_point_0_type
hot
/sys/class/thermal/thermal_zone10/k_po
0
/sys/class/thermal/thermal_zone10/integral_cutoff
0
/sys/class/thermal/thermal_zone10/k_i
0
/sys/class/thermal/thermal_zone10/k_pu
0
/sys/class/thermal/thermal_zone10/temp
32600
/sys/class/thermal/thermal_zone10/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone11/uevent
/sys/class/thermal/thermal_zone11/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone11/passive
0
/sys/class/thermal/thermal_zone11/mode
enabled
/sys/class/thermal/thermal_zone11/power/runtime_active_time
0
/sys/class/thermal/thermal_zone11/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone11/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone11/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone11/power/control
auto
/sys/class/thermal/thermal_zone11/available_policies
step_wise
/sys/class/thermal/thermal_zone11/policy
step_wise
/sys/class/thermal/thermal_zone11/k_d
0
/sys/class/thermal/thermal_zone11/sustainable_power
0
/sys/class/thermal/thermal_zone11/type
clust1-mhm-thermal
/sys/class/thermal/thermal_zone11/offset
0
/sys/class/thermal/thermal_zone11/slope
1
/sys/class/thermal/thermal_zone11/trip_point_0_type
hot
/sys/class/thermal/thermal_zone11/k_po
0
/sys/class/thermal/thermal_zone11/integral_cutoff
0
/sys/class/thermal/thermal_zone11/k_i
0
/sys/class/thermal/thermal_zone11/k_pu
0
/sys/class/thermal/thermal_zone11/temp
31700
/sys/class/thermal/thermal_zone11/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone12/uevent
/sys/class/thermal/thermal_zone12/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone12/passive
0
/sys/class/thermal/thermal_zone12/mode
enabled
/sys/class/thermal/thermal_zone12/power/runtime_active_time
0
/sys/class/thermal/thermal_zone12/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone12/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone12/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone12/power/control
auto
/sys/class/thermal/thermal_zone12/available_policies
step_wise
/sys/class/thermal/thermal_zone12/policy
step_wise
/sys/class/thermal/thermal_zone12/k_d
0
/sys/class/thermal/thermal_zone12/sustainable_power
0
/sys/class/thermal/thermal_zone12/type
cluster1-l2-thermal
/sys/class/thermal/thermal_zone12/offset
0
/sys/class/thermal/thermal_zone12/slope
1
/sys/class/thermal/thermal_zone12/trip_point_0_type
hot
/sys/class/thermal/thermal_zone12/k_po
0
/sys/class/thermal/thermal_zone12/integral_cutoff
0
/sys/class/thermal/thermal_zone12/k_i
0
/sys/class/thermal/thermal_zone12/k_pu
0
/sys/class/thermal/thermal_zone12/temp
31000
/sys/class/thermal/thermal_zone12/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone13/uevent
/sys/class/thermal/thermal_zone13/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone13/passive
0
/sys/class/thermal/thermal_zone13/mode
enabled
/sys/class/thermal/thermal_zone13/power/runtime_active_time
0
/sys/class/thermal/thermal_zone13/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone13/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone13/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone13/power/control
auto
/sys/class/thermal/thermal_zone13/available_policies
step_wise
/sys/class/thermal/thermal_zone13/policy
step_wise
/sys/class/thermal/thermal_zone13/k_d
0
/sys/class/thermal/thermal_zone13/sustainable_power
0
/sys/class/thermal/thermal_zone13/type
modem-thermal
/sys/class/thermal/thermal_zone13/offset
0
/sys/class/thermal/thermal_zone13/slope
1
/sys/class/thermal/thermal_zone13/trip_point_0_type
hot
/sys/class/thermal/thermal_zone13/k_po
0
/sys/class/thermal/thermal_zone13/integral_cutoff
0
/sys/class/thermal/thermal_zone13/k_i
0
/sys/class/thermal/thermal_zone13/k_pu
0
/sys/class/thermal/thermal_zone13/temp
31900
/sys/class/thermal/thermal_zone13/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone14/uevent
/sys/class/thermal/thermal_zone14/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone14/passive
0
/sys/class/thermal/thermal_zone14/mode
enabled
/sys/class/thermal/thermal_zone14/power/runtime_active_time
0
/sys/class/thermal/thermal_zone14/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone14/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone14/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone14/power/control
auto
/sys/class/thermal/thermal_zone14/available_policies
step_wise
/sys/class/thermal/thermal_zone14/policy
step_wise
/sys/class/thermal/thermal_zone14/k_d
0
/sys/class/thermal/thermal_zone14/sustainable_power
0
/sys/class/thermal/thermal_zone14/type
mem-thermal
/sys/class/thermal/thermal_zone14/offset
0
/sys/class/thermal/thermal_zone14/slope
1
/sys/class/thermal/thermal_zone14/trip_point_0_type
hot
/sys/class/thermal/thermal_zone14/k_po
0
/sys/class/thermal/thermal_zone14/integral_cutoff
0
/sys/class/thermal/thermal_zone14/k_i
0
/sys/class/thermal/thermal_zone14/k_pu
0
/sys/class/thermal/thermal_zone14/temp
31200
/sys/class/thermal/thermal_zone14/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone15/uevent
/sys/class/thermal/thermal_zone15/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone15/passive
0
/sys/class/thermal/thermal_zone15/mode
enabled
/sys/class/thermal/thermal_zone15/power/runtime_active_time
0
/sys/class/thermal/thermal_zone15/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone15/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone15/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone15/power/control
auto
/sys/class/thermal/thermal_zone15/available_policies
step_wise
/sys/class/thermal/thermal_zone15/policy
step_wise
/sys/class/thermal/thermal_zone15/k_d
0
/sys/class/thermal/thermal_zone15/sustainable_power
0
/sys/class/thermal/thermal_zone15/type
wlan-thermal
/sys/class/thermal/thermal_zone15/offset
0
/sys/class/thermal/thermal_zone15/slope
1
/sys/class/thermal/thermal_zone15/trip_point_0_type
hot
/sys/class/thermal/thermal_zone15/k_po
0
/sys/class/thermal/thermal_zone15/integral_cutoff
0
/sys/class/thermal/thermal_zone15/k_i
0
/sys/class/thermal/thermal_zone15/k_pu
0
/sys/class/thermal/thermal_zone15/temp
31600
/sys/class/thermal/thermal_zone15/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone16/uevent
/sys/class/thermal/thermal_zone16/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone16/passive
0
/sys/class/thermal/thermal_zone16/mode
enabled
/sys/class/thermal/thermal_zone16/power/runtime_active_time
0
/sys/class/thermal/thermal_zone16/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone16/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone16/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone16/power/control
auto
/sys/class/thermal/thermal_zone16/available_policies
step_wise
/sys/class/thermal/thermal_zone16/policy
step_wise
/sys/class/thermal/thermal_zone16/k_d
0
/sys/class/thermal/thermal_zone16/sustainable_power
0
/sys/class/thermal/thermal_zone16/type
q6-dsp-thermal
/sys/class/thermal/thermal_zone16/offset
0
/sys/class/thermal/thermal_zone16/slope
1
/sys/class/thermal/thermal_zone16/trip_point_0_type
hot
/sys/class/thermal/thermal_zone16/k_po
0
/sys/class/thermal/thermal_zone16/integral_cutoff
0
/sys/class/thermal/thermal_zone16/k_i
0
/sys/class/thermal/thermal_zone16/k_pu
0
/sys/class/thermal/thermal_zone16/temp
31200
/sys/class/thermal/thermal_zone16/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone17/uevent
/sys/class/thermal/thermal_zone17/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone17/passive
0
/sys/class/thermal/thermal_zone17/mode
enabled
/sys/class/thermal/thermal_zone17/power/runtime_active_time
0
/sys/class/thermal/thermal_zone17/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone17/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone17/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone17/power/control
auto
/sys/class/thermal/thermal_zone17/available_policies
step_wise
/sys/class/thermal/thermal_zone17/policy
step_wise
/sys/class/thermal/thermal_zone17/k_d
0
/sys/class/thermal/thermal_zone17/sustainable_power
0
/sys/class/thermal/thermal_zone17/type
camera-thermal
/sys/class/thermal/thermal_zone17/offset
0
/sys/class/thermal/thermal_zone17/slope
1
/sys/class/thermal/thermal_zone17/trip_point_0_type
hot
/sys/class/thermal/thermal_zone17/k_po
0
/sys/class/thermal/thermal_zone17/integral_cutoff
0
/sys/class/thermal/thermal_zone17/k_i
0
/sys/class/thermal/thermal_zone17/k_pu
0
/sys/class/thermal/thermal_zone17/temp
30900
/sys/class/thermal/thermal_zone17/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone18/uevent
/sys/class/thermal/thermal_zone18/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone18/passive
0
/sys/class/thermal/thermal_zone18/mode
enabled
/sys/class/thermal/thermal_zone18/power/runtime_active_time
0
/sys/class/thermal/thermal_zone18/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone18/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone18/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone18/power/control
auto
/sys/class/thermal/thermal_zone18/available_policies
step_wise
/sys/class/thermal/thermal_zone18/policy
step_wise
/sys/class/thermal/thermal_zone18/k_d
0
/sys/class/thermal/thermal_zone18/sustainable_power
0
/sys/class/thermal/thermal_zone18/type
multimedia-thermal
/sys/class/thermal/thermal_zone18/offset
0
/sys/class/thermal/thermal_zone18/slope
1
/sys/class/thermal/thermal_zone18/trip_point_0_type
hot
/sys/class/thermal/thermal_zone18/k_po
0
/sys/class/thermal/thermal_zone18/integral_cutoff
0
/sys/class/thermal/thermal_zone18/k_i
0
/sys/class/thermal/thermal_zone18/k_pu
0
/sys/class/thermal/thermal_zone18/temp
31200
/sys/class/thermal/thermal_zone18/trip_point_0_temp
90000
/sys/class/thermal/thermal_zone19/uevent
/sys/class/thermal/thermal_zone19/trip_point_0_hyst
2000
/sys/class/thermal/thermal_zone19/mode
disabled
/sys/class/thermal/thermal_zone19/power/runtime_active_time
0
/sys/class/thermal/thermal_zone19/power/runtime_status
unsupported
/sys/class/thermal/thermal_zone19/power/autosuspend_delay_ms
cat: read error: Input/output error
/sys/class/thermal/thermal_zone19/power/runtime_suspended_time
0
/sys/class/thermal/thermal_zone19/power/control
auto
/sys/class/thermal/thermal_zone19/available_policies
step_wise
/sys/class/thermal/thermal_zone19/policy
step_wise
/sys/class/thermal/thermal_zone19/trip_point_1_type
critical
/sys/class/thermal/thermal_zone19/k_d
0
/sys/class/thermal/thermal_zone19/sustainable_power
0
/sys/class/thermal/thermal_zone19/type
pm8998
/sys/class/thermal/thermal_zone19/offset
0
/sys/class/thermal/thermal_zone19/slope
1
/sys/class/thermal/thermal_zone19/trip_point_0_type
passive
/sys/class/thermal/thermal_zone19/k_po
0
/sys/class/thermal/thermal_zone19/integral_cutoff
0
/sys/class/thermal/thermal_zone19/k_i
0
/sys/class/thermal/thermal_zone19/trip_point_1_temp
125000
/sys/class/thermal/thermal_zone19/k_pu
0
/sys/class/thermal/thermal_zone19/temp
cat: read error: Invalid argument
/sys/class/thermal/thermal_zone19/trip_point_1_hyst
2000
/sys/class/thermal/thermal_zone19/trip_point_0_temp
105000

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

[Marc Gonzalez]

On 25/04/2019 08:31, Amit Kucheria wrote:

> [PATCH 3/3] arm64: dts: msm8998: thermal: Restrict thermal zone name length to under 20
> 
> The thermal core restricts names of thermal zones to under 20
> characters. Fix the names for a couple of msm8998 thermal zones.
> 
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/msm8998.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> index 062a93a12198..01757829d5f3 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> @@ -536,7 +536,7 @@
>  			};
>  		};
>  
> -		cluster0-mhm-thermal {
> +		clust0-mhm-thermal {
>  			polling-delay-passive = <250>;
>  			polling-delay = <1000>;
>  
> @@ -551,7 +551,7 @@
>  			};
>  		};
>  
> -		cluster1-mhm-thermal {
> +		clust1-mhm-thermal {
>  			polling-delay-passive = <250>;
>  			polling-delay = <1000>;
>  

Wouldn't it be better to drop the "-thermal" suffix than to chop characters
off from the actual description?

Or would it make sense to increase the 20-char limit to 24?
=> Probably impossible without breaking the user-space ABI, since
THERMAL_NAME_LENGTH is defined in include/uapi/linux/thermal.h

Anyway, for msm8998 patches, you have my

Tested-by: Marc Gonzalez <marc.w.gonzalez@free.fr>

Regards.

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

[Amit Kucheria]

On Thu, Apr 25, 2019 at 6:36 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
>
> On 25/04/2019 08:31, Amit Kucheria wrote:
>
> > [PATCH 3/3] arm64: dts: msm8998: thermal: Restrict thermal zone name length to under 20
> >
> > The thermal core restricts names of thermal zones to under 20
> > characters. Fix the names for a couple of msm8998 thermal zones.
> >
> > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> > ---
> >  arch/arm64/boot/dts/qcom/msm8998.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> > index 062a93a12198..01757829d5f3 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> > @@ -536,7 +536,7 @@
> >                       };
> >               };
> >
> > -             cluster0-mhm-thermal {
> > +             clust0-mhm-thermal {
> >                       polling-delay-passive = <250>;
> >                       polling-delay = <1000>;
> >
> > @@ -551,7 +551,7 @@
> >                       };
> >               };
> >
> > -             cluster1-mhm-thermal {
> > +             clust1-mhm-thermal {
> >                       polling-delay-passive = <250>;
> >                       polling-delay = <1000>;
> >
>
> Wouldn't it be better to drop the "-thermal" suffix than to chop characters
> off from the actual description?

Probably a good idea, but it will perturb my OCD and cause a large
search and replace to replace all thermal zones names in this series.
:-) I want to keep it consistent across all boards.

I don't think Andy would like that too much.

> Or would it make sense to increase the 20-char limit to 24?
> => Probably impossible without breaking the user-space ABI, since
> THERMAL_NAME_LENGTH is defined in include/uapi/linux/thermal.h

Yes, I abandoned that path quickly after seeing where this was
defined, but I have a follow-on patch to make this a compile-time bug
rather than wondering why the thermal zone failed at runtime.

> Anyway, for msm8998 patches, you have my
>
> Tested-by: Marc Gonzalez <marc.w.gonzalez@free.fr>

Thanks a lot for testing.

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

[Andy Gross]

On Tue, Apr 23, 2019 at 06:26:40PM +0530, Amit Kucheria wrote:
> On Tue, Apr 23, 2019 at 3:01 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
> >
> > On 02/04/2019 20:46, Amit Kucheria wrote:
> >
> > > On Tue, Apr 2, 2019 at 8:58 PM Marc Gonzalez wrote:
> > >>
> > >> On 29/03/2019 11:12, Amit Kucheria wrote:
> > >>
> > >>> Changes since v1:
> > >>> - Devices that are not associated with cooling-maps use the 'hot' type
> > >>> - Remove critical trip from such devices too and restrict that type of CPUs
> > >>> - For 8916, add the sensor on the modem
> > >>>
> > >>> Description:
> > >>> - Expose all temperature sensors on msm8916, msm996, msm8998, sdm845
> > >>> - split up the register address map for msm8998
> > >>> - standardize names of the various thermal-zones across boards to make it
> > >>>   easy for test scripts to parse
> > >>
> > >> This is what I see on msm8998 with your patch series applied on top of
> > >> yesterday's next:
> > >>
> > >> # dmesg | grep of_parse_thermal_zones
> > >> of_parse_thermal_zones: build cpu0-thermal zone 0
> > >> of_parse_thermal_zones: build cpu1-thermal zone 0
> > >> of_parse_thermal_zones: build cpu2-thermal zone 0
> > >> of_parse_thermal_zones: build cpu3-thermal zone 0
> > >> of_parse_thermal_zones: build cpu4-thermal zone 0
> > >> of_parse_thermal_zones: build cpu5-thermal zone 0
> > >> of_parse_thermal_zones: build cpu6-thermal zone 0
> > >> of_parse_thermal_zones: build cpu7-thermal zone 0
> > >> of_parse_thermal_zones: build gpu-thermal-bottom zone 0
> > >> of_parse_thermal_zones: build gpu-thermal-top zone 0
> > >> of_parse_thermal_zones: build cluster0-mhm-thermal zone -22
> > >> of_parse_thermal_zones: build cluster1-mhm-thermal zone -22
> > >> of_parse_thermal_zones: build cluster1-l2-thermal zone 0
> > >> of_parse_thermal_zones: build modem-thermal zone 0
> > >> of_parse_thermal_zones: build mem-thermal zone 0
> > >> of_parse_thermal_zones: build wlan-thermal zone 0
> > >> of_parse_thermal_zones: build q6-dsp-thermal zone 0
> > >> of_parse_thermal_zones: build camera-thermal zone 0
> > >> of_parse_thermal_zones: build multimedia-thermal zone 0
> > >> of_parse_thermal_zones: build pm8998 zone 0
> > >> of_parse_thermal_zones: build battery-thermal zone 0
> > >> of_parse_thermal_zones: build skin-thermal zone 0
> > >>
> > >> NB: -EINVAL for cluster0-mhm-thermal and cluster1-mhm-thermal
> > >>
> > >>
> > >> # cat /sys/devices/virtual/thermal/thermal_zone*/temp
> > >> 35800
> > >> 35200
> > >> 34500
> > >> 34800
> > >> 34500
> > >> 34100
> > >> 34100
> > >> 33500
> > >> 33800
> > >> cat: /sys/devices/virtual/thermal/thermal_zone17/temp: Invalid argument
> > >> 36100
> > >> cat: /sys/devices/virtual/thermal/thermal_zone19/temp: Invalid argument
> > >> 35500
> > >> 36100
> > >> 35800
> > >> 35200
> > >> 35500
> > >> 36100
> > >> cat: /sys/devices/virtual/thermal/thermal_zone8/temp: Invalid argument
> > >> cat: /sys/devices/virtual/thermal/thermal_zone9/temp: Invalid argument
> > >>
> > >>
> > >> Are the failures expected?
> > >> (cluster*-mhm-thermal and thermal_zone*/temp)
> > >
> > > No they are not. Unfortunately, I didn't have HW to test, so
> > > appreciate the help with testing. I'll check the 8, 9, 17 and 19 again
> > > before resubmitting.
> >
> > Looks like Andy merged this series?
> 
> Argh! my bad, I completely forgot about the need to fix this up. I
> need to get me one of these boards.

Hey I have a second set being worked up.  If you get me the fixups I can add
them to that.  Or I can revert.  Let me know.

> We can either revert that one patch for the msm8998, but I think it
> might be better if I send a fixup patch that could fixup those 4 zones
> instead.

Sorry to miss the conversation.  I had these queued up on a branch for a while
now and totally missed the convo on this.  In any case, we can get it fixed up.


Andy