All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big
@ 2021-09-27 16:07 Aurabindo Pillai
  2021-09-27 17:21 ` Mark Yacoub
                   ` (2 more replies)
  0 siblings, 3 replies; 19+ messages in thread
From: Aurabindo Pillai @ 2021-09-27 16:07 UTC (permalink / raw)
  To: igt-dev, markyacoub; +Cc: rodrigo.siqueira

[Why]
The rationale of the test does not hold true for AMD hardware. The
aperture size calculation has an upper bound check which is done through
i915 specific IOCTL. Hence this part of subtest must be moved
out of the platform agnostic tests. Moreover, AMD hardware
supports buffers larger than aperture size.

[How]
Skip the bo-too-big subtest unless its run on i915 as the test fails on
AMD, VKMS and VC4

Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
 tests/kms_flip.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 54137871..20112de1 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1290,6 +1290,7 @@ static void __run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
 	/* 256 MB is usually the maximum mappable aperture,
 	 * (make it 4x times that to ensure failure) */
 	if (o->flags & TEST_BO_TOOBIG) {
+		igt_skip_on(!is_i915_device(drm_fd));
 		bo_size = 4*gem_mappable_aperture_size(drm_fd);
 		igt_require(bo_size < gem_global_aperture_size(drm_fd));
 	}
-- 
2.30.2

^ permalink raw reply related	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2021-09-28 15:37 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27 16:07 [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big Aurabindo Pillai
2021-09-27 17:21 ` Mark Yacoub
2021-09-27 17:28   ` Pillai, Aurabindo
2021-09-27 17:34     ` Mark Yacoub
2021-09-27 19:10       ` Pillai, Aurabindo
2021-09-27 19:12         ` Mark Yacoub
2021-09-27 19:23           ` Pillai, Aurabindo
2021-09-28  9:15         ` Petri Latvala
2021-09-28 13:35           ` Aurabindo Pillai
2021-09-28 13:53             ` Petri Latvala
2021-09-28 14:05               ` Aurabindo Pillai
2021-09-28 14:43                 ` Rodrigo Siqueira
2021-09-28 14:48                   ` Mark Yacoub
2021-09-28 15:17                     ` Petri Latvala
2021-09-28 15:23                       ` Mark Yacoub
2021-09-28 15:37                         ` Petri Latvala
2021-09-28 15:37                           ` Mark Yacoub
2021-09-27 17:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-09-27 20:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.