[igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Aurabindo Pillai]

[Why]
The rationale of the test does not hold true for AMD hardware. The
aperture size calculation has an upper bound check which is done through
i915 specific IOCTL. Hence this part of subtest must be moved
out of the platform agnostic tests. Moreover, AMD hardware
supports buffers larger than aperture size.

[How]
Skip the bo-too-big subtest unless its run on i915 as the test fails on
AMD, VKMS and VC4

Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
 tests/kms_flip.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 54137871..20112de1 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1290,6 +1290,7 @@ static void __run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
 	/* 256 MB is usually the maximum mappable aperture,
 	 * (make it 4x times that to ensure failure) */
 	if (o->flags & TEST_BO_TOOBIG) {
+		igt_skip_on(!is_i915_device(drm_fd));
 		bo_size = 4*gem_mappable_aperture_size(drm_fd);
 		igt_require(bo_size < gem_global_aperture_size(drm_fd));
 	}
-- 
2.30.2

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Mark Yacoub]

On Mon, Sep 27, 2021 at 12:07 PM Aurabindo Pillai
<aurabindo.pillai@amd.com> wrote:
>
> [Why]
> The rationale of the test does not hold true for AMD hardware. The
> aperture size calculation has an upper bound check which is done through
> i915 specific IOCTL. Hence this part of subtest must be moved
> out of the platform agnostic tests. Moreover, AMD hardware
> supports buffers larger than aperture size.
>
> [How]
> Skip the bo-too-big subtest unless its run on i915 as the test fails on
> AMD, VKMS and VC4
>
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> ---
>  tests/kms_flip.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 54137871..20112de1 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1290,6 +1290,7 @@ static void __run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
>         /* 256 MB is usually the maximum mappable aperture,
>          * (make it 4x times that to ensure failure) */
>         if (o->flags & TEST_BO_TOOBIG) {
There is also another place where TEST_BO_TOOBIG is used, should we
skip this one as well or it's only this part?
> +               igt_skip_on(!is_i915_device(drm_fd));
>                 bo_size = 4*gem_mappable_aperture_size(drm_fd);
>                 igt_require(bo_size < gem_global_aperture_size(drm_fd));
>         }
> --
> 2.30.2
>

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip : skip subtest bo-too-big

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 1559 bytes --]

== Series Details ==

Series: tests/kms_flip : skip subtest bo-too-big
URL   : https://patchwork.freedesktop.org/series/95115/
State : success

== Summary ==

CI Bug Log - changes from IGT_6220 -> IGTPW_6265
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/index.html

Known issues
------------

  Here are the changes found in IGTPW_6265 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_chamelium@hdmi-edid-read:
    - fi-icl-u2:          [PASS][1] -> [DMESG-WARN][2] ([i915#2868])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/fi-icl-u2/igt@kms_chamelium@hdmi-edid-read.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/fi-icl-u2/igt@kms_chamelium@hdmi-edid-read.html

  
  [i915#2868]: https://gitlab.freedesktop.org/drm/intel/issues/2868


Participating hosts (36 -> 33)
------------------------------

  Missing    (3): fi-tgl-1115g4 fi-bsw-cyan fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6220 -> IGTPW_6265

  CI-20190529: 20190529
  CI_DRM_10648: 73d93dcb0d48bb76af25ca3f7149598e4bc68098 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_6265: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/index.html
  IGT_6220: 357f5887f0b42d780ec4352600670d0c733c4cf7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/index.html

[-- Attachment #2: Type: text/html, Size: 2143 bytes --]

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Pillai, Aurabindo]

[-- Attachment #1: Type: text/plain, Size: 2052 bytes --]

[AMD Official Use Only]

Hi Mark,


Both bo-too-big and bo-too-big-interruptible shall be skipped with this patch. The other location where TEST_BO_TOOBIG is mentioned is in the same function.

--

Regards,
Jay
________________________________
From: Mark Yacoub <markyacoub@chromium.org>
Sent: Monday, September 27, 2021 1:21 PM
To: Pillai, Aurabindo <Aurabindo.Pillai@amd.com>
Cc: Development mailing list for IGT GPU Tools <igt-dev@lists.freedesktop.org>; Mark Yacoub <markyacoub@google.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

On Mon, Sep 27, 2021 at 12:07 PM Aurabindo Pillai
<aurabindo.pillai@amd.com> wrote:
>
> [Why]
> The rationale of the test does not hold true for AMD hardware. The
> aperture size calculation has an upper bound check which is done through
> i915 specific IOCTL. Hence this part of subtest must be moved
> out of the platform agnostic tests. Moreover, AMD hardware
> supports buffers larger than aperture size.
>
> [How]
> Skip the bo-too-big subtest unless its run on i915 as the test fails on
> AMD, VKMS and VC4
>
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> ---
>  tests/kms_flip.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 54137871..20112de1 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1290,6 +1290,7 @@ static void __run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
>         /* 256 MB is usually the maximum mappable aperture,
>          * (make it 4x times that to ensure failure) */
>         if (o->flags & TEST_BO_TOOBIG) {
There is also another place where TEST_BO_TOOBIG is used, should we
skip this one as well or it's only this part?
> +               igt_skip_on(!is_i915_device(drm_fd));
>                 bo_size = 4*gem_mappable_aperture_size(drm_fd);
>                 igt_require(bo_size < gem_global_aperture_size(drm_fd));
>         }
> --
> 2.30.2
>

[-- Attachment #2: Type: text/html, Size: 4717 bytes --]

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Mark Yacoub]

so for the sake of consistency, I'm wondering if we can skip the test
the same way we skip other tests such as
```
if (tests[i].flags & TEST_NO_2X_OUTPUT)
continue;
```
because we're not failing a certain condition but a whole test, it
might be better not to run the test in the first place unless it's
intel.
So in both main loops that call run_test we can do if
if (tests[i].flags & TEST_BO_TOOBIG && !intel)
    continue;
this way we're not too worried where the flag would be used across the
test and not skip halfway through a test.

On Mon, Sep 27, 2021 at 1:28 PM Pillai, Aurabindo
<Aurabindo.Pillai@amd.com> wrote:
>
> [AMD Official Use Only]
>
>
> Hi Mark,
>
>
> Both bo-too-big and bo-too-big-interruptible shall be skipped with this patch. The other location where TEST_BO_TOOBIG is mentioned is in the same function.
>
> --
>
> Regards,
> Jay
> ________________________________
> From: Mark Yacoub <markyacoub@chromium.org>
> Sent: Monday, September 27, 2021 1:21 PM
> To: Pillai, Aurabindo <Aurabindo.Pillai@amd.com>
> Cc: Development mailing list for IGT GPU Tools <igt-dev@lists.freedesktop.org>; Mark Yacoub <markyacoub@google.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big
>
> On Mon, Sep 27, 2021 at 12:07 PM Aurabindo Pillai
> <aurabindo.pillai@amd.com> wrote:
> >
> > [Why]
> > The rationale of the test does not hold true for AMD hardware. The
> > aperture size calculation has an upper bound check which is done through
> > i915 specific IOCTL. Hence this part of subtest must be moved
> > out of the platform agnostic tests. Moreover, AMD hardware
> > supports buffers larger than aperture size.
> >
> > [How]
> > Skip the bo-too-big subtest unless its run on i915 as the test fails on
> > AMD, VKMS and VC4
> >
> > Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> > ---
> >  tests/kms_flip.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> > index 54137871..20112de1 100755
> > --- a/tests/kms_flip.c
> > +++ b/tests/kms_flip.c
> > @@ -1290,6 +1290,7 @@ static void __run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
> >         /* 256 MB is usually the maximum mappable aperture,
> >          * (make it 4x times that to ensure failure) */
> >         if (o->flags & TEST_BO_TOOBIG) {
> There is also another place where TEST_BO_TOOBIG is used, should we
> skip this one as well or it's only this part?
> > +               igt_skip_on(!is_i915_device(drm_fd));
> >                 bo_size = 4*gem_mappable_aperture_size(drm_fd);
> >                 igt_require(bo_size < gem_global_aperture_size(drm_fd));
> >         }
> > --
> > 2.30.2
> >

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Pillai, Aurabindo]

[-- Attachment #1: Type: text/plain, Size: 3458 bytes --]

[AMD Official Use Only]

Skipping using the continue statement has the side effect of this subtest being absent from the list of subtests, when running the test executable with paramter --list-subtest. Is that okay ?

--

Regards,
Jay
________________________________
From: Mark Yacoub <markyacoub@chromium.org>
Sent: Monday, September 27, 2021 1:34 PM
To: Pillai, Aurabindo <Aurabindo.Pillai@amd.com>
Cc: Development mailing list for IGT GPU Tools <igt-dev@lists.freedesktop.org>; Mark Yacoub <markyacoub@google.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

so for the sake of consistency, I'm wondering if we can skip the test
the same way we skip other tests such as
```
if (tests[i].flags & TEST_NO_2X_OUTPUT)
continue;
```
because we're not failing a certain condition but a whole test, it
might be better not to run the test in the first place unless it's
intel.
So in both main loops that call run_test we can do if
if (tests[i].flags & TEST_BO_TOOBIG && !intel)
    continue;
this way we're not too worried where the flag would be used across the
test and not skip halfway through a test.

On Mon, Sep 27, 2021 at 1:28 PM Pillai, Aurabindo
<Aurabindo.Pillai@amd.com> wrote:
>
> [AMD Official Use Only]
>
>
> Hi Mark,
>
>
> Both bo-too-big and bo-too-big-interruptible shall be skipped with this patch. The other location where TEST_BO_TOOBIG is mentioned is in the same function.
>
> --
>
> Regards,
> Jay
> ________________________________
> From: Mark Yacoub <markyacoub@chromium.org>
> Sent: Monday, September 27, 2021 1:21 PM
> To: Pillai, Aurabindo <Aurabindo.Pillai@amd.com>
> Cc: Development mailing list for IGT GPU Tools <igt-dev@lists.freedesktop.org>; Mark Yacoub <markyacoub@google.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big
>
> On Mon, Sep 27, 2021 at 12:07 PM Aurabindo Pillai
> <aurabindo.pillai@amd.com> wrote:
> >
> > [Why]
> > The rationale of the test does not hold true for AMD hardware. The
> > aperture size calculation has an upper bound check which is done through
> > i915 specific IOCTL. Hence this part of subtest must be moved
> > out of the platform agnostic tests. Moreover, AMD hardware
> > supports buffers larger than aperture size.
> >
> > [How]
> > Skip the bo-too-big subtest unless its run on i915 as the test fails on
> > AMD, VKMS and VC4
> >
> > Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> > ---
> >  tests/kms_flip.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> > index 54137871..20112de1 100755
> > --- a/tests/kms_flip.c
> > +++ b/tests/kms_flip.c
> > @@ -1290,6 +1290,7 @@ static void __run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
> >         /* 256 MB is usually the maximum mappable aperture,
> >          * (make it 4x times that to ensure failure) */
> >         if (o->flags & TEST_BO_TOOBIG) {
> There is also another place where TEST_BO_TOOBIG is used, should we
> skip this one as well or it's only this part?
> > +               igt_skip_on(!is_i915_device(drm_fd));
> >                 bo_size = 4*gem_mappable_aperture_size(drm_fd);
> >                 igt_require(bo_size < gem_global_aperture_size(drm_fd));
> >         }
> > --
> > 2.30.2
> >

[-- Attachment #2: Type: text/html, Size: 6047 bytes --]

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Mark Yacoub]

I'm not 100% sure but personally if I'm running the test on an AMD
device, I don't really care about seeing a subtest that I'm not
interested in.

On Mon, Sep 27, 2021 at 3:10 PM Pillai, Aurabindo
<Aurabindo.Pillai@amd.com> wrote:
>
> [AMD Official Use Only]
>
>
> Skipping using the continue statement has the side effect of this subtest being absent from the list of subtests, when running the test executable with paramter --list-subtest. Is that okay ?
>
> --
>
> Regards,
> Jay
> ________________________________
> From: Mark Yacoub <markyacoub@chromium.org>
> Sent: Monday, September 27, 2021 1:34 PM
> To: Pillai, Aurabindo <Aurabindo.Pillai@amd.com>
> Cc: Development mailing list for IGT GPU Tools <igt-dev@lists.freedesktop.org>; Mark Yacoub <markyacoub@google.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big
>
> so for the sake of consistency, I'm wondering if we can skip the test
> the same way we skip other tests such as
> ```
> if (tests[i].flags & TEST_NO_2X_OUTPUT)
> continue;
> ```
> because we're not failing a certain condition but a whole test, it
> might be better not to run the test in the first place unless it's
> intel.
> So in both main loops that call run_test we can do if
> if (tests[i].flags & TEST_BO_TOOBIG && !intel)
>     continue;
> this way we're not too worried where the flag would be used across the
> test and not skip halfway through a test.
>
> On Mon, Sep 27, 2021 at 1:28 PM Pillai, Aurabindo
> <Aurabindo.Pillai@amd.com> wrote:
> >
> > [AMD Official Use Only]
> >
> >
> > Hi Mark,
> >
> >
> > Both bo-too-big and bo-too-big-interruptible shall be skipped with this patch. The other location where TEST_BO_TOOBIG is mentioned is in the same function.
> >
> > --
> >
> > Regards,
> > Jay
> > ________________________________
> > From: Mark Yacoub <markyacoub@chromium.org>
> > Sent: Monday, September 27, 2021 1:21 PM
> > To: Pillai, Aurabindo <Aurabindo.Pillai@amd.com>
> > Cc: Development mailing list for IGT GPU Tools <igt-dev@lists.freedesktop.org>; Mark Yacoub <markyacoub@google.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>
> > Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big
> >
> > On Mon, Sep 27, 2021 at 12:07 PM Aurabindo Pillai
> > <aurabindo.pillai@amd.com> wrote:
> > >
> > > [Why]
> > > The rationale of the test does not hold true for AMD hardware. The
> > > aperture size calculation has an upper bound check which is done through
> > > i915 specific IOCTL. Hence this part of subtest must be moved
> > > out of the platform agnostic tests. Moreover, AMD hardware
> > > supports buffers larger than aperture size.
> > >
> > > [How]
> > > Skip the bo-too-big subtest unless its run on i915 as the test fails on
> > > AMD, VKMS and VC4
> > >
> > > Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> > > ---
> > >  tests/kms_flip.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> > > index 54137871..20112de1 100755
> > > --- a/tests/kms_flip.c
> > > +++ b/tests/kms_flip.c
> > > @@ -1290,6 +1290,7 @@ static void __run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
> > >         /* 256 MB is usually the maximum mappable aperture,
> > >          * (make it 4x times that to ensure failure) */
> > >         if (o->flags & TEST_BO_TOOBIG) {
> > There is also another place where TEST_BO_TOOBIG is used, should we
> > skip this one as well or it's only this part?
> > > +               igt_skip_on(!is_i915_device(drm_fd));
> > >                 bo_size = 4*gem_mappable_aperture_size(drm_fd);
> > >                 igt_require(bo_size < gem_global_aperture_size(drm_fd));
> > >         }
> > > --
> > > 2.30.2
> > >

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Pillai, Aurabindo]

[-- Attachment #1: Type: text/plain, Size: 4379 bytes --]

[AMD Official Use Only]

Sure, that makes sense. Will send a v2

--

Regards,
Jay

________________________________
From: Mark Yacoub <markyacoub@chromium.org>
Sent: Monday, September 27, 2021 3:12 PM
To: Pillai, Aurabindo <Aurabindo.Pillai@amd.com>
Cc: Development mailing list for IGT GPU Tools <igt-dev@lists.freedesktop.org>; Mark Yacoub <markyacoub@google.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

I'm not 100% sure but personally if I'm running the test on an AMD
device, I don't really care about seeing a subtest that I'm not
interested in.

On Mon, Sep 27, 2021 at 3:10 PM Pillai, Aurabindo
<Aurabindo.Pillai@amd.com> wrote:
>
> [AMD Official Use Only]
>
>
> Skipping using the continue statement has the side effect of this subtest being absent from the list of subtests, when running the test executable with paramter --list-subtest. Is that okay ?
>
> --
>
> Regards,
> Jay
> ________________________________
> From: Mark Yacoub <markyacoub@chromium.org>
> Sent: Monday, September 27, 2021 1:34 PM
> To: Pillai, Aurabindo <Aurabindo.Pillai@amd.com>
> Cc: Development mailing list for IGT GPU Tools <igt-dev@lists.freedesktop.org>; Mark Yacoub <markyacoub@google.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big
>
> so for the sake of consistency, I'm wondering if we can skip the test
> the same way we skip other tests such as
> ```
> if (tests[i].flags & TEST_NO_2X_OUTPUT)
> continue;
> ```
> because we're not failing a certain condition but a whole test, it
> might be better not to run the test in the first place unless it's
> intel.
> So in both main loops that call run_test we can do if
> if (tests[i].flags & TEST_BO_TOOBIG && !intel)
>     continue;
> this way we're not too worried where the flag would be used across the
> test and not skip halfway through a test.
>
> On Mon, Sep 27, 2021 at 1:28 PM Pillai, Aurabindo
> <Aurabindo.Pillai@amd.com> wrote:
> >
> > [AMD Official Use Only]
> >
> >
> > Hi Mark,
> >
> >
> > Both bo-too-big and bo-too-big-interruptible shall be skipped with this patch. The other location where TEST_BO_TOOBIG is mentioned is in the same function.
> >
> > --
> >
> > Regards,
> > Jay
> > ________________________________
> > From: Mark Yacoub <markyacoub@chromium.org>
> > Sent: Monday, September 27, 2021 1:21 PM
> > To: Pillai, Aurabindo <Aurabindo.Pillai@amd.com>
> > Cc: Development mailing list for IGT GPU Tools <igt-dev@lists.freedesktop.org>; Mark Yacoub <markyacoub@google.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>
> > Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big
> >
> > On Mon, Sep 27, 2021 at 12:07 PM Aurabindo Pillai
> > <aurabindo.pillai@amd.com> wrote:
> > >
> > > [Why]
> > > The rationale of the test does not hold true for AMD hardware. The
> > > aperture size calculation has an upper bound check which is done through
> > > i915 specific IOCTL. Hence this part of subtest must be moved
> > > out of the platform agnostic tests. Moreover, AMD hardware
> > > supports buffers larger than aperture size.
> > >
> > > [How]
> > > Skip the bo-too-big subtest unless its run on i915 as the test fails on
> > > AMD, VKMS and VC4
> > >
> > > Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> > > ---
> > >  tests/kms_flip.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> > > index 54137871..20112de1 100755
> > > --- a/tests/kms_flip.c
> > > +++ b/tests/kms_flip.c
> > > @@ -1290,6 +1290,7 @@ static void __run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
> > >         /* 256 MB is usually the maximum mappable aperture,
> > >          * (make it 4x times that to ensure failure) */
> > >         if (o->flags & TEST_BO_TOOBIG) {
> > There is also another place where TEST_BO_TOOBIG is used, should we
> > skip this one as well or it's only this part?
> > > +               igt_skip_on(!is_i915_device(drm_fd));
> > >                 bo_size = 4*gem_mappable_aperture_size(drm_fd);
> > >                 igt_require(bo_size < gem_global_aperture_size(drm_fd));
> > >         }
> > > --
> > > 2.30.2
> > >

[-- Attachment #2: Type: text/html, Size: 7492 bytes --]

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_flip : skip subtest bo-too-big

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 30258 bytes --]

== Series Details ==

Series: tests/kms_flip : skip subtest bo-too-big
URL   : https://patchwork.freedesktop.org/series/95115/
State : success

== Summary ==

CI Bug Log - changes from IGT_6220_full -> IGTPW_6265_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/index.html

Known issues
------------

  Here are the changes found in IGTPW_6265_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@feature_discovery@psr2:
    - shard-iclb:         [PASS][1] -> [SKIP][2] ([i915#658])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-iclb2/igt@feature_discovery@psr2.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb4/igt@feature_discovery@psr2.html

  * igt@gem_ctx_persistence@legacy-engines-persistence:
    - shard-snb:          NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +2 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-snb6/igt@gem_ctx_persistence@legacy-engines-persistence.html

  * igt@gem_eio@unwedge-stress:
    - shard-iclb:         [PASS][4] -> [TIMEOUT][5] ([i915#2369] / [i915#2481] / [i915#3070])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-iclb7/igt@gem_eio@unwedge-stress.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb1/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_fair@basic-deadline:
    - shard-glk:          [PASS][6] -> [FAIL][7] ([i915#2846])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-glk1/igt@gem_exec_fair@basic-deadline.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-glk7/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-none-share@rcs0:
    - shard-tglb:         [PASS][8] -> [FAIL][9] ([i915#2842])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-tglb8/igt@gem_exec_fair@basic-none-share@rcs0.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb6/igt@gem_exec_fair@basic-none-share@rcs0.html
    - shard-glk:          [PASS][10] -> [FAIL][11] ([i915#2842])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-glk7/igt@gem_exec_fair@basic-none-share@rcs0.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-glk9/igt@gem_exec_fair@basic-none-share@rcs0.html

  * igt@gem_exec_fair@basic-none-vip@rcs0:
    - shard-tglb:         NOTRUN -> [FAIL][12] ([i915#2842]) +7 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb3/igt@gem_exec_fair@basic-none-vip@rcs0.html

  * igt@gem_exec_fair@basic-none@vcs0:
    - shard-apl:          NOTRUN -> [FAIL][13] ([i915#2842])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-apl6/igt@gem_exec_fair@basic-none@vcs0.html

  * igt@gem_exec_fair@basic-pace@vecs0:
    - shard-kbl:          [PASS][14] -> [SKIP][15] ([fdo#109271])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl3/igt@gem_exec_fair@basic-pace@vecs0.html

  * igt@gem_exec_fair@basic-throttle@rcs0:
    - shard-glk:          NOTRUN -> [FAIL][16] ([i915#2842])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-glk3/igt@gem_exec_fair@basic-throttle@rcs0.html
    - shard-iclb:         NOTRUN -> [FAIL][17] ([i915#2849])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html

  * igt@gem_exec_params@rsvd2-dirt:
    - shard-tglb:         NOTRUN -> [SKIP][18] ([fdo#109283])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb5/igt@gem_exec_params@rsvd2-dirt.html

  * igt@gem_exec_whisper@basic-queues-all:
    - shard-glk:          [PASS][19] -> [DMESG-WARN][20] ([i915#118] / [i915#95])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-glk5/igt@gem_exec_whisper@basic-queues-all.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-glk6/igt@gem_exec_whisper@basic-queues-all.html

  * igt@gem_pread@exhaustion:
    - shard-tglb:         NOTRUN -> [WARN][21] ([i915#2658]) +1 similar issue
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb8/igt@gem_pread@exhaustion.html
    - shard-iclb:         NOTRUN -> [WARN][22] ([i915#2658]) +1 similar issue
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb3/igt@gem_pread@exhaustion.html

  * igt@gem_pwrite@basic-exhaustion:
    - shard-snb:          NOTRUN -> [WARN][23] ([i915#2658]) +1 similar issue
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-snb7/igt@gem_pwrite@basic-exhaustion.html
    - shard-kbl:          NOTRUN -> [WARN][24] ([i915#2658]) +1 similar issue
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl7/igt@gem_pwrite@basic-exhaustion.html
    - shard-apl:          NOTRUN -> [WARN][25] ([i915#2658])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-apl6/igt@gem_pwrite@basic-exhaustion.html
    - shard-glk:          NOTRUN -> [WARN][26] ([i915#2658])
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-glk1/igt@gem_pwrite@basic-exhaustion.html

  * igt@gem_render_copy@y-tiled-to-vebox-linear:
    - shard-iclb:         NOTRUN -> [SKIP][27] ([i915#768]) +1 similar issue
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb1/igt@gem_render_copy@y-tiled-to-vebox-linear.html

  * igt@gem_userptr_blits@create-destroy-unsync:
    - shard-tglb:         NOTRUN -> [SKIP][28] ([i915#3297]) +1 similar issue
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb1/igt@gem_userptr_blits@create-destroy-unsync.html

  * igt@gem_userptr_blits@unsync-unmap-after-close:
    - shard-iclb:         NOTRUN -> [SKIP][29] ([i915#3297])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb5/igt@gem_userptr_blits@unsync-unmap-after-close.html

  * igt@gen3_render_tiledy_blits:
    - shard-tglb:         NOTRUN -> [SKIP][30] ([fdo#109289]) +3 similar issues
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb6/igt@gen3_render_tiledy_blits.html

  * igt@gen7_exec_parse@load-register-reg:
    - shard-iclb:         NOTRUN -> [SKIP][31] ([fdo#109289]) +2 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb3/igt@gen7_exec_parse@load-register-reg.html

  * igt@gen9_exec_parse@bb-start-out:
    - shard-tglb:         NOTRUN -> [SKIP][32] ([i915#2856]) +2 similar issues
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb8/igt@gen9_exec_parse@bb-start-out.html

  * igt@gen9_exec_parse@secure-batches:
    - shard-iclb:         NOTRUN -> [SKIP][33] ([i915#2856])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb8/igt@gen9_exec_parse@secure-batches.html

  * igt@i915_pm_dc@dc6-psr:
    - shard-iclb:         [PASS][34] -> [FAIL][35] ([i915#454])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-iclb1/igt@i915_pm_dc@dc6-psr.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb4/igt@i915_pm_dc@dc6-psr.html

  * igt@i915_pm_lpsp@screens-disabled:
    - shard-tglb:         NOTRUN -> [SKIP][36] ([i915#1902])
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb3/igt@i915_pm_lpsp@screens-disabled.html
    - shard-iclb:         NOTRUN -> [SKIP][37] ([i915#1902])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb7/igt@i915_pm_lpsp@screens-disabled.html

  * igt@i915_pm_rc6_residency@rc6-fence:
    - shard-tglb:         NOTRUN -> [WARN][38] ([i915#2681])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb7/igt@i915_pm_rc6_residency@rc6-fence.html

  * igt@i915_pm_rc6_residency@rc6-idle:
    - shard-tglb:         NOTRUN -> [WARN][39] ([i915#2681] / [i915#2684])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb3/igt@i915_pm_rc6_residency@rc6-idle.html

  * igt@i915_pm_rpm@modeset-pc8-residency-stress:
    - shard-tglb:         NOTRUN -> [SKIP][40] ([fdo#109506] / [i915#2411]) +1 similar issue
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb8/igt@i915_pm_rpm@modeset-pc8-residency-stress.html

  * igt@i915_pm_rpm@pc8-residency:
    - shard-iclb:         NOTRUN -> [SKIP][41] ([fdo#109293] / [fdo#109506])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb3/igt@i915_pm_rpm@pc8-residency.html

  * igt@i915_pm_rpm@system-suspend-execbuf:
    - shard-tglb:         NOTRUN -> [INCOMPLETE][42] ([i915#2411] / [i915#456] / [i915#750])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb7/igt@i915_pm_rpm@system-suspend-execbuf.html

  * igt@i915_suspend@forcewake:
    - shard-kbl:          [PASS][43] -> [DMESG-WARN][44] ([i915#180]) +1 similar issue
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-kbl7/igt@i915_suspend@forcewake.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl6/igt@i915_suspend@forcewake.html

  * igt@kms_big_fb@linear-16bpp-rotate-270:
    - shard-tglb:         NOTRUN -> [SKIP][45] ([fdo#111614]) +1 similar issue
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb2/igt@kms_big_fb@linear-16bpp-rotate-270.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
    - shard-apl:          NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#3777]) +1 similar issue
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-apl1/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
    - shard-kbl:          NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#3777]) +2 similar issues
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl7/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
    - shard-glk:          NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#3777]) +1 similar issue
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-glk9/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html

  * igt@kms_big_fb@yf-tiled-addfb-size-overflow:
    - shard-tglb:         NOTRUN -> [SKIP][49] ([fdo#111615]) +4 similar issues
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb6/igt@kms_big_fb@yf-tiled-addfb-size-overflow.html

  * igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][50] ([i915#3689] / [i915#3886]) +4 similar issues
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb5/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
    - shard-iclb:         NOTRUN -> [SKIP][51] ([fdo#109278] / [i915#3886]) +2 similar issues
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb1/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
    - shard-apl:          NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#3886]) +11 similar issues
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-apl1/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
    - shard-kbl:          NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#3886]) +6 similar issues
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl7/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
    - shard-glk:          NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#3886]) +2 similar issues
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-glk8/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html

  * igt@kms_ccs@pipe-c-crc-sprite-planes-basic-yf_tiled_ccs:
    - shard-tglb:         NOTRUN -> [SKIP][55] ([i915#3689]) +7 similar issues
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb3/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-yf_tiled_ccs.html

  * igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs:
    - shard-snb:          NOTRUN -> [SKIP][56] ([fdo#109271]) +381 similar issues
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-snb2/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs.html

  * igt@kms_cdclk@mode-transition:
    - shard-apl:          NOTRUN -> [SKIP][57] ([fdo#109271]) +272 similar issues
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-apl3/igt@kms_cdclk@mode-transition.html

  * igt@kms_chamelium@dp-hpd-storm-disable:
    - shard-apl:          NOTRUN -> [SKIP][58] ([fdo#109271] / [fdo#111827]) +22 similar issues
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-apl1/igt@kms_chamelium@dp-hpd-storm-disable.html

  * igt@kms_chamelium@hdmi-audio-edid:
    - shard-glk:          NOTRUN -> [SKIP][59] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-glk1/igt@kms_chamelium@hdmi-audio-edid.html

  * igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
    - shard-iclb:         NOTRUN -> [SKIP][60] ([fdo#109284] / [fdo#111827]) +5 similar issues
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb1/igt@kms_chamelium@hdmi-hpd-enable-disable-mode.html

  * igt@kms_chamelium@vga-hpd-without-ddc:
    - shard-snb:          NOTRUN -> [SKIP][61] ([fdo#109271] / [fdo#111827]) +20 similar issues
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-snb2/igt@kms_chamelium@vga-hpd-without-ddc.html

  * igt@kms_color@pipe-d-ctm-0-25:
    - shard-iclb:         NOTRUN -> [SKIP][62] ([fdo#109278] / [i915#1149])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb7/igt@kms_color@pipe-d-ctm-0-25.html

  * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
    - shard-kbl:          NOTRUN -> [SKIP][63] ([fdo#109271] / [fdo#111827]) +14 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl4/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html

  * igt@kms_color_chamelium@pipe-d-ctm-red-to-blue:
    - shard-tglb:         NOTRUN -> [SKIP][64] ([fdo#109284] / [fdo#111827]) +12 similar issues
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb3/igt@kms_color_chamelium@pipe-d-ctm-red-to-blue.html

  * igt@kms_content_protection@content_type_change:
    - shard-tglb:         NOTRUN -> [SKIP][65] ([fdo#111828])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb1/igt@kms_content_protection@content_type_change.html

  * igt@kms_content_protection@dp-mst-lic-type-0:
    - shard-tglb:         NOTRUN -> [SKIP][66] ([i915#3116])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb5/igt@kms_content_protection@dp-mst-lic-type-0.html

  * igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding:
    - shard-iclb:         NOTRUN -> [SKIP][67] ([fdo#109278] / [fdo#109279]) +1 similar issue
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb6/igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-tglb:         [PASS][68] -> [INCOMPLETE][69] ([i915#2828] / [i915#456])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-tglb5/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_cursor_crc@pipe-c-cursor-32x32-random:
    - shard-tglb:         NOTRUN -> [SKIP][70] ([i915#3319]) +2 similar issues
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-32x32-random.html

  * igt@kms_cursor_crc@pipe-c-cursor-512x170-offscreen:
    - shard-tglb:         NOTRUN -> [SKIP][71] ([fdo#109279] / [i915#3359]) +4 similar issues
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb1/igt@kms_cursor_crc@pipe-c-cursor-512x170-offscreen.html

  * igt@kms_cursor_crc@pipe-c-cursor-max-size-offscreen:
    - shard-tglb:         NOTRUN -> [SKIP][72] ([i915#3359]) +5 similar issues
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb6/igt@kms_cursor_crc@pipe-c-cursor-max-size-offscreen.html

  * igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement:
    - shard-iclb:         NOTRUN -> [SKIP][73] ([fdo#109278]) +13 similar issues
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb5/igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement.html

  * igt@kms_cursor_crc@pipe-d-cursor-suspend:
    - shard-kbl:          NOTRUN -> [SKIP][74] ([fdo#109271]) +139 similar issues
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl7/igt@kms_cursor_crc@pipe-d-cursor-suspend.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - shard-tglb:         NOTRUN -> [SKIP][75] ([i915#4103])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  * igt@kms_cursor_legacy@cursora-vs-flipb-atomic:
    - shard-iclb:         NOTRUN -> [SKIP][76] ([fdo#109274] / [fdo#109278]) +1 similar issue
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb1/igt@kms_cursor_legacy@cursora-vs-flipb-atomic.html

  * igt@kms_dsc@basic-dsc-enable:
    - shard-iclb:         NOTRUN -> [SKIP][77] ([i915#3840])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb4/igt@kms_dsc@basic-dsc-enable.html

  * igt@kms_flip@2x-blocking-absolute-wf_vblank-interruptible:
    - shard-tglb:         NOTRUN -> [SKIP][78] ([fdo#111825]) +31 similar issues
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb2/igt@kms_flip@2x-blocking-absolute-wf_vblank-interruptible.html

  * igt@kms_flip@2x-flip-vs-wf_vblank-interruptible:
    - shard-iclb:         NOTRUN -> [SKIP][79] ([fdo#109274]) +2 similar issues
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb6/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html

  * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
    - shard-kbl:          NOTRUN -> [DMESG-WARN][80] ([i915#180]) +5 similar issues
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
    - shard-iclb:         [PASS][81] -> [SKIP][82] ([i915#3701])
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-iclb7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
    - shard-tglb:         NOTRUN -> [SKIP][83] ([i915#2587])
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile.html

  * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
    - shard-apl:          NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2672])
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-apl1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html

  * igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw:
    - shard-iclb:         NOTRUN -> [SKIP][85] ([fdo#109280]) +10 similar issues
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
    - shard-apl:          NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#533]) +4 similar issues
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-apl6/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
    - shard-glk:          NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#533]) +1 similar issue
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-glk4/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
    - shard-kbl:          NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#533]) +3 similar issues
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl1/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html

  * igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
    - shard-apl:          [PASS][89] -> [DMESG-WARN][90] ([i915#180]) +1 similar issue
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html

  * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
    - shard-apl:          NOTRUN -> [FAIL][91] ([fdo#108145] / [i915#265]) +1 similar issue
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-apl1/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
    - shard-kbl:          NOTRUN -> [FAIL][92] ([fdo#108145] / [i915#265])
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl2/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html

  * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
    - shard-apl:          NOTRUN -> [FAIL][93] ([i915#265])
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-apl3/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html

  * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
    - shard-kbl:          NOTRUN -> [FAIL][94] ([i915#265])
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl4/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html

  * igt@kms_plane_alpha_blend@pipe-d-alpha-opaque-fb:
    - shard-glk:          NOTRUN -> [SKIP][95] ([fdo#109271]) +66 similar issues
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-glk7/igt@kms_plane_alpha_blend@pipe-d-alpha-opaque-fb.html

  * igt@kms_plane_lowres@pipe-c-tiling-x:
    - shard-tglb:         NOTRUN -> [SKIP][96] ([i915#3536]) +1 similar issue
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb3/igt@kms_plane_lowres@pipe-c-tiling-x.html

  * igt@kms_plane_lowres@pipe-c-tiling-yf:
    - shard-tglb:         NOTRUN -> [SKIP][97] ([fdo#112054])
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb8/igt@kms_plane_lowres@pipe-c-tiling-yf.html

  * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
    - shard-apl:          NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#2733])
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-apl7/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
    - shard-kbl:          NOTRUN -> [SKIP][99] ([fdo#109271] / [i915#2733])
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl1/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
    - shard-tglb:         NOTRUN -> [SKIP][100] ([i915#2920])
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html

  * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
    - shard-apl:          NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#658]) +5 similar issues
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-apl3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html

  * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
    - shard-kbl:          NOTRUN -> [SKIP][102] ([fdo#109271] / [i915#658]) +3 similar issues
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [PASS][103] -> [SKIP][104] ([fdo#109642] / [fdo#111068] / [i915#658])
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb5/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr@psr2_cursor_plane_onoff:
    - shard-iclb:         [PASS][105] -> [SKIP][106] ([fdo#109441])
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb5/igt@kms_psr@psr2_cursor_plane_onoff.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         NOTRUN -> [SKIP][107] ([fdo#109441]) +1 similar issue
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@kms_psr@psr2_sprite_render:
    - shard-tglb:         NOTRUN -> [FAIL][108] ([i915#132] / [i915#3467]) +2 similar issues
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb5/igt@kms_psr@psr2_sprite_render.html

  * igt@kms_vrr@flip-suspend:
    - shard-iclb:         NOTRUN -> [SKIP][109] ([fdo#109502])
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb6/igt@kms_vrr@flip-suspend.html
    - shard-tglb:         NOTRUN -> [SKIP][110] ([fdo#109502])
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb2/igt@kms_vrr@flip-suspend.html

  * igt@kms_writeback@writeback-fb-id:
    - shard-apl:          NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#2437]) +1 similar issue
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-apl2/igt@kms_writeback@writeback-fb-id.html
    - shard-kbl:          NOTRUN -> [SKIP][112] ([fdo#109271] / [i915#2437])
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl4/igt@kms_writeback@writeback-fb-id.html

  * igt@nouveau_crc@pipe-c-ctx-flip-skip-current-frame:
    - shard-tglb:         NOTRUN -> [SKIP][113] ([i915#2530]) +3 similar issues
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb7/igt@nouveau_crc@pipe-c-ctx-flip-skip-current-frame.html

  * igt@nouveau_crc@pipe-d-source-outp-complete:
    - shard-iclb:         NOTRUN -> [SKIP][114] ([fdo#109278] / [i915#2530])
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb3/igt@nouveau_crc@pipe-d-source-outp-complete.html

  * igt@perf_pmu@rc6-suspend:
    - shard-tglb:         [PASS][115] -> [INCOMPLETE][116] ([i915#4173] / [i915#456])
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-tglb7/igt@perf_pmu@rc6-suspend.html
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb7/igt@perf_pmu@rc6-suspend.html

  * igt@prime_nv_api@i915_nv_double_import:
    - shard-tglb:         NOTRUN -> [SKIP][117] ([fdo#109291]) +4 similar issues
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb8/igt@prime_nv_api@i915_nv_double_import.html

  * igt@prime_nv_api@nv_i915_reimport_twice_check_flink_name:
    - shard-iclb:         NOTRUN -> [SKIP][118] ([fdo#109291])
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb5/igt@prime_nv_api@nv_i915_reimport_twice_check_flink_name.html

  * igt@prime_vgem@fence-read-hang:
    - shard-tglb:         NOTRUN -> [SKIP][119] ([fdo#109295])
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb7/igt@prime_vgem@fence-read-hang.html
    - shard-iclb:         NOTRUN -> [SKIP][120] ([fdo#109295])
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-iclb4/igt@prime_vgem@fence-read-hang.html

  * igt@sysfs_clients@recycle:
    - shard-kbl:          NOTRUN -> [SKIP][121] ([fdo#109271] / [i915#2994])
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl7/igt@sysfs_clients@recycle.html

  * igt@sysfs_clients@recycle-many:
    - shard-apl:          NOTRUN -> [SKIP][122] ([fdo#109271] / [i915#2994]) +2 similar issues
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-apl8/igt@sysfs_clients@recycle-many.html
    - shard-tglb:         NOTRUN -> [SKIP][123] ([i915#2994])
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb1/igt@sysfs_clients@recycle-many.html

  
#### Possible fixes ####

  * igt@gem_exec_fair@basic-deadline:
    - shard-kbl:          [FAIL][124] ([i915#2846]) -> [PASS][125]
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-kbl3/igt@gem_exec_fair@basic-deadline.html
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl1/igt@gem_exec_fair@basic-deadline.html

  * igt@gem_exec_fair@basic-pace@bcs0:
    - shard-tglb:         [FAIL][126] ([i915#2842]) -> [PASS][127]
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-tglb1/igt@gem_exec_fair@basic-pace@bcs0.html
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb2/igt@gem_exec_fair@basic-pace@bcs0.html

  * igt@gem_exec_fair@basic-pace@vcs0:
    - shard-kbl:          [FAIL][128] ([i915#2842]) -> [PASS][129]
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs0.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs0.html

  * igt@gem_exec_fair@basic-pace@vecs0:
    - shard-glk:          [FAIL][130] ([i915#2842]) -> [PASS][131] +3 similar issues
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-glk6/igt@gem_exec_fair@basic-pace@vecs0.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-glk2/igt@gem_exec_fair@basic-pace@vecs0.html

  * igt@gem_huc_copy@huc-copy:
    - shard-tglb:         [SKIP][132] ([i915#2190]) -> [PASS][133]
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6220/shard-tglb6/igt@gem_huc_copy@huc-copy.html
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/shard-tglb3/igt@gem_huc_copy@huc-copy.html

  * igt@i915_pm_dc@dc6-dpms:
    - shard-iclb:         [FAIL][134] ([i915#454]) -> [PASS][135]
   [134]: https://intel

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6265/index.html

[-- Attachment #2: Type: text/html, Size: 33940 bytes --]

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Petri Latvala]

On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote:
> Skipping using the continue statement has the side effect of this
> subtest being absent from the list of subtests, when running the
> test executable with paramter --list-subtest. Is that okay ?

It's not okay btw. When you're not in an igt_fixture or an
igt_subtest, you cannot use anything that touches the hardware or the
running system in any way.


-- 
Petri Latvala




> 
> --
> 
> Regards,
> Jay
> ________________________________
> From: Mark Yacoub <markyacoub@chromium.org>
> Sent: Monday, September 27, 2021 1:34 PM
> To: Pillai, Aurabindo <Aurabindo.Pillai@amd.com>
> Cc: Development mailing list for IGT GPU Tools <igt-dev@lists.freedesktop.org>; Mark Yacoub <markyacoub@google.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big
> 
> so for the sake of consistency, I'm wondering if we can skip the test
> the same way we skip other tests such as
> ```
> if (tests[i].flags & TEST_NO_2X_OUTPUT)
> continue;
> ```
> because we're not failing a certain condition but a whole test, it
> might be better not to run the test in the first place unless it's
> intel.
> So in both main loops that call run_test we can do if
> if (tests[i].flags & TEST_BO_TOOBIG && !intel)
>     continue;
> this way we're not too worried where the flag would be used across the
> test and not skip halfway through a test.
> 
> On Mon, Sep 27, 2021 at 1:28 PM Pillai, Aurabindo
> <Aurabindo.Pillai@amd.com> wrote:
> >
> > [AMD Official Use Only]
> >
> >
> > Hi Mark,
> >
> >
> > Both bo-too-big and bo-too-big-interruptible shall be skipped with this patch. The other location where TEST_BO_TOOBIG is mentioned is in the same function.
> >
> > --
> >
> > Regards,
> > Jay
> > ________________________________
> > From: Mark Yacoub <markyacoub@chromium.org>
> > Sent: Monday, September 27, 2021 1:21 PM
> > To: Pillai, Aurabindo <Aurabindo.Pillai@amd.com>
> > Cc: Development mailing list for IGT GPU Tools <igt-dev@lists.freedesktop.org>; Mark Yacoub <markyacoub@google.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>
> > Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big
> >
> > On Mon, Sep 27, 2021 at 12:07 PM Aurabindo Pillai
> > <aurabindo.pillai@amd.com> wrote:
> > >
> > > [Why]
> > > The rationale of the test does not hold true for AMD hardware. The
> > > aperture size calculation has an upper bound check which is done through
> > > i915 specific IOCTL. Hence this part of subtest must be moved
> > > out of the platform agnostic tests. Moreover, AMD hardware
> > > supports buffers larger than aperture size.
> > >
> > > [How]
> > > Skip the bo-too-big subtest unless its run on i915 as the test fails on
> > > AMD, VKMS and VC4
> > >
> > > Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> > > ---
> > >  tests/kms_flip.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> > > index 54137871..20112de1 100755
> > > --- a/tests/kms_flip.c
> > > +++ b/tests/kms_flip.c
> > > @@ -1290,6 +1290,7 @@ static void __run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,
> > >         /* 256 MB is usually the maximum mappable aperture,
> > >          * (make it 4x times that to ensure failure) */
> > >         if (o->flags & TEST_BO_TOOBIG) {
> > There is also another place where TEST_BO_TOOBIG is used, should we
> > skip this one as well or it's only this part?
> > > +               igt_skip_on(!is_i915_device(drm_fd));
> > >                 bo_size = 4*gem_mappable_aperture_size(drm_fd);
> > >                 igt_require(bo_size < gem_global_aperture_size(drm_fd));
> > >         }
> > > --
> > > 2.30.2
> > >

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Aurabindo Pillai]

On 9/28/21 5:15 AM, Petri Latvala wrote:
> On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote:
>> Skipping using the continue statement has the side effect of this
>> subtest being absent from the list of subtests, when running the
>> test executable with paramter --list-subtest. Is that okay ?
> It's not okay btw. When you're not in an igt_fixture or an
> igt_subtest, you cannot use anything that touches the hardware or the
> running system in any way.
>
>
In that case, please discard v2. Is this version good enough ?

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Petri Latvala]

On Tue, Sep 28, 2021 at 09:35:10AM -0400, Aurabindo Pillai wrote:
> 
> On 9/28/21 5:15 AM, Petri Latvala wrote:
> > On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote:
> > > Skipping using the continue statement has the side effect of this
> > > subtest being absent from the list of subtests, when running the
> > > test executable with paramter --list-subtest. Is that okay ?
> > It's not okay btw. When you're not in an igt_fixture or an
> > igt_subtest, you cannot use anything that touches the hardware or the
> > running system in any way.
> > 
> > 
> In that case, please discard v2. Is this version good enough ?
> 


No objections with v1.
Acked-by: Petri Latvala <petri.latvala@intel.com>

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Aurabindo Pillai]

On 9/28/21 9:53 AM, Petri Latvala wrote:
> On Tue, Sep 28, 2021 at 09:35:10AM -0400, Aurabindo Pillai wrote:
>> On 9/28/21 5:15 AM, Petri Latvala wrote:
>>> On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote:
>>>> Skipping using the continue statement has the side effect of this
>>>> subtest being absent from the list of subtests, when running the
>>>> test executable with paramter --list-subtest. Is that okay ?
>>> It's not okay btw. When you're not in an igt_fixture or an
>>> igt_subtest, you cannot use anything that touches the hardware or the
>>> running system in any way.
>>>
>>>
>> In that case, please discard v2. Is this version good enough ?
>>
>
> No objections with v1.
> Acked-by: Petri Latvala <petri.latvala@intel.com>


Thank you.

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Rodrigo Siqueira]

Hi,

I also tested it using vkms and vc4.

I already applied the V1 in the upstream.

Thanks
Siqueira

On 09/28, Aurabindo Pillai wrote:
> 
> On 9/28/21 9:53 AM, Petri Latvala wrote:
> > On Tue, Sep 28, 2021 at 09:35:10AM -0400, Aurabindo Pillai wrote:
> > > On 9/28/21 5:15 AM, Petri Latvala wrote:
> > > > On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote:
> > > > > Skipping using the continue statement has the side effect of this
> > > > > subtest being absent from the list of subtests, when running the
> > > > > test executable with paramter --list-subtest. Is that okay ?
> > > > It's not okay btw. When you're not in an igt_fixture or an
> > > > igt_subtest, you cannot use anything that touches the hardware or the
> > > > running system in any way.
> > > > 
> > > > 
> > > In that case, please discard v2. Is this version good enough ?
> > > 
> > 
> > No objections with v1.
> > Acked-by: Petri Latvala <petri.latvala@intel.com>
> 
> 
> Thank you.
> 

-- 
Rodrigo Siqueira
https://siqueira.tech

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Mark Yacoub]

On Tue, Sep 28, 2021 at 10:43 AM Rodrigo Siqueira
<Rodrigo.Siqueira@amd.com> wrote:
>
> Hi,
>
> I also tested it using vkms and vc4.
>
> I already applied the V1 in the upstream.
>
> Thanks
> Siqueira
>
> On 09/28, Aurabindo Pillai wrote:
> >
> > On 9/28/21 9:53 AM, Petri Latvala wrote:
> > > On Tue, Sep 28, 2021 at 09:35:10AM -0400, Aurabindo Pillai wrote:
> > > > On 9/28/21 5:15 AM, Petri Latvala wrote:
> > > > > On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote:
> > > > > > Skipping using the continue statement has the side effect of this
> > > > > > subtest being absent from the list of subtests, when running the
> > > > > > test executable with paramter --list-subtest. Is that okay ?
> > > > > It's not okay btw. When you're not in an igt_fixture or an
> > > > > igt_subtest, you cannot use anything that touches the hardware or the
> > > > > running system in any way.
Hi Petri, can you elaborate more on this. I'm curious to understand
what you mean. I'm slightly confused.
> > > > >
> > > > >
> > > > In that case, please discard v2. Is this version good enough ?
> > > >
> > >
> > > No objections with v1.
> > > Acked-by: Petri Latvala <petri.latvala@intel.com>
> >
> >
> > Thank you.
> >
>
> --
> Rodrigo Siqueira
> https://siqueira.tech

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Petri Latvala]

On Tue, Sep 28, 2021 at 10:48:17AM -0400, Mark Yacoub wrote:
> On Tue, Sep 28, 2021 at 10:43 AM Rodrigo Siqueira
> <Rodrigo.Siqueira@amd.com> wrote:
> >
> > Hi,
> >
> > I also tested it using vkms and vc4.
> >
> > I already applied the V1 in the upstream.
> >
> > Thanks
> > Siqueira
> >
> > On 09/28, Aurabindo Pillai wrote:
> > >
> > > On 9/28/21 9:53 AM, Petri Latvala wrote:
> > > > On Tue, Sep 28, 2021 at 09:35:10AM -0400, Aurabindo Pillai wrote:
> > > > > On 9/28/21 5:15 AM, Petri Latvala wrote:
> > > > > > On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote:
> > > > > > > Skipping using the continue statement has the side effect of this
> > > > > > > subtest being absent from the list of subtests, when running the
> > > > > > > test executable with paramter --list-subtest. Is that okay ?
> > > > > > It's not okay btw. When you're not in an igt_fixture or an
> > > > > > igt_subtest, you cannot use anything that touches the hardware or the
> > > > > > running system in any way.
> Hi Petri, can you elaborate more on this. I'm curious to understand
> what you mean. I'm slightly confused.

All subtests must be enumerable regardless of hardware, basically.

In other words, you cannot do

igt_fixture {
  variable_assigned_in_fixture = value;
}

if (variable_assigned_in_fixture)
  igt_subtest("only-exists-sometimes") {}


-- 
Petri Latvala

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Mark Yacoub]

On Tue, Sep 28, 2021 at 11:20 AM Petri Latvala <petri.latvala@intel.com> wrote:
>
> On Tue, Sep 28, 2021 at 10:48:17AM -0400, Mark Yacoub wrote:
> > On Tue, Sep 28, 2021 at 10:43 AM Rodrigo Siqueira
> > <Rodrigo.Siqueira@amd.com> wrote:
> > >
> > > Hi,
> > >
> > > I also tested it using vkms and vc4.
> > >
> > > I already applied the V1 in the upstream.
> > >
> > > Thanks
> > > Siqueira
> > >
> > > On 09/28, Aurabindo Pillai wrote:
> > > >
> > > > On 9/28/21 9:53 AM, Petri Latvala wrote:
> > > > > On Tue, Sep 28, 2021 at 09:35:10AM -0400, Aurabindo Pillai wrote:
> > > > > > On 9/28/21 5:15 AM, Petri Latvala wrote:
> > > > > > > On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote:
> > > > > > > > Skipping using the continue statement has the side effect of this
> > > > > > > > subtest being absent from the list of subtests, when running the
> > > > > > > > test executable with paramter --list-subtest. Is that okay ?
> > > > > > > It's not okay btw. When you're not in an igt_fixture or an
> > > > > > > igt_subtest, you cannot use anything that touches the hardware or the
> > > > > > > running system in any way.
> > Hi Petri, can you elaborate more on this. I'm curious to understand
> > what you mean. I'm slightly confused.
>
> All subtests must be enumerable regardless of hardware, basically.
>
> In other words, you cannot do
>
> igt_fixture {
>   variable_assigned_in_fixture = value;
> }
>
> if (variable_assigned_in_fixture)
>   igt_subtest("only-exists-sometimes") {}
>
Gotcha. thanks!
so can i still do
igt_subtest("my-subtest") {
  if (variable_assigned_in_fixture)
    run_subtest();
}
>
> --
> Petri Latvala

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Mark Yacoub]

On Tue, Sep 28, 2021 at 11:34 AM Petri Latvala <petri.latvala@intel.com> wrote:
>
> On Tue, Sep 28, 2021 at 11:23:47AM -0400, Mark Yacoub wrote:
> > On Tue, Sep 28, 2021 at 11:20 AM Petri Latvala <petri.latvala@intel.com> wrote:
> > >
> > > On Tue, Sep 28, 2021 at 10:48:17AM -0400, Mark Yacoub wrote:
> > > > On Tue, Sep 28, 2021 at 10:43 AM Rodrigo Siqueira
> > > > <Rodrigo.Siqueira@amd.com> wrote:
> > > > >
> > > > > Hi,
> > > > >
> > > > > I also tested it using vkms and vc4.
> > > > >
> > > > > I already applied the V1 in the upstream.
> > > > >
> > > > > Thanks
> > > > > Siqueira
> > > > >
> > > > > On 09/28, Aurabindo Pillai wrote:
> > > > > >
> > > > > > On 9/28/21 9:53 AM, Petri Latvala wrote:
> > > > > > > On Tue, Sep 28, 2021 at 09:35:10AM -0400, Aurabindo Pillai wrote:
> > > > > > > > On 9/28/21 5:15 AM, Petri Latvala wrote:
> > > > > > > > > On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote:
> > > > > > > > > > Skipping using the continue statement has the side effect of this
> > > > > > > > > > subtest being absent from the list of subtests, when running the
> > > > > > > > > > test executable with paramter --list-subtest. Is that okay ?
> > > > > > > > > It's not okay btw. When you're not in an igt_fixture or an
> > > > > > > > > igt_subtest, you cannot use anything that touches the hardware or the
> > > > > > > > > running system in any way.
> > > > Hi Petri, can you elaborate more on this. I'm curious to understand
> > > > what you mean. I'm slightly confused.
> > >
> > > All subtests must be enumerable regardless of hardware, basically.
> > >
> > > In other words, you cannot do
> > >
> > > igt_fixture {
> > >   variable_assigned_in_fixture = value;
> > > }
> > >
> > > if (variable_assigned_in_fixture)
> > >   igt_subtest("only-exists-sometimes") {}
> > >
> > Gotcha. thanks!
> > so can i still do
> > igt_subtest("my-subtest") {
> >   if (variable_assigned_in_fixture)
> >     run_subtest();
> > }
>
>
> Yup.
>
> Or if you want to be fancy, even
>
> igt_subtest_with_dynamic("my-subtest") {
>  if (variable_assigned_in_fixture)
>    igt_dynamic("stuff")
very cool. ty!
>      run_test();
> }
>
>
> --
> Petri Latvala

Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Petri Latvala]

On Tue, Sep 28, 2021 at 11:23:47AM -0400, Mark Yacoub wrote:
> On Tue, Sep 28, 2021 at 11:20 AM Petri Latvala <petri.latvala@intel.com> wrote:
> >
> > On Tue, Sep 28, 2021 at 10:48:17AM -0400, Mark Yacoub wrote:
> > > On Tue, Sep 28, 2021 at 10:43 AM Rodrigo Siqueira
> > > <Rodrigo.Siqueira@amd.com> wrote:
> > > >
> > > > Hi,
> > > >
> > > > I also tested it using vkms and vc4.
> > > >
> > > > I already applied the V1 in the upstream.
> > > >
> > > > Thanks
> > > > Siqueira
> > > >
> > > > On 09/28, Aurabindo Pillai wrote:
> > > > >
> > > > > On 9/28/21 9:53 AM, Petri Latvala wrote:
> > > > > > On Tue, Sep 28, 2021 at 09:35:10AM -0400, Aurabindo Pillai wrote:
> > > > > > > On 9/28/21 5:15 AM, Petri Latvala wrote:
> > > > > > > > On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote:
> > > > > > > > > Skipping using the continue statement has the side effect of this
> > > > > > > > > subtest being absent from the list of subtests, when running the
> > > > > > > > > test executable with paramter --list-subtest. Is that okay ?
> > > > > > > > It's not okay btw. When you're not in an igt_fixture or an
> > > > > > > > igt_subtest, you cannot use anything that touches the hardware or the
> > > > > > > > running system in any way.
> > > Hi Petri, can you elaborate more on this. I'm curious to understand
> > > what you mean. I'm slightly confused.
> >
> > All subtests must be enumerable regardless of hardware, basically.
> >
> > In other words, you cannot do
> >
> > igt_fixture {
> >   variable_assigned_in_fixture = value;
> > }
> >
> > if (variable_assigned_in_fixture)
> >   igt_subtest("only-exists-sometimes") {}
> >
> Gotcha. thanks!
> so can i still do
> igt_subtest("my-subtest") {
>   if (variable_assigned_in_fixture)
>     run_subtest();
> }


Yup.

Or if you want to be fancy, even

igt_subtest_with_dynamic("my-subtest") {
 if (variable_assigned_in_fixture)
   igt_dynamic("stuff")
     run_test();
}


-- 
Petri Latvala