[PATCH 0/6] ARM: berlin: add AHCI support

[PATCH 0/6] ARM: berlin: add AHCI support

[Antoine Ténart]

This series adds the support for Berlin SoCs AHCI controllers. The
controller allows to use the SATA host interface and, for example, the
eSATA port on the BG2Q.

Also enable the eSATA interface on the BG2Q DMP.

Tested on the BG2Q DMP.

Antoine Ténart (6):
  ata: ahci: add AHCI support for Berlin SoCs
  Documentation: bindings: add the berlin-achi compatible to the ahci
    platform
  ARM: berlin: add the AHCI node for the BG2Q
  ARM: berlin: enable the eSATA interface on the BG2Q DMP
  ARM: berlin: add the AHCI node for the BG2
  ARM: berlin: add the AHCI node for the BG2CD

 .../devicetree/bindings/ata/ahci-platform.txt      |   3 +-
 arch/arm/boot/dts/berlin2.dtsi                     |   7 +
 arch/arm/boot/dts/berlin2cd.dtsi                   |   7 +
 arch/arm/boot/dts/berlin2q-marvell-dmp.dts         |   5 +
 arch/arm/boot/dts/berlin2q.dtsi                    |  12 ++
 drivers/ata/Kconfig                                |   9 ++
 drivers/ata/Makefile                               |   1 +
 drivers/ata/ahci_berlin.c                          | 175 +++++++++++++++++++++
 8 files changed, 218 insertions(+), 1 deletion(-)
 create mode 100644 drivers/ata/ahci_berlin.c

-- 
1.8.3.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 0/6] ARM: berlin: add AHCI support

[Antoine Ténart]

This series adds the support for Berlin SoCs AHCI controllers. The
controller allows to use the SATA host interface and, for example, the
eSATA port on the BG2Q.

Also enable the eSATA interface on the BG2Q DMP.

Tested on the BG2Q DMP.

Antoine Ténart (6):
  ata: ahci: add AHCI support for Berlin SoCs
  Documentation: bindings: add the berlin-achi compatible to the ahci
    platform
  ARM: berlin: add the AHCI node for the BG2Q
  ARM: berlin: enable the eSATA interface on the BG2Q DMP
  ARM: berlin: add the AHCI node for the BG2
  ARM: berlin: add the AHCI node for the BG2CD

 .../devicetree/bindings/ata/ahci-platform.txt      |   3 +-
 arch/arm/boot/dts/berlin2.dtsi                     |   7 +
 arch/arm/boot/dts/berlin2cd.dtsi                   |   7 +
 arch/arm/boot/dts/berlin2q-marvell-dmp.dts         |   5 +
 arch/arm/boot/dts/berlin2q.dtsi                    |  12 ++
 drivers/ata/Kconfig                                |   9 ++
 drivers/ata/Makefile                               |   1 +
 drivers/ata/ahci_berlin.c                          | 175 +++++++++++++++++++++
 8 files changed, 218 insertions(+), 1 deletion(-)
 create mode 100644 drivers/ata/ahci_berlin.c

-- 
1.8.3.2

[PATCH 0/6] ARM: berlin: add AHCI support

[Antoine Ténart]

This series adds the support for Berlin SoCs AHCI controllers. The
controller allows to use the SATA host interface and, for example, the
eSATA port on the BG2Q.

Also enable the eSATA interface on the BG2Q DMP.

Tested on the BG2Q DMP.

Antoine T?nart (6):
  ata: ahci: add AHCI support for Berlin SoCs
  Documentation: bindings: add the berlin-achi compatible to the ahci
    platform
  ARM: berlin: add the AHCI node for the BG2Q
  ARM: berlin: enable the eSATA interface on the BG2Q DMP
  ARM: berlin: add the AHCI node for the BG2
  ARM: berlin: add the AHCI node for the BG2CD

 .../devicetree/bindings/ata/ahci-platform.txt      |   3 +-
 arch/arm/boot/dts/berlin2.dtsi                     |   7 +
 arch/arm/boot/dts/berlin2cd.dtsi                   |   7 +
 arch/arm/boot/dts/berlin2q-marvell-dmp.dts         |   5 +
 arch/arm/boot/dts/berlin2q.dtsi                    |  12 ++
 drivers/ata/Kconfig                                |   9 ++
 drivers/ata/Makefile                               |   1 +
 drivers/ata/ahci_berlin.c                          | 175 +++++++++++++++++++++
 8 files changed, 218 insertions(+), 1 deletion(-)
 create mode 100644 drivers/ata/ahci_berlin.c

-- 
1.8.3.2

[PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Antoine Ténart]

Add support for the Berlin SoCs AHCI SATA controller allowing to
interface with devices like external hard drives.

Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
---
 drivers/ata/Kconfig       |   9 +++
 drivers/ata/Makefile      |   1 +
 drivers/ata/ahci_berlin.c | 175 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 185 insertions(+)
 create mode 100644 drivers/ata/ahci_berlin.c

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 20e03a7eb8b4..c985dfcd5a6c 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -97,6 +97,15 @@ config SATA_AHCI_PLATFORM
 
 	  If unsure, say N.
 
+config AHCI_BERLIN
+	tristate "Marvell Berlin AHCI SATA support"
+	depends on ARCH_BERLIN
+	help
+	  This option enables support for the Marvell Berlin SoC's
+	  onboard AHCI SATA.
+
+	  If unsure, say N.
+
 config AHCI_DA850
 	tristate "DaVinci DA850 AHCI SATA support"
 	depends on ARCH_DAVINCI_DA850
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 44c8016e565c..7fb78d1e0a44 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -10,6 +10,7 @@ obj-$(CONFIG_SATA_INIC162X)	+= sata_inic162x.o
 obj-$(CONFIG_SATA_SIL24)	+= sata_sil24.o
 obj-$(CONFIG_SATA_DWC)		+= sata_dwc_460ex.o
 obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o libahci.o
+obj-$(CONFIG_AHCI_BERLIN)	+= ahci_berlin.o libahci.o libahci_platform.o
 obj-$(CONFIG_AHCI_DA850)	+= ahci_da850.o libahci.o libahci_platform.o
 obj-$(CONFIG_AHCI_IMX)		+= ahci_imx.o libahci.o libahci_platform.o
 obj-$(CONFIG_AHCI_SUNXI)	+= ahci_sunxi.o libahci.o libahci_platform.o
diff --git a/drivers/ata/ahci_berlin.c b/drivers/ata/ahci_berlin.c
new file mode 100644
index 000000000000..cf1c9d3b9d18
--- /dev/null
+++ b/drivers/ata/ahci_berlin.c
@@ -0,0 +1,175 @@
+/*
+ * Marvell Berlin AHCI SATA platform driver
+ *
+ * Copyright (C) 2014 Marvell Technology Group Ltd.
+ *
+ * Antoine Ténart <antoine.tenart@free-electrons.com>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/ahci_platform.h>
+#include <linux/module.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+
+#include "ahci.h"
+
+#define PORT_VSR_ADDR		0x78
+#define PORT_VSR_DATA		0x7C
+#define HOST_VSA_ADDR		0xA0
+#define HOST_VSA_DATA		0xA4
+
+static inline void ahci_berlin_reg_setbits(void __iomem *reg, u32 val)
+{
+	u32 regval;
+
+	regval = readl(reg);
+	regval |= val;
+	writel(regval, reg);
+}
+
+static inline void ahci_berlin_reg_set(void __iomem *reg, u32 val)
+{
+	writel(val, reg);
+}
+
+static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
+					     u32 set_val)
+{
+	u32 regval;
+
+	regval = readl(reg);
+	regval &= ~(clear_val);
+	regval |= set_val;
+	writel(regval, reg);
+}
+
+static void ahci_berlin_init(void __iomem *mmio)
+{
+	/* interface select */
+	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
+	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,
+			    BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));
+
+}
+
+static void ahci_berlin_port_init(void __iomem *mmio, unsigned int ports)
+{
+	int p;
+
+	/* power down pll */
+	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
+	ahci_berlin_reg_setbits(mmio + HOST_VSA_DATA, BIT(6));
+
+	for (p = 0; p < ports; p++) {
+		/* port control register */
+		void __iomem *ctrl_reg = mmio + 0x100 + (p * 0x80);
+
+		/* set PHY mode to SATA, ref freq to 25 MHz */
+		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x201);
+		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
+					  0xff, BIT(0));
+
+		/* set PHY up to 6 Gbps */
+		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x225);
+		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
+					  BIT(11) | BIT(10), BIT(11));
+
+		/* set SEL_BITS to 40 bit */
+		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x223);
+		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
+					  BIT(11) | BIT(10), BIT(11));
+
+		/* use max pll rate */
+		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x202);
+		ahci_berlin_reg_setbits(ctrl_reg + PORT_VSR_DATA, BIT(12));
+
+		/* CT timing fix */
+		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) | BIT(1));
+		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
+				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
+				    BIT(10) | BIT(2) | BIT(1));
+
+		/* set the controller speed */
+		ahci_berlin_reg_set(ctrl_reg + PORT_SCR_CTL,
+				    BIT(6) | BIT(5) | BIT(0));
+	}
+
+	/* power up pll */
+	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
+	ahci_berlin_reg_clear_set(mmio + HOST_VSA_DATA, BIT(6), 0x0);
+}
+
+static const struct ata_port_info ahci_berlin_port_info = {
+	.flags		= AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
+	.pio_mask	= ATA_PIO4,
+	.udma_mask	= ATA_UDMA6,
+	.port_ops	= &ahci_platform_ops,
+};
+
+static int ahci_berlin_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	struct device_node *np = dev->of_node;
+	struct ahci_host_priv *hpriv;
+	int ret, nports, force_map = 0;
+
+	hpriv = ahci_platform_get_resources(pdev);
+	if (IS_ERR(hpriv)) {
+		dev_err(dev, "cannot get AHCI resources\n");
+		return PTR_ERR(hpriv);
+	}
+
+	ret = ahci_platform_enable_resources(hpriv);
+	if (ret) {
+		dev_err(dev, "cannot enable resources: %d\n", ret);
+		return ret;
+	}
+
+	nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
+
+	/* force_map is modified only if the property is found */
+	of_property_read_u32(np, "marvell,force-port-map", &force_map);
+	if (force_map)
+		nports = force_map;
+
+	ahci_berlin_init(hpriv->mmio);
+	ahci_berlin_port_init(hpriv->mmio, nports);
+
+	ret = ahci_platform_init_host(pdev, hpriv, &ahci_berlin_port_info,
+				      force_map, 0);
+	if (ret) {
+		dev_err(dev, "host init failed: %d\n", ret);
+		goto disable_resources;
+	}
+
+	return 0;
+
+disable_resources:
+	ahci_platform_disable_resources(hpriv);
+	return ret;
+}
+
+static const struct of_device_id ahci_berlin_of_match[] = {
+	{ .compatible = "marvell,berlin-ahci" },
+	{ },
+};
+MODULE_DEVICE_TABLE(of, ahci_berlin_of_match);
+
+static struct platform_driver ahci_berlin_driver = {
+	.probe	= ahci_berlin_probe,
+	.remove	= ata_platform_remove_one,
+	.driver	= {
+		.name		= "ahci-berlin",
+		.owner		= THIS_MODULE,
+		.of_match_table = ahci_berlin_of_match,
+	},
+};
+module_platform_driver(ahci_berlin_driver);
+
+MODULE_DESCRIPTION("Marvell Berlin AHCI SATA driver");
+MODULE_AUTHOR("Antoine Ténart <antoine.tenart@free-electrons.com>");
+MODULE_LICENSE("GPL");
-- 
1.8.3.2

[PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Antoine Ténart]

Add support for the Berlin SoCs AHCI SATA controller allowing to
interface with devices like external hard drives.

Signed-off-by: Antoine T?nart <antoine.tenart@free-electrons.com>
---
 drivers/ata/Kconfig       |   9 +++
 drivers/ata/Makefile      |   1 +
 drivers/ata/ahci_berlin.c | 175 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 185 insertions(+)
 create mode 100644 drivers/ata/ahci_berlin.c

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 20e03a7eb8b4..c985dfcd5a6c 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -97,6 +97,15 @@ config SATA_AHCI_PLATFORM
 
 	  If unsure, say N.
 
+config AHCI_BERLIN
+	tristate "Marvell Berlin AHCI SATA support"
+	depends on ARCH_BERLIN
+	help
+	  This option enables support for the Marvell Berlin SoC's
+	  onboard AHCI SATA.
+
+	  If unsure, say N.
+
 config AHCI_DA850
 	tristate "DaVinci DA850 AHCI SATA support"
 	depends on ARCH_DAVINCI_DA850
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 44c8016e565c..7fb78d1e0a44 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -10,6 +10,7 @@ obj-$(CONFIG_SATA_INIC162X)	+= sata_inic162x.o
 obj-$(CONFIG_SATA_SIL24)	+= sata_sil24.o
 obj-$(CONFIG_SATA_DWC)		+= sata_dwc_460ex.o
 obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o libahci.o
+obj-$(CONFIG_AHCI_BERLIN)	+= ahci_berlin.o libahci.o libahci_platform.o
 obj-$(CONFIG_AHCI_DA850)	+= ahci_da850.o libahci.o libahci_platform.o
 obj-$(CONFIG_AHCI_IMX)		+= ahci_imx.o libahci.o libahci_platform.o
 obj-$(CONFIG_AHCI_SUNXI)	+= ahci_sunxi.o libahci.o libahci_platform.o
diff --git a/drivers/ata/ahci_berlin.c b/drivers/ata/ahci_berlin.c
new file mode 100644
index 000000000000..cf1c9d3b9d18
--- /dev/null
+++ b/drivers/ata/ahci_berlin.c
@@ -0,0 +1,175 @@
+/*
+ * Marvell Berlin AHCI SATA platform driver
+ *
+ * Copyright (C) 2014 Marvell Technology Group Ltd.
+ *
+ * Antoine T?nart <antoine.tenart@free-electrons.com>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/ahci_platform.h>
+#include <linux/module.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+
+#include "ahci.h"
+
+#define PORT_VSR_ADDR		0x78
+#define PORT_VSR_DATA		0x7C
+#define HOST_VSA_ADDR		0xA0
+#define HOST_VSA_DATA		0xA4
+
+static inline void ahci_berlin_reg_setbits(void __iomem *reg, u32 val)
+{
+	u32 regval;
+
+	regval = readl(reg);
+	regval |= val;
+	writel(regval, reg);
+}
+
+static inline void ahci_berlin_reg_set(void __iomem *reg, u32 val)
+{
+	writel(val, reg);
+}
+
+static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
+					     u32 set_val)
+{
+	u32 regval;
+
+	regval = readl(reg);
+	regval &= ~(clear_val);
+	regval |= set_val;
+	writel(regval, reg);
+}
+
+static void ahci_berlin_init(void __iomem *mmio)
+{
+	/* interface select */
+	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
+	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,
+			    BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));
+
+}
+
+static void ahci_berlin_port_init(void __iomem *mmio, unsigned int ports)
+{
+	int p;
+
+	/* power down pll */
+	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
+	ahci_berlin_reg_setbits(mmio + HOST_VSA_DATA, BIT(6));
+
+	for (p = 0; p < ports; p++) {
+		/* port control register */
+		void __iomem *ctrl_reg = mmio + 0x100 + (p * 0x80);
+
+		/* set PHY mode to SATA, ref freq to 25 MHz */
+		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x201);
+		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
+					  0xff, BIT(0));
+
+		/* set PHY up to 6 Gbps */
+		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x225);
+		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
+					  BIT(11) | BIT(10), BIT(11));
+
+		/* set SEL_BITS to 40 bit */
+		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x223);
+		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
+					  BIT(11) | BIT(10), BIT(11));
+
+		/* use max pll rate */
+		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x202);
+		ahci_berlin_reg_setbits(ctrl_reg + PORT_VSR_DATA, BIT(12));
+
+		/* CT timing fix */
+		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) | BIT(1));
+		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
+				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
+				    BIT(10) | BIT(2) | BIT(1));
+
+		/* set the controller speed */
+		ahci_berlin_reg_set(ctrl_reg + PORT_SCR_CTL,
+				    BIT(6) | BIT(5) | BIT(0));
+	}
+
+	/* power up pll */
+	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
+	ahci_berlin_reg_clear_set(mmio + HOST_VSA_DATA, BIT(6), 0x0);
+}
+
+static const struct ata_port_info ahci_berlin_port_info = {
+	.flags		= AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
+	.pio_mask	= ATA_PIO4,
+	.udma_mask	= ATA_UDMA6,
+	.port_ops	= &ahci_platform_ops,
+};
+
+static int ahci_berlin_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	struct device_node *np = dev->of_node;
+	struct ahci_host_priv *hpriv;
+	int ret, nports, force_map = 0;
+
+	hpriv = ahci_platform_get_resources(pdev);
+	if (IS_ERR(hpriv)) {
+		dev_err(dev, "cannot get AHCI resources\n");
+		return PTR_ERR(hpriv);
+	}
+
+	ret = ahci_platform_enable_resources(hpriv);
+	if (ret) {
+		dev_err(dev, "cannot enable resources: %d\n", ret);
+		return ret;
+	}
+
+	nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
+
+	/* force_map is modified only if the property is found */
+	of_property_read_u32(np, "marvell,force-port-map", &force_map);
+	if (force_map)
+		nports = force_map;
+
+	ahci_berlin_init(hpriv->mmio);
+	ahci_berlin_port_init(hpriv->mmio, nports);
+
+	ret = ahci_platform_init_host(pdev, hpriv, &ahci_berlin_port_info,
+				      force_map, 0);
+	if (ret) {
+		dev_err(dev, "host init failed: %d\n", ret);
+		goto disable_resources;
+	}
+
+	return 0;
+
+disable_resources:
+	ahci_platform_disable_resources(hpriv);
+	return ret;
+}
+
+static const struct of_device_id ahci_berlin_of_match[] = {
+	{ .compatible = "marvell,berlin-ahci" },
+	{ },
+};
+MODULE_DEVICE_TABLE(of, ahci_berlin_of_match);
+
+static struct platform_driver ahci_berlin_driver = {
+	.probe	= ahci_berlin_probe,
+	.remove	= ata_platform_remove_one,
+	.driver	= {
+		.name		= "ahci-berlin",
+		.owner		= THIS_MODULE,
+		.of_match_table = ahci_berlin_of_match,
+	},
+};
+module_platform_driver(ahci_berlin_driver);
+
+MODULE_DESCRIPTION("Marvell Berlin AHCI SATA driver");
+MODULE_AUTHOR("Antoine T?nart <antoine.tenart@free-electrons.com>");
+MODULE_LICENSE("GPL");
-- 
1.8.3.2

[PATCH 2/6] Documentation: bindings: add the berlin-achi compatible to the ahci platform

[Antoine Ténart]

The berlin-achi driver allows Berlin SoCs to support their AHCI SATA controller.
Add the compatible to the device tree bindings documentation.

Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
---
 Documentation/devicetree/bindings/ata/ahci-platform.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt
index 48b285ffa3a6..9987b63aaa10 100644
--- a/Documentation/devicetree/bindings/ata/ahci-platform.txt
+++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt
@@ -7,7 +7,8 @@ Required properties:
 - compatible        : compatible list, one of "snps,spear-ahci",
                       "snps,exynos5440-ahci", "ibm,476gtr-ahci",
                       "allwinner,sun4i-a10-ahci", "fsl,imx53-ahci"
-                      "fsl,imx6q-ahci" or "snps,dwc-ahci"
+                      "fsl,imx6q-ahci", "snps,dwc-ahci" or
+		      "marvell,berlin-ahci"
 - interrupts        : <interrupt mapping for SATA IRQ>
 - reg               : <registers mapping>
 
-- 
1.8.3.2

[PATCH 2/6] Documentation: bindings: add the berlin-achi compatible to the ahci platform

[Antoine Ténart]

The berlin-achi driver allows Berlin SoCs to support their AHCI SATA controller.
Add the compatible to the device tree bindings documentation.

Signed-off-by: Antoine T?nart <antoine.tenart@free-electrons.com>
---
 Documentation/devicetree/bindings/ata/ahci-platform.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt
index 48b285ffa3a6..9987b63aaa10 100644
--- a/Documentation/devicetree/bindings/ata/ahci-platform.txt
+++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt
@@ -7,7 +7,8 @@ Required properties:
 - compatible        : compatible list, one of "snps,spear-ahci",
                       "snps,exynos5440-ahci", "ibm,476gtr-ahci",
                       "allwinner,sun4i-a10-ahci", "fsl,imx53-ahci"
-                      "fsl,imx6q-ahci" or "snps,dwc-ahci"
+                      "fsl,imx6q-ahci", "snps,dwc-ahci" or
+		      "marvell,berlin-ahci"
 - interrupts        : <interrupt mapping for SATA IRQ>
 - reg               : <registers mapping>
 
-- 
1.8.3.2

[PATCH 3/6] ARM: berlin: add the AHCI node for the BG2Q

[Antoine Ténart]

The BG2Q has an AHCI SATA controller. Add the corresponding node
in its device tree.

Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
---
 arch/arm/boot/dts/berlin2q.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
index 07452a7483fa..8e58aae73365 100644
--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi
@@ -183,6 +183,18 @@
 			};
 		};
 
+		ahci: sata@e90000 {
+			compatible = "marvell,berlin-ahci";
+			reg = <0xe90000 0x10000>;
+			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disable";
+		};
+
+		generic-regs@ea0110 {
+			compatible = "marvell,berlin-generic-regs", "syscon";
+			reg = <0xea0110 0x10>;
+		};
+
 		apb@fc0000 {
 			compatible = "simple-bus";
 			#address-cells = <1>;
-- 
1.8.3.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 3/6] ARM: berlin: add the AHCI node for the BG2Q

[Antoine Ténart]

The BG2Q has an AHCI SATA controller. Add the corresponding node
in its device tree.

Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
---
 arch/arm/boot/dts/berlin2q.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
index 07452a7483fa..8e58aae73365 100644
--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi
@@ -183,6 +183,18 @@
 			};
 		};
 
+		ahci: sata@e90000 {
+			compatible = "marvell,berlin-ahci";
+			reg = <0xe90000 0x10000>;
+			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disable";
+		};
+
+		generic-regs@ea0110 {
+			compatible = "marvell,berlin-generic-regs", "syscon";
+			reg = <0xea0110 0x10>;
+		};
+
 		apb@fc0000 {
 			compatible = "simple-bus";
 			#address-cells = <1>;
-- 
1.8.3.2

[PATCH 3/6] ARM: berlin: add the AHCI node for the BG2Q

[Antoine Ténart]

The BG2Q has an AHCI SATA controller. Add the corresponding node
in its device tree.

Signed-off-by: Antoine T?nart <antoine.tenart@free-electrons.com>
---
 arch/arm/boot/dts/berlin2q.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
index 07452a7483fa..8e58aae73365 100644
--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi
@@ -183,6 +183,18 @@
 			};
 		};
 
+		ahci: sata at e90000 {
+			compatible = "marvell,berlin-ahci";
+			reg = <0xe90000 0x10000>;
+			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disable";
+		};
+
+		generic-regs at ea0110 {
+			compatible = "marvell,berlin-generic-regs", "syscon";
+			reg = <0xea0110 0x10>;
+		};
+
 		apb at fc0000 {
 			compatible = "simple-bus";
 			#address-cells = <1>;
-- 
1.8.3.2

[PATCH 4/6] ARM: berlin: enable the eSATA interface on the BG2Q DMP

[Antoine Ténart]

The BG2Q has an AHCI SATA controller with an eSATA interface. Enable it.

Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
---
 arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
index 2da9c41e29d8..26047ceed603 100644
--- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
+++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
@@ -26,3 +26,8 @@
 &uart0 {
 	status = "okay";
 };
+
+&ahci {
+	status = "okay";
+	marvell,force-port-map = <1>;
+};
-- 
1.8.3.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 4/6] ARM: berlin: enable the eSATA interface on the BG2Q DMP

[Antoine Ténart]

The BG2Q has an AHCI SATA controller with an eSATA interface. Enable it.

Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
---
 arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
index 2da9c41e29d8..26047ceed603 100644
--- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
+++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
@@ -26,3 +26,8 @@
 &uart0 {
 	status = "okay";
 };
+
+&ahci {
+	status = "okay";
+	marvell,force-port-map = <1>;
+};
-- 
1.8.3.2

[PATCH 4/6] ARM: berlin: enable the eSATA interface on the BG2Q DMP

[Antoine Ténart]

The BG2Q has an AHCI SATA controller with an eSATA interface. Enable it.

Signed-off-by: Antoine T?nart <antoine.tenart@free-electrons.com>
---
 arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
index 2da9c41e29d8..26047ceed603 100644
--- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
+++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts
@@ -26,3 +26,8 @@
 &uart0 {
 	status = "okay";
 };
+
+&ahci {
+	status = "okay";
+	marvell,force-port-map = <1>;
+};
-- 
1.8.3.2

[PATCH 5/6] ARM: berlin: add the AHCI node for the BG2

[Antoine Ténart]

The BG2 has an AHCI SATA controller. Add the corresponding node
in its device tree.

Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
---
 arch/arm/boot/dts/berlin2.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm/boot/dts/berlin2.dtsi
index 56a1af2f1052..3e98d9fa9ec7 100644
--- a/arch/arm/boot/dts/berlin2.dtsi
+++ b/arch/arm/boot/dts/berlin2.dtsi
@@ -176,6 +176,13 @@
 			};
 		};
 
+		ahci: sata@e90000 {
+			compatible = "marvell,berlin-ahci";
+			reg = <0xe90000 0x10000>;
+			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disable";
+		};
+
 		apb@fc0000 {
 			compatible = "simple-bus";
 			#address-cells = <1>;
-- 
1.8.3.2

[PATCH 5/6] ARM: berlin: add the AHCI node for the BG2

[Antoine Ténart]

The BG2 has an AHCI SATA controller. Add the corresponding node
in its device tree.

Signed-off-by: Antoine T?nart <antoine.tenart@free-electrons.com>
---
 arch/arm/boot/dts/berlin2.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm/boot/dts/berlin2.dtsi
index 56a1af2f1052..3e98d9fa9ec7 100644
--- a/arch/arm/boot/dts/berlin2.dtsi
+++ b/arch/arm/boot/dts/berlin2.dtsi
@@ -176,6 +176,13 @@
 			};
 		};
 
+		ahci: sata at e90000 {
+			compatible = "marvell,berlin-ahci";
+			reg = <0xe90000 0x10000>;
+			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disable";
+		};
+
 		apb at fc0000 {
 			compatible = "simple-bus";
 			#address-cells = <1>;
-- 
1.8.3.2

[PATCH 6/6] ARM: berlin: add the AHCI node for the BG2CD

[Antoine Ténart]

The BG2CD has an AHCI SATA controller. Add the corresponding node
in its device tree.

Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
---
 arch/arm/boot/dts/berlin2cd.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/berlin2cd.dtsi b/arch/arm/boot/dts/berlin2cd.dtsi
index 094968c27533..3974a5cafccf 100644
--- a/arch/arm/boot/dts/berlin2cd.dtsi
+++ b/arch/arm/boot/dts/berlin2cd.dtsi
@@ -169,6 +169,13 @@
 			};
 		};
 
+		ahci: sata@e90000 {
+			compatible = "marvell,berlin-ahci";
+			reg = <0xe90000 0x10000>;
+			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disable";
+		};
+
 		apb@fc0000 {
 			compatible = "simple-bus";
 			#address-cells = <1>;
-- 
1.8.3.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 6/6] ARM: berlin: add the AHCI node for the BG2CD

[Antoine Ténart]

The BG2CD has an AHCI SATA controller. Add the corresponding node
in its device tree.

Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
---
 arch/arm/boot/dts/berlin2cd.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/berlin2cd.dtsi b/arch/arm/boot/dts/berlin2cd.dtsi
index 094968c27533..3974a5cafccf 100644
--- a/arch/arm/boot/dts/berlin2cd.dtsi
+++ b/arch/arm/boot/dts/berlin2cd.dtsi
@@ -169,6 +169,13 @@
 			};
 		};
 
+		ahci: sata@e90000 {
+			compatible = "marvell,berlin-ahci";
+			reg = <0xe90000 0x10000>;
+			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disable";
+		};
+
 		apb@fc0000 {
 			compatible = "simple-bus";
 			#address-cells = <1>;
-- 
1.8.3.2

[PATCH 6/6] ARM: berlin: add the AHCI node for the BG2CD

[Antoine Ténart]

The BG2CD has an AHCI SATA controller. Add the corresponding node
in its device tree.

Signed-off-by: Antoine T?nart <antoine.tenart@free-electrons.com>
---
 arch/arm/boot/dts/berlin2cd.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/berlin2cd.dtsi b/arch/arm/boot/dts/berlin2cd.dtsi
index 094968c27533..3974a5cafccf 100644
--- a/arch/arm/boot/dts/berlin2cd.dtsi
+++ b/arch/arm/boot/dts/berlin2cd.dtsi
@@ -169,6 +169,13 @@
 			};
 		};
 
+		ahci: sata at e90000 {
+			compatible = "marvell,berlin-ahci";
+			reg = <0xe90000 0x10000>;
+			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disable";
+		};
+
 		apb at fc0000 {
 			compatible = "simple-bus";
 			#address-cells = <1>;
-- 
1.8.3.2

Re: [PATCH 2/6] Documentation: bindings: add the berlin-achi compatible to the ahci platform

[Thomas Petazzoni]

Dear Antoine Ténart,

On Tue, 22 Apr 2014 17:38:21 +0200, Antoine Ténart wrote:
> The berlin-achi driver allows Berlin SoCs to support their AHCI SATA controller.
> Add the compatible to the device tree bindings documentation.
> 
> Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>

Typo in the commit title: s/achi/ahci.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[PATCH 2/6] Documentation: bindings: add the berlin-achi compatible to the ahci platform

[Thomas Petazzoni]

Dear Antoine T?nart,

On Tue, 22 Apr 2014 17:38:21 +0200, Antoine T?nart wrote:
> The berlin-achi driver allows Berlin SoCs to support their AHCI SATA controller.
> Add the compatible to the device tree bindings documentation.
> 
> Signed-off-by: Antoine T?nart <antoine.tenart@free-electrons.com>

Typo in the commit title: s/achi/ahci.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 3/6] ARM: berlin: add the AHCI node for the BG2Q

[Thomas Petazzoni]

Dear Antoine Ténart,

On Tue, 22 Apr 2014 17:38:22 +0200, Antoine Ténart wrote:
> The BG2Q has an AHCI SATA controller. Add the corresponding node
> in its device tree.

I believe the commit log should explain why an apparently unrelated
generic-regs@ node gets added in this commit.

Thanks!

Thomas

> diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
> index 07452a7483fa..8e58aae73365 100644
> --- a/arch/arm/boot/dts/berlin2q.dtsi
> +++ b/arch/arm/boot/dts/berlin2q.dtsi
> @@ -183,6 +183,18 @@
>  			};
>  		};
>  
> +		ahci: sata@e90000 {
> +			compatible = "marvell,berlin-ahci";
> +			reg = <0xe90000 0x10000>;
> +			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> +			status = "disable";
> +		};
> +
> +		generic-regs@ea0110 {
> +			compatible = "marvell,berlin-generic-regs", "syscon";
> +			reg = <0xea0110 0x10>;
> +		};
> +
>  		apb@fc0000 {
>  			compatible = "simple-bus";
>  			#address-cells = <1>;



-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[PATCH 3/6] ARM: berlin: add the AHCI node for the BG2Q

[Thomas Petazzoni]

Dear Antoine T?nart,

On Tue, 22 Apr 2014 17:38:22 +0200, Antoine T?nart wrote:
> The BG2Q has an AHCI SATA controller. Add the corresponding node
> in its device tree.

I believe the commit log should explain why an apparently unrelated
generic-regs@ node gets added in this commit.

Thanks!

Thomas

> diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
> index 07452a7483fa..8e58aae73365 100644
> --- a/arch/arm/boot/dts/berlin2q.dtsi
> +++ b/arch/arm/boot/dts/berlin2q.dtsi
> @@ -183,6 +183,18 @@
>  			};
>  		};
>  
> +		ahci: sata at e90000 {
> +			compatible = "marvell,berlin-ahci";
> +			reg = <0xe90000 0x10000>;
> +			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> +			status = "disable";
> +		};
> +
> +		generic-regs at ea0110 {
> +			compatible = "marvell,berlin-generic-regs", "syscon";
> +			reg = <0xea0110 0x10>;
> +		};
> +
>  		apb at fc0000 {
>  			compatible = "simple-bus";
>  			#address-cells = <1>;



-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 3/6] ARM: berlin: add the AHCI node for the BG2Q

[Thomas Petazzoni]

Dear Antoine Ténart,

On Tue, 22 Apr 2014 17:38:22 +0200, Antoine Ténart wrote:

> +		ahci: sata@e90000 {
> +			compatible = "marvell,berlin-ahci";
> +			reg = <0xe90000 0x10000>;
> +			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> +			status = "disable";

Should be:

			status = "disabled";

And ditto for patches 5 and 6.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[PATCH 3/6] ARM: berlin: add the AHCI node for the BG2Q

[Thomas Petazzoni]

Dear Antoine T?nart,

On Tue, 22 Apr 2014 17:38:22 +0200, Antoine T?nart wrote:

> +		ahci: sata at e90000 {
> +			compatible = "marvell,berlin-ahci";
> +			reg = <0xe90000 0x10000>;
> +			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> +			status = "disable";

Should be:

			status = "disabled";

And ditto for patches 5 and 6.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Bartlomiej Zolnierkiewicz]

Hi,

On Tuesday, April 22, 2014 05:38:20 PM Antoine Ténart wrote:
> Add support for the Berlin SoCs AHCI SATA controller allowing to
> interface with devices like external hard drives.
> 
> Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
> ---
>  drivers/ata/Kconfig       |   9 +++
>  drivers/ata/Makefile      |   1 +
>  drivers/ata/ahci_berlin.c | 175 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 185 insertions(+)
>  create mode 100644 drivers/ata/ahci_berlin.c
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 20e03a7eb8b4..c985dfcd5a6c 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -97,6 +97,15 @@ config SATA_AHCI_PLATFORM
>  
>  	  If unsure, say N.
>  
> +config AHCI_BERLIN
> +	tristate "Marvell Berlin AHCI SATA support"
> +	depends on ARCH_BERLIN
> +	help
> +	  This option enables support for the Marvell Berlin SoC's
> +	  onboard AHCI SATA.
> +
> +	  If unsure, say N.
> +
>  config AHCI_DA850
>  	tristate "DaVinci DA850 AHCI SATA support"
>  	depends on ARCH_DAVINCI_DA850
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index 44c8016e565c..7fb78d1e0a44 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -10,6 +10,7 @@ obj-$(CONFIG_SATA_INIC162X)	+= sata_inic162x.o
>  obj-$(CONFIG_SATA_SIL24)	+= sata_sil24.o
>  obj-$(CONFIG_SATA_DWC)		+= sata_dwc_460ex.o
>  obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o libahci.o
> +obj-$(CONFIG_AHCI_BERLIN)	+= ahci_berlin.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_DA850)	+= ahci_da850.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_IMX)		+= ahci_imx.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_SUNXI)	+= ahci_sunxi.o libahci.o libahci_platform.o
> diff --git a/drivers/ata/ahci_berlin.c b/drivers/ata/ahci_berlin.c
> new file mode 100644
> index 000000000000..cf1c9d3b9d18
> --- /dev/null
> +++ b/drivers/ata/ahci_berlin.c
> @@ -0,0 +1,175 @@
> +/*
> + * Marvell Berlin AHCI SATA platform driver
> + *
> + * Copyright (C) 2014 Marvell Technology Group Ltd.
> + *
> + * Antoine Ténart <antoine.tenart@free-electrons.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#include <linux/ahci_platform.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +
> +#include "ahci.h"
> +
> +#define PORT_VSR_ADDR		0x78
> +#define PORT_VSR_DATA		0x7C
> +#define HOST_VSA_ADDR		0xA0
> +#define HOST_VSA_DATA		0xA4
> +
> +static inline void ahci_berlin_reg_setbits(void __iomem *reg, u32 val)
> +{
> +	u32 regval;
> +
> +	regval = readl(reg);
> +	regval |= val;
> +	writel(regval, reg);
> +}
> +
> +static inline void ahci_berlin_reg_set(void __iomem *reg, u32 val)
> +{
> +	writel(val, reg);
> +}
> +
> +static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
> +					     u32 set_val)
> +{
> +	u32 regval;
> +
> +	regval = readl(reg);
> +	regval &= ~(clear_val);
> +	regval |= set_val;
> +	writel(regval, reg);
> +}
> +
> +static void ahci_berlin_init(void __iomem *mmio)
> +{
> +	/* interface select */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,
> +			    BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));
> +
> +}
> +
> +static void ahci_berlin_port_init(void __iomem *mmio, unsigned int ports)
> +{
> +	int p;
> +
> +	/* power down pll */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +	ahci_berlin_reg_setbits(mmio + HOST_VSA_DATA, BIT(6));
> +
> +	for (p = 0; p < ports; p++) {
> +		/* port control register */
> +		void __iomem *ctrl_reg = mmio + 0x100 + (p * 0x80);
> +
> +		/* set PHY mode to SATA, ref freq to 25 MHz */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x201);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  0xff, BIT(0));
> +
> +		/* set PHY up to 6 Gbps */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x225);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  BIT(11) | BIT(10), BIT(11));
> +
> +		/* set SEL_BITS to 40 bit */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x223);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  BIT(11) | BIT(10), BIT(11));
> +
> +		/* use max pll rate */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x202);
> +		ahci_berlin_reg_setbits(ctrl_reg + PORT_VSR_DATA, BIT(12));
> +
> +		/* CT timing fix */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) | BIT(1));
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> +				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> +				    BIT(10) | BIT(2) | BIT(1));
> +
> +		/* set the controller speed */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_SCR_CTL,
> +				    BIT(6) | BIT(5) | BIT(0));
> +	}
> +
> +	/* power up pll */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +	ahci_berlin_reg_clear_set(mmio + HOST_VSA_DATA, BIT(6), 0x0);
> +}
> +
> +static const struct ata_port_info ahci_berlin_port_info = {
> +	.flags		= AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
> +	.pio_mask	= ATA_PIO4,
> +	.udma_mask	= ATA_UDMA6,
> +	.port_ops	= &ahci_platform_ops,
> +};
> +
> +static int ahci_berlin_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct device_node *np = dev->of_node;
> +	struct ahci_host_priv *hpriv;
> +	int ret, nports, force_map = 0;
> +
> +	hpriv = ahci_platform_get_resources(pdev);
> +	if (IS_ERR(hpriv)) {
> +		dev_err(dev, "cannot get AHCI resources\n");
> +		return PTR_ERR(hpriv);
> +	}
> +
> +	ret = ahci_platform_enable_resources(hpriv);
> +	if (ret) {
> +		dev_err(dev, "cannot enable resources: %d\n", ret);
> +		return ret;
> +	}
> +
> +	nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
> +
> +	/* force_map is modified only if the property is found */
> +	of_property_read_u32(np, "marvell,force-port-map", &force_map);
> +	if (force_map)
> +		nports = force_map;
> +
> +	ahci_berlin_init(hpriv->mmio);
> +	ahci_berlin_port_init(hpriv->mmio, nports);
> +
> +	ret = ahci_platform_init_host(pdev, hpriv, &ahci_berlin_port_info,
> +				      force_map, 0);
> +	if (ret) {
> +		dev_err(dev, "host init failed: %d\n", ret);
> +		goto disable_resources;
> +	}
> +
> +	return 0;
> +
> +disable_resources:
> +	ahci_platform_disable_resources(hpriv);
> +	return ret;
> +}
> +
> +static const struct of_device_id ahci_berlin_of_match[] = {
> +	{ .compatible = "marvell,berlin-ahci" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, ahci_berlin_of_match);
> +
> +static struct platform_driver ahci_berlin_driver = {
> +	.probe	= ahci_berlin_probe,
> +	.remove	= ata_platform_remove_one,
> +	.driver	= {
> +		.name		= "ahci-berlin",
> +		.owner		= THIS_MODULE,
> +		.of_match_table = ahci_berlin_of_match,

Please add a comment explaining lack of power management support
(i.e. that your platform doesn't have PM support implemented yet).

Otherwise the driver looks fine.

> +	},
> +};
> +module_platform_driver(ahci_berlin_driver);
> +
> +MODULE_DESCRIPTION("Marvell Berlin AHCI SATA driver");
> +MODULE_AUTHOR("Antoine Ténart <antoine.tenart@free-electrons.com>");
> +MODULE_LICENSE("GPL");

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

[PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Bartlomiej Zolnierkiewicz]

Hi,

On Tuesday, April 22, 2014 05:38:20 PM Antoine T?nart wrote:
> Add support for the Berlin SoCs AHCI SATA controller allowing to
> interface with devices like external hard drives.
> 
> Signed-off-by: Antoine T?nart <antoine.tenart@free-electrons.com>
> ---
>  drivers/ata/Kconfig       |   9 +++
>  drivers/ata/Makefile      |   1 +
>  drivers/ata/ahci_berlin.c | 175 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 185 insertions(+)
>  create mode 100644 drivers/ata/ahci_berlin.c
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 20e03a7eb8b4..c985dfcd5a6c 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -97,6 +97,15 @@ config SATA_AHCI_PLATFORM
>  
>  	  If unsure, say N.
>  
> +config AHCI_BERLIN
> +	tristate "Marvell Berlin AHCI SATA support"
> +	depends on ARCH_BERLIN
> +	help
> +	  This option enables support for the Marvell Berlin SoC's
> +	  onboard AHCI SATA.
> +
> +	  If unsure, say N.
> +
>  config AHCI_DA850
>  	tristate "DaVinci DA850 AHCI SATA support"
>  	depends on ARCH_DAVINCI_DA850
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index 44c8016e565c..7fb78d1e0a44 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -10,6 +10,7 @@ obj-$(CONFIG_SATA_INIC162X)	+= sata_inic162x.o
>  obj-$(CONFIG_SATA_SIL24)	+= sata_sil24.o
>  obj-$(CONFIG_SATA_DWC)		+= sata_dwc_460ex.o
>  obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o libahci.o
> +obj-$(CONFIG_AHCI_BERLIN)	+= ahci_berlin.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_DA850)	+= ahci_da850.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_IMX)		+= ahci_imx.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_SUNXI)	+= ahci_sunxi.o libahci.o libahci_platform.o
> diff --git a/drivers/ata/ahci_berlin.c b/drivers/ata/ahci_berlin.c
> new file mode 100644
> index 000000000000..cf1c9d3b9d18
> --- /dev/null
> +++ b/drivers/ata/ahci_berlin.c
> @@ -0,0 +1,175 @@
> +/*
> + * Marvell Berlin AHCI SATA platform driver
> + *
> + * Copyright (C) 2014 Marvell Technology Group Ltd.
> + *
> + * Antoine T?nart <antoine.tenart@free-electrons.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#include <linux/ahci_platform.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +
> +#include "ahci.h"
> +
> +#define PORT_VSR_ADDR		0x78
> +#define PORT_VSR_DATA		0x7C
> +#define HOST_VSA_ADDR		0xA0
> +#define HOST_VSA_DATA		0xA4
> +
> +static inline void ahci_berlin_reg_setbits(void __iomem *reg, u32 val)
> +{
> +	u32 regval;
> +
> +	regval = readl(reg);
> +	regval |= val;
> +	writel(regval, reg);
> +}
> +
> +static inline void ahci_berlin_reg_set(void __iomem *reg, u32 val)
> +{
> +	writel(val, reg);
> +}
> +
> +static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
> +					     u32 set_val)
> +{
> +	u32 regval;
> +
> +	regval = readl(reg);
> +	regval &= ~(clear_val);
> +	regval |= set_val;
> +	writel(regval, reg);
> +}
> +
> +static void ahci_berlin_init(void __iomem *mmio)
> +{
> +	/* interface select */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,
> +			    BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));
> +
> +}
> +
> +static void ahci_berlin_port_init(void __iomem *mmio, unsigned int ports)
> +{
> +	int p;
> +
> +	/* power down pll */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +	ahci_berlin_reg_setbits(mmio + HOST_VSA_DATA, BIT(6));
> +
> +	for (p = 0; p < ports; p++) {
> +		/* port control register */
> +		void __iomem *ctrl_reg = mmio + 0x100 + (p * 0x80);
> +
> +		/* set PHY mode to SATA, ref freq to 25 MHz */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x201);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  0xff, BIT(0));
> +
> +		/* set PHY up to 6 Gbps */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x225);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  BIT(11) | BIT(10), BIT(11));
> +
> +		/* set SEL_BITS to 40 bit */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x223);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  BIT(11) | BIT(10), BIT(11));
> +
> +		/* use max pll rate */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x202);
> +		ahci_berlin_reg_setbits(ctrl_reg + PORT_VSR_DATA, BIT(12));
> +
> +		/* CT timing fix */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) | BIT(1));
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> +				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> +				    BIT(10) | BIT(2) | BIT(1));
> +
> +		/* set the controller speed */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_SCR_CTL,
> +				    BIT(6) | BIT(5) | BIT(0));
> +	}
> +
> +	/* power up pll */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +	ahci_berlin_reg_clear_set(mmio + HOST_VSA_DATA, BIT(6), 0x0);
> +}
> +
> +static const struct ata_port_info ahci_berlin_port_info = {
> +	.flags		= AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
> +	.pio_mask	= ATA_PIO4,
> +	.udma_mask	= ATA_UDMA6,
> +	.port_ops	= &ahci_platform_ops,
> +};
> +
> +static int ahci_berlin_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct device_node *np = dev->of_node;
> +	struct ahci_host_priv *hpriv;
> +	int ret, nports, force_map = 0;
> +
> +	hpriv = ahci_platform_get_resources(pdev);
> +	if (IS_ERR(hpriv)) {
> +		dev_err(dev, "cannot get AHCI resources\n");
> +		return PTR_ERR(hpriv);
> +	}
> +
> +	ret = ahci_platform_enable_resources(hpriv);
> +	if (ret) {
> +		dev_err(dev, "cannot enable resources: %d\n", ret);
> +		return ret;
> +	}
> +
> +	nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
> +
> +	/* force_map is modified only if the property is found */
> +	of_property_read_u32(np, "marvell,force-port-map", &force_map);
> +	if (force_map)
> +		nports = force_map;
> +
> +	ahci_berlin_init(hpriv->mmio);
> +	ahci_berlin_port_init(hpriv->mmio, nports);
> +
> +	ret = ahci_platform_init_host(pdev, hpriv, &ahci_berlin_port_info,
> +				      force_map, 0);
> +	if (ret) {
> +		dev_err(dev, "host init failed: %d\n", ret);
> +		goto disable_resources;
> +	}
> +
> +	return 0;
> +
> +disable_resources:
> +	ahci_platform_disable_resources(hpriv);
> +	return ret;
> +}
> +
> +static const struct of_device_id ahci_berlin_of_match[] = {
> +	{ .compatible = "marvell,berlin-ahci" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, ahci_berlin_of_match);
> +
> +static struct platform_driver ahci_berlin_driver = {
> +	.probe	= ahci_berlin_probe,
> +	.remove	= ata_platform_remove_one,
> +	.driver	= {
> +		.name		= "ahci-berlin",
> +		.owner		= THIS_MODULE,
> +		.of_match_table = ahci_berlin_of_match,

Please add a comment explaining lack of power management support
(i.e. that your platform doesn't have PM support implemented yet).

Otherwise the driver looks fine.

> +	},
> +};
> +module_platform_driver(ahci_berlin_driver);
> +
> +MODULE_DESCRIPTION("Marvell Berlin AHCI SATA driver");
> +MODULE_AUTHOR("Antoine T?nart <antoine.tenart@free-electrons.com>");
> +MODULE_LICENSE("GPL");

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Sebastian Hesselbarth]

On 04/22/2014 05:38 PM, Antoine Ténart wrote:
> Add support for the Berlin SoCs AHCI SATA controller allowing to
> interface with devices like external hard drives.
> 
> Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
> ---
>  drivers/ata/Kconfig       |   9 +++
>  drivers/ata/Makefile      |   1 +
>  drivers/ata/ahci_berlin.c | 175 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 185 insertions(+)
>  create mode 100644 drivers/ata/ahci_berlin.c
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 20e03a7eb8b4..c985dfcd5a6c 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -97,6 +97,15 @@ config SATA_AHCI_PLATFORM
>  
>  	  If unsure, say N.
>  
> +config AHCI_BERLIN
> +	tristate "Marvell Berlin AHCI SATA support"
> +	depends on ARCH_BERLIN
> +	help
> +	  This option enables support for the Marvell Berlin SoC's
> +	  onboard AHCI SATA.
> +
> +	  If unsure, say N.
> +
>  config AHCI_DA850
>  	tristate "DaVinci DA850 AHCI SATA support"
>  	depends on ARCH_DAVINCI_DA850
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index 44c8016e565c..7fb78d1e0a44 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -10,6 +10,7 @@ obj-$(CONFIG_SATA_INIC162X)	+= sata_inic162x.o
>  obj-$(CONFIG_SATA_SIL24)	+= sata_sil24.o
>  obj-$(CONFIG_SATA_DWC)		+= sata_dwc_460ex.o
>  obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o libahci.o
> +obj-$(CONFIG_AHCI_BERLIN)	+= ahci_berlin.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_DA850)	+= ahci_da850.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_IMX)		+= ahci_imx.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_SUNXI)	+= ahci_sunxi.o libahci.o libahci_platform.o
> diff --git a/drivers/ata/ahci_berlin.c b/drivers/ata/ahci_berlin.c
> new file mode 100644
> index 000000000000..cf1c9d3b9d18
> --- /dev/null
> +++ b/drivers/ata/ahci_berlin.c
> @@ -0,0 +1,175 @@
> +/*
> + * Marvell Berlin AHCI SATA platform driver
> + *
> + * Copyright (C) 2014 Marvell Technology Group Ltd.
> + *
> + * Antoine Ténart <antoine.tenart@free-electrons.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#include <linux/ahci_platform.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +
> +#include "ahci.h"
> +
> +#define PORT_VSR_ADDR		0x78
> +#define PORT_VSR_DATA		0x7C
> +#define HOST_VSA_ADDR		0xA0
> +#define HOST_VSA_DATA		0xA4
> +
> +static inline void ahci_berlin_reg_setbits(void __iomem *reg, u32 val)
> +{
> +	u32 regval;
> +
> +	regval = readl(reg);
> +	regval |= val;
> +	writel(regval, reg);
> +}
> +
> +static inline void ahci_berlin_reg_set(void __iomem *reg, u32 val)
> +{
> +	writel(val, reg);
> +}

Antoine,

if you really need to rename writel, the above function name should
end with _write.

> +static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
> +					     u32 set_val)
> +{
> +	u32 regval;
> +
> +	regval = readl(reg);
> +	regval &= ~(clear_val);
> +	regval |= set_val;
> +	writel(regval, reg);
> +}

ahci_berlin_reg_setbits(reg, val) == ahci_berlin_reg_clear_set(reg, 0, val);

Maybe get rid of the latter?

> +static void ahci_berlin_init(void __iomem *mmio)
> +{
> +	/* interface select */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,
> +			    BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));

Any chance we get named #defines for the BIT()s above and below?

> +
> +}
> +
> +static void ahci_berlin_port_init(void __iomem *mmio, unsigned int ports)
> +{
> +	int p;
> +
> +	/* power down pll */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +	ahci_berlin_reg_setbits(mmio + HOST_VSA_DATA, BIT(6));
> +
> +	for (p = 0; p < ports; p++) {
> +		/* port control register */
> +		void __iomem *ctrl_reg = mmio + 0x100 + (p * 0x80);
> +
> +		/* set PHY mode to SATA, ref freq to 25 MHz */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x201);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  0xff, BIT(0));
> +
> +		/* set PHY up to 6 Gbps */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x225);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  BIT(11) | BIT(10), BIT(11));
> +
> +		/* set SEL_BITS to 40 bit */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x223);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  BIT(11) | BIT(10), BIT(11));
> +
> +		/* use max pll rate */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x202);
> +		ahci_berlin_reg_setbits(ctrl_reg + PORT_VSR_DATA, BIT(12));
> +
> +		/* CT timing fix */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) | BIT(1));
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> +				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> +				    BIT(10) | BIT(2) | BIT(1));
> +
> +		/* set the controller speed */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_SCR_CTL,
> +				    BIT(6) | BIT(5) | BIT(0));
> +	}
> +
> +	/* power up pll */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +	ahci_berlin_reg_clear_set(mmio + HOST_VSA_DATA, BIT(6), 0x0);
> +}
> +
> +static const struct ata_port_info ahci_berlin_port_info = {
> +	.flags		= AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
> +	.pio_mask	= ATA_PIO4,
> +	.udma_mask	= ATA_UDMA6,
> +	.port_ops	= &ahci_platform_ops,
> +};
> +
> +static int ahci_berlin_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct device_node *np = dev->of_node;
> +	struct ahci_host_priv *hpriv;
> +	int ret, nports, force_map = 0;
> +
> +	hpriv = ahci_platform_get_resources(pdev);
> +	if (IS_ERR(hpriv)) {
> +		dev_err(dev, "cannot get AHCI resources\n");
> +		return PTR_ERR(hpriv);
> +	}
> +
> +	ret = ahci_platform_enable_resources(hpriv);
> +	if (ret) {
> +		dev_err(dev, "cannot enable resources: %d\n", ret);
> +		return ret;
> +	}
> +
> +	nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
> +
> +	/* force_map is modified only if the property is found */
> +	of_property_read_u32(np, "marvell,force-port-map", &force_map);
> +	if (force_map)
> +		nports = force_map;

marvell,force-port-map is undocumented and its name does not reflect
what it is about. Before you just rename it to marvell,nr-ports or
something, how about having one sub-node per port:

sata_phy0: sata-phy@e90100 {
	compatible = "marvell,berlin-sata-phy";
	reg = <0xe90100 0x80>;
	status = "disabled";
};

sata_phy1: sata-phy@e90180 {
	compatible = "marvell,berlin-sata-phy";
	reg = <0xe90180 0x80>;
	status = "disabled";
};

ahci: sata@e90000 {
	compatible = "marvell,berlin-ahci";
	reg = <0xe90000 0x100>;
	interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
	#address-cells = <1>;
	#size-cells = <0>;
	status = "disabled";

	sata-port@0 {
		reg = <0>;
		sata-phy = <&sata_phy0>;
		status = "disabled";
	};

	sata-port@1 {
		reg = <1>;
		sata-phy = <&sata_phy1>;
		status = "okay";
	};
};

That way you can
(a) separate a PHY driver that has little code but is able to power-down
    the PHY even if there is no AHCI driver loaded.
(b) enable/disable each port individually.
(c) enable port1 while port0 is disabled.
(d) disable the PLL if there is no port enabled at all.

Sebastian

> +
> +	ahci_berlin_init(hpriv->mmio);
> +	ahci_berlin_port_init(hpriv->mmio, nports);
> +
> +	ret = ahci_platform_init_host(pdev, hpriv, &ahci_berlin_port_info,
> +				      force_map, 0);
> +	if (ret) {
> +		dev_err(dev, "host init failed: %d\n", ret);
> +		goto disable_resources;
> +	}
> +
> +	return 0;
> +
> +disable_resources:
> +	ahci_platform_disable_resources(hpriv);
> +	return ret;
> +}
> +
> +static const struct of_device_id ahci_berlin_of_match[] = {
> +	{ .compatible = "marvell,berlin-ahci" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, ahci_berlin_of_match);
> +
> +static struct platform_driver ahci_berlin_driver = {
> +	.probe	= ahci_berlin_probe,
> +	.remove	= ata_platform_remove_one,
> +	.driver	= {
> +		.name		= "ahci-berlin",
> +		.owner		= THIS_MODULE,
> +		.of_match_table = ahci_berlin_of_match,
> +	},
> +};
> +module_platform_driver(ahci_berlin_driver);
> +
> +MODULE_DESCRIPTION("Marvell Berlin AHCI SATA driver");
> +MODULE_AUTHOR("Antoine Ténart <antoine.tenart@free-electrons.com>");
> +MODULE_LICENSE("GPL");
> 

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Sebastian Hesselbarth]

On 04/22/2014 05:38 PM, Antoine Ténart wrote:
> Add support for the Berlin SoCs AHCI SATA controller allowing to
> interface with devices like external hard drives.
> 
> Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
> ---
>  drivers/ata/Kconfig       |   9 +++
>  drivers/ata/Makefile      |   1 +
>  drivers/ata/ahci_berlin.c | 175 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 185 insertions(+)
>  create mode 100644 drivers/ata/ahci_berlin.c
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 20e03a7eb8b4..c985dfcd5a6c 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -97,6 +97,15 @@ config SATA_AHCI_PLATFORM
>  
>  	  If unsure, say N.
>  
> +config AHCI_BERLIN
> +	tristate "Marvell Berlin AHCI SATA support"
> +	depends on ARCH_BERLIN
> +	help
> +	  This option enables support for the Marvell Berlin SoC's
> +	  onboard AHCI SATA.
> +
> +	  If unsure, say N.
> +
>  config AHCI_DA850
>  	tristate "DaVinci DA850 AHCI SATA support"
>  	depends on ARCH_DAVINCI_DA850
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index 44c8016e565c..7fb78d1e0a44 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -10,6 +10,7 @@ obj-$(CONFIG_SATA_INIC162X)	+= sata_inic162x.o
>  obj-$(CONFIG_SATA_SIL24)	+= sata_sil24.o
>  obj-$(CONFIG_SATA_DWC)		+= sata_dwc_460ex.o
>  obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o libahci.o
> +obj-$(CONFIG_AHCI_BERLIN)	+= ahci_berlin.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_DA850)	+= ahci_da850.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_IMX)		+= ahci_imx.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_SUNXI)	+= ahci_sunxi.o libahci.o libahci_platform.o
> diff --git a/drivers/ata/ahci_berlin.c b/drivers/ata/ahci_berlin.c
> new file mode 100644
> index 000000000000..cf1c9d3b9d18
> --- /dev/null
> +++ b/drivers/ata/ahci_berlin.c
> @@ -0,0 +1,175 @@
> +/*
> + * Marvell Berlin AHCI SATA platform driver
> + *
> + * Copyright (C) 2014 Marvell Technology Group Ltd.
> + *
> + * Antoine Ténart <antoine.tenart@free-electrons.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#include <linux/ahci_platform.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +
> +#include "ahci.h"
> +
> +#define PORT_VSR_ADDR		0x78
> +#define PORT_VSR_DATA		0x7C
> +#define HOST_VSA_ADDR		0xA0
> +#define HOST_VSA_DATA		0xA4
> +
> +static inline void ahci_berlin_reg_setbits(void __iomem *reg, u32 val)
> +{
> +	u32 regval;
> +
> +	regval = readl(reg);
> +	regval |= val;
> +	writel(regval, reg);
> +}
> +
> +static inline void ahci_berlin_reg_set(void __iomem *reg, u32 val)
> +{
> +	writel(val, reg);
> +}

Antoine,

if you really need to rename writel, the above function name should
end with _write.

> +static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
> +					     u32 set_val)
> +{
> +	u32 regval;
> +
> +	regval = readl(reg);
> +	regval &= ~(clear_val);
> +	regval |= set_val;
> +	writel(regval, reg);
> +}

ahci_berlin_reg_setbits(reg, val) == ahci_berlin_reg_clear_set(reg, 0, val);

Maybe get rid of the latter?

> +static void ahci_berlin_init(void __iomem *mmio)
> +{
> +	/* interface select */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,
> +			    BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));

Any chance we get named #defines for the BIT()s above and below?

> +
> +}
> +
> +static void ahci_berlin_port_init(void __iomem *mmio, unsigned int ports)
> +{
> +	int p;
> +
> +	/* power down pll */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +	ahci_berlin_reg_setbits(mmio + HOST_VSA_DATA, BIT(6));
> +
> +	for (p = 0; p < ports; p++) {
> +		/* port control register */
> +		void __iomem *ctrl_reg = mmio + 0x100 + (p * 0x80);
> +
> +		/* set PHY mode to SATA, ref freq to 25 MHz */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x201);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  0xff, BIT(0));
> +
> +		/* set PHY up to 6 Gbps */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x225);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  BIT(11) | BIT(10), BIT(11));
> +
> +		/* set SEL_BITS to 40 bit */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x223);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  BIT(11) | BIT(10), BIT(11));
> +
> +		/* use max pll rate */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x202);
> +		ahci_berlin_reg_setbits(ctrl_reg + PORT_VSR_DATA, BIT(12));
> +
> +		/* CT timing fix */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) | BIT(1));
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> +				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> +				    BIT(10) | BIT(2) | BIT(1));
> +
> +		/* set the controller speed */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_SCR_CTL,
> +				    BIT(6) | BIT(5) | BIT(0));
> +	}
> +
> +	/* power up pll */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +	ahci_berlin_reg_clear_set(mmio + HOST_VSA_DATA, BIT(6), 0x0);
> +}
> +
> +static const struct ata_port_info ahci_berlin_port_info = {
> +	.flags		= AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
> +	.pio_mask	= ATA_PIO4,
> +	.udma_mask	= ATA_UDMA6,
> +	.port_ops	= &ahci_platform_ops,
> +};
> +
> +static int ahci_berlin_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct device_node *np = dev->of_node;
> +	struct ahci_host_priv *hpriv;
> +	int ret, nports, force_map = 0;
> +
> +	hpriv = ahci_platform_get_resources(pdev);
> +	if (IS_ERR(hpriv)) {
> +		dev_err(dev, "cannot get AHCI resources\n");
> +		return PTR_ERR(hpriv);
> +	}
> +
> +	ret = ahci_platform_enable_resources(hpriv);
> +	if (ret) {
> +		dev_err(dev, "cannot enable resources: %d\n", ret);
> +		return ret;
> +	}
> +
> +	nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
> +
> +	/* force_map is modified only if the property is found */
> +	of_property_read_u32(np, "marvell,force-port-map", &force_map);
> +	if (force_map)
> +		nports = force_map;

marvell,force-port-map is undocumented and its name does not reflect
what it is about. Before you just rename it to marvell,nr-ports or
something, how about having one sub-node per port:

sata_phy0: sata-phy@e90100 {
	compatible = "marvell,berlin-sata-phy";
	reg = <0xe90100 0x80>;
	status = "disabled";
};

sata_phy1: sata-phy@e90180 {
	compatible = "marvell,berlin-sata-phy";
	reg = <0xe90180 0x80>;
	status = "disabled";
};

ahci: sata@e90000 {
	compatible = "marvell,berlin-ahci";
	reg = <0xe90000 0x100>;
	interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
	#address-cells = <1>;
	#size-cells = <0>;
	status = "disabled";

	sata-port@0 {
		reg = <0>;
		sata-phy = <&sata_phy0>;
		status = "disabled";
	};

	sata-port@1 {
		reg = <1>;
		sata-phy = <&sata_phy1>;
		status = "okay";
	};
};

That way you can
(a) separate a PHY driver that has little code but is able to power-down
    the PHY even if there is no AHCI driver loaded.
(b) enable/disable each port individually.
(c) enable port1 while port0 is disabled.
(d) disable the PLL if there is no port enabled at all.

Sebastian

> +
> +	ahci_berlin_init(hpriv->mmio);
> +	ahci_berlin_port_init(hpriv->mmio, nports);
> +
> +	ret = ahci_platform_init_host(pdev, hpriv, &ahci_berlin_port_info,
> +				      force_map, 0);
> +	if (ret) {
> +		dev_err(dev, "host init failed: %d\n", ret);
> +		goto disable_resources;
> +	}
> +
> +	return 0;
> +
> +disable_resources:
> +	ahci_platform_disable_resources(hpriv);
> +	return ret;
> +}
> +
> +static const struct of_device_id ahci_berlin_of_match[] = {
> +	{ .compatible = "marvell,berlin-ahci" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, ahci_berlin_of_match);
> +
> +static struct platform_driver ahci_berlin_driver = {
> +	.probe	= ahci_berlin_probe,
> +	.remove	= ata_platform_remove_one,
> +	.driver	= {
> +		.name		= "ahci-berlin",
> +		.owner		= THIS_MODULE,
> +		.of_match_table = ahci_berlin_of_match,
> +	},
> +};
> +module_platform_driver(ahci_berlin_driver);
> +
> +MODULE_DESCRIPTION("Marvell Berlin AHCI SATA driver");
> +MODULE_AUTHOR("Antoine Ténart <antoine.tenart@free-electrons.com>");
> +MODULE_LICENSE("GPL");
> 

[PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Sebastian Hesselbarth]

On 04/22/2014 05:38 PM, Antoine T?nart wrote:
> Add support for the Berlin SoCs AHCI SATA controller allowing to
> interface with devices like external hard drives.
> 
> Signed-off-by: Antoine T?nart <antoine.tenart@free-electrons.com>
> ---
>  drivers/ata/Kconfig       |   9 +++
>  drivers/ata/Makefile      |   1 +
>  drivers/ata/ahci_berlin.c | 175 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 185 insertions(+)
>  create mode 100644 drivers/ata/ahci_berlin.c
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 20e03a7eb8b4..c985dfcd5a6c 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -97,6 +97,15 @@ config SATA_AHCI_PLATFORM
>  
>  	  If unsure, say N.
>  
> +config AHCI_BERLIN
> +	tristate "Marvell Berlin AHCI SATA support"
> +	depends on ARCH_BERLIN
> +	help
> +	  This option enables support for the Marvell Berlin SoC's
> +	  onboard AHCI SATA.
> +
> +	  If unsure, say N.
> +
>  config AHCI_DA850
>  	tristate "DaVinci DA850 AHCI SATA support"
>  	depends on ARCH_DAVINCI_DA850
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index 44c8016e565c..7fb78d1e0a44 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -10,6 +10,7 @@ obj-$(CONFIG_SATA_INIC162X)	+= sata_inic162x.o
>  obj-$(CONFIG_SATA_SIL24)	+= sata_sil24.o
>  obj-$(CONFIG_SATA_DWC)		+= sata_dwc_460ex.o
>  obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o libahci.o
> +obj-$(CONFIG_AHCI_BERLIN)	+= ahci_berlin.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_DA850)	+= ahci_da850.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_IMX)		+= ahci_imx.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_SUNXI)	+= ahci_sunxi.o libahci.o libahci_platform.o
> diff --git a/drivers/ata/ahci_berlin.c b/drivers/ata/ahci_berlin.c
> new file mode 100644
> index 000000000000..cf1c9d3b9d18
> --- /dev/null
> +++ b/drivers/ata/ahci_berlin.c
> @@ -0,0 +1,175 @@
> +/*
> + * Marvell Berlin AHCI SATA platform driver
> + *
> + * Copyright (C) 2014 Marvell Technology Group Ltd.
> + *
> + * Antoine T?nart <antoine.tenart@free-electrons.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#include <linux/ahci_platform.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +
> +#include "ahci.h"
> +
> +#define PORT_VSR_ADDR		0x78
> +#define PORT_VSR_DATA		0x7C
> +#define HOST_VSA_ADDR		0xA0
> +#define HOST_VSA_DATA		0xA4
> +
> +static inline void ahci_berlin_reg_setbits(void __iomem *reg, u32 val)
> +{
> +	u32 regval;
> +
> +	regval = readl(reg);
> +	regval |= val;
> +	writel(regval, reg);
> +}
> +
> +static inline void ahci_berlin_reg_set(void __iomem *reg, u32 val)
> +{
> +	writel(val, reg);
> +}

Antoine,

if you really need to rename writel, the above function name should
end with _write.

> +static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
> +					     u32 set_val)
> +{
> +	u32 regval;
> +
> +	regval = readl(reg);
> +	regval &= ~(clear_val);
> +	regval |= set_val;
> +	writel(regval, reg);
> +}

ahci_berlin_reg_setbits(reg, val) == ahci_berlin_reg_clear_set(reg, 0, val);

Maybe get rid of the latter?

> +static void ahci_berlin_init(void __iomem *mmio)
> +{
> +	/* interface select */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,
> +			    BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));

Any chance we get named #defines for the BIT()s above and below?

> +
> +}
> +
> +static void ahci_berlin_port_init(void __iomem *mmio, unsigned int ports)
> +{
> +	int p;
> +
> +	/* power down pll */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +	ahci_berlin_reg_setbits(mmio + HOST_VSA_DATA, BIT(6));
> +
> +	for (p = 0; p < ports; p++) {
> +		/* port control register */
> +		void __iomem *ctrl_reg = mmio + 0x100 + (p * 0x80);
> +
> +		/* set PHY mode to SATA, ref freq to 25 MHz */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x201);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  0xff, BIT(0));
> +
> +		/* set PHY up to 6 Gbps */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x225);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  BIT(11) | BIT(10), BIT(11));
> +
> +		/* set SEL_BITS to 40 bit */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x223);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  BIT(11) | BIT(10), BIT(11));
> +
> +		/* use max pll rate */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x202);
> +		ahci_berlin_reg_setbits(ctrl_reg + PORT_VSR_DATA, BIT(12));
> +
> +		/* CT timing fix */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) | BIT(1));
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> +				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> +				    BIT(10) | BIT(2) | BIT(1));
> +
> +		/* set the controller speed */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_SCR_CTL,
> +				    BIT(6) | BIT(5) | BIT(0));
> +	}
> +
> +	/* power up pll */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +	ahci_berlin_reg_clear_set(mmio + HOST_VSA_DATA, BIT(6), 0x0);
> +}
> +
> +static const struct ata_port_info ahci_berlin_port_info = {
> +	.flags		= AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
> +	.pio_mask	= ATA_PIO4,
> +	.udma_mask	= ATA_UDMA6,
> +	.port_ops	= &ahci_platform_ops,
> +};
> +
> +static int ahci_berlin_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct device_node *np = dev->of_node;
> +	struct ahci_host_priv *hpriv;
> +	int ret, nports, force_map = 0;
> +
> +	hpriv = ahci_platform_get_resources(pdev);
> +	if (IS_ERR(hpriv)) {
> +		dev_err(dev, "cannot get AHCI resources\n");
> +		return PTR_ERR(hpriv);
> +	}
> +
> +	ret = ahci_platform_enable_resources(hpriv);
> +	if (ret) {
> +		dev_err(dev, "cannot enable resources: %d\n", ret);
> +		return ret;
> +	}
> +
> +	nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
> +
> +	/* force_map is modified only if the property is found */
> +	of_property_read_u32(np, "marvell,force-port-map", &force_map);
> +	if (force_map)
> +		nports = force_map;

marvell,force-port-map is undocumented and its name does not reflect
what it is about. Before you just rename it to marvell,nr-ports or
something, how about having one sub-node per port:

sata_phy0: sata-phy at e90100 {
	compatible = "marvell,berlin-sata-phy";
	reg = <0xe90100 0x80>;
	status = "disabled";
};

sata_phy1: sata-phy at e90180 {
	compatible = "marvell,berlin-sata-phy";
	reg = <0xe90180 0x80>;
	status = "disabled";
};

ahci: sata at e90000 {
	compatible = "marvell,berlin-ahci";
	reg = <0xe90000 0x100>;
	interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
	#address-cells = <1>;
	#size-cells = <0>;
	status = "disabled";

	sata-port at 0 {
		reg = <0>;
		sata-phy = <&sata_phy0>;
		status = "disabled";
	};

	sata-port at 1 {
		reg = <1>;
		sata-phy = <&sata_phy1>;
		status = "okay";
	};
};

That way you can
(a) separate a PHY driver that has little code but is able to power-down
    the PHY even if there is no AHCI driver loaded.
(b) enable/disable each port individually.
(c) enable port1 while port0 is disabled.
(d) disable the PLL if there is no port enabled at all.

Sebastian

> +
> +	ahci_berlin_init(hpriv->mmio);
> +	ahci_berlin_port_init(hpriv->mmio, nports);
> +
> +	ret = ahci_platform_init_host(pdev, hpriv, &ahci_berlin_port_info,
> +				      force_map, 0);
> +	if (ret) {
> +		dev_err(dev, "host init failed: %d\n", ret);
> +		goto disable_resources;
> +	}
> +
> +	return 0;
> +
> +disable_resources:
> +	ahci_platform_disable_resources(hpriv);
> +	return ret;
> +}
> +
> +static const struct of_device_id ahci_berlin_of_match[] = {
> +	{ .compatible = "marvell,berlin-ahci" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, ahci_berlin_of_match);
> +
> +static struct platform_driver ahci_berlin_driver = {
> +	.probe	= ahci_berlin_probe,
> +	.remove	= ata_platform_remove_one,
> +	.driver	= {
> +		.name		= "ahci-berlin",
> +		.owner		= THIS_MODULE,
> +		.of_match_table = ahci_berlin_of_match,
> +	},
> +};
> +module_platform_driver(ahci_berlin_driver);
> +
> +MODULE_DESCRIPTION("Marvell Berlin AHCI SATA driver");
> +MODULE_AUTHOR("Antoine T?nart <antoine.tenart@free-electrons.com>");
> +MODULE_LICENSE("GPL");
> 

Re: [PATCH 2/6] Documentation: bindings: add the berlin-achi compatible to the ahci platform

[Sebastian Hesselbarth]

On 04/22/2014 05:38 PM, Antoine Ténart wrote:
> The berlin-achi driver allows Berlin SoCs to support their AHCI SATA controller.
> Add the compatible to the device tree bindings documentation.
> 
> Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
> ---
>  Documentation/devicetree/bindings/ata/ahci-platform.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt
> index 48b285ffa3a6..9987b63aaa10 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt
> @@ -7,7 +7,8 @@ Required properties:
>  - compatible        : compatible list, one of "snps,spear-ahci",
>                        "snps,exynos5440-ahci", "ibm,476gtr-ahci",
>                        "allwinner,sun4i-a10-ahci", "fsl,imx53-ahci"
> -                      "fsl,imx6q-ahci" or "snps,dwc-ahci"
> +                      "fsl,imx6q-ahci", "snps,dwc-ahci" or
> +		      "marvell,berlin-ahci"

Besides the typo Thomas already mentioned, it looks like the compatibles
are indented by spaces while you have tabs.

Sebastian

>  - interrupts        : <interrupt mapping for SATA IRQ>
>  - reg               : <registers mapping>
>  
> 

Re: [PATCH 2/6] Documentation: bindings: add the berlin-achi compatible to the ahci platform

[Sebastian Hesselbarth]

On 04/22/2014 05:38 PM, Antoine Ténart wrote:
> The berlin-achi driver allows Berlin SoCs to support their AHCI SATA controller.
> Add the compatible to the device tree bindings documentation.
> 
> Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
> ---
>  Documentation/devicetree/bindings/ata/ahci-platform.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt
> index 48b285ffa3a6..9987b63aaa10 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt
> @@ -7,7 +7,8 @@ Required properties:
>  - compatible        : compatible list, one of "snps,spear-ahci",
>                        "snps,exynos5440-ahci", "ibm,476gtr-ahci",
>                        "allwinner,sun4i-a10-ahci", "fsl,imx53-ahci"
> -                      "fsl,imx6q-ahci" or "snps,dwc-ahci"
> +                      "fsl,imx6q-ahci", "snps,dwc-ahci" or
> +		      "marvell,berlin-ahci"

Besides the typo Thomas already mentioned, it looks like the compatibles
are indented by spaces while you have tabs.

Sebastian

>  - interrupts        : <interrupt mapping for SATA IRQ>
>  - reg               : <registers mapping>
>  
> 

[PATCH 2/6] Documentation: bindings: add the berlin-achi compatible to the ahci platform

[Sebastian Hesselbarth]

On 04/22/2014 05:38 PM, Antoine T?nart wrote:
> The berlin-achi driver allows Berlin SoCs to support their AHCI SATA controller.
> Add the compatible to the device tree bindings documentation.
> 
> Signed-off-by: Antoine T?nart <antoine.tenart@free-electrons.com>
> ---
>  Documentation/devicetree/bindings/ata/ahci-platform.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt
> index 48b285ffa3a6..9987b63aaa10 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt
> @@ -7,7 +7,8 @@ Required properties:
>  - compatible        : compatible list, one of "snps,spear-ahci",
>                        "snps,exynos5440-ahci", "ibm,476gtr-ahci",
>                        "allwinner,sun4i-a10-ahci", "fsl,imx53-ahci"
> -                      "fsl,imx6q-ahci" or "snps,dwc-ahci"
> +                      "fsl,imx6q-ahci", "snps,dwc-ahci" or
> +		      "marvell,berlin-ahci"

Besides the typo Thomas already mentioned, it looks like the compatibles
are indented by spaces while you have tabs.

Sebastian

>  - interrupts        : <interrupt mapping for SATA IRQ>
>  - reg               : <registers mapping>
>  
> 

Re: [PATCH 3/6] ARM: berlin: add the AHCI node for the BG2Q

[Sebastian Hesselbarth]

On 04/22/2014 06:28 PM, Thomas Petazzoni wrote:
> Dear Antoine Ténart,
> 
> On Tue, 22 Apr 2014 17:38:22 +0200, Antoine Ténart wrote:
>> The BG2Q has an AHCI SATA controller. Add the corresponding node
>> in its device tree.
> 
> I believe the commit log should explain why an apparently unrelated
> generic-regs@ node gets added in this commit.

generic-regs@ is from another patch, please drop it entirely.

Sebastian

>> diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
>> index 07452a7483fa..8e58aae73365 100644
>> --- a/arch/arm/boot/dts/berlin2q.dtsi
>> +++ b/arch/arm/boot/dts/berlin2q.dtsi
>> @@ -183,6 +183,18 @@
>>  			};
>>  		};
>>  
>> +		ahci: sata@e90000 {
>> +			compatible = "marvell,berlin-ahci";
>> +			reg = <0xe90000 0x10000>;
>> +			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
>> +			status = "disable";
>> +		};
>> +
>> +		generic-regs@ea0110 {
>> +			compatible = "marvell,berlin-generic-regs", "syscon";
>> +			reg = <0xea0110 0x10>;
>> +		};
>> +
>>  		apb@fc0000 {
>>  			compatible = "simple-bus";
>>  			#address-cells = <1>;
> 
> 
> 

Re: [PATCH 3/6] ARM: berlin: add the AHCI node for the BG2Q

[Sebastian Hesselbarth]

On 04/22/2014 06:28 PM, Thomas Petazzoni wrote:
> Dear Antoine Ténart,
> 
> On Tue, 22 Apr 2014 17:38:22 +0200, Antoine Ténart wrote:
>> The BG2Q has an AHCI SATA controller. Add the corresponding node
>> in its device tree.
> 
> I believe the commit log should explain why an apparently unrelated
> generic-regs@ node gets added in this commit.

generic-regs@ is from another patch, please drop it entirely.

Sebastian

>> diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
>> index 07452a7483fa..8e58aae73365 100644
>> --- a/arch/arm/boot/dts/berlin2q.dtsi
>> +++ b/arch/arm/boot/dts/berlin2q.dtsi
>> @@ -183,6 +183,18 @@
>>  			};
>>  		};
>>  
>> +		ahci: sata@e90000 {
>> +			compatible = "marvell,berlin-ahci";
>> +			reg = <0xe90000 0x10000>;
>> +			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
>> +			status = "disable";
>> +		};
>> +
>> +		generic-regs@ea0110 {
>> +			compatible = "marvell,berlin-generic-regs", "syscon";
>> +			reg = <0xea0110 0x10>;
>> +		};
>> +
>>  		apb@fc0000 {
>>  			compatible = "simple-bus";
>>  			#address-cells = <1>;
> 
> 
> 

[PATCH 3/6] ARM: berlin: add the AHCI node for the BG2Q

[Sebastian Hesselbarth]

On 04/22/2014 06:28 PM, Thomas Petazzoni wrote:
> Dear Antoine T?nart,
> 
> On Tue, 22 Apr 2014 17:38:22 +0200, Antoine T?nart wrote:
>> The BG2Q has an AHCI SATA controller. Add the corresponding node
>> in its device tree.
> 
> I believe the commit log should explain why an apparently unrelated
> generic-regs@ node gets added in this commit.

generic-regs@ is from another patch, please drop it entirely.

Sebastian

>> diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
>> index 07452a7483fa..8e58aae73365 100644
>> --- a/arch/arm/boot/dts/berlin2q.dtsi
>> +++ b/arch/arm/boot/dts/berlin2q.dtsi
>> @@ -183,6 +183,18 @@
>>  			};
>>  		};
>>  
>> +		ahci: sata at e90000 {
>> +			compatible = "marvell,berlin-ahci";
>> +			reg = <0xe90000 0x10000>;
>> +			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
>> +			status = "disable";
>> +		};
>> +
>> +		generic-regs at ea0110 {
>> +			compatible = "marvell,berlin-generic-regs", "syscon";
>> +			reg = <0xea0110 0x10>;
>> +		};
>> +
>>  		apb at fc0000 {
>>  			compatible = "simple-bus";
>>  			#address-cells = <1>;
> 
> 
> 

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Rob Herring]

On Tue, Apr 22, 2014 at 10:38 AM, Antoine Ténart
<antoine.tenart@free-electrons.com> wrote:
> Add support for the Berlin SoCs AHCI SATA controller allowing to
> interface with devices like external hard drives.
>
> Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
> ---
>  drivers/ata/Kconfig       |   9 +++
>  drivers/ata/Makefile      |   1 +
>  drivers/ata/ahci_berlin.c | 175 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 185 insertions(+)
>  create mode 100644 drivers/ata/ahci_berlin.c
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 20e03a7eb8b4..c985dfcd5a6c 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -97,6 +97,15 @@ config SATA_AHCI_PLATFORM
>
>           If unsure, say N.
>
> +config AHCI_BERLIN
> +       tristate "Marvell Berlin AHCI SATA support"
> +       depends on ARCH_BERLIN
> +       help
> +         This option enables support for the Marvell Berlin SoC's
> +         onboard AHCI SATA.
> +
> +         If unsure, say N.
> +
>  config AHCI_DA850
>         tristate "DaVinci DA850 AHCI SATA support"
>         depends on ARCH_DAVINCI_DA850
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index 44c8016e565c..7fb78d1e0a44 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -10,6 +10,7 @@ obj-$(CONFIG_SATA_INIC162X)   += sata_inic162x.o
>  obj-$(CONFIG_SATA_SIL24)       += sata_sil24.o
>  obj-$(CONFIG_SATA_DWC)         += sata_dwc_460ex.o
>  obj-$(CONFIG_SATA_HIGHBANK)    += sata_highbank.o libahci.o
> +obj-$(CONFIG_AHCI_BERLIN)      += ahci_berlin.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_DA850)       += ahci_da850.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_IMX)         += ahci_imx.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_SUNXI)       += ahci_sunxi.o libahci.o libahci_platform.o
> diff --git a/drivers/ata/ahci_berlin.c b/drivers/ata/ahci_berlin.c
> new file mode 100644
> index 000000000000..cf1c9d3b9d18
> --- /dev/null
> +++ b/drivers/ata/ahci_berlin.c
> @@ -0,0 +1,175 @@
> +/*
> + * Marvell Berlin AHCI SATA platform driver
> + *
> + * Copyright (C) 2014 Marvell Technology Group Ltd.
> + *
> + * Antoine Ténart <antoine.tenart@free-electrons.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#include <linux/ahci_platform.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +
> +#include "ahci.h"
> +
> +#define PORT_VSR_ADDR          0x78
> +#define PORT_VSR_DATA          0x7C
> +#define HOST_VSA_ADDR          0xA0
> +#define HOST_VSA_DATA          0xA4
> +
> +static inline void ahci_berlin_reg_setbits(void __iomem *reg, u32 val)
> +{
> +       u32 regval;
> +
> +       regval = readl(reg);
> +       regval |= val;
> +       writel(regval, reg);
> +}
> +
> +static inline void ahci_berlin_reg_set(void __iomem *reg, u32 val)
> +{
> +       writel(val, reg);
> +}

Just use writel directly.

> +
> +static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
> +                                            u32 set_val)
> +{
> +       u32 regval;
> +
> +       regval = readl(reg);
> +       regval &= ~(clear_val);
> +       regval |= set_val;
> +       writel(regval, reg);
> +}
> +
> +static void ahci_berlin_init(void __iomem *mmio)

I don't really see the point of a function to do 2 register writes of
magic values especially when the function name doesn't provide any
indication of what you are doing really.

> +{
> +       /* interface select */
> +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
> +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,

2 writes to the same reg? Is this supposed to be the VSA_DATA register?

> +                           BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));

Use of BIT is only helpful to people that don't understand hex. Can
you define what these bits are. Otherwise, just use 0x00240034 and
note that it is magic value which you have no idea what the bits are.

> +
> +}
> +
> +static void ahci_berlin_port_init(void __iomem *mmio, unsigned int ports)
> +{
> +       int p;
> +
> +       /* power down pll */
> +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +       ahci_berlin_reg_setbits(mmio + HOST_VSA_DATA, BIT(6));
> +
> +       for (p = 0; p < ports; p++) {
> +               /* port control register */
> +               void __iomem *ctrl_reg = mmio + 0x100 + (p * 0x80);
> +
> +               /* set PHY mode to SATA, ref freq to 25 MHz */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x201);
> +               ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +                                         0xff, BIT(0));

So you have registers hidden behind an address and data register.
Perhaps a read and write function to provide that access rather than
all these set/clear bit functions.

> +
> +               /* set PHY up to 6 Gbps */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x225);
> +               ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +                                         BIT(11) | BIT(10), BIT(11));
> +
> +               /* set SEL_BITS to 40 bit */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x223);
> +               ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +                                         BIT(11) | BIT(10), BIT(11));
> +
> +               /* use max pll rate */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x202);
> +               ahci_berlin_reg_setbits(ctrl_reg + PORT_VSR_DATA, BIT(12));
> +
> +               /* CT timing fix */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) | BIT(1));
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> +                                   BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> +                                   BIT(10) | BIT(2) | BIT(1));
> +
> +               /* set the controller speed */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_SCR_CTL,
> +                                   BIT(6) | BIT(5) | BIT(0));
> +       }
> +
> +       /* power up pll */
> +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +       ahci_berlin_reg_clear_set(mmio + HOST_VSA_DATA, BIT(6), 0x0);
> +}
> +
> +static const struct ata_port_info ahci_berlin_port_info = {
> +       .flags          = AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
> +       .pio_mask       = ATA_PIO4,
> +       .udma_mask      = ATA_UDMA6,
> +       .port_ops       = &ahci_platform_ops,
> +};
> +
> +static int ahci_berlin_probe(struct platform_device *pdev)
> +{
> +       struct device *dev = &pdev->dev;
> +       struct device_node *np = dev->of_node;
> +       struct ahci_host_priv *hpriv;
> +       int ret, nports, force_map = 0;
> +
> +       hpriv = ahci_platform_get_resources(pdev);
> +       if (IS_ERR(hpriv)) {
> +               dev_err(dev, "cannot get AHCI resources\n");
> +               return PTR_ERR(hpriv);
> +       }
> +
> +       ret = ahci_platform_enable_resources(hpriv);
> +       if (ret) {
> +               dev_err(dev, "cannot enable resources: %d\n", ret);
> +               return ret;
> +       }
> +
> +       nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
> +
> +       /* force_map is modified only if the property is found */
> +       of_property_read_u32(np, "marvell,force-port-map", &force_map);
> +       if (force_map)
> +               nports = force_map;
> +
> +       ahci_berlin_init(hpriv->mmio);
> +       ahci_berlin_port_init(hpriv->mmio, nports);
> +
> +       ret = ahci_platform_init_host(pdev, hpriv, &ahci_berlin_port_info,
> +                                     force_map, 0);
> +       if (ret) {
> +               dev_err(dev, "host init failed: %d\n", ret);
> +               goto disable_resources;
> +       }
> +
> +       return 0;
> +
> +disable_resources:
> +       ahci_platform_disable_resources(hpriv);
> +       return ret;
> +}
> +
> +static const struct of_device_id ahci_berlin_of_match[] = {
> +       { .compatible = "marvell,berlin-ahci" },
> +       { },
> +};
> +MODULE_DEVICE_TABLE(of, ahci_berlin_of_match);
> +
> +static struct platform_driver ahci_berlin_driver = {
> +       .probe  = ahci_berlin_probe,
> +       .remove = ata_platform_remove_one,
> +       .driver = {
> +               .name           = "ahci-berlin",
> +               .owner          = THIS_MODULE,
> +               .of_match_table = ahci_berlin_of_match,
> +       },
> +};
> +module_platform_driver(ahci_berlin_driver);
> +
> +MODULE_DESCRIPTION("Marvell Berlin AHCI SATA driver");
> +MODULE_AUTHOR("Antoine Ténart <antoine.tenart@free-electrons.com>");
> +MODULE_LICENSE("GPL");
> --
> 1.8.3.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Rob Herring]

On Tue, Apr 22, 2014 at 10:38 AM, Antoine Ténart
<antoine.tenart@free-electrons.com> wrote:
> Add support for the Berlin SoCs AHCI SATA controller allowing to
> interface with devices like external hard drives.
>
> Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
> ---
>  drivers/ata/Kconfig       |   9 +++
>  drivers/ata/Makefile      |   1 +
>  drivers/ata/ahci_berlin.c | 175 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 185 insertions(+)
>  create mode 100644 drivers/ata/ahci_berlin.c
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 20e03a7eb8b4..c985dfcd5a6c 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -97,6 +97,15 @@ config SATA_AHCI_PLATFORM
>
>           If unsure, say N.
>
> +config AHCI_BERLIN
> +       tristate "Marvell Berlin AHCI SATA support"
> +       depends on ARCH_BERLIN
> +       help
> +         This option enables support for the Marvell Berlin SoC's
> +         onboard AHCI SATA.
> +
> +         If unsure, say N.
> +
>  config AHCI_DA850
>         tristate "DaVinci DA850 AHCI SATA support"
>         depends on ARCH_DAVINCI_DA850
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index 44c8016e565c..7fb78d1e0a44 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -10,6 +10,7 @@ obj-$(CONFIG_SATA_INIC162X)   += sata_inic162x.o
>  obj-$(CONFIG_SATA_SIL24)       += sata_sil24.o
>  obj-$(CONFIG_SATA_DWC)         += sata_dwc_460ex.o
>  obj-$(CONFIG_SATA_HIGHBANK)    += sata_highbank.o libahci.o
> +obj-$(CONFIG_AHCI_BERLIN)      += ahci_berlin.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_DA850)       += ahci_da850.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_IMX)         += ahci_imx.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_SUNXI)       += ahci_sunxi.o libahci.o libahci_platform.o
> diff --git a/drivers/ata/ahci_berlin.c b/drivers/ata/ahci_berlin.c
> new file mode 100644
> index 000000000000..cf1c9d3b9d18
> --- /dev/null
> +++ b/drivers/ata/ahci_berlin.c
> @@ -0,0 +1,175 @@
> +/*
> + * Marvell Berlin AHCI SATA platform driver
> + *
> + * Copyright (C) 2014 Marvell Technology Group Ltd.
> + *
> + * Antoine Ténart <antoine.tenart@free-electrons.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#include <linux/ahci_platform.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +
> +#include "ahci.h"
> +
> +#define PORT_VSR_ADDR          0x78
> +#define PORT_VSR_DATA          0x7C
> +#define HOST_VSA_ADDR          0xA0
> +#define HOST_VSA_DATA          0xA4
> +
> +static inline void ahci_berlin_reg_setbits(void __iomem *reg, u32 val)
> +{
> +       u32 regval;
> +
> +       regval = readl(reg);
> +       regval |= val;
> +       writel(regval, reg);
> +}
> +
> +static inline void ahci_berlin_reg_set(void __iomem *reg, u32 val)
> +{
> +       writel(val, reg);
> +}

Just use writel directly.

> +
> +static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
> +                                            u32 set_val)
> +{
> +       u32 regval;
> +
> +       regval = readl(reg);
> +       regval &= ~(clear_val);
> +       regval |= set_val;
> +       writel(regval, reg);
> +}
> +
> +static void ahci_berlin_init(void __iomem *mmio)

I don't really see the point of a function to do 2 register writes of
magic values especially when the function name doesn't provide any
indication of what you are doing really.

> +{
> +       /* interface select */
> +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
> +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,

2 writes to the same reg? Is this supposed to be the VSA_DATA register?

> +                           BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));

Use of BIT is only helpful to people that don't understand hex. Can
you define what these bits are. Otherwise, just use 0x00240034 and
note that it is magic value which you have no idea what the bits are.

> +
> +}
> +
> +static void ahci_berlin_port_init(void __iomem *mmio, unsigned int ports)
> +{
> +       int p;
> +
> +       /* power down pll */
> +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +       ahci_berlin_reg_setbits(mmio + HOST_VSA_DATA, BIT(6));
> +
> +       for (p = 0; p < ports; p++) {
> +               /* port control register */
> +               void __iomem *ctrl_reg = mmio + 0x100 + (p * 0x80);
> +
> +               /* set PHY mode to SATA, ref freq to 25 MHz */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x201);
> +               ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +                                         0xff, BIT(0));

So you have registers hidden behind an address and data register.
Perhaps a read and write function to provide that access rather than
all these set/clear bit functions.

> +
> +               /* set PHY up to 6 Gbps */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x225);
> +               ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +                                         BIT(11) | BIT(10), BIT(11));
> +
> +               /* set SEL_BITS to 40 bit */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x223);
> +               ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +                                         BIT(11) | BIT(10), BIT(11));
> +
> +               /* use max pll rate */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x202);
> +               ahci_berlin_reg_setbits(ctrl_reg + PORT_VSR_DATA, BIT(12));
> +
> +               /* CT timing fix */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) | BIT(1));
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> +                                   BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> +                                   BIT(10) | BIT(2) | BIT(1));
> +
> +               /* set the controller speed */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_SCR_CTL,
> +                                   BIT(6) | BIT(5) | BIT(0));
> +       }
> +
> +       /* power up pll */
> +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +       ahci_berlin_reg_clear_set(mmio + HOST_VSA_DATA, BIT(6), 0x0);
> +}
> +
> +static const struct ata_port_info ahci_berlin_port_info = {
> +       .flags          = AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
> +       .pio_mask       = ATA_PIO4,
> +       .udma_mask      = ATA_UDMA6,
> +       .port_ops       = &ahci_platform_ops,
> +};
> +
> +static int ahci_berlin_probe(struct platform_device *pdev)
> +{
> +       struct device *dev = &pdev->dev;
> +       struct device_node *np = dev->of_node;
> +       struct ahci_host_priv *hpriv;
> +       int ret, nports, force_map = 0;
> +
> +       hpriv = ahci_platform_get_resources(pdev);
> +       if (IS_ERR(hpriv)) {
> +               dev_err(dev, "cannot get AHCI resources\n");
> +               return PTR_ERR(hpriv);
> +       }
> +
> +       ret = ahci_platform_enable_resources(hpriv);
> +       if (ret) {
> +               dev_err(dev, "cannot enable resources: %d\n", ret);
> +               return ret;
> +       }
> +
> +       nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
> +
> +       /* force_map is modified only if the property is found */
> +       of_property_read_u32(np, "marvell,force-port-map", &force_map);
> +       if (force_map)
> +               nports = force_map;
> +
> +       ahci_berlin_init(hpriv->mmio);
> +       ahci_berlin_port_init(hpriv->mmio, nports);
> +
> +       ret = ahci_platform_init_host(pdev, hpriv, &ahci_berlin_port_info,
> +                                     force_map, 0);
> +       if (ret) {
> +               dev_err(dev, "host init failed: %d\n", ret);
> +               goto disable_resources;
> +       }
> +
> +       return 0;
> +
> +disable_resources:
> +       ahci_platform_disable_resources(hpriv);
> +       return ret;
> +}
> +
> +static const struct of_device_id ahci_berlin_of_match[] = {
> +       { .compatible = "marvell,berlin-ahci" },
> +       { },
> +};
> +MODULE_DEVICE_TABLE(of, ahci_berlin_of_match);
> +
> +static struct platform_driver ahci_berlin_driver = {
> +       .probe  = ahci_berlin_probe,
> +       .remove = ata_platform_remove_one,
> +       .driver = {
> +               .name           = "ahci-berlin",
> +               .owner          = THIS_MODULE,
> +               .of_match_table = ahci_berlin_of_match,
> +       },
> +};
> +module_platform_driver(ahci_berlin_driver);
> +
> +MODULE_DESCRIPTION("Marvell Berlin AHCI SATA driver");
> +MODULE_AUTHOR("Antoine Ténart <antoine.tenart@free-electrons.com>");
> +MODULE_LICENSE("GPL");
> --
> 1.8.3.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Rob Herring]

On Tue, Apr 22, 2014 at 10:38 AM, Antoine T?nart
<antoine.tenart@free-electrons.com> wrote:
> Add support for the Berlin SoCs AHCI SATA controller allowing to
> interface with devices like external hard drives.
>
> Signed-off-by: Antoine T?nart <antoine.tenart@free-electrons.com>
> ---
>  drivers/ata/Kconfig       |   9 +++
>  drivers/ata/Makefile      |   1 +
>  drivers/ata/ahci_berlin.c | 175 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 185 insertions(+)
>  create mode 100644 drivers/ata/ahci_berlin.c
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 20e03a7eb8b4..c985dfcd5a6c 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -97,6 +97,15 @@ config SATA_AHCI_PLATFORM
>
>           If unsure, say N.
>
> +config AHCI_BERLIN
> +       tristate "Marvell Berlin AHCI SATA support"
> +       depends on ARCH_BERLIN
> +       help
> +         This option enables support for the Marvell Berlin SoC's
> +         onboard AHCI SATA.
> +
> +         If unsure, say N.
> +
>  config AHCI_DA850
>         tristate "DaVinci DA850 AHCI SATA support"
>         depends on ARCH_DAVINCI_DA850
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index 44c8016e565c..7fb78d1e0a44 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -10,6 +10,7 @@ obj-$(CONFIG_SATA_INIC162X)   += sata_inic162x.o
>  obj-$(CONFIG_SATA_SIL24)       += sata_sil24.o
>  obj-$(CONFIG_SATA_DWC)         += sata_dwc_460ex.o
>  obj-$(CONFIG_SATA_HIGHBANK)    += sata_highbank.o libahci.o
> +obj-$(CONFIG_AHCI_BERLIN)      += ahci_berlin.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_DA850)       += ahci_da850.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_IMX)         += ahci_imx.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_SUNXI)       += ahci_sunxi.o libahci.o libahci_platform.o
> diff --git a/drivers/ata/ahci_berlin.c b/drivers/ata/ahci_berlin.c
> new file mode 100644
> index 000000000000..cf1c9d3b9d18
> --- /dev/null
> +++ b/drivers/ata/ahci_berlin.c
> @@ -0,0 +1,175 @@
> +/*
> + * Marvell Berlin AHCI SATA platform driver
> + *
> + * Copyright (C) 2014 Marvell Technology Group Ltd.
> + *
> + * Antoine T?nart <antoine.tenart@free-electrons.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#include <linux/ahci_platform.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +
> +#include "ahci.h"
> +
> +#define PORT_VSR_ADDR          0x78
> +#define PORT_VSR_DATA          0x7C
> +#define HOST_VSA_ADDR          0xA0
> +#define HOST_VSA_DATA          0xA4
> +
> +static inline void ahci_berlin_reg_setbits(void __iomem *reg, u32 val)
> +{
> +       u32 regval;
> +
> +       regval = readl(reg);
> +       regval |= val;
> +       writel(regval, reg);
> +}
> +
> +static inline void ahci_berlin_reg_set(void __iomem *reg, u32 val)
> +{
> +       writel(val, reg);
> +}

Just use writel directly.

> +
> +static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
> +                                            u32 set_val)
> +{
> +       u32 regval;
> +
> +       regval = readl(reg);
> +       regval &= ~(clear_val);
> +       regval |= set_val;
> +       writel(regval, reg);
> +}
> +
> +static void ahci_berlin_init(void __iomem *mmio)

I don't really see the point of a function to do 2 register writes of
magic values especially when the function name doesn't provide any
indication of what you are doing really.

> +{
> +       /* interface select */
> +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
> +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,

2 writes to the same reg? Is this supposed to be the VSA_DATA register?

> +                           BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));

Use of BIT is only helpful to people that don't understand hex. Can
you define what these bits are. Otherwise, just use 0x00240034 and
note that it is magic value which you have no idea what the bits are.

> +
> +}
> +
> +static void ahci_berlin_port_init(void __iomem *mmio, unsigned int ports)
> +{
> +       int p;
> +
> +       /* power down pll */
> +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +       ahci_berlin_reg_setbits(mmio + HOST_VSA_DATA, BIT(6));
> +
> +       for (p = 0; p < ports; p++) {
> +               /* port control register */
> +               void __iomem *ctrl_reg = mmio + 0x100 + (p * 0x80);
> +
> +               /* set PHY mode to SATA, ref freq to 25 MHz */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x201);
> +               ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +                                         0xff, BIT(0));

So you have registers hidden behind an address and data register.
Perhaps a read and write function to provide that access rather than
all these set/clear bit functions.

> +
> +               /* set PHY up to 6 Gbps */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x225);
> +               ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +                                         BIT(11) | BIT(10), BIT(11));
> +
> +               /* set SEL_BITS to 40 bit */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x223);
> +               ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +                                         BIT(11) | BIT(10), BIT(11));
> +
> +               /* use max pll rate */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x202);
> +               ahci_berlin_reg_setbits(ctrl_reg + PORT_VSR_DATA, BIT(12));
> +
> +               /* CT timing fix */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) | BIT(1));
> +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> +                                   BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> +                                   BIT(10) | BIT(2) | BIT(1));
> +
> +               /* set the controller speed */
> +               ahci_berlin_reg_set(ctrl_reg + PORT_SCR_CTL,
> +                                   BIT(6) | BIT(5) | BIT(0));
> +       }
> +
> +       /* power up pll */
> +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +       ahci_berlin_reg_clear_set(mmio + HOST_VSA_DATA, BIT(6), 0x0);
> +}
> +
> +static const struct ata_port_info ahci_berlin_port_info = {
> +       .flags          = AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
> +       .pio_mask       = ATA_PIO4,
> +       .udma_mask      = ATA_UDMA6,
> +       .port_ops       = &ahci_platform_ops,
> +};
> +
> +static int ahci_berlin_probe(struct platform_device *pdev)
> +{
> +       struct device *dev = &pdev->dev;
> +       struct device_node *np = dev->of_node;
> +       struct ahci_host_priv *hpriv;
> +       int ret, nports, force_map = 0;
> +
> +       hpriv = ahci_platform_get_resources(pdev);
> +       if (IS_ERR(hpriv)) {
> +               dev_err(dev, "cannot get AHCI resources\n");
> +               return PTR_ERR(hpriv);
> +       }
> +
> +       ret = ahci_platform_enable_resources(hpriv);
> +       if (ret) {
> +               dev_err(dev, "cannot enable resources: %d\n", ret);
> +               return ret;
> +       }
> +
> +       nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
> +
> +       /* force_map is modified only if the property is found */
> +       of_property_read_u32(np, "marvell,force-port-map", &force_map);
> +       if (force_map)
> +               nports = force_map;
> +
> +       ahci_berlin_init(hpriv->mmio);
> +       ahci_berlin_port_init(hpriv->mmio, nports);
> +
> +       ret = ahci_platform_init_host(pdev, hpriv, &ahci_berlin_port_info,
> +                                     force_map, 0);
> +       if (ret) {
> +               dev_err(dev, "host init failed: %d\n", ret);
> +               goto disable_resources;
> +       }
> +
> +       return 0;
> +
> +disable_resources:
> +       ahci_platform_disable_resources(hpriv);
> +       return ret;
> +}
> +
> +static const struct of_device_id ahci_berlin_of_match[] = {
> +       { .compatible = "marvell,berlin-ahci" },
> +       { },
> +};
> +MODULE_DEVICE_TABLE(of, ahci_berlin_of_match);
> +
> +static struct platform_driver ahci_berlin_driver = {
> +       .probe  = ahci_berlin_probe,
> +       .remove = ata_platform_remove_one,
> +       .driver = {
> +               .name           = "ahci-berlin",
> +               .owner          = THIS_MODULE,
> +               .of_match_table = ahci_berlin_of_match,
> +       },
> +};
> +module_platform_driver(ahci_berlin_driver);
> +
> +MODULE_DESCRIPTION("Marvell Berlin AHCI SATA driver");
> +MODULE_AUTHOR("Antoine T?nart <antoine.tenart@free-electrons.com>");
> +MODULE_LICENSE("GPL");
> --
> 1.8.3.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Rob Herring]

On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring <robherring2@gmail.com> wrote:
> On Tue, Apr 22, 2014 at 10:38 AM, Antoine Ténart
> <antoine.tenart@free-electrons.com> wrote:
>> Add support for the Berlin SoCs AHCI SATA controller allowing to
>> interface with devices like external hard drives.

One more thing.

>> +       nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
>> +
>> +       /* force_map is modified only if the property is found */
>> +       of_property_read_u32(np, "marvell,force-port-map", &force_map);

This property does not appear to be documented.

>> +       if (force_map)
>> +               nports = force_map;

You don't need this as your comment says, you can just do:

of_property_read_u32(np, "marvell,force-port-map", &nports);

nports will only be changed if property is present.

Rob

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Rob Herring]

On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring <robherring2@gmail.com> wrote:
> On Tue, Apr 22, 2014 at 10:38 AM, Antoine Ténart
> <antoine.tenart@free-electrons.com> wrote:
>> Add support for the Berlin SoCs AHCI SATA controller allowing to
>> interface with devices like external hard drives.

One more thing.

>> +       nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
>> +
>> +       /* force_map is modified only if the property is found */
>> +       of_property_read_u32(np, "marvell,force-port-map", &force_map);

This property does not appear to be documented.

>> +       if (force_map)
>> +               nports = force_map;

You don't need this as your comment says, you can just do:

of_property_read_u32(np, "marvell,force-port-map", &nports);

nports will only be changed if property is present.

Rob

[PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Rob Herring]

On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring <robherring2@gmail.com> wrote:
> On Tue, Apr 22, 2014 at 10:38 AM, Antoine T?nart
> <antoine.tenart@free-electrons.com> wrote:
>> Add support for the Berlin SoCs AHCI SATA controller allowing to
>> interface with devices like external hard drives.

One more thing.

>> +       nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
>> +
>> +       /* force_map is modified only if the property is found */
>> +       of_property_read_u32(np, "marvell,force-port-map", &force_map);

This property does not appear to be documented.

>> +       if (force_map)
>> +               nports = force_map;

You don't need this as your comment says, you can just do:

of_property_read_u32(np, "marvell,force-port-map", &nports);

nports will only be changed if property is present.

Rob

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Andrew Lunn]

On Tue, Apr 22, 2014 at 05:38:20PM +0200, Antoine Ténart wrote:
> Add support for the Berlin SoCs AHCI SATA controller allowing to
> interface with devices like external hard drives.
> 
> Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
> ---
>  drivers/ata/Kconfig       |   9 +++
>  drivers/ata/Makefile      |   1 +
>  drivers/ata/ahci_berlin.c | 175 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 185 insertions(+)
>  create mode 100644 drivers/ata/ahci_berlin.c
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 20e03a7eb8b4..c985dfcd5a6c 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -97,6 +97,15 @@ config SATA_AHCI_PLATFORM
>  
>  	  If unsure, say N.
>  
> +config AHCI_BERLIN
> +	tristate "Marvell Berlin AHCI SATA support"
> +	depends on ARCH_BERLIN
> +	help
> +	  This option enables support for the Marvell Berlin SoC's
> +	  onboard AHCI SATA.
> +
> +	  If unsure, say N.
> +
>  config AHCI_DA850
>  	tristate "DaVinci DA850 AHCI SATA support"
>  	depends on ARCH_DAVINCI_DA850
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index 44c8016e565c..7fb78d1e0a44 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -10,6 +10,7 @@ obj-$(CONFIG_SATA_INIC162X)	+= sata_inic162x.o
>  obj-$(CONFIG_SATA_SIL24)	+= sata_sil24.o
>  obj-$(CONFIG_SATA_DWC)		+= sata_dwc_460ex.o
>  obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o libahci.o
> +obj-$(CONFIG_AHCI_BERLIN)	+= ahci_berlin.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_DA850)	+= ahci_da850.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_IMX)		+= ahci_imx.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_SUNXI)	+= ahci_sunxi.o libahci.o libahci_platform.o
> diff --git a/drivers/ata/ahci_berlin.c b/drivers/ata/ahci_berlin.c
> new file mode 100644
> index 000000000000..cf1c9d3b9d18
> --- /dev/null
> +++ b/drivers/ata/ahci_berlin.c
> @@ -0,0 +1,175 @@
> +/*
> + * Marvell Berlin AHCI SATA platform driver
> + *
> + * Copyright (C) 2014 Marvell Technology Group Ltd.
> + *
> + * Antoine Ténart <antoine.tenart@free-electrons.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#include <linux/ahci_platform.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +
> +#include "ahci.h"
> +
> +#define PORT_VSR_ADDR		0x78
> +#define PORT_VSR_DATA		0x7C
> +#define HOST_VSA_ADDR		0xA0
> +#define HOST_VSA_DATA		0xA4
> +
> +static inline void ahci_berlin_reg_setbits(void __iomem *reg, u32 val)
> +{
> +	u32 regval;
> +
> +	regval = readl(reg);
> +	regval |= val;
> +	writel(regval, reg);
> +}
> +
> +static inline void ahci_berlin_reg_set(void __iomem *reg, u32 val)
> +{
> +	writel(val, reg);
> +}
> +
> +static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
> +					     u32 set_val)
> +{
> +	u32 regval;
> +
> +	regval = readl(reg);
> +	regval &= ~(clear_val);
> +	regval |= set_val;
> +	writel(regval, reg);
> +}
> +
> +static void ahci_berlin_init(void __iomem *mmio)
> +{
> +	/* interface select */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,
> +			    BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));
> +
> +}
> +
> +static void ahci_berlin_port_init(void __iomem *mmio, unsigned int ports)
> +{
> +	int p;
> +
> +	/* power down pll */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +	ahci_berlin_reg_setbits(mmio + HOST_VSA_DATA, BIT(6));
> +
> +	for (p = 0; p < ports; p++) {
> +		/* port control register */
> +		void __iomem *ctrl_reg = mmio + 0x100 + (p * 0x80);
> +
> +		/* set PHY mode to SATA, ref freq to 25 MHz */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x201);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  0xff, BIT(0));
> +
> +		/* set PHY up to 6 Gbps */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x225);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  BIT(11) | BIT(10), BIT(11));

Why clear bit 11, if you are going to set it?

Could you also document all these bits, rather than use black
magic?

	Thanks
		Andrew

> +
> +		/* set SEL_BITS to 40 bit */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x223);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  BIT(11) | BIT(10), BIT(11));
> +
> +		/* use max pll rate */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x202);
> +		ahci_berlin_reg_setbits(ctrl_reg + PORT_VSR_DATA, BIT(12));
> +
> +		/* CT timing fix */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) | BIT(1));
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> +				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> +				    BIT(10) | BIT(2) | BIT(1));
> +
> +		/* set the controller speed */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_SCR_CTL,
> +				    BIT(6) | BIT(5) | BIT(0));
> +	}
> +
> +	/* power up pll */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +	ahci_berlin_reg_clear_set(mmio + HOST_VSA_DATA, BIT(6), 0x0);
> +}
> +
> +static const struct ata_port_info ahci_berlin_port_info = {
> +	.flags		= AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
> +	.pio_mask	= ATA_PIO4,
> +	.udma_mask	= ATA_UDMA6,
> +	.port_ops	= &ahci_platform_ops,
> +};
> +
> +static int ahci_berlin_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct device_node *np = dev->of_node;
> +	struct ahci_host_priv *hpriv;
> +	int ret, nports, force_map = 0;
> +
> +	hpriv = ahci_platform_get_resources(pdev);
> +	if (IS_ERR(hpriv)) {
> +		dev_err(dev, "cannot get AHCI resources\n");
> +		return PTR_ERR(hpriv);
> +	}
> +
> +	ret = ahci_platform_enable_resources(hpriv);
> +	if (ret) {
> +		dev_err(dev, "cannot enable resources: %d\n", ret);
> +		return ret;
> +	}
> +
> +	nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
> +
> +	/* force_map is modified only if the property is found */
> +	of_property_read_u32(np, "marvell,force-port-map", &force_map);
> +	if (force_map)
> +		nports = force_map;
> +
> +	ahci_berlin_init(hpriv->mmio);
> +	ahci_berlin_port_init(hpriv->mmio, nports);
> +
> +	ret = ahci_platform_init_host(pdev, hpriv, &ahci_berlin_port_info,
> +				      force_map, 0);
> +	if (ret) {
> +		dev_err(dev, "host init failed: %d\n", ret);
> +		goto disable_resources;
> +	}
> +
> +	return 0;
> +
> +disable_resources:
> +	ahci_platform_disable_resources(hpriv);
> +	return ret;
> +}
> +
> +static const struct of_device_id ahci_berlin_of_match[] = {
> +	{ .compatible = "marvell,berlin-ahci" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, ahci_berlin_of_match);
> +
> +static struct platform_driver ahci_berlin_driver = {
> +	.probe	= ahci_berlin_probe,
> +	.remove	= ata_platform_remove_one,
> +	.driver	= {
> +		.name		= "ahci-berlin",
> +		.owner		= THIS_MODULE,
> +		.of_match_table = ahci_berlin_of_match,
> +	},
> +};
> +module_platform_driver(ahci_berlin_driver);
> +
> +MODULE_DESCRIPTION("Marvell Berlin AHCI SATA driver");
> +MODULE_AUTHOR("Antoine Ténart <antoine.tenart@free-electrons.com>");
> +MODULE_LICENSE("GPL");
> -- 
> 1.8.3.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Andrew Lunn]

On Tue, Apr 22, 2014 at 05:38:20PM +0200, Antoine T?nart wrote:
> Add support for the Berlin SoCs AHCI SATA controller allowing to
> interface with devices like external hard drives.
> 
> Signed-off-by: Antoine T?nart <antoine.tenart@free-electrons.com>
> ---
>  drivers/ata/Kconfig       |   9 +++
>  drivers/ata/Makefile      |   1 +
>  drivers/ata/ahci_berlin.c | 175 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 185 insertions(+)
>  create mode 100644 drivers/ata/ahci_berlin.c
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 20e03a7eb8b4..c985dfcd5a6c 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -97,6 +97,15 @@ config SATA_AHCI_PLATFORM
>  
>  	  If unsure, say N.
>  
> +config AHCI_BERLIN
> +	tristate "Marvell Berlin AHCI SATA support"
> +	depends on ARCH_BERLIN
> +	help
> +	  This option enables support for the Marvell Berlin SoC's
> +	  onboard AHCI SATA.
> +
> +	  If unsure, say N.
> +
>  config AHCI_DA850
>  	tristate "DaVinci DA850 AHCI SATA support"
>  	depends on ARCH_DAVINCI_DA850
> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> index 44c8016e565c..7fb78d1e0a44 100644
> --- a/drivers/ata/Makefile
> +++ b/drivers/ata/Makefile
> @@ -10,6 +10,7 @@ obj-$(CONFIG_SATA_INIC162X)	+= sata_inic162x.o
>  obj-$(CONFIG_SATA_SIL24)	+= sata_sil24.o
>  obj-$(CONFIG_SATA_DWC)		+= sata_dwc_460ex.o
>  obj-$(CONFIG_SATA_HIGHBANK)	+= sata_highbank.o libahci.o
> +obj-$(CONFIG_AHCI_BERLIN)	+= ahci_berlin.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_DA850)	+= ahci_da850.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_IMX)		+= ahci_imx.o libahci.o libahci_platform.o
>  obj-$(CONFIG_AHCI_SUNXI)	+= ahci_sunxi.o libahci.o libahci_platform.o
> diff --git a/drivers/ata/ahci_berlin.c b/drivers/ata/ahci_berlin.c
> new file mode 100644
> index 000000000000..cf1c9d3b9d18
> --- /dev/null
> +++ b/drivers/ata/ahci_berlin.c
> @@ -0,0 +1,175 @@
> +/*
> + * Marvell Berlin AHCI SATA platform driver
> + *
> + * Copyright (C) 2014 Marvell Technology Group Ltd.
> + *
> + * Antoine T?nart <antoine.tenart@free-electrons.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#include <linux/ahci_platform.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +
> +#include "ahci.h"
> +
> +#define PORT_VSR_ADDR		0x78
> +#define PORT_VSR_DATA		0x7C
> +#define HOST_VSA_ADDR		0xA0
> +#define HOST_VSA_DATA		0xA4
> +
> +static inline void ahci_berlin_reg_setbits(void __iomem *reg, u32 val)
> +{
> +	u32 regval;
> +
> +	regval = readl(reg);
> +	regval |= val;
> +	writel(regval, reg);
> +}
> +
> +static inline void ahci_berlin_reg_set(void __iomem *reg, u32 val)
> +{
> +	writel(val, reg);
> +}
> +
> +static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
> +					     u32 set_val)
> +{
> +	u32 regval;
> +
> +	regval = readl(reg);
> +	regval &= ~(clear_val);
> +	regval |= set_val;
> +	writel(regval, reg);
> +}
> +
> +static void ahci_berlin_init(void __iomem *mmio)
> +{
> +	/* interface select */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,
> +			    BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));
> +
> +}
> +
> +static void ahci_berlin_port_init(void __iomem *mmio, unsigned int ports)
> +{
> +	int p;
> +
> +	/* power down pll */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +	ahci_berlin_reg_setbits(mmio + HOST_VSA_DATA, BIT(6));
> +
> +	for (p = 0; p < ports; p++) {
> +		/* port control register */
> +		void __iomem *ctrl_reg = mmio + 0x100 + (p * 0x80);
> +
> +		/* set PHY mode to SATA, ref freq to 25 MHz */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x201);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  0xff, BIT(0));
> +
> +		/* set PHY up to 6 Gbps */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x225);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  BIT(11) | BIT(10), BIT(11));

Why clear bit 11, if you are going to set it?

Could you also document all these bits, rather than use black
magic?

	Thanks
		Andrew

> +
> +		/* set SEL_BITS to 40 bit */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x223);
> +		ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> +					  BIT(11) | BIT(10), BIT(11));
> +
> +		/* use max pll rate */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x202);
> +		ahci_berlin_reg_setbits(ctrl_reg + PORT_VSR_DATA, BIT(12));
> +
> +		/* CT timing fix */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) | BIT(1));
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> +				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> +				    BIT(10) | BIT(2) | BIT(1));
> +
> +		/* set the controller speed */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_SCR_CTL,
> +				    BIT(6) | BIT(5) | BIT(0));
> +	}
> +
> +	/* power up pll */
> +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> +	ahci_berlin_reg_clear_set(mmio + HOST_VSA_DATA, BIT(6), 0x0);
> +}
> +
> +static const struct ata_port_info ahci_berlin_port_info = {
> +	.flags		= AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
> +	.pio_mask	= ATA_PIO4,
> +	.udma_mask	= ATA_UDMA6,
> +	.port_ops	= &ahci_platform_ops,
> +};
> +
> +static int ahci_berlin_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct device_node *np = dev->of_node;
> +	struct ahci_host_priv *hpriv;
> +	int ret, nports, force_map = 0;
> +
> +	hpriv = ahci_platform_get_resources(pdev);
> +	if (IS_ERR(hpriv)) {
> +		dev_err(dev, "cannot get AHCI resources\n");
> +		return PTR_ERR(hpriv);
> +	}
> +
> +	ret = ahci_platform_enable_resources(hpriv);
> +	if (ret) {
> +		dev_err(dev, "cannot enable resources: %d\n", ret);
> +		return ret;
> +	}
> +
> +	nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
> +
> +	/* force_map is modified only if the property is found */
> +	of_property_read_u32(np, "marvell,force-port-map", &force_map);
> +	if (force_map)
> +		nports = force_map;
> +
> +	ahci_berlin_init(hpriv->mmio);
> +	ahci_berlin_port_init(hpriv->mmio, nports);
> +
> +	ret = ahci_platform_init_host(pdev, hpriv, &ahci_berlin_port_info,
> +				      force_map, 0);
> +	if (ret) {
> +		dev_err(dev, "host init failed: %d\n", ret);
> +		goto disable_resources;
> +	}
> +
> +	return 0;
> +
> +disable_resources:
> +	ahci_platform_disable_resources(hpriv);
> +	return ret;
> +}
> +
> +static const struct of_device_id ahci_berlin_of_match[] = {
> +	{ .compatible = "marvell,berlin-ahci" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, ahci_berlin_of_match);
> +
> +static struct platform_driver ahci_berlin_driver = {
> +	.probe	= ahci_berlin_probe,
> +	.remove	= ata_platform_remove_one,
> +	.driver	= {
> +		.name		= "ahci-berlin",
> +		.owner		= THIS_MODULE,
> +		.of_match_table = ahci_berlin_of_match,
> +	},
> +};
> +module_platform_driver(ahci_berlin_driver);
> +
> +MODULE_DESCRIPTION("Marvell Berlin AHCI SATA driver");
> +MODULE_AUTHOR("Antoine T?nart <antoine.tenart@free-electrons.com>");
> +MODULE_LICENSE("GPL");
> -- 
> 1.8.3.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 6/6] ARM: berlin: add the AHCI node for the BG2CD

[Jisheng Zhang]

Hi Antoine,

On Tue, 22 Apr 2014 08:38:25 -0700
Antoine Ténart <antoine.tenart@free-electrons.com> wrote:

> The BG2CD has an AHCI SATA controller. Add the corresponding node
> in its device tree.

BG2CD doesn't has AHCI controller. 

Thanks

Re: [PATCH 6/6] ARM: berlin: add the AHCI node for the BG2CD

[Jisheng Zhang]

Hi Antoine,

On Tue, 22 Apr 2014 08:38:25 -0700
Antoine Ténart <antoine.tenart@free-electrons.com> wrote:

> The BG2CD has an AHCI SATA controller. Add the corresponding node
> in its device tree.

BG2CD doesn't has AHCI controller. 

Thanks

[PATCH 6/6] ARM: berlin: add the AHCI node for the BG2CD

[Jisheng Zhang]

Hi Antoine,

On Tue, 22 Apr 2014 08:38:25 -0700
Antoine T?nart <antoine.tenart@free-electrons.com> wrote:

> The BG2CD has an AHCI SATA controller. Add the corresponding node
> in its device tree.

BG2CD doesn't has AHCI controller. 

Thanks

Re: [PATCH 5/6] ARM: berlin: add the AHCI node for the BG2

[Jisheng Zhang]

Hi Antoine

On Tue, 22 Apr 2014 08:38:24 -0700
Antoine Ténart <antoine.tenart@free-electrons.com> wrote:

> The BG2 has an AHCI SATA controller. Add the corresponding node
> in its device tree.

The AHCI IP of BG2 is different with BG2Q, so the driver in the series of patch
doesn't work on BG2.

Thanks

Re: [PATCH 5/6] ARM: berlin: add the AHCI node for the BG2

[Jisheng Zhang]

Hi Antoine

On Tue, 22 Apr 2014 08:38:24 -0700
Antoine Ténart <antoine.tenart@free-electrons.com> wrote:

> The BG2 has an AHCI SATA controller. Add the corresponding node
> in its device tree.

The AHCI IP of BG2 is different with BG2Q, so the driver in the series of patch
doesn't work on BG2.

Thanks

[PATCH 5/6] ARM: berlin: add the AHCI node for the BG2

[Jisheng Zhang]

Hi Antoine

On Tue, 22 Apr 2014 08:38:24 -0700
Antoine T?nart <antoine.tenart@free-electrons.com> wrote:

> The BG2 has an AHCI SATA controller. Add the corresponding node
> in its device tree.

The AHCI IP of BG2 is different with BG2Q, so the driver in the series of patch
doesn't work on BG2.

Thanks

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Antoine Ténart]

Hi,

On Tue, Apr 22, 2014 at 06:54:27PM +0200, Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Tuesday, April 22, 2014 05:38:20 PM Antoine Ténart wrote:

[…]

> > +static struct platform_driver ahci_berlin_driver = {
> > +	.probe	= ahci_berlin_probe,
> > +	.remove	= ata_platform_remove_one,
> > +	.driver	= {
> > +		.name		= "ahci-berlin",
> > +		.owner		= THIS_MODULE,
> > +		.of_match_table = ahci_berlin_of_match,
> 
> Please add a comment explaining lack of power management support
> (i.e. that your platform doesn't have PM support implemented yet).

I can add the power management support in the v2.

Thanks!

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Antoine Ténart]

Hi,

On Tue, Apr 22, 2014 at 06:54:27PM +0200, Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Tuesday, April 22, 2014 05:38:20 PM Antoine T?nart wrote:

[?]

> > +static struct platform_driver ahci_berlin_driver = {
> > +	.probe	= ahci_berlin_probe,
> > +	.remove	= ata_platform_remove_one,
> > +	.driver	= {
> > +		.name		= "ahci-berlin",
> > +		.owner		= THIS_MODULE,
> > +		.of_match_table = ahci_berlin_of_match,
> 
> Please add a comment explaining lack of power management support
> (i.e. that your platform doesn't have PM support implemented yet).

I can add the power management support in the v2.

Thanks!

Antoine

-- 
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Antoine Ténart]

Sebastian,

On Tue, Apr 22, 2014 at 07:20:52PM +0200, Sebastian Hesselbarth wrote:
> On 04/22/2014 05:38 PM, Antoine Ténart wrote:

[…]

> > +static inline void ahci_berlin_reg_set(void __iomem *reg, u32 val)
> > +{
> > +	writel(val, reg);
> > +}
> 
> Antoine,
> 
> if you really need to rename writel, the above function name should
> end with _write.

I renamed writel for consistency with ahci_berlin_reg_clear_set() and
ahci_berlin_reg_setbits() but I can definitively drop it.

> 
> > +static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
> > +					     u32 set_val)
> > +{
> > +	u32 regval;
> > +
> > +	regval = readl(reg);
> > +	regval &= ~(clear_val);
> > +	regval |= set_val;
> > +	writel(regval, reg);
> > +}
> 
> ahci_berlin_reg_setbits(reg, val) == ahci_berlin_reg_clear_set(reg, 0, val);
> 
> Maybe get rid of the latter?

Sure.

> 
> > +static void ahci_berlin_init(void __iomem *mmio)
> > +{
> > +	/* interface select */
> > +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
> > +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,
> > +			    BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));
> 
> Any chance we get named #defines for the BIT()s above and below?

I'm afraid I can't. I'd love to do so if someone has a clue on this matter.

> > +	/* force_map is modified only if the property is found */
> > +	of_property_read_u32(np, "marvell,force-port-map", &force_map);
> > +	if (force_map)
> > +		nports = force_map;
> 
> marvell,force-port-map is undocumented and its name does not reflect
> what it is about. Before you just rename it to marvell,nr-ports or
> something, how about having one sub-node per port:
> 
> sata_phy0: sata-phy@e90100 {
> 	compatible = "marvell,berlin-sata-phy";
> 	reg = <0xe90100 0x80>;
> 	status = "disabled";
> };
> 
> sata_phy1: sata-phy@e90180 {
> 	compatible = "marvell,berlin-sata-phy";
> 	reg = <0xe90180 0x80>;
> 	status = "disabled";
> };
> 
> ahci: sata@e90000 {
> 	compatible = "marvell,berlin-ahci";
> 	reg = <0xe90000 0x100>;
> 	interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> 	#address-cells = <1>;
> 	#size-cells = <0>;
> 	status = "disabled";
> 
> 	sata-port@0 {
> 		reg = <0>;
> 		sata-phy = <&sata_phy0>;
> 		status = "disabled";
> 	};
> 
> 	sata-port@1 {
> 		reg = <1>;
> 		sata-phy = <&sata_phy1>;
> 		status = "okay";
> 	};
> };
> 
> That way you can
> (a) separate a PHY driver that has little code but is able to power-down
>     the PHY even if there is no AHCI driver loaded.
> (b) enable/disable each port individually.
> (c) enable port1 while port0 is disabled.
> (d) disable the PLL if there is no port enabled at all.

That would be better, but as of now I'm not sure I have enough information on
the PHY to do (a).

I guess (b), (c) and (d) can still be done.

Thanks for the review!

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Antoine Ténart]

Sebastian,

On Tue, Apr 22, 2014 at 07:20:52PM +0200, Sebastian Hesselbarth wrote:
> On 04/22/2014 05:38 PM, Antoine T?nart wrote:

[?]

> > +static inline void ahci_berlin_reg_set(void __iomem *reg, u32 val)
> > +{
> > +	writel(val, reg);
> > +}
> 
> Antoine,
> 
> if you really need to rename writel, the above function name should
> end with _write.

I renamed writel for consistency with ahci_berlin_reg_clear_set() and
ahci_berlin_reg_setbits() but I can definitively drop it.

> 
> > +static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
> > +					     u32 set_val)
> > +{
> > +	u32 regval;
> > +
> > +	regval = readl(reg);
> > +	regval &= ~(clear_val);
> > +	regval |= set_val;
> > +	writel(regval, reg);
> > +}
> 
> ahci_berlin_reg_setbits(reg, val) == ahci_berlin_reg_clear_set(reg, 0, val);
> 
> Maybe get rid of the latter?

Sure.

> 
> > +static void ahci_berlin_init(void __iomem *mmio)
> > +{
> > +	/* interface select */
> > +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
> > +	ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,
> > +			    BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));
> 
> Any chance we get named #defines for the BIT()s above and below?

I'm afraid I can't. I'd love to do so if someone has a clue on this matter.

> > +	/* force_map is modified only if the property is found */
> > +	of_property_read_u32(np, "marvell,force-port-map", &force_map);
> > +	if (force_map)
> > +		nports = force_map;
> 
> marvell,force-port-map is undocumented and its name does not reflect
> what it is about. Before you just rename it to marvell,nr-ports or
> something, how about having one sub-node per port:
> 
> sata_phy0: sata-phy at e90100 {
> 	compatible = "marvell,berlin-sata-phy";
> 	reg = <0xe90100 0x80>;
> 	status = "disabled";
> };
> 
> sata_phy1: sata-phy at e90180 {
> 	compatible = "marvell,berlin-sata-phy";
> 	reg = <0xe90180 0x80>;
> 	status = "disabled";
> };
> 
> ahci: sata at e90000 {
> 	compatible = "marvell,berlin-ahci";
> 	reg = <0xe90000 0x100>;
> 	interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> 	#address-cells = <1>;
> 	#size-cells = <0>;
> 	status = "disabled";
> 
> 	sata-port at 0 {
> 		reg = <0>;
> 		sata-phy = <&sata_phy0>;
> 		status = "disabled";
> 	};
> 
> 	sata-port at 1 {
> 		reg = <1>;
> 		sata-phy = <&sata_phy1>;
> 		status = "okay";
> 	};
> };
> 
> That way you can
> (a) separate a PHY driver that has little code but is able to power-down
>     the PHY even if there is no AHCI driver loaded.
> (b) enable/disable each port individually.
> (c) enable port1 while port0 is disabled.
> (d) disable the PLL if there is no port enabled at all.

That would be better, but as of now I'm not sure I have enough information on
the PHY to do (a).

I guess (b), (c) and (d) can still be done.

Thanks for the review!

Antoine

-- 
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Antoine Ténart]

Rob,

On Tue, Apr 22, 2014 at 01:54:33PM -0500, Rob Herring wrote:
> On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring <robherring2@gmail.com> wrote:
> > On Tue, Apr 22, 2014 at 10:38 AM, Antoine Ténart
> > <antoine.tenart@free-electrons.com> wrote:
> >> Add support for the Berlin SoCs AHCI SATA controller allowing to
> >> interface with devices like external hard drives.
> 
> One more thing.
> 
> >> +       nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
> >> +
> >> +       /* force_map is modified only if the property is found */
> >> +       of_property_read_u32(np, "marvell,force-port-map", &force_map);
> 
> This property does not appear to be documented.

I'll update it regarding Sebastian comments, or maybe drop it if it is
possible to enable each port individually.

> 
> >> +       if (force_map)
> >> +               nports = force_map;
> 
> You don't need this as your comment says, you can just do:
> 
> of_property_read_u32(np, "marvell,force-port-map", &nports);
> 
> nports will only be changed if property is present.

Sure.

Thanks!

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Antoine Ténart]

Rob,

On Tue, Apr 22, 2014 at 01:54:33PM -0500, Rob Herring wrote:
> On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring <robherring2@gmail.com> wrote:
> > On Tue, Apr 22, 2014 at 10:38 AM, Antoine Ténart
> > <antoine.tenart@free-electrons.com> wrote:
> >> Add support for the Berlin SoCs AHCI SATA controller allowing to
> >> interface with devices like external hard drives.
> 
> One more thing.
> 
> >> +       nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
> >> +
> >> +       /* force_map is modified only if the property is found */
> >> +       of_property_read_u32(np, "marvell,force-port-map", &force_map);
> 
> This property does not appear to be documented.

I'll update it regarding Sebastian comments, or maybe drop it if it is
possible to enable each port individually.

> 
> >> +       if (force_map)
> >> +               nports = force_map;
> 
> You don't need this as your comment says, you can just do:
> 
> of_property_read_u32(np, "marvell,force-port-map", &nports);
> 
> nports will only be changed if property is present.

Sure.

Thanks!

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Antoine Ténart]

Rob,

On Tue, Apr 22, 2014 at 01:54:33PM -0500, Rob Herring wrote:
> On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring <robherring2@gmail.com> wrote:
> > On Tue, Apr 22, 2014 at 10:38 AM, Antoine T?nart
> > <antoine.tenart@free-electrons.com> wrote:
> >> Add support for the Berlin SoCs AHCI SATA controller allowing to
> >> interface with devices like external hard drives.
> 
> One more thing.
> 
> >> +       nports = readl(hpriv->mmio + HOST_PORTS_IMPL);
> >> +
> >> +       /* force_map is modified only if the property is found */
> >> +       of_property_read_u32(np, "marvell,force-port-map", &force_map);
> 
> This property does not appear to be documented.

I'll update it regarding Sebastian comments, or maybe drop it if it is
possible to enable each port individually.

> 
> >> +       if (force_map)
> >> +               nports = force_map;
> 
> You don't need this as your comment says, you can just do:
> 
> of_property_read_u32(np, "marvell,force-port-map", &nports);
> 
> nports will only be changed if property is present.

Sure.

Thanks!

Antoine

-- 
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Antoine Ténart]

Rob,

On Tue, Apr 22, 2014 at 01:47:43PM -0500, Rob Herring wrote:
> On Tue, Apr 22, 2014 at 10:38 AM, Antoine Ténart
> <antoine.tenart@free-electrons.com> wrote:

[…]

> > +static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
> > +                                            u32 set_val)
> > +{
> > +       u32 regval;
> > +
> > +       regval = readl(reg);
> > +       regval &= ~(clear_val);
> > +       regval |= set_val;
> > +       writel(regval, reg);
> > +}
> > +
> > +static void ahci_berlin_init(void __iomem *mmio)
> 
> I don't really see the point of a function to do 2 register writes of
> magic values especially when the function name doesn't provide any
> indication of what you are doing really.
> 
> > +{
> > +       /* interface select */
> > +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
> > +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,
> 
> 2 writes to the same reg? Is this supposed to be the VSA_DATA register?

You're right it's VSA_DATA.

> 
> > +                           BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));
> 
> Use of BIT is only helpful to people that don't understand hex. Can
> you define what these bits are. Otherwise, just use 0x00240034 and
> note that it is magic value which you have no idea what the bits are.

This is magic. I'll update and add a comment.

> > +static void ahci_berlin_port_init(void __iomem *mmio, unsigned int ports)
> > +{
> > +       int p;
> > +
> > +       /* power down pll */
> > +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> > +       ahci_berlin_reg_setbits(mmio + HOST_VSA_DATA, BIT(6));
> > +
> > +       for (p = 0; p < ports; p++) {
> > +               /* port control register */
> > +               void __iomem *ctrl_reg = mmio + 0x100 + (p * 0x80);
> > +
> > +               /* set PHY mode to SATA, ref freq to 25 MHz */
> > +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x201);
> > +               ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> > +                                         0xff, BIT(0));
> 
> So you have registers hidden behind an address and data register.
> Perhaps a read and write function to provide that access rather than
> all these set/clear bit functions.

I'd like to do so if I could name 0x201, 0x225 ...
I can also merge the two functions if you think it's better for
readability.

Thanks!

Antoine


-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Antoine Ténart]

Rob,

On Tue, Apr 22, 2014 at 01:47:43PM -0500, Rob Herring wrote:
> On Tue, Apr 22, 2014 at 10:38 AM, Antoine Ténart
> <antoine.tenart@free-electrons.com> wrote:

[…]

> > +static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
> > +                                            u32 set_val)
> > +{
> > +       u32 regval;
> > +
> > +       regval = readl(reg);
> > +       regval &= ~(clear_val);
> > +       regval |= set_val;
> > +       writel(regval, reg);
> > +}
> > +
> > +static void ahci_berlin_init(void __iomem *mmio)
> 
> I don't really see the point of a function to do 2 register writes of
> magic values especially when the function name doesn't provide any
> indication of what you are doing really.
> 
> > +{
> > +       /* interface select */
> > +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
> > +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,
> 
> 2 writes to the same reg? Is this supposed to be the VSA_DATA register?

You're right it's VSA_DATA.

> 
> > +                           BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));
> 
> Use of BIT is only helpful to people that don't understand hex. Can
> you define what these bits are. Otherwise, just use 0x00240034 and
> note that it is magic value which you have no idea what the bits are.

This is magic. I'll update and add a comment.

> > +static void ahci_berlin_port_init(void __iomem *mmio, unsigned int ports)
> > +{
> > +       int p;
> > +
> > +       /* power down pll */
> > +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> > +       ahci_berlin_reg_setbits(mmio + HOST_VSA_DATA, BIT(6));
> > +
> > +       for (p = 0; p < ports; p++) {
> > +               /* port control register */
> > +               void __iomem *ctrl_reg = mmio + 0x100 + (p * 0x80);
> > +
> > +               /* set PHY mode to SATA, ref freq to 25 MHz */
> > +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x201);
> > +               ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> > +                                         0xff, BIT(0));
> 
> So you have registers hidden behind an address and data register.
> Perhaps a read and write function to provide that access rather than
> all these set/clear bit functions.

I'd like to do so if I could name 0x201, 0x225 ...
I can also merge the two functions if you think it's better for
readability.

Thanks!

Antoine


-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Antoine Ténart]

Rob,

On Tue, Apr 22, 2014 at 01:47:43PM -0500, Rob Herring wrote:
> On Tue, Apr 22, 2014 at 10:38 AM, Antoine T?nart
> <antoine.tenart@free-electrons.com> wrote:

[?]

> > +static inline void ahci_berlin_reg_clear_set(void __iomem *reg, u32 clear_val,
> > +                                            u32 set_val)
> > +{
> > +       u32 regval;
> > +
> > +       regval = readl(reg);
> > +       regval &= ~(clear_val);
> > +       regval |= set_val;
> > +       writel(regval, reg);
> > +}
> > +
> > +static void ahci_berlin_init(void __iomem *mmio)
> 
> I don't really see the point of a function to do 2 register writes of
> magic values especially when the function name doesn't provide any
> indication of what you are doing really.
> 
> > +{
> > +       /* interface select */
> > +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, BIT(2));
> > +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR,
> 
> 2 writes to the same reg? Is this supposed to be the VSA_DATA register?

You're right it's VSA_DATA.

> 
> > +                           BIT(21) | BIT(18) | BIT(5) | BIT(4) | BIT(2));
> 
> Use of BIT is only helpful to people that don't understand hex. Can
> you define what these bits are. Otherwise, just use 0x00240034 and
> note that it is magic value which you have no idea what the bits are.

This is magic. I'll update and add a comment.

> > +static void ahci_berlin_port_init(void __iomem *mmio, unsigned int ports)
> > +{
> > +       int p;
> > +
> > +       /* power down pll */
> > +       ahci_berlin_reg_set(mmio + HOST_VSA_ADDR, 0x0);
> > +       ahci_berlin_reg_setbits(mmio + HOST_VSA_DATA, BIT(6));
> > +
> > +       for (p = 0; p < ports; p++) {
> > +               /* port control register */
> > +               void __iomem *ctrl_reg = mmio + 0x100 + (p * 0x80);
> > +
> > +               /* set PHY mode to SATA, ref freq to 25 MHz */
> > +               ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, 0x201);
> > +               ahci_berlin_reg_clear_set(ctrl_reg + PORT_VSR_DATA,
> > +                                         0xff, BIT(0));
> 
> So you have registers hidden behind an address and data register.
> Perhaps a read and write function to provide that access rather than
> all these set/clear bit functions.

I'd like to do so if I could name 0x201, 0x225 ...
I can also merge the two functions if you think it's better for
readability.

Thanks!

Antoine


-- 
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 5/6] ARM: berlin: add the AHCI node for the BG2

[Antoine Ténart]

Jisheng,

On Wed, Apr 23, 2014 at 10:45:39AM +0800, Jisheng Zhang wrote:
> On Tue, 22 Apr 2014 08:38:24 -0700
> Antoine Ténart <antoine.tenart@free-electrons.com> wrote:
> 
> > The BG2 has an AHCI SATA controller. Add the corresponding node
> > in its device tree.
> 
> The AHCI IP of BG2 is different with BG2Q, so the driver in the series of patch
> doesn't work on BG2.

Thanks for the info! I'll drop BG2 and BG2CD nodes in the v2.

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 5/6] ARM: berlin: add the AHCI node for the BG2

[Antoine Ténart]

Jisheng,

On Wed, Apr 23, 2014 at 10:45:39AM +0800, Jisheng Zhang wrote:
> On Tue, 22 Apr 2014 08:38:24 -0700
> Antoine Ténart <antoine.tenart@free-electrons.com> wrote:
> 
> > The BG2 has an AHCI SATA controller. Add the corresponding node
> > in its device tree.
> 
> The AHCI IP of BG2 is different with BG2Q, so the driver in the series of patch
> doesn't work on BG2.

Thanks for the info! I'll drop BG2 and BG2CD nodes in the v2.

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[PATCH 5/6] ARM: berlin: add the AHCI node for the BG2

[Antoine Ténart]

Jisheng,

On Wed, Apr 23, 2014 at 10:45:39AM +0800, Jisheng Zhang wrote:
> On Tue, 22 Apr 2014 08:38:24 -0700
> Antoine T?nart <antoine.tenart@free-electrons.com> wrote:
> 
> > The BG2 has an AHCI SATA controller. Add the corresponding node
> > in its device tree.
> 
> The AHCI IP of BG2 is different with BG2Q, so the driver in the series of patch
> doesn't work on BG2.

Thanks for the info! I'll drop BG2 and BG2CD nodes in the v2.

Antoine

-- 
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Jisheng Zhang]

Hi Antoine,

On Tue, 22 Apr 2014 08:38:20 -0700
Antoine Ténart <antoine.tenart@free-electrons.com> wrote:

> +		/* CT timing fix */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) |
> BIT(1));
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> +				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> +				    BIT(10) | BIT(2) | BIT(1));

Could you please remove these code? They are not used for BG2Q, I'm sorry there's
such mistake in the code I provided to you ;)

Thanks

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Jisheng Zhang]

Hi Antoine,

On Tue, 22 Apr 2014 08:38:20 -0700
Antoine Ténart <antoine.tenart@free-electrons.com> wrote:

> +		/* CT timing fix */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) |
> BIT(1));
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> +				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> +				    BIT(10) | BIT(2) | BIT(1));

Could you please remove these code? They are not used for BG2Q, I'm sorry there's
such mistake in the code I provided to you ;)

Thanks

[PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Jisheng Zhang]

Hi Antoine,

On Tue, 22 Apr 2014 08:38:20 -0700
Antoine T?nart <antoine.tenart@free-electrons.com> wrote:

> +		/* CT timing fix */
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) |
> BIT(1));
> +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> +				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> +				    BIT(10) | BIT(2) | BIT(1));

Could you please remove these code? They are not used for BG2Q, I'm sorry there's
such mistake in the code I provided to you ;)

Thanks

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Antoine Ténart]

Hi Jisheng,

On Thu, Apr 24, 2014 at 05:50:41PM +0800, Jisheng Zhang wrote:
> Hi Antoine,
> 
> On Tue, 22 Apr 2014 08:38:20 -0700
> Antoine Ténart <antoine.tenart@free-electrons.com> wrote:
> 
> > +		/* CT timing fix */
> > +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) |
> > BIT(1));
> > +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> > +				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> > +				    BIT(10) | BIT(2) | BIT(1));
> 
> Could you please remove these code? They are not used for BG2Q, I'm sorry there's
> such mistake in the code I provided to you ;)

OK, thanks for the update!

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Antoine Ténart]

Hi Jisheng,

On Thu, Apr 24, 2014 at 05:50:41PM +0800, Jisheng Zhang wrote:
> Hi Antoine,
> 
> On Tue, 22 Apr 2014 08:38:20 -0700
> Antoine Ténart <antoine.tenart@free-electrons.com> wrote:
> 
> > +		/* CT timing fix */
> > +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) |
> > BIT(1));
> > +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> > +				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> > +				    BIT(10) | BIT(2) | BIT(1));
> 
> Could you please remove these code? They are not used for BG2Q, I'm sorry there's
> such mistake in the code I provided to you ;)

OK, thanks for the update!

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs

[Antoine Ténart]

Hi Jisheng,

On Thu, Apr 24, 2014 at 05:50:41PM +0800, Jisheng Zhang wrote:
> Hi Antoine,
> 
> On Tue, 22 Apr 2014 08:38:20 -0700
> Antoine T?nart <antoine.tenart@free-electrons.com> wrote:
> 
> > +		/* CT timing fix */
> > +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR, BIT(6) |
> > BIT(1));
> > +		ahci_berlin_reg_set(ctrl_reg + PORT_VSR_ADDR,
> > +				    BIT(15) | BIT(13) | BIT(12) | BIT(11) |
> > +				    BIT(10) | BIT(2) | BIT(1));
> 
> Could you please remove these code? They are not used for BG2Q, I'm sorry there's
> such mistake in the code I provided to you ;)

OK, thanks for the update!

Antoine

-- 
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com