From: Richard Zhu <hongxing.zhu@nxp.com> To: Francesco Dolcini <francesco.dolcini@toradex.com> Cc: Mark Brown <broonie@kernel.org>, "l.stach@pengutronix.de" <l.stach@pengutronix.de>, "bhelgaas@google.com" <bhelgaas@google.com>, "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>, "jingoohan1@gmail.com" <jingoohan1@gmail.com>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kernel@pengutronix.de" <kernel@pengutronix.de> Subject: RE: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never came up Date: Tue, 26 Oct 2021 09:06:56 +0000 [thread overview] Message-ID: <AS8PR04MB867692D946818A84575F71AA8C849@AS8PR04MB8676.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20211026085221.GA87230@francesco-nb.int.toradex.com> > -----Original Message----- > From: Francesco Dolcini <francesco.dolcini@toradex.com> > Sent: Tuesday, October 26, 2021 4:52 PM > To: Richard Zhu <hongxing.zhu@nxp.com> > Cc: Mark Brown <broonie@kernel.org>; Francesco Dolcini > <francesco.dolcini@toradex.com>; l.stach@pengutronix.de; > bhelgaas@google.com; lorenzo.pieralisi@arm.com; jingoohan1@gmail.com; > linux-pci@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > kernel@pengutronix.de > Subject: Re: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never > came up > > On Tue, Oct 26, 2021 at 02:18:18AM +0000, Richard Zhu wrote: > > The _enabled check is used because that this regulator is optional in the HW > design. > > To make the codes clean and aligned on different HW boards, the _enabled > check is added. > > > > The root cause is that the error return is not handled properly by the > controller driver. > > I.MX PCIe controller doesn't support the Hot-Plug, and it would return > > -110 error when PCIe link never came up. Thus, the _probe would be failed > in the end. > > The clocks/regulator usage balance should be considered by i.MX PCIe > controller, that's all. > > It's not a general case, and the problem is not caused by the regulator > support. > > Hello Richard, > I have one curiosity on this topic. Does this works well in case the regulator is > shared? I just want to be sure that if the regulator is shared everything is > working fine even if the PCI-E link is not used or not coming up for any reason. > [Richard Zhu] Hi Francesco: Actually, this regulator used by i.MX PCIe controller driver is one fixed gpio regulator. Refer to my understand, this regulator is not shared by different devices. Up to now, it works fine to power up the PCIe slot populated on the HW board. BR Richard > Francesco
WARNING: multiple messages have this Message-ID (diff)
From: Richard Zhu <hongxing.zhu@nxp.com> To: Francesco Dolcini <francesco.dolcini@toradex.com> Cc: Mark Brown <broonie@kernel.org>, "l.stach@pengutronix.de" <l.stach@pengutronix.de>, "bhelgaas@google.com" <bhelgaas@google.com>, "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>, "jingoohan1@gmail.com" <jingoohan1@gmail.com>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kernel@pengutronix.de" <kernel@pengutronix.de> Subject: RE: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never came up Date: Tue, 26 Oct 2021 09:06:56 +0000 [thread overview] Message-ID: <AS8PR04MB867692D946818A84575F71AA8C849@AS8PR04MB8676.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20211026085221.GA87230@francesco-nb.int.toradex.com> > -----Original Message----- > From: Francesco Dolcini <francesco.dolcini@toradex.com> > Sent: Tuesday, October 26, 2021 4:52 PM > To: Richard Zhu <hongxing.zhu@nxp.com> > Cc: Mark Brown <broonie@kernel.org>; Francesco Dolcini > <francesco.dolcini@toradex.com>; l.stach@pengutronix.de; > bhelgaas@google.com; lorenzo.pieralisi@arm.com; jingoohan1@gmail.com; > linux-pci@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > kernel@pengutronix.de > Subject: Re: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never > came up > > On Tue, Oct 26, 2021 at 02:18:18AM +0000, Richard Zhu wrote: > > The _enabled check is used because that this regulator is optional in the HW > design. > > To make the codes clean and aligned on different HW boards, the _enabled > check is added. > > > > The root cause is that the error return is not handled properly by the > controller driver. > > I.MX PCIe controller doesn't support the Hot-Plug, and it would return > > -110 error when PCIe link never came up. Thus, the _probe would be failed > in the end. > > The clocks/regulator usage balance should be considered by i.MX PCIe > controller, that's all. > > It's not a general case, and the problem is not caused by the regulator > support. > > Hello Richard, > I have one curiosity on this topic. Does this works well in case the regulator is > shared? I just want to be sure that if the regulator is shared everything is > working fine even if the PCI-E link is not used or not coming up for any reason. > [Richard Zhu] Hi Francesco: Actually, this regulator used by i.MX PCIe controller driver is one fixed gpio regulator. Refer to my understand, this regulator is not shared by different devices. Up to now, it works fine to power up the PCIe slot populated on the HW board. BR Richard > Francesco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-26 9:07 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-22 7:12 [PATCH v3 0/7] PCI: imx6: refine codes and add compliance tests mode support Richard Zhu 2021-10-22 7:12 ` Richard Zhu 2021-10-22 7:12 ` [PATCH v3 1/7] PCI: imx6: Encapsulate the clock enable into one standalone function Richard Zhu 2021-10-22 7:12 ` Richard Zhu 2021-10-22 7:12 ` [PATCH v3 2/7] PCI: imx6: Add the error propagation from host_init Richard Zhu 2021-10-22 7:12 ` Richard Zhu 2021-10-22 7:12 ` [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never came up Richard Zhu 2021-10-22 7:12 ` Richard Zhu 2021-10-25 11:13 ` Francesco Dolcini 2021-10-25 11:13 ` Francesco Dolcini 2021-10-25 11:23 ` Mark Brown 2021-10-25 11:23 ` Mark Brown 2021-10-26 2:18 ` Richard Zhu 2021-10-26 2:18 ` Richard Zhu 2021-10-26 8:52 ` Francesco Dolcini 2021-10-26 8:52 ` Francesco Dolcini 2021-10-26 9:06 ` Richard Zhu [this message] 2021-10-26 9:06 ` Richard Zhu 2021-10-26 9:11 ` Francesco Dolcini 2021-10-26 9:11 ` Francesco Dolcini 2021-10-26 9:18 ` Richard Zhu 2021-10-26 9:18 ` Richard Zhu 2021-10-26 9:48 ` Francesco Dolcini 2021-10-26 9:48 ` Francesco Dolcini 2021-10-28 6:48 ` Richard Zhu 2021-10-28 6:48 ` Richard Zhu 2021-10-26 10:58 ` Mark Brown 2021-10-26 10:58 ` Mark Brown 2021-10-28 6:50 ` Richard Zhu 2021-10-28 6:50 ` Richard Zhu 2021-10-28 11:50 ` Mark Brown 2021-10-28 11:50 ` Mark Brown 2021-10-29 3:58 ` Richard Zhu 2021-10-29 3:58 ` Richard Zhu 2021-10-29 11:46 ` Mark Brown 2021-10-29 11:46 ` Mark Brown 2021-11-01 1:46 ` Richard Zhu 2021-11-01 1:46 ` Richard Zhu 2021-10-26 1:57 ` Richard Zhu 2021-10-26 1:57 ` Richard Zhu 2021-10-22 7:12 ` [PATCH v3 4/7] PCI: imx6: move the clock disable function to a proper place Richard Zhu 2021-10-22 7:12 ` Richard Zhu 2021-10-22 7:12 ` [PATCH v3 5/7] PCI: dwc: add a new callback host exit function into host ops Richard Zhu 2021-10-22 7:12 ` Richard Zhu 2021-10-22 7:12 ` [PATCH v3 6/7] PCI: imx6: Fix the reference handling unbalance when link never came up Richard Zhu 2021-10-22 7:12 ` Richard Zhu 2021-10-22 7:12 ` [PATCH v3 7/7] PCI: imx6: Add the compliance tests mode support Richard Zhu 2021-10-22 7:12 ` Richard Zhu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AS8PR04MB867692D946818A84575F71AA8C849@AS8PR04MB8676.eurprd04.prod.outlook.com \ --to=hongxing.zhu@nxp.com \ --cc=bhelgaas@google.com \ --cc=broonie@kernel.org \ --cc=francesco.dolcini@toradex.com \ --cc=jingoohan1@gmail.com \ --cc=kernel@pengutronix.de \ --cc=l.stach@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.