From: Mark Brown <broonie@kernel.org>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never came up
Date: Fri, 29 Oct 2021 12:46:00 +0100 [thread overview]
Message-ID: <YXve+HlpEWOzZ+k3@sirena.org.uk> (raw)
In-Reply-To: <AS8PR04MB8676CF52F4D8E9E4E6C07F758C879@AS8PR04MB8676.eurprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]
On Fri, Oct 29, 2021 at 03:58:41AM +0000, Richard Zhu wrote:
> > The driver should undo any enables it did itself, it should not undo any
> > enables that anything else did which means it should never be basing
> > decisions on regulator_is_enabled(). While the regulator may not be
> > shared in the particular board you're looking at it may be shared in other
> > systems.
> [Richard Zhu] Understood. Thanks.
> Can I disabled this regulator in PCIe probe failure handler without the
> regulator_is_enabled() check?
If the driver called regulator_enable() (and that didn't return an
error) it can always call regulator_disable() as many times as it called
regulator_enable(), no need to check if the regulator is still enabled.
When the driver hasn't successfully called regulator_enable() it
shouldn't call regulator_disable() even if the regualtor is enabled.
This means that after your driver has enabled the regulator it can just
disable it but between the regulator_get() and regulator_enable() it
shouldn't do that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never came up
Date: Fri, 29 Oct 2021 12:46:00 +0100 [thread overview]
Message-ID: <YXve+HlpEWOzZ+k3@sirena.org.uk> (raw)
In-Reply-To: <AS8PR04MB8676CF52F4D8E9E4E6C07F758C879@AS8PR04MB8676.eurprd04.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 1050 bytes --]
On Fri, Oct 29, 2021 at 03:58:41AM +0000, Richard Zhu wrote:
> > The driver should undo any enables it did itself, it should not undo any
> > enables that anything else did which means it should never be basing
> > decisions on regulator_is_enabled(). While the regulator may not be
> > shared in the particular board you're looking at it may be shared in other
> > systems.
> [Richard Zhu] Understood. Thanks.
> Can I disabled this regulator in PCIe probe failure handler without the
> regulator_is_enabled() check?
If the driver called regulator_enable() (and that didn't return an
error) it can always call regulator_disable() as many times as it called
regulator_enable(), no need to check if the regulator is still enabled.
When the driver hasn't successfully called regulator_enable() it
shouldn't call regulator_disable() even if the regualtor is enabled.
This means that after your driver has enabled the regulator it can just
disable it but between the regulator_get() and regulator_enable() it
shouldn't do that.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-29 11:46 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 7:12 [PATCH v3 0/7] PCI: imx6: refine codes and add compliance tests mode support Richard Zhu
2021-10-22 7:12 ` Richard Zhu
2021-10-22 7:12 ` [PATCH v3 1/7] PCI: imx6: Encapsulate the clock enable into one standalone function Richard Zhu
2021-10-22 7:12 ` Richard Zhu
2021-10-22 7:12 ` [PATCH v3 2/7] PCI: imx6: Add the error propagation from host_init Richard Zhu
2021-10-22 7:12 ` Richard Zhu
2021-10-22 7:12 ` [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never came up Richard Zhu
2021-10-22 7:12 ` Richard Zhu
2021-10-25 11:13 ` Francesco Dolcini
2021-10-25 11:13 ` Francesco Dolcini
2021-10-25 11:23 ` Mark Brown
2021-10-25 11:23 ` Mark Brown
2021-10-26 2:18 ` Richard Zhu
2021-10-26 2:18 ` Richard Zhu
2021-10-26 8:52 ` Francesco Dolcini
2021-10-26 8:52 ` Francesco Dolcini
2021-10-26 9:06 ` Richard Zhu
2021-10-26 9:06 ` Richard Zhu
2021-10-26 9:11 ` Francesco Dolcini
2021-10-26 9:11 ` Francesco Dolcini
2021-10-26 9:18 ` Richard Zhu
2021-10-26 9:18 ` Richard Zhu
2021-10-26 9:48 ` Francesco Dolcini
2021-10-26 9:48 ` Francesco Dolcini
2021-10-28 6:48 ` Richard Zhu
2021-10-28 6:48 ` Richard Zhu
2021-10-26 10:58 ` Mark Brown
2021-10-26 10:58 ` Mark Brown
2021-10-28 6:50 ` Richard Zhu
2021-10-28 6:50 ` Richard Zhu
2021-10-28 11:50 ` Mark Brown
2021-10-28 11:50 ` Mark Brown
2021-10-29 3:58 ` Richard Zhu
2021-10-29 3:58 ` Richard Zhu
2021-10-29 11:46 ` Mark Brown [this message]
2021-10-29 11:46 ` Mark Brown
2021-11-01 1:46 ` Richard Zhu
2021-11-01 1:46 ` Richard Zhu
2021-10-26 1:57 ` Richard Zhu
2021-10-26 1:57 ` Richard Zhu
2021-10-22 7:12 ` [PATCH v3 4/7] PCI: imx6: move the clock disable function to a proper place Richard Zhu
2021-10-22 7:12 ` Richard Zhu
2021-10-22 7:12 ` [PATCH v3 5/7] PCI: dwc: add a new callback host exit function into host ops Richard Zhu
2021-10-22 7:12 ` Richard Zhu
2021-10-22 7:12 ` [PATCH v3 6/7] PCI: imx6: Fix the reference handling unbalance when link never came up Richard Zhu
2021-10-22 7:12 ` Richard Zhu
2021-10-22 7:12 ` [PATCH v3 7/7] PCI: imx6: Add the compliance tests mode support Richard Zhu
2021-10-22 7:12 ` Richard Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXve+HlpEWOzZ+k3@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bhelgaas@google.com \
--cc=francesco.dolcini@toradex.com \
--cc=hongxing.zhu@nxp.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.