From: Mark Brown <broonie@kernel.org>
To: Francesco Dolcini <francesco.dolcini@toradex.com>
Cc: Richard Zhu <hongxing.zhu@nxp.com>,
l.stach@pengutronix.de, bhelgaas@google.com,
lorenzo.pieralisi@arm.com, jingoohan1@gmail.com,
linux-pci@vger.kernel.org, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never came up
Date: Mon, 25 Oct 2021 12:23:48 +0100 [thread overview]
Message-ID: <YXaTxDJjhpcj5XBV@sirena.org.uk> (raw)
In-Reply-To: <20211025111312.GA31419@francesco-nb.int.toradex.com>
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
On Mon, Oct 25, 2021 at 01:13:12PM +0200, Francesco Dolcini wrote:
> Hello Richard,
> please see this comment from Mark, https://lore.kernel.org/all/YXaGve1ZJq0DGZ9l@sirena.org.uk/.
> > + if (imx6_pcie->vpcie
> > + && regulator_is_enabled(imx6_pcie->vpcie) > 0)
> > + regulator_disable(imx6_pcie->vpcie);
> > return ret;
I should probably also say that the check for the regulator looks buggy
as well, regulators should only be optional if they can be physically
absent which does not seem likely for PCI devices. If the driver is not
doing something to reconfigure the hardware to account for a missing
supply this is generally a big warning sign.
I really don't understand why regulator support is so frequently
problematic for PCI controllers. :(
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Francesco Dolcini <francesco.dolcini@toradex.com>
Cc: Richard Zhu <hongxing.zhu@nxp.com>,
l.stach@pengutronix.de, bhelgaas@google.com,
lorenzo.pieralisi@arm.com, jingoohan1@gmail.com,
linux-pci@vger.kernel.org, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never came up
Date: Mon, 25 Oct 2021 12:23:48 +0100 [thread overview]
Message-ID: <YXaTxDJjhpcj5XBV@sirena.org.uk> (raw)
In-Reply-To: <20211025111312.GA31419@francesco-nb.int.toradex.com>
[-- Attachment #1.1: Type: text/plain, Size: 768 bytes --]
On Mon, Oct 25, 2021 at 01:13:12PM +0200, Francesco Dolcini wrote:
> Hello Richard,
> please see this comment from Mark, https://lore.kernel.org/all/YXaGve1ZJq0DGZ9l@sirena.org.uk/.
> > + if (imx6_pcie->vpcie
> > + && regulator_is_enabled(imx6_pcie->vpcie) > 0)
> > + regulator_disable(imx6_pcie->vpcie);
> > return ret;
I should probably also say that the check for the regulator looks buggy
as well, regulators should only be optional if they can be physically
absent which does not seem likely for PCI devices. If the driver is not
doing something to reconfigure the hardware to account for a missing
supply this is generally a big warning sign.
I really don't understand why regulator support is so frequently
problematic for PCI controllers. :(
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-25 11:23 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 7:12 [PATCH v3 0/7] PCI: imx6: refine codes and add compliance tests mode support Richard Zhu
2021-10-22 7:12 ` Richard Zhu
2021-10-22 7:12 ` [PATCH v3 1/7] PCI: imx6: Encapsulate the clock enable into one standalone function Richard Zhu
2021-10-22 7:12 ` Richard Zhu
2021-10-22 7:12 ` [PATCH v3 2/7] PCI: imx6: Add the error propagation from host_init Richard Zhu
2021-10-22 7:12 ` Richard Zhu
2021-10-22 7:12 ` [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never came up Richard Zhu
2021-10-22 7:12 ` Richard Zhu
2021-10-25 11:13 ` Francesco Dolcini
2021-10-25 11:13 ` Francesco Dolcini
2021-10-25 11:23 ` Mark Brown [this message]
2021-10-25 11:23 ` Mark Brown
2021-10-26 2:18 ` Richard Zhu
2021-10-26 2:18 ` Richard Zhu
2021-10-26 8:52 ` Francesco Dolcini
2021-10-26 8:52 ` Francesco Dolcini
2021-10-26 9:06 ` Richard Zhu
2021-10-26 9:06 ` Richard Zhu
2021-10-26 9:11 ` Francesco Dolcini
2021-10-26 9:11 ` Francesco Dolcini
2021-10-26 9:18 ` Richard Zhu
2021-10-26 9:18 ` Richard Zhu
2021-10-26 9:48 ` Francesco Dolcini
2021-10-26 9:48 ` Francesco Dolcini
2021-10-28 6:48 ` Richard Zhu
2021-10-28 6:48 ` Richard Zhu
2021-10-26 10:58 ` Mark Brown
2021-10-26 10:58 ` Mark Brown
2021-10-28 6:50 ` Richard Zhu
2021-10-28 6:50 ` Richard Zhu
2021-10-28 11:50 ` Mark Brown
2021-10-28 11:50 ` Mark Brown
2021-10-29 3:58 ` Richard Zhu
2021-10-29 3:58 ` Richard Zhu
2021-10-29 11:46 ` Mark Brown
2021-10-29 11:46 ` Mark Brown
2021-11-01 1:46 ` Richard Zhu
2021-11-01 1:46 ` Richard Zhu
2021-10-26 1:57 ` Richard Zhu
2021-10-26 1:57 ` Richard Zhu
2021-10-22 7:12 ` [PATCH v3 4/7] PCI: imx6: move the clock disable function to a proper place Richard Zhu
2021-10-22 7:12 ` Richard Zhu
2021-10-22 7:12 ` [PATCH v3 5/7] PCI: dwc: add a new callback host exit function into host ops Richard Zhu
2021-10-22 7:12 ` Richard Zhu
2021-10-22 7:12 ` [PATCH v3 6/7] PCI: imx6: Fix the reference handling unbalance when link never came up Richard Zhu
2021-10-22 7:12 ` Richard Zhu
2021-10-22 7:12 ` [PATCH v3 7/7] PCI: imx6: Add the compliance tests mode support Richard Zhu
2021-10-22 7:12 ` Richard Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXaTxDJjhpcj5XBV@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bhelgaas@google.com \
--cc=francesco.dolcini@toradex.com \
--cc=hongxing.zhu@nxp.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.