linux-next: build warning after merge of the block tree

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (sparc64 defconfig)
produced this warning:

/home/sfr/next/next/drivers/block/sunvdc.c: In function 'init_queue':
/home/sfr/next/next/drivers/block/sunvdc.c:788:6: warning: unused variable 'ret' [-Wunused-variable]
  int ret;
      ^~~

Introduced by commit

  fa182a1fa97d ("sunvdc: convert to blk-mq")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 11/7/18 8:31 PM, Stephen Rothwell wrote:
> Hi Jens,
> 
> After merging the block tree, today's linux-next build (sparc64 defconfig)
> produced this warning:
> 
> /home/sfr/next/next/drivers/block/sunvdc.c: In function 'init_queue':
> /home/sfr/next/next/drivers/block/sunvdc.c:788:6: warning: unused variable 'ret' [-Wunused-variable]
>   int ret;
>       ^~~
> 
> Introduced by commit
> 
>   fa182a1fa97d ("sunvdc: convert to blk-mq")

Thanks, leftover from v2 of the conversion that switched to the
sq init queue helper. I'll fix it.

-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

include/linux/pipe_fs_i.h:214: warning: Function parameter or member 'nonblock' not described in 'pipe_buf_confirm'

Introduced by commit

  342a048d7390 ("fs: add 'nonblock' parameter to pipe_buf_confirm() and fops method")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 3/14/23 7:48 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> include/linux/pipe_fs_i.h:214: warning: Function parameter or member 'nonblock' not described in 'pipe_buf_confirm'
> 
> Introduced by commit
> 
>   342a048d7390 ("fs: add 'nonblock' parameter to pipe_buf_confirm() and fops method")

Thanks, I'll fix that up.

-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

fs/splice.c:301: warning: Function parameter or member 'file' not described in 'generic_file_splice_read'
fs/splice.c:301: warning: Excess function parameter 'in' description in 'generic_file_splice_read'

Introduced by commit

  df77cb28d575 ("vfs, iomap: Fix generic_file_splice_read() to avoid reversion of ITER_PIPE")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/block/ublk.rst:157: WARNING: Enumerated list ends without a blank line; unexpected unindent.
Documentation/block/ublk.rst:169: WARNING: Enumerated list ends without a blank line; unexpected unindent.

Introduced by commit

  56f5160bc1b8 ("ublk_drv: add mechanism for supporting unprivileged ublk device")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

include/linux/skbuff.h:1051: warning: Function parameter or member 'scm_io_uring' not described in 'sk_buff'

Introduced by commit

  0dd99edbfae7 ("io_uring/af_unix: defer registered files gc to io_uring release")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 10/5/22 1:17 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> include/linux/skbuff.h:1051: warning: Function parameter or member 'scm_io_uring' not described in 'sk_buff'
> 
> Introduced by commit
> 
>   0dd99edbfae7 ("io_uring/af_unix: defer registered files gc to io_uring release")

Thanks, fixed.

-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

Hi all,

After merging the block tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

io_uring/net.c: In function 'io_sendzc':
io_uring/net.c:980:41: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  980 |                                         (u64)zc->buf, zc->len);
      |                                         ^

Introduced by commit

  bb4019de9ea1 ("io_uring: sendzc with fixed buffers")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1457 bytes --]

Hi all,

On Wed, 20 Jul 2022 13:33:06 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> io_uring/net.c: In function 'io_sendzc':
> io_uring/net.c:980:41: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>   980 |                                         (u64)zc->buf, zc->len);
>       |                                         ^
> 
> Introduced by commit
> 
>   bb4019de9ea1 ("io_uring: sendzc with fixed buffers")

This become an error in my i386 defconfig build, so I applied the
following patch.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 20 Jul 2022 21:19:15 +1000
Subject: [PATCH] fix up for "io_uring: sendzc with fixed buffers"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 io_uring/net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/io_uring/net.c b/io_uring/net.c
index 282401255ab4..903a0de689fb 100644
--- a/io_uring/net.c
+++ b/io_uring/net.c
@@ -977,7 +977,7 @@ int io_sendzc(struct io_kiocb *req, unsigned int issue_flags)
 
 	if (zc->flags & IORING_RECVSEND_FIXED_BUF) {
 		ret = io_import_fixed(WRITE, &msg.msg_iter, req->imu,
-					(u64)zc->buf, zc->len);
+					(u64)(unsigned long)zc->buf, zc->len);
 		if (unlikely(ret))
 				return ret;
 	} else {
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 7/19/22 9:33 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> io_uring/net.c: In function 'io_sendzc':
> io_uring/net.c:980:41: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>   980 |                                         (u64)zc->buf, zc->len);
>       |                                         ^
> 
> Introduced by commit
> 
>   bb4019de9ea1 ("io_uring: sendzc with fixed buffers")

I pushed a fix for this, thanks Stephen.

-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

kernel/trace/blktrace.c:1884: warning: Function parameter or member 'opf' not described in 'blk_fill_rwbs'
kernel/trace/blktrace.c:1884: warning: Excess function parameter 'op' description in 'blk_fill_rwbs'

Introduced by commit

  919dbca8670d ("blktrace: Use the new blk_opf_t type")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]

Hi all,

After merging the block tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/linux/slab.h:16,
                 from io_uring/net.c:5:
io_uring/net.c: In function 'io_recvmsg_multishot_overflow':
include/linux/overflow.h:67:22: warning: comparison of distinct pointer types lacks a cast
   67 |         (void) (&__a == &__b);                  \
      |                      ^~
io_uring/net.c:332:13: note: in expansion of macro 'check_add_overflow'
  332 |         if (check_add_overflow(sizeof(struct io_uring_recvmsg_out),
      |             ^~~~~~~~~~~~~~~~~~
include/linux/overflow.h:68:22: warning: comparison of distinct pointer types lacks a cast
   68 |         (void) (&__a == __d);                   \
      |                      ^~
io_uring/net.c:332:13: note: in expansion of macro 'check_add_overflow'
  332 |         if (check_add_overflow(sizeof(struct io_uring_recvmsg_out),
      |             ^~~~~~~~~~~~~~~~~~
include/linux/overflow.h:67:22: warning: comparison of distinct pointer types lacks a cast
   67 |         (void) (&__a == &__b);                  \
      |                      ^~
io_uring/net.c:335:13: note: in expansion of macro 'check_add_overflow'
  335 |         if (check_add_overflow(hdr, iomsg->controllen, &hdr))
      |             ^~~~~~~~~~~~~~~~~~

Introduced by commit

  a8b38c4ce724 ("io_uring: support multishot in recvmsg")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2751 bytes --]

Hi all,

On Fri, 15 Jul 2022 13:52:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> In file included from include/linux/slab.h:16,
>                  from io_uring/net.c:5:
> io_uring/net.c: In function 'io_recvmsg_multishot_overflow':
> include/linux/overflow.h:67:22: warning: comparison of distinct pointer types lacks a cast
>    67 |         (void) (&__a == &__b);                  \
>       |                      ^~
> io_uring/net.c:332:13: note: in expansion of macro 'check_add_overflow'
>   332 |         if (check_add_overflow(sizeof(struct io_uring_recvmsg_out),
>       |             ^~~~~~~~~~~~~~~~~~
> include/linux/overflow.h:68:22: warning: comparison of distinct pointer types lacks a cast
>    68 |         (void) (&__a == __d);                   \
>       |                      ^~
> io_uring/net.c:332:13: note: in expansion of macro 'check_add_overflow'
>   332 |         if (check_add_overflow(sizeof(struct io_uring_recvmsg_out),
>       |             ^~~~~~~~~~~~~~~~~~
> include/linux/overflow.h:67:22: warning: comparison of distinct pointer types lacks a cast
>    67 |         (void) (&__a == &__b);                  \
>       |                      ^~
> io_uring/net.c:335:13: note: in expansion of macro 'check_add_overflow'
>   335 |         if (check_add_overflow(hdr, iomsg->controllen, &hdr))
>       |             ^~~~~~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   a8b38c4ce724 ("io_uring: support multishot in recvmsg")

This became a build failure in my i386 defconfig build.  So I have
applied the following (probably not correct) patch that makes it build.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 15 Jul 2022 21:55:32 +1000
Subject: [PATCH] fix up for "io_uring: support multishot in recvmsg"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 io_uring/net.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/io_uring/net.c b/io_uring/net.c
index 616d5f04cc74..187822e18dd6 100644
--- a/io_uring/net.c
+++ b/io_uring/net.c
@@ -329,10 +329,10 @@ static bool io_recvmsg_multishot_overflow(struct io_async_msghdr *iomsg)
 {
 	unsigned long hdr;
 
-	if (check_add_overflow(sizeof(struct io_uring_recvmsg_out),
+	if (check_add_overflow((unsigned long)sizeof(struct io_uring_recvmsg_out),
 			       (unsigned long)iomsg->namelen, &hdr))
 		return true;
-	if (check_add_overflow(hdr, iomsg->controllen, &hdr))
+	if (check_add_overflow(hdr, (unsigned long)iomsg->controllen, &hdr))
 		return true;
 	if (hdr > INT_MAX)
 		return true;
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Dylan Yudaken]

On Fri, 2022-07-15 at 22:33 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Fri, 15 Jul 2022 13:52:32 +1000 Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> > 
> > After merging the block tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> > 
> > In file included from include/linux/slab.h:16,
> >                  from io_uring/net.c:5:
> > io_uring/net.c: In function 'io_recvmsg_multishot_overflow':
> > include/linux/overflow.h:67:22: warning: comparison of distinct
> > pointer types lacks a cast
> >    67 |         (void) (&__a == &__b);                  \
> >       |                      ^~
> > io_uring/net.c:332:13: note: in expansion of macro
> > 'check_add_overflow'
> >   332 |         if (check_add_overflow(sizeof(struct
> > io_uring_recvmsg_out),
> >       |             ^~~~~~~~~~~~~~~~~~
> > include/linux/overflow.h:68:22: warning: comparison of distinct
> > pointer types lacks a cast
> >    68 |         (void) (&__a == __d);                   \
> >       |                      ^~
> > io_uring/net.c:332:13: note: in expansion of macro
> > 'check_add_overflow'
> >   332 |         if (check_add_overflow(sizeof(struct
> > io_uring_recvmsg_out),
> >       |             ^~~~~~~~~~~~~~~~~~
> > include/linux/overflow.h:67:22: warning: comparison of distinct
> > pointer types lacks a cast
> >    67 |         (void) (&__a == &__b);                  \
> >       |                      ^~
> > io_uring/net.c:335:13: note: in expansion of macro
> > 'check_add_overflow'
> >   335 |         if (check_add_overflow(hdr, iomsg->controllen,
> > &hdr))
> >       |             ^~~~~~~~~~~~~~~~~~
> > 
> > Introduced by commit
> > 
> >   a8b38c4ce724 ("io_uring: support multishot in recvmsg")
> 
> This became a build failure in my i386 defconfig build.  So I have
> applied the following (probably not correct) patch that makes it
> build.
> 

Thanks for this. Your patch will probably not cause much damage,
however I have suggested the below patch to io_uring since I noticed
that the current logic was a bit off

Dylan


From: Dylan Yudaken <dylany@fb.com>
Date: Fri, 15 Jul 2022 05:55:02 -0700
Subject: [PATCH for-next] io_uring: fix types in
io_recvmsg_multishot_overflow

io_recvmsg_multishot_overflow had incorrect types on non x64 system.
But also it had an unnecessary INT_MAX check, which could just be done
by changing the type of the accumulator to int (also simplifying the
casts).

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: a8b38c4ce724 ("io_uring: support multishot in recvmsg")
Signed-off-by: Dylan Yudaken <dylany@fb.com>
---
 io_uring/net.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/io_uring/net.c b/io_uring/net.c
index 616d5f04cc74..6b7d5f33e642 100644
--- a/io_uring/net.c
+++ b/io_uring/net.c
@@ -327,14 +327,14 @@ int io_send(struct io_kiocb *req, unsigned int
issue_flags)
 
 static bool io_recvmsg_multishot_overflow(struct io_async_msghdr
*iomsg)
 {
-	unsigned long hdr;
+	int hdr;
 
-	if (check_add_overflow(sizeof(struct io_uring_recvmsg_out),
-			       (unsigned long)iomsg->namelen, &hdr))
+	if (iomsg->namelen < 0)
 		return true;
-	if (check_add_overflow(hdr, iomsg->controllen, &hdr))
+	if (check_add_overflow((int)sizeof(struct
io_uring_recvmsg_out),
+			       iomsg->namelen, &hdr))
 		return true;
-	if (hdr > INT_MAX)
+	if (check_add_overflow(hdr, (int)iomsg->controllen, &hdr))
 		return true;
 
 	return false;

base-commit: a8b38c4ce7240d869c820d457bcd51e452149510
-- 
2.30.2

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

Hi all,

After merging the block tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

fs/io_uring.c: In function '__io_sqe_files_unregister':
fs/io_uring.c:8992:13: warning: unused variable 'i' [-Wunused-variable]
 8992 |         int i;
      |             ^

Introduced by commit

  16b217ed7bb3 ("io_uring: store SCM state in io_fixed_file->file_ptr")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 4/20/22 8:02 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> fs/io_uring.c: In function '__io_sqe_files_unregister':
> fs/io_uring.c:8992:13: warning: unused variable 'i' [-Wunused-variable]
>  8992 |         int i;
>       |             ^
> 
> Introduced by commit
> 
>   16b217ed7bb3 ("io_uring: store SCM state in io_fixed_file->file_ptr")

Thanks, looks like I forgot to amend. Will fix it up.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1406 bytes --]

Hi all,

On Thu, 21 Apr 2022 12:02:03 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> fs/io_uring.c: In function '__io_sqe_files_unregister':
> fs/io_uring.c:8992:13: warning: unused variable 'i' [-Wunused-variable]
>  8992 |         int i;
>       |             ^
> 
> Introduced by commit
> 
>   16b217ed7bb3 ("io_uring: store SCM state in io_fixed_file->file_ptr")

This become a build failure for i386 defconfig, so I added the
following patch.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 21 Apr 2022 15:34:32 +1000
Subject: [PATCH] fix up for "io_uring: store SCM state in
 io_fixed_file->file_ptr"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 fs/io_uring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 1f6004ba0463..9ace35873810 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -8989,9 +8989,9 @@ static void io_free_file_tables(struct io_file_table *table)
 
 static void __io_sqe_files_unregister(struct io_ring_ctx *ctx)
 {
+#if !defined(IO_URING_SCM_ALL)
 	int i;
 
-#if !defined(IO_URING_SCM_ALL)
 	for (i = 0; i < ctx->nr_user_files; i++) {
 		struct file *file = io_file_from_index(ctx, i);
 
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

block/blk-core.c:1082: warning: Function parameter or member 'iob' not described in 'bio_poll'

Introduced by commit

  5a72e899ceb4 ("block: add a struct io_comp_batch argument to fops->iopoll()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

block/bio.c:1689: warning: Function parameter or member 'nr_vecs' not described in 'bio_alloc_kiocb'

Introduced by commit

  1cbbd31c4ada ("bio: add allocation cache abstraction")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 8/13/21 3:41 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> block/bio.c:1689: warning: Function parameter or member 'nr_vecs' not described in 'bio_alloc_kiocb'
> 
> Introduced by commit
> 
>   1cbbd31c4ada ("bio: add allocation cache abstraction")

Thanks, fixed up.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

Hi Jens,

On Fri, 13 Aug 2021 07:54:51 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>
> On 8/13/21 3:41 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the block tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > block/bio.c:1689: warning: Function parameter or member 'nr_vecs' not described in 'bio_alloc_kiocb'
> > 
> > Introduced by commit
> > 
> >   1cbbd31c4ada ("bio: add allocation cache abstraction")  
> 
> Thanks, fixed up.

Not really :-(  I am now also getting this (the above has moved to line
1704 as well):

block/bio.c:1704: warning: Excess function parameter 'nr_iovecs' description in 'bio_alloc_kiocb'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 9/3/21 12:49 AM, Stephen Rothwell wrote:
> Hi Jens,
> 
> On Fri, 13 Aug 2021 07:54:51 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 8/13/21 3:41 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the block tree, today's linux-next build (htmldocs)
>>> produced this warning:
>>>
>>> block/bio.c:1689: warning: Function parameter or member 'nr_vecs' not described in 'bio_alloc_kiocb'
>>>
>>> Introduced by commit
>>>
>>>   1cbbd31c4ada ("bio: add allocation cache abstraction")  
>>
>> Thanks, fixed up.
> 
> Not really :-(  I am now also getting this (the above has moved to line
> 1704 as well):
> 
> block/bio.c:1704: warning: Excess function parameter 'nr_iovecs' description in 'bio_alloc_kiocb'

This should fix that one up:

diff --git a/block/bio.c b/block/bio.c
index e16849f46b0e..5df3dd282e40 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1688,7 +1688,7 @@ EXPORT_SYMBOL(bioset_init_from_src);
 /**
  * bio_alloc_kiocb - Allocate a bio from bio_set based on kiocb
  * @kiocb:	kiocb describing the IO
- * @nr_iovecs:	number of iovecs to pre-allocate
+ * @nr_vecs:	number of iovecs to pre-allocate
  * @bs:		bio_set to allocate from
  *
  * Description:

-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]

Hi all,

After merging the block tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/linux/kernel.h:15,
                 from fs/io_uring.c:42:
fs/io_uring.c: In function 'io_alloc_page_table':
include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast
   20 |  (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
      |                            ^~
include/linux/minmax.h:26:4: note: in expansion of macro '__typecheck'
   26 |   (__typecheck(x, y) && __no_side_effects(x, y))
      |    ^~~~~~~~~~~
include/linux/minmax.h:36:24: note: in expansion of macro '__safe_cmp'
   36 |  __builtin_choose_expr(__safe_cmp(x, y), \
      |                        ^~~~~~~~~~
include/linux/minmax.h:45:19: note: in expansion of macro '__careful_cmp'
   45 | #define min(x, y) __careful_cmp(x, y, <)
      |                   ^~~~~~~~~~~~~
fs/io_uring.c:7095:28: note: in expansion of macro 'min'
 7095 |   unsigned int this_size = min(size, PAGE_SIZE);
      |                            ^~~

Introduced by commit

  9123c8ffce16 ("io_uring: add helpers for 2 level table alloc")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Pavel Begunkov]

On 6/15/21 3:13 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:

Will get sorted, thanks for letting us know
 

> In file included from include/linux/kernel.h:15,
>                  from fs/io_uring.c:42:
> fs/io_uring.c: In function 'io_alloc_page_table':
> include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast
>    20 |  (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
>       |                            ^~
> include/linux/minmax.h:26:4: note: in expansion of macro '__typecheck'
>    26 |   (__typecheck(x, y) && __no_side_effects(x, y))
>       |    ^~~~~~~~~~~
> include/linux/minmax.h:36:24: note: in expansion of macro '__safe_cmp'
>    36 |  __builtin_choose_expr(__safe_cmp(x, y), \
>       |                        ^~~~~~~~~~
> include/linux/minmax.h:45:19: note: in expansion of macro '__careful_cmp'
>    45 | #define min(x, y) __careful_cmp(x, y, <)
>       |                   ^~~~~~~~~~~~~
> fs/io_uring.c:7095:28: note: in expansion of macro 'min'
>  7095 |   unsigned int this_size = min(size, PAGE_SIZE);
>       |                            ^~~
> 
> Introduced by commit
> 
>   9123c8ffce16 ("io_uring: add helpers for 2 level table alloc")
> 

-- 
Pavel Begunkov

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

Hi all,

After merging the block tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/nvdimm/pmem.c: In function 'pmem_pagemap_cleanup':
drivers/nvdimm/pmem.c:338:24: warning: unused variable 'q' [-Wunused-variable]
  338 |  struct request_queue *q =
      |                        ^

Introduced by commit

  80b58f4e9f4a ("libnvdimm/pmem: Fix blk_cleanup_disk() usage")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Dan Williams]

On Tue, Jun 8, 2021 at 8:52 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the block tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/nvdimm/pmem.c: In function 'pmem_pagemap_cleanup':
> drivers/nvdimm/pmem.c:338:24: warning: unused variable 'q' [-Wunused-variable]
>   338 |  struct request_queue *q =
>       |                        ^
>

Ugh, I should have caught this... fix incoming.

> Introduced by commit
>
>   80b58f4e9f4a ("libnvdimm/pmem: Fix blk_cleanup_disk() usage")
>
> --
> Cheers,
> Stephen Rothwell

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

kernel/trace/blktrace.c:1878: warning: Function parameter or member 'rwbs' not described in 'blk_fill_rwbs'`

Introduced by commit

  1f83bb4b4914 ("blktrace: add blk_fill_rwbs documentation comment")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Chaitanya Kulkarni]

On 2/23/21 18:31, Stephen Rothwell wrote:
> Hi all,
>
> After merging the block tree, today's linux-next build (htmldocs)
> produced this warning:
>
> kernel/trace/blktrace.c:1878: warning: Function parameter or member 'rwbs' not described in 'blk_fill_rwbs'`
>
> Introduced by commit
>
>   1f83bb4b4914 ("blktrace: add blk_fill_rwbs documentation comment")
>
Thanks for reporting, I'll send a fix soon.

Re: linux-next: build warning after merge of the block tree

[Chaitanya Kulkarni]

Stephen,

On 2/23/21 18:31, Stephen Rothwell wrote:
> Hi all,
>
> After merging the block tree, today's linux-next build (htmldocs)
> produced this warning:
>
> kernel/trace/blktrace.c:1878: warning: Function parameter or member 'rwbs' not described in 'blk_fill_rwbs'`
>
> Introduced by commit
>
>   1f83bb4b4914 ("blktrace: add blk_fill_rwbs documentation comment")
>
> -- Cheers, Stephen Rothwell
I've failed to understand this warning as rwbs is present in the doc header
and in the function parameter :-

/**                                                                                                   

 * blk_fill_rwbs - Fill the buffer rwbs by mapping op to character string.
 * @rwbs        buffer to be filled
 * @op:         REQ_OP_XXX for the tracepoint
 *
 * Description:
 *     Maps the REQ_OP_XXX to character and fills the buffer provided by the
 *     caller with resulting string.
 *
 **/
void blk_fill_rwbs(char *rwbs, unsigned int op)
{
        int i = 0;

        if (op & REQ_PREFLUSH)
                rwbs[i++] = 'F';

        switch (op & REQ_OP_MASK) {
        case REQ_OP_WRITE:
        case REQ_OP_WRITE_SAME:
                rwbs[i++] = 'W';
                break;
        case REQ_OP_DISCARD:
                rwbs[i++] = 'D';
                break;
        case REQ_OP_SECURE_ERASE:
                rwbs[i++] = 'D';
                rwbs[i++] = 'E';
                break;
        case REQ_OP_FLUSH:
                rwbs[i++] = 'F';
                break;
        case REQ_OP_READ:
                rwbs[i++] = 'R';
                break;
        default:
                rwbs[i++] = 'N';
        }

        if (op & REQ_FUA)
                rwbs[i++] = 'F';
        if (op & REQ_RAHEAD)
                rwbs[i++] = 'A';
        if (op & REQ_SYNC)
                rwbs[i++] = 'S';
        if (op & REQ_META)
                rwbs[i++] = 'M';

        rwbs[i] = '\0';
}
EXPORT_SYMBOL_GPL(blk_fill_rwbs);

Re: linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

Hi Chaitanya,

On Wed, 24 Feb 2021 05:25:49 +0000 Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com> wrote:
>
> On 2/23/21 18:31, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the block tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > kernel/trace/blktrace.c:1878: warning: Function parameter or member 'rwbs' not described in 'blk_fill_rwbs'`
> >
> > Introduced by commit
> >
> >   1f83bb4b4914 ("blktrace: add blk_fill_rwbs documentation comment")
> >
> > -- Cheers, Stephen Rothwell  
> I've failed to understand this warning as rwbs is present in the doc header
> and in the function parameter :-

I presume it is the missing ':' after @rwbs in the comment.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Chaitanya Kulkarni]

On 2/23/21 21:33, Stephen Rothwell wrote:
>> I've failed to understand this warning as rwbs is present in the doc header
>> and in the function parameter :-
> I presume it is the missing ':' after @rwbs in the comment.
Thanks, I was looking at the wrong places all this time, will send a fix.

I'll setup doc generation using sphinx on my machine, is there
a particular command line that you have used for these warnings ?

Re: linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

Hi Chaitanya,

On Wed, 24 Feb 2021 05:38:06 +0000 Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com> wrote:
>
> On 2/23/21 21:33, Stephen Rothwell wrote:
> >> I've failed to understand this warning as rwbs is present in the doc header
> >> and in the function parameter :-  
> > I presume it is the missing ':' after @rwbs in the comment.  
> Thanks, I was looking at the wrong places all this time, will send a fix.
> 
> I'll setup doc generation using sphinx on my machine, is there
> a particular command line that you have used for these warnings ?

I just do a "make htmldocs"

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Chaitanya Kulkarni]

On 2/24/21 02:43, Stephen Rothwell wrote:
>> I'll setup doc generation using sphinx on my machine, is there
>> a particular command line that you have used for these warnings ?
> I just do a "make htmldocs"
I did that, please have a look at the test log.

Re: linux-next: build warning after merge of the block tree

[Randy Dunlap]

On 2/24/21 1:41 PM, Chaitanya Kulkarni wrote:
> On 2/24/21 02:43, Stephen Rothwell wrote:
>>> I'll setup doc generation using sphinx on my machine, is there
>>> a particular command line that you have used for these warnings ?
>> I just do a "make htmldocs"
> I did that, please have a look at the test log.
> 

Hi,

Where is the test log?

-- 
~Randy

Re: linux-next: build warning after merge of the block tree

[Chaitanya Kulkarni]

Randy,

On 2/24/21 13:45, Randy Dunlap wrote:
> On 2/24/21 1:41 PM, Chaitanya Kulkarni wrote:
>> On 2/24/21 02:43, Stephen Rothwell wrote:
>>>> I'll setup doc generation using sphinx on my machine, is there
>>>> a particular command line that you have used for these warnings ?
>>> I just do a "make htmldocs"
>> I did that, please have a look at the test log.
>>
> Hi,
>
> Where is the test log?
>

I sent out the following patch yesterday @ 23:16 PST with Stephen in CC
on linux-block :- https://marc.info/?l=linux-block&m=161415113122092&w=2

It has the test log.

Re: linux-next: build warning after merge of the block tree

[Chaitanya Kulkarni]

On 2/23/21 21:33, Stephen Rothwell wrote:
>>>   1f83bb4b4914 ("blktrace: add blk_fill_rwbs documentation comment")
>>>
>>> -- Cheers, Stephen Rothwell  
>> I've failed to understand this warning as rwbs is present in the doc header
>> and in the function parameter :-
> I presume it is the missing ':' after @rwbs in the comment.
I've sent a fix with your reported by, it will be great if you can provide
reviewed-by tag.
> -- Cheers, Stephen Rothwell

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

Hi all,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

fs/io_uring.c: In function 'io_uring_get_file':
fs/io_uring.c:9408:6: warning: unused variable 'ret' [-Wunused-variable]
 9408 |  int ret;
      |      ^~~

Introduced by commit

  efc2519f427b ("io_uring: fix double io_uring free")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 12/22/20 4:47 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> fs/io_uring.c: In function 'io_uring_get_file':
> fs/io_uring.c:9408:6: warning: unused variable 'ret' [-Wunused-variable]
>  9408 |  int ret;
>       |      ^~~
> 
> Introduced by commit
> 
>   efc2519f427b ("io_uring: fix double io_uring free")

I'll fix it up, doesn't show up in my build...

-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

kernel/trace/blktrace.c:1039: warning: Excess function parameter 'q' description in 'blk_add_trace_rq_remap'

Introduced by commit

  a54895fa057c ("block: remove the request_queue to argument request based tracepoints")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

fs/block_dev.c:1838: warning: Function parameter or member 'dev' not described in 'lookup_bdev'

Introduced by commit

  4e7b5671c6a8 ("block: remove i_bdev")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

Hi all,

On Thu, 3 Dec 2020 18:39:58 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the block tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> fs/block_dev.c:1838: warning: Function parameter or member 'dev' not described in 'lookup_bdev'
> 
> Introduced by commit
> 
>   4e7b5671c6a8 ("block: remove i_bdev")

I am still getting this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

Hi all,

On Tue, 15 Dec 2020 07:14:36 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> On Thu, 3 Dec 2020 18:39:58 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the block tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > fs/block_dev.c:1838: warning: Function parameter or member 'dev' not described in 'lookup_bdev'
> > 
> > Introduced by commit
> > 
> >   4e7b5671c6a8 ("block: remove i_bdev")  
> 
> I am still getting this warning.

I am now getting this warning from Linus' tree.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

fs/block_dev.c:1067: warning: Excess function parameter 'whole' description in 'bd_abort_claiming'

Introduced by commit

  37c3fc9abb25 ("block: simplify the block device claiming interface")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

Hi all,

On Thu, 3 Dec 2020 18:37:40 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the block tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> fs/block_dev.c:1067: warning: Excess function parameter 'whole' description in 'bd_abort_claiming'
> 
> Introduced by commit
> 
>   37c3fc9abb25 ("block: simplify the block device claiming interface")

I am still getting the above warning.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]

Hi all,

On Tue, 15 Dec 2020 07:13:40 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> On Thu, 3 Dec 2020 18:37:40 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the block tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > fs/block_dev.c:1067: warning: Excess function parameter 'whole' description in 'bd_abort_claiming'
> > 
> > Introduced by commit
> > 
> >   37c3fc9abb25 ("block: simplify the block device claiming interface")  
> 
> I am still getting the above warning.

I am now getting this warning from Linus' tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

block/genhd.c:439: warning: Function parameter or member 'probe' not described in '__register_blkdev'

Introduced by commit

  3da1a61e7046 ("block: add an optional probe callback to major_names")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

Hi all,

After merging the block tree, today's linux-next build (KCONFIG_NAME)
produced this warning:

fs/io_uring.c: In function 'loop_rw_iter':
fs/io_uring.c:3141:21: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 3141 |    iovec.iov_base = (void __user *) req->rw.addr;
      |                     ^

Introduced by commit

  a5371db1e38d ("io_uring: make loop_rw_iter() use original user supplied pointers")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 10/22/20 5:48 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (KCONFIG_NAME)
> produced this warning:
> 
> fs/io_uring.c: In function 'loop_rw_iter':
> fs/io_uring.c:3141:21: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>  3141 |    iovec.iov_base = (void __user *) req->rw.addr;
>       |                     ^
> 
> Introduced by commit
> 
>   a5371db1e38d ("io_uring: make loop_rw_iter() use original user supplied pointers")

Thanks, not sure why I didn't use u64_to_user_pointer() in the first
place - updated now.

-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

Hi all,

After merging the block tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/md/dm.c: In function '__map_bio':
drivers/md/dm.c:1296:24: warning: unused variable 'md' [-Wunused-variable]
 1296 |  struct mapped_device *md = io->md;
      |                        ^~

Introduced by commit

  5a6c35f9af41 ("block: remove direct_make_request")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 7/1/20 7:21 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/md/dm.c: In function '__map_bio':
> drivers/md/dm.c:1296:24: warning: unused variable 'md' [-Wunused-variable]
>  1296 |  struct mapped_device *md = io->md;
>       |                        ^~
> 
> Introduced by commit
> 
>   5a6c35f9af41 ("block: remove direct_make_request")

Thanks, I did fix this one up, just haven't pushed out the updated tree
yet.

-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

Hi all,

After merging the block tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/io_uring.c: In function 'io_close':
fs/io_uring.c:3415:3: warning: ignoring return value of 'refcount_inc_not_zero', declared with attribute warn_unused_result [-Wunused-result]
 3415 |   refcount_inc_not_zero(&req->refs);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  62e0c6b73a2c ("io_uring: make submission ref putting consistent")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 3/3/20 7:17 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/io_uring.c: In function 'io_close':
> fs/io_uring.c:3415:3: warning: ignoring return value of 'refcount_inc_not_zero', declared with attribute warn_unused_result [-Wunused-result]
>  3415 |   refcount_inc_not_zero(&req->refs);
>       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   62e0c6b73a2c ("io_uring: make submission ref putting consistent")

That should just be a refcount_inc() and also looks like it should happen
before the async queue. I'll fix it up.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the block tree

[Pavel Begunkov]

On 04/03/2020 06:01, Jens Axboe wrote:
> On 3/3/20 7:17 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the block tree, today's linux-next build (powerpc
>> ppc64_defconfig) produced this warning:
>>
>> fs/io_uring.c: In function 'io_close':
>> fs/io_uring.c:3415:3: warning: ignoring return value of 'refcount_inc_not_zero', declared with attribute warn_unused_result [-Wunused-result]
>>  3415 |   refcount_inc_not_zero(&req->refs);
>>       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Introduced by commit
>>
>>   62e0c6b73a2c ("io_uring: make submission ref putting consistent")
> 
> That should just be a refcount_inc() and also looks like it should happen
> before the async queue. I'll fix it up.

Yes, it's better to. Thanks!


-- 
Pavel Begunkov

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

Hi all,

After merging the block tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

fs/io_uring.c: In function '__io_uring_show_fdinfo':
fs/io_uring.c:6558:32: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
 6558 |   seq_printf(m, "%5u: 0x%llx/%lu\n", i, buf->ubuf, buf->len);
      |                              ~~^                   ~~~~~~~~
      |                                |                      |
      |                                long unsigned int      size_t {aka unsigned int}
      |                              %u

Introduced by commit

  0380f1b6d0c6 ("io_uring: add ->show_fdinfo() for the io_uring file descriptor")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 1/30/20 5:16 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> fs/io_uring.c: In function '__io_uring_show_fdinfo':
> fs/io_uring.c:6558:32: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
>  6558 |   seq_printf(m, "%5u: 0x%llx/%lu\n", i, buf->ubuf, buf->len);
>       |                              ~~^                   ~~~~~~~~
>       |                                |                      |
>       |                                long unsigned int      size_t {aka unsigned int}
>       |                              %u
> 
> Introduced by commit
> 
>   0380f1b6d0c6 ("io_uring: add ->show_fdinfo() for the io_uring file descriptor")

Thanks, did fix that up, forgot to push to for-next... Will rectify that now.

-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi all,

After merging the block tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

fs/io_uring.c: In function '__io_sqe_files_update':
fs/io_uring.c:5567:8: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 5567 |  fds = (__s32 __user *) up->fds;
      |        ^

Introduced by commit

  813668c6099b ("io_uring: avoid ring quiesce for fixed file set unregister and update")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 1/15/20 5:54 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> fs/io_uring.c: In function '__io_sqe_files_update':
> fs/io_uring.c:5567:8: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>  5567 |  fds = (__s32 __user *) up->fds;
>       |        ^
> 
> Introduced by commit
> 
>   813668c6099b ("io_uring: avoid ring quiesce for fixed file set unregister and update")

Fixed up, thanks.

-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 688 bytes --]

Hi all,

After merging the block tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

fs/io_uring.c: In function 'io_accept':
fs/io_uring.c:1729:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 1729 |  addr = (struct sockaddr __user *) READ_ONCE(sqe->addr);
      |         ^
fs/io_uring.c:1730:13: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
 1730 |  addr_len = (int __user *) READ_ONCE(sqe->addr2);
      |             ^

Introduced by commit

  d674c2b9335f ("io_uring: add support for IORING_OP_ACCEPT")

addr and addr2 are __u64 ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 10/17/19 6:51 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> fs/io_uring.c: In function 'io_accept':
> fs/io_uring.c:1729:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   1729 |  addr = (struct sockaddr __user *) READ_ONCE(sqe->addr);
>        |         ^
> fs/io_uring.c:1730:13: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   1730 |  addr_len = (int __user *) READ_ONCE(sqe->addr2);
>        |             ^
> 
> Introduced by commit
> 
>    d674c2b9335f ("io_uring: add support for IORING_OP_ACCEPT")
> 
> addr and addr2 are __u64 ...

I'll fix these warnings up, guessing it's 32-bit?

-- 
Jens Axboe

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 10/17/19 6:56 PM, Jens Axboe wrote:
> On 10/17/19 6:51 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the block tree, today's linux-next build (arm
>> multi_v7_defconfig) produced this warning:
>>
>> fs/io_uring.c: In function 'io_accept':
>> fs/io_uring.c:1729:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>    1729 |  addr = (struct sockaddr __user *) READ_ONCE(sqe->addr);
>>         |         ^
>> fs/io_uring.c:1730:13: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>    1730 |  addr_len = (int __user *) READ_ONCE(sqe->addr2);
>>         |             ^
>>
>> Introduced by commit
>>
>>     d674c2b9335f ("io_uring: add support for IORING_OP_ACCEPT")
>>
>> addr and addr2 are __u64 ...
> 
> I'll fix these warnings up, guessing it's 32-bit?

Should be fixed up and pushed out now.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

Hi Jens,

On Thu, 17 Oct 2019 18:56:39 -0600 Jens Axboe <axboe@kernel.dk> wrote:
>
> I'll fix these warnings up, guessing it's 32-bit?

Thanks.  Yeah 32 bit.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2896 bytes --]

Hi all,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/trace/events/iocost.h:8,
                 from <command-line>:
include/trace/events/iocost.h:12:57: warning: 'struct ioc_now' declared inside parameter list will not be visible outside of this definition or declaration
  TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
                                                         ^~~~~~~
include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
  static inline void trace_##name(proto)    \
                                  ^~~~~
include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
  __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
                        ^~~~~~
include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
  ^~~~~~~~~~~~~
include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
                      ^~~~~~
include/trace/events/iocost.h:10:1: note: in expansion of macro 'TRACE_EVENT'
 TRACE_EVENT(iocost_iocg_activate,
 ^~~~~~~~~~~
include/trace/events/iocost.h:12:2: note: in expansion of macro 'TP_PROTO'
  TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
  ^~~~~~~~
include/trace/events/iocost.h:12:18: warning: 'struct ioc_gq' declared inside parameter list will not be visible outside of this definition or declaration
  TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
                  ^~~~~~
include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
  static inline void trace_##name(proto)    \
                                  ^~~~~
include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
  __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
                        ^~~~~~
include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
  ^~~~~~~~~~~~~
include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
                      ^~~~~~
include/trace/events/iocost.h:10:1: note: in expansion of macro 'TRACE_EVENT'
 TRACE_EVENT(iocost_iocg_activate,
 ^~~~~~~~~~~
include/trace/events/iocost.h:12:2: note: in expansion of macro 'TP_PROTO'
  TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
  ^~~~~~~~

(and many more)

Introduced by commit

  7caa47151ab2 ("blkcg: implement blk-iocost")

To get these warnings you need to build with CONFIG_HEADER_TEST and
CONFIG_KERNEL_HEADER_TEST (and maybe CONFIG_UAPI_HEADER_TEST).
allmodconfig does that.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 3873 bytes --]

Hi all,

On Thu, 29 Aug 2019 13:51:50 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> In file included from include/trace/events/iocost.h:8,
>                  from <command-line>:
> include/trace/events/iocost.h:12:57: warning: 'struct ioc_now' declared inside parameter list will not be visible outside of this definition or declaration
>   TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
>                                                          ^~~~~~~
> include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
>   static inline void trace_##name(proto)    \
>                                   ^~~~~
> include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
>   __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
>                         ^~~~~~
> include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
>   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
>   ^~~~~~~~~~~~~
> include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
>   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
>                       ^~~~~~
> include/trace/events/iocost.h:10:1: note: in expansion of macro 'TRACE_EVENT'
>  TRACE_EVENT(iocost_iocg_activate,
>  ^~~~~~~~~~~
> include/trace/events/iocost.h:12:2: note: in expansion of macro 'TP_PROTO'
>   TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
>   ^~~~~~~~
> include/trace/events/iocost.h:12:18: warning: 'struct ioc_gq' declared inside parameter list will not be visible outside of this definition or declaration
>   TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
>                   ^~~~~~
> include/linux/tracepoint.h:233:34: note: in definition of macro '__DECLARE_TRACE'
>   static inline void trace_##name(proto)    \
>                                   ^~~~~
> include/linux/tracepoint.h:396:24: note: in expansion of macro 'PARAMS'
>   __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
>                         ^~~~~~
> include/linux/tracepoint.h:532:2: note: in expansion of macro 'DECLARE_TRACE'
>   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
>   ^~~~~~~~~~~~~
> include/linux/tracepoint.h:532:22: note: in expansion of macro 'PARAMS'
>   DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
>                       ^~~~~~
> include/trace/events/iocost.h:10:1: note: in expansion of macro 'TRACE_EVENT'
>  TRACE_EVENT(iocost_iocg_activate,
>  ^~~~~~~~~~~
> include/trace/events/iocost.h:12:2: note: in expansion of macro 'TP_PROTO'
>   TP_PROTO(struct ioc_gq *iocg, const char *path, struct ioc_now *now,
>   ^~~~~~~~
> 
> (and many more)
> 
> Introduced by commit
> 
>   7caa47151ab2 ("blkcg: implement blk-iocost")
> 
> To get these warnings you need to build with CONFIG_HEADER_TEST and
> CONFIG_KERNEL_HEADER_TEST (and maybe CONFIG_UAPI_HEADER_TEST).
> allmodconfig does that.

I have applied this patch to linux-next for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 29 Aug 2019 14:03:43 +1000
Subject: [PATCH] blkcg: blk-iocost: predeclare used structs

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/trace/events/iocost.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
index ec2217dd57ac..7ecaa65b7106 100644
--- a/include/trace/events/iocost.h
+++ b/include/trace/events/iocost.h
@@ -2,6 +2,10 @@
 #undef TRACE_SYSTEM
 #define TRACE_SYSTEM iocost
 
+struct ioc;
+struct ioc_now;
+struct ioc_gq;
+
 #if !defined(_TRACE_BLK_IOCOST_H) || defined(TRACE_HEADER_MULTI_READ)
 #define _TRACE_BLK_IOCOST_H
 
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Tejun Heo]

On Thu, Aug 29, 2019 at 02:08:28PM +1000, Stephen Rothwell wrote:
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 29 Aug 2019 14:03:43 +1000
> Subject: [PATCH] blkcg: blk-iocost: predeclare used structs
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

> ---
>  include/trace/events/iocost.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
> index ec2217dd57ac..7ecaa65b7106 100644
> --- a/include/trace/events/iocost.h
> +++ b/include/trace/events/iocost.h
> @@ -2,6 +2,10 @@
>  #undef TRACE_SYSTEM
>  #define TRACE_SYSTEM iocost
>  
> +struct ioc;
> +struct ioc_now;
> +struct ioc_gq;
> +
>  #if !defined(_TRACE_BLK_IOCOST_H) || defined(TRACE_HEADER_MULTI_READ)
>  #define _TRACE_BLK_IOCOST_H

-- 
tejun

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 8/29/19 9:41 AM, Tejun Heo wrote:
> On Thu, Aug 29, 2019 at 02:08:28PM +1000, Stephen Rothwell wrote:
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Date: Thu, 29 Aug 2019 14:03:43 +1000
>> Subject: [PATCH] blkcg: blk-iocost: predeclare used structs
>>
>> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> 
> Acked-by: Tejun Heo <tj@kernel.org>
> 
> Thanks.
> 
>> ---
>>   include/trace/events/iocost.h | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
>> index ec2217dd57ac..7ecaa65b7106 100644
>> --- a/include/trace/events/iocost.h
>> +++ b/include/trace/events/iocost.h
>> @@ -2,6 +2,10 @@
>>   #undef TRACE_SYSTEM
>>   #define TRACE_SYSTEM iocost
>>   
>> +struct ioc;
>> +struct ioc_now;
>> +struct ioc_gq;
>> +
>>   #if !defined(_TRACE_BLK_IOCOST_H) || defined(TRACE_HEADER_MULTI_READ)
>>   #define _TRACE_BLK_IOCOST_H

Added, thanks.

-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

Hi all,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/lightnvm/pblk-read.c: In function 'pblk_submit_read_gc':
drivers/lightnvm/pblk-read.c:421:18: warning: unused variable 'geo' [-Wunused-variable]
  struct nvm_geo *geo = &dev->geo;
                  ^~~

Introduced by commit

  ba6f7da99aaf ("lightnvm: remove set but not used variables 'data_len' and 'rq_len'")

Removing the above line will also remove the last use of the variable
"dev" ...
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 8/8/19 9:00 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/lightnvm/pblk-read.c: In function 'pblk_submit_read_gc':
> drivers/lightnvm/pblk-read.c:421:18: warning: unused variable 'geo' [-Wunused-variable]
>    struct nvm_geo *geo = &dev->geo;
>                    ^~~
> 
> Introduced by commit
> 
>    ba6f7da99aaf ("lightnvm: remove set but not used variables 'data_len' and 'rq_len'")
> 
> Removing the above line will also remove the last use of the variable
> "dev" ...

Thanks, will fix it up.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the block tree

[Yuehaibing]

On 2019/8/9 12:00, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/lightnvm/pblk-read.c: In function 'pblk_submit_read_gc':
> drivers/lightnvm/pblk-read.c:421:18: warning: unused variable 'geo' [-Wunused-variable]
>   struct nvm_geo *geo = &dev->geo;
>                   ^~~
> 
> Introduced by commit
> 
>   ba6f7da99aaf ("lightnvm: remove set but not used variables 'data_len' and 'rq_len'")
> 
> Removing the above line will also remove the last use of the variable
> "dev" ...

Oh, my bad, thanks!

> 

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 798 bytes --]

Hi all,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

fs/f2fs/node.c: In function 'f2fs_remove_inode_page':
fs/f2fs/node.c:1193:47: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'blkcnt_t' {aka 'long long unsigned int'} [-Wformat=]
    "Inconsistent i_blocks, ino:%lu, iblocks:%zu",
                                             ~~^
                                             %llu
    inode->i_ino, inode->i_blocks);
                  ~~~~~~~~~~~~~~~               

Introduced by commit

  90ae238d9dac ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")

from the f2fs tree interacting with commit

  72deb455b5ec ("block: remove CONFIG_LBDAF")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Chao Yu]

Hi Jaegeuk,

On 2019/4/17 10:31, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> fs/f2fs/node.c: In function 'f2fs_remove_inode_page':
> fs/f2fs/node.c:1193:47: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'blkcnt_t' {aka 'long long unsigned int'} [-Wformat=]
>     "Inconsistent i_blocks, ino:%lu, iblocks:%zu",
>                                              ~~^
>                                              %llu
>     inode->i_ino, inode->i_blocks);
>                   ~~~~~~~~~~~~~~~       

Could you please help to fix that as below in your dev branch directly?

"Inconsistent i_blocks, ino:%lu, iblocks:%llu",
inode->i_ino, (unsigned long long)inode->i_blocks)


It looks that we need to fix below commits as well:

f2fs: fix to avoid panic in dec_valid_block_count()
f2fs: fix to avoid panic in dec_valid_node_count()

Thanks,

> 
> Introduced by commit
> 
>   90ae238d9dac ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")
> 
> from the f2fs tree interacting with commit
> 
>   72deb455b5ec ("block: remove CONFIG_LBDAF")
> 

Re: linux-next: build warning after merge of the block tree

[Jaegeuk Kim]

On 04/17, Chao Yu wrote:
> Hi Jaegeuk,
> 
> On 2019/4/17 10:31, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the block tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > fs/f2fs/node.c: In function 'f2fs_remove_inode_page':
> > fs/f2fs/node.c:1193:47: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'blkcnt_t' {aka 'long long unsigned int'} [-Wformat=]
> >     "Inconsistent i_blocks, ino:%lu, iblocks:%zu",
> >                                              ~~^
> >                                              %llu
> >     inode->i_ino, inode->i_blocks);
> >                   ~~~~~~~~~~~~~~~       
> 
> Could you please help to fix that as below in your dev branch directly?
> 
> "Inconsistent i_blocks, ino:%lu, iblocks:%llu",

We can just use "%lu"?

> inode->i_ino, (unsigned long long)inode->i_blocks)
> 
> 
> It looks that we need to fix below commits as well:
> 
> f2fs: fix to avoid panic in dec_valid_block_count()
> f2fs: fix to avoid panic in dec_valid_node_count()
> 
> Thanks,
> 
> > 
> > Introduced by commit
> > 
> >   90ae238d9dac ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")
> > 
> > from the f2fs tree interacting with commit
> > 
> >   72deb455b5ec ("block: remove CONFIG_LBDAF")
> > 

Re: linux-next: build warning after merge of the block tree

[Chao Yu]

On 2019/4/17 22:03, Jaegeuk Kim wrote:
> On 04/17, Chao Yu wrote:
>> Hi Jaegeuk,
>>
>> On 2019/4/17 10:31, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the block tree, today's linux-next build (x86_64
>>> allmodconfig) produced this warning:
>>>
>>> fs/f2fs/node.c: In function 'f2fs_remove_inode_page':
>>> fs/f2fs/node.c:1193:47: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'blkcnt_t' {aka 'long long unsigned int'} [-Wformat=]
>>>     "Inconsistent i_blocks, ino:%lu, iblocks:%zu",
>>>                                              ~~^
>>>                                              %llu
>>>     inode->i_ino, inode->i_blocks);
>>>                   ~~~~~~~~~~~~~~~       
>>
>> Could you please help to fix that as below in your dev branch directly?
>>
>> "Inconsistent i_blocks, ino:%lu, iblocks:%llu",
> 
> We can just use "%lu"?

We'd better follow sample in Documentation/core-api/printk-formats.rst:

If <type> is dependent on a config option for its size (e.g., sector_t,
blkcnt_t) or is architecture-dependent for its size (e.g., tcflag_t), use a
format specifier of its largest possible type and explicitly cast to it.

Example::

        printk("test: sector number/total blocks: %llu/%llu\n",
                (unsigned long long)sector, (unsigned long long)blockcount);

Thanks,

> 
>> inode->i_ino, (unsigned long long)inode->i_blocks)
>>
>>
>> It looks that we need to fix below commits as well:
>>
>> f2fs: fix to avoid panic in dec_valid_block_count()
>> f2fs: fix to avoid panic in dec_valid_node_count()
>>
>> Thanks,
>>
>>>
>>> Introduced by commit
>>>
>>>   90ae238d9dac ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")
>>>
>>> from the f2fs tree interacting with commit
>>>
>>>   72deb455b5ec ("block: remove CONFIG_LBDAF")
>>>
> .
> 

Re: linux-next: build warning after merge of the block tree

[Jaegeuk Kim]

On 04/18, Chao Yu wrote:
> On 2019/4/17 22:03, Jaegeuk Kim wrote:
> > On 04/17, Chao Yu wrote:
> >> Hi Jaegeuk,
> >>
> >> On 2019/4/17 10:31, Stephen Rothwell wrote:
> >>> Hi all,
> >>>
> >>> After merging the block tree, today's linux-next build (x86_64
> >>> allmodconfig) produced this warning:
> >>>
> >>> fs/f2fs/node.c: In function 'f2fs_remove_inode_page':
> >>> fs/f2fs/node.c:1193:47: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'blkcnt_t' {aka 'long long unsigned int'} [-Wformat=]
> >>>     "Inconsistent i_blocks, ino:%lu, iblocks:%zu",
> >>>                                              ~~^
> >>>                                              %llu
> >>>     inode->i_ino, inode->i_blocks);
> >>>                   ~~~~~~~~~~~~~~~       
> >>
> >> Could you please help to fix that as below in your dev branch directly?
> >>
> >> "Inconsistent i_blocks, ino:%lu, iblocks:%llu",
> > 
> > We can just use "%lu"?
> 
> We'd better follow sample in Documentation/core-api/printk-formats.rst:
> 
> If <type> is dependent on a config option for its size (e.g., sector_t,
> blkcnt_t) or is architecture-dependent for its size (e.g., tcflag_t), use a
> format specifier of its largest possible type and explicitly cast to it.

Great, done. :)

Thanks,

> 
> Example::
> 
>         printk("test: sector number/total blocks: %llu/%llu\n",
>                 (unsigned long long)sector, (unsigned long long)blockcount);
> 
> Thanks,
> 
> > 
> >> inode->i_ino, (unsigned long long)inode->i_blocks)
> >>
> >>
> >> It looks that we need to fix below commits as well:
> >>
> >> f2fs: fix to avoid panic in dec_valid_block_count()
> >> f2fs: fix to avoid panic in dec_valid_node_count()
> >>
> >> Thanks,
> >>
> >>>
> >>> Introduced by commit
> >>>
> >>>   90ae238d9dac ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")
> >>>
> >>> from the f2fs tree interacting with commit
> >>>
> >>>   72deb455b5ec ("block: remove CONFIG_LBDAF")
> >>>
> > .
> > 

Re: linux-next: build warning after merge of the block tree

[Chao Yu]

On 2019/4/18 22:01, Jaegeuk Kim wrote:
> On 04/18, Chao Yu wrote:
>> On 2019/4/17 22:03, Jaegeuk Kim wrote:
>>> On 04/17, Chao Yu wrote:
>>>> Hi Jaegeuk,
>>>>
>>>> On 2019/4/17 10:31, Stephen Rothwell wrote:
>>>>> Hi all,
>>>>>
>>>>> After merging the block tree, today's linux-next build (x86_64
>>>>> allmodconfig) produced this warning:
>>>>>
>>>>> fs/f2fs/node.c: In function 'f2fs_remove_inode_page':
>>>>> fs/f2fs/node.c:1193:47: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'blkcnt_t' {aka 'long long unsigned int'} [-Wformat=]
>>>>>     "Inconsistent i_blocks, ino:%lu, iblocks:%zu",
>>>>>                                              ~~^
>>>>>                                              %llu
>>>>>     inode->i_ino, inode->i_blocks);
>>>>>                   ~~~~~~~~~~~~~~~       
>>>>
>>>> Could you please help to fix that as below in your dev branch directly?
>>>>
>>>> "Inconsistent i_blocks, ino:%lu, iblocks:%llu",
>>>
>>> We can just use "%lu"?
>>
>> We'd better follow sample in Documentation/core-api/printk-formats.rst:
>>
>> If <type> is dependent on a config option for its size (e.g., sector_t,
>> blkcnt_t) or is architecture-dependent for its size (e.g., tcflag_t), use a
>> format specifier of its largest possible type and explicitly cast to it.
> 
> Great, done. :)

Thanks, :)

> 
> Thanks,
> 
>>
>> Example::
>>
>>         printk("test: sector number/total blocks: %llu/%llu\n",
>>                 (unsigned long long)sector, (unsigned long long)blockcount);
>>
>> Thanks,
>>
>>>
>>>> inode->i_ino, (unsigned long long)inode->i_blocks)
>>>>
>>>>
>>>> It looks that we need to fix below commits as well:
>>>>
>>>> f2fs: fix to avoid panic in dec_valid_block_count()
>>>> f2fs: fix to avoid panic in dec_valid_node_count()
>>>>
>>>> Thanks,
>>>>
>>>>>
>>>>> Introduced by commit
>>>>>
>>>>>   90ae238d9dac ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")
>>>>>
>>>>> from the f2fs tree interacting with commit
>>>>>
>>>>>   72deb455b5ec ("block: remove CONFIG_LBDAF")
>>>>>
>>> .
>>>
> .
> 

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

block/kyber-iosched.c:84:22: warning: integer overflow in expression of type 'long int' results in '705032704' [-Woverflow]
  [KYBER_DISCARD] = 5 * NSEC_PER_SEC,
                      ^

Introduced by commit

  6e25cb01ea20 ("kyber: implement improved heuristics")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Omar Sandoval]

On Fri, Sep 28, 2018 at 11:11:24AM +1000, Stephen Rothwell wrote:
> Hi Jens,
> 
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> block/kyber-iosched.c:84:22: warning: integer overflow in expression of type 'long int' results in '705032704' [-Woverflow]
>   [KYBER_DISCARD] = 5 * NSEC_PER_SEC,
>                       ^
> 
> Introduced by commit
> 
>   6e25cb01ea20 ("kyber: implement improved heuristics")

Ugh, thanks for the report. This should fix it:

diff --git a/block/kyber-iosched.c b/block/kyber-iosched.c
index 2b62e362fb36..eccac01a10b6 100644
--- a/block/kyber-iosched.c
+++ b/block/kyber-iosched.c
@@ -79,9 +79,9 @@ static const unsigned int kyber_depth[] = {
  * Default latency targets for each scheduling domain.
  */
 static const u64 kyber_latency_targets[] = {
-	[KYBER_READ] = 2 * NSEC_PER_MSEC,
-	[KYBER_WRITE] = 10 * NSEC_PER_MSEC,
-	[KYBER_DISCARD] = 5 * NSEC_PER_SEC,
+	[KYBER_READ] = 2ULL * NSEC_PER_MSEC,
+	[KYBER_WRITE] = 10ULL * NSEC_PER_MSEC,
+	[KYBER_DISCARD] = 5ULL * NSEC_PER_SEC,
 };
 
 /*

Jens, do you mind folding that in, or should I send it separately?

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 9/28/18 12:43 AM, Omar Sandoval wrote:
> On Fri, Sep 28, 2018 at 11:11:24AM +1000, Stephen Rothwell wrote:
>> Hi Jens,
>>
>> After merging the block tree, today's linux-next build (arm
>> multi_v7_defconfig) produced this warning:
>>
>> block/kyber-iosched.c:84:22: warning: integer overflow in expression of type 'long int' results in '705032704' [-Woverflow]
>>   [KYBER_DISCARD] = 5 * NSEC_PER_SEC,
>>                       ^
>>
>> Introduced by commit
>>
>>   6e25cb01ea20 ("kyber: implement improved heuristics")
> 
> Ugh, thanks for the report. This should fix it:
> 
> diff --git a/block/kyber-iosched.c b/block/kyber-iosched.c
> index 2b62e362fb36..eccac01a10b6 100644
> --- a/block/kyber-iosched.c
> +++ b/block/kyber-iosched.c
> @@ -79,9 +79,9 @@ static const unsigned int kyber_depth[] = {
>   * Default latency targets for each scheduling domain.
>   */
>  static const u64 kyber_latency_targets[] = {
> -	[KYBER_READ] = 2 * NSEC_PER_MSEC,
> -	[KYBER_WRITE] = 10 * NSEC_PER_MSEC,
> -	[KYBER_DISCARD] = 5 * NSEC_PER_SEC,
> +	[KYBER_READ] = 2ULL * NSEC_PER_MSEC,
> +	[KYBER_WRITE] = 10ULL * NSEC_PER_MSEC,
> +	[KYBER_DISCARD] = 5ULL * NSEC_PER_SEC,
>  };
>  
>  /*
> 
> Jens, do you mind folding that in, or should I send it separately?

It's already applied, so please send it in separately. We only
really need it for the last one, NSEC_PER_SEC, but I agree let's do
all just in case it's changed later.

-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/md/md.c: In function 'mddev_put':
drivers/md/md.c:543:1: warning: the frame size of 2080 bytes is larger than 2048 bytes [-Wframe-larger-than=]
 }
 ^

This is caused because CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL is now
switched on.  Hopefully Kees (cc'd) can procide some guidance on how to
eliminate this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

Hi all,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/memstick/core/mspro_block.c: In function 'mspro_block_init_disk':
drivers/memstick/core/mspro_block.c:1173:24: warning: unused variable 'host' [-Wunused-variable]
  struct memstick_host *host = card->host;
                        ^~~~
drivers/memstick/core/ms_block.c: In function 'msb_init_disk':
drivers/memstick/core/ms_block.c:2097:24: warning: unused variable 'host' [-Wunused-variable]
  struct memstick_host *host = card->host;
                        ^~~~

Introduced by commit

  7c2d748e8476 ("memstick: don't call blk_queue_bounce_limit")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the block tree

[Christoph Hellwig]

On Mon, May 14, 2018 at 12:51:39PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:

The look entirely correct, but oddly enough my compiler did not bother
to warn.

Fix below:

--
>From 6610bd5bbbf05fa1d925b0601a09e84cada9e0a2 Mon Sep 17 00:00:00 2001
From: Christoph Hellwig <hch@lst.de>
Date: Mon, 14 May 2018 10:24:34 +0200
Subject: memstick: remove unused variables

Fixes: 7c2d748e8476 ("memstick: don't call blk_queue_bounce_limit")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/memstick/core/ms_block.c    | 1 -
 drivers/memstick/core/mspro_block.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c
index b2d025f42d14..a15181fa45f7 100644
--- a/drivers/memstick/core/ms_block.c
+++ b/drivers/memstick/core/ms_block.c
@@ -2094,7 +2094,6 @@ static const struct block_device_operations msb_bdops = {
 static int msb_init_disk(struct memstick_dev *card)
 {
 	struct msb_data *msb = memstick_get_drvdata(card);
-	struct memstick_host *host = card->host;
 	int rc;
 	unsigned long capacity;
 
diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
index a2fadc605750..5ee932631fae 100644
--- a/drivers/memstick/core/mspro_block.c
+++ b/drivers/memstick/core/mspro_block.c
@@ -1170,7 +1170,6 @@ static int mspro_block_init_card(struct memstick_dev *card)
 static int mspro_block_init_disk(struct memstick_dev *card)
 {
 	struct mspro_block_data *msb = memstick_get_drvdata(card);
-	struct memstick_host *host = card->host;
 	struct mspro_devinfo *dev_info = NULL;
 	struct mspro_sys_info *sys_info = NULL;
 	struct mspro_sys_attr *s_attr = NULL;
-- 
2.17.0

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 5/14/18 2:29 AM, Christoph Hellwig wrote:
> On Mon, May 14, 2018 at 12:51:39PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the block tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
> 
> The look entirely correct, but oddly enough my compiler did not bother
> to warn.

Applied, thanks.

-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

Hi Jens,

After merging the block tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

block/elevator.c: In function 'elv_iosched_store':
block/elevator.c:1102:2: warning: ignoring return value of 'strstrip', declared with attribute warn_unused_result [-Wunused-result]
  strstrip(elevator_name);
  ^

Introduced by commit

  d0f6e2da5871 ("block: Remove leading whitespace and trailing newline in elevator switch error message")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the block tree

[Markus Trippelsdorf]

On 2017.05.10 at 11:24 +1000, Stephen Rothwell wrote:
> Hi Jens,
> 
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> block/elevator.c: In function 'elv_iosched_store':
> block/elevator.c:1102:2: warning: ignoring return value of 'strstrip', declared with attribute warn_unused_result [-Wunused-result]
>   strstrip(elevator_name);
>   ^
> 
> Introduced by commit
> 
>   d0f6e2da5871 ("block: Remove leading whitespace and trailing newline in elevator switch error message")

Yes, it was missing a (void) like "(void)strlcpy(...)". But Jens
unfortunately removed both warnings, so the following patch should now
be enough:

diff --git a/block/elevator.c b/block/elevator.c
index fda6be933130..dd0ed19e4fb7 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -1099,8 +1099,7 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
 		return count;
 
 	strlcpy(elevator_name, skip_spaces(name), sizeof(elevator_name));
-	strstrip(elevator_name);
-	ret = __elevator_change(q, elevator_name);
+	ret = __elevator_change(q, strstrip(elevator_name));
 	if (!ret)
 		return count;
 
-- 
Markus

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 05/09/2017 08:20 PM, Markus Trippelsdorf wrote:
> On 2017.05.10 at 11:24 +1000, Stephen Rothwell wrote:
>> Hi Jens,
>>
>> After merging the block tree, today's linux-next build (arm
>> multi_v7_defconfig) produced this warning:
>>
>> block/elevator.c: In function 'elv_iosched_store':
>> block/elevator.c:1102:2: warning: ignoring return value of 'strstrip', declared with attribute warn_unused_result [-Wunused-result]
>>   strstrip(elevator_name);
>>   ^
>>
>> Introduced by commit
>>
>>   d0f6e2da5871 ("block: Remove leading whitespace and trailing newline in elevator switch error message")
> 
> Yes, it was missing a (void) like "(void)strlcpy(...)". But Jens
> unfortunately removed both warnings, so the following patch should now
> be enough:
> 
> diff --git a/block/elevator.c b/block/elevator.c
> index fda6be933130..dd0ed19e4fb7 100644
> --- a/block/elevator.c
> +++ b/block/elevator.c
> @@ -1099,8 +1099,7 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
>  		return count;
>  
>  	strlcpy(elevator_name, skip_spaces(name), sizeof(elevator_name));
> -	strstrip(elevator_name);
> -	ret = __elevator_change(q, elevator_name);
> +	ret = __elevator_change(q, strstrip(elevator_name));
>  	if (!ret)
>  		return count;

Care to send that as a proper patch? I don't see that warning here, fwiw.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the block tree

[Markus Trippelsdorf]

On 2017.05.09 at 21:00 -0600, Jens Axboe wrote:
> On 05/09/2017 08:20 PM, Markus Trippelsdorf wrote:
> > On 2017.05.10 at 11:24 +1000, Stephen Rothwell wrote:
> >> Hi Jens,
> >>
> >> After merging the block tree, today's linux-next build (arm
> >> multi_v7_defconfig) produced this warning:
> >>
> >> block/elevator.c: In function 'elv_iosched_store':
> >> block/elevator.c:1102:2: warning: ignoring return value of 'strstrip', declared with attribute warn_unused_result [-Wunused-result]
> >>   strstrip(elevator_name);
> >>   ^
> >>
> >> Introduced by commit
> >>
> >>   d0f6e2da5871 ("block: Remove leading whitespace and trailing newline in elevator switch error message")
> > 
> > Yes, it was missing a (void) like "(void)strlcpy(...)". But Jens
> > unfortunately removed both warnings, so the following patch should now
> > be enough:
> > 
> > diff --git a/block/elevator.c b/block/elevator.c
> > index fda6be933130..dd0ed19e4fb7 100644
> > --- a/block/elevator.c
> > +++ b/block/elevator.c
> > @@ -1099,8 +1099,7 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
> >  		return count;
> >  
> >  	strlcpy(elevator_name, skip_spaces(name), sizeof(elevator_name));
> > -	strstrip(elevator_name);
> > -	ret = __elevator_change(q, elevator_name);
> > +	ret = __elevator_change(q, strstrip(elevator_name));
> >  	if (!ret)
> >  		return count;
> 
> Care to send that as a proper patch? I don't see that warning here, fwiw.

I don't see it either. But no, I don't want to send a proper patch.
Please just drop my original patch (d0f6e2da5871), because its only
reason was to improve the two debug printks that you have removed later.

-- 
Markus

Re: linux-next: build warning after merge of the block tree

[Stephen Rothwell]

Hi Markus,

On Wed, 10 May 2017 04:20:54 +0200 Markus Trippelsdorf <markus@trippelsdorf.de> wrote:
>
> Yes, it was missing a (void) like "(void)strlcpy(...)". But Jens
> unfortunately removed both warnings, so the following patch should now
> be enough:
> 
> diff --git a/block/elevator.c b/block/elevator.c
> index fda6be933130..dd0ed19e4fb7 100644
> --- a/block/elevator.c
> +++ b/block/elevator.c
> @@ -1099,8 +1099,7 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
>  		return count;
>  
>  	strlcpy(elevator_name, skip_spaces(name), sizeof(elevator_name));
> -	strstrip(elevator_name);
> -	ret = __elevator_change(q, elevator_name);
> +	ret = __elevator_change(q, strstrip(elevator_name));
>  	if (!ret)
>  		return count;

I think you (or someone) needs to do a proper patch submission to Jens,
please.
-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

block/scsi_ioctl.c: In function 'sg_scsi_ioctl':
block/scsi_ioctl.c:520:1: warning: label 'out' defined but not used [-Wunused-label]
 out:
 ^

Introduced by commit 374f8fdea4aa ("scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 2014-10-22 19:28, Stephen Rothwell wrote:
> Hi Jens,
>
> After merging the block tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> block/scsi_ioctl.c: In function 'sg_scsi_ioctl':
> block/scsi_ioctl.c:520:1: warning: label 'out' defined but not used [-Wunused-label]
>   out:
>   ^

Fixed up, thanks.


-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/kernel.h:13:0,
                 from drivers/block/skd_main.c:19:
drivers/block/skd_main.c: In function 'skd_cons_skmsg':
drivers/block/skd_main.c:4562:33: warning: format '%u' expects argument of type 'unsigned int', but argument 5 has type 'long unsigned int' [-Wformat=]
   (unsigned long) sizeof(struct skd_fitmsg_context) *
                                 ^
include/linux/printk.h:216:33: note: in definition of macro 'pr_err'
  printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
                                 ^
drivers/block/skd_main.c:4559:2: note: in expansion of macro 'VPRINTK'
  VPRINTK(skdev, "skmsg_table kzalloc, struct %u, count %u total %lu\n",
  ^

and several more.

Introduced by commit 0e2c4a3a6c0c ("drivers/block/skd_main.c: fix a few
things, disable on 32-bit"). sizeof() needs %zu to print, right?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

fs/partitions/check.c: In function 'part_discard_alignment_show':
fs/partitions/check.c:263: warning: format '%u' expects type 'unsigned int', but argument 3 has type 'long long unsigned int'

Introduced by commit  ("block: Remove extra discard_alignment from
hd_struct")
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the block tree

[Tao Ma]

Hi Jens,

Sorry for the trouble. Here is the fix.

>From 60bf0c0972c0d0d237e30e1f1c79356f4aefa138 Mon Sep 17 00:00:00 2001
From: Tao Ma <boyu.mt@taobao.com>
Date: Mon, 9 May 2011 13:39:49 +0800
Subject: [PATCH] block: Change wrong type cast in part_discard_alignment_show.

Use 'unsigned int' instead of 'unsigned long long' introduced by commit
"block: Remove extra discard_alignment from hd_struct".

Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
 fs/partitions/check.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/partitions/check.c b/fs/partitions/check.c
index b7e16bc..b2bae85 100644
--- a/fs/partitions/check.c
+++ b/fs/partitions/check.c
@@ -258,7 +258,7 @@ ssize_t part_discard_alignment_show(struct device *dev,
 	struct gendisk *disk = dev_to_disk(dev);
 
 	return sprintf(buf, "%u\n",
-		       (unsigned long long)queue_limit_discard_alignment(
+		       (unsigned int)queue_limit_discard_alignment(
 							&disk->queue->limits,
 							p->start_sect));
 }
-- 
1.7.4

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 2011-05-09 07:55, Tao Ma wrote:
> Hi Jens,
> 
> Sorry for the trouble. Here is the fix.

Already fixed it up, we don't need a cast at all.

-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/block/loop.c: In function 'lo_splice_actor':
drivers/block/loop.c:398: warning: unused variable 'ret'

Introduced by commit a8adbe378b56acd5945df70753c7e8f6fe223304
("fs/splice: Pull buf->ops->confirm() from splice_from_pipe actors").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

Hi Jens,

On Mon, 20 Dec 2010 15:31:27 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the block tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/block/loop.c: In function 'lo_splice_actor':
> drivers/block/loop.c:398: warning: unused variable 'ret'
> 
> Introduced by commit a8adbe378b56acd5945df70753c7e8f6fe223304
> ("fs/splice: Pull buf->ops->confirm() from splice_from_pipe actors").

Also:

fs/nfsd/vfs.c: In function 'nfsd_splice_actor':
fs/nfsd/vfs.c:848: warning: unused variable 'ret'

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On 2010-12-20 05:42, Stephen Rothwell wrote:
> Hi Jens,
> 
> On Mon, 20 Dec 2010 15:31:27 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the block tree, today's linux-next build (powerpc
>> ppc64_defconfig) produced this warning:
>>
>> drivers/block/loop.c: In function 'lo_splice_actor':
>> drivers/block/loop.c:398: warning: unused variable 'ret'
>>
>> Introduced by commit a8adbe378b56acd5945df70753c7e8f6fe223304
>> ("fs/splice: Pull buf->ops->confirm() from splice_from_pipe actors").
> 
> Also:
> 
> fs/nfsd/vfs.c: In function 'nfsd_splice_actor':
> fs/nfsd/vfs.c:848: warning: unused variable 'ret'

Hrmpf, that's not very nice. I'll add a fixup patch, thanks Stephen.

-- 
Jens Axboe

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

Hi Jens,

After merging the block tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/sg.c: In function 'sg_start_req':
drivers/scsi/sg.c:1660: warning: passing argument 2 of 'blk_rq_aligned' makes integer from pointer without a cast
include/linux/blkdev.h:1045: note: expected 'long unsigned int' but argument is of type 'void *'

Introduced by commit 144177991ca624841ddbd1e7edff958fc0f6d1fe ("block:
fix an address space warning in blk-map.c").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

linux-next: build warning after merge of the block tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

Hi James,

After merging the block tree, today's linux-next build (powerpc
ppc44x_defconfig) produced this warning:

block/blk-lib.c: In function 'blkdev_issue_zeroout':
block/blk-lib.c:190: warning: comparison of distinct pointer types lacks a cast

Introduced by commit 3f14d792f9a8fede64ce918dbb517f934497a4f8 ("blkdev:
add blkdev_issue_zeroout helper function").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build warning after merge of the block tree

[Jens Axboe]

On Thu, Apr 29 2010, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the block tree, today's linux-next build (powerpc
> ppc44x_defconfig) produced this warning:
> 
> block/blk-lib.c: In function 'blkdev_issue_zeroout':
> block/blk-lib.c:190: warning: comparison of distinct pointer types lacks a cast
> 
> Introduced by commit 3f14d792f9a8fede64ce918dbb517f934497a4f8 ("blkdev:
> add blkdev_issue_zeroout helper function").

I fixed that warning up.

-- 
Jens Axboe