All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Carlos O'Donell <carlos@redhat.com>
Cc: linux-api@vger.kernel.org,
	Thorsten Leemhuis <linux@leemhuis.info>,
	ksummit-discuss@lists.linuxfoundation.org,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking
Date: Wed, 5 Jul 2017 09:27:57 -0400	[thread overview]
Message-ID: <20170705092757.63dc2328@gandalf.local.home> (raw)
In-Reply-To: <4080ecc7-1aa8-2940-f230-1b79d656cdb4@redhat.com>

On Wed, 5 Jul 2017 09:09:51 -0400
Carlos O'Donell <carlos@redhat.com> wrote:

> This problem is a reflection of our own explicit or implicit priorities.
> The priorities of developers and reviewers needs to change to make an
> impact on the problem. This is a hard problem.

I 100% agree.

> 
> As a concrete action item, glibc core developers took a harder stance on
> (a) all user-visible bugs need a bug # (forces people to think about the

Unfortunately, we don't have a good system for a "bug #". Most kernel
developers hate bugzilla, and I think that includes Linus ;-) Which
means, unless Linus builds us a new bug tracking system, there wont be
any mandate for it.


> problem and file a coherent public bug about it) (b) all bugs needs a
> regression test if possible, (c) and if not possible we need to extend

I would love all bug fixes to come with a test (when possible).

> the testing framework to make it possible (we've started using kernel
> namespaces to create isolated test configurations).

Well, we have a selftest directory that should include all of these.
And most people run them on either a test box or a VM.

> 
> This change in reviewer priorities has had a noticeable impact on developer
> priorities over the last 5 years. Timelines for this problem will be
> measured in years.
> 

Your "b" above is what I would like to push. But who's going to enforce
this? With 10,000 changes per release, and a lot of them are fixes, the
best we can do is the honor system. Start shaming people that don't
have a regression test along with a Fixes tag (but we don't want people
to fix bugs without adding that tag either). There is a fine line one
must walk between getting people to change their approaches to bugs and
regression tests, and pissing them off where they start doing the
opposite of what would be best for the community.

-- Steve

WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>
To: Carlos O'Donell <carlos-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Thorsten Leemhuis <linux-rCxcAJFjeRkk+I/owrrOrA@public.gmane.org>,
	ksummit-discuss-cunTk1MwBs98uUxBSJOaYoYkZiVZrdSR2LY78lusg7I@public.gmane.org,
	Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking
Date: Wed, 5 Jul 2017 09:27:57 -0400	[thread overview]
Message-ID: <20170705092757.63dc2328@gandalf.local.home> (raw)
In-Reply-To: <4080ecc7-1aa8-2940-f230-1b79d656cdb4-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Wed, 5 Jul 2017 09:09:51 -0400
Carlos O'Donell <carlos-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:

> This problem is a reflection of our own explicit or implicit priorities.
> The priorities of developers and reviewers needs to change to make an
> impact on the problem. This is a hard problem.

I 100% agree.

> 
> As a concrete action item, glibc core developers took a harder stance on
> (a) all user-visible bugs need a bug # (forces people to think about the

Unfortunately, we don't have a good system for a "bug #". Most kernel
developers hate bugzilla, and I think that includes Linus ;-) Which
means, unless Linus builds us a new bug tracking system, there wont be
any mandate for it.


> problem and file a coherent public bug about it) (b) all bugs needs a
> regression test if possible, (c) and if not possible we need to extend

I would love all bug fixes to come with a test (when possible).

> the testing framework to make it possible (we've started using kernel
> namespaces to create isolated test configurations).

Well, we have a selftest directory that should include all of these.
And most people run them on either a test box or a VM.

> 
> This change in reviewer priorities has had a noticeable impact on developer
> priorities over the last 5 years. Timelines for this problem will be
> measured in years.
> 

Your "b" above is what I would like to push. But who's going to enforce
this? With 10,000 changes per release, and a lot of them are fixes, the
best we can do is the honor system. Start shaming people that don't
have a regression test along with a Fixes tag (but we don't want people
to fix bugs without adding that tag either). There is a fine line one
must walk between getting people to change their approaches to bugs and
regression tests, and pissing them off where they start doing the
opposite of what would be best for the community.

-- Steve

  reply	other threads:[~2017-07-05 13:28 UTC|newest]

Thread overview: 144+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-02 17:51 [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking Thorsten Leemhuis
2017-07-03 16:30 ` Steven Rostedt
2017-07-03 16:30   ` Steven Rostedt
2017-07-03 18:50   ` Dan Williams
2017-07-03 18:50     ` Dan Williams
2017-07-04 19:03   ` Thorsten Leemhuis
2017-07-04 19:03     ` Thorsten Leemhuis
2017-07-05 12:45     ` Steven Rostedt
2017-07-05 12:45       ` Steven Rostedt
2017-07-05 13:09       ` Carlos O'Donell
2017-07-05 13:09         ` Carlos O'Donell
2017-07-05 13:27         ` Steven Rostedt [this message]
2017-07-05 13:27           ` Steven Rostedt
2017-07-05 14:06           ` Greg KH
2017-07-05 14:06             ` Greg KH
2017-07-05 14:28             ` Carlos O'Donell
2017-07-05 14:28               ` Carlos O'Donell
2017-07-05 14:33             ` Steven Rostedt
2017-07-05 14:33               ` Steven Rostedt
2017-07-05 14:52               ` Mark Brown
2017-07-05 14:52                 ` Mark Brown
2017-07-05 15:08               ` Carlos O'Donell
2017-07-05 15:08                 ` Carlos O'Donell
2017-07-05 16:10                 ` Steven Rostedt
2017-07-05 16:10                   ` Steven Rostedt
2017-07-06 11:34                   ` Laurent Pinchart
2017-07-06 11:34                     ` Laurent Pinchart
2017-07-09 13:46               ` Thorsten Leemhuis
2017-07-09 13:46                 ` Thorsten Leemhuis
2017-07-05 14:33             ` Mark Brown
2017-07-05 14:33               ` Mark Brown
2017-07-05 14:36               ` Steven Rostedt
2017-07-05 14:36                 ` Steven Rostedt
2017-07-05 14:50                 ` James Bottomley
2017-07-05 14:50                   ` James Bottomley
2017-07-05 14:56                   ` Steven Rostedt
2017-07-05 14:56                     ` Steven Rostedt
2017-07-05 15:09                     ` James Bottomley
2017-07-05 15:09                       ` James Bottomley
2017-07-05 15:20                       ` Mark Brown
2017-07-05 15:20                         ` Mark Brown
2017-07-05 15:40                         ` Geert Uytterhoeven
2017-07-05 15:40                           ` Geert Uytterhoeven
2017-07-05 15:20                       ` Steven Rostedt
2017-07-05 15:20                         ` Steven Rostedt
2017-07-05 15:32                         ` James Bottomley
2017-07-05 15:32                           ` James Bottomley
2017-07-05 15:43                           ` Steven Rostedt
2017-07-05 15:43                             ` Steven Rostedt
2017-07-05 18:24                       ` Daniel Vetter
2017-07-05 18:24                         ` Daniel Vetter
2017-07-05 18:17                 ` Daniel Vetter
2017-07-05 18:17                   ` Daniel Vetter
2017-07-05 15:16             ` Guenter Roeck
2017-07-05 15:16               ` Guenter Roeck
2017-07-05 15:27               ` Steven Rostedt
2017-07-05 15:27                 ` Steven Rostedt
2017-07-05 15:36                 ` James Bottomley
2017-07-05 15:36                   ` James Bottomley
2017-07-05 16:04                   ` Steven Rostedt
2017-07-05 16:04                     ` Steven Rostedt
2017-07-05 16:58                     ` James Bottomley
2017-07-05 16:58                       ` James Bottomley
2017-07-05 17:07                       ` Steven Rostedt
2017-07-05 17:07                         ` Steven Rostedt
2017-07-05 16:48                 ` Guenter Roeck
2017-07-05 16:48                   ` Guenter Roeck
2017-07-05 16:58                   ` Dan Williams
2017-07-05 16:58                     ` Dan Williams
2017-07-05 17:02                   ` Steven Rostedt
2017-07-05 17:02                     ` Steven Rostedt
2017-07-06  9:28                     ` Mark Brown
2017-07-06  9:28                       ` Mark Brown
2017-07-06  9:41                       ` Daniel Vetter
2017-07-06  9:41                         ` Daniel Vetter
2017-07-06 14:53                         ` Theodore Ts'o
2017-07-06 14:53                           ` Theodore Ts'o
2017-07-06 21:28                           ` Daniel Vetter
2017-07-06 21:28                             ` Daniel Vetter
2017-07-06 14:48                       ` James Bottomley
2017-07-06 14:48                         ` James Bottomley
2017-07-07 10:03                         ` Mark Brown
2017-07-07 10:03                           ` Mark Brown
2017-07-31 16:54                     ` Eric W. Biederman
2017-07-31 16:54                       ` Eric W. Biederman
2017-07-31 20:11                       ` Steven Rostedt
2017-07-31 20:11                         ` Steven Rostedt
2017-07-31 20:12                         ` Eric W. Biederman
2017-07-31 20:12                           ` Eric W. Biederman
2017-08-02 16:53                       ` Shuah Khan
2017-08-02 16:53                         ` Shuah Khan
2017-08-02 17:33                         ` Eric W. Biederman
2017-08-02 17:33                           ` Eric W. Biederman
2017-08-02 17:46                           ` Shuah Khan
2017-08-02 17:46                             ` Shuah Khan
2017-08-02 17:58                             ` Shuah Khan
2017-08-02 17:58                               ` Shuah Khan
2017-08-02 18:04                             ` Eric W. Biederman
2017-08-02 18:04                               ` Eric W. Biederman
2017-08-02 18:23                               ` Randy Dunlap
2017-08-02 18:23                                 ` Randy Dunlap
2017-08-02 18:42                               ` Shuah Khan
2017-08-02 18:42                                 ` Shuah Khan
2017-08-03  3:03                                 ` Theodore Ts'o
2017-08-03  3:03                                   ` Theodore Ts'o
2017-08-03 17:42                                   ` Bird, Timothy
2017-08-03 17:42                                     ` Bird, Timothy
2017-08-03 22:11                                     ` Shuah Khan
2017-08-03 22:11                                       ` Shuah Khan
2017-08-03 18:51                                   ` Shuah Khan
2017-08-03 18:51                                     ` Shuah Khan
2017-08-04  1:15                                     ` Theodore Ts'o
2017-08-04  1:15                                       ` Theodore Ts'o
2017-07-07  3:33                 ` Fengguang Wu
2017-07-07  3:33                   ` Fengguang Wu
2017-07-07  4:52                   ` Frank Rowand
2017-07-07  4:52                     ` Frank Rowand
2017-07-05 15:32               ` Greg KH
2017-07-05 15:32                 ` Greg KH
2017-07-05 15:36                 ` Carlos O'Donell
2017-07-05 15:36                   ` Carlos O'Donell
2017-07-05 15:52                 ` Steven Rostedt
2017-07-05 15:52                   ` Steven Rostedt
2017-07-05 18:42                   ` Greg KH
2017-07-05 18:42                     ` Greg KH
2017-07-05 18:29                 ` Daniel Vetter
2017-07-05 18:29                   ` Daniel Vetter
2017-07-06 22:24                 ` Shuah Khan
2017-07-06 22:24                   ` Shuah Khan
2017-07-06 22:32                   ` Steven Rostedt
2017-07-06 22:32                     ` Steven Rostedt
2017-07-06 22:40                     ` Shuah Khan
2017-07-06 22:40                       ` Shuah Khan
2017-07-05 16:54             ` Dan Williams
2017-07-05 16:54               ` Dan Williams
2017-07-05 18:45               ` Greg KH
2017-07-05 18:45                 ` Greg KH
2017-07-05 19:47                 ` Dan Williams
2017-07-05 19:47                   ` Dan Williams
2017-07-05 14:06           ` Carlos O'Donell
2017-07-05 14:06             ` Carlos O'Donell
2017-07-05 15:47         ` Mark Brown
2017-07-05 15:47           ` Mark Brown
2017-07-07  6:15 ` Andrei Vagin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170705092757.63dc2328@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=carlos@redhat.com \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.