All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos O'Donell <carlos@redhat.com>
To: Greg KH <greg@kroah.com>, Steven Rostedt <rostedt@goodmis.org>
Cc: linux-api@vger.kernel.org,
	Thorsten Leemhuis <linux@leemhuis.info>,
	ksummit-discuss@lists.linuxfoundation.org,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking
Date: Wed, 5 Jul 2017 10:28:30 -0400	[thread overview]
Message-ID: <6401b327-cc2c-5e0a-716b-0b9ea70adcb0@redhat.com> (raw)
In-Reply-To: <20170705140607.GA30187@kroah.com>

On 07/05/2017 10:06 AM, Greg KH wrote:
> I don't mean to poo-poo the idea, but please realize that around 75% of
> the kernel is hardware/arch support, so that means that 75% of the
> changes/fixes deal with hardware things (yes, change is in direct
> correlation to size of the codebase in the tree, strange but true).

We should distinguish between the reviewer reviewing the regression test
and running the regression test. As long as the submitter ran the 
regression test on their hardware, and it passed, the reviewer need only
review the test for logical consistency and correctness?

Lack of test infrastructure was a serious problem for us in glibc. We are
relying on namespaces for more complex network and filesystem testing.
Without namespaces we would have needed a much more complex setup that
might never have seen developer adoption. When I attended LPC 2016 I
prioritized listening in on namespaces discussions to make sure nothing
was changing that might break our testing framework.

This conversation is going to lead down the path of driver HAL or
emulation in order to provide regression testing for code above the actual
hardware, and that's another hard problem, but one need not go there.

Starting with real hardware tests can have benefit.

In glibc we test SSE, AVX, AVX512, TSX etc. but if you don't have the
extensions you get a bunch of UNSUPPORTED tests. While upstream kernel 
may have a more limited set of available hardware per-person, the
collective set of developers has hardware to cover all configurations,
and they should run the regression tests for hardware they care about
... and *must* do so if they submit a patch to fix a bug! :-)

-- 
Cheers,
Carlos.

WARNING: multiple messages have this Message-ID (diff)
From: Carlos O'Donell <carlos-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>,
	Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>
Cc: Thorsten Leemhuis <linux-rCxcAJFjeRkk+I/owrrOrA@public.gmane.org>,
	ksummit-discuss-cunTk1MwBs98uUxBSJOaYoYkZiVZrdSR2LY78lusg7I@public.gmane.org,
	Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking
Date: Wed, 5 Jul 2017 10:28:30 -0400	[thread overview]
Message-ID: <6401b327-cc2c-5e0a-716b-0b9ea70adcb0@redhat.com> (raw)
In-Reply-To: <20170705140607.GA30187-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>

On 07/05/2017 10:06 AM, Greg KH wrote:
> I don't mean to poo-poo the idea, but please realize that around 75% of
> the kernel is hardware/arch support, so that means that 75% of the
> changes/fixes deal with hardware things (yes, change is in direct
> correlation to size of the codebase in the tree, strange but true).

We should distinguish between the reviewer reviewing the regression test
and running the regression test. As long as the submitter ran the 
regression test on their hardware, and it passed, the reviewer need only
review the test for logical consistency and correctness?

Lack of test infrastructure was a serious problem for us in glibc. We are
relying on namespaces for more complex network and filesystem testing.
Without namespaces we would have needed a much more complex setup that
might never have seen developer adoption. When I attended LPC 2016 I
prioritized listening in on namespaces discussions to make sure nothing
was changing that might break our testing framework.

This conversation is going to lead down the path of driver HAL or
emulation in order to provide regression testing for code above the actual
hardware, and that's another hard problem, but one need not go there.

Starting with real hardware tests can have benefit.

In glibc we test SSE, AVX, AVX512, TSX etc. but if you don't have the
extensions you get a bunch of UNSUPPORTED tests. While upstream kernel 
may have a more limited set of available hardware per-person, the
collective set of developers has hardware to cover all configurations,
and they should run the regression tests for hardware they care about
... and *must* do so if they submit a patch to fix a bug! :-)

-- 
Cheers,
Carlos.

  reply	other threads:[~2017-07-05 14:28 UTC|newest]

Thread overview: 144+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-02 17:51 [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking Thorsten Leemhuis
2017-07-03 16:30 ` Steven Rostedt
2017-07-03 16:30   ` Steven Rostedt
2017-07-03 18:50   ` Dan Williams
2017-07-03 18:50     ` Dan Williams
2017-07-04 19:03   ` Thorsten Leemhuis
2017-07-04 19:03     ` Thorsten Leemhuis
2017-07-05 12:45     ` Steven Rostedt
2017-07-05 12:45       ` Steven Rostedt
2017-07-05 13:09       ` Carlos O'Donell
2017-07-05 13:09         ` Carlos O'Donell
2017-07-05 13:27         ` Steven Rostedt
2017-07-05 13:27           ` Steven Rostedt
2017-07-05 14:06           ` Greg KH
2017-07-05 14:06             ` Greg KH
2017-07-05 14:28             ` Carlos O'Donell [this message]
2017-07-05 14:28               ` Carlos O'Donell
2017-07-05 14:33             ` Steven Rostedt
2017-07-05 14:33               ` Steven Rostedt
2017-07-05 14:52               ` Mark Brown
2017-07-05 14:52                 ` Mark Brown
2017-07-05 15:08               ` Carlos O'Donell
2017-07-05 15:08                 ` Carlos O'Donell
2017-07-05 16:10                 ` Steven Rostedt
2017-07-05 16:10                   ` Steven Rostedt
2017-07-06 11:34                   ` Laurent Pinchart
2017-07-06 11:34                     ` Laurent Pinchart
2017-07-09 13:46               ` Thorsten Leemhuis
2017-07-09 13:46                 ` Thorsten Leemhuis
2017-07-05 14:33             ` Mark Brown
2017-07-05 14:33               ` Mark Brown
2017-07-05 14:36               ` Steven Rostedt
2017-07-05 14:36                 ` Steven Rostedt
2017-07-05 14:50                 ` James Bottomley
2017-07-05 14:50                   ` James Bottomley
2017-07-05 14:56                   ` Steven Rostedt
2017-07-05 14:56                     ` Steven Rostedt
2017-07-05 15:09                     ` James Bottomley
2017-07-05 15:09                       ` James Bottomley
2017-07-05 15:20                       ` Mark Brown
2017-07-05 15:20                         ` Mark Brown
2017-07-05 15:40                         ` Geert Uytterhoeven
2017-07-05 15:40                           ` Geert Uytterhoeven
2017-07-05 15:20                       ` Steven Rostedt
2017-07-05 15:20                         ` Steven Rostedt
2017-07-05 15:32                         ` James Bottomley
2017-07-05 15:32                           ` James Bottomley
2017-07-05 15:43                           ` Steven Rostedt
2017-07-05 15:43                             ` Steven Rostedt
2017-07-05 18:24                       ` Daniel Vetter
2017-07-05 18:24                         ` Daniel Vetter
2017-07-05 18:17                 ` Daniel Vetter
2017-07-05 18:17                   ` Daniel Vetter
2017-07-05 15:16             ` Guenter Roeck
2017-07-05 15:16               ` Guenter Roeck
2017-07-05 15:27               ` Steven Rostedt
2017-07-05 15:27                 ` Steven Rostedt
2017-07-05 15:36                 ` James Bottomley
2017-07-05 15:36                   ` James Bottomley
2017-07-05 16:04                   ` Steven Rostedt
2017-07-05 16:04                     ` Steven Rostedt
2017-07-05 16:58                     ` James Bottomley
2017-07-05 16:58                       ` James Bottomley
2017-07-05 17:07                       ` Steven Rostedt
2017-07-05 17:07                         ` Steven Rostedt
2017-07-05 16:48                 ` Guenter Roeck
2017-07-05 16:48                   ` Guenter Roeck
2017-07-05 16:58                   ` Dan Williams
2017-07-05 16:58                     ` Dan Williams
2017-07-05 17:02                   ` Steven Rostedt
2017-07-05 17:02                     ` Steven Rostedt
2017-07-06  9:28                     ` Mark Brown
2017-07-06  9:28                       ` Mark Brown
2017-07-06  9:41                       ` Daniel Vetter
2017-07-06  9:41                         ` Daniel Vetter
2017-07-06 14:53                         ` Theodore Ts'o
2017-07-06 14:53                           ` Theodore Ts'o
2017-07-06 21:28                           ` Daniel Vetter
2017-07-06 21:28                             ` Daniel Vetter
2017-07-06 14:48                       ` James Bottomley
2017-07-06 14:48                         ` James Bottomley
2017-07-07 10:03                         ` Mark Brown
2017-07-07 10:03                           ` Mark Brown
2017-07-31 16:54                     ` Eric W. Biederman
2017-07-31 16:54                       ` Eric W. Biederman
2017-07-31 20:11                       ` Steven Rostedt
2017-07-31 20:11                         ` Steven Rostedt
2017-07-31 20:12                         ` Eric W. Biederman
2017-07-31 20:12                           ` Eric W. Biederman
2017-08-02 16:53                       ` Shuah Khan
2017-08-02 16:53                         ` Shuah Khan
2017-08-02 17:33                         ` Eric W. Biederman
2017-08-02 17:33                           ` Eric W. Biederman
2017-08-02 17:46                           ` Shuah Khan
2017-08-02 17:46                             ` Shuah Khan
2017-08-02 17:58                             ` Shuah Khan
2017-08-02 17:58                               ` Shuah Khan
2017-08-02 18:04                             ` Eric W. Biederman
2017-08-02 18:04                               ` Eric W. Biederman
2017-08-02 18:23                               ` Randy Dunlap
2017-08-02 18:23                                 ` Randy Dunlap
2017-08-02 18:42                               ` Shuah Khan
2017-08-02 18:42                                 ` Shuah Khan
2017-08-03  3:03                                 ` Theodore Ts'o
2017-08-03  3:03                                   ` Theodore Ts'o
2017-08-03 17:42                                   ` Bird, Timothy
2017-08-03 17:42                                     ` Bird, Timothy
2017-08-03 22:11                                     ` Shuah Khan
2017-08-03 22:11                                       ` Shuah Khan
2017-08-03 18:51                                   ` Shuah Khan
2017-08-03 18:51                                     ` Shuah Khan
2017-08-04  1:15                                     ` Theodore Ts'o
2017-08-04  1:15                                       ` Theodore Ts'o
2017-07-07  3:33                 ` Fengguang Wu
2017-07-07  3:33                   ` Fengguang Wu
2017-07-07  4:52                   ` Frank Rowand
2017-07-07  4:52                     ` Frank Rowand
2017-07-05 15:32               ` Greg KH
2017-07-05 15:32                 ` Greg KH
2017-07-05 15:36                 ` Carlos O'Donell
2017-07-05 15:36                   ` Carlos O'Donell
2017-07-05 15:52                 ` Steven Rostedt
2017-07-05 15:52                   ` Steven Rostedt
2017-07-05 18:42                   ` Greg KH
2017-07-05 18:42                     ` Greg KH
2017-07-05 18:29                 ` Daniel Vetter
2017-07-05 18:29                   ` Daniel Vetter
2017-07-06 22:24                 ` Shuah Khan
2017-07-06 22:24                   ` Shuah Khan
2017-07-06 22:32                   ` Steven Rostedt
2017-07-06 22:32                     ` Steven Rostedt
2017-07-06 22:40                     ` Shuah Khan
2017-07-06 22:40                       ` Shuah Khan
2017-07-05 16:54             ` Dan Williams
2017-07-05 16:54               ` Dan Williams
2017-07-05 18:45               ` Greg KH
2017-07-05 18:45                 ` Greg KH
2017-07-05 19:47                 ` Dan Williams
2017-07-05 19:47                   ` Dan Williams
2017-07-05 14:06           ` Carlos O'Donell
2017-07-05 14:06             ` Carlos O'Donell
2017-07-05 15:47         ` Mark Brown
2017-07-05 15:47           ` Mark Brown
2017-07-07  6:15 ` Andrei Vagin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6401b327-cc2c-5e0a-716b-0b9ea70adcb0@redhat.com \
    --to=carlos@redhat.com \
    --cc=greg@kroah.com \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=rostedt@goodmis.org \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.