All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Rowand <frowand.list@gmail.com>
To: Fengguang Wu <fengguang.wu@intel.com>,
	Steven Rostedt <rostedt@goodmis.org>
Cc: Carlos O'Donell <carlos@redhat.com>,
	linux-api@vger.kernel.org,
	Thorsten Leemhuis <linux@leemhuis.info>,
	ksummit-discuss@lists.linuxfoundation.org,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking
Date: Thu, 6 Jul 2017 21:52:25 -0700	[thread overview]
Message-ID: <595F1389.60308@gmail.com> (raw)
In-Reply-To: <20170707033302.rgpq5knzx3qvvr2p@wfg-t540p.sh.intel.com>

On 07/06/17 20:33, Fengguang Wu wrote:
> On Wed, Jul 05, 2017 at 11:27:07AM -0400, Steven Rostedt wrote:
> [snip]
>> I need to be clearer on this. What I meant was, if there's a bug
>> where someone has a test that easily reproduces the bug, then if
>> there's not a test added to selftests for said bug, then we should
>> shame those into doing so.
> 
> Besides shaming, there's one more option -- acknowledgement.
> 
> When it's a test case or test tool that discovered the bug, we could
> acknowledge it by adding one line in the bug fixing patch. The exact
> forms can be discussed, but here are some examples to show the basic
> idea:
> 
> Tool: lockdep
> Tool: ktest
> Tool: smatch
> Tool: trinity
> Tool: syzkaller
> Tool: xfstests/tests/ext4/025
> Tool: scripts/coccinelle/locks/call_kern.cocci
> Tool: tools/testing/selftests/bpf/test_align.c
> 
> Reports from test infrastructures like 0day could go further to help
> acknowledge the tool author or maintainer by showing such lines in its
> bug report email:
> 
> You may consider adding these lines in the bug fixing patch:
> 
> -----------------------[ cut here ]----------------------------------
> Fixes: XXXXXXXXXX ("title of the buggy commit")
> Tool: tools/testing/selftests/bpf/test_align.c <davem@davemloft.net>
> Reported-by: 0day test robot <xiaolong.ye@intel.com>
> -----------------------[ cut here ]----------------------------------
> 
> Regards,
> Fengguang
> _______________________________________________
> Ksummit-discuss mailing list
> Ksummit-discuss@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss
> 

That is a great idea!  If a tool is shown to be catching a large
number of bugs then I am more likely to add it to my test process.

-Frank

WARNING: multiple messages have this Message-ID (diff)
From: Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Fengguang Wu
	<fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>
Cc: ksummit-discuss-cunTk1MwBs98uUxBSJOaYoYkZiVZrdSR2LY78lusg7I@public.gmane.org,
	Carlos O'Donell <carlos-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Thorsten Leemhuis <linux-rCxcAJFjeRkk+I/owrrOrA@public.gmane.org>,
	Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking
Date: Thu, 6 Jul 2017 21:52:25 -0700	[thread overview]
Message-ID: <595F1389.60308@gmail.com> (raw)
In-Reply-To: <20170707033302.rgpq5knzx3qvvr2p-q6ZYBFIlbFFi0tQiZxhdj1DQ4js95KgL@public.gmane.org>

On 07/06/17 20:33, Fengguang Wu wrote:
> On Wed, Jul 05, 2017 at 11:27:07AM -0400, Steven Rostedt wrote:
> [snip]
>> I need to be clearer on this. What I meant was, if there's a bug
>> where someone has a test that easily reproduces the bug, then if
>> there's not a test added to selftests for said bug, then we should
>> shame those into doing so.
> 
> Besides shaming, there's one more option -- acknowledgement.
> 
> When it's a test case or test tool that discovered the bug, we could
> acknowledge it by adding one line in the bug fixing patch. The exact
> forms can be discussed, but here are some examples to show the basic
> idea:
> 
> Tool: lockdep
> Tool: ktest
> Tool: smatch
> Tool: trinity
> Tool: syzkaller
> Tool: xfstests/tests/ext4/025
> Tool: scripts/coccinelle/locks/call_kern.cocci
> Tool: tools/testing/selftests/bpf/test_align.c
> 
> Reports from test infrastructures like 0day could go further to help
> acknowledge the tool author or maintainer by showing such lines in its
> bug report email:
> 
> You may consider adding these lines in the bug fixing patch:
> 
> -----------------------[ cut here ]----------------------------------
> Fixes: XXXXXXXXXX ("title of the buggy commit")
> Tool: tools/testing/selftests/bpf/test_align.c <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
> Reported-by: 0day test robot <xiaolong.ye-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> -----------------------[ cut here ]----------------------------------
> 
> Regards,
> Fengguang
> _______________________________________________
> Ksummit-discuss mailing list
> Ksummit-discuss-cunTk1MwBs98uUxBSJOaYoYkZiVZrdSR2LY78lusg7I@public.gmane.org
> https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss
> 

That is a great idea!  If a tool is shown to be catching a large
number of bugs then I am more likely to add it to my test process.

-Frank

  reply	other threads:[~2017-07-07  4:52 UTC|newest]

Thread overview: 144+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-02 17:51 [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking Thorsten Leemhuis
2017-07-03 16:30 ` Steven Rostedt
2017-07-03 16:30   ` Steven Rostedt
2017-07-03 18:50   ` Dan Williams
2017-07-03 18:50     ` Dan Williams
2017-07-04 19:03   ` Thorsten Leemhuis
2017-07-04 19:03     ` Thorsten Leemhuis
2017-07-05 12:45     ` Steven Rostedt
2017-07-05 12:45       ` Steven Rostedt
2017-07-05 13:09       ` Carlos O'Donell
2017-07-05 13:09         ` Carlos O'Donell
2017-07-05 13:27         ` Steven Rostedt
2017-07-05 13:27           ` Steven Rostedt
2017-07-05 14:06           ` Greg KH
2017-07-05 14:06             ` Greg KH
2017-07-05 14:28             ` Carlos O'Donell
2017-07-05 14:28               ` Carlos O'Donell
2017-07-05 14:33             ` Steven Rostedt
2017-07-05 14:33               ` Steven Rostedt
2017-07-05 14:52               ` Mark Brown
2017-07-05 14:52                 ` Mark Brown
2017-07-05 15:08               ` Carlos O'Donell
2017-07-05 15:08                 ` Carlos O'Donell
2017-07-05 16:10                 ` Steven Rostedt
2017-07-05 16:10                   ` Steven Rostedt
2017-07-06 11:34                   ` Laurent Pinchart
2017-07-06 11:34                     ` Laurent Pinchart
2017-07-09 13:46               ` Thorsten Leemhuis
2017-07-09 13:46                 ` Thorsten Leemhuis
2017-07-05 14:33             ` Mark Brown
2017-07-05 14:33               ` Mark Brown
2017-07-05 14:36               ` Steven Rostedt
2017-07-05 14:36                 ` Steven Rostedt
2017-07-05 14:50                 ` James Bottomley
2017-07-05 14:50                   ` James Bottomley
2017-07-05 14:56                   ` Steven Rostedt
2017-07-05 14:56                     ` Steven Rostedt
2017-07-05 15:09                     ` James Bottomley
2017-07-05 15:09                       ` James Bottomley
2017-07-05 15:20                       ` Mark Brown
2017-07-05 15:20                         ` Mark Brown
2017-07-05 15:40                         ` Geert Uytterhoeven
2017-07-05 15:40                           ` Geert Uytterhoeven
2017-07-05 15:20                       ` Steven Rostedt
2017-07-05 15:20                         ` Steven Rostedt
2017-07-05 15:32                         ` James Bottomley
2017-07-05 15:32                           ` James Bottomley
2017-07-05 15:43                           ` Steven Rostedt
2017-07-05 15:43                             ` Steven Rostedt
2017-07-05 18:24                       ` Daniel Vetter
2017-07-05 18:24                         ` Daniel Vetter
2017-07-05 18:17                 ` Daniel Vetter
2017-07-05 18:17                   ` Daniel Vetter
2017-07-05 15:16             ` Guenter Roeck
2017-07-05 15:16               ` Guenter Roeck
2017-07-05 15:27               ` Steven Rostedt
2017-07-05 15:27                 ` Steven Rostedt
2017-07-05 15:36                 ` James Bottomley
2017-07-05 15:36                   ` James Bottomley
2017-07-05 16:04                   ` Steven Rostedt
2017-07-05 16:04                     ` Steven Rostedt
2017-07-05 16:58                     ` James Bottomley
2017-07-05 16:58                       ` James Bottomley
2017-07-05 17:07                       ` Steven Rostedt
2017-07-05 17:07                         ` Steven Rostedt
2017-07-05 16:48                 ` Guenter Roeck
2017-07-05 16:48                   ` Guenter Roeck
2017-07-05 16:58                   ` Dan Williams
2017-07-05 16:58                     ` Dan Williams
2017-07-05 17:02                   ` Steven Rostedt
2017-07-05 17:02                     ` Steven Rostedt
2017-07-06  9:28                     ` Mark Brown
2017-07-06  9:28                       ` Mark Brown
2017-07-06  9:41                       ` Daniel Vetter
2017-07-06  9:41                         ` Daniel Vetter
2017-07-06 14:53                         ` Theodore Ts'o
2017-07-06 14:53                           ` Theodore Ts'o
2017-07-06 21:28                           ` Daniel Vetter
2017-07-06 21:28                             ` Daniel Vetter
2017-07-06 14:48                       ` James Bottomley
2017-07-06 14:48                         ` James Bottomley
2017-07-07 10:03                         ` Mark Brown
2017-07-07 10:03                           ` Mark Brown
2017-07-31 16:54                     ` Eric W. Biederman
2017-07-31 16:54                       ` Eric W. Biederman
2017-07-31 20:11                       ` Steven Rostedt
2017-07-31 20:11                         ` Steven Rostedt
2017-07-31 20:12                         ` Eric W. Biederman
2017-07-31 20:12                           ` Eric W. Biederman
2017-08-02 16:53                       ` Shuah Khan
2017-08-02 16:53                         ` Shuah Khan
2017-08-02 17:33                         ` Eric W. Biederman
2017-08-02 17:33                           ` Eric W. Biederman
2017-08-02 17:46                           ` Shuah Khan
2017-08-02 17:46                             ` Shuah Khan
2017-08-02 17:58                             ` Shuah Khan
2017-08-02 17:58                               ` Shuah Khan
2017-08-02 18:04                             ` Eric W. Biederman
2017-08-02 18:04                               ` Eric W. Biederman
2017-08-02 18:23                               ` Randy Dunlap
2017-08-02 18:23                                 ` Randy Dunlap
2017-08-02 18:42                               ` Shuah Khan
2017-08-02 18:42                                 ` Shuah Khan
2017-08-03  3:03                                 ` Theodore Ts'o
2017-08-03  3:03                                   ` Theodore Ts'o
2017-08-03 17:42                                   ` Bird, Timothy
2017-08-03 17:42                                     ` Bird, Timothy
2017-08-03 22:11                                     ` Shuah Khan
2017-08-03 22:11                                       ` Shuah Khan
2017-08-03 18:51                                   ` Shuah Khan
2017-08-03 18:51                                     ` Shuah Khan
2017-08-04  1:15                                     ` Theodore Ts'o
2017-08-04  1:15                                       ` Theodore Ts'o
2017-07-07  3:33                 ` Fengguang Wu
2017-07-07  3:33                   ` Fengguang Wu
2017-07-07  4:52                   ` Frank Rowand [this message]
2017-07-07  4:52                     ` Frank Rowand
2017-07-05 15:32               ` Greg KH
2017-07-05 15:32                 ` Greg KH
2017-07-05 15:36                 ` Carlos O'Donell
2017-07-05 15:36                   ` Carlos O'Donell
2017-07-05 15:52                 ` Steven Rostedt
2017-07-05 15:52                   ` Steven Rostedt
2017-07-05 18:42                   ` Greg KH
2017-07-05 18:42                     ` Greg KH
2017-07-05 18:29                 ` Daniel Vetter
2017-07-05 18:29                   ` Daniel Vetter
2017-07-06 22:24                 ` Shuah Khan
2017-07-06 22:24                   ` Shuah Khan
2017-07-06 22:32                   ` Steven Rostedt
2017-07-06 22:32                     ` Steven Rostedt
2017-07-06 22:40                     ` Shuah Khan
2017-07-06 22:40                       ` Shuah Khan
2017-07-05 16:54             ` Dan Williams
2017-07-05 16:54               ` Dan Williams
2017-07-05 18:45               ` Greg KH
2017-07-05 18:45                 ` Greg KH
2017-07-05 19:47                 ` Dan Williams
2017-07-05 19:47                   ` Dan Williams
2017-07-05 14:06           ` Carlos O'Donell
2017-07-05 14:06             ` Carlos O'Donell
2017-07-05 15:47         ` Mark Brown
2017-07-05 15:47           ` Mark Brown
2017-07-07  6:15 ` Andrei Vagin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=595F1389.60308@gmail.com \
    --to=frowand.list@gmail.com \
    --cc=carlos@redhat.com \
    --cc=fengguang.wu@intel.com \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=rostedt@goodmis.org \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.