From: "Stefan Riedmüller" <S.Riedmueller@phytec.de>
To: "han.xu@nxp.com" <han.xu@nxp.com>
Cc: "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"michael@amarulasolutions.com" <michael@amarulasolutions.com>,
"ceggers@arri.de" <ceggers@arri.de>,
"bbrezillon@kernel.org" <bbrezillon@kernel.org>,
Christian Hemp <C.Hemp@phytec.de>,
"gerg@kernel.org" <gerg@kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [RFC PATCH 2/2] gpmi-nand: Add ERR007117 protection for nfc_apply_timings
Date: Mon, 25 Oct 2021 09:39:15 +0000 [thread overview]
Message-ID: <a14524533eccd185224e1c2ec61895e1dbbf7ff8.camel@phytec.de> (raw)
In-Reply-To: <20211022143514.lplk6jaxklq3rxry@umbrella>
Hi Han,
On Fri, 2021-10-22 at 09:35 -0500, han.xu@nxp.com wrote:
> On 21/10/22 08:45AM, Stefan Riedmüller wrote:
> > Hi Han,
> >
> > sorry it took me some time to get back to you.
> >
> > On Wed, 2021-10-13 at 00:01 -0500, Han Xu wrote:
> > > On 21/10/12 11:02AM, Stefan Riedmueller wrote:
> > > > According to i.MX 6 erratum ERR007117 gpmi clocks need to be gated off
> > > > when doing a gpmi_io clk rate change. So gate the clocks off before
> > > > the rate change in nfc_apply_timings and ungate them again after the
> > > > change.
> > > >
> > > > Otherwise this rate change can lead to an unresponsive GPMI core which
> > > > results in DMA timeouts and failed driver probe:
> > > >
> > > > [ 4.072318] gpmi-nand 112000.gpmi-nand: DMA timeout, last DMA
> > > > ...
> > > > [ 4.370355] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -110
> > > > ...
> > > > [ 4.375988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22
> > > > [ 4.381524] gpmi-nand 112000.gpmi-nand: Error in ECC-based read:
> > > > -22
> > > > [ 4.387988] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22
> > > > [ 4.393535] gpmi-nand 112000.gpmi-nand: Chip: 0, Error -22
> > > > ...
> > > >
> > > > Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> > > > ---
> > > > Hi,
> > > >
> > > > I'm not sure about the error handling here, if it is actually
> > > > neccessary.
> > > > So some feedback would be nice here.
> > > >
> > > > Thanks,
> > > > Stefan
> > > > ---
> > > > drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 21 +++++++++++++++++++--
> > > > 1 file changed, 19 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> > > > b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> > > > index a1f7000f033e..326c8a895f1f 100644
> > > > --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> > > > +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> > > > @@ -713,15 +713,28 @@ static void gpmi_nfc_compute_timings(struct
> > > > gpmi_nand_data *this,
> > > > (use_half_period ?
> > > > BM_GPMI_CTRL1_HALF_PERIOD :
> > > > 0);
> > > > }
> > > >
> > > > -static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)
> > > > +static int gpmi_nfc_apply_timings(struct gpmi_nand_data *this)
> > > > {
> > > > struct gpmi_nfc_hardware_timing *hw = &this->hw;
> > > > struct resources *r = &this->resources;
> > > > void __iomem *gpmi_regs = r->gpmi_regs;
> > > > unsigned int dll_wait_time_us;
> > > > + int ret;
> > > > +
> > > > + if (GPMI_IS_MX6Q(this)) {
> > >
> > > Not only for 6Q but for GPMI_IS_MX6
> >
> > Can you confirm that i.MX 6SX and i.MX 7 are affected by the ERR007117
> > erratum
> > as well? Because the i.MX 6UL/ULL are included by the GPMI_IS_MX6Q
> > already.
>
> i.MX6SX has the glitch issue for sure, but I can double check if it's due to
> the
> same errata. I will also go check if the errata will affect i.MX7
Thanks, that'll be great!
I'll wait for your response.
Thanks,
Stefan
>
> > Or do we need another macro for i.MX 6UL/ULL as Christian has suggested
> > earlier?
> >
> > Thanks,
> > Stefan
> >
> > > > + ret = __gpmi_enable_clk(this, false);
> > > > + if (ret)
> > > > + return ret;
> > > > + }
> > > >
> > > > clk_set_rate(r->clock[0], hw->clk_rate);
> > > >
> > > > + if (GPMI_IS_MX6Q(this)) {
> > > > + ret = __gpmi_enable_clk(this, true);
> > > > + if (ret)
> > > > + return ret;
> > > > + }
> > > > +
> > > > writel(hw->timing0, gpmi_regs + HW_GPMI_TIMING0);
> > > > writel(hw->timing1, gpmi_regs + HW_GPMI_TIMING1);
> > > >
> > > > @@ -739,6 +752,8 @@ static void gpmi_nfc_apply_timings(struct
> > > > gpmi_nand_data *this)
> > > >
> > > > /* Wait for the DLL to settle. */
> > > > udelay(dll_wait_time_us);
> > > > +
> > > > + return 0;
> > > > }
> > > >
> > > > static int gpmi_setup_interface(struct nand_chip *chip, int chipnr,
> > > > @@ -2271,7 +2286,9 @@ static int gpmi_nfc_exec_op(struct nand_chip
> > > > *chip,
> > > > */
> > > > if (this->hw.must_apply_timings) {
> > > > this->hw.must_apply_timings = false;
> > > > - gpmi_nfc_apply_timings(this);
> > > > + ret = gpmi_nfc_apply_timings(this);
> > > > + if (ret)
> > > > + return ret;
> > > > }
> > > >
> > > > dev_dbg(this->dev, "%s: %d instructions\n", __func__, op-
> > > > >ninstrs);
> > > > --
> > > > 2.25.1
> > > >
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-10-25 9:40 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 6:41 GPMI iMX6ull timeout on DMA Greg Ungerer
2019-07-29 8:36 ` Miquel Raynal
2019-07-29 8:42 ` Michael Nazzareno Trimarchi
2019-07-29 12:18 ` Greg Ungerer
2019-07-29 12:20 ` Michael Nazzareno Trimarchi
2019-07-29 12:33 ` Greg Ungerer
2019-07-29 12:47 ` Miquel Raynal
2019-07-29 12:49 ` Michael Nazzareno Trimarchi
2019-07-29 12:55 ` Miquel Raynal
2019-07-29 13:00 ` Michael Nazzareno Trimarchi
2019-07-29 13:22 ` Miquel Raynal
2019-07-29 20:00 ` Michael Nazzareno Trimarchi
2019-07-29 21:02 ` Miquel Raynal
2019-07-30 0:28 ` Greg Ungerer
2019-07-30 0:41 ` Greg Ungerer
2019-07-30 6:06 ` Greg Ungerer
2019-07-30 8:38 ` Miquel Raynal
2019-07-30 8:58 ` Boris Brezillon
2019-07-31 2:05 ` Greg Ungerer
2019-07-31 6:28 ` Boris Brezillon
2019-08-02 7:19 ` Greg Ungerer
2019-08-02 12:34 ` Greg Ungerer
2019-08-02 12:51 ` Boris Brezillon
2019-08-05 5:51 ` Greg Ungerer
2019-08-07 16:05 ` Miquel Raynal
2019-08-08 0:43 ` Greg Ungerer
2019-08-08 16:36 ` Boris Brezillon
2019-08-09 5:20 ` Greg Ungerer
2019-08-09 6:23 ` Boris Brezillon
2019-08-09 6:55 ` Greg Ungerer
2019-08-09 7:32 ` Boris Brezillon
2019-08-09 13:57 ` Greg Ungerer
2019-08-09 13:59 ` Boris Brezillon
2019-08-12 2:50 ` Greg Ungerer
2019-08-12 4:04 ` Greg Ungerer
2019-08-12 7:31 ` Boris Brezillon
2019-08-13 0:50 ` Greg Ungerer
2021-01-28 9:45 ` Michael Nazzareno Trimarchi
2021-01-28 10:26 ` Miquel Raynal
2021-01-28 10:35 ` Michael Nazzareno Trimarchi
2021-01-28 11:55 ` Michael Nazzareno Trimarchi
2021-01-29 12:43 ` Greg Ungerer
2021-01-30 9:41 ` Michael Nazzareno Trimarchi
2021-02-01 14:13 ` Miquel Raynal
2021-02-01 14:32 ` Michael Nazzareno Trimarchi
2021-02-01 15:08 ` Michael Nazzareno Trimarchi
2021-02-01 15:14 ` Miquel Raynal
2021-02-01 15:17 ` Michael Nazzareno Trimarchi
2021-10-15 20:05 ` Michael Trimarchi
2021-10-15 20:12 ` Michael Nazzareno Trimarchi
2021-10-18 7:19 ` Miquel Raynal
2021-10-18 7:33 ` Michael Nazzareno Trimarchi
2021-10-18 7:43 ` Miquel Raynal
2021-10-04 5:54 ` Christian Eggers
2021-10-04 6:27 ` Michael Nazzareno Trimarchi
2021-10-04 15:33 ` Miquel Raynal
2021-10-04 16:06 ` Han Xu
2021-10-05 6:02 ` Christian Eggers
2021-10-08 9:55 ` Christian Eggers
2021-10-08 12:08 ` Stefan Riedmüller
2021-10-08 12:27 ` Miquel Raynal
2021-10-08 13:11 ` Christian Eggers
2021-10-08 13:29 ` Miquel Raynal
2021-10-08 13:36 ` Miquel Raynal
2021-10-08 13:49 ` Christian Eggers
2021-10-08 16:07 ` Miquel Raynal
2021-10-09 5:53 ` Michael Nazzareno Trimarchi
2021-10-11 6:46 ` Miquel Raynal
2021-10-12 9:02 ` [RFC PATCH 1/2] mtd: rawnand: gpmi: Remove explicit default gpmi clock setting for i.MX6 Stefan Riedmueller
2021-10-12 9:02 ` [RFC PATCH 2/2] gpmi-nand: Add ERR007117 protection for nfc_apply_timings Stefan Riedmueller
2021-10-13 5:01 ` Han Xu
2021-10-22 8:45 ` Stefan Riedmüller
2021-10-22 14:35 ` han.xu
2021-10-25 9:39 ` Stefan Riedmüller [this message]
2021-10-28 9:28 ` Stefan Riedmüller
2021-11-01 4:01 ` han.xu
2021-10-13 6:10 ` Christian Eggers
2021-10-13 6:00 ` [RFC PATCH 1/2] mtd: rawnand: gpmi: Remove explicit default gpmi clock setting for i.MX6 Christian Eggers
2021-10-09 6:26 ` GPMI iMX6ull timeout on DMA Christian Eggers
2021-10-13 6:15 ` Christian Eggers
2021-10-08 13:13 ` Christian Eggers
2021-10-08 13:30 ` Miquel Raynal
2021-10-09 6:33 ` Christian Eggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a14524533eccd185224e1c2ec61895e1dbbf7ff8.camel@phytec.de \
--to=s.riedmueller@phytec.de \
--cc=C.Hemp@phytec.de \
--cc=bbrezillon@kernel.org \
--cc=ceggers@arri.de \
--cc=gerg@kernel.org \
--cc=han.xu@nxp.com \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@amarulasolutions.com \
--cc=miquel.raynal@bootlin.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).