netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Thomas Schreiber" <tschreibe@gmail.com>,
	"Russell King - ARM Linux admin" <linux@armlinux.org.uk>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Marek Behún" <kabel@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips
Date: Wed, 6 Jan 2021 15:55:32 +0100	[thread overview]
Message-ID: <20210106145532.xynhoufpfyzmurd5@pali> (raw)
In-Reply-To: <20210103024132.fpvjumilazrxiuzj@pali>

On Sunday 03 January 2021 03:41:32 Pali Rohár wrote:
> Hello!
> 
> On Sunday 03 January 2021 03:25:23 Thomas Schreiber wrote:
> > Hi Pali,
> > I have a CarlitoxxPro module and I reported an issue about RX_LOS pin
> > to the manufacturer.
> > It looks to me that the module asserts "inverted LOS" through EEPROM
> > but does not implement it.
> 
> So, it is broken :-( But I'm not surprised.
> 
> Anyway, I think you could be interested in this discussion about my
> patch series, but I forgot to CC you on the first patch/cover letter.
> You can read whole discussion on public archive available at:
> 
> https://lore.kernel.org/netdev/20201230154755.14746-1-pali@kernel.org/t/#u
> 
> If you have any comments, let me know so I can fix it for V2.
> 
> Those RTL8672/RTL9601C SFP are extremely broken and I do not think that
> "rebrander" CarlitoxxPro would do anything with it.
> 
> > Consequently, the SFP state machine of my
> > host router stays in check los state and link is not set up for the
> > host interface.
> 
> So link does not work at all?
> 
> > Below is a dump of the module's EEPROM:
> > 
> > [root@clearfog-gt-8k ~]# ethtool -m eth0
> > Identifier                                : 0x03 (SFP)
> > Extended identifier                       : 0x04 (GBIC/SFP defined by
> > 2-wire interface ID)
> > Connector                                 : 0x01 (SC)
> > Transceiver codes                         : 0x00 0x00 0x00 0x00 0x00
> > 0x00 0x00 0x00 0x00
> > Encoding                                  : 0x03 (NRZ)
> > BR, Nominal                               : 1200MBd
> > Rate identifier                           : 0x00 (unspecified)
> > Length (SMF,km)                           : 20km
> > Length (SMF)                              : 20000m
> > Length (50um)                             : 0m
> > Length (62.5um)                           : 0m
> > Length (Copper)                           : 0m
> > Length (OM3)                              : 0m
> > Laser wavelength                          : 1310nm
> > Vendor name                               : VSOL
> > Vendor OUI                                : 00:00:00
> > Vendor PN                                 : V2801F
> > Vendor rev                                : 1.0
> > Option values                             : 0x00 0x1c
> > Option                                    : RX_LOS implemented, inverted
> > Option                                    : TX_FAULT implemented
> > Option                                    : TX_DISABLE implemented
> > BR margin, max                            : 0%
> > BR margin, min                            : 0%
> > Vendor SN                                 : CP202003180377
> > Date code                                 : 200408
> > Optical diagnostics support               : Yes
> > Laser bias current                        : 0.000 mA
> > Laser output power                        : 0.0000 mW / -inf dBm
> > Receiver signal average optical power     : 0.0000 mW / -inf dBm
> > Module temperature                        : 31.00 degrees C / 87.80 degrees F
> > Module voltage                            : 0.0000 V
> > Alarm/warning flags implemented           : Yes
> > Laser bias current high alarm             : Off
> > Laser bias current low alarm              : On
> > Laser bias current high warning           : Off
> > Laser bias current low warning            : Off
> > Laser output power high alarm             : Off
> > Laser output power low alarm              : On
> > Laser output power high warning           : Off
> > Laser output power low warning            : Off
> > Module temperature high alarm             : Off
> > Module temperature low alarm              : Off
> > Module temperature high warning           : Off
> > Module temperature low warning            : Off
> > Module voltage high alarm                 : Off
> > Module voltage low alarm                  : Off
> > Module voltage high warning               : Off
> > Module voltage low warning                : Off
> > Laser rx power high alarm                 : Off
> > Laser rx power low alarm                  : Off
> > Laser rx power high warning               : Off
> > Laser rx power low warning                : Off
> > Laser bias current high alarm threshold   : 74.752 mA
> > Laser bias current low alarm threshold    : 0.000 mA
> > Laser bias current high warning threshold : 0.000 mA
> > Laser bias current low warning threshold  : 0.000 mA
> > Laser output power high alarm threshold   : 0.0000 mW / -inf dBm
> > Laser output power low alarm threshold    : 0.0000 mW / -inf dBm
> > Laser output power high warning threshold : 0.0000 mW / -inf dBm
> > Laser output power low warning threshold  : 0.0000 mW / -inf dBm
> > Module temperature high alarm threshold   : 90.00 degrees C / 194.00 degrees F
> > Module temperature low alarm threshold    : 0.00 degrees C / 32.00 degrees F
> > Module temperature high warning threshold : 0.00 degrees C / 32.00 degrees F
> > Module temperature low warning threshold  : 0.00 degrees C / 32.00 degrees F
> > Module voltage high alarm threshold       : 0.0000 V
> > Module voltage low alarm threshold        : 0.0000 V
> > Module voltage high warning threshold     : 0.0000 V
> > Module voltage low warning threshold      : 0.0000 V
> > Laser rx power high alarm threshold       : 0.1536 mW / -8.14 dBm
> > Laser rx power low alarm threshold        : 0.0000 mW / -inf dBm
> > Laser rx power high warning threshold     : 0.0000 mW / -inf dBm
> > Laser rx power low warning threshold      : 0.0000 mW / -inf dBm
> > 
> > 
> > Le sam. 2 janv. 2021 à 02:49, Pali Rohár <pali@kernel.org> a écrit :
> > >
> > > On Thursday 31 December 2020 18:13:38 Andrew Lunn wrote:
> > > > > > Looking at sfp_module_info(), adding a check for i2c_block_size < 2
> > > > > > when determining what length to return. ethtool should do the right
> > > > > > thing, know that the second page has not been returned to user space.
> > > > >
> > > > > But if we limit length of eeprom then userspace would not be able to
> > > > > access those TX_DISABLE, LOS and other bits from byte 110 at address A2.
> > > >
> > > > Have you tested these bits to see if they actually work? If they don't
> > > > work...
> > >
> > > On Ubiquiti module that LOS bit does not work.
> > >
> > > I think that on CarlitoxxPro module LOS bit worked. But I cannot test it
> > > right now as I do not have access to testing OLT unit.

On my tested CarlitoxxPro module is:

        Option values                             : 0x00 0x1c
        Option                                    : RX_LOS implemented, inverted
        Option                                    : TX_FAULT implemented
        Option                                    : TX_DISABLE implemented

When cable is disconnected then in EEPROM at position 0x16e is value
0x82. If I call 'ip link set eth1 up' then value changes to 0x02, module
itself has a link and I can connect to its internal telnet/webserver to
configure it.

When cable is connected but connection is not established by OLT then
this value is 0x80. If I call 'ip link set eth1 up' then value changes
to 0x00 and kernel does not see a link (no carrier).

So it seems that RX_LOS (bit 1 of 0x16e EEPROM) and also TX_DISABLE (bit
7 of 0x16e EEPROM) is implemented and working properly.

And therefore we should allow access to these bits.


I also tested UBNT module and result is:

        Option values                             : 0x00 0x06
        Option                                    : RX_LOS implemented
        Option                                    : RX_LOS implemented, inverted

Which means that those bits are not implemented.

Anyway I check position 0x16e and value on its value is randomly either
0x79 or 0xff independently of the state of the GPON module.

So it is really not implemented on UBNT.

> > > Adding Thomas to loop. Can you check if CarlitoxxPro GPON ONT module
> > > supports LOS or other bits at byte offset 110 at address A2?

  reply	other threads:[~2021-01-06 14:56 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-30 15:47 [PATCH 0/4] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár
2020-12-30 15:47 ` [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár
2020-12-30 16:10   ` Russell King - ARM Linux admin
2020-12-30 16:56     ` Pali Rohár
2020-12-30 17:05       ` Russell King - ARM Linux admin
2020-12-30 17:13         ` Andrew Lunn
2020-12-30 17:43           ` Pali Rohár
2020-12-30 19:09             ` Russell King - ARM Linux admin
2020-12-30 19:49               ` Andrew Lunn
2020-12-31 12:14               ` Pali Rohár
2020-12-31 15:09                 ` Andrew Lunn
2020-12-31 15:40                   ` Pali Rohár
2020-12-31 15:30                 ` Andrew Lunn
2020-12-31 17:00                   ` Pali Rohár
2020-12-31 17:13                     ` Andrew Lunn
2021-01-02  1:49                       ` Pali Rohár
2021-01-03  2:25                         ` Thomas Schreiber
2021-01-03  2:41                           ` Pali Rohár
2021-01-06 14:55                             ` Pali Rohár [this message]
2021-01-06 15:21                               ` Russell King - ARM Linux admin
2021-01-06 15:23                                 ` Russell King - ARM Linux admin
2021-01-06 15:27                                   ` Russell King - ARM Linux admin
2021-01-06 15:35                                     ` Pali Rohár
2020-12-30 19:30             ` Andrew Lunn
2020-12-30 19:39               ` Russell King - ARM Linux admin
2020-12-30 17:31         ` Pali Rohár
2020-12-30 19:18           ` Russell King - ARM Linux admin
2020-12-30 15:47 ` [PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF Pali Rohár
2020-12-30 16:11   ` Russell King - ARM Linux admin
2020-12-30 17:06     ` Pali Rohár
2020-12-30 17:27       ` Marek Behún
2020-12-30 19:12         ` Russell King - ARM Linux admin
2020-12-31 13:52           ` Pali Rohár
2020-12-30 15:47 ` [PATCH 3/4] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set Pali Rohár
2020-12-30 16:13   ` Russell King - ARM Linux admin
2020-12-30 16:57     ` Pali Rohár
2020-12-30 17:06       ` Russell King - ARM Linux admin
2020-12-30 17:17         ` Andrew Lunn
2020-12-30 17:32           ` Pali Rohár
2020-12-30 15:47 ` [PATCH 4/4] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Pali Rohár
2021-01-06 15:37 ` [PATCH v2 0/3] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár
2021-01-06 15:37   ` [PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár
2021-01-07  2:02     ` Andrew Lunn
2021-01-07  9:08       ` Pali Rohár
2021-01-07 17:19     ` Andrew Lunn
2021-01-07 17:40       ` Russell King - ARM Linux admin
2021-01-07 19:18         ` Pali Rohár
2021-01-07 19:17       ` Pali Rohár
2021-01-07 19:45       ` Russell King - ARM Linux admin
2021-01-07 20:21         ` Marek Behún
2021-01-08  0:49           ` Pali Rohár
2021-01-06 15:37   ` [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set Pali Rohár
2021-01-07 16:54     ` Andrew Lunn
2021-01-09 15:46       ` Russell King - ARM Linux admin
2021-01-09 15:54         ` Andrew Lunn
2021-01-09 16:27           ` Russell King - ARM Linux admin
2021-01-09 19:14         ` Pali Rohár
2021-01-09 23:19           ` Russell King - ARM Linux admin
2021-01-09 23:50             ` Pali Rohár
2021-01-06 15:37   ` [PATCH v2 3/3] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Pali Rohár
2021-01-07 16:51     ` Andrew Lunn
2021-01-11 11:39 ` [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár
2021-01-11 11:39   ` [PATCH v3 1/2] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár
2021-01-11 15:28     ` Marek Behún
2021-01-11 11:39   ` [PATCH v3 2/2] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Pali Rohár
2021-01-11 15:32     ` Marek Behún
2021-01-12 13:33   ` [PATCH v3 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber Pali Rohár
2021-01-18  9:34   ` Pali Rohár
2021-01-25 14:09     ` Pali Rohár
2021-01-25 14:16       ` Russell King - ARM Linux admin
2021-01-25 14:23         ` Pali Rohár
2021-01-25 14:42           ` Russell King - ARM Linux admin
2021-01-25 14:47             ` Pali Rohár
2021-01-25 15:41               ` Andrew Lunn
2021-01-25 15:02 ` [PATCH v4 " Pali Rohár
2021-01-25 15:02   ` [PATCH v4 1/2] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips Pali Rohár
2021-01-25 15:02   ` [PATCH v4 2/2] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant Pali Rohár
2021-01-28 21:50   ` [PATCH v4 0/2] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210106145532.xynhoufpfyzmurd5@pali \
    --to=pali@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kabel@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=tschreibe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).