From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Si-Wei Liu <si-wei.liu@oracle.com>
Cc: elic@nvidia.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero
Date: Mon, 1 Mar 2021 11:56:50 +0800
Message-ID: <2cb51a6d-afa0-7cd1-d6f2-6b153186eaca@redhat.com> (raw)
In-Reply-To: <20210228163031-mutt-send-email-mst@kernel.org>
On 2021/3/1 5:34 上午, Michael S. Tsirkin wrote:
> On Wed, Feb 24, 2021 at 10:24:41AM -0800, Si-Wei Liu wrote:
>>> Detecting it isn't enough though, we will need a new ioctl to notify
>>> the kernel that it's a legacy guest. Ugh :(
>> Well, although I think adding an ioctl is doable, may I know what the use
>> case there will be for kernel to leverage such info directly? Is there a
>> case QEMU can't do with dedicate ioctls later if there's indeed
>> differentiation (legacy v.s. modern) needed?
> BTW a good API could be
>
> #define VHOST_SET_ENDIAN _IOW(VHOST_VIRTIO, ?, int)
> #define VHOST_GET_ENDIAN _IOW(VHOST_VIRTIO, ?, int)
>
> we did it per vring but maybe that was a mistake ...
Actually, I wonder whether it's good time to just not support legacy
driver for vDPA. Consider:
1) It's definition is no-normative
2) A lot of budren of codes
So qemu can still present the legacy device since the config space or
other stuffs that is presented by vhost-vDPA is not expected to be
accessed by guest directly. Qemu can do the endian conversion when
necessary in this case?
Thanks
>
next prev parent reply index
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 11:54 Si-Wei Liu
2021-02-21 14:44 ` Eli Cohen
2021-02-21 21:52 ` Michael S. Tsirkin
2021-02-22 6:05 ` Eli Cohen
2021-02-23 9:26 ` Michael S. Tsirkin
2021-02-23 9:48 ` Jason Wang
2021-02-23 9:55 ` Michael S. Tsirkin
2021-02-22 4:14 ` Jason Wang
2021-02-22 7:34 ` Michael S. Tsirkin
2021-02-23 1:12 ` Si-Wei Liu
2021-02-23 2:03 ` Jason Wang
2021-02-23 13:26 ` Michael S. Tsirkin
2021-02-23 19:35 ` Si-Wei Liu
2021-02-24 3:20 ` Jason Wang
2021-02-24 5:17 ` Michael S. Tsirkin
2021-02-24 6:02 ` Jason Wang
2021-02-24 6:45 ` Eli Cohen
2021-02-24 6:47 ` Michael S. Tsirkin
2021-02-24 6:55 ` Jason Wang
2021-02-24 7:12 ` Michael S. Tsirkin
2021-02-24 12:40 ` Eli Cohen
2021-02-24 7:17 ` Eli Cohen
2021-02-24 5:04 ` Michael S. Tsirkin
2021-02-24 6:04 ` Jason Wang
2021-02-24 6:46 ` Michael S. Tsirkin
2021-02-24 6:53 ` Jason Wang
2021-02-24 7:17 ` Michael S. Tsirkin
[not found] ` <babc654d-8dcd-d8a2-c3b6-d20cc4fc554c@redhat.com>
2021-02-24 8:43 ` Michael S. Tsirkin
2021-02-24 9:30 ` Jason Wang
2021-02-28 21:30 ` Michael S. Tsirkin
2021-03-01 3:53 ` Jason Wang
2021-02-24 18:24 ` Si-Wei Liu
2021-02-26 0:56 ` Si-Wei Liu
2021-02-28 21:27 ` Michael S. Tsirkin
2021-03-01 18:08 ` Si-Wei Liu
2021-02-28 21:28 ` Michael S. Tsirkin
2021-02-28 21:34 ` Michael S. Tsirkin
2021-03-01 3:56 ` Jason Wang [this message]
2021-03-02 9:47 ` Michael S. Tsirkin
2021-03-02 10:53 ` Jason Wang
2021-02-22 17:09 ` Si-Wei Liu
2021-02-23 2:03 ` Jason Wang
2021-02-23 9:25 ` Michael S. Tsirkin
2021-02-23 9:46 ` Jason Wang
2021-02-23 10:01 ` Michael S. Tsirkin
2021-02-23 10:17 ` Jason Wang
2021-02-24 9:40 ` Jason Wang
2021-02-23 10:04 ` [virtio-dev] " Cornelia Huck
2021-02-23 10:31 ` Jason Wang
2021-02-23 10:58 ` Cornelia Huck
2021-02-24 9:29 ` Jason Wang
2021-02-24 11:12 ` Cornelia Huck
2021-02-25 4:36 ` Jason Wang
2021-02-25 13:26 ` Cornelia Huck
2021-02-25 18:53 ` Michael S. Tsirkin
2021-02-26 8:19 ` Jason Wang
2021-02-28 21:25 ` Michael S. Tsirkin
2021-03-01 3:51 ` Jason Wang
2021-03-02 12:08 ` Cornelia Huck
[not found] ` <5f6972fe-7246-b622-958d-9cab8dd98e21@redhat.com>
2021-03-03 8:29 ` Cornelia Huck
2021-03-04 8:24 ` Jason Wang
2021-03-04 13:50 ` Cornelia Huck
2021-03-05 3:01 ` Jason Wang
2021-02-23 12:26 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cb51a6d-afa0-7cd1-d6f2-6b153186eaca@redhat.com \
--to=jasowang@redhat.com \
--cc=elic@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Netdev Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
netdev@vger.kernel.org
public-inbox-index netdev
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.netdev
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git