From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Si-Wei Liu <si-wei.liu@oracle.com>, Eli Cohen <elic@nvidia.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: vdpa legacy guest support (was Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero)
Date: Fri, 17 Dec 2021 10:15:14 +0800 [thread overview]
Message-ID: <CACGkMEs8_oUk+5ywh08_RQb4A1qOg6N8hK=vZxQ5xOkvE_CPsg@mail.gmail.com> (raw)
In-Reply-To: <20211216205958-mutt-send-email-mst@kernel.org>
On Fri, Dec 17, 2021 at 10:01 AM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Fri, Dec 17, 2021 at 09:57:38AM +0800, Jason Wang wrote:
> > On Fri, Dec 17, 2021 at 6:32 AM Si-Wei Liu <si-wei.liu@oracle.com> wrote:
> > >
> > >
> > >
> > > On 12/15/2021 6:53 PM, Jason Wang wrote:
> > > > On Thu, Dec 16, 2021 at 10:02 AM Si-Wei Liu <si-wei.liu@oracle.com> wrote:
> > > >>
> > > >>
> > > >> On 12/15/2021 1:33 PM, Michael S. Tsirkin wrote:
> > > >>> On Wed, Dec 15, 2021 at 12:52:20PM -0800, Si-Wei Liu wrote:
> > > >>>> On 12/14/2021 6:06 PM, Jason Wang wrote:
> > > >>>>> On Wed, Dec 15, 2021 at 9:05 AM Si-Wei Liu <si-wei.liu@oracle.com> wrote:
> > > >>>>>> On 12/13/2021 9:06 PM, Michael S. Tsirkin wrote:
> > > >>>>>>> On Mon, Dec 13, 2021 at 05:59:45PM -0800, Si-Wei Liu wrote:
> > > >>>>>>>> On 12/12/2021 1:26 AM, Michael S. Tsirkin wrote:
> > > >>>>>>>>> On Fri, Dec 10, 2021 at 05:44:15PM -0800, Si-Wei Liu wrote:
> > > >>>>>>>>>> Sorry for reviving this ancient thread. I was kinda lost for the conclusion
> > > >>>>>>>>>> it ended up with. I have the following questions,
> > > >>>>>>>>>>
> > > >>>>>>>>>> 1. legacy guest support: from the past conversations it doesn't seem the
> > > >>>>>>>>>> support will be completely dropped from the table, is my understanding
> > > >>>>>>>>>> correct? Actually we're interested in supporting virtio v0.95 guest for x86,
> > > >>>>>>>>>> which is backed by the spec at
> > > >>>>>>>>>> https://urldefense.com/v3/__https://ozlabs.org/*rusty/virtio-spec/virtio-0.9.5.pdf__;fg!!ACWV5N9M2RV99hQ!dTKmzJwwRsFM7BtSuTDu1cNly5n4XCotH0WYmidzGqHSXt40i7ZU43UcNg7GYxZg$ . Though I'm not sure
> > > >>>>>>>>>> if there's request/need to support wilder legacy virtio versions earlier
> > > >>>>>>>>>> beyond.
> > > >>>>>>>>> I personally feel it's less work to add in kernel than try to
> > > >>>>>>>>> work around it in userspace. Jason feels differently.
> > > >>>>>>>>> Maybe post the patches and this will prove to Jason it's not
> > > >>>>>>>>> too terrible?
> > > >>>>>>>> I suppose if the vdpa vendor does support 0.95 in the datapath and ring
> > > >>>>>>>> layout level and is limited to x86 only, there should be easy way out.
> > > >>>>>>> Note a subtle difference: what matters is that guest, not host is x86.
> > > >>>>>>> Matters for emulators which might reorder memory accesses.
> > > >>>>>>> I guess this enforcement belongs in QEMU then?
> > > >>>>>> Right, I mean to get started, the initial guest driver support and the
> > > >>>>>> corresponding QEMU support for transitional vdpa backend can be limited
> > > >>>>>> to x86 guest/host only. Since the config space is emulated in QEMU, I
> > > >>>>>> suppose it's not hard to enforce in QEMU.
> > > >>>>> It's more than just config space, most devices have headers before the buffer.
> > > >>>> The ordering in datapath (data VQs) would have to rely on vendor's support.
> > > >>>> Since ORDER_PLATFORM is pretty new (v1.1), I guess vdpa h/w vendor nowadays
> > > >>>> can/should well support the case when ORDER_PLATFORM is not acked by the
> > > >>>> driver (actually this feature is filtered out by the QEMU vhost-vdpa driver
> > > >>>> today), even with v1.0 spec conforming and modern only vDPA device. The
> > > >>>> control VQ is implemented in software in the kernel, which can be easily
> > > >>>> accommodated/fixed when needed.
> > > >>>>
> > > >>>>>> QEMU can drive GET_LEGACY,
> > > >>>>>> GET_ENDIAN et al ioctls in advance to get the capability from the
> > > >>>>>> individual vendor driver. For that, we need another negotiation protocol
> > > >>>>>> similar to vhost_user's protocol_features between the vdpa kernel and
> > > >>>>>> QEMU, way before the guest driver is ever probed and its feature
> > > >>>>>> negotiation kicks in. Not sure we need a GET_MEMORY_ORDER ioctl call
> > > >>>>>> from the device, but we can assume weak ordering for legacy at this
> > > >>>>>> point (x86 only)?
> > > >>>>> I'm lost here, we have get_features() so:
> > > >>>> I assume here you refer to get_device_features() that Eli just changed the
> > > >>>> name.
> > > >>>>> 1) VERSION_1 means the device uses LE if provided, otherwise natvie
> > > >>>>> 2) ORDER_PLATFORM means device requires platform ordering
> > > >>>>>
> > > >>>>> Any reason for having a new API for this?
> > > >>>> Are you going to enforce all vDPA hardware vendors to support the
> > > >>>> transitional model for legacy guest?
> > > > Do we really have other choices?
> > > >
> > > > I suspect the legacy device is never implemented by any vendor:
> > > >
> > > > 1) no virtio way to detect host endian
> > > This is even true for transitional device that is conforming to the
> > > spec, right?
> >
> > For hardware, yes.
> >
> > > The transport specific way to detect host endian is still
> > > being discussed and the spec revision is not finalized yet so far as I
> > > see. Why this suddenly becomes a requirement/blocker for h/w vendors to
> > > implement the transitional model?
> >
> > It's not a sudden blocker, the problem has existed since day 0 if I
> > was not wrong. That's why the problem looks a little bit complicated
> > and why it would be much simpler if we stick to modern devices.
> >
> > > Even if the spec is out, this is
> > > pretty new and I suspect not all vendor would follow right away. I hope
> > > the software framework can be tolerant with h/w vendors not supporting
> > > host endianess (BE specifically) or not detecting it if they would like
> > > to support a transitional device for legacy.
> >
> > Well, if we know we don't want to support the BE host it would be fine.
>
> I think you guys mean guest not host here. Same for memory ordering etc.
> What matters is whether guest has barriers etc.
>
Yes.
Thanks
next prev parent reply other threads:[~2021-12-17 2:15 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 11:54 [PATCH] vdpa/mlx5: set_features should allow reset to zero Si-Wei Liu
2021-02-21 14:44 ` Eli Cohen
2021-02-21 21:52 ` Michael S. Tsirkin
2021-02-22 6:05 ` Eli Cohen
2021-02-23 9:26 ` Michael S. Tsirkin
2021-02-23 9:48 ` Jason Wang
2021-02-23 9:55 ` Michael S. Tsirkin
2021-02-22 4:14 ` Jason Wang
2021-02-22 7:34 ` Michael S. Tsirkin
2021-02-23 1:12 ` Si-Wei Liu
2021-02-23 2:03 ` Jason Wang
2021-02-23 13:26 ` Michael S. Tsirkin
2021-02-23 19:35 ` Si-Wei Liu
2021-02-24 3:20 ` Jason Wang
2021-02-24 5:17 ` Michael S. Tsirkin
2021-02-24 6:02 ` Jason Wang
2021-02-24 6:45 ` Eli Cohen
2021-02-24 6:47 ` Michael S. Tsirkin
2021-02-24 6:55 ` Jason Wang
2021-02-24 7:12 ` Michael S. Tsirkin
2021-02-24 12:40 ` Eli Cohen
2021-02-24 7:17 ` Eli Cohen
2021-02-24 5:04 ` Michael S. Tsirkin
2021-02-24 6:04 ` Jason Wang
2021-02-24 6:46 ` Michael S. Tsirkin
2021-02-24 6:53 ` Jason Wang
2021-02-24 7:17 ` Michael S. Tsirkin
[not found] ` <babc654d-8dcd-d8a2-c3b6-d20cc4fc554c@redhat.com>
2021-02-24 8:43 ` Michael S. Tsirkin
2021-02-24 9:30 ` Jason Wang
2021-02-28 21:30 ` Michael S. Tsirkin
2021-03-01 3:53 ` Jason Wang
2021-02-24 18:24 ` Si-Wei Liu
2021-02-26 0:56 ` Si-Wei Liu
2021-02-28 21:27 ` Michael S. Tsirkin
2021-03-01 18:08 ` Si-Wei Liu
2021-02-28 21:28 ` Michael S. Tsirkin
2021-02-28 21:34 ` Michael S. Tsirkin
2021-03-01 3:56 ` Jason Wang
2021-03-02 9:47 ` Michael S. Tsirkin
2021-03-02 10:53 ` Jason Wang
2021-12-11 1:44 ` vdpa legacy guest support (was Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero) Si-Wei Liu
2021-12-12 9:26 ` Michael S. Tsirkin
2021-12-13 3:02 ` Jason Wang
2021-12-13 8:06 ` Michael S. Tsirkin
2021-12-13 8:57 ` Jason Wang
2021-12-13 10:42 ` Michael S. Tsirkin
2021-12-14 1:13 ` Si-Wei Liu
2021-12-14 1:59 ` Si-Wei Liu
2021-12-14 3:01 ` Jason Wang
2021-12-14 5:06 ` Michael S. Tsirkin
2021-12-15 1:05 ` Si-Wei Liu
2021-12-15 2:06 ` Jason Wang
2021-12-15 20:52 ` Si-Wei Liu
2021-12-15 21:33 ` Michael S. Tsirkin
2021-12-16 2:01 ` Si-Wei Liu
2021-12-16 2:53 ` Jason Wang
2021-12-16 22:32 ` Si-Wei Liu
2021-12-17 1:57 ` Jason Wang
2021-12-17 2:00 ` Michael S. Tsirkin
2021-12-17 2:15 ` Jason Wang [this message]
2021-12-16 6:35 ` Michael S. Tsirkin
2021-12-16 3:43 ` Jason Wang
2021-12-17 1:08 ` Si-Wei Liu
2021-12-17 2:01 ` Jason Wang
2021-02-22 17:09 ` [PATCH] vdpa/mlx5: set_features should allow reset to zero Si-Wei Liu
2021-02-23 2:03 ` Jason Wang
2021-02-23 9:25 ` Michael S. Tsirkin
2021-02-23 9:46 ` Jason Wang
2021-02-23 10:01 ` Michael S. Tsirkin
2021-02-23 10:17 ` Jason Wang
2021-02-24 9:40 ` Jason Wang
2021-02-23 10:04 ` [virtio-dev] " Cornelia Huck
2021-02-23 10:31 ` Jason Wang
2021-02-23 10:58 ` Cornelia Huck
2021-02-24 9:29 ` Jason Wang
2021-02-24 11:12 ` Cornelia Huck
2021-02-25 4:36 ` Jason Wang
2021-02-25 13:26 ` Cornelia Huck
2021-02-25 18:53 ` Michael S. Tsirkin
2021-02-26 8:19 ` Jason Wang
2021-02-28 21:25 ` Michael S. Tsirkin
2021-03-01 3:51 ` Jason Wang
2021-03-02 12:08 ` Cornelia Huck
[not found] ` <5f6972fe-7246-b622-958d-9cab8dd98e21@redhat.com>
2021-03-03 8:29 ` Cornelia Huck
2021-03-04 8:24 ` Jason Wang
2021-03-04 13:50 ` Cornelia Huck
2021-03-05 3:01 ` Jason Wang
2021-02-23 12:26 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACGkMEs8_oUk+5ywh08_RQb4A1qOg6N8hK=vZxQ5xOkvE_CPsg@mail.gmail.com' \
--to=jasowang@redhat.com \
--cc=elic@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).