From: Huang Shijie <b32955@freescale.com>
To: Marek Vasut <marex@denx.de>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
linux-mtd@lists.infradead.org, linux-doc@vger.kernel.org,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, "dzu@denx.de" <dzu@denx.de>
Subject: Re: [PATCH v2 02/10] mtd: spi-nor: add a new field for spi_nor{}
Date: Tue, 29 Apr 2014 14:05:04 +0800 [thread overview]
Message-ID: <20140429060502.GA14227@localhost> (raw)
In-Reply-To: <201404290854.25116.marex@denx.de>
On Tue, Apr 29, 2014 at 08:54:24AM +0200, Marek Vasut wrote:
> On Tuesday, April 29, 2014 at 07:18:34 AM, Huang Shijie wrote:
> > For the m25p80.c, @dev stands for a child node for the SPI master,
> > and it points to a spi_device{}. Yes, in this case, the dev->of_node is
> > NULL.
> >
> > But for the fsl_quadspi or other SPI NOR drivers, the @dev stands for the
> > controller itself, the @dev->of_node is a list of the child nodes, so we
> > can _NOT_ know which child node we are working at now.
>
> Huh ? The dev is being recycled for two different kind of things ?
yes.
for the SPI bus, the of_register_spi_devices() will allocate a spi_device{}
for each child node for the SPI NOR flash. So in the m25p80.c, the @dev points
to a spi_device{}.
For the simplicity, we do not allocate any *_device{} for the child
node in the SPI NOR flash driver, such as in the fsl-quadspi.c.
thanks
Huang Shijie
WARNING: multiple messages have this Message-ID (diff)
From: Huang Shijie <b32955@freescale.com>
To: Marek Vasut <marex@denx.de>
Cc: <dwmw2@infradead.org>, <computersforpeace@gmail.com>,
<linux-mtd@lists.infradead.org>, <linux-doc@vger.kernel.org>,
<linux-spi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, "dzu@denx.de" <dzu@denx.de>
Subject: Re: [PATCH v2 02/10] mtd: spi-nor: add a new field for spi_nor{}
Date: Tue, 29 Apr 2014 14:05:04 +0800 [thread overview]
Message-ID: <20140429060502.GA14227@localhost> (raw)
In-Reply-To: <201404290854.25116.marex@denx.de>
On Tue, Apr 29, 2014 at 08:54:24AM +0200, Marek Vasut wrote:
> On Tuesday, April 29, 2014 at 07:18:34 AM, Huang Shijie wrote:
> > For the m25p80.c, @dev stands for a child node for the SPI master,
> > and it points to a spi_device{}. Yes, in this case, the dev->of_node is
> > NULL.
> >
> > But for the fsl_quadspi or other SPI NOR drivers, the @dev stands for the
> > controller itself, the @dev->of_node is a list of the child nodes, so we
> > can _NOT_ know which child node we are working at now.
>
> Huh ? The dev is being recycled for two different kind of things ?
yes.
for the SPI bus, the of_register_spi_devices() will allocate a spi_device{}
for each child node for the SPI NOR flash. So in the m25p80.c, the @dev points
to a spi_device{}.
For the simplicity, we do not allocate any *_device{} for the child
node in the SPI NOR flash driver, such as in the fsl-quadspi.c.
thanks
Huang Shijie
WARNING: multiple messages have this Message-ID (diff)
From: Huang Shijie <b32955@freescale.com>
To: Marek Vasut <marex@denx.de>
Cc: devicetree@vger.kernel.org, "dzu@denx.de" <dzu@denx.de>,
linux-doc@vger.kernel.org, linux-spi@vger.kernel.org,
linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 02/10] mtd: spi-nor: add a new field for spi_nor{}
Date: Tue, 29 Apr 2014 14:05:04 +0800 [thread overview]
Message-ID: <20140429060502.GA14227@localhost> (raw)
In-Reply-To: <201404290854.25116.marex@denx.de>
On Tue, Apr 29, 2014 at 08:54:24AM +0200, Marek Vasut wrote:
> On Tuesday, April 29, 2014 at 07:18:34 AM, Huang Shijie wrote:
> > For the m25p80.c, @dev stands for a child node for the SPI master,
> > and it points to a spi_device{}. Yes, in this case, the dev->of_node is
> > NULL.
> >
> > But for the fsl_quadspi or other SPI NOR drivers, the @dev stands for the
> > controller itself, the @dev->of_node is a list of the child nodes, so we
> > can _NOT_ know which child node we are working at now.
>
> Huh ? The dev is being recycled for two different kind of things ?
yes.
for the SPI bus, the of_register_spi_devices() will allocate a spi_device{}
for each child node for the SPI NOR flash. So in the m25p80.c, the @dev points
to a spi_device{}.
For the simplicity, we do not allocate any *_device{} for the child
node in the SPI NOR flash driver, such as in the fsl-quadspi.c.
thanks
Huang Shijie
WARNING: multiple messages have this Message-ID (diff)
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 02/10] mtd: spi-nor: add a new field for spi_nor{}
Date: Tue, 29 Apr 2014 14:05:04 +0800 [thread overview]
Message-ID: <20140429060502.GA14227@localhost> (raw)
In-Reply-To: <201404290854.25116.marex@denx.de>
On Tue, Apr 29, 2014 at 08:54:24AM +0200, Marek Vasut wrote:
> On Tuesday, April 29, 2014 at 07:18:34 AM, Huang Shijie wrote:
> > For the m25p80.c, @dev stands for a child node for the SPI master,
> > and it points to a spi_device{}. Yes, in this case, the dev->of_node is
> > NULL.
> >
> > But for the fsl_quadspi or other SPI NOR drivers, the @dev stands for the
> > controller itself, the @dev->of_node is a list of the child nodes, so we
> > can _NOT_ know which child node we are working at now.
>
> Huh ? The dev is being recycled for two different kind of things ?
yes.
for the SPI bus, the of_register_spi_devices() will allocate a spi_device{}
for each child node for the SPI NOR flash. So in the m25p80.c, the @dev points
to a spi_device{}.
For the simplicity, we do not allocate any *_device{} for the child
node in the SPI NOR flash driver, such as in the fsl-quadspi.c.
thanks
Huang Shijie
next prev parent reply other threads:[~2014-04-29 6:05 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 3:53 [PATCH v2 00/10] mtd: spi-nor: Add the DDR quad read support Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` [PATCH v2 03/10] mtd: spi-nor: add " Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 20:23 ` Marek Vasut
2014-04-28 20:23 ` Marek Vasut
2014-04-28 20:23 ` Marek Vasut
2014-07-30 5:08 ` Brian Norris
2014-07-30 5:08 ` Brian Norris
2014-07-30 5:08 ` Brian Norris
2014-07-30 6:44 ` Huang Shijie
2014-07-30 6:44 ` Huang Shijie
2014-07-30 6:44 ` Huang Shijie
2014-07-30 7:45 ` Brian Norris
2014-07-30 7:45 ` Brian Norris
2014-07-30 7:45 ` Brian Norris
2014-07-30 10:46 ` Mark Brown
2014-07-30 10:46 ` Mark Brown
2014-07-30 10:46 ` Mark Brown
2014-08-02 2:06 ` Brian Norris
2014-08-02 2:06 ` Brian Norris
2014-08-02 2:06 ` Brian Norris
2014-08-02 9:09 ` Geert Uytterhoeven
2014-08-02 9:09 ` Geert Uytterhoeven
2014-08-02 9:09 ` Geert Uytterhoeven
[not found] ` <CAMuHMdWxzKG1TTUVgYqfRP0Prp85HPwVxH7NQp7S-pNeLfFqjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-04 14:25 ` Mark Brown
2014-08-04 14:25 ` Mark Brown
2014-08-04 14:25 ` Mark Brown
2015-07-22 18:15 ` Zhi Li
2015-07-22 18:15 ` Zhi Li
2015-07-22 18:18 ` Zhi Li
2015-07-22 18:18 ` Zhi Li
2014-07-30 15:23 ` Huang Shijie
2014-07-30 15:23 ` Huang Shijie
2014-07-30 15:23 ` Huang Shijie
[not found] ` <1398657227-20721-1-git-send-email-b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-04-28 3:53 ` [PATCH v2 01/10] mtd: spi-nor: fix the wrong dummy value Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
[not found] ` <1398657227-20721-2-git-send-email-b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-04-28 20:22 ` Marek Vasut
2014-04-28 20:22 ` Marek Vasut
2014-04-28 20:22 ` Marek Vasut
2014-11-05 8:27 ` Brian Norris
2014-11-05 8:27 ` Brian Norris
2014-11-05 8:27 ` Brian Norris
2014-04-28 3:53 ` [PATCH v2 02/10] mtd: spi-nor: add a new field for spi_nor{} Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
[not found] ` <1398657227-20721-3-git-send-email-b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-04-28 20:23 ` Marek Vasut
2014-04-28 20:23 ` Marek Vasut
2014-04-28 20:23 ` Marek Vasut
[not found] ` <201404282223.26174.marex-ynQEQJNshbs@public.gmane.org>
2014-04-29 5:18 ` Huang Shijie
2014-04-29 5:18 ` Huang Shijie
2014-04-29 5:18 ` Huang Shijie
2014-04-29 5:18 ` Huang Shijie
2014-04-29 6:54 ` Marek Vasut
2014-04-29 6:54 ` Marek Vasut
2014-04-29 6:54 ` Marek Vasut
2014-04-29 6:05 ` Huang Shijie [this message]
2014-04-29 6:05 ` Huang Shijie
2014-04-29 6:05 ` Huang Shijie
2014-04-29 6:05 ` Huang Shijie
2014-04-28 3:53 ` [PATCH v2 04/10] Documentation: mtd: add a new document for SPI NOR flash Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` [PATCH v2 05/10] Documentation: fsl-quadspi: update the document Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` [PATCH v2 06/10] mtd: fsl-quadspi: use the information stored in spi-nor{} Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` [PATCH v2 07/10] mtd: fsl-quadspi: add the DDR quad read support for Spansion NOR Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` [PATCH v2 08/10] mtd: spi-nor: add more read transfer flags for n25q256a Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` [PATCH v2 09/10] mtd: spi-nor: add DDR quad read support for Micron Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` [PATCH v2 10/10] mtd: fsl-quadspi: " Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
2014-04-28 3:53 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429060502.GA14227@localhost \
--to=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=dzu@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.