Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

[Pavel Machek <pavel@suse.cz>]

Hi!

> > > > So let's come out and ban binary modules, rather than pussyfooting
> > > > around, if that's what we actually want to do.
> > > 
> > > Give people 12 months warning (time to work out what they're going to do,
> > > talk with the legal dept, etc) then make the kernel load only GPL-tagged
> > > modules.
> > > 
> > > I think I'd favour that.  It would aid those people who are trying to
> > > obtain device specs, and who are persuading organisations to GPL their drivers.
> > 
> > Ok, I have no objection to that at all.  I'll whip up such a patch in a
> > bit to spit out kernel log messages whenever such a module is loaded so
> > that people have some warning.
> 
> Here you go.  The wording for the feature-removal-schedule.txt file
> could probably be cleaned up.  Any suggestions would be welcome.
> 
> thanks,
> 
> greg k-h
> 
> -----------
> From: Greg Kroah-Hartmna <gregkh@suse.de>
> Subject: Notify non-GPL module loading will be going away in January 2008
> 
> Numerous kernel developers feel that loading non-GPL drivers into the
> kernel violates the license of the kernel and their copyright.  Because
> of this, a one year notice for everyone to address any non-GPL
> compatible modules has been set.
> 
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> 
> ---
>  Documentation/feature-removal-schedule.txt |    9 +++++++++
>  kernel/module.c                            |    6 +++++-
>  2 files changed, 14 insertions(+), 1 deletion(-)
> 
> --- gregkh-2.6.orig/Documentation/feature-removal-schedule.txt
> +++ gregkh-2.6/Documentation/feature-removal-schedule.txt
> @@ -281,3 +281,12 @@ Why:	Speedstep-centrino driver with ACPI
>  Who:	Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
>  
>  ---------------------------
> +
> +What:	non GPL licensed modules will able to be loaded successfully.
> +When:	January 2008
> +Why:	Numerous kernel developers feel that loading non-GPL drivers into the
> +	kernel violates the license of the kernel and their copyright.
> +
> +Who:	Greg Kroah-Hartman <greg@kroah.com> or <gregkh@suse.de>
> +
> +---------------------------
> --- gregkh-2.6.orig/kernel/module.c
> +++ gregkh-2.6/kernel/module.c
> @@ -1393,9 +1393,13 @@ static void set_license(struct module *m
>  		license = "unspecified";
>  
>  	if (!license_is_gpl_compatible(license)) {
> -		if (!(tainted & TAINT_PROPRIETARY_MODULE))
> +		if (!(tainted & TAINT_PROPRIETARY_MODULE)) {
>  			printk(KERN_WARNING "%s: module license '%s' taints "
>  				"kernel.\n", mod->name, license);
> +			printk(KERN_WARNING "%s: This module will not be able "
> +				"to be loaded after January 1, 2008 due to its "
> +				"license.\n", mod->name);
> +		}
>  		add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
>  	}
>  }

perhaps printk('Binary only modules are not allowed by kernel license,
but copyright law may still allow them in special cases. Be careful,
Greg is going tuo sue you at beggining of 2008 if you get it wrong.')
would be acceptable way to educate people?
							Pavel
-- 
Thanks for all the (sleeping) penguins.