From: "tip-bot2 for Alexey Budankov" <tip-bot2@linutronix.de> To: linux-tip-commits@vger.kernel.org Cc: Alexey Budankov <alexey.budankov@linux.intel.com>, James Morris <jamorris@linux.microsoft.com>, Will Deacon <will@kernel.org>, Alexei Starovoitov <ast@kernel.org>, Andi Kleen <ak@linux.intel.com>, Igor Lubashev <ilubashe@akamai.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Serge Hallyn <serge@hallyn.com>, Song Liu <songliubraving@fb.com>, Stephane Eranian <eranian@google.com>, Thomas Gleixner <tglx@linutronix.de>, intel-gfx@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-man@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, Arnaldo Carvalho de Melo <acme@redhat.com>, x86 <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org> Subject: [tip: perf/core] drivers/perf: Open access for CAP_PERFMON privileged process Date: Wed, 22 Apr 2020 12:17:33 -0000 [thread overview] Message-ID: <158755785322.28353.1027174524920122867.tip-bot2@tip-bot2> (raw) In-Reply-To: <4ec1d6f7-548c-8d1c-f84a-cebeb9674e4e@linux.intel.com> The following commit has been merged into the perf/core branch of tip: Commit-ID: cea7d0d4a59b4efd0e1fe067130b4c06ab4d412f Gitweb: https://git.kernel.org/tip/cea7d0d4a59b4efd0e1fe067130b4c06ab4d412f Author: Alexey Budankov <alexey.budankov@linux.intel.com> AuthorDate: Thu, 02 Apr 2020 11:51:21 +03:00 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitterDate: Thu, 16 Apr 2020 12:19:09 -03:00 drivers/perf: Open access for CAP_PERFMON privileged process Open access to monitoring for CAP_PERFMON privileged process. Providing the access under CAP_PERFMON capability singly, without the rest of CAP_SYS_ADMIN credentials, excludes chances to misuse the credentials and makes operation more secure. CAP_PERFMON implements the principle of least privilege for performance monitoring and observability operations (POSIX IEEE 1003.1e 2.2.2.39 principle of least privilege: A security design principle that states that a process or program be granted only those privileges (e.g., capabilities) necessary to accomplish its legitimate function, and only for the time that such privileges are actually required) For backward compatibility reasons access to the monitoring remains open for CAP_SYS_ADMIN privileged processes but CAP_SYS_ADMIN usage for secure monitoring is discouraged with respect to CAP_PERFMON capability. Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com> Reviewed-by: James Morris <jamorris@linux.microsoft.com> Acked-by: Will Deacon <will@kernel.org> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Andi Kleen <ak@linux.intel.com> Cc: Igor Lubashev <ilubashe@akamai.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Serge Hallyn <serge@hallyn.com> Cc: Song Liu <songliubraving@fb.com> Cc: Stephane Eranian <eranian@google.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: intel-gfx@lists.freedesktop.org Cc: linux-doc@vger.kernel.org Cc: linux-man@vger.kernel.org Cc: linux-security-module@vger.kernel.org Cc: selinux@vger.kernel.org Link: http://lore.kernel.org/lkml/4ec1d6f7-548c-8d1c-f84a-cebeb9674e4e@linux.intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- drivers/perf/arm_spe_pmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c index b72c048..0e0961a 100644 --- a/drivers/perf/arm_spe_pmu.c +++ b/drivers/perf/arm_spe_pmu.c @@ -274,7 +274,7 @@ static u64 arm_spe_event_to_pmscr(struct perf_event *event) if (!attr->exclude_kernel) reg |= BIT(SYS_PMSCR_EL1_E1SPE_SHIFT); - if (IS_ENABLED(CONFIG_PID_IN_CONTEXTIDR) && capable(CAP_SYS_ADMIN)) + if (IS_ENABLED(CONFIG_PID_IN_CONTEXTIDR) && perfmon_capable()) reg |= BIT(SYS_PMSCR_EL1_CX_SHIFT); return reg; @@ -700,7 +700,7 @@ static int arm_spe_pmu_event_init(struct perf_event *event) return -EOPNOTSUPP; reg = arm_spe_event_to_pmscr(event); - if (!capable(CAP_SYS_ADMIN) && + if (!perfmon_capable() && (reg & (BIT(SYS_PMSCR_EL1_PA_SHIFT) | BIT(SYS_PMSCR_EL1_CX_SHIFT) | BIT(SYS_PMSCR_EL1_PCT_SHIFT))))
WARNING: multiple messages have this Message-ID (diff)
From: "tip-bot2 for Alexey Budankov" <tip-bot2@linutronix.de> To: linux-tip-commits@vger.kernel.org Cc: linux-man@vger.kernel.org, Song Liu <songliubraving@fb.com>, Andi Kleen <ak@linux.intel.com>, linux-doc@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>, Jiri Olsa <jolsa@redhat.com>, Igor Lubashev <ilubashe@akamai.com>, Alexei Starovoitov <ast@kernel.org>, James Morris <jamorris@linux.microsoft.com>, LKML <linux-kernel@vger.kernel.org>, Arnaldo Carvalho de Melo <acme@redhat.com>, selinux@vger.kernel.org, linux-security-module@vger.kernel.org, Stephane Eranian <eranian@google.com>, Namhyung Kim <namhyung@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Will Deacon <will@kernel.org>, intel-gfx@lists.freedesktop.org, x86 <x86@kernel.org>, Serge Hallyn <serge@hallyn.com> Subject: [Intel-gfx] [tip: perf/core] drivers/perf: Open access for CAP_PERFMON privileged process Date: Wed, 22 Apr 2020 12:17:33 -0000 [thread overview] Message-ID: <158755785322.28353.1027174524920122867.tip-bot2@tip-bot2> (raw) In-Reply-To: <4ec1d6f7-548c-8d1c-f84a-cebeb9674e4e@linux.intel.com> The following commit has been merged into the perf/core branch of tip: Commit-ID: cea7d0d4a59b4efd0e1fe067130b4c06ab4d412f Gitweb: https://git.kernel.org/tip/cea7d0d4a59b4efd0e1fe067130b4c06ab4d412f Author: Alexey Budankov <alexey.budankov@linux.intel.com> AuthorDate: Thu, 02 Apr 2020 11:51:21 +03:00 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitterDate: Thu, 16 Apr 2020 12:19:09 -03:00 drivers/perf: Open access for CAP_PERFMON privileged process Open access to monitoring for CAP_PERFMON privileged process. Providing the access under CAP_PERFMON capability singly, without the rest of CAP_SYS_ADMIN credentials, excludes chances to misuse the credentials and makes operation more secure. CAP_PERFMON implements the principle of least privilege for performance monitoring and observability operations (POSIX IEEE 1003.1e 2.2.2.39 principle of least privilege: A security design principle that states that a process or program be granted only those privileges (e.g., capabilities) necessary to accomplish its legitimate function, and only for the time that such privileges are actually required) For backward compatibility reasons access to the monitoring remains open for CAP_SYS_ADMIN privileged processes but CAP_SYS_ADMIN usage for secure monitoring is discouraged with respect to CAP_PERFMON capability. Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com> Reviewed-by: James Morris <jamorris@linux.microsoft.com> Acked-by: Will Deacon <will@kernel.org> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Andi Kleen <ak@linux.intel.com> Cc: Igor Lubashev <ilubashe@akamai.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Serge Hallyn <serge@hallyn.com> Cc: Song Liu <songliubraving@fb.com> Cc: Stephane Eranian <eranian@google.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: intel-gfx@lists.freedesktop.org Cc: linux-doc@vger.kernel.org Cc: linux-man@vger.kernel.org Cc: linux-security-module@vger.kernel.org Cc: selinux@vger.kernel.org Link: http://lore.kernel.org/lkml/4ec1d6f7-548c-8d1c-f84a-cebeb9674e4e@linux.intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- drivers/perf/arm_spe_pmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c index b72c048..0e0961a 100644 --- a/drivers/perf/arm_spe_pmu.c +++ b/drivers/perf/arm_spe_pmu.c @@ -274,7 +274,7 @@ static u64 arm_spe_event_to_pmscr(struct perf_event *event) if (!attr->exclude_kernel) reg |= BIT(SYS_PMSCR_EL1_E1SPE_SHIFT); - if (IS_ENABLED(CONFIG_PID_IN_CONTEXTIDR) && capable(CAP_SYS_ADMIN)) + if (IS_ENABLED(CONFIG_PID_IN_CONTEXTIDR) && perfmon_capable()) reg |= BIT(SYS_PMSCR_EL1_CX_SHIFT); return reg; @@ -700,7 +700,7 @@ static int arm_spe_pmu_event_init(struct perf_event *event) return -EOPNOTSUPP; reg = arm_spe_event_to_pmscr(event); - if (!capable(CAP_SYS_ADMIN) && + if (!perfmon_capable() && (reg & (BIT(SYS_PMSCR_EL1_PA_SHIFT) | BIT(SYS_PMSCR_EL1_CX_SHIFT) | BIT(SYS_PMSCR_EL1_PCT_SHIFT)))) _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-04-22 12:20 UTC|newest] Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-02 8:42 [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability Alexey Budankov 2020-04-02 8:42 ` [Intel-gfx] " Alexey Budankov 2020-04-02 8:45 ` [PATCH v8 01/12] capabilities: introduce CAP_PERFMON to kernel and user space Alexey Budankov 2020-04-02 8:45 ` [Intel-gfx] " Alexey Budankov 2020-04-22 12:17 ` [tip: perf/core] capabilities: Introduce " tip-bot2 for Alexey Budankov 2020-04-22 12:17 ` [Intel-gfx] " tip-bot2 for Alexey Budankov 2020-04-02 8:46 ` [PATCH v8 02/12] perf/core: open access to the core for CAP_PERFMON privileged process Alexey Budankov 2020-04-02 8:46 ` [Intel-gfx] " Alexey Budankov 2020-04-22 12:17 ` [tip: perf/core] perf/core: Open " tip-bot2 for Alexey Budankov 2020-04-22 12:17 ` [Intel-gfx] " tip-bot2 for Alexey Budankov 2020-04-02 8:47 ` [PATCH v8 03/12] perf/core: open access to probes " Alexey Budankov 2020-04-02 8:47 ` [Intel-gfx] " Alexey Budankov 2020-04-22 12:17 ` [tip: perf/core] " tip-bot2 for Alexey Budankov 2020-04-22 12:17 ` [Intel-gfx] " tip-bot2 for Alexey Budankov 2020-04-02 8:47 ` [PATCH v8 04/12] perf tool: extend Perf tool with CAP_PERFMON capability support Alexey Budankov 2020-04-02 8:47 ` [Intel-gfx] " Alexey Budankov 2020-04-03 11:08 ` Jiri Olsa 2020-04-03 11:08 ` [Intel-gfx] " Jiri Olsa 2020-04-03 13:08 ` Alexey Budankov 2020-04-03 13:08 ` [Intel-gfx] " Alexey Budankov 2020-04-04 2:18 ` Namhyung Kim 2020-04-04 2:18 ` [Intel-gfx] " Namhyung Kim 2020-04-04 8:18 ` Alexey Budankov 2020-04-04 8:18 ` [Intel-gfx] " Alexey Budankov 2020-04-22 12:17 ` [tip: perf/core] perf tools: Support CAP_PERFMON capability tip-bot2 for Alexey Budankov 2020-04-22 12:17 ` [Intel-gfx] " tip-bot2 for Alexey Budankov 2020-04-02 8:48 ` [PATCH v8 05/12] drm/i915/perf: open access for CAP_PERFMON privileged process Alexey Budankov 2020-04-02 8:48 ` [Intel-gfx] " Alexey Budankov 2020-04-22 12:17 ` [tip: perf/core] drm/i915/perf: Open " tip-bot2 for Alexey Budankov 2020-04-22 12:17 ` [Intel-gfx] " tip-bot2 for Alexey Budankov 2020-04-02 8:48 ` [PATCH v8 06/12] trace/bpf_trace: open " Alexey Budankov 2020-04-02 8:48 ` [Intel-gfx] " Alexey Budankov 2020-04-22 12:17 ` [tip: perf/core] trace/bpf_trace: Open " tip-bot2 for Alexey Budankov 2020-04-22 12:17 ` [Intel-gfx] " tip-bot2 for Alexey Budankov 2020-04-02 8:49 ` [PATCH v8 07/12] powerpc/perf: open " Alexey Budankov 2020-04-02 8:49 ` [Intel-gfx] " Alexey Budankov 2020-04-22 12:17 ` [tip: perf/core] " tip-bot2 for Alexey Budankov 2020-04-22 12:17 ` [Intel-gfx] " tip-bot2 for Alexey Budankov 2020-04-02 8:50 ` [PATCH v8 08/12] parisc/perf: " Alexey Budankov 2020-04-02 8:50 ` [Intel-gfx] " Alexey Budankov 2020-04-22 12:17 ` [tip: perf/core] " tip-bot2 for Alexey Budankov 2020-04-22 12:17 ` [Intel-gfx] " tip-bot2 for Alexey Budankov 2020-04-02 8:51 ` [PATCH v8 09/12] drivers/perf: " Alexey Budankov 2020-04-02 8:51 ` [Intel-gfx] " Alexey Budankov 2020-04-22 12:17 ` tip-bot2 for Alexey Budankov [this message] 2020-04-22 12:17 ` [Intel-gfx] [tip: perf/core] drivers/perf: Open " tip-bot2 for Alexey Budankov 2020-04-02 8:53 ` [PATCH v8 10/12] drivers/oprofile: open " Alexey Budankov 2020-04-02 8:53 ` [Intel-gfx] " Alexey Budankov 2020-04-22 12:17 ` [tip: perf/core] drivers/oprofile: Open " tip-bot2 for Alexey Budankov 2020-04-22 12:17 ` [Intel-gfx] " tip-bot2 for Alexey Budankov 2020-04-02 8:54 ` [PATCH v8 11/12] doc/admin-guide: update perf-security.rst with CAP_PERFMON information Alexey Budankov 2020-04-02 8:54 ` [Intel-gfx] " Alexey Budankov 2020-04-22 12:17 ` [tip: perf/core] doc/admin-guide: Update " tip-bot2 for Alexey Budankov 2020-04-22 12:17 ` [Intel-gfx] " tip-bot2 for Alexey Budankov 2020-04-02 8:54 ` [PATCH v8 12/12] doc/admin-guide: update kernel.rst " Alexey Budankov 2020-04-02 8:54 ` [Intel-gfx] " Alexey Budankov 2020-04-05 14:10 ` Arnaldo Carvalho de Melo 2020-04-05 14:10 ` [Intel-gfx] " Arnaldo Carvalho de Melo 2020-04-05 14:41 ` Alexey Budankov 2020-04-05 14:41 ` [Intel-gfx] " Alexey Budankov 2020-04-05 14:54 ` Alexey Budankov 2020-04-05 14:54 ` [Intel-gfx] " Alexey Budankov 2020-04-05 15:05 ` Arnaldo Carvalho de Melo 2020-04-05 15:05 ` [Intel-gfx] " Arnaldo Carvalho de Melo 2020-04-05 15:51 ` Alexey Budankov 2020-04-05 15:51 ` [Intel-gfx] " Alexey Budankov 2020-04-22 12:17 ` [tip: perf/core] " tip-bot2 for Alexey Budankov 2020-04-22 12:17 ` [Intel-gfx] " tip-bot2 for Alexey Budankov 2020-04-02 9:37 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce CAP_PERFMON to secure system performance monitoring and observability (rev5) Patchwork 2020-04-02 10:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-04-03 11:24 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2020-04-05 16:00 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Introduce CAP_PERFMON to secure system performance monitoring and observability (rev6) Patchwork 2020-04-07 14:30 ` [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability Arnaldo Carvalho de Melo 2020-04-07 14:30 ` [Intel-gfx] " Arnaldo Carvalho de Melo 2020-04-07 14:35 ` Arnaldo Carvalho de Melo 2020-04-07 14:35 ` [Intel-gfx] " Arnaldo Carvalho de Melo 2020-04-07 14:54 ` Alexey Budankov 2020-04-07 14:54 ` [Intel-gfx] " Alexey Budankov 2020-04-07 16:36 ` Arnaldo Carvalho de Melo 2020-04-07 16:36 ` [Intel-gfx] " Arnaldo Carvalho de Melo 2020-04-07 16:40 ` Arnaldo Carvalho de Melo 2020-04-07 16:40 ` [Intel-gfx] " Arnaldo Carvalho de Melo 2020-04-07 17:17 ` Alexey Budankov 2020-04-07 17:17 ` [Intel-gfx] " Alexey Budankov 2020-04-07 16:52 ` Alexey Budankov 2020-04-07 16:52 ` [Intel-gfx] " Alexey Budankov 2020-04-07 17:02 ` Arnaldo Carvalho de Melo 2020-04-07 17:02 ` [Intel-gfx] " Arnaldo Carvalho de Melo 2020-04-07 17:32 ` Alexey Budankov 2020-04-07 17:32 ` [Intel-gfx] " Alexey Budankov 2020-04-07 16:56 ` Arnaldo Carvalho de Melo 2020-04-07 16:56 ` [Intel-gfx] " Arnaldo Carvalho de Melo 2020-04-07 17:23 ` Arnaldo Carvalho de Melo 2020-04-07 17:23 ` [Intel-gfx] " Arnaldo Carvalho de Melo 2020-04-22 19:18 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce CAP_PERFMON to secure system performance monitoring and observability (rev18) Patchwork 2020-04-22 19:43 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork 2020-07-10 13:31 ` [PATCH v8 00/12] Introduce CAP_PERFMON to secure system performance monitoring and observability Ravi Bangoria 2020-07-10 13:31 ` [Intel-gfx] " Ravi Bangoria 2020-07-10 14:30 ` Alexey Budankov 2020-07-10 14:30 ` [Intel-gfx] " Alexey Budankov 2020-07-10 17:09 ` Arnaldo Carvalho de Melo 2020-07-10 17:09 ` [Intel-gfx] " Arnaldo Carvalho de Melo 2020-07-13 9:48 ` Alexey Budankov 2020-07-13 9:48 ` [Intel-gfx] " Alexey Budankov 2020-07-13 12:17 ` Arnaldo Carvalho de Melo 2020-07-13 12:17 ` [Intel-gfx] " Arnaldo Carvalho de Melo 2020-07-13 12:37 ` Alexey Budankov 2020-07-13 12:37 ` [Intel-gfx] " Alexey Budankov 2020-07-13 18:51 ` Arnaldo Carvalho de Melo 2020-07-13 18:51 ` [Intel-gfx] " Arnaldo Carvalho de Melo 2020-07-14 10:59 ` Peter Zijlstra 2020-07-14 10:59 ` [Intel-gfx] " Peter Zijlstra 2020-07-14 15:27 ` Arnaldo Carvalho de Melo 2020-07-14 15:27 ` [Intel-gfx] " Arnaldo Carvalho de Melo 2020-07-21 13:06 ` Alexey Budankov 2020-07-21 13:06 ` [Intel-gfx] " Alexey Budankov 2020-07-22 11:30 ` Arnaldo Carvalho de Melo 2020-07-22 11:30 ` [Intel-gfx] " Arnaldo Carvalho de Melo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=158755785322.28353.1027174524920122867.tip-bot2@tip-bot2 \ --to=tip-bot2@linutronix.de \ --cc=acme@redhat.com \ --cc=ak@linux.intel.com \ --cc=alexey.budankov@linux.intel.com \ --cc=ast@kernel.org \ --cc=eranian@google.com \ --cc=ilubashe@akamai.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jamorris@linux.microsoft.com \ --cc=jolsa@redhat.com \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-man@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=linux-tip-commits@vger.kernel.org \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=selinux@vger.kernel.org \ --cc=serge@hallyn.com \ --cc=songliubraving@fb.com \ --cc=tglx@linutronix.de \ --cc=will@kernel.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.