* [Qemu-devel] [PATCH 01/67] block: use local path for local headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-04 9:32 ` Daniel P. Berrangé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 02/67] crypto: " Michael S. Tsirkin
` (70 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Max Reitz, Paolo Bonzini,
Jeff Cody, qemu-block
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
block/crypto.c | 2 +-
block/nbd.c | 2 +-
block/qcow.c | 2 +-
block/qcow2-bitmap.c | 2 +-
block/qcow2-cluster.c | 2 +-
block/qcow2-refcount.c | 2 +-
block/qcow2-snapshot.c | 2 +-
block/qcow2.c | 4 ++--
block/vhdx-endian.c | 2 +-
block/vhdx-log.c | 2 +-
block/vhdx.c | 2 +-
11 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/block/crypto.c b/block/crypto.c
index bc6c7e3..2d87d7c 100644
--- a/block/crypto.c
+++ b/block/crypto.c
@@ -29,7 +29,7 @@
#include "qapi/qobject-input-visitor.h"
#include "qapi/error.h"
#include "qemu/option.h"
-#include "block/crypto.h"
+#include "crypto.h"
typedef struct BlockCrypto BlockCrypto;
diff --git a/block/nbd.c b/block/nbd.c
index 1e2b3ba..5945229 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -27,7 +27,7 @@
*/
#include "qemu/osdep.h"
-#include "block/nbd-client.h"
+#include "nbd-client.h"
#include "qapi/error.h"
#include "qemu/uri.h"
#include "block/block_int.h"
diff --git a/block/qcow.c b/block/qcow.c
index f928916..0d9f753 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -37,7 +37,7 @@
#include "qapi/qapi-visit-block-core.h"
#include "crypto/block.h"
#include "migration/blocker.h"
-#include "block/crypto.h"
+#include "crypto.h"
/**************************************************************/
/* QEMU COW block driver with compression and encryption support */
diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index 6e93ec4..60d5290 100644
--- a/block/qcow2-bitmap.c
+++ b/block/qcow2-bitmap.c
@@ -30,7 +30,7 @@
#include "qemu/cutils.h"
#include "block/block_int.h"
-#include "block/qcow2.h"
+#include "qcow2.h"
/* NOTICE: BME here means Bitmaps Extension and used as a namespace for
* _internal_ constants. Please do not use this _internal_ abbreviation for
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 1aee726..0d74584 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -28,7 +28,7 @@
#include "qapi/error.h"
#include "qemu-common.h"
#include "block/block_int.h"
-#include "block/qcow2.h"
+#include "qcow2.h"
#include "qemu/bswap.h"
#include "trace.h"
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 6b8b635..3e2b14d 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -26,7 +26,7 @@
#include "qapi/error.h"
#include "qemu-common.h"
#include "block/block_int.h"
-#include "block/qcow2.h"
+#include "qcow2.h"
#include "qemu/range.h"
#include "qemu/bswap.h"
#include "qemu/cutils.h"
diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c
index 74293be..bb6a5b7 100644
--- a/block/qcow2-snapshot.c
+++ b/block/qcow2-snapshot.c
@@ -25,7 +25,7 @@
#include "qemu/osdep.h"
#include "qapi/error.h"
#include "block/block_int.h"
-#include "block/qcow2.h"
+#include "qcow2.h"
#include "qemu/bswap.h"
#include "qemu/error-report.h"
#include "qemu/cutils.h"
diff --git a/block/qcow2.c b/block/qcow2.c
index ef68772..ec9fb97 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -27,7 +27,7 @@
#include "sysemu/block-backend.h"
#include "qemu/module.h"
#include <zlib.h>
-#include "block/qcow2.h"
+#include "qcow2.h"
#include "qemu/error-report.h"
#include "qapi/error.h"
#include "qapi/qapi-events-block-core.h"
@@ -39,7 +39,7 @@
#include "qemu/bswap.h"
#include "qapi/qobject-input-visitor.h"
#include "qapi/qapi-visit-block-core.h"
-#include "block/crypto.h"
+#include "crypto.h"
/*
Differences with QCOW:
diff --git a/block/vhdx-endian.c b/block/vhdx-endian.c
index 429d755..41fbdd2 100644
--- a/block/vhdx-endian.c
+++ b/block/vhdx-endian.c
@@ -19,7 +19,7 @@
#include "qemu-common.h"
#include "block/block_int.h"
#include "qemu/bswap.h"
-#include "block/vhdx.h"
+#include "vhdx.h"
/*
* All the VHDX formats on disk are little endian - the following
diff --git a/block/vhdx-log.c b/block/vhdx-log.c
index 0ac4863..d2f1b98 100644
--- a/block/vhdx-log.c
+++ b/block/vhdx-log.c
@@ -24,7 +24,7 @@
#include "qemu/error-report.h"
#include "qemu/module.h"
#include "qemu/bswap.h"
-#include "block/vhdx.h"
+#include "vhdx.h"
typedef struct VHDXLogSequence {
diff --git a/block/vhdx.c b/block/vhdx.c
index 6ac0424..56f327d 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -23,7 +23,7 @@
#include "qemu/option.h"
#include "qemu/crc32c.h"
#include "qemu/bswap.h"
-#include "block/vhdx.h"
+#include "vhdx.h"
#include "migration/blocker.h"
#include "qemu/uuid.h"
#include "qapi/qmp/qdict.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 01/67] block: use local path for local headers
2018-05-03 19:50 ` [Qemu-devel] [PATCH 01/67] block: use local path for local headers Michael S. Tsirkin
@ 2018-05-04 9:32 ` Daniel P. Berrangé
0 siblings, 0 replies; 144+ messages in thread
From: Daniel P. Berrangé @ 2018-05-04 9:32 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, eblake, kwolf, peter.maydell, Max Reitz,
Paolo Bonzini, Jeff Cody, qemu-block
On Thu, May 03, 2018 at 10:50:20PM +0300, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
This commit message is wrong. Directory paths work by design, since
we explicitly add -I$SRCDIR to the include path.
If we want to drop -I$SRCDIR, lets be clear about that being the
reason, rather than pretending this is an accident.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 02/67] crypto: use local path for local headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 01/67] block: use local path for local headers Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 03/67] hppa: " Michael S. Tsirkin
` (69 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
crypto/block-luks.h | 2 +-
crypto/block-qcow.h | 2 +-
crypto/ivgen-essiv.h | 2 +-
crypto/ivgen-plain.h | 2 +-
crypto/ivgen-plain64.h | 2 +-
crypto/block-luks.c | 2 +-
crypto/block-qcow.c | 2 +-
crypto/block.c | 6 +++---
crypto/cipher.c | 6 +++---
crypto/ivgen-essiv.c | 2 +-
crypto/ivgen-plain.c | 2 +-
crypto/ivgen-plain64.c | 2 +-
crypto/ivgen.c | 8 ++++----
crypto/tlscreds.c | 2 +-
crypto/tlscredsanon.c | 2 +-
crypto/tlscredsx509.c | 2 +-
16 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/crypto/block-luks.h b/crypto/block-luks.h
index b2d8a35..befd8b2 100644
--- a/crypto/block-luks.h
+++ b/crypto/block-luks.h
@@ -21,7 +21,7 @@
#ifndef QCRYPTO_BLOCK_LUKS_H
#define QCRYPTO_BLOCK_LUKS_H
-#include "crypto/blockpriv.h"
+#include "blockpriv.h"
extern const QCryptoBlockDriver qcrypto_block_driver_luks;
diff --git a/crypto/block-qcow.h b/crypto/block-qcow.h
index 3e2c0a8..6988fb2 100644
--- a/crypto/block-qcow.h
+++ b/crypto/block-qcow.h
@@ -21,7 +21,7 @@
#ifndef QCRYPTO_BLOCK_QCOW_H
#define QCRYPTO_BLOCK_QCOW_H
-#include "crypto/blockpriv.h"
+#include "blockpriv.h"
extern const QCryptoBlockDriver qcrypto_block_driver_qcow;
diff --git a/crypto/ivgen-essiv.h b/crypto/ivgen-essiv.h
index 4a00af8..f34dbab 100644
--- a/crypto/ivgen-essiv.h
+++ b/crypto/ivgen-essiv.h
@@ -18,7 +18,7 @@
*
*/
-#include "crypto/ivgenpriv.h"
+#include "ivgenpriv.h"
#ifndef QCRYPTO_IVGEN_ESSIV_H__
#define QCRYPTO_IVGEN_ESSIV_H__
diff --git a/crypto/ivgen-plain.h b/crypto/ivgen-plain.h
index 0fe8835..16e1ae5 100644
--- a/crypto/ivgen-plain.h
+++ b/crypto/ivgen-plain.h
@@ -18,7 +18,7 @@
*
*/
-#include "crypto/ivgenpriv.h"
+#include "ivgenpriv.h"
#ifndef QCRYPTO_IVGEN_PLAIN_H__
#define QCRYPTO_IVGEN_PLAIN_H__
diff --git a/crypto/ivgen-plain64.h b/crypto/ivgen-plain64.h
index c410445..f8611bd 100644
--- a/crypto/ivgen-plain64.h
+++ b/crypto/ivgen-plain64.h
@@ -18,7 +18,7 @@
*
*/
-#include "crypto/ivgenpriv.h"
+#include "ivgenpriv.h"
#ifndef QCRYPTO_IVGEN_PLAIN64_H__
#define QCRYPTO_IVGEN_PLAIN64_H__
diff --git a/crypto/block-luks.c b/crypto/block-luks.c
index d418ac3..5738124 100644
--- a/crypto/block-luks.c
+++ b/crypto/block-luks.c
@@ -22,7 +22,7 @@
#include "qapi/error.h"
#include "qemu/bswap.h"
-#include "crypto/block-luks.h"
+#include "block-luks.h"
#include "crypto/hash.h"
#include "crypto/afsplit.h"
diff --git a/crypto/block-qcow.c b/crypto/block-qcow.c
index 8817d6a..4284e05 100644
--- a/crypto/block-qcow.c
+++ b/crypto/block-qcow.c
@@ -27,7 +27,7 @@
#include "qemu/osdep.h"
#include "qapi/error.h"
-#include "crypto/block-qcow.h"
+#include "block-qcow.h"
#include "crypto/secret.h"
#define QCRYPTO_BLOCK_QCOW_SECTOR_SIZE 512
diff --git a/crypto/block.c b/crypto/block.c
index f206d5e..e59d114 100644
--- a/crypto/block.c
+++ b/crypto/block.c
@@ -20,9 +20,9 @@
#include "qemu/osdep.h"
#include "qapi/error.h"
-#include "crypto/blockpriv.h"
-#include "crypto/block-qcow.h"
-#include "crypto/block-luks.h"
+#include "blockpriv.h"
+#include "block-qcow.h"
+#include "block-luks.h"
static const QCryptoBlockDriver *qcrypto_block_drivers[] = {
[Q_CRYPTO_BLOCK_FORMAT_QCOW] = &qcrypto_block_driver_qcow,
diff --git a/crypto/cipher.c b/crypto/cipher.c
index bcbfb3d..b3af579 100644
--- a/crypto/cipher.c
+++ b/crypto/cipher.c
@@ -150,11 +150,11 @@ qcrypto_cipher_munge_des_rfb_key(const uint8_t *key,
#endif /* CONFIG_GCRYPT || CONFIG_NETTLE */
#ifdef CONFIG_GCRYPT
-#include "crypto/cipher-gcrypt.c"
+#include "cipher-gcrypt.c"
#elif defined CONFIG_NETTLE
-#include "crypto/cipher-nettle.c"
+#include "cipher-nettle.c"
#else
-#include "crypto/cipher-builtin.c"
+#include "cipher-builtin.c"
#endif
QCryptoCipher *qcrypto_cipher_new(QCryptoCipherAlgorithm alg,
diff --git a/crypto/ivgen-essiv.c b/crypto/ivgen-essiv.c
index aeaa8fc..43e258c 100644
--- a/crypto/ivgen-essiv.c
+++ b/crypto/ivgen-essiv.c
@@ -20,7 +20,7 @@
#include "qemu/osdep.h"
#include "qemu/bswap.h"
-#include "crypto/ivgen-essiv.h"
+#include "ivgen-essiv.h"
typedef struct QCryptoIVGenESSIV QCryptoIVGenESSIV;
struct QCryptoIVGenESSIV {
diff --git a/crypto/ivgen-plain.c b/crypto/ivgen-plain.c
index bf2fb7a..06f4145 100644
--- a/crypto/ivgen-plain.c
+++ b/crypto/ivgen-plain.c
@@ -20,7 +20,7 @@
#include "qemu/osdep.h"
#include "qemu/bswap.h"
-#include "crypto/ivgen-plain.h"
+#include "ivgen-plain.h"
static int qcrypto_ivgen_plain_init(QCryptoIVGen *ivgen,
const uint8_t *key, size_t nkey,
diff --git a/crypto/ivgen-plain64.c b/crypto/ivgen-plain64.c
index e4679a1..fbb7724 100644
--- a/crypto/ivgen-plain64.c
+++ b/crypto/ivgen-plain64.c
@@ -20,7 +20,7 @@
#include "qemu/osdep.h"
#include "qemu/bswap.h"
-#include "crypto/ivgen-plain.h"
+#include "ivgen-plain.h"
static int qcrypto_ivgen_plain_init(QCryptoIVGen *ivgen,
const uint8_t *key, size_t nkey,
diff --git a/crypto/ivgen.c b/crypto/ivgen.c
index f664351..6a2b3ad 100644
--- a/crypto/ivgen.c
+++ b/crypto/ivgen.c
@@ -21,10 +21,10 @@
#include "qemu/osdep.h"
#include "qapi/error.h"
-#include "crypto/ivgenpriv.h"
-#include "crypto/ivgen-plain.h"
-#include "crypto/ivgen-plain64.h"
-#include "crypto/ivgen-essiv.h"
+#include "ivgenpriv.h"
+#include "ivgen-plain.h"
+#include "ivgen-plain64.h"
+#include "ivgen-essiv.h"
QCryptoIVGen *qcrypto_ivgen_new(QCryptoIVGenAlgorithm alg,
diff --git a/crypto/tlscreds.c b/crypto/tlscreds.c
index 3cd4103..02255a6 100644
--- a/crypto/tlscreds.c
+++ b/crypto/tlscreds.c
@@ -20,7 +20,7 @@
#include "qemu/osdep.h"
#include "qapi/error.h"
-#include "crypto/tlscredspriv.h"
+#include "tlscredspriv.h"
#include "trace.h"
#define DH_BITS 2048
diff --git a/crypto/tlscredsanon.c b/crypto/tlscredsanon.c
index 1464220..7ad66d1 100644
--- a/crypto/tlscredsanon.c
+++ b/crypto/tlscredsanon.c
@@ -20,7 +20,7 @@
#include "qemu/osdep.h"
#include "crypto/tlscredsanon.h"
-#include "crypto/tlscredspriv.h"
+#include "tlscredspriv.h"
#include "qapi/error.h"
#include "qom/object_interfaces.h"
#include "trace.h"
diff --git a/crypto/tlscredsx509.c b/crypto/tlscredsx509.c
index 50eb54f..98ee042 100644
--- a/crypto/tlscredsx509.c
+++ b/crypto/tlscredsx509.c
@@ -20,7 +20,7 @@
#include "qemu/osdep.h"
#include "crypto/tlscredsx509.h"
-#include "crypto/tlscredspriv.h"
+#include "tlscredspriv.h"
#include "crypto/secret.h"
#include "qapi/error.h"
#include "qom/object_interfaces.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 03/67] hppa: use local path for local headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 01/67] block: use local path for local headers Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 02/67] crypto: " Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-04 16:29 ` Philippe Mathieu-Daudé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 04/67] s390x: drop an unused include Michael S. Tsirkin
` (68 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Richard Henderson
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/hppa/hppa_sys.h | 2 +-
hw/hppa/machine.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/hppa/hppa_sys.h b/hw/hppa/hppa_sys.h
index a182d1f..f98cc8d 100644
--- a/hw/hppa/hppa_sys.h
+++ b/hw/hppa/hppa_sys.h
@@ -10,7 +10,7 @@
#include "hw/i386/pc.h"
#include "hw/irq.h"
-#include "hw/hppa/hppa_hardware.h"
+#include "hppa_hardware.h"
PCIBus *dino_init(MemoryRegion *, qemu_irq *, qemu_irq *);
diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
index 19033e2..70f509b 100644
--- a/hw/hppa/machine.c
+++ b/hw/hppa/machine.c
@@ -16,7 +16,7 @@
#include "hw/ide.h"
#include "hw/timer/i8254.h"
#include "hw/char/serial.h"
-#include "hw/hppa/hppa_sys.h"
+#include "hppa_sys.h"
#include "qemu/cutils.h"
#include "qapi/error.h"
#include "qemu/log.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 03/67] hppa: use local path for local headers
2018-05-03 19:50 ` [Qemu-devel] [PATCH 03/67] hppa: " Michael S. Tsirkin
@ 2018-05-04 16:29 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 144+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-05-04 16:29 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: kwolf, Richard Henderson, peter.maydell
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/hppa/hppa_sys.h | 2 +-
> hw/hppa/machine.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/hppa/hppa_sys.h b/hw/hppa/hppa_sys.h
> index a182d1f..f98cc8d 100644
> --- a/hw/hppa/hppa_sys.h
> +++ b/hw/hppa/hppa_sys.h
> @@ -10,7 +10,7 @@
> #include "hw/i386/pc.h"
> #include "hw/irq.h"
>
> -#include "hw/hppa/hppa_hardware.h"
> +#include "hppa_hardware.h"
>
> PCIBus *dino_init(MemoryRegion *, qemu_irq *, qemu_irq *);
>
> diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
> index 19033e2..70f509b 100644
> --- a/hw/hppa/machine.c
> +++ b/hw/hppa/machine.c
> @@ -16,7 +16,7 @@
> #include "hw/ide.h"
> #include "hw/timer/i8254.h"
> #include "hw/char/serial.h"
> -#include "hw/hppa/hppa_sys.h"
> +#include "hppa_sys.h"
> #include "qemu/cutils.h"
> #include "qapi/error.h"
> #include "qemu/log.h"
>
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 04/67] s390x: drop an unused include
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (2 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 03/67] hppa: " Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-04 0:24 ` Thomas Huth
2018-05-03 19:50 ` [Qemu-devel] [PATCH 05/67] migration: drop an unused include, add a used one Michael S. Tsirkin
` (67 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Cornelia Huck,
Christian Borntraeger, Alexander Graf, qemu-s390x
we just need a struct name, let's add a forward
declaration instead of an include.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/s390x/sclp.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
index f9db243..6e65150 100644
--- a/include/hw/s390x/sclp.h
+++ b/include/hw/s390x/sclp.h
@@ -16,7 +16,8 @@
#include "hw/sysbus.h"
#include "hw/qdev.h"
-#include "target/s390x/cpu-qom.h"
+
+typedef struct CPUS390XState CPUS390XState;
#define SCLP_CMD_CODE_MASK 0xffff00ff
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 04/67] s390x: drop an unused include
2018-05-03 19:50 ` [Qemu-devel] [PATCH 04/67] s390x: drop an unused include Michael S. Tsirkin
@ 2018-05-04 0:24 ` Thomas Huth
2018-05-08 13:23 ` Cornelia Huck
0 siblings, 1 reply; 144+ messages in thread
From: Thomas Huth @ 2018-05-04 0:24 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: kwolf, peter.maydell, Cornelia Huck, Alexander Graf,
Christian Borntraeger, qemu-s390x
On 03.05.2018 21:50, Michael S. Tsirkin wrote:
> we just need a struct name, let's add a forward
> declaration instead of an include.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/hw/s390x/sclp.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
> index f9db243..6e65150 100644
> --- a/include/hw/s390x/sclp.h
> +++ b/include/hw/s390x/sclp.h
> @@ -16,7 +16,8 @@
>
> #include "hw/sysbus.h"
> #include "hw/qdev.h"
> -#include "target/s390x/cpu-qom.h"
> +
> +typedef struct CPUS390XState CPUS390XState;
IIRC you have to use include/qemu/typedefs.h instead to avoid trouble
with older versions of GCC.
Thomas
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 04/67] s390x: drop an unused include
2018-05-04 0:24 ` Thomas Huth
@ 2018-05-08 13:23 ` Cornelia Huck
2018-05-08 13:38 ` Thomas Huth
0 siblings, 1 reply; 144+ messages in thread
From: Cornelia Huck @ 2018-05-08 13:23 UTC (permalink / raw)
To: Thomas Huth
Cc: Michael S. Tsirkin, qemu-devel, kwolf, peter.maydell,
Alexander Graf, Christian Borntraeger, qemu-s390x
On Fri, 4 May 2018 02:24:12 +0200
Thomas Huth <thuth@redhat.com> wrote:
> On 03.05.2018 21:50, Michael S. Tsirkin wrote:
> > we just need a struct name, let's add a forward
> > declaration instead of an include.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > include/hw/s390x/sclp.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
> > index f9db243..6e65150 100644
> > --- a/include/hw/s390x/sclp.h
> > +++ b/include/hw/s390x/sclp.h
> > @@ -16,7 +16,8 @@
> >
> > #include "hw/sysbus.h"
> > #include "hw/qdev.h"
> > -#include "target/s390x/cpu-qom.h"
> > +
> > +typedef struct CPUS390XState CPUS390XState;
>
> IIRC you have to use include/qemu/typedefs.h instead to avoid trouble
> with older versions of GCC.
Hm, I'm wondering why we do the typedef in cpu-qom.h, while other
architectures do it in their cpu.h.
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 04/67] s390x: drop an unused include
2018-05-08 13:23 ` Cornelia Huck
@ 2018-05-08 13:38 ` Thomas Huth
2018-05-08 13:45 ` Cornelia Huck
0 siblings, 1 reply; 144+ messages in thread
From: Thomas Huth @ 2018-05-08 13:38 UTC (permalink / raw)
To: Cornelia Huck
Cc: Michael S. Tsirkin, qemu-devel, kwolf, peter.maydell,
Alexander Graf, Christian Borntraeger, qemu-s390x,
David Hildenbrand
On 08.05.2018 15:23, Cornelia Huck wrote:
> On Fri, 4 May 2018 02:24:12 +0200
> Thomas Huth <thuth@redhat.com> wrote:
>
>> On 03.05.2018 21:50, Michael S. Tsirkin wrote:
>>> we just need a struct name, let's add a forward
>>> declaration instead of an include.
>>>
>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>> ---
>>> include/hw/s390x/sclp.h | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
>>> index f9db243..6e65150 100644
>>> --- a/include/hw/s390x/sclp.h
>>> +++ b/include/hw/s390x/sclp.h
>>> @@ -16,7 +16,8 @@
>>>
>>> #include "hw/sysbus.h"
>>> #include "hw/qdev.h"
>>> -#include "target/s390x/cpu-qom.h"
>>> +
>>> +typedef struct CPUS390XState CPUS390XState;
>>
>> IIRC you have to use include/qemu/typedefs.h instead to avoid trouble
>> with older versions of GCC.
>
> Hm, I'm wondering why we do the typedef in cpu-qom.h, while other
> architectures do it in their cpu.h.
See:
commit ef2974cc270d51959ce90df6b4d4d41635d7a603
Author: David Hildenbrand <david@redhat.com>
Date: Wed Sep 13 15:24:02 2017 +0200
target/s390x: move some s390x typedefs to cpu-qom.h
This allows us to drop inclusion of cpu_models.h in cpu-qom.h, and
prepares for using cpu-qom.h as a s390 specific version of typedefs.h
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20170913132417.24384-8-david@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Thomas
^ permalink raw reply [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 04/67] s390x: drop an unused include
2018-05-08 13:38 ` Thomas Huth
@ 2018-05-08 13:45 ` Cornelia Huck
2018-05-08 13:50 ` Thomas Huth
0 siblings, 1 reply; 144+ messages in thread
From: Cornelia Huck @ 2018-05-08 13:45 UTC (permalink / raw)
To: Thomas Huth
Cc: Michael S. Tsirkin, qemu-devel, kwolf, peter.maydell,
Alexander Graf, Christian Borntraeger, qemu-s390x,
David Hildenbrand
On Tue, 8 May 2018 15:38:03 +0200
Thomas Huth <thuth@redhat.com> wrote:
> On 08.05.2018 15:23, Cornelia Huck wrote:
> > On Fri, 4 May 2018 02:24:12 +0200
> > Thomas Huth <thuth@redhat.com> wrote:
> >
> >> On 03.05.2018 21:50, Michael S. Tsirkin wrote:
> >>> we just need a struct name, let's add a forward
> >>> declaration instead of an include.
> >>>
> >>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >>> ---
> >>> include/hw/s390x/sclp.h | 3 ++-
> >>> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
> >>> index f9db243..6e65150 100644
> >>> --- a/include/hw/s390x/sclp.h
> >>> +++ b/include/hw/s390x/sclp.h
> >>> @@ -16,7 +16,8 @@
> >>>
> >>> #include "hw/sysbus.h"
> >>> #include "hw/qdev.h"
> >>> -#include "target/s390x/cpu-qom.h"
> >>> +
> >>> +typedef struct CPUS390XState CPUS390XState;
> >>
> >> IIRC you have to use include/qemu/typedefs.h instead to avoid trouble
> >> with older versions of GCC.
> >
> > Hm, I'm wondering why we do the typedef in cpu-qom.h, while other
> > architectures do it in their cpu.h.
>
> See:
>
> commit ef2974cc270d51959ce90df6b4d4d41635d7a603
> Author: David Hildenbrand <david@redhat.com>
> Date: Wed Sep 13 15:24:02 2017 +0200
>
> target/s390x: move some s390x typedefs to cpu-qom.h
>
> This allows us to drop inclusion of cpu_models.h in cpu-qom.h, and
> prepares for using cpu-qom.h as a s390 specific version of typedefs.h
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> Message-Id: <20170913132417.24384-8-david@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>
> Thomas
>
>
Gargh, this is all very confusing...
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 04/67] s390x: drop an unused include
2018-05-08 13:45 ` Cornelia Huck
@ 2018-05-08 13:50 ` Thomas Huth
2018-05-08 14:06 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 144+ messages in thread
From: Thomas Huth @ 2018-05-08 13:50 UTC (permalink / raw)
To: Cornelia Huck
Cc: Michael S. Tsirkin, qemu-devel, kwolf, peter.maydell,
Alexander Graf, Christian Borntraeger, qemu-s390x,
David Hildenbrand
On 08.05.2018 15:45, Cornelia Huck wrote:
> On Tue, 8 May 2018 15:38:03 +0200
> Thomas Huth <thuth@redhat.com> wrote:
>
>> On 08.05.2018 15:23, Cornelia Huck wrote:
>>> On Fri, 4 May 2018 02:24:12 +0200
>>> Thomas Huth <thuth@redhat.com> wrote:
>>>
>>>> On 03.05.2018 21:50, Michael S. Tsirkin wrote:
>>>>> we just need a struct name, let's add a forward
>>>>> declaration instead of an include.
>>>>>
>>>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>>>> ---
>>>>> include/hw/s390x/sclp.h | 3 ++-
>>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
>>>>> index f9db243..6e65150 100644
>>>>> --- a/include/hw/s390x/sclp.h
>>>>> +++ b/include/hw/s390x/sclp.h
>>>>> @@ -16,7 +16,8 @@
>>>>>
>>>>> #include "hw/sysbus.h"
>>>>> #include "hw/qdev.h"
>>>>> -#include "target/s390x/cpu-qom.h"
>>>>> +
>>>>> +typedef struct CPUS390XState CPUS390XState;
>>>>
>>>> IIRC you have to use include/qemu/typedefs.h instead to avoid trouble
>>>> with older versions of GCC.
>>>
>>> Hm, I'm wondering why we do the typedef in cpu-qom.h, while other
>>> architectures do it in their cpu.h.
>>
>> See:
>>
>> commit ef2974cc270d51959ce90df6b4d4d41635d7a603
>> Author: David Hildenbrand <david@redhat.com>
>> Date: Wed Sep 13 15:24:02 2017 +0200
>>
>> target/s390x: move some s390x typedefs to cpu-qom.h
>>
>> This allows us to drop inclusion of cpu_models.h in cpu-qom.h, and
>> prepares for using cpu-qom.h as a s390 specific version of typedefs.h
>>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> Message-Id: <20170913132417.24384-8-david@redhat.com>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>>
>> Thomas
>
> Gargh, this is all very confusing...
If you'd ask me, I'd say we should get rid of the typedefs and do it the
Linux kernel way and enforce using "struct xyz" everywhere, then you
also do not have this problem with typedefs.h anymore ... but well, so
far it seems as I'm still part of a minority with this opinion here.
Thomas
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 04/67] s390x: drop an unused include
2018-05-08 13:50 ` Thomas Huth
@ 2018-05-08 14:06 ` Philippe Mathieu-Daudé
2018-05-08 14:17 ` Thomas Huth
0 siblings, 1 reply; 144+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-05-08 14:06 UTC (permalink / raw)
To: Thomas Huth, Cornelia Huck
Cc: kwolf, peter.maydell, Michael S. Tsirkin, David Hildenbrand,
Alexander Graf, qemu-devel, Christian Borntraeger, qemu-s390x
On 05/08/2018 10:50 AM, Thomas Huth wrote:
> On 08.05.2018 15:45, Cornelia Huck wrote:
>> On Tue, 8 May 2018 15:38:03 +0200
>> Thomas Huth <thuth@redhat.com> wrote:
>>
>>> On 08.05.2018 15:23, Cornelia Huck wrote:
>>>> On Fri, 4 May 2018 02:24:12 +0200
>>>> Thomas Huth <thuth@redhat.com> wrote:
>>>>
>>>>> On 03.05.2018 21:50, Michael S. Tsirkin wrote:
>>>>>> we just need a struct name, let's add a forward
>>>>>> declaration instead of an include.
>>>>>>
>>>>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>>>>> ---
>>>>>> include/hw/s390x/sclp.h | 3 ++-
>>>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
>>>>>> index f9db243..6e65150 100644
>>>>>> --- a/include/hw/s390x/sclp.h
>>>>>> +++ b/include/hw/s390x/sclp.h
>>>>>> @@ -16,7 +16,8 @@
>>>>>>
>>>>>> #include "hw/sysbus.h"
>>>>>> #include "hw/qdev.h"
>>>>>> -#include "target/s390x/cpu-qom.h"
>>>>>> +
>>>>>> +typedef struct CPUS390XState CPUS390XState;
>>>>>
>>>>> IIRC you have to use include/qemu/typedefs.h instead to avoid trouble
>>>>> with older versions of GCC.
>>>>
>>>> Hm, I'm wondering why we do the typedef in cpu-qom.h, while other
>>>> architectures do it in their cpu.h.
>>>
>>> See:
>>>
>>> commit ef2974cc270d51959ce90df6b4d4d41635d7a603
>>> Author: David Hildenbrand <david@redhat.com>
>>> Date: Wed Sep 13 15:24:02 2017 +0200
>>>
>>> target/s390x: move some s390x typedefs to cpu-qom.h
>>>
>>> This allows us to drop inclusion of cpu_models.h in cpu-qom.h, and
>>> prepares for using cpu-qom.h as a s390 specific version of typedefs.h
>>>
>>> Signed-off-by: David Hildenbrand <david@redhat.com>
>>> Message-Id: <20170913132417.24384-8-david@redhat.com>
>>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>>>
>>> Thomas
>>
>> Gargh, this is all very confusing...
>
> If you'd ask me, I'd say we should get rid of the typedefs and do it the
> Linux kernel way and enforce using "struct xyz" everywhere, then you
> also do not have this problem with typedefs.h anymore ... but well, so
> far it seems as I'm still part of a minority with this opinion here.
Maybe not getting rid of the typedefs, but I agree with removing typedefs.h.
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 04/67] s390x: drop an unused include
2018-05-08 14:06 ` Philippe Mathieu-Daudé
@ 2018-05-08 14:17 ` Thomas Huth
0 siblings, 0 replies; 144+ messages in thread
From: Thomas Huth @ 2018-05-08 14:17 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Cornelia Huck
Cc: kwolf, peter.maydell, Michael S. Tsirkin, David Hildenbrand,
Alexander Graf, qemu-devel, Christian Borntraeger, qemu-s390x
On 08.05.2018 16:06, Philippe Mathieu-Daudé wrote:
> On 05/08/2018 10:50 AM, Thomas Huth wrote:
>> On 08.05.2018 15:45, Cornelia Huck wrote:
>>> On Tue, 8 May 2018 15:38:03 +0200
>>> Thomas Huth <thuth@redhat.com> wrote:
>>>
>>>> On 08.05.2018 15:23, Cornelia Huck wrote:
[...]
>>>>> Hm, I'm wondering why we do the typedef in cpu-qom.h, while other
>>>>> architectures do it in their cpu.h.
>>>>
>>>> See:
>>>>
>>>> commit ef2974cc270d51959ce90df6b4d4d41635d7a603
>>>> Author: David Hildenbrand <david@redhat.com>
>>>> Date: Wed Sep 13 15:24:02 2017 +0200
>>>>
>>>> target/s390x: move some s390x typedefs to cpu-qom.h
>>>>
>>>> This allows us to drop inclusion of cpu_models.h in cpu-qom.h, and
>>>> prepares for using cpu-qom.h as a s390 specific version of typedefs.h
>>>>
>>>> Signed-off-by: David Hildenbrand <david@redhat.com>
>>>> Message-Id: <20170913132417.24384-8-david@redhat.com>
>>>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>>> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>>>>
>>>> Thomas
>>>
>>> Gargh, this is all very confusing...
>>
>> If you'd ask me, I'd say we should get rid of the typedefs and do it the
>> Linux kernel way and enforce using "struct xyz" everywhere, then you
>> also do not have this problem with typedefs.h anymore ... but well, so
>> far it seems as I'm still part of a minority with this opinion here.
>
> Maybe not getting rid of the typedefs, but I agree with removing typedefs.h.
But you need a way to do forward declarations ... thus you need
something like typedefs.h as long as you use typedefs. Otherwise older
versions of GCC will choke on multiple "typedef struct XyZ XyZ" statements.
Thomas
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 05/67] migration: drop an unused include, add a used one
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (3 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 04/67] s390x: drop an unused include Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-03 20:02 ` Eric Blake
2018-05-03 19:50 ` [Qemu-devel] [PATCH 06/67] trace: use local path for local headers Michael S. Tsirkin
` (66 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Juan Quintela,
Dr. David Alan Gilbert
we just need a struct name, let's add a forward
declaration instead of an include.
We also use size_t, so add stddef.h
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/migration/vmstate.h | 4 +++-
migration/savevm.c | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index df463fd..5103f15 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -27,7 +27,9 @@
#ifndef QEMU_VMSTATE_H
#define QEMU_VMSTATE_H
-#include "migration/qjson.h"
+#include <stddef.h>
+
+typedef struct QJSON QJSON;
typedef struct VMStateInfo VMStateInfo;
typedef struct VMStateDescription VMStateDescription;
diff --git a/migration/savevm.c b/migration/savevm.c
index e2be02a..532e22e 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -55,6 +55,7 @@
#include "io/channel-buffer.h"
#include "io/channel-file.h"
#include "sysemu/replay.h"
+#include "qjson.h"
#ifndef ETH_P_RARP
#define ETH_P_RARP 0x8035
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 05/67] migration: drop an unused include, add a used one
2018-05-03 19:50 ` [Qemu-devel] [PATCH 05/67] migration: drop an unused include, add a used one Michael S. Tsirkin
@ 2018-05-03 20:02 ` Eric Blake
2018-05-03 20:15 ` Michael S. Tsirkin
0 siblings, 1 reply; 144+ messages in thread
From: Eric Blake @ 2018-05-03 20:02 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: berrange, kwolf, peter.maydell, Juan Quintela, Dr. David Alan Gilbert
On 05/03/2018 02:50 PM, Michael S. Tsirkin wrote:
> we just need a struct name, let's add a forward
> declaration instead of an include.
Reasonable.
>
> We also use size_t, so add stddef.h
Why? osdep.h already does this, and ALL .c files that use include/
should be including osdep.h prior to any other in-tree .h file. So
size_t should already be in scope by the time this header is included.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/migration/vmstate.h | 4 +++-
> migration/savevm.c | 1 +
> 2 files changed, 4 insertions(+), 1 deletion(-)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 05/67] migration: drop an unused include, add a used one
2018-05-03 20:02 ` Eric Blake
@ 2018-05-03 20:15 ` Michael S. Tsirkin
2018-05-03 20:18 ` Eric Blake
0 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 20:15 UTC (permalink / raw)
To: Eric Blake
Cc: qemu-devel, berrange, kwolf, peter.maydell, Juan Quintela,
Dr. David Alan Gilbert
On Thu, May 03, 2018 at 03:02:59PM -0500, Eric Blake wrote:
> On 05/03/2018 02:50 PM, Michael S. Tsirkin wrote:
> > we just need a struct name, let's add a forward
> > declaration instead of an include.
>
> Reasonable.
>
> >
> > We also use size_t, so add stddef.h
>
> Why? osdep.h already does this, and ALL .c files that use include/ should be
> including osdep.h prior to any other in-tree .h file. So size_t should
> already be in scope by the time this header is included.
It seemed cleaner to have the file self-contained.
OK, I will drop this.
There's a small number of files which do not include qemu/osdep.h.
Might be worth fixing.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > include/migration/vmstate.h | 4 +++-
> > migration/savevm.c | 1 +
> > 2 files changed, 4 insertions(+), 1 deletion(-)
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 05/67] migration: drop an unused include, add a used one
2018-05-03 20:15 ` Michael S. Tsirkin
@ 2018-05-03 20:18 ` Eric Blake
2018-05-03 20:29 ` Michael S. Tsirkin
0 siblings, 1 reply; 144+ messages in thread
From: Eric Blake @ 2018-05-03 20:18 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, berrange, kwolf, peter.maydell, Juan Quintela,
Dr. David Alan Gilbert
On 05/03/2018 03:15 PM, Michael S. Tsirkin wrote:
> On Thu, May 03, 2018 at 03:02:59PM -0500, Eric Blake wrote:
>> On 05/03/2018 02:50 PM, Michael S. Tsirkin wrote:
>>> we just need a struct name, let's add a forward
>>> declaration instead of an include.
>>
>> Reasonable.
>>
>>>
>>> We also use size_t, so add stddef.h
>>
>> Why? osdep.h already does this, and ALL .c files that use include/ should be
>> including osdep.h prior to any other in-tree .h file. So size_t should
>> already be in scope by the time this header is included.
>
> It seemed cleaner to have the file self-contained.
> OK, I will drop this.
> There's a small number of files which do not include qemu/osdep.h.
> Might be worth fixing.
scripts/clean-includes is already supposed to fix these.
There are a few .c files exempt from including osdep.h, but in general,
those files should probably also not be including anything from include/.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 05/67] migration: drop an unused include, add a used one
2018-05-03 20:18 ` Eric Blake
@ 2018-05-03 20:29 ` Michael S. Tsirkin
2018-05-03 20:45 ` Eric Blake
0 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 20:29 UTC (permalink / raw)
To: Eric Blake
Cc: qemu-devel, berrange, kwolf, peter.maydell, Juan Quintela,
Dr. David Alan Gilbert
On Thu, May 03, 2018 at 03:18:47PM -0500, Eric Blake wrote:
> On 05/03/2018 03:15 PM, Michael S. Tsirkin wrote:
> > On Thu, May 03, 2018 at 03:02:59PM -0500, Eric Blake wrote:
> > > On 05/03/2018 02:50 PM, Michael S. Tsirkin wrote:
> > > > we just need a struct name, let's add a forward
> > > > declaration instead of an include.
> > >
> > > Reasonable.
> > >
> > > >
> > > > We also use size_t, so add stddef.h
> > >
> > > Why? osdep.h already does this, and ALL .c files that use include/ should be
> > > including osdep.h prior to any other in-tree .h file. So size_t should
> > > already be in scope by the time this header is included.
> >
> > It seemed cleaner to have the file self-contained.
> > OK, I will drop this.
> > There's a small number of files which do not include qemu/osdep.h.
> > Might be worth fixing.
>
> scripts/clean-includes is already supposed to fix these.
>
> There are a few .c files exempt from including osdep.h, but in general,
> those files should probably also not be including anything from include/.
Here's a list from a quick grep.
Most of them probably get osdep.h indirectly.
+contrib/libvhost-user/libvhost-user.c
+hw/rdma/rdma_utils.c
+libuser/trace.c
+target/mips/translate_init.c
+target/ppc/mfrom_table.c
+target/ppc/translate/dfp-impl.inc.c
+target/ppc/translate/dfp-ops.inc.c
+target/ppc/translate/fp-impl.inc.c
+target/ppc/translate/fp-ops.inc.c
+target/ppc/translate/spe-impl.inc.c
+target/ppc/translate/spe-ops.inc.c
+target/ppc/translate/vmx-impl.inc.c
+target/ppc/translate/vmx-ops.inc.c
+target/ppc/translate/vsx-impl.inc.c
+target/ppc/translate/vsx-ops.inc.c
+target/s390x/gen-features.c
+target/xtensa/core-dc232b/gdb-config.inc.c
+target/xtensa/core-dc233c/gdb-config.inc.c
+target/xtensa/core-de212/gdb-config.inc.c
+target/xtensa/core-sample_controller/gdb-config.inc.c
+tcg/aarch64/tcg-target.inc.c
+tcg/arm/tcg-target.inc.c
+tcg/i386/tcg-target.inc.c
+tcg/mips/tcg-target.inc.c
+tcg/ppc/tcg-target.inc.c
+tcg/s390/tcg-target.inc.c
+tcg/sparc/tcg-target.inc.c
+tcg/tcg-ldst.inc.c
+tcg/tcg-pool.inc.c
+tcg/tci/tcg-target.inc.c
+tests/multiboot/libc.c
+tests/multiboot/mmap.c
+tests/multiboot/modules.c
lots of files under tests/tcg
+tests/test-qapi-event.c
+tests/test-qapi-types.c
+tests/test-qapi-visit.c
+tests/test-qmp-introspect.c
+tests/test-qmp-marshal.c
+ui/keycodemapdb/tests/stdc.c
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 05/67] migration: drop an unused include, add a used one
2018-05-03 20:29 ` Michael S. Tsirkin
@ 2018-05-03 20:45 ` Eric Blake
0 siblings, 0 replies; 144+ messages in thread
From: Eric Blake @ 2018-05-03 20:45 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, berrange, kwolf, peter.maydell, Juan Quintela,
Dr. David Alan Gilbert
On 05/03/2018 03:29 PM, Michael S. Tsirkin wrote:
>>
>> There are a few .c files exempt from including osdep.h, but in general,
>> those files should probably also not be including anything from include/.
>
> Here's a list from a quick grep.
> Most of them probably get osdep.h indirectly.
>
>
> +contrib/libvhost-user/libvhost-user.c
contrib may or may not be exempt; but it's not in the whitelist.
> +hw/rdma/rdma_utils.c
Probably a bug; looks like a recently added file.
> +libuser/trace.c
Huh? I don't see this file in git.
> +target/mips/translate_init.c
> +target/ppc/mfrom_table.c
Probably bugs.
> +target/ppc/translate/dfp-impl.inc.c
This, and all other .inc.c, are indeed picking it up indirectly (by the
master .c that is including these secondary .c), so they are exempt.
They are whitelisted by the script via the shell case statement.
> +target/s390x/gen-features.c
Possibly a bug.
> +tests/multiboot/libc.c
> +tests/multiboot/mmap.c
> +tests/multiboot/modules.c
Exempt, per the XDIRREGEX in scripts/clean-includes
>
> lots of files under tests/tcg
Also exempt.
>
> +tests/test-qapi-event.c
Huh? That starts with #include "qemu/osdep.h". But it's not a file
under version control. In fact, it's stale leftovers (it used to be
generated by that name, but now we generate tests/test-qapi-events.c.
> +tests/test-qapi-types.c
> +tests/test-qapi-visit.c
> +tests/test-qmp-introspect.c
> +tests/test-qmp-marshal.c
Again, how are you flagging these generated files?
>
> +ui/keycodemapdb/tests/stdc.c
Exempt, since it's in a submodule.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 06/67] trace: use local path for local headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (4 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 05/67] migration: drop an unused include, add a used one Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-04 8:10 ` Stefan Hajnoczi
2018-05-04 16:31 ` Philippe Mathieu-Daudé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 07/67] display: " Michael S. Tsirkin
` (65 subsequent siblings)
71 siblings, 2 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Stefan Hajnoczi
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
trace/control.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/trace/control.h b/trace/control.h
index 1903e22..eb65c8e 100644
--- a/trace/control.h
+++ b/trace/control.h
@@ -267,6 +267,6 @@ char *trace_opt_parse(const char *optarg);
uint32_t trace_get_vcpu_event_count(void);
-#include "trace/control-internal.h"
+#include "control-internal.h"
#endif /* TRACE__CONTROL_H */
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 06/67] trace: use local path for local headers
2018-05-03 19:50 ` [Qemu-devel] [PATCH 06/67] trace: use local path for local headers Michael S. Tsirkin
@ 2018-05-04 8:10 ` Stefan Hajnoczi
2018-05-04 16:31 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 144+ messages in thread
From: Stefan Hajnoczi @ 2018-05-04 8:10 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell
[-- Attachment #1: Type: text/plain, Size: 479 bytes --]
On Thu, May 03, 2018 at 10:50:28PM +0300, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> trace/control.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 06/67] trace: use local path for local headers
2018-05-03 19:50 ` [Qemu-devel] [PATCH 06/67] trace: use local path for local headers Michael S. Tsirkin
2018-05-04 8:10 ` Stefan Hajnoczi
@ 2018-05-04 16:31 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 144+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-05-04 16:31 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: kwolf, Stefan Hajnoczi, peter.maydell
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> trace/control.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/trace/control.h b/trace/control.h
> index 1903e22..eb65c8e 100644
> --- a/trace/control.h
> +++ b/trace/control.h
> @@ -267,6 +267,6 @@ char *trace_opt_parse(const char *optarg);
> uint32_t trace_get_vcpu_event_count(void);
>
>
> -#include "trace/control-internal.h"
> +#include "control-internal.h"
>
> #endif /* TRACE__CONTROL_H */
>
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 07/67] display: use local path for local headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (5 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 06/67] trace: use local path for local headers Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-04 16:33 ` Philippe Mathieu-Daudé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 08/67] ide: " Michael S. Tsirkin
` (64 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/display/bcm2835_fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c
index 7eab927..3355f4c 100644
--- a/hw/display/bcm2835_fb.c
+++ b/hw/display/bcm2835_fb.c
@@ -26,7 +26,7 @@
#include "qemu/osdep.h"
#include "qapi/error.h"
#include "hw/display/bcm2835_fb.h"
-#include "hw/display/framebuffer.h"
+#include "framebuffer.h"
#include "ui/pixel_ops.h"
#include "hw/misc/bcm2835_mbox_defs.h"
#include "qemu/log.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 07/67] display: use local path for local headers
2018-05-03 19:50 ` [Qemu-devel] [PATCH 07/67] display: " Michael S. Tsirkin
@ 2018-05-04 16:33 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 144+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-05-04 16:33 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: kwolf, peter.maydell
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/display/bcm2835_fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c
> index 7eab927..3355f4c 100644
> --- a/hw/display/bcm2835_fb.c
> +++ b/hw/display/bcm2835_fb.c
> @@ -26,7 +26,7 @@
> #include "qemu/osdep.h"
> #include "qapi/error.h"
> #include "hw/display/bcm2835_fb.h"
> -#include "hw/display/framebuffer.h"
> +#include "framebuffer.h"
> #include "ui/pixel_ops.h"
> #include "hw/misc/bcm2835_mbox_defs.h"
> #include "qemu/log.h"
>
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 08/67] ide: use local path for local headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (6 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 07/67] display: " Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 09/67] ioapic: fix up includes Michael S. Tsirkin
` (63 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, John Snow, qemu-block
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/ide/ahci-allwinner.c | 2 +-
hw/ide/ahci.c | 2 +-
hw/ide/ich.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/ide/ahci-allwinner.c b/hw/ide/ahci-allwinner.c
index 5397483..425ddb0 100644
--- a/hw/ide/ahci-allwinner.c
+++ b/hw/ide/ahci-allwinner.c
@@ -20,7 +20,7 @@
#include "qemu/error-report.h"
#include "sysemu/dma.h"
#include "hw/ide/internal.h"
-#include "hw/ide/ahci_internal.h"
+#include "ahci_internal.h"
#include "trace.h"
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index e22d7be..24dbad5 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -31,7 +31,7 @@
#include "sysemu/dma.h"
#include "hw/ide/internal.h"
#include "hw/ide/pci.h"
-#include "hw/ide/ahci_internal.h"
+#include "ahci_internal.h"
#include "trace.h"
diff --git a/hw/ide/ich.c b/hw/ide/ich.c
index 134478e..51c935a 100644
--- a/hw/ide/ich.c
+++ b/hw/ide/ich.c
@@ -67,7 +67,7 @@
#include "hw/isa/isa.h"
#include "sysemu/dma.h"
#include "hw/ide/pci.h"
-#include "hw/ide/ahci_internal.h"
+#include "ahci_internal.h"
#define ICH9_MSI_CAP_OFFSET 0x80
#define ICH9_SATA_CAP_OFFSET 0xA8
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 09/67] ioapic: fix up includes
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (7 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 08/67] ide: " Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 10/67] e1000e: use local path for local headers Michael S. Tsirkin
` (62 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Paolo Bonzini
include files shouldn't have the "include/" part,
that is implied.
Also, drop an unused include.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/intc/ioapic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
index 36139a4..c45f073 100644
--- a/hw/intc/ioapic.c
+++ b/hw/intc/ioapic.c
@@ -28,9 +28,8 @@
#include "hw/i386/apic.h"
#include "hw/i386/ioapic.h"
#include "hw/i386/ioapic_internal.h"
-#include "include/hw/pci/msi.h"
+#include "hw/pci/msi.h"
#include "sysemu/kvm.h"
-#include "target/i386/cpu.h"
#include "hw/i386/apic-msidef.h"
#include "hw/i386/x86-iommu.h"
#include "trace.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 10/67] e1000e: use local path for local headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (8 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 09/67] ioapic: fix up includes Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 11/67] rocker: drop an unused include Michael S. Tsirkin
` (61 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Dmitry Fleytman, Jason Wang
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/net/e1000e.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c
index 16a9417..cda8d48 100644
--- a/hw/net/e1000e.c
+++ b/hw/net/e1000e.c
@@ -41,7 +41,7 @@
#include "hw/pci/msi.h"
#include "hw/pci/msix.h"
-#include "hw/net/e1000_regs.h"
+#include "e1000_regs.h"
#include "e1000x_common.h"
#include "e1000e_core.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 11/67] rocker: drop an unused include
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (9 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 10/67] e1000e: use local path for local headers Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-08 12:58 ` Philippe Mathieu-Daudé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 12/67] ppc: use local path for local headers Michael S. Tsirkin
` (60 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Jiri Pirko, Jason Wang
We don't use net/clients.h, drop that include.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/net/rocker/rocker_fp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/net/rocker/rocker_fp.c b/hw/net/rocker/rocker_fp.c
index 27b17c8..4aa7da7 100644
--- a/hw/net/rocker/rocker_fp.c
+++ b/hw/net/rocker/rocker_fp.c
@@ -15,7 +15,6 @@
*/
#include "qemu/osdep.h"
-#include "net/clients.h"
#include "qapi/qapi-types-rocker.h"
#include "rocker.h"
#include "rocker_hw.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 11/67] rocker: drop an unused include
2018-05-03 19:50 ` [Qemu-devel] [PATCH 11/67] rocker: drop an unused include Michael S. Tsirkin
@ 2018-05-08 12:58 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 144+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-05-08 12:58 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: kwolf, peter.maydell, Jason Wang, Jiri Pirko
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote:
> We don't use net/clients.h, drop that include.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/net/rocker/rocker_fp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/net/rocker/rocker_fp.c b/hw/net/rocker/rocker_fp.c
> index 27b17c8..4aa7da7 100644
> --- a/hw/net/rocker/rocker_fp.c
> +++ b/hw/net/rocker/rocker_fp.c
> @@ -15,7 +15,6 @@
> */
>
> #include "qemu/osdep.h"
> -#include "net/clients.h"
> #include "qapi/qapi-types-rocker.h"
> #include "rocker.h"
> #include "rocker_hw.h"
>
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 12/67] ppc: use local path for local headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (10 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 11/67] rocker: drop an unused include Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-03 23:34 ` David Gibson
2018-05-03 19:50 ` [Qemu-devel] [PATCH 13/67] vhost-scsi: drop an unused include Michael S. Tsirkin
` (59 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Alexander Graf,
David Gibson, qemu-ppc
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/ppc/ppc440_uc.c | 2 +-
hw/ppc/sam460ex.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c
index e312fdb..123f4ac 100644
--- a/hw/ppc/ppc440_uc.c
+++ b/hw/ppc/ppc440_uc.c
@@ -20,7 +20,7 @@
#include "hw/ppc/ppc.h"
#include "hw/pci/pci.h"
#include "sysemu/block-backend.h"
-#include "hw/ppc/ppc440.h"
+#include "ppc440.h"
/*****************************************************************************/
/* L2 Cache as SRAM */
diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c
index dfff262..4a66e1d 100644
--- a/hw/ppc/sam460ex.c
+++ b/hw/ppc/sam460ex.c
@@ -27,8 +27,8 @@
#include "elf.h"
#include "exec/address-spaces.h"
#include "exec/memory.h"
-#include "hw/ppc/ppc440.h"
-#include "hw/ppc/ppc405.h"
+#include "ppc440.h"
+#include "ppc405.h"
#include "hw/block/flash.h"
#include "sysemu/sysemu.h"
#include "sysemu/qtest.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 12/67] ppc: use local path for local headers
2018-05-03 19:50 ` [Qemu-devel] [PATCH 12/67] ppc: use local path for local headers Michael S. Tsirkin
@ 2018-05-03 23:34 ` David Gibson
0 siblings, 0 replies; 144+ messages in thread
From: David Gibson @ 2018-05-03 23:34 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell,
Alexander Graf, qemu-ppc
[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]
On Thu, May 03, 2018 at 10:50:35PM +0300, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> hw/ppc/ppc440_uc.c | 2 +-
> hw/ppc/sam460ex.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c
> index e312fdb..123f4ac 100644
> --- a/hw/ppc/ppc440_uc.c
> +++ b/hw/ppc/ppc440_uc.c
> @@ -20,7 +20,7 @@
> #include "hw/ppc/ppc.h"
> #include "hw/pci/pci.h"
> #include "sysemu/block-backend.h"
> -#include "hw/ppc/ppc440.h"
> +#include "ppc440.h"
>
> /*****************************************************************************/
> /* L2 Cache as SRAM */
> diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c
> index dfff262..4a66e1d 100644
> --- a/hw/ppc/sam460ex.c
> +++ b/hw/ppc/sam460ex.c
> @@ -27,8 +27,8 @@
> #include "elf.h"
> #include "exec/address-spaces.h"
> #include "exec/memory.h"
> -#include "hw/ppc/ppc440.h"
> -#include "hw/ppc/ppc405.h"
> +#include "ppc440.h"
> +#include "ppc405.h"
> #include "hw/block/flash.h"
> #include "sysemu/sysemu.h"
> #include "sysemu/qtest.h"
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 13/67] vhost-scsi: drop an unused include
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (11 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 12/67] ppc: use local path for local headers Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-08 12:59 ` Philippe Mathieu-Daudé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 14/67] sd: fix up include Michael S. Tsirkin
` (58 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Paolo Bonzini, Fam Zheng
No reason for vhost-scsi to pull in migration headers directly.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/scsi/vhost-scsi-common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/scsi/vhost-scsi-common.c b/hw/scsi/vhost-scsi-common.c
index 77e9897..e2a5828 100644
--- a/hw/scsi/vhost-scsi-common.c
+++ b/hw/scsi/vhost-scsi-common.c
@@ -17,7 +17,6 @@
#include "qemu/osdep.h"
#include "qemu/error-report.h"
-#include "migration/migration.h"
#include "hw/virtio/vhost.h"
#include "hw/virtio/vhost-scsi-common.h"
#include "hw/virtio/virtio-scsi.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 13/67] vhost-scsi: drop an unused include
2018-05-03 19:50 ` [Qemu-devel] [PATCH 13/67] vhost-scsi: drop an unused include Michael S. Tsirkin
@ 2018-05-08 12:59 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 144+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-05-08 12:59 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: kwolf, peter.maydell, Paolo Bonzini, Fam Zheng
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote:
> No reason for vhost-scsi to pull in migration headers directly.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/scsi/vhost-scsi-common.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/scsi/vhost-scsi-common.c b/hw/scsi/vhost-scsi-common.c
> index 77e9897..e2a5828 100644
> --- a/hw/scsi/vhost-scsi-common.c
> +++ b/hw/scsi/vhost-scsi-common.c
> @@ -17,7 +17,6 @@
>
> #include "qemu/osdep.h"
> #include "qemu/error-report.h"
> -#include "migration/migration.h"
> #include "hw/virtio/vhost.h"
> #include "hw/virtio/vhost-scsi-common.h"
> #include "hw/virtio/virtio-scsi.h"
>
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 14/67] sd: fix up include
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (12 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 13/67] vhost-scsi: drop an unused include Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-04 16:35 ` Philippe Mathieu-Daudé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 15/67] usb: use local path for local headers Michael S. Tsirkin
` (57 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Michael Walle
include files shouldn't have the "include/" part,
that is implied.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/sd/milkymist-memcard.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c
index 5570c1e..fe1cccc 100644
--- a/hw/sd/milkymist-memcard.c
+++ b/hw/sd/milkymist-memcard.c
@@ -27,7 +27,7 @@
#include "hw/sysbus.h"
#include "sysemu/sysemu.h"
#include "trace.h"
-#include "include/qapi/error.h"
+#include "qapi/error.h"
#include "sysemu/block-backend.h"
#include "sysemu/blockdev.h"
#include "hw/sd/sd.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 14/67] sd: fix up include
2018-05-03 19:50 ` [Qemu-devel] [PATCH 14/67] sd: fix up include Michael S. Tsirkin
@ 2018-05-04 16:35 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 144+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-05-04 16:35 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: kwolf, Michael Walle, peter.maydell
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote:
> include files shouldn't have the "include/" part,
> that is implied.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/sd/milkymist-memcard.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c
> index 5570c1e..fe1cccc 100644
> --- a/hw/sd/milkymist-memcard.c
> +++ b/hw/sd/milkymist-memcard.c
> @@ -27,7 +27,7 @@
> #include "hw/sysbus.h"
> #include "sysemu/sysemu.h"
> #include "trace.h"
> -#include "include/qapi/error.h"
> +#include "qapi/error.h"
> #include "sysemu/block-backend.h"
> #include "sysemu/blockdev.h"
> #include "hw/sd/sd.h"
>
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 15/67] usb: use local path for local headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (13 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 14/67] sd: fix up include Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 16/67] migration: " Michael S. Tsirkin
` (56 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Gerd Hoffmann, Samuel Thibault
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/usb/desc-msos.c | 2 +-
hw/usb/desc.c | 2 +-
hw/usb/dev-audio.c | 2 +-
hw/usb/dev-bluetooth.c | 2 +-
hw/usb/dev-hid.c | 2 +-
hw/usb/dev-hub.c | 2 +-
hw/usb/dev-mtp.c | 2 +-
hw/usb/dev-network.c | 2 +-
hw/usb/dev-serial.c | 2 +-
hw/usb/dev-smartcard-reader.c | 2 +-
hw/usb/dev-storage.c | 2 +-
hw/usb/dev-uas.c | 2 +-
hw/usb/dev-wacom.c | 2 +-
13 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/hw/usb/desc-msos.c b/hw/usb/desc-msos.c
index 3652919..3a5ad7c 100644
--- a/hw/usb/desc-msos.c
+++ b/hw/usb/desc-msos.c
@@ -1,6 +1,6 @@
#include "qemu/osdep.h"
#include "hw/usb.h"
-#include "hw/usb/desc.h"
+#include "desc.h"
/*
* Microsoft OS Descriptors
diff --git a/hw/usb/desc.c b/hw/usb/desc.c
index 85c15ad..8b6eaea 100644
--- a/hw/usb/desc.c
+++ b/hw/usb/desc.c
@@ -1,7 +1,7 @@
#include "qemu/osdep.h"
#include "hw/usb.h"
-#include "hw/usb/desc.h"
+#include "desc.h"
#include "trace.h"
/* ------------------------------------------------------------------ */
diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c
index 3433452..ee43e49 100644
--- a/hw/usb/dev-audio.c
+++ b/hw/usb/dev-audio.c
@@ -32,7 +32,7 @@
#include "qemu/osdep.h"
#include "qemu-common.h"
#include "hw/usb.h"
-#include "hw/usb/desc.h"
+#include "desc.h"
#include "hw/hw.h"
#include "audio/audio.h"
diff --git a/hw/usb/dev-bluetooth.c b/hw/usb/dev-bluetooth.c
index 0bbceae..eac7365 100644
--- a/hw/usb/dev-bluetooth.c
+++ b/hw/usb/dev-bluetooth.c
@@ -22,7 +22,7 @@
#include "qemu-common.h"
#include "qemu/error-report.h"
#include "hw/usb.h"
-#include "hw/usb/desc.h"
+#include "desc.h"
#include "sysemu/bt.h"
#include "hw/bt.h"
diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c
index c40019d..62d1829 100644
--- a/hw/usb/dev-hid.c
+++ b/hw/usb/dev-hid.c
@@ -26,7 +26,7 @@
#include "hw/hw.h"
#include "ui/console.h"
#include "hw/usb.h"
-#include "hw/usb/desc.h"
+#include "desc.h"
#include "qapi/error.h"
#include "qemu/timer.h"
#include "hw/input/hid.h"
diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c
index 752e30c..5d9743ef 100644
--- a/hw/usb/dev-hub.c
+++ b/hw/usb/dev-hub.c
@@ -26,7 +26,7 @@
#include "qemu-common.h"
#include "trace.h"
#include "hw/usb.h"
-#include "hw/usb/desc.h"
+#include "desc.h"
#include "qemu/error-report.h"
#define NUM_PORTS 8
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 6ecf70a..cda7335 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -24,7 +24,7 @@
#include "qemu/iov.h"
#include "trace.h"
#include "hw/usb.h"
-#include "hw/usb/desc.h"
+#include "desc.h"
/* ----------------------------------------------------------------------- */
diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c
index aea7edc..385e090 100644
--- a/hw/usb/dev-network.c
+++ b/hw/usb/dev-network.c
@@ -27,7 +27,7 @@
#include "qapi/error.h"
#include "qemu-common.h"
#include "hw/usb.h"
-#include "hw/usb/desc.h"
+#include "desc.h"
#include "net/net.h"
#include "qemu/error-report.h"
#include "qemu/queue.h"
diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c
index 2829dda..98d1ca3 100644
--- a/hw/usb/dev-serial.c
+++ b/hw/usb/dev-serial.c
@@ -14,7 +14,7 @@
#include "qemu/cutils.h"
#include "qemu/error-report.h"
#include "hw/usb.h"
-#include "hw/usb/desc.h"
+#include "desc.h"
#include "chardev/char-serial.h"
#include "chardev/char-fe.h"
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index e646805..92e3651 100644
--- a/hw/usb/dev-smartcard-reader.c
+++ b/hw/usb/dev-smartcard-reader.c
@@ -39,7 +39,7 @@
#include "qemu-common.h"
#include "qemu/error-report.h"
#include "hw/usb.h"
-#include "hw/usb/desc.h"
+#include "desc.h"
#include "ccid.h"
diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index b56c75a..f2f632a 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -14,7 +14,7 @@
#include "qemu/option.h"
#include "qemu/config-file.h"
#include "hw/usb.h"
-#include "hw/usb/desc.h"
+#include "desc.h"
#include "hw/scsi/scsi.h"
#include "ui/console.h"
#include "monitor/monitor.h"
diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c
index c218b53..aaf5a88 100644
--- a/hw/usb/dev-uas.c
+++ b/hw/usb/dev-uas.c
@@ -17,7 +17,7 @@
#include "qemu/error-report.h"
#include "hw/usb.h"
-#include "hw/usb/desc.h"
+#include "desc.h"
#include "hw/scsi/scsi.h"
#include "scsi/constants.h"
diff --git a/hw/usb/dev-wacom.c b/hw/usb/dev-wacom.c
index bf70013..ac0bc83 100644
--- a/hw/usb/dev-wacom.c
+++ b/hw/usb/dev-wacom.c
@@ -29,7 +29,7 @@
#include "hw/hw.h"
#include "ui/console.h"
#include "hw/usb.h"
-#include "hw/usb/desc.h"
+#include "desc.h"
/* Interface requests */
#define WACOM_GET_REPORT 0x2101
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 16/67] migration: use local path for local headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (14 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 15/67] usb: use local path for local headers Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-08 12:21 ` Juan Quintela
2018-05-03 19:50 ` [Qemu-devel] [PATCH 17/67] colo: " Michael S. Tsirkin
` (55 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Stefan Hajnoczi,
Fam Zheng, Juan Quintela, Dr. David Alan Gilbert, qemu-block
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
migration/block-dirty-bitmap.c | 2 +-
migration/page_cache.c | 2 +-
migration/ram.c | 4 ++--
migration/vmstate.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
index dd04f10..09c086d 100644
--- a/migration/block-dirty-bitmap.c
+++ b/migration/block-dirty-bitmap.c
@@ -66,7 +66,7 @@
#include "qemu/error-report.h"
#include "migration/misc.h"
#include "migration/migration.h"
-#include "migration/qemu-file.h"
+#include "qemu-file.h"
#include "migration/vmstate.h"
#include "migration/register.h"
#include "qemu/hbitmap.h"
diff --git a/migration/page_cache.c b/migration/page_cache.c
index 96268c3..acc252b 100644
--- a/migration/page_cache.c
+++ b/migration/page_cache.c
@@ -18,7 +18,7 @@
#include "qapi/error.h"
#include "qemu-common.h"
#include "qemu/host-utils.h"
-#include "migration/page_cache.h"
+#include "page_cache.h"
#ifdef DEBUG_CACHE
#define DPRINTF(fmt, ...) \
diff --git a/migration/ram.c b/migration/ram.c
index 0e90efa..34a34d9 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -40,7 +40,7 @@
#include "migration/misc.h"
#include "qemu-file.h"
#include "postcopy-ram.h"
-#include "migration/page_cache.h"
+#include "page_cache.h"
#include "qemu/error-report.h"
#include "qapi/error.h"
#include "qapi/qapi-events-migration.h"
@@ -50,7 +50,7 @@
#include "exec/target_page.h"
#include "qemu/rcu_queue.h"
#include "migration/colo.h"
-#include "migration/block.h"
+#include "block.h"
/***********************************************************/
/* ram save/restore */
diff --git a/migration/vmstate.c b/migration/vmstate.c
index 0b3282c..0a09636 100644
--- a/migration/vmstate.c
+++ b/migration/vmstate.c
@@ -14,7 +14,7 @@
#include "qemu-common.h"
#include "migration.h"
#include "migration/vmstate.h"
-#include "migration/savevm.h"
+#include "savevm.h"
#include "qemu-file.h"
#include "qemu/bitops.h"
#include "qemu/error-report.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 16/67] migration: use local path for local headers
2018-05-03 19:50 ` [Qemu-devel] [PATCH 16/67] migration: " Michael S. Tsirkin
@ 2018-05-08 12:21 ` Juan Quintela
2018-05-08 13:12 ` Eric Blake
0 siblings, 1 reply; 144+ messages in thread
From: Juan Quintela @ 2018-05-08 12:21 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell,
Stefan Hajnoczi, Fam Zheng, Dr. David Alan Gilbert, qemu-block
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
No, it is not by accident.
qemu-version.h and config-host.h are on the root directory. I could
agree with moving them.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> migration/block-dirty-bitmap.c | 2 +-
> migration/page_cache.c | 2 +-
> migration/ram.c | 4 ++--
> migration/vmstate.c | 2 +-
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
> index dd04f10..09c086d 100644
> --- a/migration/block-dirty-bitmap.c
> +++ b/migration/block-dirty-bitmap.c
> @@ -66,7 +66,7 @@
> #include "qemu/error-report.h"
> #include "migration/misc.h"
> #include "migration/migration.h"
> -#include "migration/qemu-file.h"
> +#include "qemu-file.h"
Substitite for "./qemu-file.h"?
My wonder here is what happens if we end with a file with the same name in
two places.
Later, Juan.
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 16/67] migration: use local path for local headers
2018-05-08 12:21 ` Juan Quintela
@ 2018-05-08 13:12 ` Eric Blake
2018-05-08 14:28 ` Juan Quintela
0 siblings, 1 reply; 144+ messages in thread
From: Eric Blake @ 2018-05-08 13:12 UTC (permalink / raw)
To: quintela, Michael S. Tsirkin
Cc: qemu-devel, berrange, kwolf, peter.maydell, Stefan Hajnoczi,
Fam Zheng, Dr. David Alan Gilbert, qemu-block
On 05/08/2018 07:21 AM, Juan Quintela wrote:
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>> When pulling in headers that are in the same directory as C file (as
>> opposed to one in include/), we should use its relative path, without a
>> directory. Directory based path works more or less by accident.
>
> No, it is not by accident.
> qemu-version.h and config-host.h are on the root directory. I could
> agree with moving them.
>
>> -#include "migration/qemu-file.h"
>> +#include "qemu-file.h"
>
> Substitite for "./qemu-file.h"?
>
> My wonder here is what happens if we end with a file with the same name in
> two places.
We already have at least:
include/qapi/qmp/qjson.h
migration/qjson.h
so it's not necessarily a theoretical question (things work now, but
renaming one or the other header may be in order as part of
consolidating everything into the /include hierarchy)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 16/67] migration: use local path for local headers
2018-05-08 13:12 ` Eric Blake
@ 2018-05-08 14:28 ` Juan Quintela
2018-05-08 14:54 ` Eric Blake
0 siblings, 1 reply; 144+ messages in thread
From: Juan Quintela @ 2018-05-08 14:28 UTC (permalink / raw)
To: Eric Blake
Cc: Michael S. Tsirkin, qemu-devel, berrange, kwolf, peter.maydell,
Stefan Hajnoczi, Fam Zheng, Dr. David Alan Gilbert, qemu-block
Eric Blake <eblake@redhat.com> wrote:
> On 05/08/2018 07:21 AM, Juan Quintela wrote:
>> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>>> When pulling in headers that are in the same directory as C file (as
>>> opposed to one in include/), we should use its relative path, without a
>>> directory. Directory based path works more or less by accident.
>>
>> No, it is not by accident.
>> qemu-version.h and config-host.h are on the root directory. I could
>> agree with moving them.
>>
>
>>> -#include "migration/qemu-file.h"
>>> +#include "qemu-file.h"
>>
>> Substitite for "./qemu-file.h"?
>>
>> My wonder here is what happens if we end with a file with the same name in
>> two places.
>
> We already have at least:
>
> include/qapi/qmp/qjson.h
> migration/qjson.h
>
> so it's not necessarily a theoretical question (things work now, but
> renaming one or the other header may be in order as part of
> consolidating everything into the /include hierarchy)
Internal ones also? The whole reason why I moved them to migration/* in
the first place was to be sure that they are internal, and that nobody
else uses them.
Later, Juan.
PD. And yes, I realize that we include $(ROOT) in the include path, and
then
#include "migration/migration.h" still works from any place.
sniff
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 16/67] migration: use local path for local headers
2018-05-08 14:28 ` Juan Quintela
@ 2018-05-08 14:54 ` Eric Blake
0 siblings, 0 replies; 144+ messages in thread
From: Eric Blake @ 2018-05-08 14:54 UTC (permalink / raw)
To: quintela
Cc: Michael S. Tsirkin, qemu-devel, berrange, kwolf, peter.maydell,
Stefan Hajnoczi, Fam Zheng, Dr. David Alan Gilbert, qemu-block
On 05/08/2018 09:28 AM, Juan Quintela wrote:
>>> My wonder here is what happens if we end with a file with the same name in
>>> two places.
>>
>> We already have at least:
>>
>> include/qapi/qmp/qjson.h
>> migration/qjson.h
>>
>> so it's not necessarily a theoretical question (things work now, but
>> renaming one or the other header may be in order as part of
>> consolidating everything into the /include hierarchy)
>
> Internal ones also? The whole reason why I moved them to migration/* in
> the first place was to be sure that they are internal, and that nobody
> else uses them.
>
> Later, Juan.
>
> PD. And yes, I realize that we include $(ROOT) in the include path, and
> then
>
> #include "migration/migration.h" still works from any place.
I think the goal of this series was to remove $(ROOT) from the include
path, so that all headers are either internal or obviously shared (and
one of the review comments mentioned that all of the earlier commits in
the series should directly mention this goal as part of the commit
message, rather than claiming just "works more or less by accident").
It's been a good RFC for getting feedback, and some of the patches are
worth applying even if others get reworked, but there are definitely
some questions to be resolved before v2 of the series.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 17/67] colo: use local path for local headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (15 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 16/67] migration: " Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-04 4:23 ` Zhang Chen
2018-05-03 19:50 ` [Qemu-devel] [PATCH 18/67] qga: " Michael S. Tsirkin
` (54 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Zhang Chen, Li Zhijian,
Jason Wang
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
net/colo-compare.c | 2 +-
net/colo.c | 2 +-
net/filter-rewriter.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 23b2d2c..c3a2be4 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -25,7 +25,7 @@
#include "net/queue.h"
#include "chardev/char-fe.h"
#include "qemu/sockets.h"
-#include "net/colo.h"
+#include "colo.h"
#include "sysemu/iothread.h"
#define TYPE_COLO_COMPARE "colo-compare"
diff --git a/net/colo.c b/net/colo.c
index 8426265..6dda4ed 100644
--- a/net/colo.c
+++ b/net/colo.c
@@ -14,7 +14,7 @@
#include "qemu/osdep.h"
#include "trace.h"
-#include "net/colo.h"
+#include "colo.h"
uint32_t connection_key_hash(const void *opaque)
{
diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c
index 62dad2d..f584e4e 100644
--- a/net/filter-rewriter.c
+++ b/net/filter-rewriter.c
@@ -11,7 +11,7 @@
#include "qemu/osdep.h"
#include "trace.h"
-#include "net/colo.h"
+#include "colo.h"
#include "net/filter.h"
#include "net/net.h"
#include "qemu-common.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 17/67] colo: use local path for local headers
2018-05-03 19:50 ` [Qemu-devel] [PATCH 17/67] colo: " Michael S. Tsirkin
@ 2018-05-04 4:23 ` Zhang Chen
0 siblings, 0 replies; 144+ messages in thread
From: Zhang Chen @ 2018-05-04 4:23 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, Eric Blake, berrange, Kevin Wolf, peter.maydell,
Li Zhijian, Jason Wang
On Fri, May 4, 2018 at 3:50 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
Reviewed-by: Zhang Chen <zhangckid@gmail.com>
> ---
> net/colo-compare.c | 2 +-
> net/colo.c | 2 +-
> net/filter-rewriter.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/colo-compare.c b/net/colo-compare.c
> index 23b2d2c..c3a2be4 100644
> --- a/net/colo-compare.c
> +++ b/net/colo-compare.c
> @@ -25,7 +25,7 @@
> #include "net/queue.h"
> #include "chardev/char-fe.h"
> #include "qemu/sockets.h"
> -#include "net/colo.h"
> +#include "colo.h"
> #include "sysemu/iothread.h"
>
> #define TYPE_COLO_COMPARE "colo-compare"
> diff --git a/net/colo.c b/net/colo.c
> index 8426265..6dda4ed 100644
> --- a/net/colo.c
> +++ b/net/colo.c
> @@ -14,7 +14,7 @@
>
> #include "qemu/osdep.h"
> #include "trace.h"
> -#include "net/colo.h"
> +#include "colo.h"
>
> uint32_t connection_key_hash(const void *opaque)
> {
> diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c
> index 62dad2d..f584e4e 100644
> --- a/net/filter-rewriter.c
> +++ b/net/filter-rewriter.c
> @@ -11,7 +11,7 @@
>
> #include "qemu/osdep.h"
> #include "trace.h"
> -#include "net/colo.h"
> +#include "colo.h"
> #include "net/filter.h"
> #include "net/net.h"
> #include "qemu-common.h"
> --
> MST
>
>
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 18/67] qga: use local path for local headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (16 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 17/67] colo: " Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-08 12:45 ` Philippe Mathieu-Daudé
2018-05-03 19:50 ` [Qemu-devel] [PATCH 19/67] xtensa: relative include for parent directory Michael S. Tsirkin
` (53 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Michael Roth
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
qga/channel-posix.c | 2 +-
qga/channel-win32.c | 4 ++--
qga/commands-posix.c | 2 +-
qga/commands-win32.c | 2 +-
qga/commands.c | 2 +-
qga/guest-agent-command-state.c | 2 +-
qga/main.c | 4 ++--
qga/vss-win32.c | 2 +-
8 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/qga/channel-posix.c b/qga/channel-posix.c
index b812bf4..5a925a9 100644
--- a/qga/channel-posix.c
+++ b/qga/channel-posix.c
@@ -2,7 +2,7 @@
#include <termios.h>
#include "qapi/error.h"
#include "qemu/sockets.h"
-#include "qga/channel.h"
+#include "channel.h"
#ifdef CONFIG_SOLARIS
#include <stropts.h>
diff --git a/qga/channel-win32.c b/qga/channel-win32.c
index 7e6dc4d..b3597a8 100644
--- a/qga/channel-win32.c
+++ b/qga/channel-win32.c
@@ -1,8 +1,8 @@
#include "qemu/osdep.h"
#include <windows.h>
#include <io.h>
-#include "qga/guest-agent-core.h"
-#include "qga/channel.h"
+#include "guest-agent-core.h"
+#include "channel.h"
typedef struct GAChannelReadState {
guint thread_id;
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 0dc219d..eae8171 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -16,7 +16,7 @@
#include <sys/utsname.h>
#include <sys/wait.h>
#include <dirent.h>
-#include "qga/guest-agent-core.h"
+#include "guest-agent-core.h"
#include "qga-qapi-commands.h"
#include "qapi/error.h"
#include "qapi/qmp/qerror.h"
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 2d48394..bc64fe8 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -32,7 +32,7 @@
#include <wtsapi32.h>
#include <wininet.h>
-#include "qga/guest-agent-core.h"
+#include "guest-agent-core.h"
#include "qga/vss-win32.h"
#include "qga-qapi-commands.h"
#include "qapi/error.h"
diff --git a/qga/commands.c b/qga/commands.c
index a64b34c..cce3010 100644
--- a/qga/commands.c
+++ b/qga/commands.c
@@ -11,7 +11,7 @@
*/
#include "qemu/osdep.h"
-#include "qga/guest-agent-core.h"
+#include "guest-agent-core.h"
#include "qga-qapi-commands.h"
#include "qapi/error.h"
#include "qapi/qmp/qerror.h"
diff --git a/qga/guest-agent-command-state.c b/qga/guest-agent-command-state.c
index e609d32..18bcb59 100644
--- a/qga/guest-agent-command-state.c
+++ b/qga/guest-agent-command-state.c
@@ -10,7 +10,7 @@
* See the COPYING file in the top-level directory.
*/
#include "qemu/osdep.h"
-#include "qga/guest-agent-core.h"
+#include "guest-agent-core.h"
struct GACommandState {
GSList *groups;
diff --git a/qga/main.c b/qga/main.c
index df1888e..127b51d 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -23,12 +23,12 @@
#include "qapi/qmp/qdict.h"
#include "qapi/qmp/qjson.h"
#include "qapi/qmp/qstring.h"
-#include "qga/guest-agent-core.h"
+#include "guest-agent-core.h"
#include "qemu/module.h"
#include "qga-qapi-commands.h"
#include "qapi/qmp/qerror.h"
#include "qapi/error.h"
-#include "qga/channel.h"
+#include "channel.h"
#include "qemu/bswap.h"
#include "qemu/help_option.h"
#include "qemu/sockets.h"
diff --git a/qga/vss-win32.c b/qga/vss-win32.c
index 0199c2a..e834ec5 100644
--- a/qga/vss-win32.c
+++ b/qga/vss-win32.c
@@ -14,7 +14,7 @@
#include <windows.h>
#include "qapi/error.h"
#include "qemu/error-report.h"
-#include "qga/guest-agent-core.h"
+#include "guest-agent-core.h"
#include "qga/vss-win32.h"
#include "qga/vss-win32/requester.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 18/67] qga: use local path for local headers
2018-05-03 19:50 ` [Qemu-devel] [PATCH 18/67] qga: " Michael S. Tsirkin
@ 2018-05-08 12:45 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 144+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-05-08 12:45 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: kwolf, Michael Roth, peter.maydell
Hi Michael,
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> qga/channel-posix.c | 2 +-
> qga/channel-win32.c | 4 ++--
> qga/commands-posix.c | 2 +-
> qga/commands-win32.c | 2 +-
> qga/commands.c | 2 +-
> qga/guest-agent-command-state.c | 2 +-
> qga/main.c | 4 ++--
> qga/vss-win32.c | 2 +-
> 8 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/qga/channel-posix.c b/qga/channel-posix.c
> index b812bf4..5a925a9 100644
> --- a/qga/channel-posix.c
> +++ b/qga/channel-posix.c
> @@ -2,7 +2,7 @@
> #include <termios.h>
> #include "qapi/error.h"
> #include "qemu/sockets.h"
> -#include "qga/channel.h"
> +#include "channel.h"
>
> #ifdef CONFIG_SOLARIS
> #include <stropts.h>
> diff --git a/qga/channel-win32.c b/qga/channel-win32.c
> index 7e6dc4d..b3597a8 100644
> --- a/qga/channel-win32.c
> +++ b/qga/channel-win32.c
> @@ -1,8 +1,8 @@
> #include "qemu/osdep.h"
> #include <windows.h>
> #include <io.h>
> -#include "qga/guest-agent-core.h"
> -#include "qga/channel.h"
> +#include "guest-agent-core.h"
> +#include "channel.h"
>
> typedef struct GAChannelReadState {
> guint thread_id;
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index 0dc219d..eae8171 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -16,7 +16,7 @@
> #include <sys/utsname.h>
> #include <sys/wait.h>
> #include <dirent.h>
> -#include "qga/guest-agent-core.h"
> +#include "guest-agent-core.h"
> #include "qga-qapi-commands.h"
> #include "qapi/error.h"
> #include "qapi/qmp/qerror.h"
> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> index 2d48394..bc64fe8 100644
> --- a/qga/commands-win32.c
> +++ b/qga/commands-win32.c
> @@ -32,7 +32,7 @@
> #include <wtsapi32.h>
> #include <wininet.h>
>
> -#include "qga/guest-agent-core.h"
> +#include "guest-agent-core.h"
> #include "qga/vss-win32.h"
You missed:
#include "vss-win32.h"
> #include "qga-qapi-commands.h"
> #include "qapi/error.h"
> diff --git a/qga/commands.c b/qga/commands.c
> index a64b34c..cce3010 100644
> --- a/qga/commands.c
> +++ b/qga/commands.c
> @@ -11,7 +11,7 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qga/guest-agent-core.h"
> +#include "guest-agent-core.h"
> #include "qga-qapi-commands.h"
> #include "qapi/error.h"
> #include "qapi/qmp/qerror.h"
> diff --git a/qga/guest-agent-command-state.c b/qga/guest-agent-command-state.c
> index e609d32..18bcb59 100644
> --- a/qga/guest-agent-command-state.c
> +++ b/qga/guest-agent-command-state.c
> @@ -10,7 +10,7 @@
> * See the COPYING file in the top-level directory.
> */
> #include "qemu/osdep.h"
> -#include "qga/guest-agent-core.h"
> +#include "guest-agent-core.h"
>
> struct GACommandState {
> GSList *groups;
> diff --git a/qga/main.c b/qga/main.c
> index df1888e..127b51d 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -23,12 +23,12 @@
> #include "qapi/qmp/qdict.h"
> #include "qapi/qmp/qjson.h"
> #include "qapi/qmp/qstring.h"
> -#include "qga/guest-agent-core.h"
> +#include "guest-agent-core.h"
> #include "qemu/module.h"
> #include "qga-qapi-commands.h"
> #include "qapi/qmp/qerror.h"
> #include "qapi/error.h"
> -#include "qga/channel.h"
> +#include "channel.h"
> #include "qemu/bswap.h"
> #include "qemu/help_option.h"
> #include "qemu/sockets.h"
> diff --git a/qga/vss-win32.c b/qga/vss-win32.c
> index 0199c2a..e834ec5 100644
> --- a/qga/vss-win32.c
> +++ b/qga/vss-win32.c
> @@ -14,7 +14,7 @@
> #include <windows.h>
> #include "qapi/error.h"
> #include "qemu/error-report.h"
> -#include "qga/guest-agent-core.h"
> +#include "guest-agent-core.h"
> #include "qga/vss-win32.h"
> #include "qga/vss-win32/requester.h"
Ditto, "vss-win32.h" and "vss-win32/requester.h".
Fixing vss-win32:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 19/67] xtensa: relative include for parent directory
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (17 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 18/67] qga: " Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-03 19:50 ` [Qemu-devel] [PATCH 20/67] tests: relative include for child directory Michael S. Tsirkin
` (52 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Max Filippov
When pulling in headers that are in the parent directory of the C file
(as opposed to one in include/), we should use its relative path, with
".." as a directory. Path without a directory works more or less by
accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
target/xtensa/core-dc232b/xtensa-modules.inc.c | 4 ++--
target/xtensa/core-dc233c/xtensa-modules.inc.c | 4 ++--
target/xtensa/core-de212/xtensa-modules.inc.c | 4 ++--
target/xtensa/core-fsf/xtensa-modules.inc.c | 4 ++--
target/xtensa/core-sample_controller/xtensa-modules.inc.c | 4 ++--
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/target/xtensa/core-dc232b/xtensa-modules.inc.c b/target/xtensa/core-dc232b/xtensa-modules.inc.c
index d322c3f..ab46f70 100644
--- a/target/xtensa/core-dc232b/xtensa-modules.inc.c
+++ b/target/xtensa/core-dc232b/xtensa-modules.inc.c
@@ -19,8 +19,8 @@
02110-1301, USA. */
#include "qemu/osdep.h"
-#include "xtensa-isa.h"
-#include "xtensa-isa-internal.h"
+#include "../xtensa-isa.h"
+#include "../xtensa-isa-internal.h"
\f
/* Sysregs. */
diff --git a/target/xtensa/core-dc233c/xtensa-modules.inc.c b/target/xtensa/core-dc233c/xtensa-modules.inc.c
index 7c20f82..a7ea8cf 100644
--- a/target/xtensa/core-dc233c/xtensa-modules.inc.c
+++ b/target/xtensa/core-dc233c/xtensa-modules.inc.c
@@ -22,8 +22,8 @@
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
#include "qemu/osdep.h"
-#include "xtensa-isa.h"
-#include "xtensa-isa-internal.h"
+#include "../xtensa-isa.h"
+#include "../xtensa-isa-internal.h"
\f
/* Sysregs. */
diff --git a/target/xtensa/core-de212/xtensa-modules.inc.c b/target/xtensa/core-de212/xtensa-modules.inc.c
index ef7674d..ef34b85 100644
--- a/target/xtensa/core-de212/xtensa-modules.inc.c
+++ b/target/xtensa/core-de212/xtensa-modules.inc.c
@@ -22,8 +22,8 @@
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
#include "qemu/osdep.h"
-#include "xtensa-isa.h"
-#include "xtensa-isa-internal.h"
+#include "../xtensa-isa.h"
+#include "../xtensa-isa-internal.h"
\f
/* Sysregs. */
diff --git a/target/xtensa/core-fsf/xtensa-modules.inc.c b/target/xtensa/core-fsf/xtensa-modules.inc.c
index f7de2de..13a36a5 100644
--- a/target/xtensa/core-fsf/xtensa-modules.inc.c
+++ b/target/xtensa/core-fsf/xtensa-modules.inc.c
@@ -19,8 +19,8 @@
02110-1301, USA. */
#include "qemu/osdep.h"
-#include "xtensa-isa.h"
-#include "xtensa-isa-internal.h"
+#include "../xtensa-isa.h"
+#include "../xtensa-isa-internal.h"
\f
/* Sysregs. */
diff --git a/target/xtensa/core-sample_controller/xtensa-modules.inc.c b/target/xtensa/core-sample_controller/xtensa-modules.inc.c
index fba41b9..51285b4 100644
--- a/target/xtensa/core-sample_controller/xtensa-modules.inc.c
+++ b/target/xtensa/core-sample_controller/xtensa-modules.inc.c
@@ -22,8 +22,8 @@
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
#include "qemu/osdep.h"
-#include "xtensa-isa.h"
-#include "xtensa-isa-internal.h"
+#include "../xtensa-isa.h"
+#include "../xtensa-isa-internal.h"
\f
/* Sysregs. */
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 20/67] tests: relative include for child directory
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (18 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 19/67] xtensa: relative include for parent directory Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-08 12:22 ` Juan Quintela
2018-05-03 19:50 ` [Qemu-devel] [PATCH 21/67] trace: use local path for local headers Michael S. Tsirkin
` (51 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Juan Quintela,
Dr. David Alan Gilbert
When pulling in headers that are in the child directory of the C file
(as opposed to one in include/), we should use its relative path, with
name of the child directory. Full path including the current directory
works more or less by accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
tests/migration-test.c | 2 +-
tests/pkix_asn1_tab.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index 422bf1a..be8d564 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -80,7 +80,7 @@ static const char *tmpfs;
/* A simple PC boot sector that modifies memory (1-100MB) quickly
* outputting a 'B' every so often if it's still running.
*/
-#include "tests/migration/x86-a-b-bootblock.h"
+#include "migration/x86-a-b-bootblock.h"
static void init_bootfile_x86(const char *bootpath)
{
diff --git a/tests/pkix_asn1_tab.c b/tests/pkix_asn1_tab.c
index f15fc51..f3bb2c7 100644
--- a/tests/pkix_asn1_tab.c
+++ b/tests/pkix_asn1_tab.c
@@ -4,7 +4,7 @@
*/
#include "qemu/osdep.h"
-#include "tests/crypto-tls-x509-helpers.h"
+#include "crypto-tls-x509-helpers.h"
#ifdef QCRYPTO_HAVE_TLS_TEST_SUPPORT
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 21/67] trace: use local path for local headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (19 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 20/67] tests: relative include for child directory Michael S. Tsirkin
@ 2018-05-03 19:50 ` Michael S. Tsirkin
2018-05-04 8:09 ` Stefan Hajnoczi
2018-05-04 16:36 ` Philippe Mathieu-Daudé
2018-05-03 19:51 ` [Qemu-devel] [PATCH 22/67] ui: " Michael S. Tsirkin
` (50 subsequent siblings)
71 siblings, 2 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:50 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Stefan Hajnoczi
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
trace/qmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/trace/qmp.c b/trace/qmp.c
index 756086c..ea99b00 100644
--- a/trace/qmp.c
+++ b/trace/qmp.c
@@ -10,7 +10,7 @@
#include "qemu/osdep.h"
#include "qapi/error.h"
#include "qapi/qapi-commands-trace.h"
-#include "trace/control.h"
+#include "control.h"
static CPUState *get_cpu(bool has_vcpu, int vcpu, Error **errp)
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 21/67] trace: use local path for local headers
2018-05-03 19:50 ` [Qemu-devel] [PATCH 21/67] trace: use local path for local headers Michael S. Tsirkin
@ 2018-05-04 8:09 ` Stefan Hajnoczi
2018-05-04 16:36 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 144+ messages in thread
From: Stefan Hajnoczi @ 2018-05-04 8:09 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
On Thu, May 03, 2018 at 10:50:59PM +0300, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> trace/qmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 21/67] trace: use local path for local headers
2018-05-03 19:50 ` [Qemu-devel] [PATCH 21/67] trace: use local path for local headers Michael S. Tsirkin
2018-05-04 8:09 ` Stefan Hajnoczi
@ 2018-05-04 16:36 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 144+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-05-04 16:36 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: kwolf, Stefan Hajnoczi, peter.maydell
On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Can this be squashed with your 6/67?
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> trace/qmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/trace/qmp.c b/trace/qmp.c
> index 756086c..ea99b00 100644
> --- a/trace/qmp.c
> +++ b/trace/qmp.c
> @@ -10,7 +10,7 @@
> #include "qemu/osdep.h"
> #include "qapi/error.h"
> #include "qapi/qapi-commands-trace.h"
> -#include "trace/control.h"
> +#include "control.h"
>
>
> static CPUState *get_cpu(bool has_vcpu, int vcpu, Error **errp)
>
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 22/67] ui: use local path for local headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (20 preceding siblings ...)
2018-05-03 19:50 ` [Qemu-devel] [PATCH 21/67] trace: use local path for local headers Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-08 12:47 ` Philippe Mathieu-Daudé
2018-05-03 19:51 ` [Qemu-devel] [PATCH 23/67] slirp: add include directory headers Michael S. Tsirkin
` (49 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Gerd Hoffmann
When pulling in headers that are in the same directory as C file (as
opposed to one in include/), we should use its relative path, without a
directory. Directory based path works more or less by accident.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
ui/gtk.c | 2 +-
ui/input-keymap.c | 2 +-
ui/input-legacy.c | 2 +-
ui/spice-input.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index bb3214c..e723304 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -66,7 +66,7 @@
#define VC_SCALE_STEP 0.25
#ifdef GDK_WINDOWING_X11
-#include "ui/x_keymap.h"
+#include "x_keymap.h"
/* Gtk2 compat */
#ifndef GDK_IS_X11_DISPLAY
diff --git a/ui/input-keymap.c b/ui/input-keymap.c
index 3d4e66b..87cc301 100644
--- a/ui/input-keymap.c
+++ b/ui/input-keymap.c
@@ -1,6 +1,6 @@
#include "qemu/osdep.h"
#include "sysemu/sysemu.h"
-#include "ui/keymaps.h"
+#include "keymaps.h"
#include "ui/input.h"
#include "standard-headers/linux/input.h"
diff --git a/ui/input-legacy.c b/ui/input-legacy.c
index e5d4db1..549654e 100644
--- a/ui/input-legacy.c
+++ b/ui/input-legacy.c
@@ -26,7 +26,7 @@
#include "qapi/qapi-commands-ui.h"
#include "sysemu/sysemu.h"
#include "ui/console.h"
-#include "ui/keymaps.h"
+#include "keymaps.h"
#include "ui/input.h"
struct QEMUPutMouseEntry {
diff --git a/ui/spice-input.c b/ui/spice-input.c
index 3d41aa1..a426c03 100644
--- a/ui/spice-input.c
+++ b/ui/spice-input.c
@@ -23,7 +23,7 @@
#include "qemu-common.h"
#include "ui/qemu-spice.h"
#include "ui/console.h"
-#include "ui/keymaps.h"
+#include "keymaps.h"
#include "ui/input.h"
/* keyboard bits */
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 22/67] ui: use local path for local headers
2018-05-03 19:51 ` [Qemu-devel] [PATCH 22/67] ui: " Michael S. Tsirkin
@ 2018-05-08 12:47 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 144+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-05-08 12:47 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel, Gerd Hoffmann; +Cc: kwolf, peter.maydell
On 05/03/2018 04:51 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> ui/gtk.c | 2 +-
> ui/input-keymap.c | 2 +-
> ui/input-legacy.c | 2 +-
> ui/spice-input.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/ui/gtk.c b/ui/gtk.c
> index bb3214c..e723304 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -66,7 +66,7 @@
> #define VC_SCALE_STEP 0.25
>
> #ifdef GDK_WINDOWING_X11
> -#include "ui/x_keymap.h"
> +#include "x_keymap.h"
>
> /* Gtk2 compat */
> #ifndef GDK_IS_X11_DISPLAY
> diff --git a/ui/input-keymap.c b/ui/input-keymap.c
> index 3d4e66b..87cc301 100644
> --- a/ui/input-keymap.c
> +++ b/ui/input-keymap.c
> @@ -1,6 +1,6 @@
> #include "qemu/osdep.h"
> #include "sysemu/sysemu.h"
> -#include "ui/keymaps.h"
> +#include "keymaps.h"
> #include "ui/input.h"
>
> #include "standard-headers/linux/input.h"
> diff --git a/ui/input-legacy.c b/ui/input-legacy.c
> index e5d4db1..549654e 100644
> --- a/ui/input-legacy.c
> +++ b/ui/input-legacy.c
> @@ -26,7 +26,7 @@
> #include "qapi/qapi-commands-ui.h"
> #include "sysemu/sysemu.h"
> #include "ui/console.h"
> -#include "ui/keymaps.h"
> +#include "keymaps.h"
> #include "ui/input.h"
>
> struct QEMUPutMouseEntry {
> diff --git a/ui/spice-input.c b/ui/spice-input.c
> index 3d41aa1..a426c03 100644
> --- a/ui/spice-input.c
> +++ b/ui/spice-input.c
> @@ -23,7 +23,7 @@
> #include "qemu-common.h"
> #include "ui/qemu-spice.h"
> #include "ui/console.h"
> -#include "ui/keymaps.h"
> +#include "keymaps.h"
> #include "ui/input.h"
>
> /* keyboard bits */
>
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 23/67] slirp: add include directory headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (21 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 22/67] ui: " Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-31 18:50 ` Samuel Thibault
2018-05-03 19:51 ` [Qemu-devel] [PATCH 25/67] arch_init: sort architectures Michael S. Tsirkin
` (48 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way they are easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/slirp/ip6.h | 1 +
include/slirp/libslirp.h | 1 +
include/slirp/slirp.h | 1 +
3 files changed, 3 insertions(+)
create mode 100644 include/slirp/ip6.h
create mode 100644 include/slirp/libslirp.h
create mode 100644 include/slirp/slirp.h
diff --git a/include/slirp/ip6.h b/include/slirp/ip6.h
new file mode 100644
index 0000000..432cc36
--- /dev/null
+++ b/include/slirp/ip6.h
@@ -0,0 +1 @@
+#include_next "../slirp/ip6.h"
diff --git a/include/slirp/libslirp.h b/include/slirp/libslirp.h
new file mode 100644
index 0000000..acab168
--- /dev/null
+++ b/include/slirp/libslirp.h
@@ -0,0 +1 @@
+#include_next "../slirp/libslirp.h"
diff --git a/include/slirp/slirp.h b/include/slirp/slirp.h
new file mode 100644
index 0000000..826a97d
--- /dev/null
+++ b/include/slirp/slirp.h
@@ -0,0 +1 @@
+#include_next "../slirp/slirp.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 23/67] slirp: add include directory headers
2018-05-03 19:51 ` [Qemu-devel] [PATCH 23/67] slirp: add include directory headers Michael S. Tsirkin
@ 2018-05-31 18:50 ` Samuel Thibault
2018-05-31 19:25 ` Michael S. Tsirkin
0 siblings, 1 reply; 144+ messages in thread
From: Samuel Thibault @ 2018-05-31 18:50 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel, kwolf, peter.maydell
Hello,
Michael S. Tsirkin, le jeu. 03 mai 2018 22:51:01 +0300, a ecrit:
> +#include_next "../slirp/ip6.h"
Mmm, this is the first time #include_next would be used in qemu, and I
don't think this is a standard thing...
Samuel
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 23/67] slirp: add include directory headers
2018-05-31 18:50 ` Samuel Thibault
@ 2018-05-31 19:25 ` Michael S. Tsirkin
0 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-31 19:25 UTC (permalink / raw)
To: Samuel Thibault; +Cc: qemu-devel, kwolf, peter.maydell
On Thu, May 31, 2018 at 08:50:32PM +0200, Samuel Thibault wrote:
> Hello,
>
> Michael S. Tsirkin, le jeu. 03 mai 2018 22:51:01 +0300, a ecrit:
> > +#include_next "../slirp/ip6.h"
>
> Mmm, this is the first time #include_next would be used in qemu, and I
> don't think this is a standard thing...
>
> Samuel
Well we don't support arbitrary compilers, and
gcc and clang both have it.
It's also a temporary thing, then intent is for maintainers
to drop these after deciding on either code refactoring
or just moving header to include.
--
MST
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 25/67] arch_init: sort architectures
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (22 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 23/67] slirp: add include directory headers Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 24/67] net: add include directory headers Michael S. Tsirkin
` (47 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Richard Henderson,
Gerd Hoffmann, David Gibson, Eduardo Habkost, Thomas Huth
Sort alphabetically. Will help us see if anything is missing (e.g. tile
is not there now).
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
arch_init.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 6ee0747..c35cd1d 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -51,14 +51,14 @@ int graphic_depth = 32;
#define QEMU_ARCH QEMU_ARCH_ARM
#elif defined(TARGET_CRIS)
#define QEMU_ARCH QEMU_ARCH_CRIS
-#elif defined(TARGET_I386)
-#define QEMU_ARCH QEMU_ARCH_I386
#elif defined(TARGET_HPPA)
#define QEMU_ARCH QEMU_ARCH_HPPA
-#elif defined(TARGET_M68K)
-#define QEMU_ARCH QEMU_ARCH_M68K
+#elif defined(TARGET_I386)
+#define QEMU_ARCH QEMU_ARCH_I386
#elif defined(TARGET_LM32)
#define QEMU_ARCH QEMU_ARCH_LM32
+#elif defined(TARGET_M68K)
+#define QEMU_ARCH QEMU_ARCH_M68K
#elif defined(TARGET_MICROBLAZE)
#define QEMU_ARCH QEMU_ARCH_MICROBLAZE
#elif defined(TARGET_MIPS)
@@ -79,12 +79,12 @@ int graphic_depth = 32;
#define QEMU_ARCH QEMU_ARCH_SH4
#elif defined(TARGET_SPARC)
#define QEMU_ARCH QEMU_ARCH_SPARC
-#elif defined(TARGET_XTENSA)
-#define QEMU_ARCH QEMU_ARCH_XTENSA
-#elif defined(TARGET_UNICORE32)
-#define QEMU_ARCH QEMU_ARCH_UNICORE32
#elif defined(TARGET_TRICORE)
#define QEMU_ARCH QEMU_ARCH_TRICORE
+#elif defined(TARGET_UNICORE32)
+#define QEMU_ARCH QEMU_ARCH_UNICORE32
+#elif defined(TARGET_XTENSA)
+#define QEMU_ARCH QEMU_ARCH_XTENSA
#endif
const uint32_t arch_type = QEMU_ARCH;
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 24/67] net: add include directory headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (23 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 25/67] arch_init: sort architectures Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 26/67] cpu: replace command line flags with preprocessor Michael S. Tsirkin
` (46 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Jason Wang
This way they are easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/net/hub.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/net/hub.h
diff --git a/include/net/hub.h b/include/net/hub.h
new file mode 100644
index 0000000..de8dfff
--- /dev/null
+++ b/include/net/hub.h
@@ -0,0 +1 @@
+#include_next "../net/hub.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 26/67] cpu: replace command line flags with preprocessor
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (24 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 24/67] net: add include directory headers Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 20:08 ` Eric Blake
2018-05-04 0:35 ` Thomas Huth
2018-05-03 19:51 ` [Qemu-devel] [PATCH 27/67] replication: add include directory header Michael S. Tsirkin
` (45 subsequent siblings)
71 siblings, 2 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
Each target is currently built with a different set of include
directories, this is what makes it possible to pull in a separate copy
of cpu.h depending on the target.
Replace with per-target ifdefs which are easier to understand.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/cpu.h | 2 ++
1 file changed, 2 insertions(+)
create mode 100644 include/cpu.h
diff --git a/include/cpu.h b/include/cpu.h
new file mode 100644
index 0000000..b18f163
--- /dev/null
+++ b/include/cpu.h
@@ -0,0 +1,2 @@
+#include "target-dir.h"
+#include TARGET_DIR(cpu.h)
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 26/67] cpu: replace command line flags with preprocessor
2018-05-03 19:51 ` [Qemu-devel] [PATCH 26/67] cpu: replace command line flags with preprocessor Michael S. Tsirkin
@ 2018-05-03 20:08 ` Eric Blake
2018-05-04 0:35 ` Thomas Huth
1 sibling, 0 replies; 144+ messages in thread
From: Eric Blake @ 2018-05-03 20:08 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: berrange, kwolf, peter.maydell
On 05/03/2018 02:51 PM, Michael S. Tsirkin wrote:
> Each target is currently built with a different set of include
> directories, this is what makes it possible to pull in a separate copy
> of cpu.h depending on the target.
>
> Replace with per-target ifdefs which are easier to understand.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/cpu.h | 2 ++
> 1 file changed, 2 insertions(+)
> create mode 100644 include/cpu.h
>
> diff --git a/include/cpu.h b/include/cpu.h
> new file mode 100644
> index 0000000..b18f163
> --- /dev/null
> +++ b/include/cpu.h
> @@ -0,0 +1,2 @@
> +#include "target-dir.h"
> +#include TARGET_DIR(cpu.h)
Out-of-order patch? I don't see target-dir.h created anywhere earlier
in this series.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 26/67] cpu: replace command line flags with preprocessor
2018-05-03 19:51 ` [Qemu-devel] [PATCH 26/67] cpu: replace command line flags with preprocessor Michael S. Tsirkin
2018-05-03 20:08 ` Eric Blake
@ 2018-05-04 0:35 ` Thomas Huth
2018-05-04 1:01 ` Michael S. Tsirkin
1 sibling, 1 reply; 144+ messages in thread
From: Thomas Huth @ 2018-05-04 0:35 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: kwolf, peter.maydell, Eric Blake, Richard Henderson, Paolo Bonzini
On 03.05.2018 21:51, Michael S. Tsirkin wrote:
> Each target is currently built with a different set of include
> directories, this is what makes it possible to pull in a separate copy
> of cpu.h depending on the target.
>
> Replace with per-target ifdefs which are easier to understand.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/cpu.h | 2 ++
> 1 file changed, 2 insertions(+)
> create mode 100644 include/cpu.h
>
> diff --git a/include/cpu.h b/include/cpu.h
> new file mode 100644
> index 0000000..b18f163
> --- /dev/null
> +++ b/include/cpu.h
> @@ -0,0 +1,2 @@
> +#include "target-dir.h"
> +#include TARGET_DIR(cpu.h)
That's a *bad* idea. As far as I can see, this way, cpu.h is now
suddenly available to generic, non-target specific code. The headers in
target/* are "hidden" by purpose for all code that gets compiled via
common-obj-y and if you now make it available for everybody again, we'll
end up in ugly situation where common code might have been compiled with
target specific defines from target specific headers... Please don't do
that!
Thomas
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 26/67] cpu: replace command line flags with preprocessor
2018-05-04 0:35 ` Thomas Huth
@ 2018-05-04 1:01 ` Michael S. Tsirkin
2018-05-04 1:11 ` Thomas Huth
0 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-04 1:01 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, kwolf, peter.maydell, Eric Blake, Richard Henderson,
Paolo Bonzini
On Fri, May 04, 2018 at 02:35:49AM +0200, Thomas Huth wrote:
> On 03.05.2018 21:51, Michael S. Tsirkin wrote:
> > Each target is currently built with a different set of include
> > directories, this is what makes it possible to pull in a separate copy
> > of cpu.h depending on the target.
> >
> > Replace with per-target ifdefs which are easier to understand.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > include/cpu.h | 2 ++
> > 1 file changed, 2 insertions(+)
> > create mode 100644 include/cpu.h
> >
> > diff --git a/include/cpu.h b/include/cpu.h
> > new file mode 100644
> > index 0000000..b18f163
> > --- /dev/null
> > +++ b/include/cpu.h
> > @@ -0,0 +1,2 @@
> > +#include "target-dir.h"
> > +#include TARGET_DIR(cpu.h)
>
> That's a *bad* idea. As far as I can see, this way, cpu.h is now
> suddenly available to generic, non-target specific code. The headers in
> target/* are "hidden" by purpose for all code that gets compiled via
> common-obj-y and if you now make it available for everybody again, we'll
> end up in ugly situation where common code might have been compiled with
> target specific defines from target specific headers... Please don't do
> that!
>
> Thomas
Are you sure that is the case? TARGET_XXX defines really shouldn't be
set for non-target specific code.
--
MST
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 26/67] cpu: replace command line flags with preprocessor
2018-05-04 1:01 ` Michael S. Tsirkin
@ 2018-05-04 1:11 ` Thomas Huth
0 siblings, 0 replies; 144+ messages in thread
From: Thomas Huth @ 2018-05-04 1:11 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, kwolf, peter.maydell, Eric Blake, Richard Henderson,
Paolo Bonzini
On 04.05.2018 03:01, Michael S. Tsirkin wrote:
> On Fri, May 04, 2018 at 02:35:49AM +0200, Thomas Huth wrote:
>> On 03.05.2018 21:51, Michael S. Tsirkin wrote:
>>> Each target is currently built with a different set of include
>>> directories, this is what makes it possible to pull in a separate copy
>>> of cpu.h depending on the target.
>>>
>>> Replace with per-target ifdefs which are easier to understand.
>>>
>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>> ---
>>> include/cpu.h | 2 ++
>>> 1 file changed, 2 insertions(+)
>>> create mode 100644 include/cpu.h
>>>
>>> diff --git a/include/cpu.h b/include/cpu.h
>>> new file mode 100644
>>> index 0000000..b18f163
>>> --- /dev/null
>>> +++ b/include/cpu.h
>>> @@ -0,0 +1,2 @@
>>> +#include "target-dir.h"
>>> +#include TARGET_DIR(cpu.h)
>>
>> That's a *bad* idea. As far as I can see, this way, cpu.h is now
>> suddenly available to generic, non-target specific code. The headers in
>> target/* are "hidden" by purpose for all code that gets compiled via
>> common-obj-y and if you now make it available for everybody again, we'll
>> end up in ugly situation where common code might have been compiled with
>> target specific defines from target specific headers... Please don't do
>> that!
>>
>> Thomas
>
> Are you sure that is the case? TARGET_XXX defines really shouldn't be
> set for non-target specific code.
Hm, ok, now I see that you've added a
#else
#error "Target-specific directory include missing"
in that target-dir.h header. So instead of not being able to include the
header since it is not in the header search path, we now will get an
error message instead... ok, that should be fine, too, so never mind.
Thomas
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 27/67] replication: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (25 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 26/67] cpu: replace command line flags with preprocessor Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-04 9:29 ` Daniel P. Berrangé
2018-05-03 19:51 ` [Qemu-devel] [PATCH 29/67] fsdev: add include directory headers Michael S. Tsirkin
` (44 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/replication.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/replication.h
diff --git a/include/replication.h b/include/replication.h
new file mode 100644
index 0000000..2f40e8e
--- /dev/null
+++ b/include/replication.h
@@ -0,0 +1 @@
+#include_next "../replication.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 27/67] replication: add include directory header
2018-05-03 19:51 ` [Qemu-devel] [PATCH 27/67] replication: add include directory header Michael S. Tsirkin
@ 2018-05-04 9:29 ` Daniel P. Berrangé
2018-05-04 14:52 ` Michael S. Tsirkin
0 siblings, 1 reply; 144+ messages in thread
From: Daniel P. Berrangé @ 2018-05-04 9:29 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel, eblake, kwolf, peter.maydell
On Thu, May 03, 2018 at 10:51:05PM +0300, Michael S. Tsirkin wrote:
> This way it is easier to find using standard rules.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/replication.h | 1 +
> 1 file changed, 1 insertion(+)
> create mode 100644 include/replication.h
>
> diff --git a/include/replication.h b/include/replication.h
> new file mode 100644
> index 0000000..2f40e8e
> --- /dev/null
> +++ b/include/replication.h
> @@ -0,0 +1 @@
> +#include_next "../replication.h"
I think this is really crazy. If we want the headers to be accessible
via the include/ directory, lets move them to the include/ directory,
not create wrappers that point back to the source directory.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 27/67] replication: add include directory header
2018-05-04 9:29 ` Daniel P. Berrangé
@ 2018-05-04 14:52 ` Michael S. Tsirkin
2018-05-04 15:04 ` Daniel P. Berrangé
0 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-04 14:52 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: qemu-devel, eblake, kwolf, peter.maydell
On Fri, May 04, 2018 at 10:29:24AM +0100, Daniel P. Berrangé wrote:
> On Thu, May 03, 2018 at 10:51:05PM +0300, Michael S. Tsirkin wrote:
> > This way it is easier to find using standard rules.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > include/replication.h | 1 +
> > 1 file changed, 1 insertion(+)
> > create mode 100644 include/replication.h
> >
> > diff --git a/include/replication.h b/include/replication.h
> > new file mode 100644
> > index 0000000..2f40e8e
> > --- /dev/null
> > +++ b/include/replication.h
> > @@ -0,0 +1 @@
> > +#include_next "../replication.h"
>
> I think this is really crazy. If we want the headers to be accessible
> via the include/ directory, lets move them to the include/ directory,
> not create wrappers that point back to the source directory.
>
> Regards,
> Daniel
True. I did that initially. However I think maintainers should do this
otherwise this amounts to moving internal headers to include/ wholesale.
At least this patch will stop proliferation of new headers in source
directories.
And with these patches external headers in source directory are
easy to identify.
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 27/67] replication: add include directory header
2018-05-04 14:52 ` Michael S. Tsirkin
@ 2018-05-04 15:04 ` Daniel P. Berrangé
0 siblings, 0 replies; 144+ messages in thread
From: Daniel P. Berrangé @ 2018-05-04 15:04 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel, eblake, kwolf, peter.maydell
On Fri, May 04, 2018 at 05:52:39PM +0300, Michael S. Tsirkin wrote:
> On Fri, May 04, 2018 at 10:29:24AM +0100, Daniel P. Berrangé wrote:
> > On Thu, May 03, 2018 at 10:51:05PM +0300, Michael S. Tsirkin wrote:
> > > This way it is easier to find using standard rules.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > ---
> > > include/replication.h | 1 +
> > > 1 file changed, 1 insertion(+)
> > > create mode 100644 include/replication.h
> > >
> > > diff --git a/include/replication.h b/include/replication.h
> > > new file mode 100644
> > > index 0000000..2f40e8e
> > > --- /dev/null
> > > +++ b/include/replication.h
> > > @@ -0,0 +1 @@
> > > +#include_next "../replication.h"
> >
> > I think this is really crazy. If we want the headers to be accessible
> > via the include/ directory, lets move them to the include/ directory,
> > not create wrappers that point back to the source directory.
> >
> > Regards,
> > Daniel
>
> True. I did that initially. However I think maintainers should do this
> otherwise this amounts to moving internal headers to include/ wholesale.
Your change amounts the very same thing IMHO. A #include will find the
"internal" header via include/... If the header is currently used from
outside its source dir, then it is defacto not an internal header any
more, so we should just move it. If some subset of the header is
internal, the maintainer can decide to separate the internal vs shared
bits later if desired.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 29/67] fsdev: add include directory headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (26 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 27/67] replication: add include directory header Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 28/67] 9pfs: " Michael S. Tsirkin
` (43 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way they are easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/fsdev/9p-iov-marshal.h | 1 +
include/fsdev/file-op-9p.h | 1 +
include/fsdev/qemu-fsdev.h | 1 +
3 files changed, 3 insertions(+)
create mode 100644 include/fsdev/9p-iov-marshal.h
create mode 100644 include/fsdev/file-op-9p.h
create mode 100644 include/fsdev/qemu-fsdev.h
diff --git a/include/fsdev/9p-iov-marshal.h b/include/fsdev/9p-iov-marshal.h
new file mode 100644
index 0000000..8e608e9
--- /dev/null
+++ b/include/fsdev/9p-iov-marshal.h
@@ -0,0 +1 @@
+#include_next "../fsdev/9p-iov-marshal.h"
diff --git a/include/fsdev/file-op-9p.h b/include/fsdev/file-op-9p.h
new file mode 100644
index 0000000..782a83d
--- /dev/null
+++ b/include/fsdev/file-op-9p.h
@@ -0,0 +1 @@
+#include_next "../fsdev/file-op-9p.h"
diff --git a/include/fsdev/qemu-fsdev.h b/include/fsdev/qemu-fsdev.h
new file mode 100644
index 0000000..b7b8b87
--- /dev/null
+++ b/include/fsdev/qemu-fsdev.h
@@ -0,0 +1 @@
+#include_next "../fsdev/qemu-fsdev.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 28/67] 9pfs: add include directory headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (27 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 29/67] fsdev: add include directory headers Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 31/67] target/cris: add include directory header Michael S. Tsirkin
` (42 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way they are easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/9pfs/9p-proxy.h | 1 +
include/hw/9pfs/virtio-9p.h | 1 +
2 files changed, 2 insertions(+)
create mode 100644 include/hw/9pfs/9p-proxy.h
create mode 100644 include/hw/9pfs/virtio-9p.h
diff --git a/include/hw/9pfs/9p-proxy.h b/include/hw/9pfs/9p-proxy.h
new file mode 100644
index 0000000..03d2df7
--- /dev/null
+++ b/include/hw/9pfs/9p-proxy.h
@@ -0,0 +1 @@
+#include_next "../hw/9pfs/9p-proxy.h"
diff --git a/include/hw/9pfs/virtio-9p.h b/include/hw/9pfs/virtio-9p.h
new file mode 100644
index 0000000..b6a1a5f
--- /dev/null
+++ b/include/hw/9pfs/virtio-9p.h
@@ -0,0 +1 @@
+#include_next "../hw/9pfs/virtio-9p.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 31/67] target/cris: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (28 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 28/67] 9pfs: " Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 30/67] audio: " Michael S. Tsirkin
` (41 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/target/cris/opcode-cris.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/target/cris/opcode-cris.h
diff --git a/include/target/cris/opcode-cris.h b/include/target/cris/opcode-cris.h
new file mode 100644
index 0000000..f44fb05
--- /dev/null
+++ b/include/target/cris/opcode-cris.h
@@ -0,0 +1 @@
+#include_next "../target/cris/opcode-cris.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 30/67] audio: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (29 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 31/67] target/cris: add include directory header Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 32/67] ui: " Michael S. Tsirkin
` (40 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/audio/audio.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/audio/audio.h
diff --git a/include/audio/audio.h b/include/audio/audio.h
new file mode 100644
index 0000000..3717f8b
--- /dev/null
+++ b/include/audio/audio.h
@@ -0,0 +1 @@
+#include_next "../audio/audio.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 32/67] ui: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (30 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 30/67] audio: " Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 33/67] hw/net: " Michael S. Tsirkin
` (39 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Gerd Hoffmann
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/ui/vnc.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/ui/vnc.h
diff --git a/include/ui/vnc.h b/include/ui/vnc.h
new file mode 100644
index 0000000..41803da
--- /dev/null
+++ b/include/ui/vnc.h
@@ -0,0 +1 @@
+#include_next "../ui/vnc.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 33/67] hw/net: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (31 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 32/67] ui: " Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 34/67] hw/ppc: add include directory headers Michael S. Tsirkin
` (38 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Jason Wang
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/net/pcnet.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/hw/net/pcnet.h
diff --git a/include/hw/net/pcnet.h b/include/hw/net/pcnet.h
new file mode 100644
index 0000000..cfb7f42
--- /dev/null
+++ b/include/hw/net/pcnet.h
@@ -0,0 +1 @@
+#include_next "../hw/net/pcnet.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 34/67] hw/ppc: add include directory headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (32 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 33/67] hw/net: " Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-04 0:15 ` David Gibson
2018-05-03 19:51 ` [Qemu-devel] [PATCH 35/67] hw/usb: add include directory header Michael S. Tsirkin
` (37 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, David Gibson,
Alexander Graf, qemu-ppc
This way they are easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/ppc/e500-ccsr.h | 1 +
include/hw/ppc/mac.h | 1 +
2 files changed, 2 insertions(+)
create mode 100644 include/hw/ppc/e500-ccsr.h
create mode 100644 include/hw/ppc/mac.h
diff --git a/include/hw/ppc/e500-ccsr.h b/include/hw/ppc/e500-ccsr.h
new file mode 100644
index 0000000..08e4ba2
--- /dev/null
+++ b/include/hw/ppc/e500-ccsr.h
@@ -0,0 +1 @@
+#include_next "../hw/ppc/e500-ccsr.h"
diff --git a/include/hw/ppc/mac.h b/include/hw/ppc/mac.h
new file mode 100644
index 0000000..e0f0b67
--- /dev/null
+++ b/include/hw/ppc/mac.h
@@ -0,0 +1 @@
+#include_next "../hw/ppc/mac.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 34/67] hw/ppc: add include directory headers
2018-05-03 19:51 ` [Qemu-devel] [PATCH 34/67] hw/ppc: add include directory headers Michael S. Tsirkin
@ 2018-05-04 0:15 ` David Gibson
2018-05-04 2:39 ` Michael S. Tsirkin
0 siblings, 1 reply; 144+ messages in thread
From: David Gibson @ 2018-05-04 0:15 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell,
Alexander Graf, qemu-ppc
[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]
On Thu, May 03, 2018 at 10:51:12PM +0300, Michael S. Tsirkin wrote:
> This way they are easier to find using standard rules.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
I don't really understand what this is accomplishing.
> ---
> include/hw/ppc/e500-ccsr.h | 1 +
> include/hw/ppc/mac.h | 1 +
> 2 files changed, 2 insertions(+)
> create mode 100644 include/hw/ppc/e500-ccsr.h
> create mode 100644 include/hw/ppc/mac.h
>
> diff --git a/include/hw/ppc/e500-ccsr.h b/include/hw/ppc/e500-ccsr.h
> new file mode 100644
> index 0000000..08e4ba2
> --- /dev/null
> +++ b/include/hw/ppc/e500-ccsr.h
> @@ -0,0 +1 @@
> +#include_next "../hw/ppc/e500-ccsr.h"
> diff --git a/include/hw/ppc/mac.h b/include/hw/ppc/mac.h
> new file mode 100644
> index 0000000..e0f0b67
> --- /dev/null
> +++ b/include/hw/ppc/mac.h
> @@ -0,0 +1 @@
> +#include_next "../hw/ppc/mac.h"
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 34/67] hw/ppc: add include directory headers
2018-05-04 0:15 ` David Gibson
@ 2018-05-04 2:39 ` Michael S. Tsirkin
2018-05-04 3:07 ` David Gibson
0 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-04 2:39 UTC (permalink / raw)
To: David Gibson
Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell,
Alexander Graf, qemu-ppc
On Fri, May 04, 2018 at 10:15:56AM +1000, David Gibson wrote:
> On Thu, May 03, 2018 at 10:51:12PM +0300, Michael S. Tsirkin wrote:
> > This way they are easier to find using standard rules.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> I don't really understand what this is accomplishing.
Pls see the cover letter.
The specific headers are used outside their directory so ideally long
term either they should move to include or split or callers refactored.
It's up to maintainers to decide what to do, I do not want to make this
decision.
> > ---
> > include/hw/ppc/e500-ccsr.h | 1 +
> > include/hw/ppc/mac.h | 1 +
> > 2 files changed, 2 insertions(+)
> > create mode 100644 include/hw/ppc/e500-ccsr.h
> > create mode 100644 include/hw/ppc/mac.h
> >
> > diff --git a/include/hw/ppc/e500-ccsr.h b/include/hw/ppc/e500-ccsr.h
> > new file mode 100644
> > index 0000000..08e4ba2
> > --- /dev/null
> > +++ b/include/hw/ppc/e500-ccsr.h
> > @@ -0,0 +1 @@
> > +#include_next "../hw/ppc/e500-ccsr.h"
> > diff --git a/include/hw/ppc/mac.h b/include/hw/ppc/mac.h
> > new file mode 100644
> > index 0000000..e0f0b67
> > --- /dev/null
> > +++ b/include/hw/ppc/mac.h
> > @@ -0,0 +1 @@
> > +#include_next "../hw/ppc/mac.h"
>
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 34/67] hw/ppc: add include directory headers
2018-05-04 2:39 ` Michael S. Tsirkin
@ 2018-05-04 3:07 ` David Gibson
0 siblings, 0 replies; 144+ messages in thread
From: David Gibson @ 2018-05-04 3:07 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell,
Alexander Graf, qemu-ppc
[-- Attachment #1: Type: text/plain, Size: 1817 bytes --]
On Fri, May 04, 2018 at 05:39:57AM +0300, Michael S. Tsirkin wrote:
> On Fri, May 04, 2018 at 10:15:56AM +1000, David Gibson wrote:
> > On Thu, May 03, 2018 at 10:51:12PM +0300, Michael S. Tsirkin wrote:
> > > This way they are easier to find using standard rules.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > I don't really understand what this is accomplishing.
>
> Pls see the cover letter.
The cover letter that I wasn't CCed on, and won't appear in the git
history? Ok.. I read that and I still don't really see how this
specific patch fits into the overall picture.
> The specific headers are used outside their directory so ideally long
> term either they should move to include or split or callers refactored.
>
> It's up to maintainers to decide what to do, I do not want to make this
> decision.
>
> > > ---
> > > include/hw/ppc/e500-ccsr.h | 1 +
> > > include/hw/ppc/mac.h | 1 +
> > > 2 files changed, 2 insertions(+)
> > > create mode 100644 include/hw/ppc/e500-ccsr.h
> > > create mode 100644 include/hw/ppc/mac.h
> > >
> > > diff --git a/include/hw/ppc/e500-ccsr.h b/include/hw/ppc/e500-ccsr.h
> > > new file mode 100644
> > > index 0000000..08e4ba2
> > > --- /dev/null
> > > +++ b/include/hw/ppc/e500-ccsr.h
> > > @@ -0,0 +1 @@
> > > +#include_next "../hw/ppc/e500-ccsr.h"
> > > diff --git a/include/hw/ppc/mac.h b/include/hw/ppc/mac.h
> > > new file mode 100644
> > > index 0000000..e0f0b67
> > > --- /dev/null
> > > +++ b/include/hw/ppc/mac.h
> > > @@ -0,0 +1 @@
> > > +#include_next "../hw/ppc/mac.h"
> >
>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 35/67] hw/usb: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (33 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 34/67] hw/ppc: add include directory headers Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 36/67] migration: add include directory headers Michael S. Tsirkin
` (36 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Gerd Hoffmann
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/usb/hcd-ehci.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/hw/usb/hcd-ehci.h
diff --git a/include/hw/usb/hcd-ehci.h b/include/hw/usb/hcd-ehci.h
new file mode 100644
index 0000000..ba80914
--- /dev/null
+++ b/include/hw/usb/hcd-ehci.h
@@ -0,0 +1 @@
+#include_next "../hw/usb/hcd-ehci.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 36/67] migration: add include directory headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (34 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 35/67] hw/usb: add include directory header Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-08 12:25 ` Juan Quintela
2018-05-03 19:51 ` [Qemu-devel] [PATCH 37/67] tcg: " Michael S. Tsirkin
` (35 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Juan Quintela,
Dr. David Alan Gilbert
This way they are easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/migration/migration.h | 1 +
include/migration/postcopy-ram.h | 1 +
include/migration/qemu-file.h | 1 +
3 files changed, 3 insertions(+)
create mode 100644 include/migration/migration.h
create mode 100644 include/migration/postcopy-ram.h
create mode 100644 include/migration/qemu-file.h
diff --git a/include/migration/migration.h b/include/migration/migration.h
new file mode 100644
index 0000000..516b7f6
--- /dev/null
+++ b/include/migration/migration.h
@@ -0,0 +1 @@
+#include_next "../migration/migration.h"
diff --git a/include/migration/postcopy-ram.h b/include/migration/postcopy-ram.h
new file mode 100644
index 0000000..2ea8237
--- /dev/null
+++ b/include/migration/postcopy-ram.h
@@ -0,0 +1 @@
+#include_next "../migration/postcopy-ram.h"
diff --git a/include/migration/qemu-file.h b/include/migration/qemu-file.h
new file mode 100644
index 0000000..8ea3af1
--- /dev/null
+++ b/include/migration/qemu-file.h
@@ -0,0 +1 @@
+#include_next "../migration/qemu-file.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers
2018-05-03 19:51 ` [Qemu-devel] [PATCH 36/67] migration: add include directory headers Michael S. Tsirkin
@ 2018-05-08 12:25 ` Juan Quintela
2018-05-08 12:56 ` Philippe Mathieu-Daudé
2018-05-11 17:23 ` Michael S. Tsirkin
0 siblings, 2 replies; 144+ messages in thread
From: Juan Quintela @ 2018-05-08 12:25 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell,
Dr. David Alan Gilbert
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> This way they are easier to find using standard rules.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Nack.
This are _internal_ files, that shouldn't be used anywere elese.
Except .... that we need them to write tests. We only have two scopes
on qemu:
- internal: only for the subsystem we are at in
- pubilc: they can be used everywhere
So, tests came in a strange class here, because they need internal
implementation, but they are not in the proper directory due to the way
we do tests.
I *think* that using complete paths is the only reasonable way of doing
this.
Thanks, Juan.
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers
2018-05-08 12:25 ` Juan Quintela
@ 2018-05-08 12:56 ` Philippe Mathieu-Daudé
2018-05-11 17:23 ` Michael S. Tsirkin
1 sibling, 0 replies; 144+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-05-08 12:56 UTC (permalink / raw)
To: quintela, Michael S. Tsirkin
Cc: kwolf, peter.maydell, qemu-devel, Dr. David Alan Gilbert
On 05/08/2018 09:25 AM, Juan Quintela wrote:
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>> This way they are easier to find using standard rules.
>>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Nack.
>
> This are _internal_ files, that shouldn't be used anywere elese.
>
> Except .... that we need them to write tests. We only have two scopes
> on qemu:
> - internal: only for the subsystem we are at in
> - pubilc: they can be used everywhere
>
> So, tests came in a strange class here, because they need internal
> implementation, but they are not in the proper directory due to the way
> we do tests.
>
> I *think* that using complete paths is the only reasonable way of doing
> this.
I hit the same issue with SD tests.
The current scheme is confuse but works fine:
tests/test-vmstate.c:30:#include "migration/qemu-file-types.h"
tests/test-vmstate.c:32:#include "../migration/qemu-file-channel.h"
Michael, what about keeping those includes internal ("only for the
subsystem we are at in") and adding complete paths in
tests/Makefile.include?
Such:
tests/test-vmstate.o: QEMU_CFLAGS += -I$(SRC_PATH)/migration
^ permalink raw reply [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers
2018-05-08 12:25 ` Juan Quintela
2018-05-08 12:56 ` Philippe Mathieu-Daudé
@ 2018-05-11 17:23 ` Michael S. Tsirkin
2018-05-11 17:26 ` Daniel P. Berrangé
1 sibling, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-11 17:23 UTC (permalink / raw)
To: Juan Quintela
Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell,
Dr. David Alan Gilbert
On Tue, May 08, 2018 at 02:25:07PM +0200, Juan Quintela wrote:
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > This way they are easier to find using standard rules.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Nack.
>
> This are _internal_ files, that shouldn't be used anywere elese.
>
> Except .... that we need them to write tests. We only have two scopes
> on qemu:
> - internal: only for the subsystem we are at in
> - pubilc: they can be used everywhere
>
> So, tests came in a strange class here, because they need internal
> implementation, but they are not in the proper directory due to the way
> we do tests.
> I *think* that using complete paths is the only reasonable way of doing
> this.
>
> Thanks, Juan.
So how about tests include internal headers in a special way then?
#include "../migration/foo.h" works but makes it clear
something unusual is going on.
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers
2018-05-11 17:23 ` Michael S. Tsirkin
@ 2018-05-11 17:26 ` Daniel P. Berrangé
0 siblings, 0 replies; 144+ messages in thread
From: Daniel P. Berrangé @ 2018-05-11 17:26 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Juan Quintela, qemu-devel, eblake, kwolf, peter.maydell,
Dr. David Alan Gilbert
On Fri, May 11, 2018 at 08:23:22PM +0300, Michael S. Tsirkin wrote:
> On Tue, May 08, 2018 at 02:25:07PM +0200, Juan Quintela wrote:
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > > This way they are easier to find using standard rules.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > Nack.
> >
> > This are _internal_ files, that shouldn't be used anywere elese.
> >
> > Except .... that we need them to write tests. We only have two scopes
> > on qemu:
> > - internal: only for the subsystem we are at in
> > - pubilc: they can be used everywhere
> >
> > So, tests came in a strange class here, because they need internal
> > implementation, but they are not in the proper directory due to the way
> > we do tests.
> > I *think* that using complete paths is the only reasonable way of doing
> > this.
> >
> > Thanks, Juan.
>
> So how about tests include internal headers in a special way then?
>
> #include "../migration/foo.h" works but makes it clear
> something unusual is going on.
I might suggest that the idea of having a single directory for all tests
is the real problem here. We have structured our source so that each
logically separate area of code has its own subdirectory, and then we
dump all unit tests in one big directory !
So how about moving unit tests into their respective directories, so
then any internal headers they need are just local includes.
Leave the global tests/ directory for qtests and iotests, etc which
don't need to poke at internal source.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 37/67] tcg: add include directory headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (35 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 36/67] migration: add include directory headers Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 38/67] helper: replace command line flags with preprocessor Michael S. Tsirkin
` (34 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way they are easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/tcg-mo.h | 1 +
include/tcg-op-gvec.h | 1 +
include/tcg-op.h | 1 +
include/tcg-runtime.h | 1 +
include/tcg.h | 1 +
include/tcg/tcg-gvec-desc.h | 1 +
6 files changed, 6 insertions(+)
create mode 100644 include/tcg-mo.h
create mode 100644 include/tcg-op-gvec.h
create mode 100644 include/tcg-op.h
create mode 100644 include/tcg-runtime.h
create mode 100644 include/tcg.h
create mode 100644 include/tcg/tcg-gvec-desc.h
diff --git a/include/tcg-mo.h b/include/tcg-mo.h
new file mode 100644
index 0000000..ba16778
--- /dev/null
+++ b/include/tcg-mo.h
@@ -0,0 +1 @@
+#include_next "../tcg/tcg-mo.h"
diff --git a/include/tcg-op-gvec.h b/include/tcg-op-gvec.h
new file mode 100644
index 0000000..0c00fbc
--- /dev/null
+++ b/include/tcg-op-gvec.h
@@ -0,0 +1 @@
+#include_next "../tcg/tcg-op-gvec.h"
diff --git a/include/tcg-op.h b/include/tcg-op.h
new file mode 100644
index 0000000..3e08978
--- /dev/null
+++ b/include/tcg-op.h
@@ -0,0 +1 @@
+#include_next "../tcg/tcg-op.h"
diff --git a/include/tcg-runtime.h b/include/tcg-runtime.h
new file mode 100644
index 0000000..b6be561
--- /dev/null
+++ b/include/tcg-runtime.h
@@ -0,0 +1 @@
+#include_next "../accel/tcg/tcg-runtime.h"
diff --git a/include/tcg.h b/include/tcg.h
new file mode 100644
index 0000000..052e05d
--- /dev/null
+++ b/include/tcg.h
@@ -0,0 +1 @@
+#include_next "../tcg/tcg.h"
diff --git a/include/tcg/tcg-gvec-desc.h b/include/tcg/tcg-gvec-desc.h
new file mode 100644
index 0000000..71d8e27
--- /dev/null
+++ b/include/tcg/tcg-gvec-desc.h
@@ -0,0 +1 @@
+#include_next "../tcg/tcg-gvec-desc.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 38/67] helper: replace command line flags with preprocessor
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (36 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 37/67] tcg: " Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 20:09 ` Eric Blake
2018-05-03 19:51 ` [Qemu-devel] [PATCH 39/67] target: " Michael S. Tsirkin
` (33 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Paolo Bonzini,
Peter Crosthwaite, Richard Henderson
Each target is currently built with a different set of include
directories, this is what makes it possible to pull in a separate copy
of helper.h depending on the target.
Replace with per-target ifdefs which are easier to understand.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/exec/helper.h | 2 ++
1 file changed, 2 insertions(+)
create mode 100644 include/exec/helper.h
diff --git a/include/exec/helper.h b/include/exec/helper.h
new file mode 100644
index 0000000..55a48a0
--- /dev/null
+++ b/include/exec/helper.h
@@ -0,0 +1,2 @@
+#include "target-dir.h"
+#include TARGET_DIR(helper.h)
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 38/67] helper: replace command line flags with preprocessor
2018-05-03 19:51 ` [Qemu-devel] [PATCH 38/67] helper: replace command line flags with preprocessor Michael S. Tsirkin
@ 2018-05-03 20:09 ` Eric Blake
0 siblings, 0 replies; 144+ messages in thread
From: Eric Blake @ 2018-05-03 20:09 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: berrange, kwolf, peter.maydell, Paolo Bonzini, Peter Crosthwaite,
Richard Henderson
On 05/03/2018 02:51 PM, Michael S. Tsirkin wrote:
> Each target is currently built with a different set of include
> directories, this is what makes it possible to pull in a separate copy
> of helper.h depending on the target.
>
> Replace with per-target ifdefs which are easier to understand.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/exec/helper.h | 2 ++
> 1 file changed, 2 insertions(+)
> create mode 100644 include/exec/helper.h
Out-of-order patch; target-dir.h isn't created yet...
>
> diff --git a/include/exec/helper.h b/include/exec/helper.h
> new file mode 100644
> index 0000000..55a48a0
> --- /dev/null
> +++ b/include/exec/helper.h
> @@ -0,0 +1,2 @@
> +#include "target-dir.h"
> +#include TARGET_DIR(helper.h)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 39/67] target: replace command line flags with preprocessor
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (37 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 38/67] helper: replace command line flags with preprocessor Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 20:11 ` Eric Blake
2018-05-03 19:51 ` [Qemu-devel] [PATCH 40/67] trace: add include directory headers Michael S. Tsirkin
` (32 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
Each target is currently built with a different set of include
directories, this is what makes it possible to pull in a separate copy
of header files depending on the target.
Replace with per-target ifdefs which are easier to understand.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/target-dir.h | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 63 insertions(+)
create mode 100644 include/target-dir.h
diff --git a/include/target-dir.h b/include/target-dir.h
new file mode 100644
index 0000000..3044236
--- /dev/null
+++ b/include/target-dir.h
@@ -0,0 +1,63 @@
+/*
+ * QEMU target-specific directory macros
+ *
+ * Copyright (C) 2018 Red Hat, Inc.
+ * Author: Michael S. Tsirkin <mst@redhat.com>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+#ifndef QEMU_TARGET_DIR_H
+#define QEMU_TARGET_DIR_H
+
+#if defined(TARGET_ALPHA)
+#define TARGET_DIR_PREFIX ../target/alpha
+#elif defined(TARGET_ARM)
+#define TARGET_DIR_PREFIX ../target/arm
+#elif defined(TARGET_CRIS)
+#define TARGET_DIR_PREFIX ../target/cris
+#elif defined(TARGET_HPPA)
+#define TARGET_DIR_PREFIX ../target/hppa
+#elif defined(TARGET_I386)
+#define TARGET_DIR_PREFIX ../target/i386
+#elif defined(TARGET_LM32)
+#define TARGET_DIR_PREFIX ../target/lm32
+#elif defined(TARGET_M68K)
+#define TARGET_DIR_PREFIX ../target/m68k
+#elif defined(TARGET_MICROBLAZE)
+#define TARGET_DIR_PREFIX ../target/microblaze
+#elif defined(TARGET_MIPS)
+#define TARGET_DIR_PREFIX ../target/mips
+#elif defined(TARGET_MOXIE)
+#define TARGET_DIR_PREFIX ../target/moxie
+#elif defined(TARGET_NIOS2)
+#define TARGET_DIR_PREFIX ../target/nios2
+#elif defined(TARGET_OPENRISC)
+#define TARGET_DIR_PREFIX ../target/openrisc
+#elif defined(TARGET_PPC)
+#define TARGET_DIR_PREFIX ../target/ppc
+#elif defined(TARGET_RISCV)
+#define TARGET_DIR_PREFIX ../target/riscv
+#elif defined(TARGET_S390X)
+#define TARGET_DIR_PREFIX ../target/s390x
+#elif defined(TARGET_SH4)
+#define TARGET_DIR_PREFIX ../target/sh4
+#elif defined(TARGET_SPARC)
+#define TARGET_DIR_PREFIX ../target/sparc
+#elif defined(TARGET_UNICORE32)
+#define TARGET_DIR_PREFIX ../target/unicore32
+#elif defined(TARGET_TILEGX)
+#define TARGET_DIR_PREFIX ../target/tilegx
+#elif defined(TARGET_TRICORE)
+#define TARGET_DIR_PREFIX ../target/tricore
+#elif defined(TARGET_XTENSA)
+#define TARGET_DIR_PREFIX ../target/xtensa
+#else
+#error "Target-specific directory include missing"
+#endif
+
+#define TARGET_DIR_HASH(file) #file
+#define TARGET_DIR_STRING(file) TARGET_DIR_HASH(file)
+#define TARGET_DIR(file) TARGET_DIR_STRING(TARGET_DIR_PREFIX/file)
+
+#endif
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 39/67] target: replace command line flags with preprocessor
2018-05-03 19:51 ` [Qemu-devel] [PATCH 39/67] target: " Michael S. Tsirkin
@ 2018-05-03 20:11 ` Eric Blake
2018-05-03 20:15 ` Michael S. Tsirkin
0 siblings, 1 reply; 144+ messages in thread
From: Eric Blake @ 2018-05-03 20:11 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: berrange, kwolf, peter.maydell
On 05/03/2018 02:51 PM, Michael S. Tsirkin wrote:
> Each target is currently built with a different set of include
> directories, this is what makes it possible to pull in a separate copy
> of header files depending on the target.
>
> Replace with per-target ifdefs which are easier to understand.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/target-dir.h | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 63 insertions(+)
> create mode 100644 include/target-dir.h
Ah, now we get to the file mentioned in a couple of previous patches.
> +#ifndef QEMU_TARGET_DIR_H
> +#define QEMU_TARGET_DIR_H
> +
> +#if defined(TARGET_ALPHA)
> +#define TARGET_DIR_PREFIX ../target/alpha
> +#elif defined(TARGET_ARM)
> +#define TARGET_DIR_PREFIX ../target/arm
> +#elif defined(TARGET_XTENSA)
> +#define TARGET_DIR_PREFIX ../target/xtensa
> +#else
> +#error "Target-specific directory include missing"
> +#endif
> +
> +#define TARGET_DIR_HASH(file) #file
> +#define TARGET_DIR_STRING(file) TARGET_DIR_HASH(file)
> +#define TARGET_DIR(file) TARGET_DIR_STRING(TARGET_DIR_PREFIX/file)
Cool trick! It seems pretty reasonable to me.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 39/67] target: replace command line flags with preprocessor
2018-05-03 20:11 ` Eric Blake
@ 2018-05-03 20:15 ` Michael S. Tsirkin
0 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 20:15 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, berrange, kwolf, peter.maydell
On Thu, May 03, 2018 at 03:11:26PM -0500, Eric Blake wrote:
> On 05/03/2018 02:51 PM, Michael S. Tsirkin wrote:
> > Each target is currently built with a different set of include
> > directories, this is what makes it possible to pull in a separate copy
> > of header files depending on the target.
> >
> > Replace with per-target ifdefs which are easier to understand.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > include/target-dir.h | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 63 insertions(+)
> > create mode 100644 include/target-dir.h
>
> Ah, now we get to the file mentioned in a couple of previous patches.
Thanks, will reorder.
> > +#ifndef QEMU_TARGET_DIR_H
> > +#define QEMU_TARGET_DIR_H
> > +
> > +#if defined(TARGET_ALPHA)
> > +#define TARGET_DIR_PREFIX ../target/alpha
> > +#elif defined(TARGET_ARM)
> > +#define TARGET_DIR_PREFIX ../target/arm
>
> > +#elif defined(TARGET_XTENSA)
> > +#define TARGET_DIR_PREFIX ../target/xtensa
> > +#else
> > +#error "Target-specific directory include missing"
> > +#endif
> > +
> > +#define TARGET_DIR_HASH(file) #file
> > +#define TARGET_DIR_STRING(file) TARGET_DIR_HASH(file)
> > +#define TARGET_DIR(file) TARGET_DIR_STRING(TARGET_DIR_PREFIX/file)
>
> Cool trick! It seems pretty reasonable to me.
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 40/67] trace: add include directory headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (38 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 39/67] target: " Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 42/67] tcg: use include "tcg.h" consistently Michael S. Tsirkin
` (31 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way they are easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/trace/mem-internal.h | 1 +
include/trace/mem.h | 1 +
2 files changed, 2 insertions(+)
create mode 100644 include/trace/mem-internal.h
create mode 100644 include/trace/mem.h
diff --git a/include/trace/mem-internal.h b/include/trace/mem-internal.h
new file mode 100644
index 0000000..eb84b2f
--- /dev/null
+++ b/include/trace/mem-internal.h
@@ -0,0 +1 @@
+#include_next "../trace/mem-internal.h"
diff --git a/include/trace/mem.h b/include/trace/mem.h
new file mode 100644
index 0000000..a907937
--- /dev/null
+++ b/include/trace/mem.h
@@ -0,0 +1 @@
+#include_next "../trace/mem.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 42/67] tcg: use include "tcg.h" consistently
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (39 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 40/67] trace: add include directory headers Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-04 5:40 ` Marcel Apfelbaum
2018-05-03 19:51 ` [Qemu-devel] [PATCH 41/67] tcg-pool.inc.c: replace command line flags with preprocessor Michael S. Tsirkin
` (30 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Paolo Bonzini,
Peter Crosthwaite, Richard Henderson, Stefan Weil,
Eduardo Habkost, Marcel Apfelbaum, Stefan Hajnoczi
Some places include tcg.h, others tcg/tcg.h.
Let's be consistent.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/exec/translator.h | 2 +-
trace/mem.h | 2 +-
accel/stubs/tcg-stub.c | 2 +-
accel/tcg/cputlb.c | 2 +-
accel/tcg/translator.c | 2 +-
disas/tci.c | 2 +-
hw/i386/kvmvapic.c | 2 +-
tcg/tcg-common.c | 2 +-
tcg/tci.c | 2 +-
9 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/include/exec/translator.h b/include/exec/translator.h
index e2dc2a0..a915953 100644
--- a/include/exec/translator.h
+++ b/include/exec/translator.h
@@ -20,7 +20,7 @@
#include "exec/exec-all.h"
-#include "tcg/tcg.h"
+#include "tcg.h"
/**
diff --git a/trace/mem.h b/trace/mem.h
index 9c88bcb..39a1e21 100644
--- a/trace/mem.h
+++ b/trace/mem.h
@@ -10,7 +10,7 @@
#ifndef TRACE__MEM_H
#define TRACE__MEM_H
-#include "tcg/tcg.h"
+#include "tcg.h"
/**
diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
index ee575a8..ab2a372b 100644
--- a/accel/stubs/tcg-stub.c
+++ b/accel/stubs/tcg-stub.c
@@ -13,7 +13,7 @@
#include "qemu/osdep.h"
#include "qemu-common.h"
#include "cpu.h"
-#include "tcg/tcg.h"
+#include "tcg.h"
#include "exec/cpu-common.h"
#include "exec/exec-all.h"
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index 0543903..d295d14 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -27,7 +27,7 @@
#include "exec/cputlb.h"
#include "exec/memory-internal.h"
#include "exec/ram_addr.h"
-#include "tcg/tcg.h"
+#include "tcg.h"
#include "qemu/error-report.h"
#include "exec/log.h"
#include "exec/helper-proto.h"
diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c
index 23c6602..01480b9 100644
--- a/accel/tcg/translator.c
+++ b/accel/tcg/translator.c
@@ -11,7 +11,7 @@
#include "qemu-common.h"
#include "qemu/error-report.h"
#include "cpu.h"
-#include "tcg/tcg.h"
+#include "tcg.h"
#include "tcg/tcg-op.h"
#include "exec/exec-all.h"
#include "exec/gen-icount.h"
diff --git a/disas/tci.c b/disas/tci.c
index 1cdf5ee..7408a56 100644
--- a/disas/tci.c
+++ b/disas/tci.c
@@ -20,7 +20,7 @@
#include "qemu/osdep.h"
#include "qemu-common.h"
#include "disas/bfd.h"
-#include "tcg/tcg.h"
+#include "tcg.h"
/* Disassemble TCI bytecode. */
int print_insn_tci(bfd_vma addr, disassemble_info *info)
diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c
index fc962c5..23aef34 100644
--- a/hw/i386/kvmvapic.c
+++ b/hw/i386/kvmvapic.c
@@ -18,7 +18,7 @@
#include "sysemu/kvm.h"
#include "hw/i386/apic_internal.h"
#include "hw/sysbus.h"
-#include "tcg/tcg.h"
+#include "tcg.h"
#define VAPIC_IO_PORT 0x7e
diff --git a/tcg/tcg-common.c b/tcg/tcg-common.c
index 2f139de..d80cbec 100644
--- a/tcg/tcg-common.c
+++ b/tcg/tcg-common.c
@@ -25,7 +25,7 @@
#include "qemu/osdep.h"
#include "qemu-common.h"
#include "exec/cpu-common.h"
-#include "tcg/tcg.h"
+#include "tcg.h"
#if defined(CONFIG_TCG_INTERPRETER)
uintptr_t tci_tb_ptr;
diff --git a/tcg/tci.c b/tcg/tci.c
index 33edca1..2d11dc6 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -28,7 +28,7 @@
#endif
#include "qemu-common.h"
-#include "tcg/tcg.h" /* MAX_OPC_PARAM_IARGS */
+#include "tcg.h" /* MAX_OPC_PARAM_IARGS */
#include "exec/cpu_ldst.h"
#include "tcg-op.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 42/67] tcg: use include "tcg.h" consistently
2018-05-03 19:51 ` [Qemu-devel] [PATCH 42/67] tcg: use include "tcg.h" consistently Michael S. Tsirkin
@ 2018-05-04 5:40 ` Marcel Apfelbaum
0 siblings, 0 replies; 144+ messages in thread
From: Marcel Apfelbaum @ 2018-05-04 5:40 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: kwolf, peter.maydell, Eduardo Habkost, Peter Crosthwaite,
Stefan Weil, Stefan Hajnoczi, Marcel Apfelbaum, Paolo Bonzini,
Richard Henderson
On 05/03/2018 10:51 PM, Michael S. Tsirkin wrote:
> Some places include tcg.h, others tcg/tcg.h.
> Let's be consistent.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/exec/translator.h | 2 +-
> trace/mem.h | 2 +-
> accel/stubs/tcg-stub.c | 2 +-
> accel/tcg/cputlb.c | 2 +-
> accel/tcg/translator.c | 2 +-
> disas/tci.c | 2 +-
> hw/i386/kvmvapic.c | 2 +-
> tcg/tcg-common.c | 2 +-
> tcg/tci.c | 2 +-
> 9 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/include/exec/translator.h b/include/exec/translator.h
> index e2dc2a0..a915953 100644
> --- a/include/exec/translator.h
> +++ b/include/exec/translator.h
> @@ -20,7 +20,7 @@
>
>
> #include "exec/exec-all.h"
> -#include "tcg/tcg.h"
> +#include "tcg.h"
>
>
> /**
> diff --git a/trace/mem.h b/trace/mem.h
> index 9c88bcb..39a1e21 100644
> --- a/trace/mem.h
> +++ b/trace/mem.h
> @@ -10,7 +10,7 @@
> #ifndef TRACE__MEM_H
> #define TRACE__MEM_H
>
> -#include "tcg/tcg.h"
> +#include "tcg.h"
>
>
> /**
> diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c
> index ee575a8..ab2a372b 100644
> --- a/accel/stubs/tcg-stub.c
> +++ b/accel/stubs/tcg-stub.c
> @@ -13,7 +13,7 @@
> #include "qemu/osdep.h"
> #include "qemu-common.h"
> #include "cpu.h"
> -#include "tcg/tcg.h"
> +#include "tcg.h"
> #include "exec/cpu-common.h"
> #include "exec/exec-all.h"
>
> diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
> index 0543903..d295d14 100644
> --- a/accel/tcg/cputlb.c
> +++ b/accel/tcg/cputlb.c
> @@ -27,7 +27,7 @@
> #include "exec/cputlb.h"
> #include "exec/memory-internal.h"
> #include "exec/ram_addr.h"
> -#include "tcg/tcg.h"
> +#include "tcg.h"
> #include "qemu/error-report.h"
> #include "exec/log.h"
> #include "exec/helper-proto.h"
> diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c
> index 23c6602..01480b9 100644
> --- a/accel/tcg/translator.c
> +++ b/accel/tcg/translator.c
> @@ -11,7 +11,7 @@
> #include "qemu-common.h"
> #include "qemu/error-report.h"
> #include "cpu.h"
> -#include "tcg/tcg.h"
> +#include "tcg.h"
> #include "tcg/tcg-op.h"
> #include "exec/exec-all.h"
> #include "exec/gen-icount.h"
> diff --git a/disas/tci.c b/disas/tci.c
> index 1cdf5ee..7408a56 100644
> --- a/disas/tci.c
> +++ b/disas/tci.c
> @@ -20,7 +20,7 @@
> #include "qemu/osdep.h"
> #include "qemu-common.h"
> #include "disas/bfd.h"
> -#include "tcg/tcg.h"
> +#include "tcg.h"
>
> /* Disassemble TCI bytecode. */
> int print_insn_tci(bfd_vma addr, disassemble_info *info)
> diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c
> index fc962c5..23aef34 100644
> --- a/hw/i386/kvmvapic.c
> +++ b/hw/i386/kvmvapic.c
> @@ -18,7 +18,7 @@
> #include "sysemu/kvm.h"
> #include "hw/i386/apic_internal.h"
> #include "hw/sysbus.h"
> -#include "tcg/tcg.h"
> +#include "tcg.h"
>
> #define VAPIC_IO_PORT 0x7e
>
> diff --git a/tcg/tcg-common.c b/tcg/tcg-common.c
> index 2f139de..d80cbec 100644
> --- a/tcg/tcg-common.c
> +++ b/tcg/tcg-common.c
> @@ -25,7 +25,7 @@
> #include "qemu/osdep.h"
> #include "qemu-common.h"
> #include "exec/cpu-common.h"
> -#include "tcg/tcg.h"
> +#include "tcg.h"
>
> #if defined(CONFIG_TCG_INTERPRETER)
> uintptr_t tci_tb_ptr;
> diff --git a/tcg/tci.c b/tcg/tci.c
> index 33edca1..2d11dc6 100644
> --- a/tcg/tci.c
> +++ b/tcg/tci.c
> @@ -28,7 +28,7 @@
> #endif
>
> #include "qemu-common.h"
> -#include "tcg/tcg.h" /* MAX_OPC_PARAM_IARGS */
> +#include "tcg.h" /* MAX_OPC_PARAM_IARGS */
> #include "exec/cpu_ldst.h"
> #include "tcg-op.h"
>
Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>
Thanks,
Marcel
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 41/67] tcg-pool.inc.c: replace command line flags with preprocessor
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (40 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 42/67] tcg: use include "tcg.h" consistently Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 20:12 ` Eric Blake
2018-05-03 19:51 ` [Qemu-devel] [PATCH 43/67] translate-all: add include directory header Michael S. Tsirkin
` (29 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
Each target is currently built with a different set of include
directories, this is what makes it possible to pull in a separate copy
of cpu.h depending on the target.
Replace with per-target ifdefs which are easier to understand.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/tcg-pool.inc.c | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/tcg-pool.inc.c
diff --git a/include/tcg-pool.inc.c b/include/tcg-pool.inc.c
new file mode 100644
index 0000000..d04a981
--- /dev/null
+++ b/include/tcg-pool.inc.c
@@ -0,0 +1 @@
+#include_next "../tcg/tcg-pool.inc.c"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 41/67] tcg-pool.inc.c: replace command line flags with preprocessor
2018-05-03 19:51 ` [Qemu-devel] [PATCH 41/67] tcg-pool.inc.c: replace command line flags with preprocessor Michael S. Tsirkin
@ 2018-05-03 20:12 ` Eric Blake
2018-05-03 20:16 ` Michael S. Tsirkin
0 siblings, 1 reply; 144+ messages in thread
From: Eric Blake @ 2018-05-03 20:12 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: berrange, kwolf, peter.maydell
On 05/03/2018 02:51 PM, Michael S. Tsirkin wrote:
> Each target is currently built with a different set of include
> directories, this is what makes it possible to pull in a separate copy
> of cpu.h depending on the target.
>
> Replace with per-target ifdefs which are easier to understand.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/tcg-pool.inc.c | 1 +
> 1 file changed, 1 insertion(+)
> create mode 100644 include/tcg-pool.inc.c
>
> diff --git a/include/tcg-pool.inc.c b/include/tcg-pool.inc.c
> new file mode 100644
> index 0000000..d04a981
> --- /dev/null
> +++ b/include/tcg-pool.inc.c
> @@ -0,0 +1 @@
> +#include_next "../tcg/tcg-pool.inc.c"
Bad copy-and-paste in the commit message?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 41/67] tcg-pool.inc.c: replace command line flags with preprocessor
2018-05-03 20:12 ` Eric Blake
@ 2018-05-03 20:16 ` Michael S. Tsirkin
0 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 20:16 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, berrange, kwolf, peter.maydell
On Thu, May 03, 2018 at 03:12:16PM -0500, Eric Blake wrote:
> On 05/03/2018 02:51 PM, Michael S. Tsirkin wrote:
> > Each target is currently built with a different set of include
> > directories, this is what makes it possible to pull in a separate copy
> > of cpu.h depending on the target.
> >
> > Replace with per-target ifdefs which are easier to understand.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > include/tcg-pool.inc.c | 1 +
> > 1 file changed, 1 insertion(+)
> > create mode 100644 include/tcg-pool.inc.c
> >
> > diff --git a/include/tcg-pool.inc.c b/include/tcg-pool.inc.c
> > new file mode 100644
> > index 0000000..d04a981
> > --- /dev/null
> > +++ b/include/tcg-pool.inc.c
> > @@ -0,0 +1 @@
> > +#include_next "../tcg/tcg-pool.inc.c"
>
> Bad copy-and-paste in the commit message?
Yes :(
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 43/67] translate-all: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (41 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 41/67] tcg-pool.inc.c: replace command line flags with preprocessor Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 44/67] tcg-ldst.inc.c: replace command line flags with preprocessor Michael S. Tsirkin
` (28 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/translate-all.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/translate-all.h
diff --git a/include/translate-all.h b/include/translate-all.h
new file mode 100644
index 0000000..90b8b4a
--- /dev/null
+++ b/include/translate-all.h
@@ -0,0 +1 @@
+#include_next "../accel/tcg/translate-all.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 44/67] tcg-ldst.inc.c: replace command line flags with preprocessor
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (42 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 43/67] translate-all: add include directory header Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 45/67] tcg: add include directory headers Michael S. Tsirkin
` (27 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
Each target is currently built with a different set of include
directories, this is what makes it possible to pull in a separate copy
of tcg-ldst.inc.c depending on the target.
Replace with per-target ifdefs which are easier to understand.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/tcg-ldst.inc.c | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/tcg-ldst.inc.c
diff --git a/include/tcg-ldst.inc.c b/include/tcg-ldst.inc.c
new file mode 100644
index 0000000..fa0f3bf
--- /dev/null
+++ b/include/tcg-ldst.inc.c
@@ -0,0 +1 @@
+#include_next "../tcg/tcg-ldst.inc.c"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 45/67] tcg: add include directory headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (43 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 44/67] tcg-ldst.inc.c: replace command line flags with preprocessor Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 46/67] cpu-qom: " Michael S. Tsirkin
` (26 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way they are easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/tcg-gvec-desc.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/tcg-gvec-desc.h
diff --git a/include/tcg-gvec-desc.h b/include/tcg-gvec-desc.h
new file mode 100644
index 0000000..71d8e27
--- /dev/null
+++ b/include/tcg-gvec-desc.h
@@ -0,0 +1 @@
+#include_next "../tcg/tcg-gvec-desc.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 46/67] cpu-qom: add include directory headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (44 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 45/67] tcg: add include directory headers Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 48/67] virtio-pci: add include directory header Michael S. Tsirkin
` (25 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way they are easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/target/alpha/cpu-qom.h | 1 +
include/target/arm/cpu-qom.h | 1 +
include/target/cris/cpu-qom.h | 1 +
include/target/hppa/cpu-qom.h | 1 +
include/target/i386/cpu-qom.h | 1 +
include/target/lm32/cpu-qom.h | 1 +
include/target/m68k/cpu-qom.h | 1 +
include/target/microblaze/cpu-qom.h | 1 +
include/target/mips/cpu-qom.h | 1 +
include/target/ppc/cpu-qom.h | 1 +
include/target/s390x/cpu-qom.h | 1 +
include/target/sh4/cpu-qom.h | 1 +
include/target/sparc/cpu-qom.h | 1 +
include/target/tricore/cpu-qom.h | 1 +
include/target/unicore32/cpu-qom.h | 1 +
include/target/xtensa/cpu-qom.h | 1 +
16 files changed, 16 insertions(+)
create mode 100644 include/target/alpha/cpu-qom.h
create mode 100644 include/target/arm/cpu-qom.h
create mode 100644 include/target/cris/cpu-qom.h
create mode 100644 include/target/hppa/cpu-qom.h
create mode 100644 include/target/i386/cpu-qom.h
create mode 100644 include/target/lm32/cpu-qom.h
create mode 100644 include/target/m68k/cpu-qom.h
create mode 100644 include/target/microblaze/cpu-qom.h
create mode 100644 include/target/mips/cpu-qom.h
create mode 100644 include/target/ppc/cpu-qom.h
create mode 100644 include/target/s390x/cpu-qom.h
create mode 100644 include/target/sh4/cpu-qom.h
create mode 100644 include/target/sparc/cpu-qom.h
create mode 100644 include/target/tricore/cpu-qom.h
create mode 100644 include/target/unicore32/cpu-qom.h
create mode 100644 include/target/xtensa/cpu-qom.h
diff --git a/include/target/alpha/cpu-qom.h b/include/target/alpha/cpu-qom.h
new file mode 100644
index 0000000..2bacb91
--- /dev/null
+++ b/include/target/alpha/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/alpha/cpu-qom.h"
diff --git a/include/target/arm/cpu-qom.h b/include/target/arm/cpu-qom.h
new file mode 100644
index 0000000..33ddbcf
--- /dev/null
+++ b/include/target/arm/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/arm/cpu-qom.h"
diff --git a/include/target/cris/cpu-qom.h b/include/target/cris/cpu-qom.h
new file mode 100644
index 0000000..01aaf0c
--- /dev/null
+++ b/include/target/cris/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/cris/cpu-qom.h"
diff --git a/include/target/hppa/cpu-qom.h b/include/target/hppa/cpu-qom.h
new file mode 100644
index 0000000..16af5ae
--- /dev/null
+++ b/include/target/hppa/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/hppa/cpu-qom.h"
diff --git a/include/target/i386/cpu-qom.h b/include/target/i386/cpu-qom.h
new file mode 100644
index 0000000..d319042
--- /dev/null
+++ b/include/target/i386/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/i386/cpu-qom.h"
diff --git a/include/target/lm32/cpu-qom.h b/include/target/lm32/cpu-qom.h
new file mode 100644
index 0000000..d167dd0
--- /dev/null
+++ b/include/target/lm32/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/lm32/cpu-qom.h"
diff --git a/include/target/m68k/cpu-qom.h b/include/target/m68k/cpu-qom.h
new file mode 100644
index 0000000..c1eaf99
--- /dev/null
+++ b/include/target/m68k/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/m68k/cpu-qom.h"
diff --git a/include/target/microblaze/cpu-qom.h b/include/target/microblaze/cpu-qom.h
new file mode 100644
index 0000000..db57306
--- /dev/null
+++ b/include/target/microblaze/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/microblaze/cpu-qom.h"
diff --git a/include/target/mips/cpu-qom.h b/include/target/mips/cpu-qom.h
new file mode 100644
index 0000000..a226860
--- /dev/null
+++ b/include/target/mips/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/mips/cpu-qom.h"
diff --git a/include/target/ppc/cpu-qom.h b/include/target/ppc/cpu-qom.h
new file mode 100644
index 0000000..2e74cde
--- /dev/null
+++ b/include/target/ppc/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/ppc/cpu-qom.h"
diff --git a/include/target/s390x/cpu-qom.h b/include/target/s390x/cpu-qom.h
new file mode 100644
index 0000000..8c90a83
--- /dev/null
+++ b/include/target/s390x/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/s390x/cpu-qom.h"
diff --git a/include/target/sh4/cpu-qom.h b/include/target/sh4/cpu-qom.h
new file mode 100644
index 0000000..94a8268
--- /dev/null
+++ b/include/target/sh4/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/sh4/cpu-qom.h"
diff --git a/include/target/sparc/cpu-qom.h b/include/target/sparc/cpu-qom.h
new file mode 100644
index 0000000..2e8af3b
--- /dev/null
+++ b/include/target/sparc/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/sparc/cpu-qom.h"
diff --git a/include/target/tricore/cpu-qom.h b/include/target/tricore/cpu-qom.h
new file mode 100644
index 0000000..2c18b33
--- /dev/null
+++ b/include/target/tricore/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/tricore/cpu-qom.h"
diff --git a/include/target/unicore32/cpu-qom.h b/include/target/unicore32/cpu-qom.h
new file mode 100644
index 0000000..1505771
--- /dev/null
+++ b/include/target/unicore32/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/unicore32/cpu-qom.h"
diff --git a/include/target/xtensa/cpu-qom.h b/include/target/xtensa/cpu-qom.h
new file mode 100644
index 0000000..6a9f790
--- /dev/null
+++ b/include/target/xtensa/cpu-qom.h
@@ -0,0 +1 @@
+#include_next "../target/xtensa/cpu-qom.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 48/67] virtio-pci: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (45 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 46/67] cpu-qom: " Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 47/67] tcg-op: use include "tcg.h" consistently Michael S. Tsirkin
` (24 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/virtio/virtio-pci.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/hw/virtio/virtio-pci.h
diff --git a/include/hw/virtio/virtio-pci.h b/include/hw/virtio/virtio-pci.h
new file mode 100644
index 0000000..f0376c1
--- /dev/null
+++ b/include/hw/virtio/virtio-pci.h
@@ -0,0 +1 @@
+#include_next "../hw/virtio/virtio-pci.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 47/67] tcg-op: use include "tcg.h" consistently
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (46 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 48/67] virtio-pci: add include directory header Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 50/67] hmp: add include directory header Michael S. Tsirkin
` (23 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Paolo Bonzini,
Peter Crosthwaite, Richard Henderson
Some places include tcg-op.h, others tcg/tcg-op.h.
Let's be consistent.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
accel/tcg/translator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c
index 01480b9..429b0c8 100644
--- a/accel/tcg/translator.c
+++ b/accel/tcg/translator.c
@@ -12,7 +12,7 @@
#include "qemu/error-report.h"
#include "cpu.h"
#include "tcg.h"
-#include "tcg/tcg-op.h"
+#include "tcg-op.h"
#include "exec/exec-all.h"
#include "exec/gen-icount.h"
#include "exec/log.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 50/67] hmp: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (47 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 47/67] tcg-op: use include "tcg.h" consistently Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 49/67] kvm_XXX: add include directory headers Michael S. Tsirkin
` (22 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hmp.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/hmp.h
diff --git a/include/hmp.h b/include/hmp.h
new file mode 100644
index 0000000..db13478
--- /dev/null
+++ b/include/hmp.h
@@ -0,0 +1 @@
+#include_next "../hmp.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 49/67] kvm_XXX: add include directory headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (48 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 50/67] hmp: add include directory header Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 51/67] hyperv: add include directory header Michael S. Tsirkin
` (21 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way they are easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/kvm_arm.h | 1 +
include/kvm_i386.h | 1 +
include/kvm_mips.h | 1 +
include/kvm_ppc.h | 1 +
include/kvm_s390x.h | 1 +
5 files changed, 5 insertions(+)
create mode 100644 include/kvm_arm.h
create mode 100644 include/kvm_i386.h
create mode 100644 include/kvm_mips.h
create mode 100644 include/kvm_ppc.h
create mode 100644 include/kvm_s390x.h
diff --git a/include/kvm_arm.h b/include/kvm_arm.h
new file mode 100644
index 0000000..3a57d37
--- /dev/null
+++ b/include/kvm_arm.h
@@ -0,0 +1 @@
+#include_next "../target/arm/kvm_arm.h"
diff --git a/include/kvm_i386.h b/include/kvm_i386.h
new file mode 100644
index 0000000..e43c259
--- /dev/null
+++ b/include/kvm_i386.h
@@ -0,0 +1 @@
+#include_next "../target/i386/kvm_i386.h"
diff --git a/include/kvm_mips.h b/include/kvm_mips.h
new file mode 100644
index 0000000..d5acbfe
--- /dev/null
+++ b/include/kvm_mips.h
@@ -0,0 +1 @@
+#include_next "../target/mips/kvm_mips.h"
diff --git a/include/kvm_ppc.h b/include/kvm_ppc.h
new file mode 100644
index 0000000..d5baf60
--- /dev/null
+++ b/include/kvm_ppc.h
@@ -0,0 +1 @@
+#include_next "../target/ppc/kvm_ppc.h"
diff --git a/include/kvm_s390x.h b/include/kvm_s390x.h
new file mode 100644
index 0000000..e2d7230
--- /dev/null
+++ b/include/kvm_s390x.h
@@ -0,0 +1 @@
+#include_next "../target/s390x/kvm_s390x.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 51/67] hyperv: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (49 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 49/67] kvm_XXX: add include directory headers Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 52/67] target/arm: add include directory headers Michael S. Tsirkin
` (20 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/target/i386/hyperv.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/target/i386/hyperv.h
diff --git a/include/target/i386/hyperv.h b/include/target/i386/hyperv.h
new file mode 100644
index 0000000..79a989a
--- /dev/null
+++ b/include/target/i386/hyperv.h
@@ -0,0 +1 @@
+#include_next "../target/i386/hyperv.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 52/67] target/arm: add include directory headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (50 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 51/67] hyperv: add include directory header Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 53/67] target/ppc: " Michael S. Tsirkin
` (19 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way they are easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/arm-powerctl.h | 1 +
include/target/arm/cpu.h | 1 +
include/target/arm/idau.h | 1 +
3 files changed, 3 insertions(+)
create mode 100644 include/arm-powerctl.h
create mode 100644 include/target/arm/cpu.h
create mode 100644 include/target/arm/idau.h
diff --git a/include/arm-powerctl.h b/include/arm-powerctl.h
new file mode 100644
index 0000000..77af740
--- /dev/null
+++ b/include/arm-powerctl.h
@@ -0,0 +1 @@
+#include_next "../target/arm/arm-powerctl.h"
diff --git a/include/target/arm/cpu.h b/include/target/arm/cpu.h
new file mode 100644
index 0000000..97b4615
--- /dev/null
+++ b/include/target/arm/cpu.h
@@ -0,0 +1 @@
+#include_next "../target/arm/cpu.h"
diff --git a/include/target/arm/idau.h b/include/target/arm/idau.h
new file mode 100644
index 0000000..06bce14
--- /dev/null
+++ b/include/target/arm/idau.h
@@ -0,0 +1 @@
+#include_next "../target/arm/idau.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 53/67] target/ppc: add include directory headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (51 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 52/67] target/arm: add include directory headers Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 54/67] amd_iommu: add include directory header Michael S. Tsirkin
` (18 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way they are easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/target/ppc/cpu-models.h | 1 +
include/target/ppc/cpu.h | 1 +
include/target/ppc/helper_regs.h | 1 +
include/target/ppc/mmu-book3s-v3.h | 1 +
include/target/ppc/mmu-hash64.h | 1 +
5 files changed, 5 insertions(+)
create mode 100644 include/target/ppc/cpu-models.h
create mode 100644 include/target/ppc/cpu.h
create mode 100644 include/target/ppc/helper_regs.h
create mode 100644 include/target/ppc/mmu-book3s-v3.h
create mode 100644 include/target/ppc/mmu-hash64.h
diff --git a/include/target/ppc/cpu-models.h b/include/target/ppc/cpu-models.h
new file mode 100644
index 0000000..2cb5fb9
--- /dev/null
+++ b/include/target/ppc/cpu-models.h
@@ -0,0 +1 @@
+#include_next "../target/ppc/cpu-models.h"
diff --git a/include/target/ppc/cpu.h b/include/target/ppc/cpu.h
new file mode 100644
index 0000000..36348ed
--- /dev/null
+++ b/include/target/ppc/cpu.h
@@ -0,0 +1 @@
+#include_next "../target/ppc/cpu.h"
diff --git a/include/target/ppc/helper_regs.h b/include/target/ppc/helper_regs.h
new file mode 100644
index 0000000..0e125b4
--- /dev/null
+++ b/include/target/ppc/helper_regs.h
@@ -0,0 +1 @@
+#include_next "../target/ppc/helper_regs.h"
diff --git a/include/target/ppc/mmu-book3s-v3.h b/include/target/ppc/mmu-book3s-v3.h
new file mode 100644
index 0000000..3d6e989
--- /dev/null
+++ b/include/target/ppc/mmu-book3s-v3.h
@@ -0,0 +1 @@
+#include_next "../target/ppc/mmu-book3s-v3.h"
diff --git a/include/target/ppc/mmu-hash64.h b/include/target/ppc/mmu-hash64.h
new file mode 100644
index 0000000..7eaddfe
--- /dev/null
+++ b/include/target/ppc/mmu-hash64.h
@@ -0,0 +1 @@
+#include_next "../target/ppc/mmu-hash64.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 54/67] amd_iommu: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (52 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 53/67] target/ppc: " Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 56/67] tcg: use include "tcg-gvec-desc.h.h" consistently Michael S. Tsirkin
` (17 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Marcel Apfelbaum
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/i386/amd_iommu.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/hw/i386/amd_iommu.h
diff --git a/include/hw/i386/amd_iommu.h b/include/hw/i386/amd_iommu.h
new file mode 100644
index 0000000..5576788
--- /dev/null
+++ b/include/hw/i386/amd_iommu.h
@@ -0,0 +1 @@
+#include_next "../hw/i386/amd_iommu.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 56/67] tcg: use include "tcg-gvec-desc.h.h" consistently
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (53 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 54/67] amd_iommu: add include directory header Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 55/67] amd_iommu: add include directory header Michael S. Tsirkin
` (16 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Paolo Bonzini,
Peter Crosthwaite, Richard Henderson
Some places include tcg-gvec-desc.h, others tcg/tcg-gvec-desc.h.
Let's be consistent.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
accel/tcg/tcg-runtime-gvec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/accel/tcg/tcg-runtime-gvec.c b/accel/tcg/tcg-runtime-gvec.c
index 90340e5..dad5821 100644
--- a/accel/tcg/tcg-runtime-gvec.c
+++ b/accel/tcg/tcg-runtime-gvec.c
@@ -21,7 +21,7 @@
#include "qemu/host-utils.h"
#include "cpu.h"
#include "exec/helper-proto.h"
-#include "tcg-gvec-desc.h"
+#include "tcg/tcg-gvec-desc.h"
/* Virtually all hosts support 16-byte vectors. Those that don't can emulate
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 55/67] amd_iommu: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (54 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 56/67] tcg: use include "tcg-gvec-desc.h.h" consistently Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 58/67] target/riscv: " Michael S. Tsirkin
` (15 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/target/i386/cpu.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/target/i386/cpu.h
diff --git a/include/target/i386/cpu.h b/include/target/i386/cpu.h
new file mode 100644
index 0000000..282f7a4
--- /dev/null
+++ b/include/target/i386/cpu.h
@@ -0,0 +1 @@
+#include_next "../target/i386/cpu.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 58/67] target/riscv: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (55 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 55/67] amd_iommu: add include directory header Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 57/67] kvm: use include "kvm_i386.h" consistently Michael S. Tsirkin
` (14 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/target/riscv/cpu.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/target/riscv/cpu.h
diff --git a/include/target/riscv/cpu.h b/include/target/riscv/cpu.h
new file mode 100644
index 0000000..0141f65
--- /dev/null
+++ b/include/target/riscv/cpu.h
@@ -0,0 +1 @@
+#include_next "../target/riscv/cpu.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 57/67] kvm: use include "kvm_i386.h" consistently
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (56 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 58/67] target/riscv: " Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-04 5:40 ` Marcel Apfelbaum
2018-05-03 19:51 ` [Qemu-devel] [PATCH 59/67] hw/ppc: add target headers explicitly Michael S. Tsirkin
` (13 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Marcel Apfelbaum,
Paolo Bonzini, Richard Henderson, Eduardo Habkost
Some places include kvm_i386.h, others target/i386/kvm_i386.h.
Let's be consistent.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/i386/kvm/apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/kvm/apic.c b/hw/i386/kvm/apic.c
index 1df6d26..ce43c3c 100644
--- a/hw/i386/kvm/apic.c
+++ b/hw/i386/kvm/apic.c
@@ -16,7 +16,7 @@
#include "hw/pci/msi.h"
#include "sysemu/hw_accel.h"
#include "sysemu/kvm.h"
-#include "target/i386/kvm_i386.h"
+#include "kvm_i386.h"
static inline void kvm_apic_set_reg(struct kvm_lapic_state *kapic,
int reg_id, uint32_t val)
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 57/67] kvm: use include "kvm_i386.h" consistently
2018-05-03 19:51 ` [Qemu-devel] [PATCH 57/67] kvm: use include "kvm_i386.h" consistently Michael S. Tsirkin
@ 2018-05-04 5:40 ` Marcel Apfelbaum
0 siblings, 0 replies; 144+ messages in thread
From: Marcel Apfelbaum @ 2018-05-04 5:40 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: kwolf, peter.maydell, Eduardo Habkost, Marcel Apfelbaum,
Paolo Bonzini, Richard Henderson
On 05/03/2018 10:51 PM, Michael S. Tsirkin wrote:
> Some places include kvm_i386.h, others target/i386/kvm_i386.h.
> Let's be consistent.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/i386/kvm/apic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/kvm/apic.c b/hw/i386/kvm/apic.c
> index 1df6d26..ce43c3c 100644
> --- a/hw/i386/kvm/apic.c
> +++ b/hw/i386/kvm/apic.c
> @@ -16,7 +16,7 @@
> #include "hw/pci/msi.h"
> #include "sysemu/hw_accel.h"
> #include "sysemu/kvm.h"
> -#include "target/i386/kvm_i386.h"
> +#include "kvm_i386.h"
>
> static inline void kvm_apic_set_reg(struct kvm_lapic_state *kapic,
> int reg_id, uint32_t val)
Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>
Thanks,
Marcel
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 59/67] hw/ppc: add target headers explicitly
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (57 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 57/67] kvm: use include "kvm_i386.h" consistently Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 23:36 ` David Gibson
2018-05-03 19:51 ` [Qemu-devel] [PATCH 60/67] hw/s390x: add include directory headers Michael S. Tsirkin
` (12 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, David Gibson,
Alexander Graf, qemu-ppc
This way they are easier to find.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/ppc/spapr.c | 6 +++---
hw/ppc/spapr_caps.c | 2 +-
hw/ppc/spapr_hcall.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index a81570e..62d625c 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -42,9 +42,9 @@
#include "migration/misc.h"
#include "migration/global_state.h"
#include "migration/register.h"
-#include "mmu-hash64.h"
-#include "mmu-book3s-v3.h"
-#include "cpu-models.h"
+#include "target/ppc/mmu-hash64.h"
+#include "target/ppc/mmu-book3s-v3.h"
+#include "target/ppc/cpu-models.h"
#include "qom/cpu.h"
#include "hw/boards.h"
diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c
index 531e145..b950a0a 100644
--- a/hw/ppc/spapr_caps.c
+++ b/hw/ppc/spapr_caps.c
@@ -27,7 +27,7 @@
#include "qapi/visitor.h"
#include "sysemu/hw_accel.h"
#include "target/ppc/cpu.h"
-#include "cpu-models.h"
+#include "target/ppc/cpu-models.h"
#include "kvm_ppc.h"
#include "hw/ppc/spapr.h"
diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
index 16bccdd..f011fa9 100644
--- a/hw/ppc/spapr_hcall.c
+++ b/hw/ppc/spapr_hcall.c
@@ -6,14 +6,14 @@
#include "qemu/error-report.h"
#include "cpu.h"
#include "exec/exec-all.h"
-#include "helper_regs.h"
+#include "target/ppc/helper_regs.h"
#include "hw/ppc/spapr.h"
#include "mmu-hash64.h"
#include "cpu-models.h"
#include "trace.h"
#include "kvm_ppc.h"
#include "hw/ppc/spapr_ovec.h"
-#include "mmu-book3s-v3.h"
+#include "target/ppc/mmu-book3s-v3.h"
struct SPRSyncState {
int spr;
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 59/67] hw/ppc: add target headers explicitly
2018-05-03 19:51 ` [Qemu-devel] [PATCH 59/67] hw/ppc: add target headers explicitly Michael S. Tsirkin
@ 2018-05-03 23:36 ` David Gibson
0 siblings, 0 replies; 144+ messages in thread
From: David Gibson @ 2018-05-03 23:36 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell,
Alexander Graf, qemu-ppc
[-- Attachment #1: Type: text/plain, Size: 2118 bytes --]
On Thu, May 03, 2018 at 10:51:39PM +0300, Michael S. Tsirkin wrote:
> This way they are easier to find.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> hw/ppc/spapr.c | 6 +++---
> hw/ppc/spapr_caps.c | 2 +-
> hw/ppc/spapr_hcall.c | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index a81570e..62d625c 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -42,9 +42,9 @@
> #include "migration/misc.h"
> #include "migration/global_state.h"
> #include "migration/register.h"
> -#include "mmu-hash64.h"
> -#include "mmu-book3s-v3.h"
> -#include "cpu-models.h"
> +#include "target/ppc/mmu-hash64.h"
> +#include "target/ppc/mmu-book3s-v3.h"
> +#include "target/ppc/cpu-models.h"
> #include "qom/cpu.h"
>
> #include "hw/boards.h"
> diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c
> index 531e145..b950a0a 100644
> --- a/hw/ppc/spapr_caps.c
> +++ b/hw/ppc/spapr_caps.c
> @@ -27,7 +27,7 @@
> #include "qapi/visitor.h"
> #include "sysemu/hw_accel.h"
> #include "target/ppc/cpu.h"
> -#include "cpu-models.h"
> +#include "target/ppc/cpu-models.h"
> #include "kvm_ppc.h"
>
> #include "hw/ppc/spapr.h"
> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> index 16bccdd..f011fa9 100644
> --- a/hw/ppc/spapr_hcall.c
> +++ b/hw/ppc/spapr_hcall.c
> @@ -6,14 +6,14 @@
> #include "qemu/error-report.h"
> #include "cpu.h"
> #include "exec/exec-all.h"
> -#include "helper_regs.h"
> +#include "target/ppc/helper_regs.h"
> #include "hw/ppc/spapr.h"
> #include "mmu-hash64.h"
> #include "cpu-models.h"
> #include "trace.h"
> #include "kvm_ppc.h"
> #include "hw/ppc/spapr_ovec.h"
> -#include "mmu-book3s-v3.h"
> +#include "target/ppc/mmu-book3s-v3.h"
>
> struct SPRSyncState {
> int spr;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 60/67] hw/s390x: add include directory headers
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (58 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 59/67] hw/ppc: add target headers explicitly Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-04 7:10 ` Cornelia Huck
2018-05-03 19:51 ` [Qemu-devel] [PATCH 61/67] hw/net: add include directory header Michael S. Tsirkin
` (11 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Cornelia Huck,
Christian Borntraeger, Alexander Graf, qemu-s390x
This way they are easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/s390x/ccw-device.h | 1 +
include/hw/s390x/ipl.h | 1 +
include/hw/s390x/s390-pci-bus.h | 1 +
include/hw/s390x/s390-pci-inst.h | 1 +
include/hw/s390x/s390-virtio-hcall.h | 1 +
include/hw/s390x/virtio-ccw.h | 1 +
6 files changed, 6 insertions(+)
create mode 100644 include/hw/s390x/ccw-device.h
create mode 100644 include/hw/s390x/ipl.h
create mode 100644 include/hw/s390x/s390-pci-bus.h
create mode 100644 include/hw/s390x/s390-pci-inst.h
create mode 100644 include/hw/s390x/s390-virtio-hcall.h
create mode 100644 include/hw/s390x/virtio-ccw.h
diff --git a/include/hw/s390x/ccw-device.h b/include/hw/s390x/ccw-device.h
new file mode 100644
index 0000000..ab761b3
--- /dev/null
+++ b/include/hw/s390x/ccw-device.h
@@ -0,0 +1 @@
+#include_next "../hw/s390x/ccw-device.h"
diff --git a/include/hw/s390x/ipl.h b/include/hw/s390x/ipl.h
new file mode 100644
index 0000000..21a3c5f
--- /dev/null
+++ b/include/hw/s390x/ipl.h
@@ -0,0 +1 @@
+#include_next "../hw/s390x/ipl.h"
diff --git a/include/hw/s390x/s390-pci-bus.h b/include/hw/s390x/s390-pci-bus.h
new file mode 100644
index 0000000..67ead13
--- /dev/null
+++ b/include/hw/s390x/s390-pci-bus.h
@@ -0,0 +1 @@
+#include_next "../hw/s390x/s390-pci-bus.h"
diff --git a/include/hw/s390x/s390-pci-inst.h b/include/hw/s390x/s390-pci-inst.h
new file mode 100644
index 0000000..f4f0106
--- /dev/null
+++ b/include/hw/s390x/s390-pci-inst.h
@@ -0,0 +1 @@
+#include_next "../hw/s390x/s390-pci-inst.h"
diff --git a/include/hw/s390x/s390-virtio-hcall.h b/include/hw/s390x/s390-virtio-hcall.h
new file mode 100644
index 0000000..4d7a2ed
--- /dev/null
+++ b/include/hw/s390x/s390-virtio-hcall.h
@@ -0,0 +1 @@
+#include_next "../hw/s390x/s390-virtio-hcall.h"
diff --git a/include/hw/s390x/virtio-ccw.h b/include/hw/s390x/virtio-ccw.h
new file mode 100644
index 0000000..4f22f9d
--- /dev/null
+++ b/include/hw/s390x/virtio-ccw.h
@@ -0,0 +1 @@
+#include_next "../hw/s390x/virtio-ccw.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 60/67] hw/s390x: add include directory headers
2018-05-03 19:51 ` [Qemu-devel] [PATCH 60/67] hw/s390x: add include directory headers Michael S. Tsirkin
@ 2018-05-04 7:10 ` Cornelia Huck
2018-05-04 13:07 ` [Qemu-devel] " Eric Blake
0 siblings, 1 reply; 144+ messages in thread
From: Cornelia Huck @ 2018-05-04 7:10 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell,
Christian Borntraeger, Alexander Graf, qemu-s390x
On Thu, 3 May 2018 22:51:40 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> This way they are easier to find using standard rules.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/hw/s390x/ccw-device.h | 1 +
> include/hw/s390x/ipl.h | 1 +
> include/hw/s390x/s390-pci-bus.h | 1 +
> include/hw/s390x/s390-pci-inst.h | 1 +
> include/hw/s390x/s390-virtio-hcall.h | 1 +
> include/hw/s390x/virtio-ccw.h | 1 +
> 6 files changed, 6 insertions(+)
> create mode 100644 include/hw/s390x/ccw-device.h
> create mode 100644 include/hw/s390x/ipl.h
> create mode 100644 include/hw/s390x/s390-pci-bus.h
> create mode 100644 include/hw/s390x/s390-pci-inst.h
> create mode 100644 include/hw/s390x/s390-virtio-hcall.h
> create mode 100644 include/hw/s390x/virtio-ccw.h
>
> diff --git a/include/hw/s390x/ccw-device.h b/include/hw/s390x/ccw-device.h
> new file mode 100644
> index 0000000..ab761b3
> --- /dev/null
> +++ b/include/hw/s390x/ccw-device.h
> @@ -0,0 +1 @@
> +#include_next "../hw/s390x/ccw-device.h"
Eww. I find this very ugly.
[Goes to find cover letter to figure out what this is all about.
*Please*, cc: people on the cover letter so they can see immediately
what this is trying to do!]
After reading the cover letter, I still don't like this. If you want to
move headers under include/ (which I don't have a problem with), please
move them and do not introduce these weird constructs.
[Also, that might need a MAINTAINERS update :)]
^ permalink raw reply [flat|nested] 144+ messages in thread
* cover letter cc's [was: [PATCH 60/67] hw/s390x: add include directory headers]
2018-05-04 7:10 ` Cornelia Huck
@ 2018-05-04 13:07 ` Eric Blake
0 siblings, 0 replies; 144+ messages in thread
From: Eric Blake @ 2018-05-04 13:07 UTC (permalink / raw)
To: Cornelia Huck, Michael S. Tsirkin
Cc: qemu-devel, berrange, kwolf, peter.maydell,
Christian Borntraeger, Alexander Graf, qemu-s390x, git
[adding a cross-post to the git mailing list]
On 05/04/2018 02:10 AM, Cornelia Huck wrote:
> On Thu, 3 May 2018 22:51:40 +0300
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
>> This way they are easier to find using standard rules.
>>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
...
> [Goes to find cover letter to figure out what this is all about.
> *Please*, cc: people on the cover letter so they can see immediately
> what this is trying to do!]
Is there an EASY way to make 'git format-patch --cover-letter $commitid'
(and git send-email, by extension) automatically search for all cc's any
any of the N/M patches, and auto-cc ALL of those recipients on the 0/N
cover letter? And if that is not something easily built into git
format-patch directly, is it something that can easily be added to
sendemail.cccmd? This is not the first time that someone has complained
that automatic cc's are not sending the cover letter context to a
particular maintainer interested (and auto-cc'd) in only a subset of an
overall series.
On the other hand, cc'ing all recipients for a largely mechanical patch
series that was split into 67 parts, in part because it touches so many
different maintainers' areas, may make the cover letter have so many
recipients that various mail gateways start rejecting it as potential spam.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] cover letter cc's [was: [PATCH 60/67] hw/s390x: add include directory headers]
@ 2018-05-04 13:07 ` Eric Blake
0 siblings, 0 replies; 144+ messages in thread
From: Eric Blake @ 2018-05-04 13:07 UTC (permalink / raw)
To: Cornelia Huck, Michael S. Tsirkin
Cc: qemu-devel, berrange, kwolf, peter.maydell,
Christian Borntraeger, Alexander Graf, qemu-s390x, git
[adding a cross-post to the git mailing list]
On 05/04/2018 02:10 AM, Cornelia Huck wrote:
> On Thu, 3 May 2018 22:51:40 +0300
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
>> This way they are easier to find using standard rules.
>>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
...
> [Goes to find cover letter to figure out what this is all about.
> *Please*, cc: people on the cover letter so they can see immediately
> what this is trying to do!]
Is there an EASY way to make 'git format-patch --cover-letter $commitid'
(and git send-email, by extension) automatically search for all cc's any
any of the N/M patches, and auto-cc ALL of those recipients on the 0/N
cover letter? And if that is not something easily built into git
format-patch directly, is it something that can easily be added to
sendemail.cccmd? This is not the first time that someone has complained
that automatic cc's are not sending the cover letter context to a
particular maintainer interested (and auto-cc'd) in only a subset of an
overall series.
On the other hand, cc'ing all recipients for a largely mechanical patch
series that was split into 67 parts, in part because it touches so many
different maintainers' areas, may make the cover letter have so many
recipients that various mail gateways start rejecting it as potential spam.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: cover letter cc's [was: [PATCH 60/67] hw/s390x: add include directory headers]
2018-05-04 13:07 ` [Qemu-devel] " Eric Blake
@ 2018-05-04 13:26 ` Cornelia Huck
-1 siblings, 0 replies; 144+ messages in thread
From: Cornelia Huck @ 2018-05-04 13:26 UTC (permalink / raw)
To: Eric Blake
Cc: Michael S. Tsirkin, qemu-devel, berrange, kwolf, peter.maydell,
Christian Borntraeger, Alexander Graf, qemu-s390x, git
On Fri, 4 May 2018 08:07:53 -0500
Eric Blake <eblake@redhat.com> wrote:
> [adding a cross-post to the git mailing list]
>
> On 05/04/2018 02:10 AM, Cornelia Huck wrote:
> > On Thu, 3 May 2018 22:51:40 +0300
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >
> >> This way they are easier to find using standard rules.
> >>
> >> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >> ---
> ...
>
> > [Goes to find cover letter to figure out what this is all about.
> > *Please*, cc: people on the cover letter so they can see immediately
> > what this is trying to do!]
>
> Is there an EASY way to make 'git format-patch --cover-letter $commitid'
> (and git send-email, by extension) automatically search for all cc's any
> any of the N/M patches, and auto-cc ALL of those recipients on the 0/N
> cover letter? And if that is not something easily built into git
> format-patch directly, is it something that can easily be added to
> sendemail.cccmd? This is not the first time that someone has complained
> that automatic cc's are not sending the cover letter context to a
> particular maintainer interested (and auto-cc'd) in only a subset of an
> overall series.
I think for most cases where I've been cc:ed on the cover letter and
only some of the patches, people actually added cc: lines to the cover
letter manually.
>
> On the other hand, cc'ing all recipients for a largely mechanical patch
> series that was split into 67 parts, in part because it touches so many
> different maintainers' areas, may make the cover letter have so many
> recipients that various mail gateways start rejecting it as potential spam.
Yes, large cross-subsystem patch series make this painful.
If I get some patches like "subsystem: frobnicate foo" and it's clear
that it's simply frobnicating foo for various subsystems, I can see
what this is about without reading the cover letter, no need to cc: me.
In this case, however, the patch did not make any sense at all without
looking at the explanation in the cover letter.
So I think we don't want to do this automatically, although some way to
collect potential candidates for cc:ing on the cover letter might be
helpful.
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] cover letter cc's [was: [PATCH 60/67] hw/s390x: add include directory headers]
@ 2018-05-04 13:26 ` Cornelia Huck
0 siblings, 0 replies; 144+ messages in thread
From: Cornelia Huck @ 2018-05-04 13:26 UTC (permalink / raw)
To: Eric Blake
Cc: Michael S. Tsirkin, qemu-devel, berrange, kwolf, peter.maydell,
Christian Borntraeger, Alexander Graf, qemu-s390x, git
On Fri, 4 May 2018 08:07:53 -0500
Eric Blake <eblake@redhat.com> wrote:
> [adding a cross-post to the git mailing list]
>
> On 05/04/2018 02:10 AM, Cornelia Huck wrote:
> > On Thu, 3 May 2018 22:51:40 +0300
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >
> >> This way they are easier to find using standard rules.
> >>
> >> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >> ---
> ...
>
> > [Goes to find cover letter to figure out what this is all about.
> > *Please*, cc: people on the cover letter so they can see immediately
> > what this is trying to do!]
>
> Is there an EASY way to make 'git format-patch --cover-letter $commitid'
> (and git send-email, by extension) automatically search for all cc's any
> any of the N/M patches, and auto-cc ALL of those recipients on the 0/N
> cover letter? And if that is not something easily built into git
> format-patch directly, is it something that can easily be added to
> sendemail.cccmd? This is not the first time that someone has complained
> that automatic cc's are not sending the cover letter context to a
> particular maintainer interested (and auto-cc'd) in only a subset of an
> overall series.
I think for most cases where I've been cc:ed on the cover letter and
only some of the patches, people actually added cc: lines to the cover
letter manually.
>
> On the other hand, cc'ing all recipients for a largely mechanical patch
> series that was split into 67 parts, in part because it touches so many
> different maintainers' areas, may make the cover letter have so many
> recipients that various mail gateways start rejecting it as potential spam.
Yes, large cross-subsystem patch series make this painful.
If I get some patches like "subsystem: frobnicate foo" and it's clear
that it's simply frobnicating foo for various subsystems, I can see
what this is about without reading the cover letter, no need to cc: me.
In this case, however, the patch did not make any sense at all without
looking at the explanation in the cover letter.
So I think we don't want to do this automatically, although some way to
collect potential candidates for cc:ing on the cover letter might be
helpful.
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: cover letter cc's [was: [PATCH 60/67] hw/s390x: add include directory headers]
2018-05-04 13:26 ` [Qemu-devel] " Cornelia Huck
@ 2018-05-04 13:32 ` Peter Maydell
-1 siblings, 0 replies; 144+ messages in thread
From: Peter Maydell @ 2018-05-04 13:32 UTC (permalink / raw)
To: Cornelia Huck
Cc: Eric Blake, Michael S. Tsirkin, QEMU Developers,
Daniel P. Berrange, Kevin Wolf, Christian Borntraeger,
Alexander Graf, qemu-s390x, git
On 4 May 2018 at 14:26, Cornelia Huck <cohuck@redhat.com> wrote:
> On Fri, 4 May 2018 08:07:53 -0500
> Eric Blake <eblake@redhat.com> wrote:
>> On the other hand, cc'ing all recipients for a largely mechanical patch
>> series that was split into 67 parts, in part because it touches so many
>> different maintainers' areas, may make the cover letter have so many
>> recipients that various mail gateways start rejecting it as potential spam.
>
> Yes, large cross-subsystem patch series make this painful.
My solution is to either (a) avoid them or (b) not bother cc'ing
people (except people I think might be interested in reviewing
cross-subsystem patchsets like Eric ;-))...
thanks
-- PMM
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] cover letter cc's [was: [PATCH 60/67] hw/s390x: add include directory headers]
@ 2018-05-04 13:32 ` Peter Maydell
0 siblings, 0 replies; 144+ messages in thread
From: Peter Maydell @ 2018-05-04 13:32 UTC (permalink / raw)
To: Cornelia Huck
Cc: Eric Blake, Michael S. Tsirkin, QEMU Developers,
Daniel P. Berrange, Kevin Wolf, Christian Borntraeger,
Alexander Graf, qemu-s390x, git
On 4 May 2018 at 14:26, Cornelia Huck <cohuck@redhat.com> wrote:
> On Fri, 4 May 2018 08:07:53 -0500
> Eric Blake <eblake@redhat.com> wrote:
>> On the other hand, cc'ing all recipients for a largely mechanical patch
>> series that was split into 67 parts, in part because it touches so many
>> different maintainers' areas, may make the cover letter have so many
>> recipients that various mail gateways start rejecting it as potential spam.
>
> Yes, large cross-subsystem patch series make this painful.
My solution is to either (a) avoid them or (b) not bother cc'ing
people (except people I think might be interested in reviewing
cross-subsystem patchsets like Eric ;-))...
thanks
-- PMM
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: cover letter cc's [was: [PATCH 60/67] hw/s390x: add include directory headers]
2018-05-04 13:07 ` [Qemu-devel] " Eric Blake
@ 2018-05-04 21:38 ` Michael S. Tsirkin
-1 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-04 21:38 UTC (permalink / raw)
To: Eric Blake
Cc: Cornelia Huck, qemu-devel, berrange, kwolf, peter.maydell,
Christian Borntraeger, Alexander Graf, qemu-s390x, git
On Fri, May 04, 2018 at 08:07:53AM -0500, Eric Blake wrote:
> [adding a cross-post to the git mailing list]
>
> On 05/04/2018 02:10 AM, Cornelia Huck wrote:
> > On Thu, 3 May 2018 22:51:40 +0300
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >
> > > This way they are easier to find using standard rules.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > ---
> ...
>
> > [Goes to find cover letter to figure out what this is all about.
> > *Please*, cc: people on the cover letter so they can see immediately
> > what this is trying to do!]
>
> Is there an EASY way to make 'git format-patch --cover-letter $commitid'
> (and git send-email, by extension) automatically search for all cc's any any
> of the N/M patches, and auto-cc ALL of those recipients on the 0/N cover
> letter? And if that is not something easily built into git format-patch
> directly, is it something that can easily be added to sendemail.cccmd? This
> is not the first time that someone has complained that automatic cc's are
> not sending the cover letter context to a particular maintainer interested
> (and auto-cc'd) in only a subset of an overall series.
>
> On the other hand, cc'ing all recipients for a largely mechanical patch
> series that was split into 67 parts, in part because it touches so many
> different maintainers' areas, may make the cover letter have so many
> recipients that various mail gateways start rejecting it as potential spam.
I do this sometimes (pipe to this script):
grep -e ^Signed-off-by -e ^Acked -e ^Reported -e ^Tested -e ^Cc | sed 's/.*<//'| sed 's/>.*//'|sort | uniq | sed 's/^/Cc: /'
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] cover letter cc's [was: [PATCH 60/67] hw/s390x: add include directory headers]
@ 2018-05-04 21:38 ` Michael S. Tsirkin
0 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-04 21:38 UTC (permalink / raw)
To: Eric Blake
Cc: Cornelia Huck, qemu-devel, berrange, kwolf, peter.maydell,
Christian Borntraeger, Alexander Graf, qemu-s390x, git
On Fri, May 04, 2018 at 08:07:53AM -0500, Eric Blake wrote:
> [adding a cross-post to the git mailing list]
>
> On 05/04/2018 02:10 AM, Cornelia Huck wrote:
> > On Thu, 3 May 2018 22:51:40 +0300
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >
> > > This way they are easier to find using standard rules.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > ---
> ...
>
> > [Goes to find cover letter to figure out what this is all about.
> > *Please*, cc: people on the cover letter so they can see immediately
> > what this is trying to do!]
>
> Is there an EASY way to make 'git format-patch --cover-letter $commitid'
> (and git send-email, by extension) automatically search for all cc's any any
> of the N/M patches, and auto-cc ALL of those recipients on the 0/N cover
> letter? And if that is not something easily built into git format-patch
> directly, is it something that can easily be added to sendemail.cccmd? This
> is not the first time that someone has complained that automatic cc's are
> not sending the cover letter context to a particular maintainer interested
> (and auto-cc'd) in only a subset of an overall series.
>
> On the other hand, cc'ing all recipients for a largely mechanical patch
> series that was split into 67 parts, in part because it touches so many
> different maintainers' areas, may make the cover letter have so many
> recipients that various mail gateways start rejecting it as potential spam.
I do this sometimes (pipe to this script):
grep -e ^Signed-off-by -e ^Acked -e ^Reported -e ^Tested -e ^Cc | sed 's/.*<//'| sed 's/>.*//'|sort | uniq | sed 's/^/Cc: /'
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 61/67] hw/net: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (59 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 60/67] hw/s390x: add include directory headers Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 62/67] kvm: use include "kvm_ppc.h" consistently Michael S. Tsirkin
` (10 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Jason Wang
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/net/fsl_etsec/etsec.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/hw/net/fsl_etsec/etsec.h
diff --git a/include/hw/net/fsl_etsec/etsec.h b/include/hw/net/fsl_etsec/etsec.h
new file mode 100644
index 0000000..7d5e659
--- /dev/null
+++ b/include/hw/net/fsl_etsec/etsec.h
@@ -0,0 +1 @@
+#include_next "../hw/net/fsl_etsec/etsec.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 62/67] kvm: use include "kvm_ppc.h" consistently
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (60 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 61/67] hw/net: add include directory header Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-04 0:17 ` David Gibson
2018-05-03 19:51 ` [Qemu-devel] [PATCH 63/67] hw/s390x: use target headers explicitly Michael S. Tsirkin
` (9 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, David Gibson,
Alexander Graf, qemu-ppc
Some places include kvm_ppc.h, others target/ppc/kvm_ppc.h.
Let's be consistent.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/ppc/spapr_cpu_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c
index 94afeb3..312d6ed 100644
--- a/hw/ppc/spapr_cpu_core.c
+++ b/hw/ppc/spapr_cpu_core.c
@@ -15,7 +15,7 @@
#include "qapi/error.h"
#include "sysemu/cpus.h"
#include "sysemu/kvm.h"
-#include "target/ppc/kvm_ppc.h"
+#include "kvm_ppc.h"
#include "hw/ppc/ppc.h"
#include "target/ppc/mmu-hash64.h"
#include "sysemu/numa.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 62/67] kvm: use include "kvm_ppc.h" consistently
2018-05-03 19:51 ` [Qemu-devel] [PATCH 62/67] kvm: use include "kvm_ppc.h" consistently Michael S. Tsirkin
@ 2018-05-04 0:17 ` David Gibson
2018-05-04 2:44 ` Michael S. Tsirkin
0 siblings, 1 reply; 144+ messages in thread
From: David Gibson @ 2018-05-04 0:17 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell,
Alexander Graf, qemu-ppc
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
On Thu, May 03, 2018 at 10:51:42PM +0300, Michael S. Tsirkin wrote:
> Some places include kvm_ppc.h, others target/ppc/kvm_ppc.h.
> Let's be consistent.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
One of your earlier patches in this series moved to using a full
target/ppc/whatever.h for includers outside target/ppc itself. So I'm
not sure why you're standardizing on the short form here.
> ---
> hw/ppc/spapr_cpu_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c
> index 94afeb3..312d6ed 100644
> --- a/hw/ppc/spapr_cpu_core.c
> +++ b/hw/ppc/spapr_cpu_core.c
> @@ -15,7 +15,7 @@
> #include "qapi/error.h"
> #include "sysemu/cpus.h"
> #include "sysemu/kvm.h"
> -#include "target/ppc/kvm_ppc.h"
> +#include "kvm_ppc.h"
> #include "hw/ppc/ppc.h"
> #include "target/ppc/mmu-hash64.h"
> #include "sysemu/numa.h"
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 62/67] kvm: use include "kvm_ppc.h" consistently
2018-05-04 0:17 ` David Gibson
@ 2018-05-04 2:44 ` Michael S. Tsirkin
2018-05-04 3:15 ` David Gibson
0 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-04 2:44 UTC (permalink / raw)
To: David Gibson
Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell,
Alexander Graf, qemu-ppc
On Fri, May 04, 2018 at 10:17:01AM +1000, David Gibson wrote:
> On Thu, May 03, 2018 at 10:51:42PM +0300, Michael S. Tsirkin wrote:
> > Some places include kvm_ppc.h, others target/ppc/kvm_ppc.h.
> > Let's be consistent.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> One of your earlier patches in this series moved to using a full
> target/ppc/whatever.h for includers outside target/ppc itself. So I'm
> not sure why you're standardizing on the short form here.
It's not a short form. The specific header is kvm_ppc.h. That's how
most files used it so I selected a location minimizing the churn.
I also don't know why is it kvm_ppc.h and not just kvm.h.
> > ---
> > hw/ppc/spapr_cpu_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c
> > index 94afeb3..312d6ed 100644
> > --- a/hw/ppc/spapr_cpu_core.c
> > +++ b/hw/ppc/spapr_cpu_core.c
> > @@ -15,7 +15,7 @@
> > #include "qapi/error.h"
> > #include "sysemu/cpus.h"
> > #include "sysemu/kvm.h"
> > -#include "target/ppc/kvm_ppc.h"
> > +#include "kvm_ppc.h"
> > #include "hw/ppc/ppc.h"
> > #include "target/ppc/mmu-hash64.h"
> > #include "sysemu/numa.h"
>
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 62/67] kvm: use include "kvm_ppc.h" consistently
2018-05-04 2:44 ` Michael S. Tsirkin
@ 2018-05-04 3:15 ` David Gibson
0 siblings, 0 replies; 144+ messages in thread
From: David Gibson @ 2018-05-04 3:15 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell,
Alexander Graf, qemu-ppc
[-- Attachment #1: Type: text/plain, Size: 1955 bytes --]
On Fri, May 04, 2018 at 05:44:02AM +0300, Michael S. Tsirkin wrote:
> On Fri, May 04, 2018 at 10:17:01AM +1000, David Gibson wrote:
> > On Thu, May 03, 2018 at 10:51:42PM +0300, Michael S. Tsirkin wrote:
> > > Some places include kvm_ppc.h, others target/ppc/kvm_ppc.h.
> > > Let's be consistent.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > One of your earlier patches in this series moved to using a full
> > target/ppc/whatever.h for includers outside target/ppc itself. So I'm
> > not sure why you're standardizing on the short form here.
>
> It's not a short form. The specific header is kvm_ppc.h.
I don't see what you're getting at. Just a couple of lines below in
the context we have #include "target/ppc/mmu-hash64.h". That's in
exactly the same directory as kvm_ppc.h - which does it get the path,
but this one doesn't?
> That's how
> most files used it so I selected a location minimizing the churn.
>
> I also don't know why is it kvm_ppc.h and not just kvm.h.
Neither do I, it was like that when I started work on qemu and I've
never had a compelling reason to change it.
>
> > > ---
> > > hw/ppc/spapr_cpu_core.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c
> > > index 94afeb3..312d6ed 100644
> > > --- a/hw/ppc/spapr_cpu_core.c
> > > +++ b/hw/ppc/spapr_cpu_core.c
> > > @@ -15,7 +15,7 @@
> > > #include "qapi/error.h"
> > > #include "sysemu/cpus.h"
> > > #include "sysemu/kvm.h"
> > > -#include "target/ppc/kvm_ppc.h"
> > > +#include "kvm_ppc.h"
> > > #include "hw/ppc/ppc.h"
> > > #include "target/ppc/mmu-hash64.h"
> > > #include "sysemu/numa.h"
> >
>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 63/67] hw/s390x: use target headers explicitly
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (61 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 62/67] kvm: use include "kvm_ppc.h" consistently Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-08 13:48 ` Cornelia Huck
2018-05-03 19:51 ` [Qemu-devel] [PATCH 64/67] target/s390x: add include directory header Michael S. Tsirkin
` (8 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Cornelia Huck,
Christian Borntraeger, Alexander Graf, Richard Henderson,
David Hildenbrand, qemu-s390x
This way they are easier to find.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/s390x/s390-virtio-ccw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 435f7c9..418dc48 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -33,7 +33,7 @@
#include "hw/s390x/s390-virtio-ccw.h"
#include "hw/s390x/css-bridge.h"
#include "migration/register.h"
-#include "cpu_models.h"
+#include "target/s390x/cpu_models.h"
#include "hw/nmi.h"
S390CPU *s390_cpu_addr2state(uint16_t cpu_addr)
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 63/67] hw/s390x: use target headers explicitly
2018-05-03 19:51 ` [Qemu-devel] [PATCH 63/67] hw/s390x: use target headers explicitly Michael S. Tsirkin
@ 2018-05-08 13:48 ` Cornelia Huck
0 siblings, 0 replies; 144+ messages in thread
From: Cornelia Huck @ 2018-05-08 13:48 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell,
Christian Borntraeger, Alexander Graf, Richard Henderson,
David Hildenbrand, qemu-s390x
On Thu, 3 May 2018 22:51:43 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> This way they are easier to find.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/s390x/s390-virtio-ccw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index 435f7c9..418dc48 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -33,7 +33,7 @@
> #include "hw/s390x/s390-virtio-ccw.h"
> #include "hw/s390x/css-bridge.h"
> #include "migration/register.h"
> -#include "cpu_models.h"
> +#include "target/s390x/cpu_models.h"
> #include "hw/nmi.h"
>
> S390CPU *s390_cpu_addr2state(uint16_t cpu_addr)
Acked-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 64/67] target/s390x: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (62 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 63/67] hw/s390x: use target headers explicitly Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-08 13:50 ` Cornelia Huck
2018-05-03 19:51 ` [Qemu-devel] [PATCH 66/67] linux-user: " Michael S. Tsirkin
` (7 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Cornelia Huck, qemu-s390x
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/target/s390x/cpu_models.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/target/s390x/cpu_models.h
diff --git a/include/target/s390x/cpu_models.h b/include/target/s390x/cpu_models.h
new file mode 100644
index 0000000..f66ea19
--- /dev/null
+++ b/include/target/s390x/cpu_models.h
@@ -0,0 +1 @@
+#include_next "../target/s390x/cpu_models.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 64/67] target/s390x: add include directory header
2018-05-03 19:51 ` [Qemu-devel] [PATCH 64/67] target/s390x: add include directory header Michael S. Tsirkin
@ 2018-05-08 13:50 ` Cornelia Huck
0 siblings, 0 replies; 144+ messages in thread
From: Cornelia Huck @ 2018-05-08 13:50 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: qemu-devel, eblake, berrange, kwolf, peter.maydell, qemu-s390x
On Thu, 3 May 2018 22:51:45 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> This way it is easier to find using standard rules.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/target/s390x/cpu_models.h | 1 +
> 1 file changed, 1 insertion(+)
> create mode 100644 include/target/s390x/cpu_models.h
>
> diff --git a/include/target/s390x/cpu_models.h b/include/target/s390x/cpu_models.h
> new file mode 100644
> index 0000000..f66ea19
> --- /dev/null
> +++ b/include/target/s390x/cpu_models.h
> @@ -0,0 +1 @@
> +#include_next "../target/s390x/cpu_models.h"
FWIW, I don't like this any better than the other one.
^ permalink raw reply [flat|nested] 144+ messages in thread
* [Qemu-devel] [PATCH 66/67] linux-user: add include directory header
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (63 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 64/67] target/s390x: add include directory header Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 65/67] tcg: use include "translate-all.h" consistently Michael S. Tsirkin
` (6 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell
This way it is easier to find using standard rules.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/linux-user/syscall_defs.h | 1 +
1 file changed, 1 insertion(+)
create mode 100644 include/linux-user/syscall_defs.h
diff --git a/include/linux-user/syscall_defs.h b/include/linux-user/syscall_defs.h
new file mode 100644
index 0000000..e1e0b1f
--- /dev/null
+++ b/include/linux-user/syscall_defs.h
@@ -0,0 +1 @@
+#include_next "../linux-user/syscall_defs.h"
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 65/67] tcg: use include "translate-all.h" consistently
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (64 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 66/67] linux-user: " Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 19:51 ` [Qemu-devel] [PATCH 67/67] make: simplify source include path Michael S. Tsirkin
` (5 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake, berrange, kwolf, peter.maydell, Max Filippov
Some places include translate-all.h, others accel/tcg/translate-all.h.
Let's be consistent.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
target/xtensa/op_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/xtensa/op_helper.c b/target/xtensa/op_helper.c
index e3bcbe1..ede60ea 100644
--- a/target/xtensa/op_helper.c
+++ b/target/xtensa/op_helper.c
@@ -38,7 +38,7 @@
#ifdef CONFIG_USER_ONLY
/* tb_invalidate_phys_range */
-#include "accel/tcg/translate-all.h"
+#include "translate-all.h"
#endif
#ifndef CONFIG_USER_ONLY
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* [Qemu-devel] [PATCH 67/67] make: simplify source include path
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (65 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 65/67] tcg: use include "translate-all.h" consistently Michael S. Tsirkin
@ 2018-05-03 19:51 ` Michael S. Tsirkin
2018-05-03 20:22 ` Eric Blake
2018-05-03 20:58 ` [Qemu-devel] [PATCH 00/67] include path cleanup no-reply
` (4 subsequent siblings)
71 siblings, 1 reply; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 19:51 UTC (permalink / raw)
To: qemu-devel
Cc: eblake, berrange, kwolf, peter.maydell, Paolo Bonzini,
Philippe Mathieu-Daudé,
Yang Zhong, Richard Henderson, Gerd Hoffmann, Fam Zheng
Include all files in the source directory through include/ directory.
This helps ensure consistent naming and makes it easier to locate any
specific header.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
configure | 3 +--
Makefile.target | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index 0a19b03..3d5d2b9 100755
--- a/configure
+++ b/configure
@@ -534,7 +534,7 @@ QEMU_CFLAGS="-fno-strict-aliasing -fno-common -fwrapv $QEMU_CFLAGS"
QEMU_CFLAGS="-Wall -Wundef -Wwrite-strings -Wmissing-prototypes $QEMU_CFLAGS"
QEMU_CFLAGS="-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS"
QEMU_CFLAGS="-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE $QEMU_CFLAGS"
-QEMU_INCLUDES="-iquote . -iquote \$(SRC_PATH) -iquote \$(SRC_PATH)/accel/tcg -iquote \$(SRC_PATH)/include"
+QEMU_INCLUDES="-iquote . -iquote \$(SRC_PATH)/include"
if test "$debug_info" = "yes"; then
CFLAGS="-g $CFLAGS"
LDFLAGS="-g $LDFLAGS"
@@ -6631,7 +6631,6 @@ elif test "$ARCH" = "ppc64" ; then
else
QEMU_INCLUDES="-iquote \$(SRC_PATH)/tcg/\$(ARCH) $QEMU_INCLUDES"
fi
-QEMU_INCLUDES="-iquote \$(SRC_PATH)/tcg $QEMU_INCLUDES"
echo "TOOLS=$tools" >> $config_host_mak
echo "ROMS=$roms" >> $config_host_mak
diff --git a/Makefile.target b/Makefile.target
index d0ec77a..b6605ed 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -11,7 +11,7 @@ $(call set-vpath, $(SRC_PATH):$(BUILD_DIR))
ifdef CONFIG_LINUX
QEMU_CFLAGS += -I../linux-headers
endif
-QEMU_CFLAGS += -iquote .. -iquote $(SRC_PATH)/target/$(TARGET_BASE_ARCH) -DNEED_CPU_H
+QEMU_CFLAGS += -iquote .. -iquote $(SRC_PATH)/include/target/$(TARGET_BASE_ARCH) -DNEED_CPU_H
QEMU_CFLAGS+=-iquote $(SRC_PATH)/include
--
MST
^ permalink raw reply related [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 67/67] make: simplify source include path
2018-05-03 19:51 ` [Qemu-devel] [PATCH 67/67] make: simplify source include path Michael S. Tsirkin
@ 2018-05-03 20:22 ` Eric Blake
2018-05-03 20:31 ` Michael S. Tsirkin
0 siblings, 1 reply; 144+ messages in thread
From: Eric Blake @ 2018-05-03 20:22 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: berrange, kwolf, peter.maydell, Paolo Bonzini,
Philippe Mathieu-Daudé,
Yang Zhong, Richard Henderson, Gerd Hoffmann, Fam Zheng
On 05/03/2018 02:51 PM, Michael S. Tsirkin wrote:
> Include all files in the source directory through include/ directory.
> This helps ensure consistent naming and makes it easier to locate any
> specific header.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> configure | 3 +--
> Makefile.target | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 0a19b03..3d5d2b9 100755
> --- a/configure
> +++ b/configure
> @@ -534,7 +534,7 @@ QEMU_CFLAGS="-fno-strict-aliasing -fno-common -fwrapv $QEMU_CFLAGS"
> QEMU_CFLAGS="-Wall -Wundef -Wwrite-strings -Wmissing-prototypes $QEMU_CFLAGS"
> QEMU_CFLAGS="-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS"
> QEMU_CFLAGS="-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE $QEMU_CFLAGS"
> -QEMU_INCLUDES="-iquote . -iquote \$(SRC_PATH) -iquote \$(SRC_PATH)/accel/tcg -iquote \$(SRC_PATH)/include"
> +QEMU_INCLUDES="-iquote . -iquote \$(SRC_PATH)/include"
I think this is a nice cleanup.
> if test "$debug_info" = "yes"; then
> CFLAGS="-g $CFLAGS"
> LDFLAGS="-g $LDFLAGS"
> @@ -6631,7 +6631,6 @@ elif test "$ARCH" = "ppc64" ; then
> else
> QEMU_INCLUDES="-iquote \$(SRC_PATH)/tcg/\$(ARCH) $QEMU_INCLUDES"
Should you also be cleaning up this line?
> fi
> -QEMU_INCLUDES="-iquote \$(SRC_PATH)/tcg $QEMU_INCLUDES"
>
> echo "TOOLS=$tools" >> $config_host_mak
> echo "ROMS=$roms" >> $config_host_mak
> diff --git a/Makefile.target b/Makefile.target
> index d0ec77a..b6605ed 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -11,7 +11,7 @@ $(call set-vpath, $(SRC_PATH):$(BUILD_DIR))
> ifdef CONFIG_LINUX
> QEMU_CFLAGS += -I../linux-headers
> endif
> -QEMU_CFLAGS += -iquote .. -iquote $(SRC_PATH)/target/$(TARGET_BASE_ARCH) -DNEED_CPU_H
> +QEMU_CFLAGS += -iquote .. -iquote $(SRC_PATH)/include/target/$(TARGET_BASE_ARCH) -DNEED_CPU_H
>
> QEMU_CFLAGS+=-iquote $(SRC_PATH)/include
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 67/67] make: simplify source include path
2018-05-03 20:22 ` Eric Blake
@ 2018-05-03 20:31 ` Michael S. Tsirkin
0 siblings, 0 replies; 144+ messages in thread
From: Michael S. Tsirkin @ 2018-05-03 20:31 UTC (permalink / raw)
To: Eric Blake
Cc: qemu-devel, berrange, kwolf, peter.maydell, Paolo Bonzini,
Philippe Mathieu-Daudé,
Yang Zhong, Richard Henderson, Gerd Hoffmann, Fam Zheng
On Thu, May 03, 2018 at 03:22:39PM -0500, Eric Blake wrote:
> On 05/03/2018 02:51 PM, Michael S. Tsirkin wrote:
> > Include all files in the source directory through include/ directory.
> > This helps ensure consistent naming and makes it easier to locate any
> > specific header.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > configure | 3 +--
> > Makefile.target | 2 +-
> > 2 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/configure b/configure
> > index 0a19b03..3d5d2b9 100755
> > --- a/configure
> > +++ b/configure
> > @@ -534,7 +534,7 @@ QEMU_CFLAGS="-fno-strict-aliasing -fno-common -fwrapv $QEMU_CFLAGS"
> > QEMU_CFLAGS="-Wall -Wundef -Wwrite-strings -Wmissing-prototypes $QEMU_CFLAGS"
> > QEMU_CFLAGS="-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS"
> > QEMU_CFLAGS="-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE $QEMU_CFLAGS"
> > -QEMU_INCLUDES="-iquote . -iquote \$(SRC_PATH) -iquote \$(SRC_PATH)/accel/tcg -iquote \$(SRC_PATH)/include"
> > +QEMU_INCLUDES="-iquote . -iquote \$(SRC_PATH)/include"
>
> I think this is a nice cleanup.
>
> > if test "$debug_info" = "yes"; then
> > CFLAGS="-g $CFLAGS"
> > LDFLAGS="-g $LDFLAGS"
> > @@ -6631,7 +6631,6 @@ elif test "$ARCH" = "ppc64" ; then
> > else
> > QEMU_INCLUDES="-iquote \$(SRC_PATH)/tcg/\$(ARCH) $QEMU_INCLUDES"
>
> Should you also be cleaning up this line?
True - I missed this part.
There will likely be more fallout from removing this part, so I will
note this in the commit log and work on patches on top.
> > fi
> > -QEMU_INCLUDES="-iquote \$(SRC_PATH)/tcg $QEMU_INCLUDES"
> > echo "TOOLS=$tools" >> $config_host_mak
> > echo "ROMS=$roms" >> $config_host_mak
> > diff --git a/Makefile.target b/Makefile.target
> > index d0ec77a..b6605ed 100644
> > --- a/Makefile.target
> > +++ b/Makefile.target
> > @@ -11,7 +11,7 @@ $(call set-vpath, $(SRC_PATH):$(BUILD_DIR))
> > ifdef CONFIG_LINUX
> > QEMU_CFLAGS += -I../linux-headers
> > endif
> > -QEMU_CFLAGS += -iquote .. -iquote $(SRC_PATH)/target/$(TARGET_BASE_ARCH) -DNEED_CPU_H
> > +QEMU_CFLAGS += -iquote .. -iquote $(SRC_PATH)/include/target/$(TARGET_BASE_ARCH) -DNEED_CPU_H
> > QEMU_CFLAGS+=-iquote $(SRC_PATH)/include
> >
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 144+ messages in thread
* Re: [Qemu-devel] [PATCH 00/67] include path cleanup
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (66 preceding siblings ...)
2018-05-03 19:51 ` [Qemu-devel] [PATCH 67/67] make: simplify source include path Michael S. Tsirkin
@ 2018-05-03 20:58 ` no-reply
2018-05-03 20:58 ` no-reply
` (3 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: no-reply @ 2018-05-03 20:58 UTC (permalink / raw)
To: mst; +Cc: famz, qemu-devel, kwolf, peter.maydell
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1525376963-79623-1-git-send-email-mst@redhat.com
Subject: [Qemu-devel] [PATCH 00/67] include path cleanup
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/1525376963-79623-1-git-send-email-mst@redhat.com -> patchew/1525376963-79623-1-git-send-email-mst@redhat.com
Switched to a new branch 'test'
dda9647d70 make: simplify source include path
b158a719f3 linux-user: add include directory header
b2ae9844c1 tcg: use include "translate-all.h" consistently
3613ec1453 target/s390x: add include directory header
d00910afb1 hw/s390x: use target headers explicitly
194f6f9974 kvm: use include "kvm_ppc.h" consistently
256581c1be hw/net: add include directory header
440e14b88a hw/s390x: add include directory headers
84a81cbde5 hw/ppc: add target headers explicitly
87bebef613 target/riscv: add include directory header
d02cccc221 kvm: use include "kvm_i386.h" consistently
f9543ea9d8 tcg: use include "tcg-gvec-desc.h.h" consistently
52a7685f6f amd_iommu: add include directory header
18b966a8fe amd_iommu: add include directory header
1f841bece5 target/ppc: add include directory headers
3d6945bd6b target/arm: add include directory headers
863bb03c5a hyperv: add include directory header
1011069886 hmp: add include directory header
5f1be83b0f kvm_XXX: add include directory headers
a4f45a0012 virtio-pci: add include directory header
8e2f2e471e tcg-op: use include "tcg.h" consistently
d9c41e578e cpu-qom: add include directory headers
ce17c41200 tcg: add include directory headers
1690189b5e tcg-ldst.inc.c: replace command line flags with preprocessor
5143bc145e translate-all: add include directory header
cd074d2b2c tcg: use include "tcg.h" consistently
3418bf3073 tcg-pool.inc.c: replace command line flags with preprocessor
653e93fefe trace: add include directory headers
76e207bfb1 target: replace command line flags with preprocessor
81d9592c44 helper: replace command line flags with preprocessor
287a3a85aa tcg: add include directory headers
0912dbb70e migration: add include directory headers
e234a2f0a3 hw/usb: add include directory header
0855ad7432 hw/ppc: add include directory headers
bff5bf26d6 hw/net: add include directory header
523897142f ui: add include directory header
a86a80bd28 target/cris: add include directory header
bc35b6c9a9 audio: add include directory header
c5c49795ca fsdev: add include directory headers
2184da2487 9pfs: add include directory headers
cebd0e6d5d replication: add include directory header
7fd6a43e9c cpu: replace command line flags with preprocessor
8d5900280a arch_init: sort architectures
5f3be2f16f net: add include directory headers
26e688947b slirp: add include directory headers
677b5a5222 ui: use local path for local headers
a2e9d7b6d0 trace: use local path for local headers
ab8e11dbb1 tests: relative include for child directory
2505961862 xtensa: relative include for parent directory
0561f465a9 qga: use local path for local headers
f02e149685 colo: use local path for local headers
f63ff1c1e5 migration: use local path for local headers
0e2942e37a usb: use local path for local headers
a17070acf1 sd: fix up include
804ef03fb9 vhost-scsi: drop an unused include
eded79b7c5 ppc: use local path for local headers
e352ed36c5 rocker: drop an unused include
303a3d4072 e1000e: use local path for local headers
4df0916e5c ioapic: fix up includes
4f533ce25a ide: use local path for local headers
3ad03c679d display: use local path for local headers
e56cb2ab7c trace: use local path for local headers
711e6fe8f8 migration: drop an unused include, add a used one
fdbc0e45c0 s390x: drop an unused include
abd9bbe5ea hppa: use local path for local headers
6ce2ed96c7 crypto: use local path for local headers
d5cd88766c block: use local path for local headers
=== OUTPUT BEGIN ===
Checking PATCH 1/67: block: use local path for local headers...
Checking PATCH 2/67: crypto: use local path for local headers...
Checking PATCH 3/67: hppa: use local path for local headers...
Checking PATCH 4/67: s390x: drop an unused include...
Checking PATCH 5/67: migration: drop an unused include, add a used one...
Checking PATCH 6/67: trace: use local path for local headers...
Checking PATCH 7/67: display: use local path for local headers...
Checking PATCH 8/67: ide: use local path for local headers...
Checking PATCH 9/67: ioapic: fix up includes...
Checking PATCH 10/67: e1000e: use local path for local headers...
Checking PATCH 11/67: rocker: drop an unused include...
Checking PATCH 12/67: ppc: use local path for local headers...
Checking PATCH 13/67: vhost-scsi: drop an unused include...
Checking PATCH 14/67: sd: fix up include...
Checking PATCH 15/67: usb: use local path for local headers...
Checking PATCH 16/67: migration: use local path for local headers...
Checking PATCH 17/67: colo: use local path for local headers...
Checking PATCH 18/67: qga: use local path for local headers...
Checking PATCH 19/67: xtensa: relative include for parent directory...
Checking PATCH 20/67: tests: relative include for child directory...
Checking PATCH 21/67: trace: use local path for local headers...
Checking PATCH 22/67: ui: use local path for local headers...
Checking PATCH 23/67: slirp: add include directory headers...
Checking PATCH 24/67: net: add include directory headers...
Checking PATCH 25/67: arch_init: sort architectures...
Checking PATCH 26/67: cpu: replace command line flags with preprocessor...
Checking PATCH 27/67: replication: add include directory header...
Checking PATCH 28/67: 9pfs: add include directory headers...
Checking PATCH 29/67: fsdev: add include directory headers...
Checking PATCH 30/67: audio: add include directory header...
Checking PATCH 31/67: target/cris: add include directory header...
Checking PATCH 32/67: ui: add include directory header...
Checking PATCH 33/67: hw/net: add include directory header...
Checking PATCH 34/67: hw/ppc: add include directory headers...
Checking PATCH 35/67: hw/usb: add include directory header...
Checking PATCH 36/67: migration: add include directory headers...
Checking PATCH 37/67: tcg: add include directory headers...
Checking PATCH 38/67: helper: replace command line flags with preprocessor...
Checking PATCH 39/67: target: replace command line flags with preprocessor...
ERROR: spaces required around that '/' (ctx:VxV)
#34: FILE: include/target-dir.h:14:
+#define TARGET_DIR_PREFIX ../target/alpha
^
ERROR: spaces required around that '/' (ctx:VxV)
#34: FILE: include/target-dir.h:14:
+#define TARGET_DIR_PREFIX ../target/alpha
^
ERROR: Macros with complex values should be enclosed in parenthesis
#34: FILE: include/target-dir.h:14:
+#define TARGET_DIR_PREFIX ../target/alpha
ERROR: spaces required around that '/' (ctx:VxV)
#36: FILE: include/target-dir.h:16:
+#define TARGET_DIR_PREFIX ../target/arm
^
ERROR: spaces required around that '/' (ctx:VxV)
#36: FILE: include/target-dir.h:16:
+#define TARGET_DIR_PREFIX ../target/arm
^
ERROR: Macros with complex values should be enclosed in parenthesis
#36: FILE: include/target-dir.h:16:
+#define TARGET_DIR_PREFIX ../target/arm
ERROR: spaces required around that '/' (ctx:VxV)
#38: FILE: include/target-dir.h:18:
+#define TARGET_DIR_PREFIX ../target/cris
^
ERROR: spaces required around that '/' (ctx:VxV)
#38: FILE: include/target-dir.h:18:
+#define TARGET_DIR_PREFIX ../target/cris
^
ERROR: Macros with complex values should be enclosed in parenthesis
#38: FILE: include/target-dir.h:18:
+#define TARGET_DIR_PREFIX ../target/cris
ERROR: spaces required around that '/' (ctx:VxV)
#40: FILE: include/target-dir.h:20:
+#define TARGET_DIR_PREFIX ../target/hppa
^
ERROR: spaces required around that '/' (ctx:VxV)
#40: FILE: include/target-dir.h:20:
+#define TARGET_DIR_PREFIX ../target/hppa
^
ERROR: Macros with complex values should be enclosed in parenthesis
#40: FILE: include/target-dir.h:20:
+#define TARGET_DIR_PREFIX ../target/hppa
ERROR: spaces required around that '/' (ctx:VxV)
#42: FILE: include/target-dir.h:22:
+#define TARGET_DIR_PREFIX ../target/i386
^
ERROR: spaces required around that '/' (ctx:VxV)
#42: FILE: include/target-dir.h:22:
+#define TARGET_DIR_PREFIX ../target/i386
^
ERROR: Macros with complex values should be enclosed in parenthesis
#42: FILE: include/target-dir.h:22:
+#define TARGET_DIR_PREFIX ../target/i386
ERROR: spaces required around that '/' (ctx:VxV)
#44: FILE: include/target-dir.h:24:
+#define TARGET_DIR_PREFIX ../target/lm32
^
ERROR: spaces required around that '/' (ctx:VxV)
#44: FILE: include/target-dir.h:24:
+#define TARGET_DIR_PREFIX ../target/lm32
^
ERROR: Macros with complex values should be enclosed in parenthesis
#44: FILE: include/target-dir.h:24:
+#define TARGET_DIR_PREFIX ../target/lm32
ERROR: spaces required around that '/' (ctx:VxV)
#46: FILE: include/target-dir.h:26:
+#define TARGET_DIR_PREFIX ../target/m68k
^
ERROR: spaces required around that '/' (ctx:VxV)
#46: FILE: include/target-dir.h:26:
+#define TARGET_DIR_PREFIX ../target/m68k
^
ERROR: Macros with complex values should be enclosed in parenthesis
#46: FILE: include/target-dir.h:26:
+#define TARGET_DIR_PREFIX ../target/m68k
ERROR: spaces required around that '/' (ctx:VxV)
#48: FILE: include/target-dir.h:28:
+#define TARGET_DIR_PREFIX ../target/microblaze
^
ERROR: spaces required around that '/' (ctx:VxV)
#48: FILE: include/target-dir.h:28:
+#define TARGET_DIR_PREFIX ../target/microblaze
^
ERROR: Macros with complex values should be enclosed in parenthesis
#48: FILE: include/target-dir.h:28:
+#define TARGET_DIR_PREFIX ../target/microblaze
ERROR: spaces required around that '/' (ctx:VxV)
#50: FILE: include/target-dir.h:30:
+#define TARGET_DIR_PREFIX ../target/mips
^
ERROR: spaces required around that '/' (ctx:VxV)
#50: FILE: include/target-dir.h:30:
+#define TARGET_DIR_PREFIX ../target/mips
^
ERROR: Macros with complex values should be enclosed in parenthesis
#50: FILE: include/target-dir.h:30:
+#define TARGET_DIR_PREFIX ../target/mips
ERROR: spaces required around that '/' (ctx:VxV)
#52: FILE: include/target-dir.h:32:
+#define TARGET_DIR_PREFIX ../target/moxie
^
ERROR: spaces required around that '/' (ctx:VxV)
#52: FILE: include/target-dir.h:32:
+#define TARGET_DIR_PREFIX ../target/moxie
^
ERROR: Macros with complex values should be enclosed in parenthesis
#52: FILE: include/target-dir.h:32:
+#define TARGET_DIR_PREFIX ../target/moxie
ERROR: spaces required around that '/' (ctx:VxV)
#54: FILE: include/target-dir.h:34:
+#define TARGET_DIR_PREFIX ../target/nios2
^
ERROR: spaces required around that '/' (ctx:VxV)
#54: FILE: include/target-dir.h:34:
+#define TARGET_DIR_PREFIX ../target/nios2
^
ERROR: Macros with complex values should be enclosed in parenthesis
#54: FILE: include/target-dir.h:34:
+#define TARGET_DIR_PREFIX ../target/nios2
ERROR: spaces required around that '/' (ctx:VxV)
#56: FILE: include/target-dir.h:36:
+#define TARGET_DIR_PREFIX ../target/openrisc
^
ERROR: spaces required around that '/' (ctx:VxV)
#56: FILE: include/target-dir.h:36:
+#define TARGET_DIR_PREFIX ../target/openrisc
^
ERROR: Macros with complex values should be enclosed in parenthesis
#56: FILE: include/target-dir.h:36:
+#define TARGET_DIR_PREFIX ../target/openrisc
ERROR: spaces required around that '/' (ctx:VxV)
#58: FILE: include/target-dir.h:38:
+#define TARGET_DIR_PREFIX ../target/ppc
^
ERROR: spaces required around that '/' (ctx:VxV)
#58: FILE: include/target-dir.h:38:
+#define TARGET_DIR_PREFIX ../target/ppc
^
ERROR: Macros with complex values should be enclosed in parenthesis
#58: FILE: include/target-dir.h:38:
+#define TARGET_DIR_PREFIX ../target/ppc
ERROR: spaces required around that '/' (ctx:VxV)
#60: FILE: include/target-dir.h:40:
+#define TARGET_DIR_PREFIX ../target/riscv
^
ERROR: spaces required around that '/' (ctx:VxV)
#60: FILE: include/target-dir.h:40:
+#define TARGET_DIR_PREFIX ../target/riscv
^
ERROR: Macros with complex values should be enclosed in parenthesis
#60: FILE: include/target-dir.h:40:
+#define TARGET_DIR_PREFIX ../target/riscv
ERROR: spaces required around that '/' (ctx:VxV)
#62: FILE: include/target-dir.h:42:
+#define TARGET_DIR_PREFIX ../target/s390x
^
ERROR: spaces required around that '/' (ctx:VxV)
#62: FILE: include/target-dir.h:42:
+#define TARGET_DIR_PREFIX ../target/s390x
^
ERROR: Macros with complex values should be enclosed in parenthesis
#62: FILE: include/target-dir.h:42:
+#define TARGET_DIR_PREFIX ../target/s390x
ERROR: spaces required around that '/' (ctx:VxV)
#64: FILE: include/target-dir.h:44:
+#define TARGET_DIR_PREFIX ../target/sh4
^
ERROR: spaces required around that '/' (ctx:VxV)
#64: FILE: include/target-dir.h:44:
+#define TARGET_DIR_PREFIX ../target/sh4
^
ERROR: Macros with complex values should be enclosed in parenthesis
#64: FILE: include/target-dir.h:44:
+#define TARGET_DIR_PREFIX ../target/sh4
ERROR: spaces required around that '/' (ctx:VxV)
#66: FILE: include/target-dir.h:46:
+#define TARGET_DIR_PREFIX ../target/sparc
^
ERROR: spaces required around that '/' (ctx:VxV)
#66: FILE: include/target-dir.h:46:
+#define TARGET_DIR_PREFIX ../target/sparc
^
ERROR: Macros with complex values should be enclosed in parenthesis
#66: FILE: include/target-dir.h:46:
+#define TARGET_DIR_PREFIX ../target/sparc
ERROR: spaces required around that '/' (ctx:VxV)
#68: FILE: include/target-dir.h:48:
+#define TARGET_DIR_PREFIX ../target/unicore32
^
ERROR: spaces required around that '/' (ctx:VxV)
#68: FILE: include/target-dir.h:48:
+#define TARGET_DIR_PREFIX ../target/unicore32
^
ERROR: Macros with complex values should be enclosed in parenthesis
#68: FILE: include/target-dir.h:48:
+#define TARGET_DIR_PREFIX ../target/unicore32
ERROR: spaces required around that '/' (ctx:VxV)
#70: FILE: include/target-dir.h:50:
+#define TARGET_DIR_PREFIX ../target/tilegx
^
ERROR: spaces required around that '/' (ctx:VxV)
#70: FILE: include/target-dir.h:50:
+#define TARGET_DIR_PREFIX ../target/tilegx
^
ERROR: Macros with complex values should be enclosed in parenthesis
#70: FILE: include/target-dir.h:50:
+#define TARGET_DIR_PREFIX ../target/tilegx
ERROR: spaces required around that '/' (ctx:VxV)
#72: FILE: include/target-dir.h:52:
+#define TARGET_DIR_PREFIX ../target/tricore
^
ERROR: spaces required around that '/' (ctx:VxV)
#72: FILE: include/target-dir.h:52:
+#define TARGET_DIR_PREFIX ../target/tricore
^
ERROR: Macros with complex values should be enclosed in parenthesis
#72: FILE: include/target-dir.h:52:
+#define TARGET_DIR_PREFIX ../target/tricore
ERROR: spaces required around that '/' (ctx:VxV)
#74: FILE: include/target-dir.h:54:
+#define TARGET_DIR_PREFIX ../target/xtensa
^
ERROR: spaces required around that '/' (ctx:VxV)
#74: FILE: include/target-dir.h:54:
+#define TARGET_DIR_PREFIX ../target/xtensa
^
ERROR: Macros with complex values should be enclosed in parenthesis
#74: FILE: include/target-dir.h:54:
+#define TARGET_DIR_PREFIX ../target/xtensa
ERROR: spaces required around that '/' (ctx:VxV)
#81: FILE: include/target-dir.h:61:
+#define TARGET_DIR(file) TARGET_DIR_STRING(TARGET_DIR_PREFIX/file)
^
total: 64 errors, 0 warnings, 63 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 40/67: trace: add include directory headers...
Checking PATCH 41/67: tcg-pool.inc.c: replace command line flags with preprocessor...
Checking PATCH 42/67: tcg: use include "tcg.h" consistently...
Checking PATCH 43/67: translate-all: add include directory header...
Checking PATCH 44/67: tcg-ldst.inc.c: replace command line flags with preprocessor...
Checking PATCH 45/67: tcg: add include directory headers...
Checking PATCH 46/67: cpu-qom: add include directory headers...
Checking PATCH 47/67: tcg-op: use include "tcg.h" consistently...
Checking PATCH 48/67: virtio-pci: add include directory header...
Checking PATCH 49/67: kvm_XXX: add include directory headers...
Checking PATCH 50/67: hmp: add include directory header...
Checking PATCH 51/67: hyperv: add include directory header...
Checking PATCH 52/67: target/arm: add include directory headers...
Checking PATCH 53/67: target/ppc: add include directory headers...
Checking PATCH 54/67: amd_iommu: add include directory header...
Checking PATCH 55/67: amd_iommu: add include directory header...
Checking PATCH 56/67: tcg: use include "tcg-gvec-desc.h.h" consistently...
Checking PATCH 57/67: kvm: use include "kvm_i386.h" consistently...
Checking PATCH 58/67: target/riscv: add include directory header...
Checking PATCH 59/67: hw/ppc: add target headers explicitly...
Checking PATCH 60/67: hw/s390x: add include directory headers...
Checking PATCH 61/67: hw/net: add include directory header...
Checking PATCH 62/67: kvm: use include "kvm_ppc.h" consistently...
Checking PATCH 63/67: hw/s390x: use target headers explicitly...
Checking PATCH 64/67: target/s390x: add include directory header...
Checking PATCH 65/67: tcg: use include "translate-all.h" consistently...
Checking PATCH 66/67: linux-user: add include directory header...
Checking PATCH 67/67: make: simplify source include path...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 00/67] include path cleanup
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (67 preceding siblings ...)
2018-05-03 20:58 ` [Qemu-devel] [PATCH 00/67] include path cleanup no-reply
@ 2018-05-03 20:58 ` no-reply
2018-05-03 21:00 ` no-reply
` (2 subsequent siblings)
71 siblings, 0 replies; 144+ messages in thread
From: no-reply @ 2018-05-03 20:58 UTC (permalink / raw)
To: mst; +Cc: famz, qemu-devel, kwolf, peter.maydell
Hi,
This series failed build test on s390x host. Please find the details below.
Type: series
Message-id: 1525376963-79623-1-git-send-email-mst@redhat.com
Subject: [Qemu-devel] [PATCH 00/67] include path cleanup
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e
echo "=== ENV ==="
env
echo "=== PACKAGES ==="
rpm -qa
echo "=== TEST BEGIN ==="
CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
echo -n "Using CC: "
realpath $CC
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/1525376963-79623-1-git-send-email-mst@redhat.com -> patchew/1525376963-79623-1-git-send-email-mst@redhat.com
Switched to a new branch 'test'
dda9647d70 make: simplify source include path
b158a719f3 linux-user: add include directory header
b2ae9844c1 tcg: use include "translate-all.h" consistently
3613ec1453 target/s390x: add include directory header
d00910afb1 hw/s390x: use target headers explicitly
194f6f9974 kvm: use include "kvm_ppc.h" consistently
256581c1be hw/net: add include directory header
440e14b88a hw/s390x: add include directory headers
84a81cbde5 hw/ppc: add target headers explicitly
87bebef613 target/riscv: add include directory header
d02cccc221 kvm: use include "kvm_i386.h" consistently
f9543ea9d8 tcg: use include "tcg-gvec-desc.h.h" consistently
52a7685f6f amd_iommu: add include directory header
18b966a8fe amd_iommu: add include directory header
1f841bece5 target/ppc: add include directory headers
3d6945bd6b target/arm: add include directory headers
863bb03c5a hyperv: add include directory header
1011069886 hmp: add include directory header
5f1be83b0f kvm_XXX: add include directory headers
a4f45a0012 virtio-pci: add include directory header
8e2f2e471e tcg-op: use include "tcg.h" consistently
d9c41e578e cpu-qom: add include directory headers
ce17c41200 tcg: add include directory headers
1690189b5e tcg-ldst.inc.c: replace command line flags with preprocessor
5143bc145e translate-all: add include directory header
cd074d2b2c tcg: use include "tcg.h" consistently
3418bf3073 tcg-pool.inc.c: replace command line flags with preprocessor
653e93fefe trace: add include directory headers
76e207bfb1 target: replace command line flags with preprocessor
81d9592c44 helper: replace command line flags with preprocessor
287a3a85aa tcg: add include directory headers
0912dbb70e migration: add include directory headers
e234a2f0a3 hw/usb: add include directory header
0855ad7432 hw/ppc: add include directory headers
bff5bf26d6 hw/net: add include directory header
523897142f ui: add include directory header
a86a80bd28 target/cris: add include directory header
bc35b6c9a9 audio: add include directory header
c5c49795ca fsdev: add include directory headers
2184da2487 9pfs: add include directory headers
cebd0e6d5d replication: add include directory header
7fd6a43e9c cpu: replace command line flags with preprocessor
8d5900280a arch_init: sort architectures
5f3be2f16f net: add include directory headers
26e688947b slirp: add include directory headers
677b5a5222 ui: use local path for local headers
a2e9d7b6d0 trace: use local path for local headers
ab8e11dbb1 tests: relative include for child directory
2505961862 xtensa: relative include for parent directory
0561f465a9 qga: use local path for local headers
f02e149685 colo: use local path for local headers
f63ff1c1e5 migration: use local path for local headers
0e2942e37a usb: use local path for local headers
a17070acf1 sd: fix up include
804ef03fb9 vhost-scsi: drop an unused include
eded79b7c5 ppc: use local path for local headers
e352ed36c5 rocker: drop an unused include
303a3d4072 e1000e: use local path for local headers
4df0916e5c ioapic: fix up includes
4f533ce25a ide: use local path for local headers
3ad03c679d display: use local path for local headers
e56cb2ab7c trace: use local path for local headers
711e6fe8f8 migration: drop an unused include, add a used one
fdbc0e45c0 s390x: drop an unused include
abd9bbe5ea hppa: use local path for local headers
6ce2ed96c7 crypto: use local path for local headers
d5cd88766c block: use local path for local headers
=== OUTPUT BEGIN ===
=== ENV ===
LANG=en_US.UTF-8
XDG_SESSION_ID=169414
USER=fam
PWD=/var/tmp/patchew-tester-tmp-zmws4k92/src
HOME=/home/fam
SHELL=/bin/sh
SHLVL=2
PATCHEW=/home/fam/patchew/patchew-cli -s http://patchew.org --nodebug
LOGNAME=fam
DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1012/bus
XDG_RUNTIME_DIR=/run/user/1012
PATH=/usr/bin:/bin
_=/usr/bin/env
=== PACKAGES ===
gpg-pubkey-873529b8-54e386ff
glibc-debuginfo-common-2.24-10.fc25.s390x
fedora-release-26-1.noarch
dejavu-sans-mono-fonts-2.35-4.fc26.noarch
xemacs-filesystem-21.5.34-22.20170124hgf412e9f093d4.fc26.noarch
bash-4.4.12-7.fc26.s390x
libSM-1.2.2-5.fc26.s390x
libmpc-1.0.2-6.fc26.s390x
libaio-0.3.110-7.fc26.s390x
libverto-0.2.6-7.fc26.s390x
perl-Scalar-List-Utils-1.48-1.fc26.s390x
iptables-libs-1.6.1-2.fc26.s390x
tcl-8.6.6-2.fc26.s390x
libxshmfence-1.2-4.fc26.s390x
expect-5.45-23.fc26.s390x
perl-Thread-Queue-3.12-1.fc26.noarch
perl-encoding-2.19-6.fc26.s390x
keyutils-1.5.10-1.fc26.s390x
gmp-devel-6.1.2-4.fc26.s390x
enchant-1.6.0-16.fc26.s390x
python-gobject-base-3.24.1-1.fc26.s390x
python3-enchant-1.6.10-1.fc26.noarch
python-lockfile-0.11.0-6.fc26.noarch
python2-pyparsing-2.1.10-3.fc26.noarch
python2-lxml-4.1.1-1.fc26.s390x
librados2-10.2.7-2.fc26.s390x
trousers-lib-0.3.13-7.fc26.s390x
libdatrie-0.2.9-4.fc26.s390x
libsoup-2.58.2-1.fc26.s390x
passwd-0.79-9.fc26.s390x
bind99-libs-9.9.10-3.P3.fc26.s390x
python3-rpm-4.13.0.2-1.fc26.s390x
systemd-233-7.fc26.s390x
virglrenderer-0.6.0-1.20170210git76b3da97b.fc26.s390x
s390utils-ziomon-1.36.1-3.fc26.s390x
s390utils-osasnmpd-1.36.1-3.fc26.s390x
libXrandr-1.5.1-2.fc26.s390x
libglvnd-glx-1.0.0-1.fc26.s390x
texlive-ifxetex-svn19685.0.5-33.fc26.2.noarch
texlive-psnfss-svn33946.9.2a-33.fc26.2.noarch
texlive-dvipdfmx-def-svn40328-33.fc26.2.noarch
texlive-natbib-svn20668.8.31b-33.fc26.2.noarch
texlive-xdvi-bin-svn40750-33.20160520.fc26.2.s390x
texlive-cm-svn32865.0-33.fc26.2.noarch
texlive-beton-svn15878.0-33.fc26.2.noarch
texlive-fpl-svn15878.1.002-33.fc26.2.noarch
texlive-mflogo-svn38628-33.fc26.2.noarch
texlive-texlive-docindex-svn41430-33.fc26.2.noarch
texlive-luaotfload-bin-svn34647.0-33.20160520.fc26.2.noarch
texlive-koma-script-svn41508-33.fc26.2.noarch
texlive-pst-tree-svn24142.1.12-33.fc26.2.noarch
texlive-breqn-svn38099.0.98d-33.fc26.2.noarch
texlive-xetex-svn41438-33.fc26.2.noarch
gstreamer1-plugins-bad-free-1.12.3-1.fc26.s390x
xorg-x11-font-utils-7.5-33.fc26.s390x
ghostscript-fonts-5.50-36.fc26.noarch
libXext-devel-1.3.3-5.fc26.s390x
libusbx-devel-1.0.21-2.fc26.s390x
libglvnd-devel-1.0.0-1.fc26.s390x
emacs-25.3-3.fc26.s390x
alsa-lib-devel-1.1.4.1-1.fc26.s390x
kbd-2.0.4-2.fc26.s390x
dconf-0.26.0-2.fc26.s390x
mc-4.8.19-5.fc26.s390x
doxygen-1.8.13-9.fc26.s390x
dpkg-1.18.24-1.fc26.s390x
libtdb-1.3.13-1.fc26.s390x
python2-pynacl-1.1.1-1.fc26.s390x
perl-Filter-1.58-1.fc26.s390x
python2-pip-9.0.1-11.fc26.noarch
dnf-2.7.5-2.fc26.noarch
bind-license-9.11.2-1.P1.fc26.noarch
libtasn1-4.13-1.fc26.s390x
cpp-7.3.1-2.fc26.s390x
pkgconf-1.3.12-2.fc26.s390x
python2-fedora-0.10.0-1.fc26.noarch
cmake-filesystem-3.10.1-11.fc26.s390x
python3-requests-kerberos-0.12.0-1.fc26.noarch
libmicrohttpd-0.9.59-1.fc26.s390x
GeoIP-GeoLite-data-2018.01-1.fc26.noarch
python2-libs-2.7.14-7.fc26.s390x
libidn2-2.0.4-3.fc26.s390x
p11-kit-devel-0.23.10-1.fc26.s390x
perl-Errno-1.25-396.fc26.s390x
libdrm-2.4.90-2.fc26.s390x
sssd-common-1.16.1-1.fc26.s390x
boost-random-1.63.0-11.fc26.s390x
urw-fonts-2.4-24.fc26.noarch
ccache-3.3.6-1.fc26.s390x
glibc-debuginfo-2.24-10.fc25.s390x
dejavu-fonts-common-2.35-4.fc26.noarch
bind99-license-9.9.10-3.P3.fc26.noarch
ncurses-libs-6.0-8.20170212.fc26.s390x
libpng-1.6.28-2.fc26.s390x
libICE-1.0.9-9.fc26.s390x
perl-Text-ParseWords-3.30-366.fc26.noarch
libtool-ltdl-2.4.6-17.fc26.s390x
libselinux-utils-2.6-7.fc26.s390x
userspace-rcu-0.9.3-2.fc26.s390x
perl-Class-Inspector-1.31-3.fc26.noarch
keyutils-libs-devel-1.5.10-1.fc26.s390x
isl-0.16.1-1.fc26.s390x
libsecret-0.18.5-3.fc26.s390x
compat-openssl10-1.0.2m-1.fc26.s390x
python3-iniparse-0.4-24.fc26.noarch
python3-dateutil-2.6.0-3.fc26.noarch
python3-firewall-0.4.4.5-1.fc26.noarch
python-enum34-1.1.6-1.fc26.noarch
python2-pygments-2.2.0-7.fc26.noarch
python2-dockerfile-parse-0.0.7-1.fc26.noarch
perl-Net-SSLeay-1.81-1.fc26.s390x
hostname-3.18-2.fc26.s390x
libtirpc-1.0.2-0.fc26.s390x
rpm-build-libs-4.13.0.2-1.fc26.s390x
libutempter-1.1.6-9.fc26.s390x
systemd-pam-233-7.fc26.s390x
libXinerama-1.1.3-7.fc26.s390x
mesa-libGL-17.2.4-2.fc26.s390x
texlive-amsfonts-svn29208.3.04-33.fc26.2.noarch
texlive-caption-svn41409-33.fc26.2.noarch
texlive-enumitem-svn24146.3.5.2-33.fc26.2.noarch
texlive-pdftex-def-svn22653.0.06d-33.fc26.2.noarch
texlive-xdvi-svn40768-33.fc26.2.noarch
texlive-courier-svn35058.0-33.fc26.2.noarch
texlive-charter-svn15878.0-33.fc26.2.noarch
texlive-graphics-def-svn41879-33.fc26.2.noarch
texlive-mfnfss-svn19410.0-33.fc26.2.noarch
texlive-texlive-en-svn41185-33.fc26.2.noarch
texlive-ifplatform-svn21156.0.4-33.fc26.2.noarch
texlive-ms-svn29849.0-33.fc26.2.noarch
texlive-pst-tools-svn34067.0.05-33.fc26.2.noarch
texlive-powerdot-svn38984-33.fc26.2.noarch
texlive-xetexconfig-svn41133-33.fc26.2.noarch
libvdpau-1.1.1-4.fc26.s390x
zlib-devel-1.2.11-2.fc26.s390x
gdk-pixbuf2-devel-2.36.9-1.fc26.s390x
libX11-devel-1.6.5-2.fc26.s390x
libglvnd-core-devel-1.0.0-1.fc26.s390x
SDL2-devel-2.0.7-2.fc26.s390x
webkitgtk3-2.4.11-5.fc26.s390x
grubby-8.40-4.fc26.s390x
uboot-tools-2017.05-4.fc26.s390x
cracklib-dicts-2.9.6-5.fc26.s390x
texinfo-6.3-3.fc26.s390x
time-1.7-52.fc26.s390x
python2-deltarpm-3.6-19.fc26.s390x
python2-setuptools-37.0.0-1.fc26.noarch
python2-dnf-2.7.5-2.fc26.noarch
groff-base-1.22.3-10.fc26.s390x
python2-GitPython-2.1.7-2.fc26.noarch
cups-libs-2.2.2-8.fc26.s390x
bind-libs-lite-9.11.2-1.P1.fc26.s390x
libpkgconf-1.3.12-2.fc26.s390x
java-1.8.0-openjdk-headless-1.8.0.161-5.b14.fc26.s390x
python3-dnf-plugin-system-upgrade-2.0.5-1.fc26.noarch
dtc-1.4.6-1.fc26.s390x
glusterfs-client-xlators-3.10.11-1.fc26.s390x
libunistring-0.9.9-1.fc26.s390x
python3-libs-3.6.4-3.fc26.s390x
perl-IO-1.36-396.fc26.s390x
libXcursor-1.1.15-1.fc26.s390x
libdrm-devel-2.4.90-2.fc26.s390x
boost-thread-1.63.0-11.fc26.s390x
strace-4.21-1.fc26.s390x
boost-iostreams-1.63.0-11.fc26.s390x
gpg-pubkey-efe550f5-5220ba41
gpg-pubkey-81b46521-55b3ca9a
filesystem-3.2-40.fc26.s390x
basesystem-11-3.fc26.noarch
js-jquery-3.2.1-1.fc26.noarch
libidn-1.33-2.fc26.s390x
libogg-1.3.2-6.fc26.s390x
slang-2.3.1a-2.fc26.s390x
apr-1.6.3-1.fc26.s390x
libxkbcommon-0.7.1-3.fc26.s390x
less-487-3.fc26.s390x
lttng-ust-2.9.0-2.fc26.s390x
OpenEXR-libs-2.2.0-6.fc26.s390x
ipset-libs-6.29-3.fc26.s390x
perl-XML-XPath-1.42-1.fc26.noarch
lua-filesystem-1.6.3-3.fc24.s390x
gstreamer1-1.12.3-1.fc26.s390x
libpwquality-1.3.0-8.fc26.s390x
gettext-libs-0.19.8.1-9.fc26.s390x
python3-chardet-2.3.0-3.fc26.noarch
python3-slip-dbus-0.6.4-6.fc26.noarch
python-chardet-2.3.0-3.fc26.noarch
python2-pyasn1-0.2.3-1.fc26.noarch
python-slip-dbus-0.6.4-6.fc26.noarch
libarchive-3.2.2-4.fc26.s390x
libbabeltrace-1.5.2-2.fc26.s390x
cdparanoia-libs-10.2-22.fc26.s390x
gpgme-1.8.0-12.fc26.s390x
python2-gpg-1.8.0-12.fc26.s390x
shadow-utils-4.3.1-3.fc26.s390x
cryptsetup-libs-1.7.5-1.fc26.s390x
kpartx-0.4.9-88.fc26.s390x
libXi-1.7.9-2.fc26.s390x
texlive-tetex-svn41059-33.fc26.2.noarch
texlive-tools-svn40934-33.fc26.2.noarch
texlive-bibtex-bin-svn40473-33.20160520.fc26.2.s390x
texlive-mfware-bin-svn40473-33.20160520.fc26.2.s390x
texlive-underscore-svn18261.0-33.fc26.2.noarch
texlive-avantgar-svn31835.0-33.fc26.2.noarch
texlive-anysize-svn15878.0-33.fc26.2.noarch
texlive-lineno-svn21442.4.41-33.fc26.2.noarch
texlive-mathpazo-svn15878.1.003-33.fc26.2.noarch
texlive-soul-svn15878.2.4-33.fc26.2.noarch
texlive-luatexbase-svn38550-33.fc26.2.noarch
texlive-listings-svn37534.1.6-33.fc26.2.noarch
texlive-pstricks-svn41321-33.fc26.2.noarch
texlive-metalogo-svn18611.0.12-33.fc26.2.noarch
texlive-dvipdfmx-svn41149-33.fc26.2.noarch
kbd-legacy-2.0.4-2.fc26.noarch
ghostscript-x11-9.20-10.fc26.s390x
libXrender-devel-0.9.10-2.fc26.s390x
libxkbcommon-devel-0.7.1-3.fc26.s390x
mesa-libGL-devel-17.2.4-2.fc26.s390x
usbredir-devel-0.7.1-3.fc26.s390x
libcap-devel-2.25-5.fc26.s390x
brlapi-devel-0.6.6-5.fc26.s390x
python3-pygpgme-0.3-22.fc26.s390x
pinentry-0.9.7-3.fc26.s390x
qemu-sanity-check-nodeps-1.1.5-6.fc26.s390x
libldb-1.1.29-5.fc26.s390x
libwayland-cursor-1.13.0-3.fc26.s390x
pulseaudio-libs-devel-11.1-7.fc26.s390x
json-c-0.12.1-5.fc26.s390x
libgcrypt-1.8.2-1.fc26.s390x
libgo-devel-7.3.1-2.fc26.s390x
ca-certificates-2018.2.22-1.0.fc26.noarch
python2-sphinx-1.5.6-1.fc26.noarch
dnsmasq-2.76-6.fc26.s390x
perl-Module-CoreList-5.20180120-1.fc26.noarch
pcre-8.41-6.fc26.s390x
net-snmp-libs-5.7.3-27.fc26.s390x
gnutls-dane-3.5.18-2.fc26.s390x
glusterfs-devel-3.10.11-1.fc26.s390x
libsss_nss_idmap-1.16.1-1.fc26.s390x
elfutils-0.170-4.fc26.s390x
nss-devel-3.36.0-1.0.fc26.s390x
perl-open-1.10-396.fc26.noarch
ethtool-4.15-1.fc26.s390x
gpg-pubkey-34ec9cba-54e38751
gpg-pubkey-030d5aed-55b577f0
setup-2.10.5-2.fc26.noarch
lato-fonts-2.015-3.fc26.noarch
web-assets-filesystem-5-5.fc26.noarch
libsepol-2.6-2.fc26.s390x
libcap-2.25-5.fc26.s390x
tcp_wrappers-libs-7.6-85.fc26.s390x
libnl3-3.3.0-1.fc26.s390x
pixman-0.34.0-3.fc26.s390x
lzo-2.08-9.fc26.s390x
libnl3-cli-3.3.0-1.fc26.s390x
gpm-libs-1.20.7-10.fc26.s390x
iso-codes-3.74-2.fc26.noarch
ipset-6.29-3.fc26.s390x
lua-term-0.07-1.fc25.s390x
libdb-utils-5.3.28-24.fc26.s390x
dbus-glib-0.108-2.fc26.s390x
pam-1.3.0-2.fc26.s390x
avahi-glib-0.6.32-7.fc26.s390x
python2-dateutil-2.6.0-3.fc26.noarch
python3-asn1crypto-0.23.0-1.fc26.noarch
python3-slip-0.6.4-6.fc26.noarch
python-backports-ssl_match_hostname-3.5.0.1-4.fc26.noarch
python2-pyOpenSSL-16.2.0-6.fc26.noarch
python-slip-0.6.4-6.fc26.noarch
nss-pem-1.0.3-3.fc26.s390x
fipscheck-1.5.0-1.fc26.s390x
cyrus-sasl-lib-2.1.26-32.fc26.s390x
python3-kerberos-1.2.5-3.fc26.s390x
rpmconf-1.0.19-1.fc26.noarch
libsemanage-2.6-4.fc26.s390x
device-mapper-libs-1.02.137-6.fc26.s390x
yum-3.4.3-512.fc26.noarch
device-mapper-multipath-0.4.9-88.fc26.s390x
libXtst-1.2.3-2.fc26.s390x
libXxf86vm-1.1.4-4.fc26.s390x
texlive-amsmath-svn41561-33.fc26.2.noarch
texlive-xkeyval-svn35741.2.7a-33.fc26.2.noarch
texlive-bibtex-svn40768-33.fc26.2.noarch
texlive-mfware-svn40768-33.fc26.2.noarch
texlive-wasy-svn35831.0-33.fc26.2.noarch
texlive-bookman-svn31835.0-33.fc26.2.noarch
texlive-babel-english-svn30264.3.3p-33.fc26.2.noarch
texlive-fix2col-svn38770-33.fc26.2.noarch
texlive-mdwtools-svn15878.1.05.4-33.fc26.2.noarch
texlive-tex-gyre-math-svn41264-33.fc26.2.noarch
texlive-luaotfload-svn40902-33.fc26.2.noarch
texlive-showexpl-svn32737.v0.3l-33.fc26.2.noarch
texlive-pstricks-add-svn40744-33.fc26.2.noarch
texlive-l3experimental-svn41163-33.fc26.2.noarch
texlive-xetex-bin-svn41091-33.20160520.fc26.2.s390x
kbd-misc-2.0.4-2.fc26.noarch
libpng-devel-1.6.28-2.fc26.s390x
ghostscript-core-9.20-10.fc26.s390x
libXfixes-devel-5.0.3-2.fc26.s390x
libverto-devel-0.2.6-7.fc26.s390x
mesa-libEGL-devel-17.2.4-2.fc26.s390x
popt-devel-1.16-12.fc26.s390x
readline-devel-7.0-5.fc26.s390x
cyrus-sasl-devel-2.1.26-32.fc26.s390x
sendmail-8.15.2-19.fc26.s390x
systemd-bootchart-231-3.fc26.s390x
perl-IO-Socket-SSL-2.049-1.fc26.noarch
python2-enchant-1.6.10-1.fc26.noarch
perl-generators-1.10-2.fc26.noarch
createrepo-0.10.3-11.fc26.noarch
pulseaudio-libs-glib2-11.1-7.fc26.s390x
dhcp-libs-4.3.5-10.fc26.s390x
libtiff-4.0.9-1.fc26.s390x
python-srpm-macros-3-21.fc26.noarch
libtalloc-2.1.11-1.fc26.s390x
nfs-utils-2.2.1-4.rc2.fc26.s390x
qt5-srpm-macros-5.9.4-2.fc26.noarch
python2-dnf-plugins-core-2.1.5-4.fc26.noarch
mariadb-libs-10.1.30-2.fc26.s390x
bind-libs-9.11.2-1.P1.fc26.s390x
acpica-tools-20180105-1.fc26.s390x
perl-podlators-4.09-3.fc26.noarch
glusterfs-3.10.11-1.fc26.s390x
nss-sysinit-3.36.0-1.0.fc26.s390x
gnutls-c++-3.5.18-2.fc26.s390x
perl-macros-5.24.3-396.fc26.s390x
sssd-client-1.16.1-1.fc26.s390x
elfutils-devel-0.170-4.fc26.s390x
kernel-4.15.12-201.fc26.s390x
vim-minimal-8.0.1553-1.fc26.s390x
desktop-file-utils-0.23-6.fc26.s390x
fontpackages-filesystem-1.44-18.fc26.noarch
vte-profile-0.48.4-1.fc26.s390x
texlive-kpathsea-doc-svn41139-33.fc26.2.noarch
zlib-1.2.11-2.fc26.s390x
readline-7.0-5.fc26.s390x
libattr-2.4.47-18.fc26.s390x
libglvnd-1.0.0-1.fc26.s390x
lz4-libs-1.8.0-1.fc26.s390x
perl-File-Path-2.12-367.fc26.noarch
perl-Unicode-EastAsianWidth-1.33-9.fc26.noarch
hunspell-1.5.4-2.fc26.s390x
libasyncns-0.8-11.fc26.s390x
libnetfilter_conntrack-1.0.6-2.fc26.s390x
perl-Storable-2.56-368.fc26.s390x
autoconf-2.69-24.fc26.noarch
device-mapper-persistent-data-0.6.3-5.fc26.s390x
quota-4.03-9.fc26.s390x
crypto-policies-20170606-1.git7c32281.fc26.noarch
glib2-2.52.3-2.fc26.s390x
python2-idna-2.5-1.fc26.noarch
python2-libcomps-0.1.8-3.fc26.s390x
gsettings-desktop-schemas-3.24.1-1.fc26.s390x
javapackages-tools-4.7.0-17.fc26.noarch
libselinux-python3-2.6-7.fc26.s390x
python-backports-1.0-9.fc26.s390x
python2-cryptography-2.0.2-2.fc26.s390x
libselinux-python-2.6-7.fc26.s390x
Lmod-7.5.3-1.fc26.s390x
fipscheck-lib-1.5.0-1.fc26.s390x
libuser-0.62-6.fc26.s390x
npth-1.5-1.fc26.s390x
packagedb-cli-2.14.1-2.fc26.noarch
ustr-1.0.4-22.fc26.s390x
device-mapper-1.02.137-6.fc26.s390x
polkit-pkla-compat-0.1-8.fc26.s390x
fakeroot-1.22-1.fc26.s390x
libXmu-1.1.2-5.fc26.s390x
cairo-gobject-1.14.10-1.fc26.s390x
texlive-booktabs-svn40846-33.fc26.2.noarch
texlive-dvips-bin-svn40987-33.20160520.fc26.2.s390x
texlive-float-svn15878.1.3d-33.fc26.2.noarch
texlive-tex-svn40793-33.fc26.2.noarch
texlive-fancyref-svn15878.0.9c-33.fc26.2.noarch
texlive-manfnt-font-svn35799.0-33.fc26.2.noarch
texlive-cmap-svn41168-33.fc26.2.noarch
texlive-hyph-utf8-svn41189-33.fc26.2.noarch
texlive-paralist-svn39247-33.fc26.2.noarch
texlive-trimspaces-svn15878.1.1-33.fc26.2.noarch
texlive-tipa-svn29349.1.3-33.fc26.2.noarch
texlive-l3packages-svn41246-33.fc26.2.noarch
texlive-pst-pdf-svn31660.1.1v-33.fc26.2.noarch
texlive-tex-gyre-svn18651.2.004-33.fc26.2.noarch
texlive-beamer-svn36461.3.36-33.fc26.2.noarch
gd-2.2.5-1.fc26.s390x
gc-devel-7.6.0-2.fc26.s390x
libXft-devel-2.3.2-5.fc26.s390x
rpm-devel-4.13.0.2-1.fc26.s390x
bluez-libs-devel-5.46-6.fc26.s390x
trousers-0.3.13-7.fc26.s390x
iproute-tc-4.11.0-1.fc26.s390x
libgnome-keyring-3.12.0-8.fc26.s390x
perl-File-ShareDir-1.102-8.fc26.noarch
python2-paramiko-2.2.1-1.fc26.noarch
python2-openidc-client-0.4.0-1.20171113git54dee6e.fc26.noarch
openssh-server-7.5p1-4.fc26.s390x
pulseaudio-libs-11.1-7.fc26.s390x
python2-bodhi-2.12.2-3.fc26.noarch
lua-libs-5.3.4-7.fc26.s390x
dhcp-common-4.3.5-10.fc26.noarch
python3-pip-9.0.1-11.fc26.noarch
python2-py-1.4.34-1.fc26.noarch
glibc-common-2.25-13.fc26.s390x
webkitgtk4-jsc-2.18.6-1.fc26.s390x
glibc-devel-2.25-13.fc26.s390x
pcre2-10.23-13.fc26.s390x
linux-firmware-20171215-82.git2451bb22.fc26.noarch
libfdt-devel-1.4.6-1.fc26.s390x
audit-2.8.2-1.fc26.s390x
perl-Socket-2.027-1.fc26.s390x
nosync-1.0-6.fc26.s390x
redhat-rpm-config-65-1.fc26.noarch
freetype-2.7.1-10.fc26.s390x
gnutls-3.5.18-2.fc26.s390x
sqlite-3.20.1-2.fc26.s390x
pcre-devel-8.41-6.fc26.s390x
fedpkg-1.32-1.fc26.noarch
gnutls-devel-3.5.18-2.fc26.s390x
python2-pytz-2017.2-7.fc26.noarch
gsm-1.0.17-2.fc26.s390x
gpg-pubkey-95a43f54-5284415a
gpg-pubkey-fdb19c98-56fd6333
gpg-pubkey-64dab85d-57d33e22
firewalld-filesystem-0.4.4.5-1.fc26.noarch
xkeyboard-config-2.21-3.fc26.noarch
texlive-texlive-common-doc-svn40682-33.fc26.2.noarch
ncurses-base-6.0-8.20170212.fc26.noarch
libselinux-2.6-7.fc26.s390x
bzip2-libs-1.0.6-22.fc26.s390x
libdb-5.3.28-24.fc26.s390x
file-libs-5.30-11.fc26.s390x
libxslt-1.1.29-1.fc26.s390x
gdbm-1.13-1.fc26.s390x
libepoxy-1.4.3-1.fc26.s390x
libpsl-0.18.0-1.fc26.s390x
perl-Carp-1.40-366.fc26.noarch
e2fsprogs-libs-1.43.4-2.fc26.s390x
libmnl-1.0.4-2.fc26.s390x
openjpeg2-2.2.0-3.fc26.s390x
perl-PathTools-3.63-367.fc26.s390x
perl-File-Temp-0.230.400-2.fc26.noarch
perl-XML-Parser-2.44-6.fc26.s390x
libss-1.43.4-2.fc26.s390x
ilmbase-2.2.0-8.fc26.s390x
fuse-libs-2.9.7-2.fc26.s390x
libdaemon-0.14-11.fc26.s390x
libbasicobjects-0.1.1-34.fc26.s390x
iptables-1.6.1-2.fc26.s390x
perl-TermReadKey-2.37-2.fc26.s390x
perl-Term-ANSIColor-4.06-2.fc26.noarch
perl-libintl-perl-1.26-2.fc26.s390x
usbredir-0.7.1-3.fc26.s390x
fftw-libs-double-3.3.5-4.fc26.s390x
libiscsi-1.15.0-3.fc26.s390x
ttmkfdir-3.0.9-49.fc26.s390x
texlive-base-2016-33.20160520.fc26.1.noarch
python2-six-1.10.0-9.fc26.noarch
atk-2.24.0-1.fc26.s390x
python2-kitchen-1.2.4-6.fc26.noarch
guile-2.0.14-1.fc26.s390x
pyxattr-0.5.3-10.fc26.s390x
libyaml-0.1.7-2.fc26.s390x
python3-PyYAML-3.12-3.fc26.s390x
openssh-7.5p1-4.fc26.s390x
openssl-1.1.0g-1.fc26.s390x
gawk-4.1.4-6.fc26.s390x
openldap-2.4.45-2.fc26.s390x
NetworkManager-libnm-1.8.2-4.fc26.s390x
python2-urllib3-1.20-2.fc26.noarch
python3-py-1.4.34-1.fc26.noarch
perl-ExtUtils-Command-7.24-3.fc26.noarch
tzdata-2018c-1.fc26.noarch
libcrypt-nss-2.25-13.fc26.s390x
libstdc++-devel-7.3.1-2.fc26.s390x
rpcbind-0.2.4-8.rc3.fc26.s390x
gdb-headless-8.0.1-36.fc26.s390x
python3-dnf-plugins-extras-common-2.0.5-1.fc26.noarch
glibc-headers-2.25-13.fc26.s390x
libfdt-1.4.6-1.fc26.s390x
wget-1.19.4-1.fc26.s390x
mariadb-common-10.1.30-2.fc26.s390x
python2-dnf-plugin-migrate-2.1.5-4.fc26.noarch
pcre2-devel-10.23-13.fc26.s390x
perl-threads-shared-1.58-1.fc26.s390x
gcc-c++-7.3.1-2.fc26.s390x
ImageMagick-libs-6.9.9.27-1.fc26.s390x
poppler-0.52.0-11.fc26.s390x
perl-Data-Dumper-2.161-4.fc26.s390x
python2-dnf-plugins-extras-common-2.0.5-1.fc26.noarch
gcc-debuginfo-7.3.1-2.fc26.s390x
krb5-libs-1.15.2-7.fc26.s390x
nspr-devel-4.19.0-1.fc26.s390x
nss-softokn-3.36.0-1.0.fc26.s390x
libsss_idmap-1.16.1-1.fc26.s390x
systemtap-runtime-3.2-7.fc26.s390x
gnupg2-2.2.5-1.fc26.s390x
python2-gluster-3.10.11-1.fc26.s390x
sqlite-devel-3.20.1-2.fc26.s390x
git-2.13.6-3.fc26.s390x
libtevent-0.9.36-1.fc26.s390x
elfutils-libs-0.170-4.fc26.s390x
systemtap-3.2-7.fc26.s390x
vim-enhanced-8.0.1553-1.fc26.s390x
gnupg2-smime-2.2.5-1.fc26.s390x
libcurl-devel-7.53.1-16.fc26.s390x
python2-sssdconfig-1.16.1-1.fc26.noarch
patch-2.7.6-3.fc26.s390x
fedora-repos-26-3.noarch
python3-mock-2.0.0-4.fc26.noarch
libgudev-232-1.fc26.s390x
python3-javapackages-4.7.0-17.fc26.noarch
python3-ply-3.9-3.fc26.noarch
python3-systemd-234-1.fc26.s390x
python3-requests-2.13.0-1.fc26.noarch
blktrace-1.1.0-4.fc26.s390x
python2-asn1crypto-0.23.0-1.fc26.noarch
python2-cffi-1.9.1-2.fc26.s390x
python2-sphinx_rtd_theme-0.2.4-1.fc26.noarch
lua-json-1.3.2-7.fc26.noarch
libcephfs1-10.2.7-2.fc26.s390x
glib-networking-2.50.0-2.fc26.s390x
libedit-3.1-17.20160618cvs.fc26.s390x
libverto-libev-0.2.6-7.fc26.s390x
libserf-1.3.9-3.fc26.s390x
python2-kerberos-1.2.5-3.fc26.s390x
libsrtp-1.5.4-4.fc26.s390x
lzo-minilzo-2.08-9.fc26.s390x
librepo-1.8.0-1.fc26.s390x
sg3_utils-1.42-1.fc26.s390x
policycoreutils-2.6-6.fc26.s390x
lvm2-2.02.168-6.fc26.s390x
device-mapper-multipath-libs-0.4.9-88.fc26.s390x
s390utils-cmsfs-1.36.1-3.fc26.s390x
libXdamage-1.1.4-9.fc26.s390x
libXaw-1.0.13-5.fc26.s390x
brltty-5.5-5.fc26.s390x
librsvg2-2.40.18-1.fc26.s390x
texlive-tetex-bin-svn36770.0-33.20160520.fc26.2.noarch
texlive-etex-pkg-svn39355-33.fc26.2.noarch
texlive-graphics-svn41015-33.fc26.2.noarch
texlive-dvips-svn41149-33.fc26.2.noarch
texlive-zapfding-svn31835.0-33.fc26.2.noarch
texlive-footmisc-svn23330.5.5b-33.fc26.2.noarch
texlive-makeindex-svn40768-33.fc26.2.noarch
texlive-pst-ovl-svn40873-33.fc26.2.noarch
texlive-texlive-scripts-svn41433-33.fc26.2.noarch
texlive-ltabptch-svn17533.1.74d-33.fc26.2.noarch
texlive-euro-svn22191.1.1-33.fc26.2.noarch
texlive-mflogo-font-svn36898.1.002-33.fc26.2.noarch
texlive-zapfchan-svn31835.0-33.fc26.2.noarch
texlive-cmextra-svn32831.0-33.fc26.2.noarch
texlive-finstrut-svn21719.0.5-33.fc26.2.noarch
texlive-hyphen-base-svn41138-33.fc26.2.noarch
texlive-marginnote-svn41382-33.fc26.2.noarch
texlive-parallel-svn15878.0-33.fc26.2.noarch
texlive-sepnum-svn20186.2.0-33.fc26.2.noarch
texlive-environ-svn33821.0.3-33.fc26.2.noarch
texlive-type1cm-svn21820.0-33.fc26.2.noarch
texlive-xunicode-svn30466.0.981-33.fc26.2.noarch
texlive-attachfile-svn38830-33.fc26.2.noarch
texlive-fontspec-svn41262-33.fc26.2.noarch
texlive-fancyvrb-svn18492.2.8-33.fc26.2.noarch
texlive-pst-pdf-bin-svn7838.0-33.20160520.fc26.2.noarch
texlive-xcolor-svn41044-33.fc26.2.noarch
texlive-pdfpages-svn40638-33.fc26.2.noarch
texlive-sansmathaccent-svn30187.0-33.fc26.2.noarch
texlive-ucs-svn35853.2.2-33.fc26.2.noarch
texlive-dvipdfmx-bin-svn40273-33.20160520.fc26.2.s390x
libotf-0.9.13-8.fc26.s390x
go-srpm-macros-2-8.fc26.noarch
mesa-libwayland-egl-devel-17.2.4-2.fc26.s390x
ghostscript-9.20-10.fc26.s390x
libcephfs_jni-devel-10.2.7-2.fc26.s390x
libXdamage-devel-1.1.4-9.fc26.s390x
ncurses-devel-6.0-8.20170212.fc26.s390x
fontconfig-devel-2.12.6-4.fc26.s390x
cairo-devel-1.14.10-1.fc26.s390x
libselinux-devel-2.6-7.fc26.s390x
guile-devel-2.0.14-1.fc26.s390x
libcap-ng-devel-0.7.8-3.fc26.s390x
bash-completion-2.6-1.fc26.noarch
libXevie-1.0.3-12.fc26.s390x
python-firewall-0.4.4.5-1.fc26.noarch
python3-html5lib-0.999-13.fc26.noarch
python2-simplejson-3.10.0-3.fc26.s390x
flex-2.6.1-3.fc26.s390x
telnet-0.17-69.fc26.s390x
gpg-pubkey-8e1431d5-53bcbac7
emacs-filesystem-25.3-3.fc26.noarch
fontawesome-fonts-4.7.0-2.fc26.noarch
fontawesome-fonts-web-4.7.0-2.fc26.noarch
rpmconf-base-1.0.19-1.fc26.noarch
info-6.3-3.fc26.s390x
texlive-lib-2016-33.20160520.fc26.1.s390x
libicu-57.1-7.fc26.s390x
libcap-ng-0.7.8-3.fc26.s390x
nettle-3.3-2.fc26.s390x
lcms2-2.8-3.fc26.s390x
dbus-libs-1.11.18-1.fc26.s390x
perl-Exporter-5.72-367.fc26.noarch
unzip-6.0-34.fc26.s390x
iproute-4.11.0-1.fc26.s390x
zip-3.0-18.fc26.s390x
perl-constant-1.33-368.fc26.noarch
perl-MIME-Base64-3.15-366.fc26.s390x
lua-posix-33.3.1-4.fc26.s390x
bzip2-1.0.6-22.fc26.s390x
hyphen-2.8.8-6.fc26.s390x
libdvdread-5.0.3-4.fc26.s390x
libcollection-0.7.0-34.fc26.s390x
libdvdnav-5.0.3-5.fc26.s390x
perl-version-0.99.18-1.fc26.s390x
perl-Encode-2.88-6.fc26.s390x
automake-1.15-9.fc26.noarch
plymouth-core-libs-0.9.3-0.7.20160620git0e65b86c.fc26.s390x
hesiod-3.2.1-7.fc26.s390x
jasper-libs-2.0.14-1.fc26.s390x
mozjs17-17.0.0-18.fc26.s390x
fontconfig-2.12.6-4.fc26.s390x
harfbuzz-1.4.4-1.fc26.s390x
alsa-lib-1.1.4.1-1.fc26.s390x
make-4.2.1-2.fc26.s390x
gobject-introspection-1.52.1-1.fc26.s390x
hicolor-icon-theme-0.15-5.fc26.noarch
gdk-pixbuf2-2.36.9-1.fc26.s390x
libgusb-0.2.11-1.fc26.s390x
libdhash-0.5.0-34.fc26.s390x
python2-bcrypt-3.1.4-2.fc26.s390x
PyYAML-3.12-3.fc26.s390x
openssl-devel-1.1.0g-1.fc26.s390x
copy-jdk-configs-3.3-2.fc26.noarch
python3-setuptools-37.0.0-1.fc26.noarch
kernel-core-4.14.8-200.fc26.s390x
NetworkManager-1.8.2-4.fc26.s390x
libjpeg-turbo-devel-1.5.3-1.fc26.s390x
lua-5.3.4-7.fc26.s390x
kernel-devel-4.14.8-200.fc26.s390x
perl-autodie-2.29-367.fc26.noarch
tzdata-java-2018c-1.fc26.noarch
createrepo_c-0.10.0-15.fc26.s390x
libgfortran-7.3.1-2.fc26.s390x
mariadb-config-10.1.30-2.fc26.s390x
java-1.8.0-openjdk-1.8.0.161-5.b14.fc26.s390x
libtasn1-devel-4.13-1.fc26.s390x
gcc-gdb-plugin-7.3.1-2.fc26.s390x
python2-libxml2-2.9.7-1.fc26.s390x
net-tools-2.0-0.44.20160912git.fc26.s390x
python2-requests-kerberos-0.12.0-1.fc26.noarch
gcc-base-debuginfo-7.3.1-2.fc26.s390x
glusterfs-libs-3.10.11-1.fc26.s390x
system-python-libs-3.6.4-3.fc26.s390x
nss-softokn-freebl-3.36.0-1.0.fc26.s390x
git-core-2.13.6-3.fc26.s390x
libsss_certmap-1.16.1-1.fc26.s390x
nss-softokn-devel-3.36.0-1.0.fc26.s390x
python3-3.6.4-3.fc26.s390x
glusterfs-cli-3.10.11-1.fc26.s390x
perl-5.24.3-396.fc26.s390x
pcre-utf32-8.41-6.fc26.s390x
kernel-headers-4.15.12-201.fc26.s390x
mock-1.4.9-1.fc26.noarch
libXcursor-devel-1.1.15-1.fc26.s390x
python3-sssdconfig-1.16.1-1.fc26.noarch
freetype-devel-2.7.1-10.fc26.s390x
python2-devel-2.7.14-7.fc26.s390x
sssd-nfs-idmap-1.16.1-1.fc26.s390x
libsss_autofs-1.16.1-1.fc26.s390x
libzip-1.3.0-1.fc26.s390x
python3-lxml-4.1.1-1.fc26.s390x
python3-ordered-set-2.0.0-6.fc26.noarch
python3-rpmconf-1.0.19-1.fc26.noarch
python-offtrac-0.1.0-9.fc26.noarch
python2-pycparser-2.14-10.fc26.noarch
python2-sphinx-theme-alabaster-0.7.9-3.fc26.noarch
python2-pysocks-1.6.7-1.fc26.noarch
lua-lpeg-1.0.1-2.fc26.s390x
libproxy-0.4.15-2.fc26.s390x
crontabs-1.11-14.20150630git.fc26.noarch
libev-4.24-2.fc26.s390x
libsigsegv-2.11-1.fc26.s390x
fedora-cert-0.6.0.1-2.fc26.noarch
drpm-0.3.0-6.fc26.s390x
python2-cccolutils-1.5-3.fc26.s390x
m17n-lib-1.7.0-6.fc26.s390x
lsscsi-0.28-4.fc26.s390x
python3-gpg-1.8.0-12.fc26.s390x
sg3_utils-libs-1.42-1.fc26.s390x
SDL2-2.0.7-2.fc26.s390x
util-linux-2.30.2-1.fc26.s390x
s390utils-mon_statd-1.36.1-3.fc26.s390x
GConf2-3.2.6-17.fc26.s390x
systemd-container-233-7.fc26.s390x
libXt-1.1.5-4.fc26.s390x
libXpm-3.5.12-2.fc26.s390x
at-spi2-core-2.24.1-1.fc26.s390x
cairo-1.14.10-1.fc26.s390x
texlive-kpathsea-bin-svn40473-33.20160520.fc26.2.s390x
texlive-ifluatex-svn41346-33.fc26.2.noarch
texlive-babel-svn40706-33.fc26.2.noarch
texlive-colortbl-svn29803.v1.0a-33.fc26.2.noarch
texlive-marvosym-svn29349.2.2a-33.fc26.2.noarch
texlive-euler-svn17261.2.5-33.fc26.2.noarch
texlive-latexconfig-svn40274-33.fc26.2.noarch
texlive-plain-svn40274-33.fc26.2.noarch
texlive-texconfig-bin-svn29741.0-33.20160520.fc26.2.noarch
giflib-4.1.6-16.fc26.s390x
texlive-microtype-svn41127-33.fc26.2.noarch
texlive-eurosym-svn17265.1.4_subrfix-33.fc26.2.noarch
texlive-symbol-svn31835.0-33.fc26.2.noarch
texlive-chngcntr-svn17157.1.0a-33.fc26.2.noarch
texlive-euenc-svn19795.0.1h-33.fc26.2.noarch
texlive-luatex-svn40963-33.fc26.2.noarch
texlive-knuth-local-svn38627-33.fc26.2.noarch
texlive-mparhack-svn15878.1.4-33.fc26.2.noarch
texlive-rcs-svn15878.0-33.fc26.2.noarch
texlive-texlive-msg-translations-svn41431-33.fc26.2.noarch
texlive-updmap-map-svn41159-33.fc26.2.noarch
texlive-geometry-svn19716.5.6-33.fc26.2.noarch
texlive-memoir-svn41203-33.fc26.2.noarch
texlive-l3kernel-svn41246-33.fc26.2.noarch
texlive-pst-eps-svn15878.1.0-33.fc26.2.noarch
texlive-pst-text-svn15878.1.00-33.fc26.2.noarch
texlive-amscls-svn36804.0-33.fc26.2.noarch
texlive-pst-slpe-svn24391.1.31-33.fc26.2.noarch
texlive-extsizes-svn17263.1.4a-33.fc26.2.noarch
texlive-xetex-def-svn40327-33.fc26.2.noarch
texlive-collection-latex-svn41011-33.20160520.fc26.2.noarch
gstreamer1-plugins-base-1.12.3-1.fc26.s390x
fpc-srpm-macros-1.1-2.fc26.noarch
xorg-x11-proto-devel-7.7-22.fc26.noarch
atk-devel-2.24.0-1.fc26.s390x
libxcb-devel-1.12-3.fc26.s390x
libXrandr-devel-1.5.1-2.fc26.s390x
libcom_err-devel-1.43.4-2.fc26.s390x
dbus-devel-1.11.18-1.fc26.s390x
libepoxy-devel-1.4.3-1.fc26.s390x
libicu-devel-57.1-7.fc26.s390x
rpm-build-4.13.0.2-1.fc26.s390x
libssh2-devel-1.8.0-5.fc26.s390x
graphviz-2.40.1-4.fc26.s390x
zlib-static-1.2.11-2.fc26.s390x
mesa-libgbm-devel-17.2.4-2.fc26.s390x
screen-4.6.2-1.fc26.s390x
python-osbs-client-0.39.1-1.fc26.noarch
pyparsing-2.1.10-3.fc26.noarch
python3-pyasn1-0.2.3-1.fc26.noarch
python2-html5lib-0.999-13.fc26.noarch
teamd-1.27-1.fc26.s390x
hardlink-1.3-1.fc26.s390x
chrpath-0.16-4.fc26.s390x
texlive-pdftex-doc-svn41149-33.fc26.2.noarch
grep-3.1-1.fc26.s390x
libacl-2.2.52-15.fc26.s390x
cpio-2.12-4.fc26.s390x
libatomic_ops-7.4.4-2.fc26.s390x
gc-7.6.0-2.fc26.s390x
psmisc-22.21-9.fc26.s390x
systemd-libs-233-7.fc26.s390x
xz-5.2.3-2.fc26.s390x
libpcap-1.8.1-3.fc26.s390x
perl-parent-0.236-2.fc26.noarch
perl-Text-Unidecode-1.30-2.fc26.noarch
newt-0.52.20-1.fc26.s390x
libcomps-0.1.8-3.fc26.s390x
libfontenc-1.1.3-4.fc26.s390x
ipcalc-0.2.0-1.fc26.s390x
libnfnetlink-1.0.1-9.fc26.s390x
libref_array-0.1.5-34.fc26.s390x
perl-Term-Cap-1.17-366.fc26.noarch
perl-Digest-1.17-367.fc26.noarch
perl-Pod-Simple-3.35-2.fc26.noarch
perl-URI-1.71-6.fc26.noarch
attr-2.4.47-18.fc26.s390x
gmp-c++-6.1.2-4.fc26.s390x
harfbuzz-icu-1.4.4-1.fc26.s390x
http-parser-2.7.1-5.fc26.s390x
libsodium-1.0.14-1.fc26.s390x
python-gssapi-1.2.0-5.fc26.s390x
perl-libnet-3.11-1.fc26.noarch
libwayland-client-1.13.0-3.fc26.s390x
python3-dnf-2.7.5-2.fc26.noarch
kernel-modules-4.14.8-200.fc26.s390x
NetworkManager-ppp-1.8.2-4.fc26.s390x
wayland-devel-1.13.0-3.fc26.s390x
kernel-4.14.8-200.fc26.s390x
NetworkManager-glib-1.8.2-4.fc26.s390x
perl-IPC-System-Simple-1.25-12.fc26.noarch
sed-4.4-2.fc26.s390x
libassuan-2.5.1-1.fc26.s390x
createrepo_c-libs-0.10.0-15.fc26.s390x
dnf-utils-2.1.5-4.fc26.noarch
libobjc-7.3.1-2.fc26.s390x
dracut-046-8.git20180105.fc26.s390x
libseccomp-2.3.3-1.fc26.s390x
python-sphinx-locale-1.5.6-1.fc26.noarch
libxml2-devel-2.9.7-1.fc26.s390x
libseccomp-devel-2.3.3-1.fc26.s390x
fedora-upgrade-28.1-1.fc26.noarch
gcc-gfortran-7.3.1-2.fc26.s390x
gdb-8.0.1-36.fc26.s390x
unbound-libs-1.6.8-1.fc26.s390x
man-db-2.7.6.1-9.fc26.s390x
python2-rpm-macros-3-21.fc26.noarch
kernel-devel-4.15.4-200.fc26.s390x
sqlite-libs-3.20.1-2.fc26.s390x
python2-2.7.14-7.fc26.s390x
libkadm5-1.15.2-7.fc26.s390x
libcurl-7.53.1-16.fc26.s390x
net-snmp-agent-libs-5.7.3-27.fc26.s390x
p11-kit-trust-0.23.10-1.fc26.s390x
python3-koji-1.15.0-4.fc26.noarch
glusterfs-server-3.10.11-1.fc26.s390x
kernel-devel-4.15.12-201.fc26.s390x
pcre-utf16-8.41-6.fc26.s390x
jansson-2.11-1.fc26.s390x
python2-rpkg-1.52-1.fc26.noarch
pcre-static-8.41-6.fc26.s390x
systemtap-sdt-devel-3.2-7.fc26.s390x
libXfont-1.5.4-1.fc26.s390x
system-python-3.6.4-3.fc26.s390x
shared-mime-info-1.8-3.fc26.s390x
libpaper-1.1.24-21.fc26.s390x
python3-pbr-1.10.0-4.fc26.noarch
libcroco-0.6.12-1.fc26.s390x
libssh2-1.8.0-5.fc26.s390x
json-glib-1.2.6-1.fc26.s390x
libevent-2.0.22-3.fc26.s390x
gdk-pixbuf2-modules-2.36.9-1.fc26.s390x
colord-libs-1.3.5-1.fc26.s390x
python3-magic-5.30-11.fc26.noarch
python3-gobject-base-3.24.1-1.fc26.s390x
python3-pyroute2-0.4.13-1.fc26.noarch
python3-pysocks-1.6.7-1.fc26.noarch
python2-click-6.7-3.fc26.noarch
python-munch-2.1.0-2.fc26.noarch
python2-ply-3.9-3.fc26.noarch
python2-snowballstemmer-1.2.1-3.fc26.noarch
python-magic-5.30-11.fc26.noarch
python-beautifulsoup4-4.6.0-1.fc26.noarch
python2-gitdb-2.0.3-1.fc26.noarch
librados-devel-10.2.7-2.fc26.s390x
libcacard-2.5.3-1.fc26.s390x
libmodman-2.0.1-13.fc26.s390x
zziplib-0.13.62-8.fc26.s390x
lksctp-tools-1.0.16-6.fc26.s390x
procmail-3.22-44.fc26.s390x
libthai-0.1.25-2.fc26.s390x
libpipeline-1.4.1-3.fc26.s390x
python2-pycurl-7.43.0-8.fc26.s390x
deltarpm-3.6-19.fc26.s390x
subversion-libs-1.9.7-1.fc26.s390x
python-krbV-1.0.90-13.fc26.s390x
m17n-db-1.7.0-8.fc26.noarch
linux-atm-libs-2.5.1-17.fc26.s390x
python2-rpm-4.13.0.2-1.fc26.s390x
python2-librepo-1.8.0-1.fc26.s390x
qrencode-libs-3.4.4-1.fc26.s390x
s390utils-iucvterm-1.36.1-3.fc26.s390x
libsmartcols-2.30.2-1.fc26.s390x
dbus-1.11.18-1.fc26.s390x
systemd-udev-233-7.fc26.s390x
device-mapper-event-1.02.137-6.fc26.s390x
polkit-0.113-8.fc26.s390x
libwmf-lite-0.2.8.4-53.fc26.s390x
libXcomposite-0.4.4-9.fc26.s390x
at-spi2-atk-2.24.1-1.fc26.s390x
pango-1.40.12-1.fc26.s390x
texlive-metafont-bin-svn40987-33.20160520.fc26.2.s390x
texlive-url-svn32528.3.4-33.fc26.2.noarch
texlive-fp-svn15878.0-33.fc26.2.noarch
texlive-latex-fonts-svn28888.0-33.fc26.2.noarch
texlive-mptopdf-bin-svn18674.0-33.20160520.fc26.2.noarch
texlive-fancybox-svn18304.1.4-33.fc26.2.noarch
texlive-lua-alt-getopt-svn29349.0.7.0-33.fc26.2.noarch
texlive-tex-bin-svn40987-33.20160520.fc26.2.s390x
texlive-texconfig-svn40768-33.fc26.2.noarch
texlive-wasy2-ps-svn35830.0-33.fc26.2.noarch
texlive-psfrag-svn15878.3.04-33.fc26.2.noarch
texlive-helvetic-svn31835.0-33.fc26.2.noarch
texlive-times-svn35058.0-33.fc26.2.noarch
texlive-cite-svn36428.5.5-33.fc26.2.noarch
texlive-fancyhdr-svn15878.3.1-33.fc26.2.noarch
texlive-luatex-bin-svn41091-33.20160520.fc26.2.s390x
texlive-lm-math-svn36915.1.959-33.fc26.2.noarch
texlive-ntgclass-svn15878.2.1a-33.fc26.2.noarch
texlive-sansmath-svn17997.1.1-33.fc26.2.noarch
texlive-textcase-svn15878.0-33.fc26.2.noarch
texlive-unicode-data-svn39808-33.fc26.2.noarch
texlive-breakurl-svn29901.1.40-33.fc26.2.noarch
texlive-latex-svn40218-33.fc26.2.noarch
texlive-lualatex-math-svn40621-33.fc26.2.noarch
texlive-pst-coil-svn37377.1.07-33.fc26.2.noarch
texlive-pst-plot-svn41242-33.fc26.2.noarch
texlive-unicode-math-svn38462-33.fc26.2.noarch
texlive-pst-blur-svn15878.2.0-33.fc26.2.noarch
texlive-cm-super-svn15878.0-33.fc26.2.noarch
texlive-wasysym-svn15878.2.0-33.fc26.2.noarch
texlive-collection-fontsrecommended-svn35830.0-33.20160520.fc26.2.noarch
libXv-1.0.11-2.fc26.s390x
ghc-srpm-macros-1.4.2-5.fc26.noarch
latex2html-2017.2-2.fc26.noarch
libXau-devel-1.0.8-7.fc26.s390x
graphite2-devel-1.3.10-1.fc26.s390x
pixman-devel-0.34.0-3.fc26.s390x
wayland-protocols-devel-1.9-1.fc26.noarch
mesa-libGLES-devel-17.2.4-2.fc26.s390x
vte291-devel-0.48.4-1.fc26.s390x
ceph-devel-compat-10.2.7-2.fc26.s390x
lzo-devel-2.08-9.fc26.s390x
libiscsi-devel-1.15.0-3.fc26.s390x
avahi-autoipd-0.6.32-7.fc26.s390x
rpm-plugin-systemd-inhibit-4.13.0.2-1.fc26.s390x
python2-ndg_httpsclient-0.4.0-7.fc26.noarch
gettext-0.19.8.1-9.fc26.s390x
btrfs-progs-4.9.1-2.fc26.s390x
fedora-logos-26.0.1-1.fc26.s390x
dejagnu-1.6-2.fc26.noarch
libaio-devel-0.3.110-7.fc26.s390x
dos2unix-7.3.4-2.fc26.s390x
popt-1.16-12.fc26.s390x
tar-1.29-5.fc26.s390x
avahi-libs-0.6.32-7.fc26.s390x
m4-1.4.18-3.fc26.s390x
perl-Time-Local-1.250-2.fc26.noarch
libmetalink-0.1.3-2.fc26.s390x
jbigkit-libs-2.1-6.fc26.s390x
netpbm-10.80.00-2.fc26.s390x
perl-Digest-MD5-2.55-3.fc26.s390x
perl-Getopt-Long-2.49.1-2.fc26.noarch
libglvnd-opengl-1.0.0-1.fc26.s390x
libattr-devel-2.4.47-18.fc26.s390x
teckit-2.5.1-16.fc26.s390x
python3-six-1.10.0-9.fc26.noarch
python3-libcomps-0.1.8-3.fc26.s390x
python3-pyparsing-2.1.10-3.fc26.noarch
python2-markupsafe-0.23-13.fc26.s390x
python2-mock-2.0.0-4.fc26.noarch
python2-yubico-1.3.2-7.fc26.noarch
python2-smmap-2.0.3-1.fc26.noarch
librbd-devel-10.2.7-2.fc26.s390x
libnghttp2-1.21.1-1.fc26.s390x
ykpers-1.18.0-2.fc26.s390x
python3-librepo-1.8.0-1.fc26.s390x
geoclue2-2.4.5-4.fc26.s390x
initscripts-9.72-1.fc26.s390x
plymouth-0.9.3-0.7.20160620git0e65b86c.fc26.s390x
ebtables-2.0.10-22.fc26.s390x
gssproxy-0.7.0-9.fc26.s390x
libXext-1.3.3-5.fc26.s390x
mesa-libEGL-17.2.4-2.fc26.s390x
texlive-texlive.infra-bin-svn40312-33.20160520.fc26.2.s390x
texlive-thumbpdf-svn34621.3.16-33.fc26.2.noarch
texlive-carlisle-svn18258.0-33.fc26.2.noarch
texlive-gsftopk-svn40768-33.fc26.2.noarch
texlive-pdftex-svn41149-33.fc26.2.noarch
texlive-crop-svn15878.1.5-33.fc26.2.noarch
texlive-pxfonts-svn15878.0-33.fc26.2.noarch
texlive-enctex-svn34957.0-33.fc26.2.noarch
texlive-kastrup-svn15878.0-33.fc26.2.noarch
texlive-pspicture-svn15878.0-33.fc26.2.noarch
texlive-varwidth-svn24104.0.92-33.fc26.2.noarch
texlive-currfile-svn40725-33.fc26.2.noarch
texlive-pst-grad-svn15878.1.06-33.fc26.2.noarch
texlive-latex-bin-svn41438-33.fc26.2.noarch
texlive-ltxmisc-svn21927.0-33.fc26.2.noarch
lasi-1.1.2-7.fc26.s390x
adwaita-icon-theme-3.24.0-2.fc26.noarch
xz-devel-5.2.3-2.fc26.s390x
xorg-x11-fonts-Type1-7.5-17.fc26.noarch
libXi-devel-1.7.9-2.fc26.s390x
at-spi2-atk-devel-2.24.1-1.fc26.s390x
pango-devel-1.40.12-1.fc26.s390x
libcacard-devel-2.5.3-1.fc26.s390x
subversion-1.9.7-1.fc26.s390x
sudo-1.8.21p2-1.fc26.s390x
pykickstart-2.35-2.fc26.noarch
e2fsprogs-1.43.4-2.fc26.s390x
libbsd-0.8.3-3.fc26.s390x
c-ares-1.13.0-1.fc26.s390x
python2-pyxdg-0.25-12.fc26.noarch
valgrind-3.13.0-12.fc26.s390x
libwayland-server-1.13.0-3.fc26.s390x
dhcp-client-4.3.5-10.fc26.s390x
man-pages-4.09-4.fc26.noarch
libffi-devel-3.1-12.fc26.s390x
libxml2-2.9.7-1.fc26.s390x
kmod-25-1.fc26.s390x
dnf-plugins-core-2.1.5-4.fc26.noarch
kmod-libs-25-1.fc26.s390x
pigz-2.4-1.fc26.s390x
pkgconf-pkg-config-1.3.12-2.fc26.s390x
gcc-go-7.3.1-2.fc26.s390x
python-rpm-macros-3-21.fc26.noarch
perl-libs-5.24.3-396.fc26.s390x
glusterfs-api-3.10.11-1.fc26.s390x
git-core-doc-2.13.6-3.fc26.s390x
pcre-cpp-8.41-6.fc26.s390x
usermode-1.112-1.fc26.s390x
distribution-gpg-keys-1.19-1.fc26.noarch
perl-Test-Harness-3.41-1.fc26.noarch
krb5-devel-1.15.2-7.fc26.s390x
libvorbis-1.3.6-1.fc26.s390x
python2-configargparse-0.12.0-1.fc26.noarch
gpg-pubkey-a29cb19c-53bcbba6
quota-nls-4.03-9.fc26.noarch
xz-libs-5.2.3-2.fc26.s390x
gmp-6.1.2-4.fc26.s390x
file-5.30-11.fc26.s390x
libusbx-1.0.21-2.fc26.s390x
binutils-2.27-28.fc26.s390x
perl-HTTP-Tiny-0.070-2.fc26.noarch
xml-common-0.6.3-45.fc26.noarch
opus-1.2.1-1.fc26.s390x
flac-libs-1.3.2-2.fc26.s390x
libacl-devel-2.2.52-15.fc26.s390x
coreutils-common-8.27-7.fc26.s390x
cracklib-2.9.6-5.fc26.s390x
pyliblzma-0.5.3-17.fc26.s390x
libnotify-0.7.7-2.fc26.s390x
python3-idna-2.5-1.fc26.noarch
python3-pyOpenSSL-16.2.0-6.fc26.noarch
python2-pbr-1.10.0-4.fc26.noarch
pyusb-1.0.0-4.fc26.noarch
librbd1-10.2.7-2.fc26.s390x
libnfs-1.9.8-3.fc26.s390x
libsolv-0.6.30-2.fc26.s390x
python3-pycurl-7.43.0-8.fc26.s390x
libyubikey-1.13-3.fc26.s390x
rpmlint-1.10-5.fc26.noarch
python2-pygpgme-0.3-22.fc26.s390x
s390utils-base-1.36.1-3.fc26.s390x
ppp-2.4.7-11.fc26.s390x
s390utils-cpuplugd-1.36.1-3.fc26.s390x
libXrender-0.9.10-2.fc26.s390x
libglvnd-gles-1.0.0-1.fc26.s390x
texlive-texlive.infra-svn41280-33.fc26.2.noarch
texlive-lm-svn28119.2.004-33.fc26.2.noarch
texlive-babelbib-svn25245.1.31-33.fc26.2.noarch
texlive-index-svn24099.4.1beta-33.fc26.2.noarch
texlive-pdftex-bin-svn40987-33.20160520.fc26.2.s390x
texlive-csquotes-svn39538-33.fc26.2.noarch
texlive-rsfs-svn15878.0-33.fc26.2.noarch
texlive-etex-svn37057.0-33.fc26.2.noarch
texlive-knuth-lib-svn35820.0-33.fc26.2.noarch
texlive-pst-math-svn34786.0.63-33.fc26.2.noarch
texlive-utopia-svn15878.0-33.fc26.2.noarch
texlive-eso-pic-svn37925.2.0g-33.fc26.2.noarch
texlive-pst-fill-svn15878.1.01-33.fc26.2.noarch
texlive-latex-bin-bin-svn14050.0-33.20160520.fc26.2.noarch
texlive-jknapltx-svn19440.0-33.fc26.2.noarch
texlive-collection-latexrecommended-svn35765.0-33.20160520.fc26.2.noarch
adwaita-cursor-theme-3.24.0-2.fc26.noarch
xorg-x11-fonts-ISO8859-1-100dpi-7.5-17.fc26.noarch
libXcomposite-devel-0.4.4-9.fc26.s390x
at-spi2-core-devel-2.24.1-1.fc26.s390x
harfbuzz-devel-1.4.4-1.fc26.s390x
rpmdevtools-8.10-2.fc26.noarch
texi2html-5.0-5.fc26.noarch
libnfs-devel-1.9.8-3.fc26.s390x
firewalld-0.4.4.5-1.fc26.noarch
wpa_supplicant-2.6-12.fc26.s390x
newt-python-0.52.20-1.fc26.s390x
perl-Mozilla-CA-20160104-4.fc26.noarch
pth-2.0.7-28.fc26.s390x
python3-pyxdg-0.25-12.fc26.noarch
timedatex-0.4-3.fc26.s390x
libjpeg-turbo-1.5.3-1.fc26.s390x
dnf-yum-2.7.5-2.fc26.noarch
libuv-devel-1.11.0-1.fc26.s390x
libstdc++-7.3.1-2.fc26.s390x
libgo-7.3.1-2.fc26.s390x
python3-dnf-plugins-core-2.1.5-4.fc26.noarch
gtk3-3.22.21-3.fc26.s390x
perl-threads-2.21-1.fc26.s390x
pkgconf-m4-1.3.12-2.fc26.noarch
gtk3-devel-3.22.21-3.fc26.s390x
gcc-objc-7.3.1-2.fc26.s390x
nss-util-3.36.0-1.0.fc26.s390x
python2-koji-1.15.0-4.fc26.noarch
kernel-modules-4.15.12-201.fc26.s390x
elfutils-libelf-devel-0.170-4.fc26.s390x
selinux-policy-3.13.1-260.20.fc26.noarch
mock-core-configs-28.3-1.fc26.noarch
glusterfs-api-devel-3.10.11-1.fc26.s390x
krb5-workstation-1.15.2-7.fc26.s390x
libsss_sudo-1.16.1-1.fc26.s390x
python-async-0.6.1-9.fc22.s390x
poppler-data-0.4.7-7.fc26.noarch
ocaml-srpm-macros-4-2.fc26.noarch
libuuid-2.30.2-1.fc26.s390x
libgpg-error-1.25-2.fc26.s390x
graphite2-1.3.10-1.fc26.s390x
perl-Text-Tabs+Wrap-2013.0523-366.fc26.noarch
perl-Error-0.17024-8.fc26.noarch
which-2.21-2.fc26.s390x
libXau-1.0.8-7.fc26.s390x
orc-0.4.27-1.fc26.s390x
perl-Pod-Perldoc-3.28-1.fc26.noarch
libsndfile-1.0.28-6.fc26.s390x
gzip-1.8-2.fc26.s390x
python-ipaddress-1.0.16-4.fc26.noarch
yum-metadata-parser-1.1.4-18.fc26.s390x
python3-dbus-1.2.4-6.fc26.s390x
python3-cryptography-2.0.2-2.fc26.s390x
python3-kickstart-2.35-2.fc26.noarch
python2-imagesize-0.7.1-5.fc26.noarch
python2-jinja2-2.9.6-1.fc26.noarch
libradosstriper-devel-10.2.7-2.fc26.s390x
soundtouch-1.9.2-4.fc26.s390x
libndp-1.6-2.fc26.s390x
rpm-4.13.0.2-1.fc26.s390x
rest-0.8.0-2.fc26.s390x
libvisual-0.4.0-21.fc26.s390x
python2-hawkey-0.11.1-1.fc26.s390x
fakeroot-libs-1.22-1.fc26.s390x
device-mapper-event-libs-1.02.137-6.fc26.s390x
cyrus-sasl-2.1.26-32.fc26.s390x
cronie-anacron-1.5.1-5.fc26.s390x
libpath_utils-0.2.1-34.fc26.s390x
libX11-common-1.6.5-2.fc26.noarch
libXft-2.3.2-5.fc26.s390x
gtk2-2.24.31-4.fc26.s390x
texlive-etoolbox-svn38031.2.2a-33.fc26.2.noarch
texlive-multido-svn18302.1.42-33.fc26.2.noarch
texlive-glyphlist-svn28576.0-33.fc26.2.noarch
texlive-setspace-svn24881.6.7a-33.fc26.2.noarch
texlive-mathtools-svn38833-33.fc26.2.noarch
texlive-ncntrsbk-svn31835.0-33.fc26.2.noarch
texlive-dvisvgm-def-svn41011-33.fc26.2.noarch
texlive-ifetex-svn24853.1.2-33.fc26.2.noarch
texlive-parskip-svn19963.2.0-33.fc26.2.noarch
texlive-bera-svn20031.0-33.fc26.2.noarch
texlive-pgf-svn40966-33.fc26.2.noarch
texlive-auto-pst-pdf-svn23723.0.6-33.fc26.2.noarch
texlive-ctable-svn38672-33.fc26.2.noarch
texlive-typehtml-svn17134.0-33.fc26.2.noarch
mesa-libGLES-17.2.4-2.fc26.s390x
vte291-0.48.4-1.fc26.s390x
libcephfs_jni1-10.2.7-2.fc26.s390x
bzip2-devel-1.0.6-22.fc26.s390x
expat-devel-2.2.4-1.fc26.s390x
libsepol-devel-2.6-2.fc26.s390x
glib2-static-2.52.3-2.fc26.s390x
virglrenderer-devel-0.6.0-1.20170210git76b3da97b.fc26.s390x
parted-3.2-24.fc26.s390x
python3-beautifulsoup4-4.6.0-1.fc26.noarch
python-bunch-1.0.1-10.fc26.noarch
lz4-1.8.0-1.fc26.s390x
openssh-clients-7.5p1-4.fc26.s390x
chrony-3.2-1.fc26.s390x
dnf-conf-2.7.5-2.fc26.noarch
bodhi-client-2.12.2-3.fc26.noarch
libuv-1.11.0-1.fc26.s390x
glibc-2.25-13.fc26.s390x
libgomp-7.3.1-2.fc26.s390x
cmake-rpm-macros-3.10.1-11.fc26.noarch
gtk-update-icon-cache-3.22.21-3.fc26.s390x
pcre2-utf32-10.23-13.fc26.s390x
kernel-modules-4.15.4-200.fc26.s390x
webkitgtk4-2.18.6-1.fc26.s390x
libstdc++-static-7.3.1-2.fc26.s390x
rsync-3.1.3-2.fc26.s390x
nspr-4.19.0-1.fc26.s390x
nss-util-devel-3.36.0-1.0.fc26.s390x
kernel-core-4.15.12-201.fc26.s390x
glusterfs-extra-xlators-3.10.11-1.fc26.s390x
vim-filesystem-8.0.1553-1.fc26.noarch
systemtap-client-3.2-7.fc26.s390x
net-snmp-5.7.3-27.fc26.s390x
mailx-12.5-25.fc26.s390x
mpfr-3.1.6-1.fc26.s390x
libzip-devel-1.3.0-1.fc26.s390x
hawkey-0.6.4-3.fc25.s390x
perl-srpm-macros-1-21.fc26.noarch
expat-2.2.4-1.fc26.s390x
chkconfig-1.10-1.fc26.s390x
findutils-4.6.0-12.fc26.s390x
mesa-libwayland-egl-17.2.4-2.fc26.s390x
procps-ng-3.3.10-13.fc26.s390x
mesa-libglapi-17.2.4-2.fc26.s390x
perl-Unicode-Normalize-1.25-366.fc26.s390x
perl-IO-Socket-IP-0.39-1.fc26.noarch
hunspell-en-US-0.20140811.1-6.fc26.noarch
libxcb-1.12-3.fc26.s390x
perl-Pod-Escapes-1.07-366.fc26.noarch
perl-Pod-Usage-1.69-2.fc26.noarch
libtheora-1.1.1-15.fc26.s390x
tcp_wrappers-7.6-85.fc26.s390x
coreutils-8.27-7.fc26.s390x
libmount-2.30.2-1.fc26.s390x
python2-iniparse-0.4-24.fc26.noarch
python2-decorator-4.0.11-2.fc26.noarch
ModemManager-glib-1.6.10-1.fc26.s390x
python3-decorator-4.0.11-2.fc26.noarch
python3-cffi-1.9.1-2.fc26.s390x
python-bugzilla-cli-2.1.0-1.fc26.noarch
python2-funcsigs-1.0.2-5.fc26.noarch
python2-babel-2.3.4-5.fc26.noarch
python-bugzilla-2.1.0-1.fc26.noarch
libradosstriper1-10.2.7-2.fc26.s390x
snappy-1.1.4-3.fc26.s390x
libmpcdec-1.2.6-17.fc26.s390x
rpm-libs-4.13.0.2-1.fc26.s390x
python-urlgrabber-3.10.1-11.fc26.noarch
sysfsutils-2.1.0-20.fc26.s390x
python3-hawkey-0.11.1-1.fc26.s390x
iputils-20161105-5.fc26.s390x
plymouth-scripts-0.9.3-0.7.20160620git0e65b86c.fc26.s390x
cronie-1.5.1-5.fc26.s390x
libini_config-1.3.1-34.fc26.s390x
libX11-1.6.5-2.fc26.s390x
libglvnd-egl-1.0.0-1.fc26.s390x
texlive-kpathsea-svn41139-33.fc26.2.noarch
texlive-thumbpdf-bin-svn6898.0-33.20160520.fc26.2.noarch
texlive-subfig-svn15878.1.3-33.fc26.2.noarch
texlive-gsftopk-bin-svn40473-33.20160520.fc26.2.s390x
texlive-tex-ini-files-svn40533-33.fc26.2.noarch
texlive-qstest-svn15878.0-33.fc26.2.noarch
texlive-palatino-svn31835.0-33.fc26.2.noarch
texlive-ec-svn25033.1.0-33.fc26.2.noarch
texlive-iftex-svn29654.0.2-33.fc26.2.noarch
texlive-pslatex-svn16416.0-33.fc26.2.noarch
texlive-algorithms-svn38085.0.1-33.fc26.2.noarch
texlive-filehook-svn24280.0.5d-33.fc26.2.noarch
texlive-pst-node-svn40743-33.fc26.2.noarch
texlive-rotating-svn16832.2.16b-33.fc26.2.noarch
texlive-seminar-svn34011.1.62-33.fc26.2.noarch
libuuid-devel-2.30.2-1.fc26.s390x
libXinerama-devel-1.1.3-7.fc26.s390x
emacs-common-25.3-3.fc26.s390x
fedora-packager-0.6.0.1-2.fc26.noarch
snappy-devel-1.1.4-3.fc26.s390x
authconfig-7.0.1-2.fc26.s390x
newt-python3-0.52.20-1.fc26.s390x
python-decoratortools-1.8-13.fc26.noarch
python-systemd-doc-234-1.fc26.s390x
openssl-libs-1.1.0g-1.fc26.s390x
lsof-4.89-5.fc26.s390x
glibc-all-langpacks-2.25-13.fc26.s390x
audit-libs-2.8.2-1.fc26.s390x
gcc-7.3.1-2.fc26.s390x
pcre2-utf16-10.23-13.fc26.s390x
kernel-core-4.15.4-200.fc26.s390x
dracut-config-rescue-046-8.git20180105.fc26.s390x
webkitgtk4-plugin-process-gtk2-2.18.6-1.fc26.s390x
perl-Time-HiRes-1.9753-1.fc26.s390x
haveged-1.9.1-6.fc26.s390x
p11-kit-0.23.10-1.fc26.s390x
boost-system-1.63.0-11.fc26.s390x
glusterfs-fuse-3.10.11-1.fc26.s390x
vim-common-8.0.1553-1.fc26.s390x
systemtap-devel-3.2-7.fc26.s390x
perl-SelfLoader-1.23-396.fc26.noarch
nss-tools-3.36.0-1.0.fc26.s390x
libwebp-0.6.1-8.fc26.s390x
python3-configargparse-0.12.0-1.fc26.noarch
gpg-pubkey-a0a7badb-52844296
gpg-pubkey-e372e838-56fd7943
gpg-pubkey-3b921d09-57a87096
google-roboto-slab-fonts-1.100263-0.5.20150923git.fc26.noarch
libreport-filesystem-2.9.1-3.fc26.s390x
libcom_err-1.43.4-2.fc26.s390x
libffi-3.1-12.fc26.s390x
keyutils-libs-1.5.10-1.fc26.s390x
diffutils-3.5-3.fc26.s390x
apr-util-1.5.4-6.fc26.s390x
bluez-libs-5.46-6.fc26.s390x
libksba-1.3.5-3.fc26.s390x
ncurses-6.0-8.20170212.fc26.s390x
libteam-1.27-1.fc26.s390x
perl-Fedora-VSP-0.001-5.fc26.noarch
libusb-0.1.5-8.fc26.s390x
acl-2.2.52-15.fc26.s390x
dwz-0.12-3.fc26.s390x
libblkid-2.30.2-1.fc26.s390x
polkit-libs-0.113-8.fc26.s390x
dbus-python-1.2.4-6.fc26.s390x
gts-0.7.6-30.20121130.fc26.s390x
libfdisk-2.30.2-1.fc26.s390x
python3-pycparser-2.14-10.fc26.noarch
python3-bugzilla-2.1.0-1.fc26.noarch
python2-docutils-0.13.1-4.fc26.noarch
python2-requests-2.13.0-1.fc26.noarch
libcephfs-devel-10.2.7-2.fc26.s390x
ncurses-c++-libs-6.0-8.20170212.fc26.s390x
GeoIP-1.6.11-1.fc26.s390x
liblockfile-1.09-5.fc26.s390x
rpm-plugin-selinux-4.13.0.2-1.fc26.s390x
libsysfs-2.1.0-20.fc26.s390x
libdnf-0.11.1-1.fc26.s390x
mesa-libgbm-17.2.4-2.fc26.s390x
lvm2-libs-2.02.168-6.fc26.s390x
libXfixes-5.0.3-2.fc26.s390x
brlapi-0.6.6-5.fc26.s390x
texlive-metafont-svn40793-33.fc26.2.noarch
texlive-graphics-cfg-svn40269-33.fc26.2.noarch
texlive-mptopdf-svn41282-33.fc26.2.noarch
texlive-makeindex-bin-svn40473-33.20160520.fc26.2.s390x
texlive-texlive-scripts-bin-svn29741.0-33.20160520.fc26.2.noarch
texlive-sauerj-svn15878.0-33.fc26.2.noarch
texlive-txfonts-svn15878.0-33.fc26.2.noarch
texlive-filecontents-svn24250.1.3-33.fc26.2.noarch
texlive-lualibs-svn40370-33.fc26.2.noarch
texlive-section-svn20180.0-33.fc26.2.noarch
texlive-ucharcat-svn38907-33.fc26.2.noarch
texlive-hyperref-svn41396-33.fc26.2.noarch
texlive-pst-3d-svn17257.1.10-33.fc26.2.noarch
texlive-oberdiek-svn41346-33.fc26.2.noarch
texlive-ae-svn15878.1.4-33.fc26.2.noarch
texlive-collection-basic-svn41149-33.20160520.fc26.2.noarch
gnat-srpm-macros-4-2.fc26.noarch
glib2-devel-2.52.3-2.fc26.s390x
netpbm-progs-10.80.00-2.fc26.s390x
libXxf86vm-devel-1.1.4-4.fc26.s390x
nettle-devel-3.3-2.fc26.s390x
cairo-gobject-devel-1.14.10-1.fc26.s390x
fedora-rpm-macros-26-2.fc26.noarch
libidn-devel-1.33-2.fc26.s390x
s390utils-1.36.1-3.fc26.s390x
libtool-2.4.6-17.fc26.s390x
python3-cssselect-0.9.2-4.fc26.noarch
python2-cssselect-0.9.2-4.fc26.noarch
bison-3.0.4-6.fc26.s390x
rootfiles-8.1-20.fc26.noarch
python3-urllib3-1.20-2.fc26.noarch
libgcc-7.3.1-2.fc26.s390x
python3-distro-1.2.0-1.fc26.noarch
libnfsidmap-2.2.1-4.rc2.fc26.s390x
kernel-4.15.4-200.fc26.s390x
glibc-static-2.25-13.fc26.s390x
xapian-core-libs-1.4.5-1.fc26.s390x
elfutils-libelf-0.170-4.fc26.s390x
nss-3.36.0-1.0.fc26.s390x
nss-softokn-freebl-devel-3.36.0-1.0.fc26.s390x
koji-1.15.0-4.fc26.noarch
perl-Git-2.13.6-3.fc26.noarch
elfutils-default-yama-scope-0.170-4.fc26.noarch
selinux-policy-targeted-3.13.1-260.20.fc26.noarch
curl-7.53.1-16.fc26.s390x
publicsuffix-list-dafsa-20180223-1.fc26.noarch
python3-funcsigs-1.0.2-5.fc26.noarch
=== TEST BEGIN ===
Using CC: /home/fam/bin/cc
Install prefix /var/tmp/patchew-tester-tmp-zmws4k92/src/install
BIOS directory /var/tmp/patchew-tester-tmp-zmws4k92/src/install/share/qemu
firmware path /var/tmp/patchew-tester-tmp-zmws4k92/src/install/share/qemu-firmware
binary directory /var/tmp/patchew-tester-tmp-zmws4k92/src/install/bin
library directory /var/tmp/patchew-tester-tmp-zmws4k92/src/install/lib
module directory /var/tmp/patchew-tester-tmp-zmws4k92/src/install/lib/qemu
libexec directory /var/tmp/patchew-tester-tmp-zmws4k92/src/install/libexec
include directory /var/tmp/patchew-tester-tmp-zmws4k92/src/install/include
config directory /var/tmp/patchew-tester-tmp-zmws4k92/src/install/etc
local state directory /var/tmp/patchew-tester-tmp-zmws4k92/src/install/var
Manual directory /var/tmp/patchew-tester-tmp-zmws4k92/src/install/share/man
ELF interp prefix /usr/gnemul/qemu-%M
Source path /var/tmp/patchew-tester-tmp-zmws4k92/src
GIT binary git
GIT submodules ui/keycodemapdb capstone
C compiler /home/fam/bin/cc
Host C compiler cc
C++ compiler c++
Objective-C compiler /home/fam/bin/cc
ARFLAGS rv
CFLAGS -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g
QEMU_CFLAGS -I/usr/include/pixman-1 -Werror -DHAS_LIBSSH2_SFTP_FSYNC -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wexpansion-to-defined -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-strong -I/usr/include/p11-kit-1 -I/usr/include/libpng16 -I/usr/include/libdrm -I$(SRC_PATH)/capstone/include
LDFLAGS -Wl,--warn-common -m64 -g
make make
install install
python python -B
smbd /usr/sbin/smbd
module support no
host CPU s390x
host big endian yes
target list aarch64-softmmu alpha-softmmu arm-softmmu cris-softmmu hppa-softmmu i386-softmmu lm32-softmmu m68k-softmmu microblazeel-softmmu microblaze-softmmu mips64el-softmmu mips64-softmmu mipsel-softmmu mips-softmmu moxie-softmmu nios2-softmmu or1k-softmmu ppc64-softmmu ppcemb-softmmu ppc-softmmu riscv32-softmmu riscv64-softmmu s390x-softmmu sh4eb-softmmu sh4-softmmu sparc64-softmmu sparc-softmmu tricore-softmmu unicore32-softmmu x86_64-softmmu xtensaeb-softmmu xtensa-softmmu aarch64_be-linux-user aarch64-linux-user alpha-linux-user armeb-linux-user arm-linux-user cris-linux-user hppa-linux-user i386-linux-user m68k-linux-user microblazeel-linux-user microblaze-linux-user mips64el-linux-user mips64-linux-user mipsel-linux-user mips-linux-user mipsn32el-linux-user mipsn32-linux-user nios2-linux-user or1k-linux-user ppc64abi32-linux-user ppc64le-linux-user ppc64-linux-user ppc-linux-user riscv32-linux-user riscv64-linux-user s390x-linux-user sh4eb-linux-user sh4-linux-user sparc32plus-linux-user sparc64-linux-user sparc-linux-user tilegx-linux-user x86_64-linux-user xtensaeb-linux-user xtensa-linux-user
gprof enabled no
sparse enabled no
strip binaries yes
profiler no
static build no
SDL support yes (2.0.7)
GTK support yes (3.22.21)
GTK GL support yes
VTE support yes (0.48.4)
TLS priority NORMAL
GNUTLS support yes
GNUTLS rnd yes
libgcrypt no
libgcrypt kdf no
nettle yes (3.3)
nettle kdf yes
libtasn1 yes
curses support yes
virgl support yes
curl support yes
mingw32 support no
Audio drivers oss
Block whitelist (rw)
Block whitelist (ro)
VirtFS support yes
Multipath support no
VNC support yes
VNC SASL support yes
VNC JPEG support yes
VNC PNG support yes
xen support no
brlapi support yes
bluez support yes
Documentation yes
PIE no
vde support no
netmap support no
Linux AIO support yes
ATTR/XATTR support yes
Install blobs yes
KVM support yes
HAX support no
HVF support no
WHPX support no
TCG support yes
TCG debug enabled no
TCG interpreter no
malloc trim support yes
RDMA support no
fdt support yes
membarrier no
preadv support yes
fdatasync yes
madvise yes
posix_madvise yes
posix_memalign yes
libcap-ng support yes
vhost-net support yes
vhost-crypto support yes
vhost-scsi support yes
vhost-vsock support yes
vhost-user support yes
Trace backends log
spice support no
rbd support yes
xfsctl support no
smartcard support yes
libusb yes
usb net redir yes
OpenGL support yes
OpenGL dmabufs yes
libiscsi support yes
libnfs support yes
build guest agent yes
QGA VSS support no
QGA w32 disk info no
QGA MSI support no
seccomp support yes
coroutine backend ucontext
coroutine pool yes
debug stack usage no
crypto afalg no
GlusterFS support yes
gcov gcov
gcov enabled no
TPM support yes
libssh2 support yes
TPM passthrough no
TPM emulator yes
QOM debugging yes
Live block migration yes
lzo support yes
snappy support yes
bzip2 support yes
NUMA host support no
libxml2 yes
tcmalloc support no
jemalloc support no
avx2 optimization no
replication support yes
VxHS block device no
capstone git
GEN aarch64-softmmu/config-devices.mak.tmp
GEN alpha-softmmu/config-devices.mak.tmp
GEN arm-softmmu/config-devices.mak.tmp
GEN cris-softmmu/config-devices.mak.tmp
GEN cris-softmmu/config-devices.mak
GEN arm-softmmu/config-devices.mak
GEN hppa-softmmu/config-devices.mak.tmp
GEN alpha-softmmu/config-devices.mak
GEN i386-softmmu/config-devices.mak.tmp
GEN aarch64-softmmu/config-devices.mak
GEN lm32-softmmu/config-devices.mak.tmp
GEN m68k-softmmu/config-devices.mak.tmp
GEN lm32-softmmu/config-devices.mak
GEN hppa-softmmu/config-devices.mak
GEN microblazeel-softmmu/config-devices.mak.tmp
GEN microblaze-softmmu/config-devices.mak.tmp
GEN m68k-softmmu/config-devices.mak
GEN i386-softmmu/config-devices.mak
GEN microblaze-softmmu/config-devices.mak
GEN mips64el-softmmu/config-devices.mak.tmp
GEN mips64-softmmu/config-devices.mak.tmp
GEN microblazeel-softmmu/config-devices.mak
GEN mipsel-softmmu/config-devices.mak.tmp
GEN mips-softmmu/config-devices.mak.tmp
GEN mips64-softmmu/config-devices.mak
GEN mips64el-softmmu/config-devices.mak
GEN mipsel-softmmu/config-devices.mak
GEN moxie-softmmu/config-devices.mak.tmp
GEN nios2-softmmu/config-devices.mak.tmp
GEN or1k-softmmu/config-devices.mak.tmp
GEN mips-softmmu/config-devices.mak
GEN moxie-softmmu/config-devices.mak
GEN ppc64-softmmu/config-devices.mak.tmp
GEN nios2-softmmu/config-devices.mak
GEN ppcemb-softmmu/config-devices.mak.tmp
GEN or1k-softmmu/config-devices.mak
GEN ppc-softmmu/config-devices.mak.tmp
GEN riscv32-softmmu/config-devices.mak.tmp
GEN riscv32-softmmu/config-devices.mak
GEN ppc64-softmmu/config-devices.mak
GEN ppcemb-softmmu/config-devices.mak
GEN riscv64-softmmu/config-devices.mak.tmp
GEN ppc-softmmu/config-devices.mak
GEN s390x-softmmu/config-devices.mak.tmp
GEN sh4eb-softmmu/config-devices.mak.tmp
GEN sh4-softmmu/config-devices.mak.tmp
GEN riscv64-softmmu/config-devices.mak
GEN s390x-softmmu/config-devices.mak
GEN sparc64-softmmu/config-devices.mak.tmp
GEN sparc-softmmu/config-devices.mak.tmp
GEN sh4-softmmu/config-devices.mak
GEN sh4eb-softmmu/config-devices.mak
GEN tricore-softmmu/config-devices.mak.tmp
GEN unicore32-softmmu/config-devices.mak.tmp
GEN sparc-softmmu/config-devices.mak
GEN x86_64-softmmu/config-devices.mak.tmp
GEN sparc64-softmmu/config-devices.mak
GEN tricore-softmmu/config-devices.mak
GEN xtensaeb-softmmu/config-devices.mak.tmp
GEN xtensa-softmmu/config-devices.mak.tmp
GEN unicore32-softmmu/config-devices.mak
GEN aarch64_be-linux-user/config-devices.mak.tmp
GEN xtensaeb-softmmu/config-devices.mak
GEN aarch64-linux-user/config-devices.mak.tmp
GEN aarch64_be-linux-user/config-devices.mak
GEN xtensa-softmmu/config-devices.mak
GEN x86_64-softmmu/config-devices.mak
GEN alpha-linux-user/config-devices.mak.tmp
GEN armeb-linux-user/config-devices.mak.tmp
GEN arm-linux-user/config-devices.mak.tmp
GEN aarch64-linux-user/config-devices.mak
GEN cris-linux-user/config-devices.mak.tmp
GEN alpha-linux-user/config-devices.mak
GEN armeb-linux-user/config-devices.mak
GEN arm-linux-user/config-devices.mak
GEN hppa-linux-user/config-devices.mak.tmp
GEN i386-linux-user/config-devices.mak.tmp
GEN m68k-linux-user/config-devices.mak.tmp
GEN cris-linux-user/config-devices.mak
GEN microblazeel-linux-user/config-devices.mak.tmp
GEN hppa-linux-user/config-devices.mak
GEN m68k-linux-user/config-devices.mak
GEN microblaze-linux-user/config-devices.mak.tmp
GEN i386-linux-user/config-devices.mak
GEN mips64el-linux-user/config-devices.mak.tmp
GEN microblazeel-linux-user/config-devices.mak
GEN mips64-linux-user/config-devices.mak.tmp
GEN microblaze-linux-user/config-devices.mak
GEN mipsel-linux-user/config-devices.mak.tmp
GEN mips64el-linux-user/config-devices.mak
GEN mips-linux-user/config-devices.mak.tmp
GEN mipsn32el-linux-user/config-devices.mak.tmp
GEN mipsel-linux-user/config-devices.mak
GEN mips64-linux-user/config-devices.mak
GEN mipsn32-linux-user/config-devices.mak.tmp
GEN mips-linux-user/config-devices.mak
GEN mipsn32el-linux-user/config-devices.mak
GEN nios2-linux-user/config-devices.mak.tmp
GEN or1k-linux-user/config-devices.mak.tmp
GEN ppc64abi32-linux-user/config-devices.mak.tmp
GEN mipsn32-linux-user/config-devices.mak
GEN ppc64le-linux-user/config-devices.mak.tmp
GEN nios2-linux-user/config-devices.mak
GEN ppc64abi32-linux-user/config-devices.mak
GEN or1k-linux-user/config-devices.mak
GEN ppc64-linux-user/config-devices.mak.tmp
GEN ppc-linux-user/config-devices.mak.tmp
GEN riscv32-linux-user/config-devices.mak.tmp
GEN ppc64le-linux-user/config-devices.mak
GEN ppc64-linux-user/config-devices.mak
GEN riscv64-linux-user/config-devices.mak.tmp
GEN ppc-linux-user/config-devices.mak
GEN s390x-linux-user/config-devices.mak.tmp
GEN riscv32-linux-user/config-devices.mak
GEN sh4eb-linux-user/config-devices.mak.tmp
GEN sh4-linux-user/config-devices.mak.tmp
GEN riscv64-linux-user/config-devices.mak
GEN s390x-linux-user/config-devices.mak
GEN sparc32plus-linux-user/config-devices.mak.tmp
GEN sparc64-linux-user/config-devices.mak.tmp
GEN sh4eb-linux-user/config-devices.mak
GEN sh4-linux-user/config-devices.mak
GEN sparc-linux-user/config-devices.mak.tmp
GEN tilegx-linux-user/config-devices.mak.tmp
GEN sparc32plus-linux-user/config-devices.mak
GEN sparc64-linux-user/config-devices.mak
GEN x86_64-linux-user/config-devices.mak.tmp
GEN xtensaeb-linux-user/config-devices.mak.tmp
GEN tilegx-linux-user/config-devices.mak
GEN sparc-linux-user/config-devices.mak
GEN xtensa-linux-user/config-devices.mak.tmp
GEN x86_64-linux-user/config-devices.mak
GEN config-host.h
GEN xtensa-linux-user/config-devices.mak
GEN xtensaeb-linux-user/config-devices.mak
GIT ui/keycodemapdb capstone
GEN qemu-options.def
GEN trace/generated-tcg-tracers.h
GEN qapi-gen
GEN trace/generated-helpers-wrappers.h
GEN trace/generated-helpers.h
GEN trace/generated-helpers.c
GEN module_block.h
GEN tests/test-qapi-gen
GEN trace-root.h
GEN util/trace.h
GEN crypto/trace.h
GEN io/trace.h
GEN migration/trace.h
GEN block/trace.h
GEN chardev/trace.h
GEN hw/block/trace.h
Submodule 'capstone' (git://git.qemu.org/capstone.git) registered for path 'capstone'
Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered for path 'ui/keycodemapdb'
GEN hw/block/dataplane/trace.h
GEN hw/char/trace.h
GEN hw/intc/trace.h
GEN hw/net/trace.h
GEN hw/rdma/trace.h
GEN hw/rdma/vmw/trace.h
Cloning into '/var/tmp/patchew-tester-tmp-zmws4k92/src/capstone'...
GEN hw/virtio/trace.h
GEN hw/audio/trace.h
GEN hw/misc/trace.h
GEN hw/misc/macio/trace.h
GEN hw/usb/trace.h
GEN hw/scsi/trace.h
GEN hw/nvram/trace.h
GEN hw/display/trace.h
GEN hw/input/trace.h
GEN hw/timer/trace.h
GEN hw/dma/trace.h
GEN hw/sparc/trace.h
GEN hw/sparc64/trace.h
GEN hw/sd/trace.h
GEN hw/isa/trace.h
GEN hw/mem/trace.h
GEN hw/i386/trace.h
GEN hw/i386/xen/trace.h
GEN hw/9pfs/trace.h
GEN hw/ppc/trace.h
GEN hw/pci/trace.h
GEN hw/pci-host/trace.h
GEN hw/s390x/trace.h
GEN hw/vfio/trace.h
GEN hw/acpi/trace.h
GEN hw/arm/trace.h
GEN hw/alpha/trace.h
GEN hw/hppa/trace.h
GEN hw/xen/trace.h
GEN hw/ide/trace.h
GEN hw/tpm/trace.h
GEN ui/trace.h
GEN audio/trace.h
GEN net/trace.h
GEN target/arm/trace.h
GEN target/i386/trace.h
GEN target/mips/trace.h
GEN target/sparc/trace.h
GEN target/s390x/trace.h
GEN target/ppc/trace.h
GEN qom/trace.h
GEN linux-user/trace.h
GEN qapi/trace.h
GEN accel/tcg/trace.h
GEN accel/kvm/trace.h
GEN nbd/trace.h
GEN scsi/trace.h
GEN trace-root.c
GEN util/trace.c
GEN crypto/trace.c
GEN io/trace.c
GEN migration/trace.c
GEN block/trace.c
GEN chardev/trace.c
GEN hw/block/trace.c
GEN hw/block/dataplane/trace.c
GEN hw/char/trace.c
GEN hw/intc/trace.c
GEN hw/net/trace.c
GEN hw/rdma/trace.c
GEN hw/rdma/vmw/trace.c
GEN hw/virtio/trace.c
GEN hw/audio/trace.c
GEN hw/misc/trace.c
GEN hw/misc/macio/trace.c
GEN hw/usb/trace.c
GEN hw/scsi/trace.c
GEN hw/nvram/trace.c
GEN hw/display/trace.c
GEN hw/input/trace.c
GEN hw/timer/trace.c
GEN hw/dma/trace.c
GEN hw/sparc/trace.c
GEN hw/sparc64/trace.c
GEN hw/sd/trace.c
GEN hw/isa/trace.c
GEN hw/mem/trace.c
GEN hw/i386/trace.c
GEN hw/i386/xen/trace.c
GEN hw/9pfs/trace.c
GEN hw/ppc/trace.c
GEN hw/pci/trace.c
GEN hw/pci-host/trace.c
GEN hw/s390x/trace.c
GEN hw/vfio/trace.c
GEN hw/acpi/trace.c
GEN hw/arm/trace.c
GEN hw/alpha/trace.c
GEN hw/hppa/trace.c
GEN hw/xen/trace.c
GEN hw/ide/trace.c
GEN hw/tpm/trace.c
GEN ui/trace.c
GEN audio/trace.c
GEN net/trace.c
GEN target/arm/trace.c
GEN target/i386/trace.c
GEN target/mips/trace.c
GEN target/sparc/trace.c
GEN target/s390x/trace.c
GEN target/ppc/trace.c
GEN qom/trace.c
GEN linux-user/trace.c
GEN qapi/trace.c
GEN accel/tcg/trace.c
GEN accel/kvm/trace.c
GEN nbd/trace.c
GEN scsi/trace.c
GEN config-all-devices.mak
Cloning into '/var/tmp/patchew-tester-tmp-zmws4k92/src/ui/keycodemapdb'...
GEN ui/input-keymap-linux-to-qcode.c
GEN ui/input-keymap-atset1-to-qcode.c
GEN ui/input-keymap-qcode-to-atset1.c
GEN ui/input-keymap-qcode-to-atset2.c
GEN ui/input-keymap-qcode-to-atset3.c
GEN ui/input-keymap-qcode-to-linux.c
GEN ui/input-keymap-qcode-to-qnum.c
CC cs.o
GEN ui/input-keymap-qcode-to-sun.c
GEN ui/input-keymap-qnum-to-qcode.c
GEN ui/input-keymap-usb-to-qcode.c
GEN ui/input-keymap-win32-to-qcode.c
CC utils.o
GEN ui/input-keymap-x11-to-qcode.c
CC SStream.o
CC MCInstrDesc.o
CC MCRegisterInfo.o
CC arch/ARM/ARMDisassembler.o
CC arch/ARM/ARMInstPrinter.o
CC arch/ARM/ARMMapping.o
GEN ui/input-keymap-xorgevdev-to-qcode.c
CC arch/ARM/ARMModule.o
GEN ui/input-keymap-xorgkbd-to-qcode.c
GEN ui/input-keymap-xorgxquartz-to-qcode.c
GEN ui/input-keymap-xorgxwin-to-qcode.c
CC arch/AArch64/AArch64BaseInfo.o
CC arch/AArch64/AArch64Disassembler.o
CC arch/AArch64/AArch64InstPrinter.o
CC arch/AArch64/AArch64Mapping.o
CC arch/AArch64/AArch64Module.o
CC arch/Mips/MipsDisassembler.o
CC arch/Mips/MipsInstPrinter.o
CC arch/Mips/MipsMapping.o
CC arch/Mips/MipsModule.o
CC arch/PowerPC/PPCDisassembler.o
CC arch/PowerPC/PPCInstPrinter.o
CC arch/PowerPC/PPCMapping.o
CC arch/PowerPC/PPCModule.o
CC arch/Sparc/SparcDisassembler.o
CC arch/Sparc/SparcInstPrinter.o
CC arch/Sparc/SparcMapping.o
CC arch/Sparc/SparcModule.o
CC arch/SystemZ/SystemZDisassembler.o
CC arch/SystemZ/SystemZInstPrinter.o
CC arch/SystemZ/SystemZMapping.o
CC arch/SystemZ/SystemZModule.o
CC arch/SystemZ/SystemZMCTargetDesc.o
CC arch/X86/X86DisassemblerDecoder.o
CC arch/X86/X86Disassembler.o
CC arch/X86/X86IntelInstPrinter.o
CC arch/X86/X86ATTInstPrinter.o
CC arch/X86/X86Mapping.o
CC arch/X86/X86Module.o
CC arch/XCore/XCoreDisassembler.o
CC arch/XCore/XCoreInstPrinter.o
CC arch/XCore/XCoreMapping.o
CC arch/XCore/XCoreModule.o
CC MCInst.o
AR libcapstone.a
ar: creating /var/tmp/patchew-tester-tmp-zmws4k92/src/build/capstone/libcapstone.a
CC tests/qemu-iotests/socket_scm_helper.o
GEN qemu-options.texi
GEN docs/version.texi
GEN qemu-monitor.texi
GEN qemu-img-cmds.texi
GEN qemu-img.1
GEN qemu-monitor-info.texi
GEN qemu-nbd.8
GEN qemu-ga.8
GEN qga/qapi-generated/qapi-gen
GEN docs/qemu-block-drivers.7
GEN fsdev/virtfs-proxy-helper.1
CC qapi/qapi-builtin-types.o
CC qapi/qapi-types.o
CC qapi/qapi-types-block-core.o
CC qapi/qapi-types-block.o
CC qapi/qapi-types-char.o
CC qapi/qapi-types-common.o
CC qapi/qapi-types-crypto.o
CC qapi/qapi-types-introspect.o
CC qapi/qapi-types-migration.o
CC qapi/qapi-types-misc.o
CC qapi/qapi-types-net.o
CC qapi/qapi-types-rocker.o
CC qapi/qapi-types-run-state.o
CC qapi/qapi-types-sockets.o
CC qapi/qapi-types-tpm.o
CC qapi/qapi-types-trace.o
CC qapi/qapi-types-transaction.o
CC qapi/qapi-types-ui.o
CC qapi/qapi-builtin-visit.o
CC qapi/qapi-visit.o
CC qapi/qapi-visit-block-core.o
CC qapi/qapi-visit-block.o
CC qapi/qapi-visit-char.o
CC qapi/qapi-visit-common.o
CC qapi/qapi-visit-crypto.o
CC qapi/qapi-visit-introspect.o
CC qapi/qapi-visit-migration.o
CC qapi/qapi-visit-misc.o
CC qapi/qapi-visit-net.o
CC qapi/qapi-visit-rocker.o
CC qapi/qapi-visit-run-state.o
CC qapi/qapi-visit-sockets.o
CC qapi/qapi-visit-tpm.o
CC qapi/qapi-visit-trace.o
CC qapi/qapi-visit-transaction.o
CC qapi/qapi-visit-ui.o
CC qapi/qapi-events.o
CC qapi/qapi-events-block-core.o
CC qapi/qapi-events-block.o
CC qapi/qapi-events-char.o
CC qapi/qapi-events-common.o
CC qapi/qapi-events-crypto.o
CC qapi/qapi-events-introspect.o
CC qapi/qapi-events-migration.o
CC qapi/qapi-events-misc.o
CC qapi/qapi-events-net.o
CC qapi/qapi-events-rocker.o
CC qapi/qapi-events-run-state.o
CC qapi/qapi-events-sockets.o
CC qapi/qapi-events-tpm.o
CC qapi/qapi-events-trace.o
CC qapi/qapi-events-transaction.o
CC qapi/qapi-events-ui.o
CC qapi/qapi-introspect.o
CC qapi/qapi-visit-core.o
CC qapi/qapi-dealloc-visitor.o
In file included from /var/tmp/patchew-tester-tmp-zmws4k92/src/qapi/qapi-visit-core.c:21:0:
/var/tmp/patchew-tester-tmp-zmws4k92/src/build/qapi/trace.h:7:10: fatal error: trace/control.h: No such file or directory
#include "trace/control.h"
^~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [/var/tmp/patchew-tester-tmp-zmws4k92/src/rules.mak:66: qapi/qapi-visit-core.o] Error 1
make: *** Waiting for unfinished jobs....
=== OUTPUT END ===
Test command exited with code: 2
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 00/67] include path cleanup
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (68 preceding siblings ...)
2018-05-03 20:58 ` no-reply
@ 2018-05-03 21:00 ` no-reply
2018-05-03 21:01 ` no-reply
2018-05-09 10:39 ` Paolo Bonzini
71 siblings, 0 replies; 144+ messages in thread
From: no-reply @ 2018-05-03 21:00 UTC (permalink / raw)
To: mst; +Cc: famz, qemu-devel, kwolf, peter.maydell
Hi,
This series failed docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 1525376963-79623-1-git-send-email-mst@redhat.com
Subject: [Qemu-devel] [PATCH 00/67] include path cleanup
=== TEST SCRIPT BEGIN ===
#!/bin/bash
set -e
git submodule update --init dtc
# Let docker tests dump environment info
export SHOW_ENV=1
export J=8
time make docker-test-mingw@fedora
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
dda9647d70 make: simplify source include path
b158a719f3 linux-user: add include directory header
b2ae9844c1 tcg: use include "translate-all.h" consistently
3613ec1453 target/s390x: add include directory header
d00910afb1 hw/s390x: use target headers explicitly
194f6f9974 kvm: use include "kvm_ppc.h" consistently
256581c1be hw/net: add include directory header
440e14b88a hw/s390x: add include directory headers
84a81cbde5 hw/ppc: add target headers explicitly
87bebef613 target/riscv: add include directory header
d02cccc221 kvm: use include "kvm_i386.h" consistently
f9543ea9d8 tcg: use include "tcg-gvec-desc.h.h" consistently
52a7685f6f amd_iommu: add include directory header
18b966a8fe amd_iommu: add include directory header
1f841bece5 target/ppc: add include directory headers
3d6945bd6b target/arm: add include directory headers
863bb03c5a hyperv: add include directory header
1011069886 hmp: add include directory header
5f1be83b0f kvm_XXX: add include directory headers
a4f45a0012 virtio-pci: add include directory header
8e2f2e471e tcg-op: use include "tcg.h" consistently
d9c41e578e cpu-qom: add include directory headers
ce17c41200 tcg: add include directory headers
1690189b5e tcg-ldst.inc.c: replace command line flags with preprocessor
5143bc145e translate-all: add include directory header
cd074d2b2c tcg: use include "tcg.h" consistently
3418bf3073 tcg-pool.inc.c: replace command line flags with preprocessor
653e93fefe trace: add include directory headers
76e207bfb1 target: replace command line flags with preprocessor
81d9592c44 helper: replace command line flags with preprocessor
287a3a85aa tcg: add include directory headers
0912dbb70e migration: add include directory headers
e234a2f0a3 hw/usb: add include directory header
0855ad7432 hw/ppc: add include directory headers
bff5bf26d6 hw/net: add include directory header
523897142f ui: add include directory header
a86a80bd28 target/cris: add include directory header
bc35b6c9a9 audio: add include directory header
c5c49795ca fsdev: add include directory headers
2184da2487 9pfs: add include directory headers
cebd0e6d5d replication: add include directory header
7fd6a43e9c cpu: replace command line flags with preprocessor
8d5900280a arch_init: sort architectures
5f3be2f16f net: add include directory headers
26e688947b slirp: add include directory headers
677b5a5222 ui: use local path for local headers
a2e9d7b6d0 trace: use local path for local headers
ab8e11dbb1 tests: relative include for child directory
2505961862 xtensa: relative include for parent directory
0561f465a9 qga: use local path for local headers
f02e149685 colo: use local path for local headers
f63ff1c1e5 migration: use local path for local headers
0e2942e37a usb: use local path for local headers
a17070acf1 sd: fix up include
804ef03fb9 vhost-scsi: drop an unused include
eded79b7c5 ppc: use local path for local headers
e352ed36c5 rocker: drop an unused include
303a3d4072 e1000e: use local path for local headers
4df0916e5c ioapic: fix up includes
4f533ce25a ide: use local path for local headers
3ad03c679d display: use local path for local headers
e56cb2ab7c trace: use local path for local headers
711e6fe8f8 migration: drop an unused include, add a used one
fdbc0e45c0 s390x: drop an unused include
abd9bbe5ea hppa: use local path for local headers
6ce2ed96c7 crypto: use local path for local headers
d5cd88766c block: use local path for local headers
=== OUTPUT BEGIN ===
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into '/var/tmp/patchew-tester-tmp-vhw2wwer/src/dtc'...
Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42'
BUILD fedora
make[1]: Entering directory '/var/tmp/patchew-tester-tmp-vhw2wwer/src'
GEN /var/tmp/patchew-tester-tmp-vhw2wwer/src/docker-src.2018-05-03-16.58.41.25302/qemu.tar
Cloning into '/var/tmp/patchew-tester-tmp-vhw2wwer/src/docker-src.2018-05-03-16.58.41.25302/qemu.tar.vroot'...
done.
Checking out files: 47% (2915/6190)
Checking out files: 48% (2972/6190)
Checking out files: 49% (3034/6190)
Checking out files: 50% (3095/6190)
Checking out files: 51% (3157/6190)
Checking out files: 52% (3219/6190)
Checking out files: 53% (3281/6190)
Checking out files: 54% (3343/6190)
Checking out files: 55% (3405/6190)
Checking out files: 56% (3467/6190)
Checking out files: 57% (3529/6190)
Checking out files: 58% (3591/6190)
Checking out files: 59% (3653/6190)
Checking out files: 60% (3714/6190)
Checking out files: 61% (3776/6190)
Checking out files: 62% (3838/6190)
Checking out files: 63% (3900/6190)
Checking out files: 64% (3962/6190)
Checking out files: 65% (4024/6190)
Checking out files: 66% (4086/6190)
Checking out files: 67% (4148/6190)
Checking out files: 68% (4210/6190)
Checking out files: 69% (4272/6190)
Checking out files: 70% (4333/6190)
Checking out files: 71% (4395/6190)
Checking out files: 72% (4457/6190)
Checking out files: 73% (4519/6190)
Checking out files: 74% (4581/6190)
Checking out files: 75% (4643/6190)
Checking out files: 76% (4705/6190)
Checking out files: 77% (4767/6190)
Checking out files: 78% (4829/6190)
Checking out files: 79% (4891/6190)
Checking out files: 80% (4952/6190)
Checking out files: 81% (5014/6190)
Checking out files: 82% (5076/6190)
Checking out files: 83% (5138/6190)
Checking out files: 84% (5200/6190)
Checking out files: 85% (5262/6190)
Checking out files: 86% (5324/6190)
Checking out files: 87% (5386/6190)
Checking out files: 88% (5448/6190)
Checking out files: 89% (5510/6190)
Checking out files: 90% (5571/6190)
Checking out files: 91% (5633/6190)
Checking out files: 92% (5695/6190)
Checking out files: 93% (5757/6190)
Checking out files: 94% (5819/6190)
Checking out files: 95% (5881/6190)
Checking out files: 96% (5943/6190)
Checking out files: 97% (6005/6190)
Checking out files: 98% (6067/6190)
Checking out files: 99% (6129/6190)
Checking out files: 100% (6190/6190)
Checking out files: 100% (6190/6190), done.
Your branch is up-to-date with 'origin/test'.
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into '/var/tmp/patchew-tester-tmp-vhw2wwer/src/docker-src.2018-05-03-16.58.41.25302/qemu.tar.vroot/dtc'...
Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42'
Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into '/var/tmp/patchew-tester-tmp-vhw2wwer/src/docker-src.2018-05-03-16.58.41.25302/qemu.tar.vroot/ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
COPY RUNNER
RUN test-mingw in qemu:fedora
Packages installed:
PyYAML-3.12-5.fc27.x86_64
SDL2-devel-2.0.7-2.fc27.x86_64
bc-1.07.1-3.fc27.x86_64
bison-3.0.4-8.fc27.x86_64
bluez-libs-devel-5.48-3.fc27.x86_64
brlapi-devel-0.6.6-8.fc27.x86_64
bzip2-1.0.6-24.fc27.x86_64
bzip2-devel-1.0.6-24.fc27.x86_64
ccache-3.3.6-1.fc27.x86_64
clang-5.0.1-5.fc27.x86_64
device-mapper-multipath-devel-0.7.1-9.git847cc43.fc27.x86_64
findutils-4.6.0-16.fc27.x86_64
flex-2.6.1-5.fc27.x86_64
gcc-7.3.1-5.fc27.x86_64
gcc-c++-7.3.1-5.fc27.x86_64
gettext-0.19.8.1-12.fc27.x86_64
git-2.14.3-3.fc27.x86_64
glib2-devel-2.54.3-2.fc27.x86_64
glusterfs-api-devel-3.12.7-1.fc27.x86_64
gnutls-devel-3.5.18-2.fc27.x86_64
gtk3-devel-3.22.26-2.fc27.x86_64
hostname-3.18-4.fc27.x86_64
libaio-devel-0.3.110-9.fc27.x86_64
libasan-7.3.1-5.fc27.x86_64
libattr-devel-2.4.47-21.fc27.x86_64
libcap-devel-2.25-7.fc27.x86_64
libcap-ng-devel-0.7.8-5.fc27.x86_64
libcurl-devel-7.55.1-10.fc27.x86_64
libfdt-devel-1.4.6-1.fc27.x86_64
libpng-devel-1.6.31-1.fc27.x86_64
librbd-devel-12.2.4-1.fc27.x86_64
libssh2-devel-1.8.0-5.fc27.x86_64
libubsan-7.3.1-5.fc27.x86_64
libusbx-devel-1.0.21-4.fc27.x86_64
libxml2-devel-2.9.7-1.fc27.x86_64
llvm-5.0.1-6.fc27.x86_64
lzo-devel-2.08-11.fc27.x86_64
make-4.2.1-4.fc27.x86_64
mingw32-SDL-1.2.15-9.fc27.noarch
mingw32-bzip2-1.0.6-9.fc27.noarch
mingw32-curl-7.54.1-2.fc27.noarch
mingw32-glib2-2.54.1-1.fc27.noarch
mingw32-gmp-6.1.2-2.fc27.noarch
mingw32-gnutls-3.5.13-2.fc27.noarch
mingw32-gtk2-2.24.31-4.fc27.noarch
mingw32-gtk3-3.22.16-1.fc27.noarch
mingw32-libjpeg-turbo-1.5.1-3.fc27.noarch
mingw32-libpng-1.6.29-2.fc27.noarch
mingw32-libssh2-1.8.0-3.fc27.noarch
mingw32-libtasn1-4.13-1.fc27.noarch
mingw32-nettle-3.3-3.fc27.noarch
mingw32-pixman-0.34.0-3.fc27.noarch
mingw32-pkg-config-0.28-9.fc27.x86_64
mingw64-SDL-1.2.15-9.fc27.noarch
mingw64-bzip2-1.0.6-9.fc27.noarch
mingw64-curl-7.54.1-2.fc27.noarch
mingw64-glib2-2.54.1-1.fc27.noarch
mingw64-gmp-6.1.2-2.fc27.noarch
mingw64-gnutls-3.5.13-2.fc27.noarch
mingw64-gtk2-2.24.31-4.fc27.noarch
mingw64-gtk3-3.22.16-1.fc27.noarch
mingw64-libjpeg-turbo-1.5.1-3.fc27.noarch
mingw64-libpng-1.6.29-2.fc27.noarch
mingw64-libssh2-1.8.0-3.fc27.noarch
mingw64-libtasn1-4.13-1.fc27.noarch
mingw64-nettle-3.3-3.fc27.noarch
mingw64-pixman-0.34.0-3.fc27.noarch
mingw64-pkg-config-0.28-9.fc27.x86_64
ncurses-devel-6.0-13.20170722.fc27.x86_64
nettle-devel-3.4-1.fc27.x86_64
nss-devel-3.36.0-1.0.fc27.x86_64
numactl-devel-2.0.11-5.fc27.x86_64
package libjpeg-devel is not installed
perl-5.26.1-403.fc27.x86_64
pixman-devel-0.34.0-4.fc27.x86_64
python3-3.6.2-13.fc27.x86_64
snappy-devel-1.1.4-5.fc27.x86_64
sparse-0.5.1-2.fc27.x86_64
spice-server-devel-0.14.0-1.fc27.x86_64
systemtap-sdt-devel-3.2-3.fc27.x86_64
tar-1.29-7.fc27.x86_64
usbredir-devel-0.7.1-5.fc27.x86_64
virglrenderer-devel-0.6.0-3.20170210git76b3da97b.fc27.x86_64
vte3-devel-0.36.5-5.fc27.x86_64
which-2.21-4.fc27.x86_64
xen-devel-4.9.1-5.fc27.x86_64
zlib-devel-1.2.11-4.fc27.x86_64
Environment variables:
TARGET_LIST=
PACKAGES=ccache gettext git tar PyYAML sparse flex bison python3 bzip2 hostname gcc gcc-c++ llvm clang make perl which bc findutils glib2-devel libaio-devel pixman-devel zlib-devel libfdt-devel libasan libubsan bluez-libs-devel brlapi-devel bzip2-devel device-mapper-multipath-devel glusterfs-api-devel gnutls-devel gtk3-devel libattr-devel libcap-devel libcap-ng-devel libcurl-devel libjpeg-devel libpng-devel librbd-devel libssh2-devel libusbx-devel libxml2-devel lzo-devel ncurses-devel nettle-devel nss-devel numactl-devel SDL2-devel snappy-devel spice-server-devel systemtap-sdt-devel usbredir-devel virglrenderer-devel vte3-devel xen-devel mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL mingw32-pkg-config mingw32-gtk2 mingw32-gtk3 mingw32-gnutls mingw32-nettle mingw32-libtasn1 mingw32-libjpeg-turbo mingw32-libpng mingw32-curl mingw32-libssh2 mingw32-bzip2 mingw64-pixman mingw64-glib2 mingw64-gmp mingw64-SDL mingw64-pkg-config mingw64-gtk2 mingw64-gtk3 mingw64-gnutls mingw64-nettle mingw64-libtasn1 mingw64-libjpeg-turbo mingw64-libpng mingw64-curl mingw64-libssh2 mingw64-bzip2
J=8
V=
HOSTNAME=c28c4092d538
DEBUG=
SHOW_ENV=1
PWD=/
HOME=/root
CCACHE_DIR=/var/tmp/ccache
DISTTAG=f27container
QEMU_CONFIGURE_OPTS=--python=/usr/bin/python3
FGC=f27
TEST_DIR=/tmp/qemu-test
SHLVL=1
FEATURES=mingw clang pyyaml asan dtc
PATH=/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
MAKEFLAGS= -j8
EXTRA_CONFIGURE_OPTS=
_=/usr/bin/env
Configure options:
--enable-werror --target-list=x86_64-softmmu,aarch64-softmmu --prefix=/tmp/qemu-test/install --python=/usr/bin/python3 --cross-prefix=x86_64-w64-mingw32- --enable-trace-backends=simple --enable-gnutls --enable-nettle --enable-curl --enable-vnc --enable-bzip2 --enable-guest-agent --with-sdlabi=1.2 --with-gtkabi=2.0
Install prefix /tmp/qemu-test/install
BIOS directory /tmp/qemu-test/install
firmware path /tmp/qemu-test/install/share/qemu-firmware
binary directory /tmp/qemu-test/install
library directory /tmp/qemu-test/install/lib
module directory /tmp/qemu-test/install/lib
libexec directory /tmp/qemu-test/install/libexec
include directory /tmp/qemu-test/install/include
config directory /tmp/qemu-test/install
local state directory queried at runtime
Windows SDK no
Source path /tmp/qemu-test/src
GIT binary git
GIT submodules
C compiler x86_64-w64-mingw32-gcc
Host C compiler cc
C++ compiler x86_64-w64-mingw32-g++
Objective-C compiler clang
ARFLAGS rv
CFLAGS -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g
QEMU_CFLAGS -I/usr/x86_64-w64-mingw32/sys-root/mingw/include/pixman-1 -I$(SRC_PATH)/dtc/libfdt -Werror -DHAS_LIBSSH2_SFTP_FSYNC -mms-bitfields -I/usr/x86_64-w64-mingw32/sys-root/mingw/include/glib-2.0 -I/usr/x86_64-w64-mingw32/sys-root/mingw/lib/glib-2.0/include -I/usr/x86_64-w64-mingw32/sys-root/mingw/include -m64 -mcx16 -mthreads -D__USE_MINGW_ANSI_STDIO=1 -DWIN32_LEAN_AND_MEAN -DWINVER=0x501 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wexpansion-to-defined -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-strong -I/usr/x86_64-w64-mingw32/sys-root/mingw/include -I/usr/x86_64-w64-mingw32/sys-root/mingw/include/p11-kit-1 -I/usr/x86_64-w64-mingw32/sys-root/mingw/include -I/usr/x86_64-w64-mingw32/sys-root/mingw/include -I/usr/x86_64-w64-mingw32/sys-root/mingw/include/libpng16
LDFLAGS -Wl,--nxcompat -Wl,--no-seh -Wl,--dynamicbase -Wl,--warn-common -m64 -g
make make
install install
python /usr/bin/python3 -B
smbd /usr/sbin/smbd
module support no
host CPU x86_64
host big endian no
target list x86_64-softmmu aarch64-softmmu
gprof enabled no
sparse enabled no
strip binaries yes
profiler no
static build no
SDL support yes (1.2.15)
GTK support yes (2.24.31)
GTK GL support no
VTE support no
TLS priority NORMAL
GNUTLS support yes
GNUTLS rnd yes
libgcrypt no
libgcrypt kdf no
nettle yes (3.3)
nettle kdf yes
libtasn1 yes
curses support no
virgl support no
curl support yes
mingw32 support yes
Audio drivers dsound
Block whitelist (rw)
Block whitelist (ro)
VirtFS support no
Multipath support no
VNC support yes
VNC SASL support no
VNC JPEG support yes
VNC PNG support yes
xen support no
brlapi support no
bluez support no
Documentation no
PIE no
vde support no
netmap support no
Linux AIO support no
ATTR/XATTR support no
Install blobs yes
KVM support no
HAX support yes
HVF support no
WHPX support no
TCG support yes
TCG debug enabled no
TCG interpreter no
malloc trim support no
RDMA support no
fdt support yes
membarrier no
preadv support no
fdatasync no
madvise no
posix_madvise no
posix_memalign no
libcap-ng support no
vhost-net support no
vhost-crypto support no
vhost-scsi support no
vhost-vsock support no
vhost-user support no
Trace backends simple
Trace output file trace-<pid>
spice support no
rbd support no
xfsctl support no
smartcard support no
libusb no
usb net redir no
OpenGL support no
OpenGL dmabufs no
libiscsi support no
libnfs support no
build guest agent yes
QGA VSS support no
QGA w32 disk info yes
QGA MSI support no
seccomp support no
coroutine backend win32
coroutine pool yes
debug stack usage no
crypto afalg no
GlusterFS support no
gcov gcov
gcov enabled no
TPM support yes
libssh2 support yes
TPM passthrough no
TPM emulator no
QOM debugging yes
Live block migration yes
lzo support no
snappy support no
bzip2 support yes
NUMA host support no
libxml2 no
tcmalloc support no
jemalloc support no
avx2 optimization yes
replication support yes
VxHS block device no
capstone no
WARNING: Use of GTK 2.0 is deprecated and will be removed in
WARNING: future releases. Please switch to using GTK 3.0
WARNING: Use of SDL 1.2 is deprecated and will be removed in
WARNING: future releases. Please switch to using SDL 2.0
mkdir -p dtc/libfdt
mkdir -p dtc/tests
GEN aarch64-softmmu/config-devices.mak.tmp
GEN x86_64-softmmu/config-devices.mak.tmp
GEN config-host.h
GEN qemu-options.def
GEN trace/generated-tcg-tracers.h
GEN qapi-gen
GEN trace/generated-helpers-wrappers.h
GEN trace/generated-helpers.h
GEN trace/generated-helpers.c
GEN x86_64-softmmu/config-devices.mak
GEN aarch64-softmmu/config-devices.mak
GEN module_block.h
GEN ui/input-keymap-linux-to-qcode.c
GEN ui/input-keymap-atset1-to-qcode.c
GEN ui/input-keymap-qcode-to-atset1.c
GEN ui/input-keymap-qcode-to-atset2.c
GEN ui/input-keymap-qcode-to-atset3.c
GEN ui/input-keymap-qcode-to-linux.c
GEN ui/input-keymap-qcode-to-qnum.c
GEN ui/input-keymap-qcode-to-sun.c
GEN ui/input-keymap-usb-to-qcode.c
GEN ui/input-keymap-qnum-to-qcode.c
GEN ui/input-keymap-win32-to-qcode.c
GEN ui/input-keymap-x11-to-qcode.c
GEN ui/input-keymap-xorgevdev-to-qcode.c
GEN ui/input-keymap-xorgxquartz-to-qcode.c
GEN ui/input-keymap-xorgkbd-to-qcode.c
GEN ui/input-keymap-xorgxwin-to-qcode.c
GEN tests/test-qapi-gen
GEN trace-root.h
GEN util/trace.h
GEN crypto/trace.h
GEN io/trace.h
GEN migration/trace.h
GEN block/trace.h
GEN chardev/trace.h
GEN hw/block/trace.h
GEN hw/block/dataplane/trace.h
GEN hw/char/trace.h
GEN hw/intc/trace.h
GEN hw/net/trace.h
GEN hw/rdma/trace.h
GEN hw/rdma/vmw/trace.h
GEN hw/virtio/trace.h
GEN hw/audio/trace.h
GEN hw/misc/trace.h
GEN hw/misc/macio/trace.h
GEN hw/usb/trace.h
GEN hw/scsi/trace.h
GEN hw/nvram/trace.h
GEN hw/display/trace.h
GEN hw/input/trace.h
GEN hw/timer/trace.h
GEN hw/dma/trace.h
GEN hw/sparc/trace.h
GEN hw/sparc64/trace.h
GEN hw/sd/trace.h
GEN hw/isa/trace.h
GEN hw/mem/trace.h
GEN hw/i386/trace.h
GEN hw/i386/xen/trace.h
GEN hw/9pfs/trace.h
GEN hw/ppc/trace.h
GEN hw/pci/trace.h
GEN hw/pci-host/trace.h
GEN hw/s390x/trace.h
GEN hw/vfio/trace.h
GEN hw/acpi/trace.h
GEN hw/arm/trace.h
GEN hw/alpha/trace.h
GEN hw/hppa/trace.h
GEN hw/xen/trace.h
GEN hw/ide/trace.h
GEN hw/tpm/trace.h
GEN ui/trace.h
GEN audio/trace.h
GEN net/trace.h
GEN target/arm/trace.h
GEN target/i386/trace.h
GEN target/mips/trace.h
GEN target/sparc/trace.h
GEN target/s390x/trace.h
GEN target/ppc/trace.h
GEN qom/trace.h
GEN linux-user/trace.h
GEN qapi/trace.h
GEN accel/tcg/trace.h
GEN accel/kvm/trace.h
GEN nbd/trace.h
GEN scsi/trace.h
GEN trace-root.c
GEN util/trace.c
GEN crypto/trace.c
GEN io/trace.c
GEN migration/trace.c
GEN block/trace.c
GEN chardev/trace.c
GEN hw/block/trace.c
GEN hw/block/dataplane/trace.c
GEN hw/char/trace.c
GEN hw/intc/trace.c
GEN hw/net/trace.c
GEN hw/rdma/trace.c
GEN hw/rdma/vmw/trace.c
GEN hw/virtio/trace.c
GEN hw/audio/trace.c
GEN hw/misc/trace.c
GEN hw/misc/macio/trace.c
GEN hw/usb/trace.c
GEN hw/scsi/trace.c
GEN hw/nvram/trace.c
GEN hw/display/trace.c
GEN hw/input/trace.c
GEN hw/timer/trace.c
GEN hw/dma/trace.c
GEN hw/sparc/trace.c
GEN hw/sparc64/trace.c
GEN hw/sd/trace.c
GEN hw/isa/trace.c
GEN hw/mem/trace.c
GEN hw/i386/trace.c
GEN hw/i386/xen/trace.c
GEN hw/9pfs/trace.c
GEN hw/ppc/trace.c
GEN hw/pci/trace.c
GEN hw/pci-host/trace.c
GEN hw/s390x/trace.c
GEN hw/vfio/trace.c
GEN hw/acpi/trace.c
GEN hw/arm/trace.c
GEN hw/alpha/trace.c
GEN hw/hppa/trace.c
GEN hw/xen/trace.c
GEN hw/ide/trace.c
GEN hw/tpm/trace.c
GEN ui/trace.c
GEN audio/trace.c
GEN net/trace.c
GEN target/arm/trace.c
GEN target/i386/trace.c
GEN target/mips/trace.c
GEN target/sparc/trace.c
GEN target/s390x/trace.c
GEN target/ppc/trace.c
GEN qom/trace.c
GEN linux-user/trace.c
GEN qapi/trace.c
GEN accel/tcg/trace.c
GEN accel/kvm/trace.c
GEN nbd/trace.c
GEN scsi/trace.c
GEN config-all-devices.mak
DEP /tmp/qemu-test/src/dtc/tests/dumptrees.c
DEP /tmp/qemu-test/src/dtc/tests/trees.S
DEP /tmp/qemu-test/src/dtc/tests/testutils.c
DEP /tmp/qemu-test/src/dtc/tests/value-labels.c
DEP /tmp/qemu-test/src/dtc/tests/asm_tree_dump.c
DEP /tmp/qemu-test/src/dtc/tests/truncated_property.c
DEP /tmp/qemu-test/src/dtc/tests/check_path.c
DEP /tmp/qemu-test/src/dtc/tests/overlay.c
DEP /tmp/qemu-test/src/dtc/tests/overlay_bad_fixup.c
DEP /tmp/qemu-test/src/dtc/tests/subnode_iterate.c
DEP /tmp/qemu-test/src/dtc/tests/property_iterate.c
DEP /tmp/qemu-test/src/dtc/tests/integer-expressions.c
DEP /tmp/qemu-test/src/dtc/tests/utilfdt_test.c
DEP /tmp/qemu-test/src/dtc/tests/path_offset_aliases.c
DEP /tmp/qemu-test/src/dtc/tests/add_subnode_with_nops.c
DEP /tmp/qemu-test/src/dtc/tests/dtbs_equal_unordered.c
DEP /tmp/qemu-test/src/dtc/tests/dtb_reverse.c
DEP /tmp/qemu-test/src/dtc/tests/dtbs_equal_ordered.c
DEP /tmp/qemu-test/src/dtc/tests/extra-terminating-null.c
DEP /tmp/qemu-test/src/dtc/tests/incbin.c
DEP /tmp/qemu-test/src/dtc/tests/boot-cpuid.c
DEP /tmp/qemu-test/src/dtc/tests/phandle_format.c
DEP /tmp/qemu-test/src/dtc/tests/path-references.c
DEP /tmp/qemu-test/src/dtc/tests/references.c
DEP /tmp/qemu-test/src/dtc/tests/string_escapes.c
DEP /tmp/qemu-test/src/dtc/tests/propname_escapes.c
DEP /tmp/qemu-test/src/dtc/tests/appendprop1.c
DEP /tmp/qemu-test/src/dtc/tests/appendprop2.c
DEP /tmp/qemu-test/src/dtc/tests/del_node.c
DEP /tmp/qemu-test/src/dtc/tests/del_property.c
DEP /tmp/qemu-test/src/dtc/tests/setprop.c
DEP /tmp/qemu-test/src/dtc/tests/set_name.c
DEP /tmp/qemu-test/src/dtc/tests/rw_tree1.c
DEP /tmp/qemu-test/src/dtc/tests/open_pack.c
DEP /tmp/qemu-test/src/dtc/tests/nopulate.c
DEP /tmp/qemu-test/src/dtc/tests/mangle-layout.c
DEP /tmp/qemu-test/src/dtc/tests/move_and_save.c
DEP /tmp/qemu-test/src/dtc/tests/sw_tree1.c
DEP /tmp/qemu-test/src/dtc/tests/nop_node.c
DEP /tmp/qemu-test/src/dtc/tests/nop_property.c
DEP /tmp/qemu-test/src/dtc/tests/setprop_inplace.c
DEP /tmp/qemu-test/src/dtc/tests/stringlist.c
DEP /tmp/qemu-test/src/dtc/tests/addr_size_cells.c
DEP /tmp/qemu-test/src/dtc/tests/notfound.c
DEP /tmp/qemu-test/src/dtc/tests/sized_cells.c
DEP /tmp/qemu-test/src/dtc/tests/char_literal.c
DEP /tmp/qemu-test/src/dtc/tests/get_alias.c
DEP /tmp/qemu-test/src/dtc/tests/node_offset_by_compatible.c
DEP /tmp/qemu-test/src/dtc/tests/node_check_compatible.c
DEP /tmp/qemu-test/src/dtc/tests/node_offset_by_phandle.c
DEP /tmp/qemu-test/src/dtc/tests/node_offset_by_prop_value.c
DEP /tmp/qemu-test/src/dtc/tests/parent_offset.c
DEP /tmp/qemu-test/src/dtc/tests/supernode_atdepth_offset.c
DEP /tmp/qemu-test/src/dtc/tests/get_path.c
DEP /tmp/qemu-test/src/dtc/tests/getprop.c
DEP /tmp/qemu-test/src/dtc/tests/get_phandle.c
DEP /tmp/qemu-test/src/dtc/tests/get_name.c
DEP /tmp/qemu-test/src/dtc/tests/subnode_offset.c
DEP /tmp/qemu-test/src/dtc/tests/path_offset.c
DEP /tmp/qemu-test/src/dtc/tests/find_property.c
DEP /tmp/qemu-test/src/dtc/tests/root_node.c
DEP /tmp/qemu-test/src/dtc/tests/get_mem_rsv.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_overlay.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_addresses.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_empty_tree.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_strerror.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_rw.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_sw.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_wip.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_ro.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt.c
DEP /tmp/qemu-test/src/dtc/util.c
DEP /tmp/qemu-test/src/dtc/fdtoverlay.c
DEP /tmp/qemu-test/src/dtc/fdtput.c
DEP /tmp/qemu-test/src/dtc/fdtdump.c
DEP /tmp/qemu-test/src/dtc/fdtget.c
LEX convert-dtsv0-lexer.lex.c
LEX dtc-lexer.lex.c
DEP /tmp/qemu-test/src/dtc/treesource.c
DEP /tmp/qemu-test/src/dtc/srcpos.c
BISON dtc-parser.tab.c
DEP /tmp/qemu-test/src/dtc/fstree.c
DEP /tmp/qemu-test/src/dtc/livetree.c
DEP /tmp/qemu-test/src/dtc/flattree.c
DEP /tmp/qemu-test/src/dtc/dtc.c
DEP /tmp/qemu-test/src/dtc/data.c
DEP /tmp/qemu-test/src/dtc/checks.c
DEP convert-dtsv0-lexer.lex.c
DEP dtc-parser.tab.c
DEP dtc-lexer.lex.c
CHK version_gen.h
UPD version_gen.h
DEP /tmp/qemu-test/src/dtc/util.c
CC libfdt/fdt.o
CC libfdt/fdt_ro.o
CC libfdt/fdt_wip.o
CC libfdt/fdt_strerror.o
CC libfdt/fdt_sw.o
CC libfdt/fdt_rw.o
CC libfdt/fdt_addresses.o
CC libfdt/fdt_empty_tree.o
CC libfdt/fdt_overlay.o
AR libfdt/libfdt.a
x86_64-w64-mingw32-ar: creating libfdt/libfdt.a
a - libfdt/fdt.o
a - libfdt/fdt_ro.o
a - libfdt/fdt_wip.o
a - libfdt/fdt_sw.o
a - libfdt/fdt_rw.o
a - libfdt/fdt_strerror.o
a - libfdt/fdt_empty_tree.o
a - libfdt/fdt_addresses.o
a - libfdt/fdt_overlay.o
RC version.o
mkdir -p dtc/libfdt
mkdir -p dtc/tests
GEN qga/qapi-generated/qapi-gen
CC qapi/qapi-builtin-types.o
CC qapi/qapi-types.o
CC qapi/qapi-types-block.o
CC qapi/qapi-types-common.o
CC qapi/qapi-types-char.o
CC qapi/qapi-types-crypto.o
CC qapi/qapi-types-block-core.o
CC qapi/qapi-types-introspect.o
CC qapi/qapi-types-migration.o
CC qapi/qapi-types-misc.o
CC qapi/qapi-types-net.o
CC qapi/qapi-types-rocker.o
CC qapi/qapi-types-run-state.o
CC qapi/qapi-types-sockets.o
CC qapi/qapi-types-tpm.o
CC qapi/qapi-types-trace.o
CC qapi/qapi-types-transaction.o
CC qapi/qapi-types-ui.o
CC qapi/qapi-builtin-visit.o
CC qapi/qapi-visit.o
CC qapi/qapi-visit-block-core.o
CC qapi/qapi-visit-block.o
CC qapi/qapi-visit-char.o
CC qapi/qapi-visit-common.o
CC qapi/qapi-visit-crypto.o
CC qapi/qapi-visit-introspect.o
CC qapi/qapi-visit-migration.o
CC qapi/qapi-visit-misc.o
CC qapi/qapi-visit-net.o
CC qapi/qapi-visit-rocker.o
CC qapi/qapi-visit-run-state.o
CC qapi/qapi-visit-sockets.o
CC qapi/qapi-visit-tpm.o
CC qapi/qapi-visit-trace.o
CC qapi/qapi-visit-transaction.o
CC qapi/qapi-visit-ui.o
CC qapi/qapi-events.o
CC qapi/qapi-events-block-core.o
CC qapi/qapi-events-block.o
CC qapi/qapi-events-char.o
CC qapi/qapi-events-common.o
CC qapi/qapi-events-crypto.o
CC qapi/qapi-events-migration.o
CC qapi/qapi-events-introspect.o
CC qapi/qapi-events-misc.o
CC qapi/qapi-events-net.o
CC qapi/qapi-events-rocker.o
CC qapi/qapi-events-run-state.o
CC qapi/qapi-events-sockets.o
CC qapi/qapi-events-tpm.o
CC qapi/qapi-events-trace.o
CC qapi/qapi-events-transaction.o
CC qapi/qapi-events-ui.o
CC qapi/qapi-introspect.o
CC qapi/qapi-visit-core.o
CC qapi/qapi-dealloc-visitor.o
CC qapi/qobject-input-visitor.o
CC qapi/qobject-output-visitor.o
CC qapi/qmp-registry.o
CC qapi/qmp-dispatch.o
CC qapi/string-input-visitor.o
CC qapi/string-output-visitor.o
CC qapi/opts-visitor.o
CC qapi/qapi-clone-visitor.o
CC qapi/qmp-event.o
CC qapi/qapi-util.o
CC qobject/qnull.o
CC qobject/qnum.o
CC qobject/qstring.o
CC qobject/qdict.o
CC qobject/qlist.o
CC qobject/qbool.o
CC qobject/qlit.o
CC qobject/qjson.o
CC qobject/qobject.o
In file included from /tmp/qemu-test/src/qapi/qapi-visit-core.c:21:0:
/tmp/qemu-test/build/qapi/trace.h:7:10: fatal error: trace/control.h: No such file or directory
#include "trace/control.h"
^~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [/tmp/qemu-test/src/rules.mak:66: qapi/qapi-visit-core.o] Error 1
make: *** Waiting for unfinished jobs....
Traceback (most recent call last):
File "./tests/docker/docker.py", line 407, in <module>
sys.exit(main())
File "./tests/docker/docker.py", line 404, in main
return args.cmdobj.run(args, argv)
File "./tests/docker/docker.py", line 261, in run
return Docker().run(argv, args.keep, quiet=args.quiet)
File "./tests/docker/docker.py", line 229, in run
quiet=quiet)
File "./tests/docker/docker.py", line 147, in _do_check
return subprocess.check_call(self._command + cmd, **kwargs)
File "/usr/lib64/python2.7/subprocess.py", line 186, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['docker', 'run', '--label', 'com.qemu.instance.uuid=c9fbacd64f1411e8bae552540069c830', '-u', '0', '--security-opt', 'seccomp=unconfined', '--rm', '--net=none', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=8', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/root/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-vhw2wwer/src/docker-src.2018-05-03-16.58.41.25302:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit status 2
make[1]: *** [tests/docker/Makefile.include:129: docker-run] Error 1
make[1]: Leaving directory '/var/tmp/patchew-tester-tmp-vhw2wwer/src'
make: *** [tests/docker/Makefile.include:163: docker-run-test-mingw@fedora] Error 2
real 1m39.599s
user 0m4.664s
sys 0m3.752s
=== OUTPUT END ===
Test command exited with code: 2
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 00/67] include path cleanup
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (69 preceding siblings ...)
2018-05-03 21:00 ` no-reply
@ 2018-05-03 21:01 ` no-reply
2018-05-09 10:39 ` Paolo Bonzini
71 siblings, 0 replies; 144+ messages in thread
From: no-reply @ 2018-05-03 21:01 UTC (permalink / raw)
To: mst; +Cc: famz, qemu-devel, kwolf, peter.maydell
Hi,
This series failed docker-build@min-glib build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 1525376963-79623-1-git-send-email-mst@redhat.com
Subject: [Qemu-devel] [PATCH 00/67] include path cleanup
=== TEST SCRIPT BEGIN ===
#!/bin/bash
set -e
git submodule update --init dtc
# Let docker tests dump environment info
export SHOW_ENV=1
export J=8
time make docker-test-build@min-glib
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
dda9647d70 make: simplify source include path
b158a719f3 linux-user: add include directory header
b2ae9844c1 tcg: use include "translate-all.h" consistently
3613ec1453 target/s390x: add include directory header
d00910afb1 hw/s390x: use target headers explicitly
194f6f9974 kvm: use include "kvm_ppc.h" consistently
256581c1be hw/net: add include directory header
440e14b88a hw/s390x: add include directory headers
84a81cbde5 hw/ppc: add target headers explicitly
87bebef613 target/riscv: add include directory header
d02cccc221 kvm: use include "kvm_i386.h" consistently
f9543ea9d8 tcg: use include "tcg-gvec-desc.h.h" consistently
52a7685f6f amd_iommu: add include directory header
18b966a8fe amd_iommu: add include directory header
1f841bece5 target/ppc: add include directory headers
3d6945bd6b target/arm: add include directory headers
863bb03c5a hyperv: add include directory header
1011069886 hmp: add include directory header
5f1be83b0f kvm_XXX: add include directory headers
a4f45a0012 virtio-pci: add include directory header
8e2f2e471e tcg-op: use include "tcg.h" consistently
d9c41e578e cpu-qom: add include directory headers
ce17c41200 tcg: add include directory headers
1690189b5e tcg-ldst.inc.c: replace command line flags with preprocessor
5143bc145e translate-all: add include directory header
cd074d2b2c tcg: use include "tcg.h" consistently
3418bf3073 tcg-pool.inc.c: replace command line flags with preprocessor
653e93fefe trace: add include directory headers
76e207bfb1 target: replace command line flags with preprocessor
81d9592c44 helper: replace command line flags with preprocessor
287a3a85aa tcg: add include directory headers
0912dbb70e migration: add include directory headers
e234a2f0a3 hw/usb: add include directory header
0855ad7432 hw/ppc: add include directory headers
bff5bf26d6 hw/net: add include directory header
523897142f ui: add include directory header
a86a80bd28 target/cris: add include directory header
bc35b6c9a9 audio: add include directory header
c5c49795ca fsdev: add include directory headers
2184da2487 9pfs: add include directory headers
cebd0e6d5d replication: add include directory header
7fd6a43e9c cpu: replace command line flags with preprocessor
8d5900280a arch_init: sort architectures
5f3be2f16f net: add include directory headers
26e688947b slirp: add include directory headers
677b5a5222 ui: use local path for local headers
a2e9d7b6d0 trace: use local path for local headers
ab8e11dbb1 tests: relative include for child directory
2505961862 xtensa: relative include for parent directory
0561f465a9 qga: use local path for local headers
f02e149685 colo: use local path for local headers
f63ff1c1e5 migration: use local path for local headers
0e2942e37a usb: use local path for local headers
a17070acf1 sd: fix up include
804ef03fb9 vhost-scsi: drop an unused include
eded79b7c5 ppc: use local path for local headers
e352ed36c5 rocker: drop an unused include
303a3d4072 e1000e: use local path for local headers
4df0916e5c ioapic: fix up includes
4f533ce25a ide: use local path for local headers
3ad03c679d display: use local path for local headers
e56cb2ab7c trace: use local path for local headers
711e6fe8f8 migration: drop an unused include, add a used one
fdbc0e45c0 s390x: drop an unused include
abd9bbe5ea hppa: use local path for local headers
6ce2ed96c7 crypto: use local path for local headers
d5cd88766c block: use local path for local headers
=== OUTPUT BEGIN ===
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into '/var/tmp/patchew-tester-tmp-_xv4drrx/src/dtc'...
Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42'
BUILD min-glib
make[1]: Entering directory '/var/tmp/patchew-tester-tmp-_xv4drrx/src'
GEN /var/tmp/patchew-tester-tmp-_xv4drrx/src/docker-src.2018-05-03-17.00.43.29958/qemu.tar
Cloning into '/var/tmp/patchew-tester-tmp-_xv4drrx/src/docker-src.2018-05-03-17.00.43.29958/qemu.tar.vroot'...
done.
Checking out files: 46% (2878/6190)
Checking out files: 47% (2910/6190)
Checking out files: 48% (2972/6190)
Checking out files: 49% (3034/6190)
Checking out files: 50% (3095/6190)
Checking out files: 51% (3157/6190)
Checking out files: 52% (3219/6190)
Checking out files: 53% (3281/6190)
Checking out files: 54% (3343/6190)
Checking out files: 55% (3405/6190)
Checking out files: 56% (3467/6190)
Checking out files: 57% (3529/6190)
Checking out files: 58% (3591/6190)
Checking out files: 59% (3653/6190)
Checking out files: 60% (3714/6190)
Checking out files: 61% (3776/6190)
Checking out files: 62% (3838/6190)
Checking out files: 63% (3900/6190)
Checking out files: 64% (3962/6190)
Checking out files: 65% (4024/6190)
Checking out files: 66% (4086/6190)
Checking out files: 67% (4148/6190)
Checking out files: 68% (4210/6190)
Checking out files: 69% (4272/6190)
Checking out files: 70% (4333/6190)
Checking out files: 71% (4395/6190)
Checking out files: 72% (4457/6190)
Checking out files: 73% (4519/6190)
Checking out files: 74% (4581/6190)
Checking out files: 75% (4643/6190)
Checking out files: 76% (4705/6190)
Checking out files: 77% (4767/6190)
Checking out files: 78% (4829/6190)
Checking out files: 79% (4891/6190)
Checking out files: 80% (4952/6190)
Checking out files: 81% (5014/6190)
Checking out files: 82% (5076/6190)
Checking out files: 83% (5138/6190)
Checking out files: 84% (5200/6190)
Checking out files: 85% (5262/6190)
Checking out files: 86% (5324/6190)
Checking out files: 87% (5386/6190)
Checking out files: 88% (5448/6190)
Checking out files: 89% (5510/6190)
Checking out files: 90% (5571/6190)
Checking out files: 91% (5633/6190)
Checking out files: 92% (5695/6190)
Checking out files: 93% (5757/6190)
Checking out files: 94% (5819/6190)
Checking out files: 95% (5881/6190)
Checking out files: 96% (5943/6190)
Checking out files: 97% (6005/6190)
Checking out files: 98% (6067/6190)
Checking out files: 99% (6129/6190)
Checking out files: 100% (6190/6190)
Checking out files: 100% (6190/6190), done.
Your branch is up-to-date with 'origin/test'.
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into '/var/tmp/patchew-tester-tmp-_xv4drrx/src/docker-src.2018-05-03-17.00.43.29958/qemu.tar.vroot/dtc'...
Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42'
Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into '/var/tmp/patchew-tester-tmp-_xv4drrx/src/docker-src.2018-05-03-17.00.43.29958/qemu.tar.vroot/ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
COPY RUNNER
RUN test-build in qemu:min-glib
Environment variables:
HOSTNAME=d850dd24133f
MAKEFLAGS= -j8
J=8
CCACHE_DIR=/var/tmp/ccache
EXTRA_CONFIGURE_OPTS=
V=
SHOW_ENV=1
PATH=/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
PWD=/
TARGET_LIST=
SHLVL=1
HOME=/root
TEST_DIR=/tmp/qemu-test
FEATURES= dtc
DEBUG=
_=/usr/bin/env
Configure options:
--enable-werror --target-list=x86_64-softmmu,aarch64-softmmu --prefix=/tmp/qemu-test/install
No C++ compiler available; disabling C++ specific optional code
Install prefix /tmp/qemu-test/install
BIOS directory /tmp/qemu-test/install/share/qemu
firmware path /tmp/qemu-test/install/share/qemu-firmware
binary directory /tmp/qemu-test/install/bin
library directory /tmp/qemu-test/install/lib
module directory /tmp/qemu-test/install/lib/qemu
libexec directory /tmp/qemu-test/install/libexec
include directory /tmp/qemu-test/install/include
config directory /tmp/qemu-test/install/etc
local state directory /tmp/qemu-test/install/var
Manual directory /tmp/qemu-test/install/share/man
ELF interp prefix /usr/gnemul/qemu-%M
Source path /tmp/qemu-test/src
GIT binary git
GIT submodules
C compiler cc
Host C compiler cc
C++ compiler
Objective-C compiler cc
ARFLAGS rv
CFLAGS -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g
QEMU_CFLAGS -I/usr/include/pixman-1 -I$(SRC_PATH)/dtc/libfdt -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-all -Wno-missing-braces
LDFLAGS -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -pie -m64 -g
make make
install install
python python -B
smbd /usr/sbin/smbd
module support no
host CPU x86_64
host big endian no
target list x86_64-softmmu aarch64-softmmu
gprof enabled no
sparse enabled no
strip binaries yes
profiler no
static build no
SDL support yes (1.2.14)
GTK support no
GTK GL support no
VTE support no
TLS priority NORMAL
GNUTLS support no
GNUTLS rnd no
libgcrypt no
libgcrypt kdf no
nettle no
nettle kdf no
libtasn1 no
curses support no
virgl support no
curl support no
mingw32 support no
Audio drivers oss
Block whitelist (rw)
Block whitelist (ro)
VirtFS support no
Multipath support no
VNC support yes
VNC SASL support no
VNC JPEG support no
VNC PNG support no
xen support no
brlapi support no
bluez support no
Documentation no
PIE yes
vde support no
netmap support no
Linux AIO support no
ATTR/XATTR support yes
Install blobs yes
KVM support yes
HAX support no
HVF support no
WHPX support no
TCG support yes
TCG debug enabled no
TCG interpreter no
malloc trim support yes
RDMA support no
fdt support yes
membarrier no
preadv support yes
fdatasync yes
madvise yes
posix_madvise yes
posix_memalign yes
libcap-ng support no
vhost-net support yes
vhost-crypto support yes
vhost-scsi support yes
vhost-vsock support yes
vhost-user support yes
Trace backends log
spice support no
rbd support no
xfsctl support no
smartcard support no
libusb no
usb net redir no
OpenGL support no
OpenGL dmabufs no
libiscsi support no
libnfs support no
build guest agent yes
QGA VSS support no
QGA w32 disk info no
QGA MSI support no
seccomp support no
coroutine backend ucontext
coroutine pool yes
debug stack usage no
crypto afalg no
GlusterFS support no
gcov gcov
gcov enabled no
TPM support yes
libssh2 support no
TPM passthrough yes
TPM emulator yes
QOM debugging yes
Live block migration yes
lzo support no
snappy support no
bzip2 support no
NUMA host support no
libxml2 no
tcmalloc support no
jemalloc support no
avx2 optimization no
replication support yes
VxHS block device no
capstone no
WARNING: Use of SDL 1.2 is deprecated and will be removed in
WARNING: future releases. Please switch to using SDL 2.0
mkdir -p dtc/libfdt
GEN x86_64-softmmu/config-devices.mak.tmp
mkdir -p dtc/tests
GEN aarch64-softmmu/config-devices.mak.tmp
GEN config-host.h
GEN qemu-options.def
GEN qapi-gen
GEN trace/generated-tcg-tracers.h
GEN trace/generated-helpers.h
GEN trace/generated-helpers-wrappers.h
GEN x86_64-softmmu/config-devices.mak
GEN aarch64-softmmu/config-devices.mak
GEN trace/generated-helpers.c
GEN module_block.h
GEN ui/input-keymap-atset1-to-qcode.c
GEN ui/input-keymap-linux-to-qcode.c
GEN ui/input-keymap-qcode-to-atset1.c
GEN ui/input-keymap-qcode-to-atset3.c
GEN ui/input-keymap-qcode-to-atset2.c
GEN ui/input-keymap-qcode-to-linux.c
GEN ui/input-keymap-qcode-to-qnum.c
GEN ui/input-keymap-qcode-to-sun.c
GEN ui/input-keymap-qnum-to-qcode.c
GEN ui/input-keymap-usb-to-qcode.c
GEN ui/input-keymap-x11-to-qcode.c
GEN ui/input-keymap-win32-to-qcode.c
GEN ui/input-keymap-xorgevdev-to-qcode.c
GEN ui/input-keymap-xorgkbd-to-qcode.c
GEN ui/input-keymap-xorgxquartz-to-qcode.c
GEN ui/input-keymap-xorgxwin-to-qcode.c
GEN tests/test-qapi-gen
GEN trace-root.h
GEN util/trace.h
GEN crypto/trace.h
GEN io/trace.h
GEN migration/trace.h
GEN block/trace.h
GEN chardev/trace.h
GEN hw/block/trace.h
GEN hw/block/dataplane/trace.h
GEN hw/char/trace.h
GEN hw/intc/trace.h
GEN hw/net/trace.h
GEN hw/rdma/trace.h
GEN hw/rdma/vmw/trace.h
GEN hw/virtio/trace.h
GEN hw/audio/trace.h
GEN hw/misc/trace.h
GEN hw/misc/macio/trace.h
GEN hw/usb/trace.h
GEN hw/scsi/trace.h
GEN hw/nvram/trace.h
GEN hw/display/trace.h
GEN hw/input/trace.h
GEN hw/timer/trace.h
GEN hw/dma/trace.h
GEN hw/sparc/trace.h
GEN hw/sparc64/trace.h
GEN hw/sd/trace.h
GEN hw/isa/trace.h
GEN hw/mem/trace.h
GEN hw/i386/trace.h
GEN hw/i386/xen/trace.h
GEN hw/9pfs/trace.h
GEN hw/ppc/trace.h
GEN hw/pci/trace.h
GEN hw/pci-host/trace.h
GEN hw/s390x/trace.h
GEN hw/vfio/trace.h
GEN hw/acpi/trace.h
GEN hw/arm/trace.h
GEN hw/alpha/trace.h
GEN hw/hppa/trace.h
GEN hw/xen/trace.h
GEN hw/ide/trace.h
GEN hw/tpm/trace.h
GEN ui/trace.h
GEN audio/trace.h
GEN net/trace.h
GEN target/arm/trace.h
GEN target/i386/trace.h
GEN target/mips/trace.h
GEN target/sparc/trace.h
GEN target/s390x/trace.h
GEN target/ppc/trace.h
GEN qom/trace.h
GEN linux-user/trace.h
GEN qapi/trace.h
GEN accel/tcg/trace.h
GEN accel/kvm/trace.h
GEN nbd/trace.h
GEN scsi/trace.h
GEN trace-root.c
GEN util/trace.c
GEN crypto/trace.c
GEN io/trace.c
GEN migration/trace.c
GEN block/trace.c
GEN chardev/trace.c
GEN hw/block/trace.c
GEN hw/block/dataplane/trace.c
GEN hw/char/trace.c
GEN hw/intc/trace.c
GEN hw/net/trace.c
GEN hw/rdma/trace.c
GEN hw/rdma/vmw/trace.c
GEN hw/virtio/trace.c
GEN hw/audio/trace.c
GEN hw/misc/trace.c
GEN hw/misc/macio/trace.c
GEN hw/usb/trace.c
GEN hw/scsi/trace.c
GEN hw/nvram/trace.c
GEN hw/display/trace.c
GEN hw/input/trace.c
GEN hw/timer/trace.c
GEN hw/dma/trace.c
GEN hw/sparc/trace.c
GEN hw/sparc64/trace.c
GEN hw/sd/trace.c
GEN hw/isa/trace.c
GEN hw/mem/trace.c
GEN hw/i386/trace.c
GEN hw/i386/xen/trace.c
GEN hw/9pfs/trace.c
GEN hw/ppc/trace.c
GEN hw/pci/trace.c
GEN hw/pci-host/trace.c
GEN hw/s390x/trace.c
GEN hw/vfio/trace.c
GEN hw/acpi/trace.c
GEN hw/arm/trace.c
GEN hw/alpha/trace.c
GEN hw/hppa/trace.c
GEN hw/xen/trace.c
GEN hw/ide/trace.c
GEN hw/tpm/trace.c
GEN ui/trace.c
GEN audio/trace.c
GEN net/trace.c
GEN target/arm/trace.c
GEN target/i386/trace.c
GEN target/mips/trace.c
GEN target/sparc/trace.c
GEN target/s390x/trace.c
GEN target/ppc/trace.c
GEN qom/trace.c
GEN linux-user/trace.c
GEN qapi/trace.c
GEN accel/tcg/trace.c
GEN accel/kvm/trace.c
GEN nbd/trace.c
GEN scsi/trace.c
GEN config-all-devices.mak
DEP /tmp/qemu-test/src/dtc/tests/dumptrees.c
DEP /tmp/qemu-test/src/dtc/tests/trees.S
DEP /tmp/qemu-test/src/dtc/tests/testutils.c
DEP /tmp/qemu-test/src/dtc/tests/value-labels.c
DEP /tmp/qemu-test/src/dtc/tests/asm_tree_dump.c
DEP /tmp/qemu-test/src/dtc/tests/truncated_property.c
DEP /tmp/qemu-test/src/dtc/tests/check_path.c
DEP /tmp/qemu-test/src/dtc/tests/overlay_bad_fixup.c
DEP /tmp/qemu-test/src/dtc/tests/overlay.c
DEP /tmp/qemu-test/src/dtc/tests/subnode_iterate.c
DEP /tmp/qemu-test/src/dtc/tests/property_iterate.c
DEP /tmp/qemu-test/src/dtc/tests/integer-expressions.c
DEP /tmp/qemu-test/src/dtc/tests/utilfdt_test.c
DEP /tmp/qemu-test/src/dtc/tests/path_offset_aliases.c
DEP /tmp/qemu-test/src/dtc/tests/add_subnode_with_nops.c
DEP /tmp/qemu-test/src/dtc/tests/dtbs_equal_unordered.c
DEP /tmp/qemu-test/src/dtc/tests/dtb_reverse.c
DEP /tmp/qemu-test/src/dtc/tests/dtbs_equal_ordered.c
DEP /tmp/qemu-test/src/dtc/tests/extra-terminating-null.c
DEP /tmp/qemu-test/src/dtc/tests/incbin.c
DEP /tmp/qemu-test/src/dtc/tests/boot-cpuid.c
DEP /tmp/qemu-test/src/dtc/tests/phandle_format.c
DEP /tmp/qemu-test/src/dtc/tests/path-references.c
DEP /tmp/qemu-test/src/dtc/tests/references.c
DEP /tmp/qemu-test/src/dtc/tests/string_escapes.c
DEP /tmp/qemu-test/src/dtc/tests/propname_escapes.c
DEP /tmp/qemu-test/src/dtc/tests/appendprop2.c
DEP /tmp/qemu-test/src/dtc/tests/appendprop1.c
DEP /tmp/qemu-test/src/dtc/tests/del_node.c
DEP /tmp/qemu-test/src/dtc/tests/del_property.c
DEP /tmp/qemu-test/src/dtc/tests/setprop.c
DEP /tmp/qemu-test/src/dtc/tests/set_name.c
DEP /tmp/qemu-test/src/dtc/tests/rw_tree1.c
DEP /tmp/qemu-test/src/dtc/tests/nopulate.c
DEP /tmp/qemu-test/src/dtc/tests/open_pack.c
DEP /tmp/qemu-test/src/dtc/tests/mangle-layout.c
DEP /tmp/qemu-test/src/dtc/tests/move_and_save.c
DEP /tmp/qemu-test/src/dtc/tests/sw_tree1.c
DEP /tmp/qemu-test/src/dtc/tests/nop_node.c
DEP /tmp/qemu-test/src/dtc/tests/nop_property.c
DEP /tmp/qemu-test/src/dtc/tests/setprop_inplace.c
DEP /tmp/qemu-test/src/dtc/tests/stringlist.c
DEP /tmp/qemu-test/src/dtc/tests/addr_size_cells.c
DEP /tmp/qemu-test/src/dtc/tests/notfound.c
DEP /tmp/qemu-test/src/dtc/tests/sized_cells.c
DEP /tmp/qemu-test/src/dtc/tests/char_literal.c
DEP /tmp/qemu-test/src/dtc/tests/get_alias.c
DEP /tmp/qemu-test/src/dtc/tests/node_offset_by_compatible.c
DEP /tmp/qemu-test/src/dtc/tests/node_check_compatible.c
DEP /tmp/qemu-test/src/dtc/tests/node_offset_by_phandle.c
DEP /tmp/qemu-test/src/dtc/tests/node_offset_by_prop_value.c
DEP /tmp/qemu-test/src/dtc/tests/parent_offset.c
DEP /tmp/qemu-test/src/dtc/tests/get_path.c
DEP /tmp/qemu-test/src/dtc/tests/supernode_atdepth_offset.c
DEP /tmp/qemu-test/src/dtc/tests/get_phandle.c
DEP /tmp/qemu-test/src/dtc/tests/getprop.c
DEP /tmp/qemu-test/src/dtc/tests/get_name.c
DEP /tmp/qemu-test/src/dtc/tests/path_offset.c
DEP /tmp/qemu-test/src/dtc/tests/subnode_offset.c
DEP /tmp/qemu-test/src/dtc/tests/find_property.c
DEP /tmp/qemu-test/src/dtc/tests/root_node.c
DEP /tmp/qemu-test/src/dtc/tests/get_mem_rsv.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_overlay.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_addresses.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_empty_tree.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_strerror.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_rw.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_wip.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_ro.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt_sw.c
DEP /tmp/qemu-test/src/dtc/libfdt/fdt.c
DEP /tmp/qemu-test/src/dtc/util.c
DEP /tmp/qemu-test/src/dtc/fdtoverlay.c
DEP /tmp/qemu-test/src/dtc/fdtput.c
DEP /tmp/qemu-test/src/dtc/fdtget.c
DEP /tmp/qemu-test/src/dtc/fdtdump.c
LEX convert-dtsv0-lexer.lex.c
make[1]: flex: Command not found
DEP /tmp/qemu-test/src/dtc/srcpos.c
BISON dtc-parser.tab.c
LEX dtc-lexer.lex.c
make[1]: bison: Command not found
make[1]: flex: Command not found
DEP /tmp/qemu-test/src/dtc/treesource.c
DEP /tmp/qemu-test/src/dtc/livetree.c
DEP /tmp/qemu-test/src/dtc/fstree.c
DEP /tmp/qemu-test/src/dtc/flattree.c
DEP /tmp/qemu-test/src/dtc/dtc.c
DEP /tmp/qemu-test/src/dtc/data.c
DEP /tmp/qemu-test/src/dtc/checks.c
CHK version_gen.h
LEX convert-dtsv0-lexer.lex.c
BISON dtc-parser.tab.c
make[1]: flex: Command not found
make[1]: bison: Command not found
UPD version_gen.h
LEX dtc-lexer.lex.c
make[1]: flex: Command not found
DEP /tmp/qemu-test/src/dtc/util.c
LEX convert-dtsv0-lexer.lex.c
BISON dtc-parser.tab.c
make[1]: flex: Command not found
make[1]: bison: Command not found
LEX dtc-lexer.lex.c
make[1]: flex: Command not found
CC libfdt/fdt.o
CC libfdt/fdt_ro.o
CC libfdt/fdt_wip.o
CC libfdt/fdt_rw.o
CC libfdt/fdt_sw.o
CC libfdt/fdt_empty_tree.o
CC libfdt/fdt_addresses.o
CC libfdt/fdt_strerror.o
CC libfdt/fdt_overlay.o
AR libfdt/libfdt.a
ar: creating libfdt/libfdt.a
a - libfdt/fdt.o
a - libfdt/fdt_ro.o
a - libfdt/fdt_wip.o
a - libfdt/fdt_sw.o
a - libfdt/fdt_rw.o
a - libfdt/fdt_strerror.o
a - libfdt/fdt_empty_tree.o
a - libfdt/fdt_addresses.o
a - libfdt/fdt_overlay.o
mkdir -p dtc/libfdt
mkdir -p dtc/tests
LEX convert-dtsv0-lexer.lex.c
make[1]: flex: Command not found
LEX dtc-lexer.lex.c
BISON dtc-parser.tab.c
make[1]: flex: Command not found
make[1]: bison: Command not found
CC tests/qemu-iotests/socket_scm_helper.o
GEN qga/qapi-generated/qapi-gen
CC qapi/qapi-builtin-types.o
CC qapi/qapi-types.o
CC qapi/qapi-types-char.o
CC qapi/qapi-types-block.o
CC qapi/qapi-types-common.o
CC qapi/qapi-types-block-core.o
CC qapi/qapi-types-crypto.o
CC qapi/qapi-types-introspect.o
CC qapi/qapi-types-migration.o
CC qapi/qapi-types-misc.o
CC qapi/qapi-types-net.o
CC qapi/qapi-types-rocker.o
CC qapi/qapi-types-run-state.o
CC qapi/qapi-types-sockets.o
CC qapi/qapi-types-tpm.o
CC qapi/qapi-types-trace.o
CC qapi/qapi-types-transaction.o
CC qapi/qapi-types-ui.o
CC qapi/qapi-builtin-visit.o
CC qapi/qapi-visit.o
CC qapi/qapi-visit-block-core.o
CC qapi/qapi-visit-block.o
CC qapi/qapi-visit-char.o
CC qapi/qapi-visit-common.o
CC qapi/qapi-visit-crypto.o
CC qapi/qapi-visit-introspect.o
CC qapi/qapi-visit-misc.o
CC qapi/qapi-visit-net.o
CC qapi/qapi-visit-migration.o
CC qapi/qapi-visit-rocker.o
CC qapi/qapi-visit-run-state.o
CC qapi/qapi-visit-sockets.o
CC qapi/qapi-visit-tpm.o
CC qapi/qapi-visit-trace.o
CC qapi/qapi-visit-transaction.o
CC qapi/qapi-visit-ui.o
CC qapi/qapi-events.o
CC qapi/qapi-events-block-core.o
CC qapi/qapi-events-block.o
CC qapi/qapi-events-char.o
CC qapi/qapi-events-common.o
CC qapi/qapi-events-crypto.o
CC qapi/qapi-events-introspect.o
CC qapi/qapi-events-migration.o
CC qapi/qapi-events-misc.o
CC qapi/qapi-events-net.o
CC qapi/qapi-events-rocker.o
CC qapi/qapi-events-run-state.o
CC qapi/qapi-events-sockets.o
CC qapi/qapi-events-tpm.o
CC qapi/qapi-events-trace.o
CC qapi/qapi-events-transaction.o
CC qapi/qapi-events-ui.o
CC qapi/qapi-visit-core.o
CC qapi/qapi-introspect.o
CC qapi/qapi-dealloc-visitor.o
CC qapi/qobject-input-visitor.o
In file included from /tmp/qemu-test/src/qapi/qapi-visit-core.c:21:
/tmp/qemu-test/build/qapi/trace.h:7:27: error: trace/control.h: No such file or directory
In file included from /tmp/qemu-test/src/qapi/qapi-visit-core.c:21:
/tmp/qemu-test/build/qapi/trace.h:9: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_FREE_EVENT'
/tmp/qemu-test/build/qapi/trace.h:10: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_COMPLETE_EVENT'
/tmp/qemu-test/build/qapi/trace.h:11: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_START_STRUCT_EVENT'
/tmp/qemu-test/build/qapi/trace.h:12: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_CHECK_STRUCT_EVENT'
/tmp/qemu-test/build/qapi/trace.h:13: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_END_STRUCT_EVENT'
/tmp/qemu-test/build/qapi/trace.h:14: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_START_LIST_EVENT'
/tmp/qemu-test/build/qapi/trace.h:15: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_NEXT_LIST_EVENT'
/tmp/qemu-test/build/qapi/trace.h:16: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_CHECK_LIST_EVENT'
/tmp/qemu-test/build/qapi/trace.h:17: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_END_LIST_EVENT'
/tmp/qemu-test/build/qapi/trace.h:18: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_START_ALTERNATE_EVENT'
/tmp/qemu-test/build/qapi/trace.h:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_END_ALTERNATE_EVENT'
/tmp/qemu-test/build/qapi/trace.h:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_OPTIONAL_EVENT'
/tmp/qemu-test/build/qapi/trace.h:21: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_ENUM_EVENT'
/tmp/qemu-test/build/qapi/trace.h:22: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_INT_EVENT'
/tmp/qemu-test/build/qapi/trace.h:23: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_UINT8_EVENT'
/tmp/qemu-test/build/qapi/trace.h:24: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_UINT16_EVENT'
/tmp/qemu-test/build/qapi/trace.h:25: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_UINT32_EVENT'
/tmp/qemu-test/build/qapi/trace.h:26: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_UINT64_EVENT'
/tmp/qemu-test/build/qapi/trace.h:27: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_INT8_EVENT'
/tmp/qemu-test/build/qapi/trace.h:28: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_INT16_EVENT'
/tmp/qemu-test/build/qapi/trace.h:29: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_INT32_EVENT'
/tmp/qemu-test/build/qapi/trace.h:30: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_INT64_EVENT'
/tmp/qemu-test/build/qapi/trace.h:31: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_SIZE_EVENT'
/tmp/qemu-test/build/qapi/trace.h:32: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_BOOL_EVENT'
/tmp/qemu-test/build/qapi/trace.h:33: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_STR_EVENT'
/tmp/qemu-test/build/qapi/trace.h:34: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_NUMBER_EVENT'
/tmp/qemu-test/build/qapi/trace.h:35: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_ANY_EVENT'
/tmp/qemu-test/build/qapi/trace.h:36: error: expected '=', ',', ';', 'asm' or '__attribute__' before '_TRACE_VISIT_TYPE_NULL_EVENT'
In file included from /tmp/qemu-test/src/qapi/qapi-visit-core.c:21:
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_free':
/tmp/qemu-test/build/qapi/trace.h:102: warning: implicit declaration of function 'trace_event_get_state'
/tmp/qemu-test/build/qapi/trace.h:102: warning: nested extern declaration of 'trace_event_get_state'
/tmp/qemu-test/build/qapi/trace.h:102: error: 'TRACE_VISIT_FREE' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h:102: error: (Each undeclared identifier is reported only once
/tmp/qemu-test/build/qapi/trace.h:102: error: for each function it appears in.)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_complete':
/tmp/qemu-test/build/qapi/trace.h:125: error: 'TRACE_VISIT_COMPLETE' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_start_struct':
/tmp/qemu-test/build/qapi/trace.h:148: error: 'TRACE_VISIT_START_STRUCT' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_check_struct':
/tmp/qemu-test/build/qapi/trace.h:171: error: 'TRACE_VISIT_CHECK_STRUCT' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_end_struct':
/tmp/qemu-test/build/qapi/trace.h:194: error: 'TRACE_VISIT_END_STRUCT' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_start_list':
/tmp/qemu-test/build/qapi/trace.h:217: error: 'TRACE_VISIT_START_LIST' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_next_list':
/tmp/qemu-test/build/qapi/trace.h:240: error: 'TRACE_VISIT_NEXT_LIST' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_check_list':
/tmp/qemu-test/build/qapi/trace.h:263: error: 'TRACE_VISIT_CHECK_LIST' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_end_list':
/tmp/qemu-test/build/qapi/trace.h:286: error: 'TRACE_VISIT_END_LIST' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_start_alternate':
/tmp/qemu-test/build/qapi/trace.h:309: error: 'TRACE_VISIT_START_ALTERNATE' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_end_alternate':
/tmp/qemu-test/build/qapi/trace.h:332: error: 'TRACE_VISIT_END_ALTERNATE' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_optional':
/tmp/qemu-test/build/qapi/trace.h:355: error: 'TRACE_VISIT_OPTIONAL' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_enum':
/tmp/qemu-test/build/qapi/trace.h:378: error: 'TRACE_VISIT_TYPE_ENUM' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_int':
/tmp/qemu-test/build/qapi/trace.h:401: error: 'TRACE_VISIT_TYPE_INT' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_uint8':
/tmp/qemu-test/build/qapi/trace.h:424: error: 'TRACE_VISIT_TYPE_UINT8' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_uint16':
/tmp/qemu-test/build/qapi/trace.h:447: error: 'TRACE_VISIT_TYPE_UINT16' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_uint32':
/tmp/qemu-test/build/qapi/trace.h:470: error: 'TRACE_VISIT_TYPE_UINT32' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_uint64':
/tmp/qemu-test/build/qapi/trace.h:493: error: 'TRACE_VISIT_TYPE_UINT64' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_int8':
/tmp/qemu-test/build/qapi/trace.h:516: error: 'TRACE_VISIT_TYPE_INT8' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_int16':
/tmp/qemu-test/build/qapi/trace.h:539: error: 'TRACE_VISIT_TYPE_INT16' undeclared (first use in this function)
CC qapi/qobject-output-visitor.o
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_int32':
/tmp/qemu-test/build/qapi/trace.h:562: error: 'TRACE_VISIT_TYPE_INT32' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_int64':
/tmp/qemu-test/build/qapi/trace.h:585: error: 'TRACE_VISIT_TYPE_INT64' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_size':
/tmp/qemu-test/build/qapi/trace.h:608: error: 'TRACE_VISIT_TYPE_SIZE' undeclared (first use in this function)
CC qapi/qmp-registry.o
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_bool':
/tmp/qemu-test/build/qapi/trace.h:631: error: 'TRACE_VISIT_TYPE_BOOL' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_str':
/tmp/qemu-test/build/qapi/trace.h:654: error: 'TRACE_VISIT_TYPE_STR' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_number':
/tmp/qemu-test/build/qapi/trace.h:677: error: 'TRACE_VISIT_TYPE_NUMBER' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_any':
/tmp/qemu-test/build/qapi/trace.h:700: error: 'TRACE_VISIT_TYPE_ANY' undeclared (first use in this function)
/tmp/qemu-test/build/qapi/trace.h: In function '_nocheck__trace_visit_type_null':
/tmp/qemu-test/build/qapi/trace.h:723: error: 'TRACE_VISIT_TYPE_NULL' undeclared (first use in this function)
CC qapi/qmp-dispatch.o
CC qapi/string-input-visitor.o
make: *** [qapi/qapi-visit-core.o] Error 1
make: *** Waiting for unfinished jobs....
Traceback (most recent call last):
File "./tests/docker/docker.py", line 407, in <module>
sys.exit(main())
File "./tests/docker/docker.py", line 404, in main
return args.cmdobj.run(args, argv)
File "./tests/docker/docker.py", line 261, in run
return Docker().run(argv, args.keep, quiet=args.quiet)
File "./tests/docker/docker.py", line 229, in run
quiet=quiet)
File "./tests/docker/docker.py", line 147, in _do_check
return subprocess.check_call(self._command + cmd, **kwargs)
File "/usr/lib64/python2.7/subprocess.py", line 186, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['docker', 'run', '--label', 'com.qemu.instance.uuid=12733c544f1511e883ef52540069c830', '-u', '0', '--security-opt', 'seccomp=unconfined', '--rm', '--net=none', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=8', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/root/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-_xv4drrx/src/docker-src.2018-05-03-17.00.43.29958:/var/tmp/qemu:z,ro', 'qemu:min-glib', '/var/tmp/qemu/run', 'test-build']' returned non-zero exit status 2
make[1]: *** [tests/docker/Makefile.include:129: docker-run] Error 1
make[1]: Leaving directory '/var/tmp/patchew-tester-tmp-_xv4drrx/src'
make: *** [tests/docker/Makefile.include:163: docker-run-test-build@min-glib] Error 2
real 1m1.906s
user 0m4.393s
sys 0m3.786s
=== OUTPUT END ===
Test command exited with code: 2
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 144+ messages in thread* Re: [Qemu-devel] [PATCH 00/67] include path cleanup
2018-05-03 19:50 [Qemu-devel] [PATCH 00/67] include path cleanup Michael S. Tsirkin
` (70 preceding siblings ...)
2018-05-03 21:01 ` no-reply
@ 2018-05-09 10:39 ` Paolo Bonzini
71 siblings, 0 replies; 144+ messages in thread
From: Paolo Bonzini @ 2018-05-09 10:39 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: kwolf, peter.maydell
On 03/05/2018 21:50, Michael S. Tsirkin wrote:
> At the moment during build we have multiple subdirectories of the source
> tree on the search path for include files. This includes source
> directory itself, tcg and accel/tcg subdirectories, target-specific
> source subdirectory and the include subdirectory.
>
> The result is that there are many ways to include each
> specific file, e.g. for a file in the include directory:
>
> #include "dir/foo.h"
> #include "include/dir/foo.h"
>
> (We actually do both).
>
> OTOH local headers can be included with
> #include "foo.h"
> #include "dir/foo.h"
>
> There are also target-specific headers and they are even
> trickier - e.g. try to guess which file does
> #include "cpu.h"
> pull in? The answer actually depends on which target is built.
>
> It is also quite easy to place an external header outside of
> include/ as nothing will catch this misuse.
>
> In an attempt to simplify this situation, this changes the build to look
> for headers in a single directory under the source tree: include/
> (generated files are still spread around a bit, this is left for another
> patchset - and RFC of that I posted earlier).
>
> This way, one can always find any header under include/
> (and sometimes follow from there to another directory).
>
> A nice side effect of this refactoring is that it makes it easy to
> identify external headers which are not under include/.
Yes, this was always the intended usage.
> I decided not to actually move any headers around -
> instead I created small stub files using include_next
> which pull in the original files.
For the RFC is okay, but I think we should at least see which headers
can just get a home in include/ before applying the series. Perhaps we
can add an include-from-topsrcdir/ directory with the #include_next
directives so that the todo list is clear.
> This way we can move the headers gradually - in particular it is often
> benefitial to split a header up with external parts under include and
> internal ones with the source.
I agree.
> Note that it's already benefitial even in this form, since
> - it's now easy to see there is an external header outside include
> that requires work
> - reader can simply look at the header and immediately know
> where to look for it
>
> Target specific files are pulled in using preprocessor which is still
> tricky but arguably easier to understand than makefile tricks.
Another possibility is to directories like include/target/<XXX>, or
target/<XXX>/include/.
Paolo
^ permalink raw reply [flat|nested] 144+ messages in thread